[xcvrd] Fix swsscommon set port table handle in media_settings parser #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Dahiya <[email protected]>
|
@vdahiya12 please update |
Signed-off-by: Vaibhav Dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of ProducerStateTable for settings kvp, the xcvrd daemon should be just using swsscommon.Table which is what this PR fixes.
Description
The method notify_media_setting was updated to use get_app_set_port_tbl() instead of get_app_port_tbl() for interacting with the application port table. This change modifies the way media settings are published to the application database for a given logical port.
A new table, app_set_port_tbl, was added to the XcvrTableHelper class to support the updated functionality in media_settings_parser.py. The table is initialized in the constructor and used by the get_app_set_port_tbl() method.
The changes include:
Motivation and Context
since ProducerStateTable cannot be used to set key-value pairs in redis, the xcvrd daemon should be just using swsscommon.Table for PORT_TABLE which is what this PR fixes.
How Has This Been Tested?
UT and testing on Arista 7260cx3 testbed
Additional Information (Optional)