This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
feat/enterpriseportal: support DevOnly in list subscriptions #63837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2024
This was referenced Jul 15, 2024
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
5d27309 to
ea1973d
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
cfe43cc to
a22ee20
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
ea1973d to
5061fd6
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
5061fd6 to
aa59edf
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
f7e511c to
0e3f450
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
aa59edf to
8ff52ad
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
0e3f450 to
02210dd
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
8ff52ad to
a52025d
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
02210dd to
173d040
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
a52025d to
10e57d2
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
173d040 to
a80dd1f
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
10e57d2 to
b990a28
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
a80dd1f to
63167e2
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
b990a28 to
3f5c924
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
63167e2 to
988e464
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
3f5c924 to
b732ac4
Compare
jac
approved these changes
Jul 17, 2024
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
988e464 to
e180a53
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
b732ac4 to
00147a6
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
00147a6 to
cf5d11e
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
cc8e759 to
9f0f026
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
cf5d11e to
5e27ca1
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
9f0f026 to
f7ac8de
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
5e27ca1 to
764c767
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
f7ac8de to
c85e1e3
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
764c767 to
5edbbdd
Compare
3 tasks
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
c85e1e3 to
a23cef5
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
5edbbdd to
883f5fb
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
a23cef5 to
3a2cc30
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
883f5fb to
64a0ee8
Compare
bobheadxi
force-pushed
the
07-12-feat_enterpriseportal_implement_subscription_conditions
branch
from
3a2cc30 to
92614a2
Compare
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
64a0ee8 to
b77567d
Compare
Base automatically changed from
07-12-feat_enterpriseportal_implement_subscription_conditions
to
main
July 23, 2024 19:27
bobheadxi
force-pushed
the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
from
b77567d to
c236467
Compare
bobheadxi
deleted the
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
branch
evict
reviewed
Jul 24, 2024
This was referenced Jul 24, 2024
This was referenced Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure prod data does not end up in the dev Enterprise Portal instance once we start syncing. This change adds support for the DevOnly option in ListSubscriptions and strictly enforces it there (i.e. dev subscriptions cannot end up in the prod instance either).
I've tried to minimize the changes elsewhere to reduce the impact of this change for now.
Test plan
Tests