-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoothing models to resolution #78
Comments
@mileslucas , thank you for your offer! I think I had seen feature request like this over at AstroBetter. But before you put in all that effort, how about first, a Jupyter notebook gist of what you already have, and we'll go from there? |
@mileslucas , thank you but after thinking about this for a bit, I think this is better off as a separate tutorial-type documentation rather than being an actual function in this package. As you mentioned, different people might have their own favorite way to convolve a spectrum, hence being a tutorial would provide more flexibility. Furthermore, since you are using Astropy for the convolution kernel, perhaps this is even better using our refactored synphot package, which is an Astropy-affiliated package and uses Astropy models. If you go that route, then such a tutorial would naturally be part of https://github.com/astropy/astropy-tutorials . |
I have an idea for implementing a method for SourceSpectrum objects to smooth them to a given resolution. I have some working code that convolves gaussian kernels to the spectrum in logspace. I was curious if there is merit in putting the effort into creating a nice pull request with documentation and tests.
The text was updated successfully, but these errors were encountered: