Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: GaussianSource totalflux unit doc is misleading #94

Open
pllim opened this issue Jun 22, 2018 · 0 comments
Open

DOC: GaussianSource totalflux unit doc is misleading #94

pllim opened this issue Jun 22, 2018 · 0 comments
Labels

Comments

@pllim
Copy link
Collaborator

pllim commented Jun 22, 2018

Given this GaussianSource docstring:

    Parameters
    ----------
    flux : float
        Total flux under the Gaussian curve, in given flux unit.
    center : float
        Central wavelength of the Gaussian curve, in given wavelength unit.
    fwhm : float
        FWHM of the Gaussian curve, in given wavelength unit.
    waveunits, fluxunits : str
        Wavelength and flux units, as accepted by `~pysynphot.units.Units`.
        Defaults are Angstrom and ``flam``.

However, the total flux actually represents the integrated flux, not the monochromatic flux, therefore cannot be represented by the fluxunits. Instead of, say, flam, it is actually erg/s/cm^2.

c/c @vglaidler , not sure if you use Gaussian source in ETC.

xref spacetelescope/synphot_refactor#153

@pllim pllim added the bug label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant