Update matrix-appservice-irc version
#3512
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomwiggers
commented
Sep 9, 2024
Comment on lines
+117
to
+132
| # Config for the media proxy, required to serve publically accessible URLs to authenticated Matrix media | ||
| mediaProxy: | ||
| # To generate a .jwk file: | ||
| # $ node src/generate-signing-key.js > signingkey.jwk | ||
| signingKeyPath: "signingkey.jwk" | ||
| # How long should the generated URLs be valid for | ||
| ttlSeconds: 3600 | ||
| # The port for the media proxy to listen on | ||
| bindPort: 11111 | ||
| # The publically accessible URL to the media proxy | ||
| publicUrl: "https://irc.bridge/media" |
There was a problem hiding this comment.
These lines require some more setup
|
Setting up media proxy is a bit above my level |
|
I have rebased this, but would appreciate some help getting the authenticated media set up correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update to
3.0brings with it that it now uses MediaProxy.