Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user created snippets #435

Open
theRealPadster opened this issue Feb 7, 2023 · 7 comments
Open

Add user created snippets #435

theRealPadster opened this issue Feb 7, 2023 · 7 comments
Labels
💫 enhancement New feature or request

Comments

@theRealPadster
Copy link
Member

📝 Provide a description of the new feature

It would be sweet to add user created snippets to marketplace, so it's easier to get them added in, and we don't need people to make a PR and stuff every time they want to add/update one.

This would work much the same as the themes and extensions tabs, but have a snippetcss key or something and use a snippet github topic.

➕ Additional Information

No response

@theRealPadster theRealPadster added the 💫 enhancement New feature or request label Feb 7, 2023
@CharlieS1103
Copy link
Member

Yeah wasn't this the original plan with the snippets idea using firebase but then we opted to just do a file instead

@theRealPadster
Copy link
Member Author

I don't remember. I'm proposing we just use a manifest like all the rest

@theRealPadster
Copy link
Member Author

Should we make the manifest have a snippetcss field that is the css string, or have it point to a css file, like the usercss one does? Pointing to a file would let people keep things cleaner if they have more than one snippet, and would allow people to use less or scss and build the css itself. But also might just be overkill for snippets.

@CharlieS1103
Copy link
Member

@theRealPadster I forget why we didn't allow this from the start, did we have a good reason?

@CharlieS1103
Copy link
Member

The only good reason I can come up with now is to prevent the saturation of unmaintained snippets, but at this point I think most of them are like that regardless.

@theRealPadster
Copy link
Member Author

@CharlieS1103 tbh I think we just didn't think of it? Like we just added them ourselves and didn't really think of other people adding their own in their own repo.

@CharlieS1103
Copy link
Member

@theRealPadster thats very valid on past us's behalf. I'll look into merging that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💫 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants