Bugfix #1080: "Deactivated users reappeared" #1104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chestnutFan
changed the title
almet
requested changes
Dec 11, 2022
There was a problem hiding this comment.
Thanks for your work on this. It's leading the right way, but needs some changes before integration.
Some feedback :
- At all times, avoid copy-pasting code. Here the code to get the deactivated member list is in two different places. If we needed this code, it should probably go in the model instead ;
- I believe we don't actually need this code because the model can already tel us what are the deactivated members. Try to do this instead of building the list on your own
- In terms of UX, I believe it would be better to have a tooltip as I explained. I'm happy to change my mind on this if you have good arguments :-)
Anyway, thanks for taking the time to do this 👍. Let me know when you've made some edits.
|
Hi Almet! Thanks for reviewing my code. I rewrote the check function using the activated attribute, and moved it to the model. |
-Made involves_deactivated_members() a property of the Bill class -Removed flashed messages
|
Hi @almet! Tooltips have been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1080 by adding the deactivated member check. Corresponding test functions were also finished.
Details:
1. Added the deactivated member check for editing/deleting bills.
Compare the payer&owers list (POL) of the bill with the active member list (AML). If the relative complement of AML in POL (POL \ AML) is not empty, then the bill contains deactivated members and should not be edited/deleted.
2. Added two corresponding integration test functions.
Test:
Passed all the tests.