Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of "estimateAffine2D" for finding transformation matrix in OpenCV version greater than 3.0 #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Addition of "estimateAffine2D" for finding transformation matrix in OpenCV version greater than 3.0 #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions VideoStabilization/video_stabilization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,11 @@ def fixBorder(frame):
curr_pts = curr_pts[idx]

#Find transformation matrix
m = cv2.estimateRigidTransform(prev_pts, curr_pts, fullAffine=False) #will only work with OpenCV-3 or less
if float((cv2.__version__)[0:3])<=3.0:
Copy link

@dustinfreeman dustinfreeman Jul 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on other usages in the repo, I less brittle version of this is:

if int((cv2.__version__).split('.')[0]) <= 3:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dustinfreeman what changes do you suggest here to merge this PR?

m = cv2.estimateRigidTransform(prev_pts, curr_pts, fullAffine=False) #will only work with OpenCV-3 or less

else:
m,_ = cv2.estimateAffine2D(prev_pts, curr_pts)# will work with OpenCV>3.0

# Extract traslation
dx = m[0,2]
Expand Down Expand Up @@ -165,4 +169,4 @@ def fixBorder(frame):
cap.release()
out.release()
# Close windows
cv2.destroyAllWindows()
cv2.destroyAllWindows()