From d227660e60e0da19d71a0c214fb3478a58ec2d14 Mon Sep 17 00:00:00 2001 From: Kengo TODA Date: Sat, 23 Sep 2017 21:26:56 +0800 Subject: [PATCH 0001/1013] Deploy Maven site to gh-page --- .travis.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/.travis.yml b/.travis.yml index c5a2f0d36..aeed466f1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,5 +6,23 @@ jdk: - openjdk8 - openjdk7 +env: + global: + # GITHUB_TOKEN value to push changes to GitHub; Currently it is ued to update gh-pages. + - secure: "KqPuq9TiiqdOUfGq3k+XYObNjV8FxbgJeqSWK0pcWFFs5w5c4vcGmrfUSSSqNa/JJkKOBWQ6S3tJP7CRxx0uow5BvU4ZQAZLFt6VjzcUZFKGTl5soMTF2gQdyAAcwUnRX2gQKt0doO8Fid6xzfsn1KdTIWXmeqMrcTvC+d7EhxU=" + script: - ./mvnw verify -B -P run-its -DtestSrc=remote -Dinvoker.parallelThreads=4 + - ./mvnw site -B + +deploy: + - provider: pages + skip_cleanup: true + github_token: $GITHUB_TOKEN + local_dir: $TRAVIS_BUILD_DIR/target/site + email: skypencil+spotbugs-bot@gmail.com + on: + repo: spotbugs/spotbugs-maven-plugin + branch: spotbugs + jdk: oraclejdk8 + condition: "!$TRAVIS_PULL_REQUEST" From 5ea87a1d5a60952a72f7c49a5ecacf618ad3bf10 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 11 Oct 2017 22:16:33 -0400 Subject: [PATCH 0002/1013] [travis] Drop Java 7 in support of spotbugs --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index aeed466f1..7b15fa2e2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,6 @@ sudo: false jdk: - oraclejdk8 - openjdk8 - - openjdk7 env: global: From a9827871d19147b810f125bcc813bfb8b1718334 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 11 Oct 2017 22:31:54 -0400 Subject: [PATCH 0003/1013] Spotbugs Rebranding --- README.md | 24 +- pom.xml | 71 +-- src/changes/changes.xml | 7 +- .../it/App.java | 2 +- .../it/FooTest.java | 2 +- src/it-tools/build-tools/pom.xml | 6 +- src/it-tools/prime/pom.xml | 8 +- src/it/MFINDBUGS-145/pom.xml | 8 +- .../it/mfindbugs145/App.java | 2 +- src/it/MFINDBUGS-145/verify.bsh | 8 +- src/it/MFINDBUGS-178/pom.xml | 14 +- src/it/basic-1/pom.xml | 8 +- src/it/basic-1/verify.groovy | 34 +- src/it/check-fail/invoker.properties | 2 +- src/it/check-fail/pom.xml | 8 +- src/it/check-jvmargs/invoker.properties | 2 +- src/it/check-jvmargs/pom.xml | 10 +- src/it/check-jvmargs/verify.groovy | 20 +- src/it/check-multi/invoker.properties | 2 +- src/it/check-multi/modules/module-1/pom.xml | 2 +- src/it/check-multi/modules/module-2/pom.xml | 2 +- src/it/check-multi/modules/pom.xml | 10 +- src/it/check-multi/pom.xml | 2 +- src/it/check-multi/verify.groovy | 28 +- src/it/check-nofail/invoker.properties | 2 +- src/it/check-nofail/pom.xml | 8 +- .../check-pluginList-repo/invoker.properties | 2 +- src/it/check-pluginList-repo/pom.xml | 8 +- src/it/check-pluginList-repo/verify.groovy | 20 +- src/it/check-skip/invoker.properties | 2 +- src/it/check-skip/pom.xml | 8 +- src/it/check-skip/verify.groovy | 6 +- src/it/check-timeout/invoker.properties | 2 +- src/it/check-timeout/pom.xml | 6 +- src/it/check/invoker.properties | 2 +- src/it/check/pom.xml | 8 +- src/it/check/verify.groovy | 24 +- src/it/common.xml | 18 +- src/it/effort-default/pom.xml | 8 +- src/it/effort-default/verify.groovy | 34 +- src/it/effort-max/pom.xml | 8 +- src/it/effort-max/verify.groovy | 34 +- src/it/effort-min/pom.xml | 8 +- src/it/effort-min/verify.groovy | 34 +- src/it/empty/pom.xml | 8 +- src/it/empty/verify.groovy | 6 +- src/it/encoding-utf8/pom.xml | 8 +- src/it/encoding-utf8/verify.groovy | 32 +- src/it/exclude-modules/invoker.properties | 2 +- src/it/exclude-modules/module1/pom.xml | 8 +- src/it/exclude-modules/module2/pom.xml | 8 +- src/it/exclude-modules/pom.xml | 2 +- src/it/exclude-modules/verify.groovy | 28 +- src/it/exclude-multi/pom.xml | 10 +- src/it/exclude-multi/verify.groovy | 32 +- src/it/exclude/pom.xml | 10 +- src/it/exclude/verify.groovy | 32 +- src/it/excludeBugsFile/excludeBugs1.xml | 6 +- src/it/excludeBugsFile/excludeBugs2.xml | 2 +- src/it/excludeBugsFile/invoker.properties | 2 +- src/it/excludeBugsFile/pom.xml | 8 +- src/it/excludeBugsFile/verify.groovy | 20 +- src/it/experimental/pom.xml | 8 +- src/it/experimental/verify.groovy | 35 +- src/it/include-multi/pom.xml | 10 +- src/it/include-multi/verify.groovy | 32 +- src/it/include/pom.xml | 10 +- src/it/include/verify.groovy | 32 +- src/it/maxRank/invoker.properties | 2 +- src/it/maxRank/pom.xml | 8 +- src/it/maxRank/verify.groovy | 20 +- src/it/multi-build/modules/module-1/pom.xml | 2 +- src/it/multi-build/modules/module-2/pom.xml | 2 +- src/it/multi-build/modules/pom.xml | 4 +- src/it/multi-build/pom.xml | 37 +- src/it/multi-build/verify.groovy | 86 ++-- src/it/multi/modules/module-1/pom.xml | 2 +- .../modules/module-1/src/site/xdoc/index.xml | 4 +- src/it/multi/modules/module-2/pom.xml | 2 +- .../modules/module-2/src/site/xdoc/index.xml | 4 +- src/it/multi/modules/pom.xml | 10 +- src/it/multi/pom.xml | 2 +- src/it/multi/verify.groovy | 86 ++-- src/it/nested/pom.xml | 8 +- src/it/nested/verify.groovy | 34 +- src/it/no-src/pom.xml | 6 +- src/it/no-src/verify.groovy | 4 +- src/it/no-testsrc/pom.xml | 6 +- src/it/no-testsrc/verify.groovy | 34 +- src/it/omitVisitors/pom.xml | 8 +- src/it/omitVisitors/verify.groovy | 44 +- src/it/onlyAnalyze/pom.xml | 8 +- src/it/onlyAnalyze/verify.groovy | 34 +- src/it/pluginList-repo/pom.xml | 8 +- src/it/pluginList-repo/verify.groovy | 34 +- src/it/pluginList/pom.xml | 8 +- src/it/pluginList/verify.groovy | 34 +- src/it/relaxed/pom.xml | 8 +- src/it/relaxed/verify.groovy | 34 +- src/it/site-brazil/pom.xml | 8 +- src/it/site-brazil/verify.groovy | 34 +- src/it/site-default/pom.xml | 8 +- src/it/site-default/verify.groovy | 34 +- src/it/site-french/pom.xml | 8 +- src/it/site-french/verify.groovy | 34 +- src/it/site-spanish/pom.xml | 8 +- src/it/site-spanish/verify.groovy | 34 +- src/it/skip/pom.xml | 8 +- src/it/skip/verify.groovy | 6 +- src/it/skipEmpty/pom.xml | 10 +- src/it/skipEmpty/verify.groovy | 22 +- src/it/threaded/pom.xml | 8 +- src/it/threaded/verify.groovy | 34 +- src/it/threshold-experimental/pom.xml | 8 +- src/it/threshold-experimental/verify.groovy | 34 +- src/it/threshold-high/pom.xml | 8 +- src/it/threshold-high/verify.groovy | 34 +- src/it/threshold-low/pom.xml | 8 +- src/it/threshold-low/verify.groovy | 34 +- src/it/trace/pom.xml | 8 +- src/it/trace/verify.groovy | 34 +- .../edu.umd.cs.findbugs.core.prefs | 4 +- src/it/userPrefs-override/pom.xml | 8 +- src/it/userPrefs-override/verify.groovy | 34 +- .../userPrefs/edu.umd.cs.findbugs.core.prefs | 4 +- src/it/userPrefs/pom.xml | 8 +- src/it/userPrefs/verify.groovy | 34 +- .../ResourceHelper.groovy | 10 +- .../SpotBugsGui.groovy} | 58 +-- .../SpotBugsInfo.groovy} | 30 +- .../SpotBugsMojo.groovy} | 205 +++++---- .../SpotBugsPluginsTrait.groovy} | 16 +- .../SpotbugsReportGenerator.groovy} | 102 ++--- .../SpotbugsViolationCheckMojo.groovy} | 102 ++--- .../XDocsReporter.groovy | 32 +- src/main/resources/findbugs.properties | 28 -- src/main/resources/findbugs_en.properties | 28 -- src/main/resources/findbugs_es.properties | 28 -- src/main/resources/findbugs_fr.properties | 28 -- src/main/resources/findbugs_no_NO.properties | 28 -- src/main/resources/findbugs_pt_BR.properties | 28 -- src/main/resources/spotbugs.properties | 28 ++ src/main/resources/spotbugs_en.properties | 28 ++ src/main/resources/spotbugs_es.properties | 28 ++ src/main/resources/spotbugs_fr.properties | 28 ++ src/main/resources/spotbugs_no_NO.properties | 28 ++ src/main/resources/spotbugs_pt_BR.properties | 28 ++ src/main/tools/annotations.pom | 22 - src/main/tools/bcel.pom | 22 - src/main/tools/fb2bundle.groovy | 12 +- src/main/tools/fb2local.groovy | 24 +- src/main/tools/fb2repo.groovy | 25 +- src/main/tools/findbugs-ant.pom | 29 -- src/main/tools/jFormatString.pom | 16 +- src/main/tools/jsr305.pom | 16 +- src/main/tools/spotbugs-annotations.pom | 23 + src/main/tools/spotbugs-ant.pom | 30 ++ src/main/tools/{findbugs.pom => spotbugs.pom} | 35 +- .../apt/examples/multi-module-config.apt.vm | 18 +- .../apt/examples/violationChecking.apt.vm | 8 +- src/site/apt/index.apt.vm | 18 +- src/site/apt/usage.apt.vm | 88 ++-- src/site/fml/faq.fml | 4 +- src/site/resources/examples/findbugsXml.xml | 417 ------------------ .../examples/{findbugs.html => spotbugs.html} | 208 ++++----- .../examples/{findbugs.xml => spotbugs.xml} | 2 +- src/site/resources/examples/spotbugsXml.xml | 417 ++++++++++++++++++ .../examples/xref-test/allclasses-frame.html | 4 +- .../mojo/findbugsmavenplugin/it/App.html | 6 +- .../mojo/findbugsmavenplugin/it/FooTest.html | 6 +- .../findbugsmavenplugin/it/package-frame.html | 4 +- .../it/package-summary.html | 4 +- .../examples/xref-test/overview-frame.html | 2 +- .../examples/xref-test/overview-summary.html | 2 +- .../resources/examples/xref/UserMistakes.html | 2 +- src/site/site.xml | 18 +- 176 files changed, 2169 insertions(+), 2178 deletions(-) rename src/it-src/test/java/org/codehaus/mojo/{findbugsmavenplugin => spotbugsmavenplugin}/it/App.java (85%) rename src/it-src/test/java/org/codehaus/mojo/{findbugsmavenplugin => spotbugsmavenplugin}/it/FooTest.java (88%) rename src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/{findbugsmavenplugin => spotbugsmavenplugin}/it/mfindbugs145/App.java (81%) rename src/main/groovy/org/codehaus/mojo/{findbugs => spotbugs}/ResourceHelper.groovy (92%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindBugsGui.groovy => spotbugs/SpotBugsGui.groovy} (79%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindBugsInfo.groovy => spotbugs/SpotBugsInfo.groovy} (70%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindBugsMojo.groovy => spotbugs/SpotBugsMojo.groovy} (83%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindBugsPluginsTrait.groovy => spotbugs/SpotBugsPluginsTrait.groovy} (92%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindbugsReportGenerator.groovy => spotbugs/SpotbugsReportGenerator.groovy} (81%) rename src/main/groovy/org/codehaus/mojo/{findbugs/FindbugsViolationCheckMojo.groovy => spotbugs/SpotbugsViolationCheckMojo.groovy} (79%) rename src/main/groovy/org/codehaus/mojo/{findbugs => spotbugs}/XDocsReporter.groovy (82%) delete mode 100644 src/main/resources/findbugs.properties delete mode 100644 src/main/resources/findbugs_en.properties delete mode 100644 src/main/resources/findbugs_es.properties delete mode 100644 src/main/resources/findbugs_fr.properties delete mode 100644 src/main/resources/findbugs_no_NO.properties delete mode 100644 src/main/resources/findbugs_pt_BR.properties create mode 100644 src/main/resources/spotbugs.properties create mode 100644 src/main/resources/spotbugs_en.properties create mode 100644 src/main/resources/spotbugs_es.properties create mode 100644 src/main/resources/spotbugs_fr.properties create mode 100644 src/main/resources/spotbugs_no_NO.properties create mode 100644 src/main/resources/spotbugs_pt_BR.properties delete mode 100644 src/main/tools/annotations.pom delete mode 100644 src/main/tools/bcel.pom delete mode 100644 src/main/tools/findbugs-ant.pom create mode 100644 src/main/tools/spotbugs-annotations.pom create mode 100644 src/main/tools/spotbugs-ant.pom rename src/main/tools/{findbugs.pom => spotbugs.pom} (68%) delete mode 100644 src/site/resources/examples/findbugsXml.xml rename src/site/resources/examples/{findbugs.html => spotbugs.html} (66%) rename src/site/resources/examples/{findbugs.xml => spotbugs.xml} (96%) create mode 100644 src/site/resources/examples/spotbugsXml.xml diff --git a/README.md b/README.md index 48f3ea102..ee5e8fca2 100644 --- a/README.md +++ b/README.md @@ -1,22 +1,22 @@ -# Findbugs Maven Plugin +# Spotbugs Maven Plugin -[![Build Status](https://travis-ci.org/gleclaire/findbugs-maven-plugin.svg?branch=master)](https://travis-ci.org/gleclaire/findbugs-maven-plugin) -[![Maven central](https://maven-badges.herokuapp.com/maven-central/org.codehaus.mojo/findbugs-maven-plugin/badge.svg)](https://maven-badges.herokuapp.com/maven-central/org.codehaus.mojo/findbugs-maven-plugin) +[![Build Status](https://travis-ci.org/spotbugs/spotbugs-maven-plugin.svg?branch=spotbugs)](https://travis-ci.org/spotbugs/spotbugs-maven-plugin) +[![Maven central](https://maven-badges.herokuapp.com/maven-central/com.github.spotbugs/spotbugs-maven-plugin/badge.svg)](https://maven-badges.herokuapp.com/maven-central/com.github.spotbugs/spotbugs-maven-plugin) [![Apache 2](https://img.shields.io/badge/license-Apache%202-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0) ## Latest Snapshot ## -Please download latest snapshots from [here](https://oss.sonatype.org/content/repositories/snapshots/org/codehaus/mojo/findbugs-maven-plugin/) +Please download latest snapshots from [here](https://oss.sonatype.org/content/repositories/snapshots/com/github/spotbugs/spotbugs-maven-plugin/) -Building findbugs-maven-plugin Requirements -===================== +Building spotbugs-maven-plugin Requirements +=========================================== -Java 7 is required. This will allow analysis of bytecode up to Java 8 +Java 8 is required for spotbugs analysis. -findbugs-maven-plugin +spotbugs-maven-plugin ===================== -Maven Mojo Plug-In to generate reports based on the FindBugs Analyzer +Maven Mojo Plug-In to generate reports based on the SpotBugs Analyzer Run all tests ``` @@ -26,9 +26,9 @@ Skip tests ``` mvn -DskipTests=true clean install ``` -Run tests on findbugs test source code that is local instead of from FindBugs github repository +Run tests on spotbugs test source code that is local instead of from SpotBugs github repository ``` -mvn -DtestSrc=local -DlocalTestSrc=/opt/findBugs -Prun-its clean install -D"invoker.parallelThreads=4" +mvn -DtestSrc=local -DlocalTestSrc=/opt/spotBugs -Prun-its clean install -D"invoker.parallelThreads=4" ``` Run selected tests @@ -48,5 +48,5 @@ mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspe Run gui with a specific version ``` -mvn org.codehaus.mojo:findbugs-maven-plugin:3.0.6-SNAPSHOT:gui +mvn com.github.spotbugs:spotbugs-maven-plugin:3.1.0-SNAPSHOT:gui ``` diff --git a/pom.xml b/pom.xml index 45857514d..221bd3432 100644 --- a/pom.xml +++ b/pom.xml @@ -9,14 +9,14 @@ - org.codehaus.mojo - findbugs-maven-plugin - 3.0.6-SNAPSHOT + com.github.spotbugs + spotbugs-maven-plugin + 3.1.0-SNAPSHOT maven-plugin - FindBugs Maven Plugin - This Plug-In generates reports based on the FindBugs Library - https://gleclaire.github.io/findbugs-maven-plugin/ + SpotBugs Maven Plugin + This Plug-In generates reports based on the SpotBugs Library + https://spotbugs.github.io/spotbugs-maven-plugin/ 2005 @@ -98,19 +98,27 @@ - scm:git:https://github.com/gleclaire/findbugs-maven-plugin.git - scm:git:ssh://git@github.com/gleclaire/findbugs-maven-plugin.git - https://github.com/gleclaire/findbugs-maven-plugin + scm:git:https://github.com/spotbugs/spotbugs-maven-plugin.git + scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git + https://github.com/spotbugs/spotbugs-maven-plugin HEAD GitHub Issues - http://github.com/gleclaire/findbugs-maven-plugin/issues + https://github.com/spotbugs/spotbugs-maven-plugin/issues + + ossrh + https://oss.sonatype.org/service/local/staging/deploy/maven2/ + + + ossrh + https://oss.sonatype.org/content/repositories/snapshots + github-project-site - gitsite:git@github.com/gleclaire/findbugs-maven-plugin.git + gitsite:git@github.com/spotbugs/spotbugs-maven-plugin.git @@ -118,8 +126,9 @@ 1.7 ${project.version} - 3.0.1 4.12 + 3.1.0-RC5 + 3.1.0_RC5 1.9.9 2.4.12 @@ -150,11 +159,11 @@ 0.3.1 - false - ${project.build.directory}/it-src-findbugs - ${user.dir}/FindBugs - scm:git:https://github.com/findbugsproject/findbugs/ - **findbugsTestCases/src/java/A*.java, **findbugsTestCases/src/java/Use*.java, **findbugsTestCases/src/java/annotations/*.java + false + ${project.build.directory}/it-src-spotbugs + ${user.dir}/SpotBugs + scm:git:https://github.com/spotbugs/spotbugs/ + **spotbugsTestCases/src/java/A*.java, **spotbugsTestCases/src/java/Use*.java, **spotbugsTestCases/src/java/annotations/*.java remote true @@ -168,17 +177,17 @@ 1.7.1 2.5 2.20.1 - 6.0 - 3.0.1 + 7.0 + 3.1.0 - com.google.code.findbugs - findbugs - ${findbugsVersion} + com.github.spotbugs + spotbugs + ${spotbugsVersion} xml-apis @@ -455,8 +464,8 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${project.version} true @@ -561,7 +570,7 @@ run-its - false + false @@ -619,7 +628,7 @@ - find-it-src-checkout + spot-it-src-checkout testSrc @@ -634,7 +643,7 @@ ${scmPluginVersion} - prepare-integration-test-remote-findbugs-src + prepare-integration-test-remote-spotbugs-src pre-integration-test checkout @@ -646,8 +655,8 @@ jgit ${includesTestSrcPattern} - release-${findbugsVersion} - branch + ${spotbugsTag} + tag @@ -664,7 +673,7 @@ - find-it-src-local + spot-it-src-local testSrc @@ -679,7 +688,7 @@ ${antrunPluginVersion} - prepare-integration-test-local-findbugs-src + prepare-integration-test-local-spotbugs-src pre-integration-test run diff --git a/src/changes/changes.xml b/src/changes/changes.xml index d56b8fb78..1c8b0fb9e 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -1,11 +1,16 @@ - FindBugs Maven plugin changelog + SpotBugs Maven plugin Changelog Garvin LeClaire + + + Rebrand and upgrade to using spotbugs + + Update to Findbugs 1.3.9 diff --git a/src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/App.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java similarity index 85% rename from src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/App.java rename to src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java index 98f3e16f7..3b9c238ec 100644 --- a/src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/App.java +++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java @@ -1,4 +1,4 @@ -package org.codehaus.mojo.findbugsmavenplugin.it; +package org.codehaus.mojo.spotbugsmavenplugin.it; import org.junit.*; diff --git a/src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/FooTest.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java similarity index 88% rename from src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/FooTest.java rename to src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java index 47b94d3dd..ae61479e2 100644 --- a/src/it-src/test/java/org/codehaus/mojo/findbugsmavenplugin/it/FooTest.java +++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java @@ -1,4 +1,4 @@ -package org.codehaus.mojo.findbugsmavenplugin.it; +package org.codehaus.mojo.spotbugsmavenplugin.it; import static org.junit.Assert.assertEquals; diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml index fe72aa4ba..bb9e1e644 100644 --- a/src/it-tools/build-tools/pom.xml +++ b/src/it-tools/build-tools/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools build-tools jar @@ -32,8 +32,8 @@ maven-compiler-plugin false - 1.6 - 1.6 + 1.8 + 1.8 fakeAnnotations/** jsr305/** diff --git a/src/it-tools/prime/pom.xml b/src/it-tools/prime/pom.xml index 24f22de85..2e124d002 100644 --- a/src/it-tools/prime/pom.xml +++ b/src/it-tools/prime/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it prime prime jar @@ -27,9 +27,9 @@ - com.google.code.findbugs - findbugs - @findbugsVersion@ + com.github.spotbugs + spotbugs + @spotbugsVersion@ junit diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml index d12ef82d3..136badd09 100644 --- a/src/it/MFINDBUGS-145/pom.xml +++ b/src/it/MFINDBUGS-145/pom.xml @@ -20,14 +20,14 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it MFINDBUGS-145 testing jar @@ -55,8 +55,8 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin diff --git a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/findbugsmavenplugin/it/mfindbugs145/App.java b/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java similarity index 81% rename from src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/findbugsmavenplugin/it/mfindbugs145/App.java rename to src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java index d31a8d55d..43de59a09 100644 --- a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/findbugsmavenplugin/it/mfindbugs145/App.java +++ b/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java @@ -1,4 +1,4 @@ -package org.codehaus.mojo.findbugsmavenplugin.it.mfindbugs145; +package org.codehaus.mojo.spotbugsmavenplugin.it.mfindbugs145; /** * Hello world! diff --git a/src/it/MFINDBUGS-145/verify.bsh b/src/it/MFINDBUGS-145/verify.bsh index 8e9bf5467..57baba1c8 100644 --- a/src/it/MFINDBUGS-145/verify.bsh +++ b/src/it/MFINDBUGS-145/verify.bsh @@ -5,11 +5,11 @@ import java.util.*; String[] paths = { - "target/site/findbugs.html", + "target/site/spotbugs.html", "target/site/xref/index.html", }; -// Findbugs and JXR reports +// Spotbugs and JXR reports for ( String path : paths ) { File file = new File( basedir, path ); @@ -20,9 +20,9 @@ for ( String path : paths ) } } -File report = new File( basedir, "target/site/findbugs.html" ); +File report = new File( basedir, "target/site/spotbugs.html" ); String content = FileUtils.fileRead( report, "UTF-8" ); -if ( content.indexOf( "" ) < 0 ) +if ( content.indexOf( "" ) < 0 ) { throw new IOException( "XRef link not generated." ); } diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml index b3f2c37f2..c6032cfda 100644 --- a/src/it/MFINDBUGS-178/pom.xml +++ b/src/it/MFINDBUGS-178/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High @@ -57,10 +57,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/basic-1/pom.xml b/src/it/basic-1/pom.xml index dfba3a8ce..4e1a3db5f 100644 --- a/src/it/basic-1/pom.xml +++ b/src/it/basic-1/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true true diff --git a/src/it/basic-1/verify.groovy b/src/it/basic-1/verify.groovy index c02b26eee..b64794365 100644 --- a/src/it/basic-1/verify.groovy +++ b/src/it/basic-1/verify.groovy @@ -17,54 +17,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/check-fail/invoker.properties b/src/it/check-fail/invoker.properties index 6d1d896e9..14379f58c 100644 --- a/src/it/check-fail/invoker.properties +++ b/src/it/check-fail/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = failure diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml index cb38ef285..0728cb3af 100644 --- a/src/it/check-fail/pom.xml +++ b/src/it/check-fail/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true true - @findbugsTestDebug@ + @spotbugsTestDebug@ High diff --git a/src/it/check-jvmargs/invoker.properties b/src/it/check-jvmargs/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check-jvmargs/invoker.properties +++ b/src/it/check-jvmargs/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check-jvmargs/pom.xml b/src/it/check-jvmargs/pom.xml index 87d02bd9d..48fc7ff91 100644 --- a/src/it/check-jvmargs/pom.xml +++ b/src/it/check-jvmargs/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,15 +30,15 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High - -Dfindbugs.dumpProperties=true -Dfindbugs.progress=true -Dfindbugs.verbose=true -Dfindbugs.debug=true + -Dspotbugs.dumpProperties=true -Dspotbugs.progress=true -Dspotbugs.verbose=true -Dspotbugs.debug=true diff --git a/src/it/check-jvmargs/verify.groovy b/src/it/check-jvmargs/verify.groovy index 4406c6eba..861be815d 100644 --- a/src/it/check-jvmargs/verify.groovy +++ b/src/it/check-jvmargs/verify.groovy @@ -15,32 +15,32 @@ */ -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -def path = new XmlSlurper().parse(findbugXdoc) +def path = new XmlSlurper().parse(spotbugXdoc) def allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors diff --git a/src/it/check-multi/invoker.properties b/src/it/check-multi/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check-multi/invoker.properties +++ b/src/it/check-multi/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check-multi/modules/module-1/pom.xml b/src/it/check-multi/modules/module-1/pom.xml index c3f25da02..08b62b744 100644 --- a/src/it/check-multi/modules/module-1/pom.xml +++ b/src/it/check-multi/modules/module-1/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/check-multi/modules/module-2/pom.xml b/src/it/check-multi/modules/module-2/pom.xml index 6c41c155b..62f9b8edd 100644 --- a/src/it/check-multi/modules/module-2/pom.xml +++ b/src/it/check-multi/modules/module-2/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/check-multi/modules/pom.xml b/src/it/check-multi/modules/pom.xml index a067e69a3..745355545 100644 --- a/src/it/check-multi/modules/pom.xml +++ b/src/it/check-multi/modules/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it multi testing ../pom.xml @@ -30,18 +30,18 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true - @findbugsTestDebug@ + @spotbugsTestDebug@ false - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing diff --git a/src/it/check-multi/pom.xml b/src/it/check-multi/pom.xml index d2ce57358..155a0a2ac 100644 --- a/src/it/check-multi/pom.xml +++ b/src/it/check-multi/pom.xml @@ -18,7 +18,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml diff --git a/src/it/check-multi/verify.groovy b/src/it/check-multi/verify.groovy index cd88ada5f..506611dd1 100644 --- a/src/it/check-multi/verify.groovy +++ b/src/it/check-multi/verify.groovy @@ -19,36 +19,36 @@ // check module 1 -File findbugXml = new File(basedir, "modules/module-1/target/findbugsXml.xml") -assert findbugXml.exists() +File spotbugXml = new File(basedir, "modules/module-1/target/spotbugsXml.xml") +assert spotbugXml.exists() -def path = new XmlSlurper().parse(findbugXml) +def path = new XmlSlurper().parse(spotbugXml) println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' allNodes = path.depthFirst().collect { it } -def findbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsErrors}" +def spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsErrors}" -assert findbugsErrors > 0 +assert spotbugsErrors > 0 // check module 2 -findbugXml = new File(basedir, "modules/module-2/target/findbugsXml.xml") -assert findbugXml.exists() +spotbugXml = new File(basedir, "modules/module-2/target/spotbugsXml.xml") +assert spotbugXml.exists() -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' allNodes = path.depthFirst().collect { it } -findbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsErrors}" +spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsErrors}" -assert findbugsErrors > 0 +assert spotbugsErrors > 0 diff --git a/src/it/check-nofail/invoker.properties b/src/it/check-nofail/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check-nofail/invoker.properties +++ b/src/it/check-nofail/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml index f49174227..e61d8d263 100644 --- a/src/it/check-nofail/pom.xml +++ b/src/it/check-nofail/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High diff --git a/src/it/check-pluginList-repo/invoker.properties b/src/it/check-pluginList-repo/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check-pluginList-repo/invoker.properties +++ b/src/it/check-pluginList-repo/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check-pluginList-repo/pom.xml b/src/it/check-pluginList-repo/pom.xml index b9d51f9d0..ebcf21036 100644 --- a/src/it/check-pluginList-repo/pom.xml +++ b/src/it/check-pluginList-repo/pom.xml @@ -12,7 +12,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -23,12 +23,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin false true - @findbugsTestDebug@ + @spotbugsTestDebug@ com.mebigfatguy.fb-contrib diff --git a/src/it/check-pluginList-repo/verify.groovy b/src/it/check-pluginList-repo/verify.groovy index 8f479baf6..0d76faf7e 100644 --- a/src/it/check-pluginList-repo/verify.groovy +++ b/src/it/check-pluginList-repo/verify.groovy @@ -15,33 +15,33 @@ */ -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -def path = new XmlSlurper().parse(findbugXdoc) +def path = new XmlSlurper().parse(spotbugXdoc) def allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors diff --git a/src/it/check-skip/invoker.properties b/src/it/check-skip/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check-skip/invoker.properties +++ b/src/it/check-skip/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check-skip/pom.xml b/src/it/check-skip/pom.xml index 73377675e..9cceef769 100644 --- a/src/it/check-skip/pom.xml +++ b/src/it/check-skip/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High true diff --git a/src/it/check-skip/verify.groovy b/src/it/check-skip/verify.groovy index 4c422b5dd..b8d6d5137 100644 --- a/src/it/check-skip/verify.groovy +++ b/src/it/check-skip/verify.groovy @@ -14,6 +14,6 @@ * limitations under the License. */ -assert !(new File(basedir, 'target/site/findbugs.html').exists()) -assert !(new File(basedir, 'target/findbugs.xml').exists()) -assert !(new File(basedir, 'target/findbugsXml.xml').exists()) +assert !(new File(basedir, 'target/site/spotbugs.html').exists()) +assert !(new File(basedir, 'target/spotbugs.xml').exists()) +assert !(new File(basedir, 'target/spotbugsXml.xml').exists()) diff --git a/src/it/check-timeout/invoker.properties b/src/it/check-timeout/invoker.properties index 6d1d896e9..14379f58c 100644 --- a/src/it/check-timeout/invoker.properties +++ b/src/it/check-timeout/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = failure diff --git a/src/it/check-timeout/pom.xml b/src/it/check-timeout/pom.xml index bd1bbbf4a..8ad811237 100644 --- a/src/it/check-timeout/pom.xml +++ b/src/it/check-timeout/pom.xml @@ -18,7 +18,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -29,8 +29,8 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true 1000 diff --git a/src/it/check/invoker.properties b/src/it/check/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/check/invoker.properties +++ b/src/it/check/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/check/pom.xml b/src/it/check/pom.xml index f49174227..e61d8d263 100644 --- a/src/it/check/pom.xml +++ b/src/it/check/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High diff --git a/src/it/check/verify.groovy b/src/it/check/verify.groovy index 26191e306..e4faa7be6 100644 --- a/src/it/check/verify.groovy +++ b/src/it/check/verify.groovy @@ -14,24 +14,24 @@ * limitations under the License. */ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert !findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert !spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" @@ -39,11 +39,11 @@ println '***************************' println "Checking xDoc file" println '***************************' -def path = new XmlSlurper().parse(findbugXdoc) +def path = new XmlSlurper().parse(spotbugXdoc) xNodes = path.depthFirst().collect{ it } def xdocErrors = xNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors diff --git a/src/it/common.xml b/src/it/common.xml index aff173846..82a71dd14 100644 --- a/src/it/common.xml +++ b/src/it/common.xml @@ -21,16 +21,16 @@ 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing pom - com.google.code.findbugs - findbugs - @findbugsVersion@ + com.github.spotbugs + spotbugs + @spotbugsVersion@ junit @@ -53,13 +53,13 @@ - @project.build.directory@/it-src-findbugs/findbugsTestCases/src/java + @project.build.directory@/it-src-spotbugs/spotbugsTestCases/src/java @project.basedir@/src/it-src/test/java - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin @pom.version@ @@ -97,8 +97,8 @@ maven-compiler-plugin false - 1.6 - 1.6 + 1.8 + 1.8 *fakeAnnotations/** jsr305/** diff --git a/src/it/effort-default/pom.xml b/src/it/effort-default/pom.xml index 8d6e93ab7..97cbbd36a 100644 --- a/src/it/effort-default/pom.xml +++ b/src/it/effort-default/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin Default - true + true true true diff --git a/src/it/effort-default/verify.groovy b/src/it/effort-default/verify.groovy index a220ba3b1..7aaf734f6 100644 --- a/src/it/effort-default/verify.groovy +++ b/src/it/effort-default/verify.groovy @@ -17,48 +17,48 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -66,7 +66,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/effort-max/pom.xml b/src/it/effort-max/pom.xml index 188675580..7e9d7f597 100644 --- a/src/it/effort-max/pom.xml +++ b/src/it/effort-max/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin Max - true + true true true diff --git a/src/it/effort-max/verify.groovy b/src/it/effort-max/verify.groovy index 3e6d61235..1cd9cb999 100644 --- a/src/it/effort-max/verify.groovy +++ b/src/it/effort-max/verify.groovy @@ -17,48 +17,48 @@ def effortLevel = 'max' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -66,7 +66,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/effort-min/pom.xml b/src/it/effort-min/pom.xml index 6941f3db4..939241772 100644 --- a/src/it/effort-min/pom.xml +++ b/src/it/effort-min/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin Min - true + true true true diff --git a/src/it/effort-min/verify.groovy b/src/it/effort-min/verify.groovy index d6ffdd306..b74ed570b 100644 --- a/src/it/effort-min/verify.groovy +++ b/src/it/effort-min/verify.groovy @@ -17,48 +17,48 @@ def effortLevel = 'min' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -66,7 +66,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/empty/pom.xml b/src/it/empty/pom.xml index ac2f1bd1c..cc3be7e1b 100644 --- a/src/it/empty/pom.xml +++ b/src/it/empty/pom.xml @@ -17,7 +17,7 @@ 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it testing empty empty @@ -30,10 +30,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/empty/verify.groovy b/src/it/empty/verify.groovy index 011bd62d2..c8e17fe0e 100644 --- a/src/it/empty/verify.groovy +++ b/src/it/empty/verify.groovy @@ -15,10 +15,10 @@ */ -assert !(new File(basedir, 'target/site/findbugs.html').exists()) +assert !(new File(basedir, 'target/site/spotbugs.html').exists()) -assert !(new File(basedir, 'target/findbugs.xml').exists()) +assert !(new File(basedir, 'target/spotbugs.xml').exists()) -assert !(new File(basedir, 'target/findbugsXml.xml').exists()) +assert !(new File(basedir, 'target/spotbugsXml.xml').exists()) diff --git a/src/it/encoding-utf8/pom.xml b/src/it/encoding-utf8/pom.xml index a5d63aca6..34a50c710 100644 --- a/src/it/encoding-utf8/pom.xml +++ b/src/it/encoding-utf8/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -39,10 +39,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/encoding-utf8/verify.groovy b/src/it/encoding-utf8/verify.groovy index f03c1a6bc..70902470c 100644 --- a/src/it/encoding-utf8/verify.groovy +++ b/src/it/encoding-utf8/verify.groovy @@ -16,14 +16,14 @@ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' @@ -33,35 +33,35 @@ println '***************************' def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/exclude-modules/invoker.properties b/src/it/exclude-modules/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/exclude-modules/invoker.properties +++ b/src/it/exclude-modules/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/exclude-modules/module1/pom.xml b/src/it/exclude-modules/module1/pom.xml index b0c4d9d1b..88ac15744 100644 --- a/src/it/exclude-modules/module1/pom.xml +++ b/src/it/exclude-modules/module1/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it exclude-modules testing ../pom.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ ${project.basedir}/src/main/excludeBugs.xml diff --git a/src/it/exclude-modules/module2/pom.xml b/src/it/exclude-modules/module2/pom.xml index 7cf8e5424..c8fde266c 100644 --- a/src/it/exclude-modules/module2/pom.xml +++ b/src/it/exclude-modules/module2/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it exclude-modules testing ../pom.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ ${project.basedir}/src/main/excludeBugs.xml diff --git a/src/it/exclude-modules/pom.xml b/src/it/exclude-modules/pom.xml index f95169751..639b694eb 100644 --- a/src/it/exclude-modules/pom.xml +++ b/src/it/exclude-modules/pom.xml @@ -18,7 +18,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml diff --git a/src/it/exclude-modules/verify.groovy b/src/it/exclude-modules/verify.groovy index 8661b9f9c..5f5a080e7 100644 --- a/src/it/exclude-modules/verify.groovy +++ b/src/it/exclude-modules/verify.groovy @@ -19,36 +19,36 @@ // check module 1 -File findbugXml = new File(basedir, "module1/target/findbugsXml.xml") -assert findbugXml.exists() +File spotbugXml = new File(basedir, "module1/target/spotbugsXml.xml") +assert spotbugXml.exists() -def path = new XmlSlurper().parse(findbugXml) +def path = new XmlSlurper().parse(spotbugXml) println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' allNodes = path.depthFirst().collect { it } -def findbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsErrors}" +def spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsErrors}" -assert findbugsErrors > 0 +assert spotbugsErrors > 0 // check module 2 -findbugXml = new File(basedir, "module2/target/findbugsXml.xml") -assert findbugXml.exists() +spotbugXml = new File(basedir, "module2/target/spotbugsXml.xml") +assert spotbugXml.exists() -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' allNodes = path.depthFirst().collect { it } -findbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsErrors}" +spotbugsErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsErrors}" -assert findbugsErrors > 0 +assert spotbugsErrors > 0 diff --git a/src/it/exclude-multi/pom.xml b/src/it/exclude-multi/pom.xml index 4c472c88d..9f3c234c4 100644 --- a/src/it/exclude-multi/pom.xml +++ b/src/it/exclude-multi/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing @@ -45,10 +45,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true whizbang/lib-filter.xml,filters/lib-filter2.xml diff --git a/src/it/exclude-multi/verify.groovy b/src/it/exclude-multi/verify.groovy index f03c1a6bc..70902470c 100644 --- a/src/it/exclude-multi/verify.groovy +++ b/src/it/exclude-multi/verify.groovy @@ -16,14 +16,14 @@ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' @@ -33,35 +33,35 @@ println '***************************' def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/exclude/pom.xml b/src/it/exclude/pom.xml index 205fd0f38..e2abc8d4a 100644 --- a/src/it/exclude/pom.xml +++ b/src/it/exclude/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing @@ -45,10 +45,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true filters/lib-filter2.xml diff --git a/src/it/exclude/verify.groovy b/src/it/exclude/verify.groovy index f03c1a6bc..70902470c 100644 --- a/src/it/exclude/verify.groovy +++ b/src/it/exclude/verify.groovy @@ -16,14 +16,14 @@ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' @@ -33,35 +33,35 @@ println '***************************' def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/excludeBugsFile/excludeBugs1.xml b/src/it/excludeBugsFile/excludeBugs1.xml index 93ba0a7fc..4c733a96e 100644 --- a/src/it/excludeBugsFile/excludeBugs1.xml +++ b/src/it/excludeBugsFile/excludeBugs1.xml @@ -1,5 +1,5 @@ -/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it/basic-2/target/classes/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/mojo/findbugs-maven-plugin/2.4.1-SNAPSHOT/findbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-sink-api/1.1.3/doxia-sink-api-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-site-renderer/1.1.3/doxia-site-renderer-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/findbugs-ant/2.0.0/findbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/findbugs/2.0.0/findbugs-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it-src-findbugs/java/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it/basic-2/targetDoomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 14]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 28]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 35]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 16]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 24]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 30]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 26]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 37]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 92-2973]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 12]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 92-2973]Expected StringValue loaded from ?At ArrayEquality.java:[line 17]equals() used to compare array and nonarrayCalling String[][].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 27]equals() used to compare array and nonarrayCalling String[].equals(String[][]) in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 32]Call to equals() comparing different typesCall to String[].equals(int[]) in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 37]Call to equals() comparing different typesCall to int[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 42]Call to equals() comparing different typesCall to StringBuffer[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 47]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 162]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 67]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 79]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 83]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 115]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 111]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 127]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 123]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 131]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 119]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 56]Nullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 12 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 6-19]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 11]Redundant null check at UseCheckUse.java:[line 12]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 44]Method call passes null to a nonnull parameter Null passed for nonnull parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 24]Dodgy codeBad practiceCorrectnessInternationalizationClass defines equals() and uses Object.hashCode()
+/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-sink-api/1.1.3/doxia-sink-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-site-renderer/1.1.3/doxia-site-renderer-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/targetDoomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 14]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 28]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 35]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 16]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 24]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 30]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 26]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 37]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 92-2973]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 12]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 92-2973]Expected StringValue loaded from ?At ArrayEquality.java:[line 17]equals() used to compare array and nonarrayCalling String[][].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 27]equals() used to compare array and nonarrayCalling String[].equals(String[][]) in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 32]Call to equals() comparing different typesCall to String[].equals(int[]) in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 37]Call to equals() comparing different typesCall to int[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 42]Call to equals() comparing different typesCall to StringBuffer[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 47]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 162]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 67]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 79]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 83]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 115]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 111]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 127]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 123]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 131]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 119]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 56]Nullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 12 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 6-19]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 11]Redundant null check at UseCheckUse.java:[line 12]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 44]Method call passes null to a nonnull parameter Null passed for nonnull parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 24]Dodgy codeBad practiceCorrectnessInternationalizationClass defines equals() and uses Object.hashCode()
<p> This class overrides <code>equals(Object)</code>, but does not override <code>hashCode()</code>, and inherits the implementation of @@ -161,8 +161,8 @@ used. </p> <p> Note that Sun's javac compiler often generates dead stores for -final local variables. Because FindBugs is a bytecode-based tool, +final local variables. Because SpotBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. </p> -
Suspicious calls to generic collection methodsUninitialized read of field in constructorDubious method usedEqual objects must have equal hashcodesRedundant comparison to nullSuspicious integer expressionComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceUseless self-operation \ No newline at end of file +
Suspicious calls to generic collection methodsUninitialized read of field in constructorDubious method usedEqual objects must have equal hashcodesRedundant comparison to nullSuspicious integer expressionComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceUseless self-operation \ No newline at end of file diff --git a/src/it/excludeBugsFile/excludeBugs2.xml b/src/it/excludeBugsFile/excludeBugs2.xml index e6a3ec35d..ba077e7ab 100644 --- a/src/it/excludeBugsFile/excludeBugs2.xml +++ b/src/it/excludeBugsFile/excludeBugs2.xml @@ -1,5 +1,5 @@ -/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it/includeFile/target/classes/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/mojo/findbugs-maven-plugin/2.4.1-SNAPSHOT/findbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/findbugs-ant/2.0.0/findbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/findbugs/2.0.0/findbugs-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it-src-findbugs/java/Users/garvin/NetBeansProjects/findbugs-maven-plugin/target/it/includeFile/targetDead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 17]Another occurrence at UselessAssignments.java:[line 19]Dead store to local variableDead store to $L1 in UselessCurrentThread.test4()At UselessCurrentThread.java:[lines 7-64]In class UselessCurrentThreadIn method UselessCurrentThread.test4()Local variable stored in JVM register 1At UselessCurrentThread.java:[line 37]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 28]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 159]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]Dodgy codeDead store to local variable
+/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/targetDead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 17]Another occurrence at UselessAssignments.java:[line 19]Dead store to local variableDead store to $L1 in UselessCurrentThread.test4()At UselessCurrentThread.java:[lines 7-64]In class UselessCurrentThreadIn method UselessCurrentThread.test4()Local variable stored in JVM register 1At UselessCurrentThread.java:[line 37]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 28]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 159]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]Dodgy codeDead store to local variable
<p> This instruction assigns a value to a local variable, diff --git a/src/it/excludeBugsFile/invoker.properties b/src/it/excludeBugsFile/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/excludeBugsFile/invoker.properties +++ b/src/it/excludeBugsFile/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/excludeBugsFile/pom.xml b/src/it/excludeBugsFile/pom.xml index ca52aa3c6..4d6ff4980 100644 --- a/src/it/excludeBugsFile/pom.xml +++ b/src/it/excludeBugsFile/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ ${project.basedir}/excludeBugs1.xml,${project.basedir}/excludeBugs2.xml diff --git a/src/it/excludeBugsFile/verify.groovy b/src/it/excludeBugsFile/verify.groovy index ffde7d909..bdfc0137a 100644 --- a/src/it/excludeBugsFile/verify.groovy +++ b/src/it/excludeBugsFile/verify.groovy @@ -15,11 +15,11 @@ */ -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() @@ -27,21 +27,21 @@ println '***************************' println "Checking xDoc file" println '***************************' -def path = new XmlSlurper().parse(findbugXdoc) +def path = new XmlSlurper().parse(spotbugXdoc) def allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors diff --git a/src/it/experimental/pom.xml b/src/it/experimental/pom.xml index c71d43778..919e7e235 100644 --- a/src/it/experimental/pom.xml +++ b/src/it/experimental/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -35,10 +35,10 @@ maven-jxr-plugin - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true Exp true diff --git a/src/it/experimental/verify.groovy b/src/it/experimental/verify.groovy index 519418583..5f8c1714e 100644 --- a/src/it/experimental/verify.groovy +++ b/src/it/experimental/verify.groovy @@ -17,46 +17,47 @@ def thresholdLevel = 'experimental' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + thresholdLevel + "" ) +assert spotbugsHtml.text.contains( "" + thresholdLevel + "" ) + def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -64,7 +65,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@threshold.text() == thresholdLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/include-multi/pom.xml b/src/it/include-multi/pom.xml index 9f754138a..bfdcd4b45 100644 --- a/src/it/include-multi/pom.xml +++ b/src/it/include-multi/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing @@ -45,10 +45,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true whizbang/lib-filter.xml,filters/lib-filter2.xml diff --git a/src/it/include-multi/verify.groovy b/src/it/include-multi/verify.groovy index f03c1a6bc..70902470c 100644 --- a/src/it/include-multi/verify.groovy +++ b/src/it/include-multi/verify.groovy @@ -16,14 +16,14 @@ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' @@ -33,35 +33,35 @@ println '***************************' def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/include/pom.xml b/src/it/include/pom.xml index 7a6a0024a..31b4d6efa 100644 --- a/src/it/include/pom.xml +++ b/src/it/include/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing @@ -45,10 +45,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true whizbang/lib-filter.xml diff --git a/src/it/include/verify.groovy b/src/it/include/verify.groovy index f03c1a6bc..70902470c 100644 --- a/src/it/include/verify.groovy +++ b/src/it/include/verify.groovy @@ -16,14 +16,14 @@ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' @@ -33,35 +33,35 @@ println '***************************' def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/maxRank/invoker.properties b/src/it/maxRank/invoker.properties index 45d371380..d5da9063b 100644 --- a/src/it/maxRank/invoker.properties +++ b/src/it/maxRank/invoker.properties @@ -1,4 +1,4 @@ -invoker.goals = clean compile findbugs:check +invoker.goals = clean compile spotbugs:check # The expected result of the build, possible values are "success" (default) and "failure" invoker.buildResult = success diff --git a/src/it/maxRank/pom.xml b/src/it/maxRank/pom.xml index 69a589edd..4cc0fce95 100644 --- a/src/it/maxRank/pom.xml +++ b/src/it/maxRank/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,12 +30,12 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true false - @findbugsTestDebug@ + @spotbugsTestDebug@ High 4 diff --git a/src/it/maxRank/verify.groovy b/src/it/maxRank/verify.groovy index ffde7d909..bdfc0137a 100644 --- a/src/it/maxRank/verify.groovy +++ b/src/it/maxRank/verify.groovy @@ -15,11 +15,11 @@ */ -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() @@ -27,21 +27,21 @@ println '***************************' println "Checking xDoc file" println '***************************' -def path = new XmlSlurper().parse(findbugXdoc) +def path = new XmlSlurper().parse(spotbugXdoc) def allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors diff --git a/src/it/multi-build/modules/module-1/pom.xml b/src/it/multi-build/modules/module-1/pom.xml index c3f25da02..08b62b744 100644 --- a/src/it/multi-build/modules/module-1/pom.xml +++ b/src/it/multi-build/modules/module-1/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/multi-build/modules/module-2/pom.xml b/src/it/multi-build/modules/module-2/pom.xml index 6c41c155b..62f9b8edd 100644 --- a/src/it/multi-build/modules/module-2/pom.xml +++ b/src/it/multi-build/modules/module-2/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/multi-build/modules/pom.xml b/src/it/multi-build/modules/pom.xml index 4fc4d0879..319c9090c 100644 --- a/src/it/multi-build/modules/pom.xml +++ b/src/it/multi-build/modules/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it multi-build testing ../pom.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing diff --git a/src/it/multi-build/pom.xml b/src/it/multi-build/pom.xml index 7ee519ed3..adc54f2ac 100644 --- a/src/it/multi-build/pom.xml +++ b/src/it/multi-build/pom.xml @@ -18,7 +18,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,25 +36,26 @@ org.apache.maven.plugins maven-site-plugin @sitePluginVersion@ + + + + + + + + org.apache.maven.plugins + maven-jxr-plugin + @jxrPluginVersion@ + + + com.github.spotbugs + spotbugs-maven-plugin - - - org.apache.maven.plugins - maven-jxr-plugin - @jxrPluginVersion@ - - - org.codehaus.mojo - findbugs-maven-plugin - - true - true - whizbang/lib-filter.xml - - - + true + true + whizbang/lib-filter.xml - + \ No newline at end of file diff --git a/src/it/multi-build/verify.groovy b/src/it/multi-build/verify.groovy index 7e4a00899..84cf37624 100644 --- a/src/it/multi-build/verify.groovy +++ b/src/it/multi-build/verify.groovy @@ -25,63 +25,63 @@ println '***************************' def module = "module-1" -File findbugsHtml = new File(basedir, "modules/${module}/target/site/findbugs.html") -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, "modules/${module}/target/site/spotbugs.html") +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, "modules/${module}/target/findbugs.xml") -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, "modules/${module}/target/spotbugs.xml") +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, "modules/${module}/target/findbugsXml.xml") -assert findbugXml.exists() +File spotbugXml = new File(basedir, "modules/${module}/target/spotbugsXml.xml") +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors xdocErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() println "BugInstance with includes size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() -println "BugInstance with includes size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() +println "BugInstance with includes size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors @@ -93,63 +93,63 @@ println '***************************' module = "module-2" -findbugsHtml = new File(basedir, "modules/${module}/target/site/findbugs.html") -assert findbugsHtml.exists() +spotbugsHtml = new File(basedir, "modules/${module}/target/site/spotbugs.html") +assert spotbugsHtml.exists() -findbugXdoc = new File(basedir, "modules/${module}/target/findbugs.xml") -assert findbugXdoc.exists() +spotbugXdoc = new File(basedir, "modules/${module}/target/spotbugs.xml") +assert spotbugXdoc.exists() -findbugXml = new File(basedir, "modules/${module}/target/findbugsXml.xml") -assert findbugXml.exists() +spotbugXml = new File(basedir, "modules/${module}/target/spotbugsXml.xml") +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) -//path = new XmlSlurper(true, true, true).parse( findbugsHtml ) +//path = new XmlSlurper(true, true, true).parse( spotbugsHtml ) xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -path = xhtmlParser.parse( findbugsHtml ) +path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors xdocErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() println "BugInstance with includes size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() -println "BugInstance with includes size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() +println "BugInstance with includes size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/multi/modules/module-1/pom.xml b/src/it/multi/modules/module-1/pom.xml index c3f25da02..08b62b744 100644 --- a/src/it/multi/modules/module-1/pom.xml +++ b/src/it/multi/modules/module-1/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/multi/modules/module-1/src/site/xdoc/index.xml b/src/it/multi/modules/module-1/src/site/xdoc/index.xml index b1e577965..6bab5b73e 100644 --- a/src/it/multi/modules/module-1/src/site/xdoc/index.xml +++ b/src/it/multi/modules/module-1/src/site/xdoc/index.xml @@ -1,11 +1,11 @@ - FindBugs Maven Testing + SpotBugs Maven Testing -
+

diff --git a/src/it/multi/modules/module-2/pom.xml b/src/it/multi/modules/module-2/pom.xml index 6c41c155b..62f9b8edd 100644 --- a/src/it/multi/modules/module-2/pom.xml +++ b/src/it/multi/modules/module-2/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it modules testing ../pom.xml diff --git a/src/it/multi/modules/module-2/src/site/xdoc/index.xml b/src/it/multi/modules/module-2/src/site/xdoc/index.xml index a03682d2e..925d6ac47 100644 --- a/src/it/multi/modules/module-2/src/site/xdoc/index.xml +++ b/src/it/multi/modules/module-2/src/site/xdoc/index.xml @@ -1,11 +1,11 @@ - Findbugs Maven Testing + Spotbugs Maven Testing -
+

diff --git a/src/it/multi/modules/pom.xml b/src/it/multi/modules/pom.xml index 02901ae24..5a44e17db 100644 --- a/src/it/multi/modules/pom.xml +++ b/src/it/multi/modules/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it multi testing ../pom.xml @@ -30,7 +30,7 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it build-tools testing @@ -45,10 +45,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true whizbang/lib-filter.xml diff --git a/src/it/multi/pom.xml b/src/it/multi/pom.xml index d2ce57358..155a0a2ac 100644 --- a/src/it/multi/pom.xml +++ b/src/it/multi/pom.xml @@ -18,7 +18,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml diff --git a/src/it/multi/verify.groovy b/src/it/multi/verify.groovy index 428557ceb..26de2a664 100644 --- a/src/it/multi/verify.groovy +++ b/src/it/multi/verify.groovy @@ -25,63 +25,63 @@ println '***************************' def module = "module-1" -File findbugsHtml = new File(basedir, "modules/${module}/target/site/findbugs.html") -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, "modules/${module}/target/site/spotbugs.html") +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, "modules/${module}/target/findbugs.xml") -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, "modules/${module}/target/spotbugs.xml") +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, "modules/${module}/target/findbugsXml.xml") -assert findbugXml.exists() +File spotbugXml = new File(basedir, "modules/${module}/target/spotbugsXml.xml") +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(new File(basedir, "modules/${module}/target/findbugs.xml")) +path = new XmlSlurper().parse(new File(basedir, "modules/${module}/target/spotbugs.xml")) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors xdocErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() println "BugInstance with includes size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(new File(basedir, "modules/${module}/target/findbugsXml.xml")) +path = new XmlSlurper().parse(new File(basedir, "modules/${module}/target/spotbugsXml.xml")) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() -println "BugInstance with includes size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() +println "BugInstance with includes size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors @@ -94,64 +94,64 @@ println '***************************' module = "module-2" -findbugsHtml = new File(basedir, "modules/${module}/target/site/findbugs.html") -assert findbugsHtml.exists() +spotbugsHtml = new File(basedir, "modules/${module}/target/site/spotbugs.html") +assert spotbugsHtml.exists() -findbugXdoc = new File(basedir, "modules/${module}/target/findbugs.xml") -assert findbugXdoc.exists() +spotbugXdoc = new File(basedir, "modules/${module}/target/spotbugs.xml") +assert spotbugXdoc.exists() -findbugXml = new File(basedir, "modules/${module}/target/findbugsXml.xml") -assert findbugXml.exists() +spotbugXml = new File(basedir, "modules/${module}/target/spotbugsXml.xml") +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) -//path = new XmlSlurper(true, true, true).parse( findbugsHtml ) +//path = new XmlSlurper(true, true, true).parse( spotbugsHtml ) // xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -path = xhtmlParser.parse( findbugsHtml ) +path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors xdocErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() println "BugInstance with includes size is ${xdocErrors}" -assert findbugsErrors == xdocErrors +assert spotbugsErrors == xdocErrors println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() -println "BugInstance with includes size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() +println "BugInstance with includes size is ${spotbugsXmlErrors}" -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/nested/pom.xml b/src/it/nested/pom.xml index b810e09a6..3d2ade813 100644 --- a/src/it/nested/pom.xml +++ b/src/it/nested/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true true diff --git a/src/it/nested/verify.groovy b/src/it/nested/verify.groovy index c02b26eee..b64794365 100644 --- a/src/it/nested/verify.groovy +++ b/src/it/nested/verify.groovy @@ -17,54 +17,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/no-src/pom.xml b/src/it/no-src/pom.xml index ec2aca689..efada9ce8 100644 --- a/src/it/no-src/pom.xml +++ b/src/it/no-src/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -34,8 +34,8 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true true diff --git a/src/it/no-src/verify.groovy b/src/it/no-src/verify.groovy index dd40c38af..389e2fb82 100644 --- a/src/it/no-src/verify.groovy +++ b/src/it/no-src/verify.groovy @@ -17,5 +17,5 @@ assert (new File(basedir, 'target/site/index.html').exists()) -assert (new File(basedir, 'target/findbugs.xml').exists()) -assert (new File(basedir, 'target/findbugsXml.xml').exists()) +assert (new File(basedir, 'target/spotbugs.xml').exists()) +assert (new File(basedir, 'target/spotbugsXml.xml').exists()) diff --git a/src/it/no-testsrc/pom.xml b/src/it/no-testsrc/pom.xml index 569c394e3..7c5e53ae8 100644 --- a/src/it/no-testsrc/pom.xml +++ b/src/it/no-testsrc/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -33,8 +33,8 @@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true true diff --git a/src/it/no-testsrc/verify.groovy b/src/it/no-testsrc/verify.groovy index c02b26eee..b64794365 100644 --- a/src/it/no-testsrc/verify.groovy +++ b/src/it/no-testsrc/verify.groovy @@ -17,54 +17,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/omitVisitors/pom.xml b/src/it/omitVisitors/pom.xml index 18aeb924e..7a8c1b144 100644 --- a/src/it/omitVisitors/pom.xml +++ b/src/it/omitVisitors/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true FindDeadLocalStores,UnreadFields diff --git a/src/it/omitVisitors/verify.groovy b/src/it/omitVisitors/verify.groovy index 12d8f72b3..c4cc53081 100644 --- a/src/it/omitVisitors/verify.groovy +++ b/src/it/omitVisitors/verify.groovy @@ -17,61 +17,61 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsXmlErrors == findbugsErrors +assert spotbugsXmlErrors == spotbugsErrors -findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "URF_UNREAD_FIELD" }.size() -findbugsXmlErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "UUF_UNUSED_FIELD"}.size() -findbugsXmlErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() -println "BugInstance with includes size is ${findbugsXmlErrors}" +spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "URF_UNREAD_FIELD" }.size() +spotbugsXmlErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "UUF_UNUSED_FIELD"}.size() +spotbugsXmlErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_DEAD_LOCAL_STORE"}.size() +println "BugInstance with includes size is ${spotbugsXmlErrors}" -assert 0 == findbugsXmlErrors +assert 0 == spotbugsXmlErrors println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsErrors +assert xdocErrors == spotbugsErrors xdocErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == "URF_UNREAD_FIELD" }.size() xdocErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "UUF_UNUSED_FIELD"}.size() diff --git a/src/it/onlyAnalyze/pom.xml b/src/it/onlyAnalyze/pom.xml index 1e62e16f3..3bdb68780 100644 --- a/src/it/onlyAnalyze/pom.xml +++ b/src/it/onlyAnalyze/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true BC_Unconfirmed_Cast diff --git a/src/it/onlyAnalyze/verify.groovy b/src/it/onlyAnalyze/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/onlyAnalyze/verify.groovy +++ b/src/it/onlyAnalyze/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/pluginList-repo/pom.xml b/src/it/pluginList-repo/pom.xml index a118d7ecb..197a7bc6b 100644 --- a/src/it/pluginList-repo/pom.xml +++ b/src/it/pluginList-repo/pom.xml @@ -9,7 +9,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -21,10 +21,10 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/pluginList-repo/verify.groovy b/src/it/pluginList-repo/verify.groovy index c02b26eee..b64794365 100644 --- a/src/it/pluginList-repo/verify.groovy +++ b/src/it/pluginList-repo/verify.groovy @@ -17,54 +17,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/pluginList/pom.xml b/src/it/pluginList/pom.xml index 335c2b52f..01a6d83a3 100644 --- a/src/it/pluginList/pom.xml +++ b/src/it/pluginList/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,10 +31,10 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true http://repo1.maven.org/maven2/com/mebigfatguy/fb-contrib/fb-contrib/@fb-contribVersion@/fb-contrib-@fb-contribVersion@.jar, diff --git a/src/it/pluginList/verify.groovy b/src/it/pluginList/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/pluginList/verify.groovy +++ b/src/it/pluginList/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/relaxed/pom.xml b/src/it/relaxed/pom.xml index 8326a6432..01d95aee4 100644 --- a/src/it/relaxed/pom.xml +++ b/src/it/relaxed/pom.xml @@ -18,7 +18,7 @@ 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -30,10 +30,10 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true true diff --git a/src/it/relaxed/verify.groovy b/src/it/relaxed/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/relaxed/verify.groovy +++ b/src/it/relaxed/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/site-brazil/pom.xml b/src/it/site-brazil/pom.xml index a6f0fdcbf..22806d3fd 100644 --- a/src/it/site-brazil/pom.xml +++ b/src/it/site-brazil/pom.xml @@ -18,7 +18,7 @@ 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -43,10 +43,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/site-brazil/verify.groovy b/src/it/site-brazil/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/site-brazil/verify.groovy +++ b/src/it/site-brazil/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/site-default/pom.xml b/src/it/site-default/pom.xml index a4b475534..1a5d1b3e5 100644 --- a/src/it/site-default/pom.xml +++ b/src/it/site-default/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -42,10 +42,10 @@ maven-jxr-plugin - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/site-default/verify.groovy b/src/it/site-default/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/site-default/verify.groovy +++ b/src/it/site-default/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/site-french/pom.xml b/src/it/site-french/pom.xml index 2a7c53a8f..9e580eed5 100644 --- a/src/it/site-french/pom.xml +++ b/src/it/site-french/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -42,10 +42,10 @@ maven-jxr-plugin - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/site-french/verify.groovy b/src/it/site-french/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/site-french/verify.groovy +++ b/src/it/site-french/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/site-spanish/pom.xml b/src/it/site-spanish/pom.xml index 30b5a9db1..7cba8012b 100644 --- a/src/it/site-spanish/pom.xml +++ b/src/it/site-spanish/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -42,10 +42,10 @@ maven-jxr-plugin - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/site-spanish/verify.groovy b/src/it/site-spanish/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/site-spanish/verify.groovy +++ b/src/it/site-spanish/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/skip/pom.xml b/src/it/skip/pom.xml index 4ea13a090..e2402334f 100644 --- a/src/it/skip/pom.xml +++ b/src/it/skip/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,11 +36,11 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin true - true + true true true diff --git a/src/it/skip/verify.groovy b/src/it/skip/verify.groovy index 3eeb3e8c3..2c571c005 100644 --- a/src/it/skip/verify.groovy +++ b/src/it/skip/verify.groovy @@ -15,7 +15,7 @@ */ -assert !(new File(basedir, 'target/site/findbugs.html').exists()) -assert !(new File(basedir, 'target/findbugs.xml').exists()) -assert !(new File(basedir, 'target/findbugsXml.xml').exists()) +assert !(new File(basedir, 'target/site/spotbugs.html').exists()) +assert !(new File(basedir, 'target/spotbugs.xml').exists()) +assert !(new File(basedir, 'target/spotbugsXml.xml').exists()) diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml index 9a8fa1ec8..62446b7a6 100644 --- a/src/it/skipEmpty/pom.xml +++ b/src/it/skipEmpty/pom.xml @@ -20,14 +20,14 @@ - findbugs-maven-plugin.it + spotbugs-maven-plugin.it testing skipEmpty skipEmpty @@ -40,10 +40,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true true diff --git a/src/it/skipEmpty/verify.groovy b/src/it/skipEmpty/verify.groovy index 21ceb3c73..0d2151846 100644 --- a/src/it/skipEmpty/verify.groovy +++ b/src/it/skipEmpty/verify.groovy @@ -15,25 +15,25 @@ */ -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert !findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert !spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert !findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert !spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" -assert findbugsXmlErrors == 0 +assert spotbugsXmlErrors == 0 diff --git a/src/it/threaded/pom.xml b/src/it/threaded/pom.xml index d20002df2..5e4036e8a 100644 --- a/src/it/threaded/pom.xml +++ b/src/it/threaded/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true diff --git a/src/it/threaded/verify.groovy b/src/it/threaded/verify.groovy index 2ff94a73d..75a58203d 100644 --- a/src/it/threaded/verify.groovy +++ b/src/it/threaded/verify.groovy @@ -16,54 +16,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/threshold-experimental/pom.xml b/src/it/threshold-experimental/pom.xml index 5d8e5227b..9da926e2a 100644 --- a/src/it/threshold-experimental/pom.xml +++ b/src/it/threshold-experimental/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin Exp - true + true true true diff --git a/src/it/threshold-experimental/verify.groovy b/src/it/threshold-experimental/verify.groovy index 4e465c63c..4b66932b8 100644 --- a/src/it/threshold-experimental/verify.groovy +++ b/src/it/threshold-experimental/verify.groovy @@ -17,54 +17,54 @@ def thresholdLevel = 'experimental' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + thresholdLevel + "" ) +assert spotbugsHtml.text.contains( "" + thresholdLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/threshold-high/pom.xml b/src/it/threshold-high/pom.xml index d3deb6148..2a30f180e 100644 --- a/src/it/threshold-high/pom.xml +++ b/src/it/threshold-high/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin High - true + true true true diff --git a/src/it/threshold-high/verify.groovy b/src/it/threshold-high/verify.groovy index 67ac5a277..7d050126f 100644 --- a/src/it/threshold-high/verify.groovy +++ b/src/it/threshold-high/verify.groovy @@ -18,54 +18,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/threshold-low/pom.xml b/src/it/threshold-low/pom.xml index a7f5afe8c..4e207d937 100644 --- a/src/it/threshold-low/pom.xml +++ b/src/it/threshold-low/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin Low - true + true true true diff --git a/src/it/threshold-low/verify.groovy b/src/it/threshold-low/verify.groovy index 5109debf2..af9309c53 100644 --- a/src/it/threshold-low/verify.groovy +++ b/src/it/threshold-low/verify.groovy @@ -17,47 +17,47 @@ def thresholdLevel = 'low' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + thresholdLevel + "" ) +assert spotbugsHtml.text.contains( "" + thresholdLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -65,7 +65,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@threshold.text() == thresholdLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/trace/pom.xml b/src/it/trace/pom.xml index 3cccae612..f75929dff 100644 --- a/src/it/trace/pom.xml +++ b/src/it/trace/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -36,10 +36,10 @@ @jxrPluginVersion@ - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin - true + true true true diff --git a/src/it/trace/verify.groovy b/src/it/trace/verify.groovy index c02b26eee..b64794365 100644 --- a/src/it/trace/verify.groovy +++ b/src/it/trace/verify.groovy @@ -17,54 +17,54 @@ def effortLevel = 'default' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/userPrefs-override/edu.umd.cs.findbugs.core.prefs b/src/it/userPrefs-override/edu.umd.cs.findbugs.core.prefs index 596625f92..410c1efc7 100644 --- a/src/it/userPrefs-override/edu.umd.cs.findbugs.core.prefs +++ b/src/it/userPrefs-override/edu.umd.cs.findbugs.core.prefs @@ -1,4 +1,4 @@ -#FindBugs User Preferences +#SpotBugs User Preferences #Wed Jun 18 10:04:41 CEST 2014 cloud_id=edu.umd.cs.findbugs.cloud.appengine.findbugs-cloud detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true @@ -129,7 +129,7 @@ detectorWrongMapIterator=WrongMapIterator|true detectorXMLFactoryBypass=XMLFactoryBypass|true detector_threshold=3 effort=min -excludefilter0=findbugsExclude.xml|true +excludefilter0=spotbugsExclude.xml|true filter_settings=Low|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|20 filter_settings_neg=MALICIOUS_CODE,NOISE| run_at_full_build=false diff --git a/src/it/userPrefs-override/pom.xml b/src/it/userPrefs-override/pom.xml index 28483ed83..4292e5a55 100644 --- a/src/it/userPrefs-override/pom.xml +++ b/src/it/userPrefs-override/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${project.basedir}/edu.umd.cs.findbugs.core.prefs - true + true true Max true diff --git a/src/it/userPrefs-override/verify.groovy b/src/it/userPrefs-override/verify.groovy index 1ab97316a..13d1f6e49 100644 --- a/src/it/userPrefs-override/verify.groovy +++ b/src/it/userPrefs-override/verify.groovy @@ -17,47 +17,47 @@ def effortLevel = 'max' -File findbugsHtml = new File(basedir, 'target/site/findbugs.html') -assert findbugsHtml.exists() +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() -File findbugXdoc = new File(basedir, 'target/findbugs.xml') -assert findbugXdoc.exists() +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() -File findbugXml = new File(basedir, 'target/findbugsXml.xml') -assert findbugXml.exists() +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() println '***************************' println "Checking HTML file" println '***************************' -assert findbugsHtml.text.contains( "" + effortLevel + "" ) +assert spotbugsHtml.text.contains( "" + effortLevel + "" ) def xhtmlParser = new XmlSlurper(); xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) -def path = xhtmlParser.parse( findbugsHtml ) +def path = xhtmlParser.parse( spotbugsHtml ) //*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] -def findbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() -println "Error Count is ${findbugsErrors}" +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.div[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" println '**********************************' -println "Checking Findbugs Native XML file" +println "Checking Spotbugs Native XML file" println '**********************************' -path = new XmlSlurper().parse(findbugXml) +path = new XmlSlurper().parse(spotbugXml) allNodes = path.depthFirst().collect{ it } -def findbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() -println "BugInstance size is ${findbugsXmlErrors}" +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" println '***************************' println "Checking xDoc file" println '***************************' -path = new XmlSlurper().parse(findbugXdoc) +path = new XmlSlurper().parse(spotbugXdoc) allNodes = path.depthFirst().collect{ it } def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() @@ -65,7 +65,7 @@ println "BugInstance size is ${xdocErrors}" assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLevel -assert xdocErrors == findbugsXmlErrors +assert xdocErrors == spotbugsXmlErrors -assert findbugsErrors == findbugsXmlErrors +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/it/userPrefs/edu.umd.cs.findbugs.core.prefs b/src/it/userPrefs/edu.umd.cs.findbugs.core.prefs index 596625f92..410c1efc7 100644 --- a/src/it/userPrefs/edu.umd.cs.findbugs.core.prefs +++ b/src/it/userPrefs/edu.umd.cs.findbugs.core.prefs @@ -1,4 +1,4 @@ -#FindBugs User Preferences +#SpotBugs User Preferences #Wed Jun 18 10:04:41 CEST 2014 cloud_id=edu.umd.cs.findbugs.cloud.appengine.findbugs-cloud detectorAppendingToAnObjectOutputStream=AppendingToAnObjectOutputStream|true @@ -129,7 +129,7 @@ detectorWrongMapIterator=WrongMapIterator|true detectorXMLFactoryBypass=XMLFactoryBypass|true detector_threshold=3 effort=min -excludefilter0=findbugsExclude.xml|true +excludefilter0=spotbugsExclude.xml|true filter_settings=Low|BAD_PRACTICE,CORRECTNESS,EXPERIMENTAL,I18N,MT_CORRECTNESS,PERFORMANCE,SECURITY,STYLE|false|20 filter_settings_neg=MALICIOUS_CODE,NOISE| run_at_full_build=false diff --git a/src/it/userPrefs/pom.xml b/src/it/userPrefs/pom.xml index 09843102c..3c50e6ae8 100644 --- a/src/it/userPrefs/pom.xml +++ b/src/it/userPrefs/pom.xml @@ -19,7 +19,7 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> 4.0.0 - findbugs-maven-plugin.it + spotbugs-maven-plugin.it common testing ../common.xml @@ -31,11 +31,11 @@ true - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${project.basedir}/edu.umd.cs.findbugs.core.prefs - true + true true ${bugInstance}") @@ -452,7 +452,7 @@ class FindbugsReportGenerator implements FindBugsInfo { // priority sink.tableCell() - sink.text(findbugsPriority[priority.toInteger()]) + sink.text(spotbugsPriority[priority.toInteger()]) sink.tableCell_() sink.tableRow_() @@ -489,7 +489,7 @@ class FindbugsReportGenerator implements FindBugsInfo { if ( new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) - prefix = prefix ? prefix + FindBugsInfo.URL_SEPARATOR + xrefLocation.getName() + FindBugsInfo.URL_SEPARATOR : FindBugsInfo.PERIOD + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD return } } @@ -499,7 +499,7 @@ class FindbugsReportGenerator implements FindBugsInfo { if ( new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) - prefix = prefix ? prefix + FindBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + FindBugsInfo.URL_SEPARATOR : FindBugsInfo.PERIOD + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD return } } @@ -622,22 +622,22 @@ class FindbugsReportGenerator implements FindBugsInfo { // files sink.tableCell() - sink.text(findbugsResults.FindBugsSummary.@total_classes.text()) + sink.text(spotbugsResults.FindBugsSummary.@total_classes.text()) sink.tableCell_() // bug sink.tableCell() - sink.text(findbugsResults.FindBugsSummary.@total_bugs.text()) + sink.text(spotbugsResults.FindBugsSummary.@total_bugs.text()) sink.tableCell_() // Errors sink.tableCell() - sink.text(findbugsResults.Errors.@errors.text()) + sink.text(spotbugsResults.Errors.@errors.text()) sink.tableCell_() // Missing Classes sink.tableCell() - sink.text(findbugsResults.Errors.@missingClasses.text()) + sink.text(spotbugsResults.Errors.@missingClasses.text()) sink.tableCell_() sink.tableRow_() @@ -680,7 +680,7 @@ class FindbugsReportGenerator implements FindBugsInfo { sink.tableRow_() - findbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> + spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> def classStatsValue = classStats.'@class'.text() def classStatsBugCount = classStats.'@bugs'.text() @@ -733,7 +733,7 @@ class FindbugsReportGenerator implements FindBugsInfo { } /** - * Return the value to display. If FindBugs does not provide a line number, a default message is returned. The line + * Return the value to display. If SpotBugs does not provide a line number, a default message is returned. The line * number otherwise. * * @param line diff --git a/src/main/groovy/org/codehaus/mojo/findbugs/FindbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy similarity index 79% rename from src/main/groovy/org/codehaus/mojo/findbugs/FindbugsViolationCheckMojo.groovy rename to src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index f4cffe857..1504b95d4 100644 --- a/src/main/groovy/org/codehaus/mojo/findbugs/FindbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -1,4 +1,4 @@ -package org.codehaus.mojo.findbugs +package org.codehaus.mojo.spotbugs /* * Licensed to the Apache Software Foundation (ASF) under one @@ -36,9 +36,9 @@ import org.codehaus.plexus.resource.ResourceManager import org.codehaus.plexus.util.FileUtils /** - * Fail the build if there were any FindBugs violations in the source code. + * Fail the build if there were any SpotBugs violations in the source code. * An XML report is put out by default in the target directory with the errors. - * To see more documentation about FindBugs' options, please see the FindBugs Manual.. + * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. * * @since 2.0 * @@ -46,8 +46,8 @@ import org.codehaus.plexus.util.FileUtils */ @Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true ) -@Execute( goal = "findbugs") -class FindbugsViolationCheckMojo extends AbstractMojo { +@Execute( goal = "spotbugs") +class SpotbugsViolationCheckMojo extends AbstractMojo { /** * Location where generated html will be created. @@ -57,11 +57,11 @@ class FindbugsViolationCheckMojo extends AbstractMojo { File outputDirectory /** - * Turn on and off xml output of the Findbugs report. + * Turn on and off xml output of the Spotbugs report. * * @since 1.0.0 */ - @Parameter( defaultValue = "false", property="findbugs.xmlOutput", required = true ) + @Parameter( defaultValue = "false", property="spotbugs.xmlOutput", required = true ) boolean xmlOutput /** @@ -85,15 +85,15 @@ class FindbugsViolationCheckMojo extends AbstractMojo { */ @Deprecated @Parameter( defaultValue = "true" ) - boolean findbugsXmlOutput + boolean spotbugsXmlOutput /** - * Specifies the directory where the findbugs native xml output will be generated. + * Specifies the directory where the spotbugs native xml output will be generated. * * @since 1.2.0 */ @Parameter( defaultValue = '${project.build.directory}', required = true ) - File findbugsXmlOutputDirectory + File spotbugsXmlOutputDirectory /** * Doxia Site Renderer. @@ -102,13 +102,13 @@ class FindbugsViolationCheckMojo extends AbstractMojo { Renderer siteRenderer /** - * Directory containing the class files for FindBugs to analyze. + * Directory containing the class files for SpotBugs to analyze. */ @Parameter( defaultValue = '${project.build.outputDirectory}', required = true ) File classFilesDirectory /** - * Directory containing the test class files for FindBugs to analyze. + * Directory containing the test class files for SpotBugs to analyze. * */ @Parameter( defaultValue = '${project.build.testOutputDirectory}', required = true ) @@ -144,15 +144,15 @@ class FindbugsViolationCheckMojo extends AbstractMojo { List testSourceRoots /** - * Run Findbugs on the tests. + * Run Spotbugs on the tests. * * @since 2.0 */ - @Parameter( defaultValue = "false", property="findbugs.includeTests" ) + @Parameter( defaultValue = "false", property="spotbugs.includeTests" ) boolean includeTests /** - * List of artifacts this plugin depends on. Used for resolving the Findbugs coreplugin. + * List of artifacts this plugin depends on. Used for resolving the Spotbugs coreplugin. * */ @Parameter( property="plugin.artifacts", required = true, readonly = true ) @@ -208,7 +208,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * Threshold of minimum bug severity to report. Valid values are High, Default, Low, Ignore, and Exp (for experimental). * */ - @Parameter( defaultValue = "Default", property="findbugs.threshold" ) + @Parameter( defaultValue = "Default", property="spotbugs.threshold" ) String threshold /** @@ -230,12 +230,12 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} - * directory before being passed to Findbugs as a filter file. + * directory before being passed to Spotbugs as a filter file. *

* * @since 1.0-beta-1 */ - @Parameter( property="findbugs.includeFilterFile" ) + @Parameter( property="spotbugs.includeFilterFile" ) String includeFilterFile /** @@ -251,12 +251,12 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} - * directory before being passed to Findbugs as a filter file. + * directory before being passed to Spotbugs as a filter file. *

* * @since 1.0-beta-1 */ - @Parameter( property="findbugs.excludeFilterFile" ) + @Parameter( property="spotbugs.excludeFilterFile" ) String excludeFilterFile /** @@ -272,14 +272,14 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} - * directory before being passed to Findbugs as a filter file. + * directory before being passed to Spotbugs as a filter file. *

* * This is a comma-delimited list. * * @since 2.4.1 */ - @Parameter( property="findbugs.excludeBugsFile" ) + @Parameter( property="spotbugs.excludeBugsFile" ) String excludeBugsFile /** @@ -287,14 +287,14 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( defaultValue = "Default", property="findbugs.effort" ) + @Parameter( defaultValue = "Default", property="spotbugs.effort" ) String effort /** - * turn on Findbugs debugging + * turn on Spotbugs debugging * */ - @Parameter( defaultValue = "false", property="findbugs.debug" ) + @Parameter( defaultValue = "false", property="spotbugs.debug" ) Boolean debug /** @@ -303,7 +303,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( defaultValue = "false", property="findbugs.relaxed" ) + @Parameter( defaultValue = "false", property="spotbugs.relaxed" ) Boolean relaxed /** @@ -311,7 +311,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="findbugs.visitors" ) + @Parameter( property="spotbugs.visitors" ) String visitors /** @@ -319,7 +319,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="findbugs.omitVisitors" ) + @Parameter( property="spotbugs.omitVisitors" ) String omitVisitors /** @@ -335,12 +335,12 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} - * directory before being passed to Findbugs as a plugin file. + * directory before being passed to Spotbugs as a plugin file. *

* * @since 1.0-beta-1 */ - @Parameter( property="findbugs.pluginList" ) + @Parameter( property="spotbugs.pluginList" ) String pluginList /** @@ -348,7 +348,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( property="findbugs.onlyAnalyze" ) + @Parameter( property="spotbugs.onlyAnalyze" ) String onlyAnalyze /** @@ -357,7 +357,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.3.2 */ - @Parameter( property="findbugs.nested", defaultValue = "false" ) + @Parameter( property="spotbugs.nested", defaultValue = "false" ) Boolean nested /** @@ -366,7 +366,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.3.2 */ - @Parameter( property="findbugs.trace", defaultValue = "false" ) + @Parameter( property="spotbugs.trace", defaultValue = "false" ) Boolean trace /** @@ -374,7 +374,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="findbugs.maxRank" ) + @Parameter( property="spotbugs.maxRank" ) int maxRank /** @@ -382,7 +382,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( property="findbugs.skip", defaultValue = "false" ) + @Parameter( property="spotbugs.skip", defaultValue = "false" ) boolean skip /** @@ -404,15 +404,15 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.0 */ - @Parameter( property="findbugs.failOnError", defaultValue = "true" ) + @Parameter( property="spotbugs.failOnError", defaultValue = "true" ) boolean failOnError /** - * Fork a VM for FindBugs analysis. This will allow you to set timeouts and heap size + * Fork a VM for SpotBugs analysis. This will allow you to set timeouts and heap size * * @since 2.3.2 */ - @Parameter( property="findbugs.fork", defaultValue = "true" ) + @Parameter( property="spotbugs.fork", defaultValue = "true" ) boolean fork /** @@ -421,18 +421,18 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.2 */ - @Parameter( property="findbugs.maxHeap", defaultValue = "512" ) + @Parameter( property="spotbugs.maxHeap", defaultValue = "512" ) int maxHeap /** - * Specifies the amount of time, in milliseconds, that FindBugs may run before + * Specifies the amount of time, in milliseconds, that SpotBugs may run before * it is assumed to be hung and is terminated. * The default is 600,000 milliseconds, which is ten minutes. * This only works if the fork parameter is set true. * * @since 2.2 */ - @Parameter( property="findbugs.timeout", defaultValue = "600000" ) + @Parameter( property="spotbugs.timeout", defaultValue = "600000" ) int timeout /** @@ -442,7 +442,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="findbugs.jvmArgs" ) + @Parameter( property="spotbugs.jvmArgs" ) String jvmArgs int bugCount @@ -453,25 +453,25 @@ class FindbugsViolationCheckMojo extends AbstractMojo { Locale locale = Locale.getDefault() List sourceFiles - log.debug("Executing findbugs:check") + log.debug("Executing spotbugs:check") if ( this.classFilesDirectory.exists() && this.classFilesDirectory.isDirectory() ) { - sourceFiles = FileUtils.getFiles(classFilesDirectory, FindBugsInfo.JAVA_REGEX_PATTERN, null) + sourceFiles = FileUtils.getFiles(classFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null) } if ( !skip && sourceFiles ) { // this goes - log.debug("Here goes...............Executing findbugs:check") + log.debug("Here goes...............Executing spotbugs:check") - if (!findbugsXmlOutputDirectory.exists()) { - if ( !findbugsXmlOutputDirectory.mkdirs() ) { + if (!spotbugsXmlOutputDirectory.exists()) { + if ( !spotbugsXmlOutputDirectory.mkdirs() ) { throw new MojoExecutionException("Cannot create xml output directory") } } - File outputFile = new File("${findbugsXmlOutputDirectory}/findbugsXml.xml") + File outputFile = new File("${spotbugsXmlOutputDirectory}/spotbugsXml.xml") if (outputFile.exists()) { @@ -497,10 +497,10 @@ class FindbugsViolationCheckMojo extends AbstractMojo { log.info('Total bugs: ' + total) for (i in 0..total-1) { def bug = bugs[i] - log.info( bug.LongMessage.text() + FindBugsInfo.BLANK + bug.SourceLine.'@classname' + FindBugsInfo.BLANK + bug.SourceLine.Message.text() + FindBugsInfo.BLANK + bug.'@type') + log.info( bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type') } - log.info('\n\n\nTo see bug detail using the Findbugs GUI, use the following command "mvn findbugs:gui"\n\n\n') + log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n') if ( (bugCount || errorCount) && failOnError ) { throw new MojoExecutionException("failed with ${bugCount} bugs and ${errorCount} errors ") @@ -508,7 +508,7 @@ class FindbugsViolationCheckMojo extends AbstractMojo { } } else { - log.debug("Nothing for FindBugs to do here.") + log.debug("Nothing for SpotBugs to do here.") } } diff --git a/src/main/groovy/org/codehaus/mojo/findbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy similarity index 82% rename from src/main/groovy/org/codehaus/mojo/findbugs/XDocsReporter.groovy rename to src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 8fe5bbb22..ff7264eb8 100644 --- a/src/main/groovy/org/codehaus/mojo/findbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -1,4 +1,4 @@ -package org.codehaus.mojo.findbugs +package org.codehaus.mojo.spotbugs /* * Licensed to the Apache Software Foundation (ASF) under one @@ -25,7 +25,7 @@ import groovy.xml.StreamingMarkupBuilder /** - * The reporter controls the generation of the FindBugs report. + * The reporter controls the generation of the Spotbugs report. * * @author Garvin LeClaire */ @@ -36,7 +36,7 @@ class XDocsReporter { * The key to get the value if the line number is not available. * */ - static final String NOLINE_KEY = "report.findbugs.noline" + static final String NOLINE_KEY = "report.spotbugs.noline" /** * The bundle to get the messages from. @@ -68,7 +68,7 @@ class XDocsReporter { */ Writer outputWriter - GPathResult findbugsResults + GPathResult spotbugsResults List bugClasses @@ -101,7 +101,7 @@ class XDocsReporter { this.outputEncoding = outputEncoding this.outputWriter = null - this.findbugsResults = null + this.spotbugsResults = null this.compileSourceRoots = [] this.testSourceRoots = [] @@ -143,13 +143,13 @@ class XDocsReporter { } /** - * Gets the Findbugs Version of the report. + * Gets the Spotbugs Version of the report. * - * @return The Findbugs Version used on the report. + * @return The Spotbugs Version used on the report. * */ - protected String getFindBugsVersion() { - return edu.umd.cs.findbugs.Version.RELEASE + protected String getSpotBugsVersion() { + return edu.umd.cs.findbugs.Version.VERSION_STRING } public void generateReport() { @@ -159,13 +159,13 @@ class XDocsReporter { def xdoc = { mkp.xmlDeclaration() - log.debug("generateReport findbugsResults is ${findbugsResults}") + log.debug("generateReport spotbugsResults is ${spotbugsResults}") - BugCollection(version: getFindBugsVersion(), threshold: FindBugsInfo.findbugsThresholds.get(threshold), effort: FindBugsInfo.findbugsEfforts.get(effort)) { + BugCollection(version: getSpotBugsVersion(), threshold: SpotBugsInfo.spotbugsThresholds.get(threshold), effort: SpotBugsInfo.spotbugsEfforts.get(effort)) { - log.debug("findbugsResults.FindBugsSummary total_bugs is ${findbugsResults.FindBugsSummary.@total_bugs.text()}") + log.debug("spotbugsResults.FindBugsSummary total_bugs is ${spotbugsResults.FindBugsSummary.@total_bugs.text()}") - findbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> + spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> def classStatsValue = classStats.'@class'.text() def classStatsBugCount = classStats.'@bugs'.text() @@ -182,7 +182,7 @@ class XDocsReporter { bugClasses.each() {bugClass -> log.debug("finish bugClass is ${bugClass}") file(classname: bugClass) { - findbugsResults.BugInstance.each() {bugInstance -> + spotbugsResults.BugInstance.each() {bugInstance -> if ( bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass ) { @@ -201,13 +201,13 @@ class XDocsReporter { log.debug("Printing Errors") Error() { - findbugsResults.Error.analysisError.each() {analysisError -> + spotbugsResults.Error.analysisError.each() {analysisError -> AnalysisError(analysisError.message.text()) } log.debug("Printing Missing classes") - findbugsResults.Error.MissingClass.each() {missingClass -> + spotbugsResults.Error.MissingClass.each() {missingClass -> MissingClass(missingClass.text) } } diff --git a/src/main/resources/findbugs.properties b/src/main/resources/findbugs.properties deleted file mode 100644 index f1c1ce155..000000000 --- a/src/main/resources/findbugs.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Category -report.findbugs.column.class=Class -report.findbugs.column.classes=Classes -report.findbugs.column.details=Details -report.findbugs.column.errors=Errors -report.findbugs.column.files=Files -report.findbugs.column.missingclasses=Missing Classes -report.findbugs.column.line=Line -report.findbugs.column.priority=Priority -report.findbugs.description=Generates a source code report with the FindBugs Library. -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.files=Files -report.findbugs.summary=Summary -report.findbugs.javasources=Found java sources (Class files): -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=The following document contains the results of -report.findbugs.name=FindBugs -report.findbugs.noline=Not available -report.findbugs.reporttitle=FindBugs Bug Detector Report -report.findbugs.sourceRoot=Using source root: -report.findbugs.testSourceRoot=Using test source root: -report.findbugs.threshold=Threshold is -report.findbugs.effort=Effort is -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.versiontitle=FindBugs Version is -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/findbugs_en.properties b/src/main/resources/findbugs_en.properties deleted file mode 100644 index f1c1ce155..000000000 --- a/src/main/resources/findbugs_en.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Category -report.findbugs.column.class=Class -report.findbugs.column.classes=Classes -report.findbugs.column.details=Details -report.findbugs.column.errors=Errors -report.findbugs.column.files=Files -report.findbugs.column.missingclasses=Missing Classes -report.findbugs.column.line=Line -report.findbugs.column.priority=Priority -report.findbugs.description=Generates a source code report with the FindBugs Library. -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.files=Files -report.findbugs.summary=Summary -report.findbugs.javasources=Found java sources (Class files): -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=The following document contains the results of -report.findbugs.name=FindBugs -report.findbugs.noline=Not available -report.findbugs.reporttitle=FindBugs Bug Detector Report -report.findbugs.sourceRoot=Using source root: -report.findbugs.testSourceRoot=Using test source root: -report.findbugs.threshold=Threshold is -report.findbugs.effort=Effort is -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.versiontitle=FindBugs Version is -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/findbugs_es.properties b/src/main/resources/findbugs_es.properties deleted file mode 100644 index 8359ef065..000000000 --- a/src/main/resources/findbugs_es.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Categoría -report.findbugs.column.class=Clase -report.findbugs.column.classes=Clases -report.findbugs.column.details=Detalles -report.findbugs.column.errors=Errores -report.findbugs.column.files=Archivos -report.findbugs.column.missingclasses=Classes Faltantes -report.findbugs.column.line=Línea -report.findbugs.column.priority=Prioridad -report.findbugs.description=Genera un reporte del código fuente con la Librería FindBugs. -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.files=Archivos -report.findbugs.summary=Resumen -report.findbugs.javasources=Fuentes java encontrados (Archivos class): -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=El siguiente documento contiene los resultados de -report.findbugs.name=FindBugs -report.findbugs.noline=No disponible -report.findbugs.reporttitle=Reporte FindBugs Bug Detector -report.findbugs.sourceRoot=Utilizando raíz de fuentes: -report.findbugs.testSourceRoot=Utilizando raíz de fuentes de test: -report.findbugs.threshold=El umbral es -report.findbugs.effort=El esfuerzo es -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.versiontitle=La versión de FindBugs es -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/findbugs_fr.properties b/src/main/resources/findbugs_fr.properties deleted file mode 100644 index 574f39e60..000000000 --- a/src/main/resources/findbugs_fr.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Cat\u00e9gorie -report.findbugs.column.class=Classe -report.findbugs.column.classes=Classes -report.findbugs.column.details=D\u00e9tails -report.findbugs.column.errors=Erreurs -report.findbugs.column.files=Fichiers -report.findbugs.column.missingclasses=Classes Manquantes -report.findbugs.column.line=Ligne -report.findbugs.column.priority=Priorit\u00e9 -report.findbugs.description=G\u00e9n\u00e8re un rapport du code source avec la librairie FindBugs. -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.files=Fichiers -report.findbugs.summary=R\u00e9sum\u00e9 -report.findbugs.javasources=Sources java trouv\u00e9es (Classes): -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=Le document suivant contient les r\u00e9sultats du -report.findbugs.name=FindBugs -report.findbugs.noline=Non disponible -report.findbugs.reporttitle=Rapport FindBugs de d\u00e9tection des bugs -report.findbugs.sourceRoot=Utilise la racine des sources : -report.findbugs.testSourceRoot=Utilise la racine des sources de test : -report.findbugs.threshold=La limite est -report.findbugs.effort=L'effort est -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.versiontitle=La version de FindBugs est -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/findbugs_no_NO.properties b/src/main/resources/findbugs_no_NO.properties deleted file mode 100644 index bd9928c36..000000000 --- a/src/main/resources/findbugs_no_NO.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Kategori -report.findbugs.column.class=Klasse -report.findbugs.column.classes=Klasser -report.findbugs.column.details=Detaljer -report.findbugs.column.errors=Feil -report.findbugs.column.files=Filer -report.findbugs.column.missingclasses=Manglende Klasser -report.findbugs.column.line=Linje -report.findbugs.column.priority=Prioritet -report.findbugs.description=Genererer en kildekode rapport med FindBugs biblioteket -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.files=Filer -report.findbugs.summary=Sammendrag -report.findbugs.javasources=Fant java kildefiler (Klasse files): -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=Dokumentet best�r av f�lgende resultater -report.findbugs.name=FindBugs -report.findbugs.noline=Ikke tilgjengelig -report.findbugs.reporttitle=FindBugs Bug Deteksjons Report -report.findbugs.sourceRoot=Bruker kildetre: -report.findbugs.testSourceRoot=Bruker test kildetre: -report.findbugs.threshold=Grenseverdi er -report.findbugs.effort=Innsatsvilje er -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.versiontitle=FindBugs Versjon er -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/findbugs_pt_BR.properties b/src/main/resources/findbugs_pt_BR.properties deleted file mode 100644 index 896483a45..000000000 --- a/src/main/resources/findbugs_pt_BR.properties +++ /dev/null @@ -1,28 +0,0 @@ -report.findbugs.column.bug=Bug -report.findbugs.column.bugs=Bugs -report.findbugs.column.category=Categoria -report.findbugs.column.class=Classe -report.findbugs.column.classes=Classes -report.findbugs.column.details=Detalhes -report.findbugs.column.errors=Erros -report.findbugs.column.files=Arquivos -report.findbugs.column.line=Linhas -report.findbugs.column.missingclasses=Classes n\u00E3o Encontradas -report.findbugs.column.priority=Prioridade -report.findbugs.description=Gera um relat\u00F3rio do c\u00F3digo fonte utilizando o FindBugs. -report.findbugs.detailslink=http://findbugs.sourceforge.net/bugDescriptions.html -report.findbugs.effort=Esfor\u00E7o\: -report.findbugs.files=Arquivos -report.findbugs.javasources=C\u00F3digo Java encontrado\: -report.findbugs.jxrplugin.artifactid=maven-jxr-plugin -report.findbugs.link=http://findbugs.sourceforge.net -report.findbugs.linktitle=O seguinte documento cont\u00E9m os resultados do -report.findbugs.name=FindBugs -report.findbugs.noline=Indispon\u00EDvel -report.findbugs.reporttitle=Relat\u00F3rio do FindBugs Bug Detector -report.findbugs.sourceRoot=Verificando c\u00F3digo a partir de\: -report.findbugs.summary=Sum\u00E1rio -report.findbugs.testSourceRoot=Verificando c\u00F3digo de testes a partir de\: -report.findbugs.threshold=Limite\: -report.findbugs.versiontitle=A vers\u00E3o do FindBugs \u00E9 a -report.findbugs.coreplugin=findbugs diff --git a/src/main/resources/spotbugs.properties b/src/main/resources/spotbugs.properties new file mode 100644 index 000000000..e783fe99b --- /dev/null +++ b/src/main/resources/spotbugs.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Category +report.spotbugs.column.class=Class +report.spotbugs.column.classes=Classes +report.spotbugs.column.details=Details +report.spotbugs.column.errors=Errors +report.spotbugs.column.files=Files +report.spotbugs.column.missingclasses=Missing Classes +report.spotbugs.column.line=Line +report.spotbugs.column.priority=Priority +report.spotbugs.description=Generates a source code report with the SpotBugs Library. +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.files=Files +report.spotbugs.summary=Summary +report.spotbugs.javasources=Found java sources (Class files): +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=The following document contains the results of +report.spotbugs.name=SpotBugs +report.spotbugs.noline=Not available +report.spotbugs.reporttitle=SpotBugs Bug Detector Report +report.spotbugs.sourceRoot=Using source root: +report.spotbugs.testSourceRoot=Using test source root: +report.spotbugs.threshold=Threshold is +report.spotbugs.effort=Effort is +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.versiontitle=SpotBugs Version is +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/resources/spotbugs_en.properties b/src/main/resources/spotbugs_en.properties new file mode 100644 index 000000000..e783fe99b --- /dev/null +++ b/src/main/resources/spotbugs_en.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Category +report.spotbugs.column.class=Class +report.spotbugs.column.classes=Classes +report.spotbugs.column.details=Details +report.spotbugs.column.errors=Errors +report.spotbugs.column.files=Files +report.spotbugs.column.missingclasses=Missing Classes +report.spotbugs.column.line=Line +report.spotbugs.column.priority=Priority +report.spotbugs.description=Generates a source code report with the SpotBugs Library. +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.files=Files +report.spotbugs.summary=Summary +report.spotbugs.javasources=Found java sources (Class files): +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=The following document contains the results of +report.spotbugs.name=SpotBugs +report.spotbugs.noline=Not available +report.spotbugs.reporttitle=SpotBugs Bug Detector Report +report.spotbugs.sourceRoot=Using source root: +report.spotbugs.testSourceRoot=Using test source root: +report.spotbugs.threshold=Threshold is +report.spotbugs.effort=Effort is +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.versiontitle=SpotBugs Version is +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/resources/spotbugs_es.properties b/src/main/resources/spotbugs_es.properties new file mode 100644 index 000000000..dde97b91e --- /dev/null +++ b/src/main/resources/spotbugs_es.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Categoría +report.spotbugs.column.class=Clase +report.spotbugs.column.classes=Clases +report.spotbugs.column.details=Detalles +report.spotbugs.column.errors=Errores +report.spotbugs.column.files=Archivos +report.spotbugs.column.missingclasses=Classes Faltantes +report.spotbugs.column.line=Línea +report.spotbugs.column.priority=Prioridad +report.spotbugs.description=Genera un reporte del código fuente con la Librería SpotBugs. +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.files=Archivos +report.spotbugs.summary=Resumen +report.spotbugs.javasources=Fuentes java encontrados (Archivos class): +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=El siguiente documento contiene los resultados de +report.spotbugs.name=SpotBugs +report.spotbugs.noline=No disponible +report.spotbugs.reporttitle=Reporte SpotBugs Bug Detector +report.spotbugs.sourceRoot=Utilizando raíz de fuentes: +report.spotbugs.testSourceRoot=Utilizando raíz de fuentes de test: +report.spotbugs.threshold=El umbral es +report.spotbugs.effort=El esfuerzo es +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.versiontitle=La versión de SpotBugs es +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/resources/spotbugs_fr.properties b/src/main/resources/spotbugs_fr.properties new file mode 100644 index 000000000..f4ac3c118 --- /dev/null +++ b/src/main/resources/spotbugs_fr.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Cat\u00e9gorie +report.spotbugs.column.class=Classe +report.spotbugs.column.classes=Classes +report.spotbugs.column.details=D\u00e9tails +report.spotbugs.column.errors=Erreurs +report.spotbugs.column.files=Fichiers +report.spotbugs.column.missingclasses=Classes Manquantes +report.spotbugs.column.line=Ligne +report.spotbugs.column.priority=Priorit\u00e9 +report.spotbugs.description=G\u00e9n\u00e8re un rapport du code source avec la librairie SpotBugs. +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.files=Fichiers +report.spotbugs.summary=R\u00e9sum\u00e9 +report.spotbugs.javasources=Sources java trouv\u00e9es (Classes): +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=Le document suivant contient les r\u00e9sultats du +report.spotbugs.name=SpotBugs +report.spotbugs.noline=Non disponible +report.spotbugs.reporttitle=Rapport SpotBugs de d\u00e9tection des bugs +report.spotbugs.sourceRoot=Utilise la racine des sources : +report.spotbugs.testSourceRoot=Utilise la racine des sources de test : +report.spotbugs.threshold=La limite est +report.spotbugs.effort=L'effort est +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.versiontitle=La version de SpotBugs est +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/resources/spotbugs_no_NO.properties b/src/main/resources/spotbugs_no_NO.properties new file mode 100644 index 000000000..e67586710 --- /dev/null +++ b/src/main/resources/spotbugs_no_NO.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Kategori +report.spotbugs.column.class=Klasse +report.spotbugs.column.classes=Klasser +report.spotbugs.column.details=Detaljer +report.spotbugs.column.errors=Feil +report.spotbugs.column.files=Filer +report.spotbugs.column.missingclasses=Manglende Klasser +report.spotbugs.column.line=Linje +report.spotbugs.column.priority=Prioritet +report.spotbugs.description=Genererer en kildekode rapport med SpotBugs biblioteket +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.files=Filer +report.spotbugs.summary=Sammendrag +report.spotbugs.javasources=Fant java kildefiler (Klasse files): +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=Dokumentet best�r av f�lgende resultater +report.spotbugs.name=SpotBugs +report.spotbugs.noline=Ikke tilgjengelig +report.spotbugs.reporttitle=SpotBugs Bug Deteksjons Report +report.spotbugs.sourceRoot=Bruker kildetre: +report.spotbugs.testSourceRoot=Bruker test kildetre: +report.spotbugs.threshold=Grenseverdi er +report.spotbugs.effort=Innsatsvilje er +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.versiontitle=SpotBugs Versjon er +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/resources/spotbugs_pt_BR.properties b/src/main/resources/spotbugs_pt_BR.properties new file mode 100644 index 000000000..145bcee16 --- /dev/null +++ b/src/main/resources/spotbugs_pt_BR.properties @@ -0,0 +1,28 @@ +report.spotbugs.column.bug=Bug +report.spotbugs.column.bugs=Bugs +report.spotbugs.column.category=Categoria +report.spotbugs.column.class=Classe +report.spotbugs.column.classes=Classes +report.spotbugs.column.details=Detalhes +report.spotbugs.column.errors=Erros +report.spotbugs.column.files=Arquivos +report.spotbugs.column.line=Linhas +report.spotbugs.column.missingclasses=Classes n\u00E3o Encontradas +report.spotbugs.column.priority=Prioridade +report.spotbugs.description=Gera um relat\u00F3rio do c\u00F3digo fonte utilizando o SpotBugs. +report.spotbugs.detailslink=https://spotbugs.readthedocs.io/en/latest/bugDescriptions.html +report.spotbugs.effort=Esfor\u00E7o\: +report.spotbugs.files=Arquivos +report.spotbugs.javasources=C\u00F3digo Java encontrado\: +report.spotbugs.jxrplugin.artifactid=maven-jxr-plugin +report.spotbugs.link=https://spotbugs.github.io/ +report.spotbugs.linktitle=O seguinte documento cont\u00E9m os resultados do +report.spotbugs.name=SpotBugs +report.spotbugs.noline=Indispon\u00EDvel +report.spotbugs.reporttitle=Relat\u00F3rio do SpotBugs Bug Detector +report.spotbugs.sourceRoot=Verificando c\u00F3digo a partir de\: +report.spotbugs.summary=Sum\u00E1rio +report.spotbugs.testSourceRoot=Verificando c\u00F3digo de testes a partir de\: +report.spotbugs.threshold=Limite\: +report.spotbugs.versiontitle=A vers\u00E3o do SpotBugs \u00E9 a +report.spotbugs.coreplugin=spotbugs diff --git a/src/main/tools/annotations.pom b/src/main/tools/annotations.pom deleted file mode 100644 index 43daaa5b6..000000000 --- a/src/main/tools/annotations.pom +++ /dev/null @@ -1,22 +0,0 @@ - - 4.0.0 - com.google.code.findbugs - annotations - @findbugs.version@ - jar - http://findbugs.sourceforge.net/ - FindBugs-Annotations - Annotation supports the FindBugs tool - - - GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html - repo - - - - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ - - diff --git a/src/main/tools/bcel.pom b/src/main/tools/bcel.pom deleted file mode 100644 index 6f6191479..000000000 --- a/src/main/tools/bcel.pom +++ /dev/null @@ -1,22 +0,0 @@ - - 4.0.0 - com.google.code.findbugs - bcel - @findbugs.version@ - jar - http://findbugs.sourceforge.net/ - FindBugs-bcel - Modified BCEL for Findbugs - - - The Apache Software License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt - repo - - - - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ - - diff --git a/src/main/tools/fb2bundle.groovy b/src/main/tools/fb2bundle.groovy index 118a69884..c91997e21 100644 --- a/src/main/tools/fb2bundle.groovy +++ b/src/main/tools/fb2bundle.groovy @@ -1,15 +1,15 @@ #!/usr/bin/env groovy -def cli = new CliBuilder(usage:'fb2bundle -f findbugs.home -version version') +def cli = new CliBuilder(usage:'fb2bundle -f spotbugs.home -version version') cli.h(longOpt: 'help', 'usage information') -cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Findbugs version') +cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version') def opt = cli.parse(args) if (!opt) { return } if (opt.h) opt.usage() -def findbugsVersion = opt.v +def spotbugsVersion = opt.v -println "findbugsVersion is ${findbugsVersion}" +println "spotbugsVersion is ${spotbugsVersion}" println "Done parsing" def cmdPrefix = """""" @@ -18,11 +18,11 @@ println "os.name is " + System.getProperty("os.name") if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """ -def modules = ["annotations", "bcel", "findbugs", "findbugs-ant", "jFormatString", "jsr305" ] +def modules = ["spotbugs-annotations", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ] modules.each(){ module -> println "Processing ${module}........" - cmd = cmdPrefix + """mvn repository:bundle-pack -B -DgroupId=com.google.code.findbugs -DartifactId=${module} -Dversion=${findbugsVersion}""" + cmd = cmdPrefix + """mvn repository:bundle-pack -B -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion}""" proc = cmd.execute() println proc.text } diff --git a/src/main/tools/fb2local.groovy b/src/main/tools/fb2local.groovy index 6c33a8de8..a2f94c859 100644 --- a/src/main/tools/fb2local.groovy +++ b/src/main/tools/fb2local.groovy @@ -1,23 +1,21 @@ #!groovy -// fb2local -f /opt/findbugs/findbugs-2.0.0-rc2 -v 2.0.0-rc2 - -def findbugsHome = System.getenv("FINDBUGS_HOME") +def spotbugsHome = System.getenv("SPOTBUGS_HOME") def antBuilder = new AntBuilder() -def cli = new CliBuilder(usage:'fb2local -f findbugs.home -version version') +def cli = new CliBuilder(usage:'fb2local -f spotbugs.home -version version') cli.h(longOpt: 'help', 'usage information') -cli.f(argName: 'home', longOpt: 'home', required: false, args: 1, type:GString, 'Findbugs home directory') -cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Findbugs version') +cli.f(argName: 'home', longOpt: 'home', required: false, args: 1, type:GString, 'Spotbugs home directory') +cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version') def opt = cli.parse(args) if (!opt) { return } if (opt.h) opt.usage() -if (opt.f) findbugsHome = opt.f -def findbugsVersion = opt.v +if (opt.f) spotbugsHome = opt.f +def spotbugsVersion = opt.v -println "findbugsHome is ${findbugsHome}" -println "findbugsVersion is ${findbugsVersion}" +println "spotbugsHome is ${spotbugsHome}" +println "spotbugsVersion is ${spotbugsVersion}" println "Done parsing" def cmdPrefix = """""" @@ -26,16 +24,16 @@ println "os.name is " + System.getProperty("os.name") if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """ -def modules = ["annotations", "bcel", "findbugs", "findbugs-ant", "jFormatString", "jsr305" ] +def modules = ["spotbugs-annotations", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ] modules.each(){ module -> antBuilder.copy(file: new File("${module}.pom"), toFile: new File("${module}.xml"), overwrite: true ) { filterset() { - filter(token: "findbugs.version", value: "${findbugsVersion}") + filter(token: "spotbugs.version", value: "${spotbugsVersion}") } } - cmd = cmdPrefix + """mvn install:install-file -DpomFile=${module}.xml -Dfile=${findbugsHome}/lib/${module}.jar -DgroupId=com.google.code.findbugs -DartifactId=${module} -Dversion=${findbugsVersion} -Dpackaging=jar""" + cmd = cmdPrefix + """mvn install:install-file -DpomFile=${module}.xml -Dfile=${spotbugsHome}/lib/${module}.jar -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion} -Dpackaging=jar""" proc = cmd.execute() println proc.text } diff --git a/src/main/tools/fb2repo.groovy b/src/main/tools/fb2repo.groovy index 88f7bd011..c0f49fcea 100644 --- a/src/main/tools/fb2repo.groovy +++ b/src/main/tools/fb2repo.groovy @@ -1,26 +1,23 @@ #!/usr/bin/env groovy -// fb2repo -f /opt/findbugs/findbugs-2.0.0 -v 2.0.0 -url file:///Users/user/NetBeansProjects/findbugs-repo/rc-repository -// fb2repo -f /opt/findbugs/findbugs-2.0.0 -v 2.0.0 -url file:///Users/user/NetBeansProjects/findbugs-repo/release-repository - -def findbugsHome = System.getenv("FINDBUGS_HOME") +def spotbugsHome = System.getenv("SPOTBUGS_HOME") def antBuilder = new AntBuilder() -def cli = new CliBuilder(usage:'fb2repo -f findbugs.home -version version -u repositoryURL') +def cli = new CliBuilder(usage:'fb2repo -f spotbugs.home -version version -u repositoryURL') cli.h(longOpt: 'help', 'usage information') -cli.f(argName: 'home', longOpt: 'home', required: false, args: 1, type:GString, 'Findbugs home directory') -cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Findbugs version') +cli.f(argName: 'home', longOpt: 'home', required: false, args: 1, type:GString, 'Spotbugs home directory') +cli.v(argName: 'version', longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version') cli.u(argName: 'url', longOpt: 'url', required: true, args: 1, type:GString, 'Repository URL') def opt = cli.parse(args) if (!opt) { return } if (opt.h) opt.usage() -if (opt.f) findbugsHome = opt.f -def findbugsVersion = opt.v +if (opt.f) spotbugsHome = opt.f +def spotbugsVersion = opt.v def repoUrl = opt.u -println "findbugsHome is ${findbugsHome}" -println "findbugsVersion is ${findbugsVersion}" +println "spotbugsHome is ${spotbugsHome}" +println "spotbugsVersion is ${spotbugsVersion}" println "Done parsing" def cmdPrefix = """""" @@ -29,16 +26,16 @@ println "os.name is " + System.getProperty("os.name") if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """ -def modules = ["annotations", "bcel", "findbugs", "findbugs-ant", "jFormatString", "jsr305" ] +def modules = ["annotations", "bcel", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ] modules.each(){ module -> antBuilder.copy(file: new File("${module}.pom"), toFile: new File("${module}.xml"), overwrite: true ) { filterset() { - filter(token: "findbugs.version", value: "${findbugsVersion}") + filter(token: "spotbugs.version", value: "${spotbugsVersion}") } } - cmd = cmdPrefix + """mvn deploy:deploy-file -DpomFile=${module}.xml -Dfile=${findbugsHome}/lib/${module}.jar -DgroupId=com.google.code.findbugs -DartifactId=${module} -Dversion=${findbugsVersion} -Durl=${repoUrl} -Dpackaging=jar""" + cmd = cmdPrefix + """mvn deploy:deploy-file -DpomFile=${module}.xml -Dfile=${spotbugsHome}/lib/${module}.jar -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion} -Durl=${repoUrl} -Dpackaging=jar""" proc = cmd.execute() println proc.text antBuilder.delete(file: "pom.xml") diff --git a/src/main/tools/findbugs-ant.pom b/src/main/tools/findbugs-ant.pom deleted file mode 100644 index f07dae29b..000000000 --- a/src/main/tools/findbugs-ant.pom +++ /dev/null @@ -1,29 +0,0 @@ - - 4.0.0 - com.google.code.findbugs - findbugs-ant - @findbugs.version@ - jar - http://findbugs.sourceforge.net/ - FindBugs-AntTask - AntTask to run Findbugs - - - GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html - repo - - - - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ - - - - com.google.code.findbugs - findbugs - @findbugs.version@ - - - diff --git a/src/main/tools/jFormatString.pom b/src/main/tools/jFormatString.pom index c91743a49..4c6fa38c4 100644 --- a/src/main/tools/jFormatString.pom +++ b/src/main/tools/jFormatString.pom @@ -1,12 +1,12 @@ 4.0.0 - com.google.code.findbugs + com.github.spotbugs jFormatString - @findbugs.version@ + @Spotbugs.version@ jar - http://findbugs.sourceforge.net/ - FindBugs-jFormatString - jFormatString for Findbugs + http://www.github.com/spotbugs/ + SpotBugs-jFormatString + jFormatString for Spotbugs GNU Lesser Public License @@ -15,8 +15,8 @@ - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ + scm:git:https://github.com/spotbugs/spotbugs.git + scm:git:ssh://git@github.com/spotbugs/spotbugs.git + https://github.com/spotbugs/spotbugs diff --git a/src/main/tools/jsr305.pom b/src/main/tools/jsr305.pom index 5c04c377f..c4b99c88c 100644 --- a/src/main/tools/jsr305.pom +++ b/src/main/tools/jsr305.pom @@ -1,12 +1,12 @@ 4.0.0 - com.google.code.findbugs + com.github.spotbugs jsr305 - @findbugs.version@ + @spotbugs.version@ jar - http://findbugs.sourceforge.net/ - FindBugs-jsr305 - JSR305 Annotations for Findbugs + http://spotbugs.sourceforge.net/ + SpotBugs-jsr305 + JSR305 Annotations for Spotbugs The Apache Software License, Version 2.0 @@ -15,8 +15,8 @@ - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ + scm:git:https://code.google.com/p/jsr-305/ + scm:git:https://code.google.com/p/jsr-305/ + https://code.google.com/p/jsr-305/ diff --git a/src/main/tools/spotbugs-annotations.pom b/src/main/tools/spotbugs-annotations.pom new file mode 100644 index 000000000..56d7cb307 --- /dev/null +++ b/src/main/tools/spotbugs-annotations.pom @@ -0,0 +1,23 @@ + + 4.0.0 + com.github.spotbugs + spotbugs-annotations + @spotbugs.version@ + jar + https://spotbugs.github.io/ + SpotBugs-Annotations + Annotation supports the SpotBugs tool + + + GNU Lesser Public License + http://www.gnu.org/licenses/lgpl.html + repo + + + + scm:git:https://github.com/spotbugs/spotbugs.git + scm:git:ssh://git@github.com/spotbugs/spotbugs.git + https://github.com/spotbugs/spotbugs + HEAD + + diff --git a/src/main/tools/spotbugs-ant.pom b/src/main/tools/spotbugs-ant.pom new file mode 100644 index 000000000..91566e99a --- /dev/null +++ b/src/main/tools/spotbugs-ant.pom @@ -0,0 +1,30 @@ + + 4.0.0 + com.github.spotbugs + spotbugs-ant + @spotbugs.version@ + jar + https://spotbugs.github.io/ + SpotBugs-AntTask + AntTask to run Spotbugs + + + GNU Lesser Public License + http://www.gnu.org/licenses/lgpl.html + repo + + + + scm:git:https://github.com/spotbugs/spotbugs.git + scm:git:ssh://git@github.com/spotbugs/spotbugs.git + https://github.com/spotbugs/spotbugs + HEAD + + + + com.github.spotbugs + spotbugs + @spotbugs.version@ + + + diff --git a/src/main/tools/findbugs.pom b/src/main/tools/spotbugs.pom similarity index 68% rename from src/main/tools/findbugs.pom rename to src/main/tools/spotbugs.pom index 1db057d79..128499412 100644 --- a/src/main/tools/findbugs.pom +++ b/src/main/tools/spotbugs.pom @@ -1,12 +1,12 @@ 4.0.0 - com.google.code.findbugs - findbugs - @findbugs.version@ + com.github.spotbugs + spotbugs + @spotbugs.version@ jar - http://findbugs.sourceforge.net/ - FindBugs - Findbugs: Because it's easy! + https://spotbugs.github.io/ + SpotBugs + Spotbugs: Because it's easy! GNU Lesser Public License @@ -15,30 +15,31 @@ - scm:svn:http://findbugs.googlecode.com/svn/trunk/ - scm:svn:https://findbugs.googlecode.com/svn/trunk/ - http://findbugs.googlecode.com/svn/trunk/ + scm:git:https://github.com/spotbugs/spotbugs.git + scm:git:ssh://git@github.com/spotbugs/spotbugs.git + https://github.com/spotbugs/spotbugs + HEAD - com.google.code.findbugs + com.github.spotbugs bcel - @findbugs.version@ + @spotbugs.version@ - com.google.code.findbugs + com.github.spotbugs jsr305 - @findbugs.version@ + @spotbugs.version@ - com.google.code.findbugs + com.github.spotbugs jFormatString - @findbugs.version@ + @spotbugs.version@ - com.google.code.findbugs + com.github.spotbugs annotations - @findbugs.version@ + @spotbugs.version@ dom4j diff --git a/src/site/apt/examples/multi-module-config.apt.vm b/src/site/apt/examples/multi-module-config.apt.vm index b6577808b..ca8509c8c 100644 --- a/src/site/apt/examples/multi-module-config.apt.vm +++ b/src/site/apt/examples/multi-module-config.apt.vm @@ -27,13 +27,13 @@ Multimodule Configuration - <> This implemented in version 2.0 of the Findbugs plugin. + <> This implemented in version 2.0 of the Spotbugs plugin. <> This is a shameless plagiarization of the Checkstyle plugin for consistency and due to my laziness. - Configuring the Findbugs plugin for use within large multimodule projects + Configuring the Spotbugs plugin for use within large multimodule projects can be done, but it requires a little setup. This example will use a mysterious project called . This is what @@ -56,7 +56,7 @@ whizbang We'll start by adding another sub project that will house our common configuration. Let's call it . In it we put the resources that we want to include. In this example, we will add configuration files for the - Findbugs plugin. Configuration files for other plugins, like the PMD and + Spotbugs plugin. Configuration files for other plugins, like the PMD and Checkstyle plugin, can be included in the same subproject if you like. We will create another directory and call it and create a pom.xml file. We will move our core, gui, and jmx modules to . @@ -106,7 +106,7 @@ whizbang * Configure the other projects to build-tools - Now we can include the Findbugs configuration in the whiz-progs <<>>. + Now we can include the Spotbugs configuration in the whiz-progs <<>>. +-----+ @@ -132,8 +132,8 @@ whizbang - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} Max @@ -152,10 +152,10 @@ whizbang +-----+ Once you are done with that, ensure that you do not include - findbugs-maven-plugin in your sub modules, as their definition and + spotbugs-maven-plugin in your sub modules, as their definition and configuration, will override the top level parent pom's definition. - Based on the Findbugs plugin configuration above, the values of + Based on the Spotbugs plugin configuration above, the values of <<>> will be resolved from the classpath. The jar was included in the classpath when it was declared as an dependency to the plugin. @@ -171,4 +171,4 @@ whizbang mvn site +-----+ - Every sub project will now use the same Findbugs setup and configuration. + Every sub project will now use the same Spotbugs setup and configuration. diff --git a/src/site/apt/examples/violationChecking.apt.vm b/src/site/apt/examples/violationChecking.apt.vm index 783902b31..411fda7e0 100644 --- a/src/site/apt/examples/violationChecking.apt.vm +++ b/src/site/apt/examples/violationChecking.apt.vm @@ -26,8 +26,8 @@ Violation Checking - The <<>> goal allows you to configure your build to fail if any errors are found - in the FindBugs report. + The <<>> goal allows you to configure your build to fail if any errors are found + in the SpotBugs report. The following code fragment enables the check in a build during the <<>> phase. The check will fail if any of the filter triggers in the include file are met. @@ -38,8 +38,8 @@ Violation Checking - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} Max diff --git a/src/site/apt/index.apt.vm b/src/site/apt/index.apt.vm index 9cbd18bfe..3a6c7c203 100644 --- a/src/site/apt/index.apt.vm +++ b/src/site/apt/index.apt.vm @@ -6,11 +6,11 @@ -FindBugs Maven Plugin +SpotBugs Maven Plugin -*Please Note - This version is using Findbugs ${findbugsVersion}. +*Please Note - This version is using Spotbugs ${spotbugsVersion}. - FindBugs looks for bugs in Java programs. It is based on the concept of bug patterns. A bug pattern is a code idiom that is often an error. Bug patterns arise for a variety of reasons: + SpotBugs looks for bugs in Java programs. It is based on the concept of bug patterns. A bug pattern is a code idiom that is often an error. Bug patterns arise for a variety of reasons: * Difficult language features @@ -20,16 +20,16 @@ FindBugs Maven Plugin * Garden variety mistakes: typos, use of the wrong boolean operator - FindBugs uses static analysis to inspect Java bytecode for occurrences of bug patterns. We have found that FindBugs finds real errors in most Java software. Because its analysis is sometimes imprecise, FindBugs can report false warnings, which are warnings that do not indicate real errors. In practice, the rate of false warnings reported by FindBugs is generally less than 50%. + SpotBugs uses static analysis to inspect Java bytecode for occurrences of bug patterns. We have found that SpotBugs finds real errors in most Java software. Because its analysis is sometimes imprecise, SpotBugs can report false warnings, which are warnings that do not indicate real errors. In practice, the rate of false warnings reported by SpotBugs is generally less than 50%. - FindBugs is free software, available under the terms of the Lesser GNU Public License. It is written in Java, and can be run with any virtual machine compatible with Java 7. It can analyze programs written for any version of Java. FindBugs was originally developed by Bill Pugh. It is maintained by Bill Pugh, David Hovemeyer, and a team of volunteers. + SpotBugs is free software, available under the terms of the Lesser GNU Public License. It is written in Java, and can be run with any virtual machine compatible with Java 8. It can analyze programs written for any version of Java. SpotBugs was originally developed by Bill Pugh. It is maintained by Bill Pugh, David Hovemeyer, and a team of volunteers. - FindBugs uses BCEL to analyze Java bytecode. It uses dom4j for XML manipulation. + SpotBugs uses BCEL to analyze Java bytecode. It uses dom4j for XML manipulation. - This introduction is an excerpt from the Facts Sheet at {{{http://findbugs.sourceforge.net/factSheet.html}FindBugs home page}}. + This introduction is an excerpt from the Facts Sheet at {{{http://spotbugs.sourceforge.net/factSheet.html}SpotBugs home page}}. - To see more documentation about FindBugs' options, please see the {{{http://findbugs.sourceforge.net/manual/index.html}FindBugs Manual}}. + To see more documentation about SpotBugs' options, please see the {{{http://spotbugs.sourceforge.net/manual/index.html}SpotBugs Manual}}. *Please Note - As of version 3.0.0, you will need to use JDK 7 to run this plugin. This is a requirement imposed by Findbugs. + As of version 3.1.0, you will need to use JDK 8 to run this plugin. This is a requirement imposed by Spotbugs. diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index 40013d565..67d7f321a 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -26,12 +26,12 @@ Usage ${projectVersion} - The following examples describe the basic usage of the FindBugs plugin. + The following examples describe the basic usage of the SpotBugs plugin. -* Generate FindBugs Report As Part of the Project Reports +* Generate SpotBugs Report As Part of the Project Reports - To generate the FindBugs report as part of the Project Reports, add the - FindBugs plugin in the <<<\>>> section + To generate the SpotBugs report as part of the Project Reports, add the + SpotBugs plugin in the <<<\>>> section of your <<>>. +-----+ @@ -40,8 +40,8 @@ Usage - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} @@ -56,13 +56,13 @@ Usage mvn site +-----+ -* Generate FindBugs xdoc Report As Part of the Project Reports +* Generate SpotBugs xdoc Report As Part of the Project Reports - To generate the FindBugs xdoc report as part of the Project Reports, add the - FindBugs plugin in the <<<\>>> section - of your <<>>. This will be the same report as that of the Maven 1 FindBugs + To generate the SpotBugs xdoc report as part of the Project Reports, add the + SpotBugs plugin in the <<<\>>> section + of your <<>>. This will be the same report as that of the Maven 1 SpotBugs report. It is also the format used by Hudson. - The output file will be written as <<>> to either the default output + The output file will be written as <<>> to either the default output directory of $\{project.build.directory\} or by that started in the <<<\>>> option. @@ -72,12 +72,12 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} true - + target/site @@ -101,7 +101,7 @@ mvn site you can use filters. The filters allow specifying by class and method which bug categories to include/exclude in/from the reports. The - {{{http://findbugs.sourceforge.net/manual/filter.html}filter format specification}} + {{{http://spotbugs.sourceforge.net/manual/filter.html}filter format specification}} also contains useful examples. +-----+ @@ -110,12 +110,12 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} - findbugs-exclude.xml - findbugs-include.xml + spotbugs-exclude.xml + spotbugs-include.xml @@ -139,7 +139,7 @@ mvn site you can use filters. The filters allow specifying by class and method which bug categories to include/exclude in/from the reports. The - {{{http://findbugs.sourceforge.net/manual/filter.html}filter format specification}} + {{{http://spotbugs.sourceforge.net/manual/filter.html}filter format specification}} also contains useful examples. +-----+ @@ -148,12 +148,12 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} - findbugs-exclude.xml - findbugs-include.xml + spotbugs-exclude.xml + spotbugs-include.xml @@ -183,8 +183,8 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} FindDeadLocalStores,UnreadFields @@ -215,8 +215,8 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} FindDeadLocalStores,UnreadFields @@ -247,11 +247,11 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} - org.codehaus.mojo.findbugs.* + com.github.spotbugs.spotbugs.* @@ -280,8 +280,8 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} myDetectors.jar, yourDetectors.jar @@ -311,14 +311,14 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} com.timgroup - findbugs4jmock + spotbugs4jmock 0.2 @@ -338,10 +338,10 @@ mvn site +-----+ -* Launch the Findbugs GUI +* Launch the Spotbugs GUI - This will launch the FindBugs GUI configured for this project and will open the - findbugsXml.xml file if present. It therefore assumes a pom.xml with the minimum + This will launch the SpotBugs GUI configured for this project and will open the + spotbugsXml.xml file if present. It therefore assumes a pom.xml with the minimum as follows. +-----+ @@ -350,11 +350,11 @@ mvn site - org.codehaus.mojo - findbugs-maven-plugin + com.github.spotbugs + spotbugs-maven-plugin ${projectVersion} - + @@ -363,10 +363,10 @@ mvn site +-----+ - Then, execute the findbugs plugin with the gui option. + Then, execute the spotbugs plugin with the gui option. +-----+ -mvn findbugs:gui +mvn spotbugs:gui +-----+ diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml index a118b9dd5..9a6e05f5e 100644 --- a/src/site/fml/faq.fml +++ b/src/site/fml/faq.fml @@ -21,8 +21,8 @@ How do I avoid OutOfMemory errors?

- When running findbugs on a project, the default heap size might not be enough - to complete the build. For now there is no way to fork findbugs and run with + When running spotbugs on a project, the default heap size might not be enough + to complete the build. For now there is no way to fork spotbugs and run with its own memory requirements, but the following system variable will allow you to do so for Maven:

diff --git a/src/site/resources/examples/findbugsXml.xml b/src/site/resources/examples/findbugsXml.xml deleted file mode 100644 index 73cce200e..000000000 --- a/src/site/resources/examples/findbugsXml.xml +++ /dev/null @@ -1,417 +0,0 @@ - -/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/it/basic-1/target/classes/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/mojo/findbugs-maven-plugin/3.0.3-SNAPSHOT/findbugs-maven-plugin-3.0.3-SNAPSHOT.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/findbugs/3.0.1/findbugs-3.0.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jsr305/2.0.1/jsr305-2.0.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/bcel-findbugs/6.0/bcel-findbugs-6.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/com/google/code/findbugs/jFormatString/2.0.1/jFormatString-2.0.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-debug-all/5.0.2/asm-debug-all-5.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-commons/5.0.2/asm-commons-5.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-tree/5.0.2/asm-tree-5.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/ow2/asm/asm/5.0.2/asm-5.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.6/commons-lang-2.6.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/com/apple/AppleJavaExtensions/1.4/AppleJavaExtensions-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.9.4/ant-1.9.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.9.4/ant-launcher-1.9.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/2.4.3/groovy-all-2.4.3.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.4/doxia-core-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.4/doxia-logging-api-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.3/commons-codec-1.3.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.4/doxia-module-fml-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-chain/commons-chain/1.1/commons-chain-1.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/sslext/sslext/1.2-0/sslext-1.2-0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/antlr/antlr/2.7.2/antlr-2.7.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-7/plexus-resources-1.0-alpha-7.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/junit/junit/4.11/junit-4.11.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/it-src-findbugs/java/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/src/it-src/test/java/Users/garvin/gitProjects/Findbugs/findbugs-maven-plugin/target/it/basic-1/targetClass inherits equals() and uses Object.hashCode()AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode()At AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeAt AbstractMissingHashCode.java:[line 14]Unused fieldUnused field: AbstractMissingHashCode$StillMissingHashCode.yAt AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeIn AbstractMissingHashCode.javaField AbstractMissingHashCode$StillMissingHashCode.yIn AbstractMissingHashCode.javaShould be a static inner classShould AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 21-24]In class AccidentalNonConstructorInInnerClass$DoNotReportAt AccidentalNonConstructorInInnerClass.java:[lines 21-24]Should be a static inner classShould AccidentalNonConstructorInInnerClass$Report be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 3-7]In class AccidentalNonConstructorInInnerClass$ReportAt AccidentalNonConstructorInInnerClass.java:[lines 3-7]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 15]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 27]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 33]Invocation of toString on an unnamed arrayInvocation of toString on an unnamed array in ArrayToString.print2()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print2()At ArrayToString.java:[line 29]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print0(String[])At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print0(String[])Local variable stored in JVM register 1At ArrayToString.java:[line 18]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print1()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print1()Local variable stored in JVM register 1At ArrayToString.java:[line 24]Invocation of toString on an arrayInvocation of toString on gargs in ArrayToString.print3()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print3()In ArrayToString.javaValue loaded from field ArrayToString.gargsAt ArrayToString.java:[line 34]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Unusual equals method UseOfNonHashableClassInHashDataStructure.equals(Object) is unusualAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 23]equals() method does not check for null argumentUseOfNonHashableClassInHashDataStructure.equals(Object) does not check for null argumentAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)Parameter $L1At UseOfNonHashableClassInHashDataStructure.java:[line 14]Dead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Another occurrence at UselessAssignments.java:[line 13]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 24]Double assignment of fieldDouble assignment of field g1 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.g1In UselessAssignments.javaDid you mean to refer to the field UselessAssignments.g2?At UselessAssignments.java:[line 12]Double assignment of fieldDouble assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Another occurrence at UselessAssignments.java:[line 26]Double assignment of fieldDouble assignment of field foo in UselessAssignments.report(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.report(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Double assignment of fieldDouble assignment of field bar in UselessAssignments.setFoo(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.setFoo(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Double assignment of local variable Double assignment of $L3 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 3At UselessAssignments.java:[line 13]Self assignment of local variableSelf assignment of $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Unread fieldUnread field: UselessAssignments.barAt UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Unread fieldUnread field: UselessAssignments.g1At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g1At UselessAssignments.java:[line 12]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Unused fieldUnused field: UselessAssignments.g2At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g2In UselessAssignments.javaUseless control flowUseless control flow in UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[line 23]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[line 14]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[line 18]Useless non-empty void methodMethod UselessControlFlow.report4(Object[], Object) seems to be uselessAt UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report4(Object[], Object)At UselessControlFlow.java:[line 40]Static Thread.interrupted() method invoked on thread instanceUselessCurrentThread.run() invokes static Thread.interrupted() method on thread instanceAt UselessCurrentThread.java:[lines 5-36]In class UselessCurrentThreadIn method UselessCurrentThread.run()At UselessCurrentThread.java:[line 29]Finalizer does nothing but call superclass finalizerUselessFinalize.finalize() does nothing except call super.finalize(); delete itAt UselessFinalize.java:[lines 1-5]In class UselessFinalizeIn method UselessFinalize.finalize()At UselessFinalize.java:[lines 4-5]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 31]Code contains a hard coded reference to an absolute pathnameHard coded reference to an absolute pathname in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])File name /mainList.txtAt UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]"." or "|" used for regular expression"." or "|" used for regular expression in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method String.replaceAll(String, String)At UserMistakes.java:[line 15]Method discards result of readLine after checking if it is non-nullUserMistakes.main(String[]) discards result of readLine after checking if it is non-nullAt UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])At UserMistakes.java:[line 30]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 108-3095]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 8]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 108-3095]Expected StringValue loaded from ?At ArrayEquality.java:[line 12]Invocation of equals() on an array, which is equivalent to ==Using .equals to compare two String[]'s, (equivalent to ==) in equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])Actual type String[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 15]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a String[][] in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 18]equals(...) used to compare incompatible arraysUsing equals to compare a String[][] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 21]equals(...) used to compare incompatible arraysUsing equals to compare a int[] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 24]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a int[] in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 27]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a StringBuffer[] in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 30]Impossible castImpossible cast from java.util.LinkedList to java.util.ArrayList in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At LinkedList.java:[lines 85-1137]Actual type java.util.LinkedListAt ArrayList.java:[lines 102-966]Expected java.util.ArrayListValue loaded from ?At AllListsCouldBeEqual.java:[line 134]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 134]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 138]Return value of method without side effect is ignoredReturn value of java.util.Set.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.falsePositive()Called method java.util.Set.contains(Object)At AllListsCouldBeEqual.java:[line 152]Another occurrence at AllListsCouldBeEqual.java:[line 153]Return value of method without side effect is ignoredReturn value of java.util.List.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Called method java.util.List.contains(Object)At AllListsCouldBeEqual.java:[line 138]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 68]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 80]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 84]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 116]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 112]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 128]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 124]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 132]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 120]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 58]Another occurrence at ArrayListContains.java:[line 59]Another occurrence at ArrayListContains.java:[line 60]Another occurrence at ArrayListContains.java:[line 62]Another occurrence at ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 66]Another occurrence at ArrayListContains.java:[line 67]Another occurrence at ArrayListContains.java:[line 68]Another occurrence at ArrayListContains.java:[line 70]Another occurrence at ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 74]Another occurrence at ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 78]Another occurrence at ArrayListContains.java:[line 79]Another occurrence at ArrayListContains.java:[line 80]Another occurrence at ArrayListContains.java:[line 82]Another occurrence at ArrayListContains.java:[line 83]Another occurrence at ArrayListContains.java:[line 84]Another occurrence at ArrayListContains.java:[line 86]Another occurrence at ArrayListContains.java:[line 87]Another occurrence at ArrayListContains.java:[line 88]Another occurrence at ArrayListContains.java:[line 90]Another occurrence at ArrayListContains.java:[line 91]Another occurrence at ArrayListContains.java:[line 92]Another occurrence at ArrayListContains.java:[line 94]Another occurrence at ArrayListContains.java:[line 95]Another occurrence at ArrayListContains.java:[line 96]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 106]Another occurrence at ArrayListContains.java:[line 107]Another occurrence at ArrayListContains.java:[line 108]Another occurrence at ArrayListContains.java:[line 110]Another occurrence at ArrayListContains.java:[line 111]Another occurrence at ArrayListContains.java:[line 112]Another occurrence at ArrayListContains.java:[line 114]Another occurrence at ArrayListContains.java:[line 115]Another occurrence at ArrayListContains.java:[line 116]Another occurrence at ArrayListContains.java:[line 118]Another occurrence at ArrayListContains.java:[line 119]Another occurrence at ArrayListContains.java:[line 120]Another occurrence at ArrayListContains.java:[line 122]Another occurrence at ArrayListContains.java:[line 123]Another occurrence at ArrayListContains.java:[line 124]Another occurrence at ArrayListContains.java:[line 126]Another occurrence at ArrayListContains.java:[line 127]Another occurrence at ArrayListContains.java:[line 128]Another occurrence at ArrayListContains.java:[line 130]Another occurrence at ArrayListContains.java:[line 131]Another occurrence at ArrayListContains.java:[line 132]Another occurrence at ArrayListContains.java:[line 134]Another occurrence at ArrayListContains.java:[line 135]Another occurrence at ArrayListContains.java:[line 136]Another occurrence at ArrayListContains.java:[line 138]Another occurrence at ArrayListContains.java:[line 139]Another occurrence at ArrayListContains.java:[line 140]Another occurrence at ArrayListContains.java:[line 142]Another occurrence at ArrayListContains.java:[line 143]Another occurrence at ArrayListContains.java:[line 144]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 42]Another occurrence at ArrayListContains0.java:[line 43]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 58]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]Another occurrence at ArrayListContains0.java:[line 58]Unused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummySFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummySFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.wildcardFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.wildcardFIn ArrayListContains0.javaNullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 10 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 5-17]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 9]Redundant null check at UseCheckUse.java:[line 10]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 36]Method call passes null to a non-null parameter Null passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 20]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar3(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 41]Null value at UseAnnotations.java:[line 39]Known null at UseAnnotations.java:[line 40]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar4(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar4(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 46]Null value at UseAnnotations.java:[line 44]Known null at UseAnnotations.java:[line 45]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.bar() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 32]Known null at UseAnnotations.java:[line 32]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo()Local variable stored in JVM register ?Method invoked at UseAnnotations.java:[line 17]Known null at UseAnnotations.java:[line 17]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo4() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo4()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 28]Known null at UseAnnotations.java:[line 28]Method call passes null for non-null parameterNull passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo3(int)Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 might be null but must not be nullValue loaded from ?Method invoked at UseAnnotations.java:[line 25]Null value at UseAnnotations.java:[line 23]Known null at UseAnnotations.java:[line 24]clone method does not call super.clone()org.codehaus.mojo.findbugsmavenplugin.it.App.clone() does not call super.clone()At App.java:[lines 11-21]In class org.codehaus.mojo.findbugsmavenplugin.it.AppIn method org.codehaus.mojo.findbugsmavenplugin.it.App.clone()At App.java:[line 21]Clone method may return nullorg.codehaus.mojo.findbugsmavenplugin.it.App.clone() may return nullAt App.java:[lines 11-21]In class org.codehaus.mojo.findbugsmavenplugin.it.AppIn method org.codehaus.mojo.findbugsmavenplugin.it.App.clone()At App.java:[line 21]Dodgy codeBad practiceCorrectnessInternationalizationPerformanceImpossible cast

- -<p> -This cast will always throw a ClassCastException. -FindBugs tracks type information from instanceof checks, -and also uses more precise information about the types -of values returned from methods and loaded from fields. -Thus, it may have more precise information that just -the declared type of a variable, and can use this to determine -that a cast will always throw an exception at runtime. - -</p> - -
Uninitialized read of field in constructor
- - <p> This constructor reads a field which has not yet been assigned a value.&nbsp; - This is often caused when the programmer mistakenly uses the field instead - of one of the constructor's parameters.</p> - -
Double assignment of local variable
- -<p> This method contains a double assignment of a local variable; e.g. -</p> -<pre> - public void foo() { - int x,y; - x = x = 17; - } -</pre> -<p>Assigning the same value to a variable twice is useless, and may indicate a logic error or typo.</p> - -
Return value of method without side effect is ignored
- -<p>This code calls a method and ignores the return value. However our analysis shows that -the method (including its implementations in subclasses if any) does not produce any effect -other than return value. Thus this call can be removed. -</p> -<p>We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. -Common false-positive cases include:</p> -<p>- The method is designed to be overridden and produce a side effect in other projects which are out of the scope of the analysis.</p> -<p>- The method is called to trigger the class loading which may have a side effect.</p> -<p>- The method is called just to get some exception.</p> -<p>If you feel that our assumption is incorrect, you can use a @CheckReturnValue annotation -to instruct FindBugs that ignoring the return value of this method is acceptable. -</p> - -
Null pointer dereference
- -<p> A null pointer is dereferenced here.&nbsp; This will lead to a -<code>NullPointerException</code> when the code is executed.</p> - -
equals() used to compare array and nonarray
- -<p> -This method invokes the .equals(Object o) to compare an array and a reference that doesn't seem -to be an array. If things being compared are of different types, they are guaranteed to be unequal -and the comparison is almost certainly an error. Even if they are both arrays, the equals method -on arrays only determines of the two arrays are the same object. -To compare the -contents of the arrays, use java.util.Arrays.equals(Object[], Object[]). -</p> - -
Useless non-empty void method
- -<p>Our analysis shows that this non-empty void method does not actually perform any useful work. -Please check it: probably there's a mistake in its code or its body can be fully removed. -</p> -<p>We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. -Common false-positive cases include:</p> -<p>- The method is intended to trigger loading of some class which may have a side effect.</p> -<p>- The method is intended to implicitly throw some obscure exception.</p> - -
Nullcheck of value previously dereferenced
- -<p> A value is checked here to see whether it is null, but this value can't -be null because it was previously dereferenced and if it were null a null pointer -exception would have occurred at the earlier dereference. -Essentially, this code and the previous dereference -disagree as to whether this value is allowed to be null. Either the check is redundant -or the previous dereference is erroneous.</p> - -
Method discards result of readLine after checking if it is non-null
- - <p> The value returned by readLine is discarded after checking to see if the return -value is non-null. In almost all situations, if the result is non-null, you will want -to use that non-null value. Calling readLine again will give you a different line.</p> - -
Unused field
- - <p> This field is never used.&nbsp; Consider removing it from the class.</p> - -
No relationship between generic parameter and method argument
- - <p> This call to a generic collection method contains an argument - with an incompatible class from that of the collection's parameter - (i.e., the type of the argument is neither a supertype nor a subtype - of the corresponding generic type argument). - Therefore, it is unlikely that the collection contains any objects - that are equal to the method argument used here. - Most likely, the wrong value is being passed to the method.</p> - <p>In general, instances of two unrelated classes are not equal. - For example, if the <code>Foo</code> and <code>Bar</code> classes - are not related by subtyping, then an instance of <code>Foo</code> - should not be equal to an instance of <code>Bar</code>. - Among other issues, doing so will likely result in an equals method - that is not symmetrical. For example, if you define the <code>Foo</code> class - so that a <code>Foo</code> can be equal to a <code>String</code>, - your equals method isn't symmetrical since a <code>String</code> can only be equal - to a <code>String</code>. - </p> - <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make - their code work. Although none of the APIs document or guarantee it, it is typically - the case that if you check if a <code>Collection&lt;String&gt;</code> contains - a <code>Foo</code>, the equals method of argument (e.g., the equals method of the - <code>Foo</code> class) used to perform the equality checks. - </p> - -
Doomed attempt to append to an object output stream
- - <p> - This code opens a file in append mode and then wraps the result in an object output stream. - This won't allow you to append to an existing object output stream stored in a file. If you want to be - able to append to an object output stream, you need to keep the object output stream open. - </p> - <p>The only situation in which opening a file in append mode and the writing an object output stream - could work is if on reading the file you plan to open it in random access mode and seek to the byte offset - where the append started. - </p> - - <p> - TODO: example. - </p> - -
Clone method may return null
- - <p> - This clone method seems to return null in some circumstances, but clone is never - allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError - instead. - </p> - -
Bad comparison of signed byte
- -<p> Signed bytes can only have a value in the range -128 to 127. Comparing -a signed byte with a value outside that range is vacuous and likely to be incorrect. -To convert a signed byte <code>b</code> to an unsigned value in the range 0..255, -use <code>0xff &amp; b</code> -</p> - -
Unread field
- - <p> This field is never read.&nbsp; Consider removing it from the class.</p> - -
Useless control flow
- -<p> This method contains a useless control flow statement, where -control flow continues onto the same place regardless of whether or not -the branch is taken. For example, -this is caused by having an empty statement -block for an <code>if</code> statement:</p> -<pre> - if (argv.length == 0) { - // TODO: handle this case - } -</pre> - -
equals() method does not check for null argument
- - <p> - This implementation of equals(Object) violates the contract defined - by java.lang.Object.equals() because it does not check for null - being passed as the argument. All equals() methods should return - false if passed a null value. - </p> - -
Method call passes null for non-null parameter
- - <p> - This method call passes a null value for a non-null method parameter. - Either the parameter is annotated as a parameter that should - always be non-null, or analysis has shown that it will always be - dereferenced. - </p> - -
Possible null pointer dereference
- -<p> There is a branch of statement that, <em>if executed,</em> guarantees that -a null value will be dereferenced, which -would generate a <code>NullPointerException</code> when the code is executed. -Of course, the problem might be that the branch or statement is infeasible and that -the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs. -</p> - -
Should be a static inner class
- - <p> This class is an inner class, but does not use its embedded reference - to the object which created it.&nbsp; This reference makes the instances - of the class larger, and may keep the reference to the creator object - alive longer than necessary.&nbsp; If possible, the class should be - made static. -</p> - -
Dead store to local variable
- -<p> -This instruction assigns a value to a local variable, -but the value is not read or used in any subsequent instruction. -Often, this indicates an error, because the value computed is never -used. -</p> -<p> -Note that Sun's javac compiler often generates dead stores for -final local variables. Because FindBugs is a bytecode-based tool, -there is no easy way to eliminate these false positives. -</p> - -
Invocation of toString on an unnamed array
- -<p> -The code invokes toString on an (anonymous) array. Calling toString on an array generates a fairly useless result -such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable -String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12. -</p> - -
equals(...) used to compare incompatible arrays
- -<p> -This method invokes the .equals(Object o) to compare two arrays, but the arrays of -of incompatible types (e.g., String[] and StringBuffer[], or String[] and int[]). -They will never be equal. In addition, when equals(...) is used to compare arrays it -only checks to see if they are the same array, and ignores the contents of the arrays. -</p> - -
Class defines equals() and uses Object.hashCode()
- - <p> This class overrides <code>equals(Object)</code>, but does not - override <code>hashCode()</code>, and inherits the implementation of - <code>hashCode()</code> from <code>java.lang.Object</code> (which returns - the identity hash code, an arbitrary value assigned to the object - by the VM).&nbsp; Therefore, the class is very likely to violate the - invariant that equal objects must have equal hashcodes.</p> - -<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable, -the recommended <code>hashCode</code> implementation to use is:</p> -<pre>public int hashCode() { - assert false : "hashCode not designed"; - return 42; // any arbitrary constant will do - }</pre> - -
Double assignment of field
- -<p> This method contains a double assignment of a field; e.g. -</p> -<pre> - int x,y; - public void foo() { - x = x = 17; - } -</pre> -<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p> - -
Useless control flow to next line
- -<p> This method contains a useless control flow statement in which control -flow follows to the same or following line regardless of whether or not -the branch is taken. -Often, this is caused by inadvertently using an empty statement as the -body of an <code>if</code> statement, e.g.:</p> -<pre> - if (argv.length == 1); - System.out.println("Hello, " + argv[0]); -</pre> - -
Invocation of toString on an array
- -<p> -The code invokes toString on an array, which will generate a fairly useless result -such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable -String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12. -</p> - -
Code contains a hard coded reference to an absolute pathname
- -<p>This code constructs a File object using a hard coded to an absolute pathname -(e.g., <code>new File("/home/dannyc/workspace/j2ee/src/share/com/sun/enterprise/deployment");</code> -</p> - -
Method call passes null to a non-null parameter
- - <p> - This method passes a null value as the parameter of a method which - must be non-null. Either this parameter has been explicitly marked - as @Nonnull, or analysis has determined that this parameter is - always dereferenced. - </p> - -
Possible null pointer dereference due to return value of called method
- -<p> The return value from a method is dereferenced without a null check, -and the return value of that method is one that should generally be checked -for null. This may lead to a <code>NullPointerException</code> when the code is executed. -</p> - -
Reliance on default encoding
- -<p> Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. </p> - -
Unusual equals method
- - <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument -is compatible with the type of the <code>this</code> object. There might not be anything wrong with -this code, but it is worth reviewing. -</p> - -
Static Thread.interrupted() method invoked on thread instance
- -<p> -This method invokes the Thread.interrupted() method on a Thread object that appears to be a Thread object that is -not the current thread. As the interrupted() method is static, the interrupted method will be called on a different -object than the one the author intended. -</p> - -
Self assignment of field
- -<p> This method contains a self assignment of a field; e.g. -</p> -<pre> - int x; - public void foo() { - x = x; - } -</pre> -<p>Such assignments are useless, and may indicate a logic error or typo.</p> - -
"." or "|" used for regular expression
- -<p> -A String function is being invoked and "." or "|" is being passed -to a parameter that takes a regular expression as an argument. Is this what you intended? -For example -<li>s.replaceAll(".", "/") will return a String in which <em>every</em> character has been replaced by a '/' character -<li>s.split(".") <em>always</em> returns a zero length array of String -<li>"ab|cd".replaceAll("|", "/") will return "/a/b/|/c/d/" -<li>"ab|cd".split("|") will return array with six (!) elements: [, a, b, |, c, d] -</p> - -
Use of class without a hashCode() method in a hashed data structure
- - <p> A class defines an equals(Object) method but not a hashCode() method, -and thus doesn't fulfill the requirement that equal objects have equal hashCodes. -An instance of this class is used in a hash data structure, making the need to -fix this problem of highest importance. - -
Invocation of equals() on an array, which is equivalent to ==
- -<p> -This method invokes the .equals(Object o) method on an array. Since arrays do not override the equals -method of Object, calling equals on an array is the same as comparing their addresses. To compare the -contents of the arrays, use <code>java.util.Arrays.equals(Object[], Object[])</code>. -To compare the addresses of the arrays, it would be -less confusing to explicitly check pointer equality using <code>==</code>. -</p> - -
Overwritten increment
- -<p> -The code performs an increment operation (e.g., <code>i++</code>) and then -immediately overwrites it. For example, <code>i = i++</code> immediately -overwrites the incremented value with the original value. -</p> - -
clone method does not call super.clone()
- -<p> This non-final class defines a clone() method that does not call super.clone(). -If this class ("<i>A</i>") is extended by a subclass ("<i>B</i>"), -and the subclass <i>B</i> calls super.clone(), then it is likely that -<i>B</i>'s clone() method will return an object of type <i>A</i>, -which violates the standard contract for clone().</p> - -<p> If all clone() methods call super.clone(), then they are guaranteed -to use Object.clone(), which always returns an object of the correct type.</p> - -
Finalizer does nothing but call superclass finalizer
- - <p> The only thing this <code>finalize()</code> method does is call - the superclass's <code>finalize()</code> method, making it - redundant.&nbsp; Delete it.</p> - -
Class inherits equals() and uses Object.hashCode()
- - <p> This class inherits <code>equals(Object)</code> from an abstract - superclass, and <code>hashCode()</code> from -<code>java.lang.Object</code> (which returns - the identity hash code, an arbitrary value assigned to the object - by the VM).&nbsp; Therefore, the class is very likely to violate the - invariant that equal objects must have equal hashcodes.</p> - - <p>If you don't want to define a hashCode method, and/or don't - believe the object will ever be put into a HashMap/Hashtable, - define the <code>hashCode()</code> method - to throw <code>UnsupportedOperationException</code>.</p> - -
Self assignment of local variable
- -<p> This method contains a self assignment of a local variable; e.g.</p> -<pre> - public void foo() { - int x = 3; - x = x; - } -</pre> -<p> -Such assignments are useless, and may indicate a logic error or typo. -</p> - -
Suspicious calls to generic collection methodsUninitialized read of field in constructorEqual objects must have equal hashcodesRegular expressionsComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceDubious method invocationUnused fieldProblems with implementation of equals()Dubious method usedUseless codeInner class could be made staticRedundant comparison to nullBad use of return value from methodUseless control flowSuspicious integer expressionUnread fieldBad casts of object referencesUseless/non-informative string generatedSuspicious Thread InterruptedBad implementation of cloneable idiomIncorrect use of finalizersUseless self-operation \ No newline at end of file diff --git a/src/site/resources/examples/findbugs.html b/src/site/resources/examples/spotbugs.html similarity index 66% rename from src/site/resources/examples/findbugs.html rename to src/site/resources/examples/spotbugs.html index c5f87cf85..16fb48e58 100644 --- a/src/site/resources/examples/findbugs.html +++ b/src/site/resources/examples/spotbugs.html @@ -3,7 +3,7 @@ - basic-1 – FindBugs Bug Detector Report + basic-1 – SpotBugs Bug Detector Report - + @@ -76,13 +76,13 @@
Project Documentation
-

SpotBugs Bug Detector Report

+

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 3.1.0

Threshold is medium

Effort is min

-

Summary

+

Summary

@@ -95,7 +95,7 @@

Summary

Classes 0 0
-

Files

+

Files

@@ -156,9 +156,9 @@

Files

-
Class 8
com.github.spotbugs.spotbugs-maven-plugin.it.App2
+2
-

AbstractMissingHashCode$StillMissingHashCode

+

AbstractMissingHashCode$StillMissingHashCode

@@ -177,9 +177,9 @@

AbstractMissingHas

-
BugPERFORMANCE UUF_UNUSED_FIELD Not availableMedium
+Medium
-

AccidentalNonConstructorInInnerClass$DoNotReport

+

AccidentalNonConstructorInInnerClass$DoNotReport

@@ -192,9 +192,9 @@

AccidentalNonC

-
BugPERFORMANCE SIC_INNER_SHOULD_BE_STATIC 21-24Medium
+Medium
-

AccidentalNonConstructorInInnerClass$Report

+

AccidentalNonConstructorInInnerClass$Report

@@ -207,9 +207,9 @@

AccidentalNonConstr

-
BugPERFORMANCE SIC_INNER_SHOULD_BE_STATIC 3-7Medium
+Medium
-

AppendingToAnObjectOutputStream

+

AppendingToAnObjectOutputStream

@@ -240,9 +240,9 @@

AppendingToAnObjectOutputStrea

-
BugCORRECTNESS IO_APPENDING_TO_OBJECT_OUTPUT_STREAM 33High
+High
-

ArrayToString

+

ArrayToString

@@ -273,9 +273,9 @@

ArrayToString

-
Bug CORRECTNESS DMI_INVOKING_TOSTRING_ON_ARRAY 34Medium
+Medium
-

AssumeUnsignedBytes

+

AssumeUnsignedBytes

@@ -288,9 +288,9 @@

AssumeUnsignedBytes

-
Bug CORRECTNESS INT_BAD_COMPARISON_WITH_SIGNED_BYTE 8High
+High
-

UseOfNonHashableClassInHashDataStructure

+

UseOfNonHashableClassInHashDataStructure

@@ -321,9 +321,9 @@

UseOfNonHashableClass

-
BugBAD_PRACTICE NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT 14Medium
+Medium
-

UselessAssignments

+

UselessAssignments

@@ -414,9 +414,9 @@

UselessAssignments

-
Bug PERFORMANCE UUF_UNUSED_FIELD Not availableMedium
+Medium
-

UselessControlFlow

+

UselessControlFlow

@@ -447,9 +447,9 @@

UselessControlFlow

-
Bug STYLE UC_USELESS_VOID_METHOD 40Medium
+Medium
-

UselessCurrentThread

+

UselessCurrentThread

@@ -462,9 +462,9 @@

UselessCurrentThread

-
Bug CORRECTNESS STI_INTERRUPTED_ON_UNKNOWNTHREAD 29Medium
+Medium
-

UselessFinalize

+

UselessFinalize

@@ -477,9 +477,9 @@

UselessFinalize

-
Bug BAD_PRACTICE FI_USELESS 4-5Medium
+Medium
-

UserMistakes

+

UserMistakes

@@ -516,9 +516,9 @@

UserMistakes

-
Bug STYLE RV_DONT_JUST_NULL_CHECK_READLINE 30Medium
+Medium
-

equals.ArrayEquality

+

equals.ArrayEquality

@@ -573,9 +573,9 @@

equals.ArrayEquality

-
Bug CORRECTNESS EC_INCOMPATIBLE_ARRAY_COMPARE 30Medium
+Medium
-

gcUnrelatedTypes.AllListsCouldBeEqual

+

gcUnrelatedTypes.AllListsCouldBeEqual

@@ -612,9 +612,9 @@

gcUnrelatedTypes.AllList

-
BugSTYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 138Medium
+Medium
-

gcUnrelatedTypes.ArrayListContains

+

gcUnrelatedTypes.ArrayListContains

@@ -687,9 +687,9 @@

gcUnrelatedTypes.ArrayListC

-
BugSTYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 106Medium
+Medium
-

gcUnrelatedTypes.ArrayListContains0

+

gcUnrelatedTypes.ArrayListContains0

@@ -786,9 +786,9 @@

gcUnrelatedTypes.ArrayList

-
BugPERFORMANCE UUF_UNUSED_FIELD Not availableMedium
+Medium
-

npe.UseCheckUse

+

npe.UseCheckUse

@@ -801,9 +801,9 @@

npe.UseCheckUse

-
Bug CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 9High
+High
-

nullnessAnnotations.UseAnnotations

+

nullnessAnnotations.UseAnnotations

@@ -858,9 +858,9 @@

nullnessAnnotations.UseAnno

-
BugCORRECTNESS NP_NULL_PARAM_DEREF 25Medium
+Medium
-

com.github.spotbugs.spotbugs-maven-plugin.it.App

+

com.github.spotbugs.spotbugs-maven-plugin.it.App

diff --git a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/App.html b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/App.html index fb15487ca..7b5a455fb 100644 --- a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/App.html +++ b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/App.html @@ -8,30 +8,30 @@ 
-1   package com.github.spotbugs.spotbugs-maven-plugin.it;
-2   
-3   
-4   import org.junit.*;
-5   
-6   
-7   /**
-8    * Hello world!
-9    *
-10   */
-11  public class App implements Cloneable
-12  {
-13  
-14      public static void main( String[] args )
-15      {
-16          System.out.println( "Hello World!" );
-17      }
-18  
-19      public Object clone()
-20      {
-21          return null; // Does not call 'super.clone()'.
-22      }
-23  
-24  }
+1   package com.github.spotbugs.spotbugs-maven-plugin.it;
+2   
+3   
+4   import org.junit.*;
+5   
+6   
+7   /**
+8    * Hello world!
+9    *
+10   */
+11  public class App implements Cloneable
+12  {
+13  
+14      public static void main( String[] args )
+15      {
+16          System.out.println( "Hello World!" );
+17      }
+18  
+19      public Object clone()
+20      {
+21          return null; // Does not call 'super.clone()'.
+22      }
+23  
+24  }
diff --git a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/FooTest.html b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/FooTest.html index c6fb96035..878969f04 100644 --- a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/FooTest.html +++ b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/FooTest.html @@ -8,32 +8,32 @@ 
-1   package com.github.spotbugs.spotbugs-maven-plugin.it;
-2   
-3   import static org.junit.Assert.assertEquals;
-4   
-5   import org.junit.Test;
-6   import org.junit.Ignore;
-7   import org.junit.runner.RunWith;
-8   import org.junit.runners.JUnit4;
-9   
-10  /**
-11   * Tests for {@link Foo}.
-12   *
-13   * @author user@example.com (John Doe)
-14   */
-15  public class FooTest {
-16  
-17      @Test
-18      public void thisAlwaysPasses() {
-19  
-20      }
-21  
-22      @Test
-23      @Ignore
-24      public void thisIsIgnored() {
-25      }
-26  }
+1   package com.github.spotbugs.spotbugs-maven-plugin.it;
+2   
+3   import static org.junit.Assert.assertEquals;
+4   
+5   import org.junit.Test;
+6   import org.junit.Ignore;
+7   import org.junit.runner.RunWith;
+8   import org.junit.runners.JUnit4;
+9   
+10  /**
+11   * Tests for {@link Foo}.
+12   *
+13   * @author user@example.com (John Doe)
+14   */
+15  public class FooTest {
+16  
+17      @Test
+18      public void thisAlwaysPasses() {
+19  
+20      }
+21  
+22      @Test
+23      @Ignore
+24      public void thisIsIgnored() {
+25      }
+26  }
diff --git a/src/site/resources/examples/xref/A.html b/src/site/resources/examples/xref/A.html index 8e23d9f3c..bd0650afe 100644 --- a/src/site/resources/examples/xref/A.html +++ b/src/site/resources/examples/xref/A.html @@ -8,11 +8,11 @@ 
-1   class A {
-2   	public static void main(String args[]) {
-3   		System.out.println(args[0].replace("x", "y"));
-4   	}
-5   }
+1   class A {
+2   	public static void main(String args[]) {
+3   		System.out.println(args[0].replace("x", "y"));
+4   	}
+5   }
diff --git a/src/site/resources/examples/xref/AbstractMissingHashCode.html b/src/site/resources/examples/xref/AbstractMissingHashCode.html index 88d6c5502..1a41d526a 100644 --- a/src/site/resources/examples/xref/AbstractMissingHashCode.html +++ b/src/site/resources/examples/xref/AbstractMissingHashCode.html @@ -8,23 +8,23 @@ 
-1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
-3   abstract class AbstractMissingHashCode {
-4   	int x;
-5   
-6   	@Override
-7   	public boolean equals(Object o) {
-8   		if (!(o instanceof AbstractMissingHashCode))
-9   			return false;
-10  		return x == ((AbstractMissingHashCode) o).x;
-11  	}
-12  
-13  	@ExpectWarning("HE")
-14  	static class StillMissingHashCode extends AbstractMissingHashCode {
-15  		int y;
-16  	}
-17  }
+1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+2   
+3   abstract class AbstractMissingHashCode {
+4   	int x;
+5   
+6   	@Override
+7   	public boolean equals(Object o) {
+8   		if (!(o instanceof AbstractMissingHashCode))
+9   			return false;
+10  		return x == ((AbstractMissingHashCode) o).x;
+11  	}
+12  
+13  	@ExpectWarning("HE")
+14  	static class StillMissingHashCode extends AbstractMissingHashCode {
+15  		int y;
+16  	}
+17  }
diff --git a/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html b/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html index df25a947c..0285ac7dd 100644 --- a/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html +++ b/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html @@ -8,42 +8,42 @@ 
-1   public class AccidentalNonConstructorInInnerClass {
-2   
-3   	class Report {
-4   		void Report() {
-5   		};
-6   
-7   		class DeeplyNested {
-8   			void DeeplyNested() {
-9   			};
-10  		}
-11  	}
-12  
-13  	static class Report2 {
-14  		void Report2() {
-15  		};
-16  	}
-17  
-18  	class DoNotReport {
-19  		@Deprecated
-20  		void DoNotReport() {
-21  		}
-22  
-23  		DoNotReport() {
-24  		}
-25  	}
-26  
-27  	static class DoNotReport2 {
-28  		void DoNotReport2() {
-29  			throw new UnsupportedOperationException();
-30  		}
-31  
-32  		DoNotReport2() {
-33  		}
-34  	}
-35  
-36  }
+1   public class AccidentalNonConstructorInInnerClass {
+2   
+3   	class Report {
+4   		void Report() {
+5   		};
+6   
+7   		class DeeplyNested {
+8   			void DeeplyNested() {
+9   			};
+10  		}
+11  	}
+12  
+13  	static class Report2 {
+14  		void Report2() {
+15  		};
+16  	}
+17  
+18  	class DoNotReport {
+19  		@Deprecated
+20  		void DoNotReport() {
+21  		}
+22  
+23  		DoNotReport() {
+24  		}
+25  	}
+26  
+27  	static class DoNotReport2 {
+28  		void DoNotReport2() {
+29  			throw new UnsupportedOperationException();
+30  		}
+31  
+32  		DoNotReport2() {
+33  		}
+34  	}
+35  
+36  }
diff --git a/src/site/resources/examples/xref/AnnotationTest.html b/src/site/resources/examples/xref/AnnotationTest.html index 7faafadc9..b42aaf5f3 100644 --- a/src/site/resources/examples/xref/AnnotationTest.html +++ b/src/site/resources/examples/xref/AnnotationTest.html @@ -8,15 +8,15 @@ 
-1   import edu.umd.cs.findbugs.annotations.CheckReturnValue;
-2   import edu.umd.cs.findbugs.annotations.Priority;
-3   
-4   class AnnotationTest {
-5   	@CheckReturnValue(priority = Priority.HIGH)
-6   	int f() {
-7   		return 42;
-8   	}
-9   }
+1   import edu.umd.cs.findbugs.annotations.CheckReturnValue;
+2   import edu.umd.cs.findbugs.annotations.Priority;
+3   
+4   class AnnotationTest {
+5   	@CheckReturnValue(priority = Priority.HIGH)
+6   	int f() {
+7   		return 42;
+8   	}
+9   }
diff --git a/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html b/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html index 53a8d7719..cb709e0dd 100644 --- a/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html +++ b/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html @@ -8,43 +8,43 @@ 
-1   import java.io.BufferedOutputStream;
-2   import java.io.File;
-3   import java.io.FileNotFoundException;
-4   import java.io.FileOutputStream;
-5   import java.io.IOException;
-6   import java.io.ObjectOutputStream;
-7   
-8   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-9   
-10  
-11  public class AppendingToAnObjectOutputStream {
-12  	
-13  	@ExpectWarning("IO")
-14  	public static void appendObject1(File f, Object o) throws FileNotFoundException, IOException {
-15  		ObjectOutputStream out = new ObjectOutputStream (new FileOutputStream(f, true));
-16  		out.writeObject(o);
-17  		out.close();
-18  	}
-19  	@ExpectWarning("IO")
-20  	public static void appendObject2(File f, Object o) throws FileNotFoundException, IOException {
-21  		ObjectOutputStream out = new ObjectOutputStream (new BufferedOutputStream(new FileOutputStream(f, true)));
-22  		out.writeObject(o);
-23  		out.close();
-24  	}
-25  	@ExpectWarning("IO")
-26  	public static void appendObject3(String f, Object o) throws FileNotFoundException, IOException {
-27  		ObjectOutputStream out = new ObjectOutputStream (new FileOutputStream(f, true));
-28  		out.writeObject(o);
-29  		out.close();
-30  	}
-31  	@ExpectWarning("IO")
-32  	public static void appendObject4(String f, Object o) throws FileNotFoundException, IOException {
-33  		ObjectOutputStream out = new ObjectOutputStream (new BufferedOutputStream(new FileOutputStream(f, true)));
-34  		out.writeObject(o);
-35  		out.close();
-36  	}
-37  }
+1   import java.io.BufferedOutputStream;
+2   import java.io.File;
+3   import java.io.FileNotFoundException;
+4   import java.io.FileOutputStream;
+5   import java.io.IOException;
+6   import java.io.ObjectOutputStream;
+7   
+8   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+9   
+10  
+11  public class AppendingToAnObjectOutputStream {
+12  	
+13  	@ExpectWarning("IO")
+14  	public static void appendObject1(File f, Object o) throws FileNotFoundException, IOException {
+15  		ObjectOutputStream out = new ObjectOutputStream (new FileOutputStream(f, true));
+16  		out.writeObject(o);
+17  		out.close();
+18  	}
+19  	@ExpectWarning("IO")
+20  	public static void appendObject2(File f, Object o) throws FileNotFoundException, IOException {
+21  		ObjectOutputStream out = new ObjectOutputStream (new BufferedOutputStream(new FileOutputStream(f, true)));
+22  		out.writeObject(o);
+23  		out.close();
+24  	}
+25  	@ExpectWarning("IO")
+26  	public static void appendObject3(String f, Object o) throws FileNotFoundException, IOException {
+27  		ObjectOutputStream out = new ObjectOutputStream (new FileOutputStream(f, true));
+28  		out.writeObject(o);
+29  		out.close();
+30  	}
+31  	@ExpectWarning("IO")
+32  	public static void appendObject4(String f, Object o) throws FileNotFoundException, IOException {
+33  		ObjectOutputStream out = new ObjectOutputStream (new BufferedOutputStream(new FileOutputStream(f, true)));
+34  		out.writeObject(o);
+35  		out.close();
+36  	}
+37  }
diff --git a/src/site/resources/examples/xref/ArrayToString.html b/src/site/resources/examples/xref/ArrayToString.html index ef2b0b57b..935156040 100644 --- a/src/site/resources/examples/xref/ArrayToString.html +++ b/src/site/resources/examples/xref/ArrayToString.html @@ -8,42 +8,42 @@ 
-1   import edu.umd.cs.findbugs.annotations.DesireWarning;
-2   
-3   
-4   public class ArrayToString {
-5   	
-6   	private static final String[] gargs = new String[] {"1", "2"};
-7   	
-8   	public static void main(String[] args) {
-9   		ArrayToString a = new ArrayToString();
-10  		a.print0(args);
-11  		a.print1();
-12  		a.print2();
-13  		a.print3();
-14  	}
-15  	
-16  	@DesireWarning("DMI")
-17  	public void print0(String args[]) {
-18  		System.out.println(args.toString());
-19  	}
-20  
-21  	@DesireWarning("DMI")
-22  	public void print1() {
-23  		String [] args2 = new String[] {"Hello", "there"};
-24  		System.out.println(args2.toString());
-25  	}
-26  
-27  	@DesireWarning("DMI")
-28  	public void print2() {
-29  		System.out.println((new String[] {"one","two"}).toString());		
-30  	}
-31  
-32  	@DesireWarning("DMI")
-33  	public void print3() {
-34  		System.out.println(gargs.toString());
-35  	}
-36  }
+1   import edu.umd.cs.findbugs.annotations.DesireWarning;
+2   
+3   
+4   public class ArrayToString {
+5   	
+6   	private static final String[] gargs = new String[] {"1", "2"};
+7   	
+8   	public static void main(String[] args) {
+9   		ArrayToString a = new ArrayToString();
+10  		a.print0(args);
+11  		a.print1();
+12  		a.print2();
+13  		a.print3();
+14  	}
+15  	
+16  	@DesireWarning("DMI")
+17  	public void print0(String args[]) {
+18  		System.out.println(args.toString());
+19  	}
+20  
+21  	@DesireWarning("DMI")
+22  	public void print1() {
+23  		String [] args2 = new String[] {"Hello", "there"};
+24  		System.out.println(args2.toString());
+25  	}
+26  
+27  	@DesireWarning("DMI")
+28  	public void print2() {
+29  		System.out.println((new String[] {"one","two"}).toString());		
+30  	}
+31  
+32  	@DesireWarning("DMI")
+33  	public void print3() {
+34  		System.out.println(gargs.toString());
+35  	}
+36  }
diff --git a/src/site/resources/examples/xref/AssignedOnlyInCtor.html b/src/site/resources/examples/xref/AssignedOnlyInCtor.html index 153de60b4..2db619f3c 100644 --- a/src/site/resources/examples/xref/AssignedOnlyInCtor.html +++ b/src/site/resources/examples/xref/AssignedOnlyInCtor.html @@ -8,18 +8,18 @@ 
-1   public class AssignedOnlyInCtor {
-2   	private int value;
-3   
-4   	public AssignedOnlyInCtor(int value) {
-5   		this.value = value;
-6   	}
-7   
-8   	public int getValue() {
-9   		return value;
-10  	}
-11  
-12  }
+1   public class AssignedOnlyInCtor {
+2   	private int value;
+3   
+4   	public AssignedOnlyInCtor(int value) {
+5   		this.value = value;
+6   	}
+7   
+8   	public int getValue() {
+9   		return value;
+10  	}
+11  
+12  }
diff --git a/src/site/resources/examples/xref/AssumeUnsignedBytes.html b/src/site/resources/examples/xref/AssumeUnsignedBytes.html index e085ce1d3..1c9106340 100644 --- a/src/site/resources/examples/xref/AssumeUnsignedBytes.html +++ b/src/site/resources/examples/xref/AssumeUnsignedBytes.html @@ -8,18 +8,18 @@ 
-1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
-3   class AssumeUnsignedBytes {
-4   
-5   	@ExpectWarning("INT")
-6   	int find200(byte[] b) {
-7   		for (int i = 0; i < b.length; i++)
-8   			if (b[i] == 200)
-9   				return i;
-10  		return -1;
-11  	}
-12  }
+1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+2   
+3   class AssumeUnsignedBytes {
+4   
+5   	@ExpectWarning("INT")
+6   	int find200(byte[] b) {
+7   		for (int i = 0; i < b.length; i++)
+8   			if (b[i] == 200)
+9   				return i;
+10  		return -1;
+11  	}
+12  }
diff --git a/src/site/resources/examples/xref/UseInitCause.html b/src/site/resources/examples/xref/UseInitCause.html index ed5ce29a1..f60f4a083 100644 --- a/src/site/resources/examples/xref/UseInitCause.html +++ b/src/site/resources/examples/xref/UseInitCause.html @@ -8,21 +8,21 @@ 
-1   import java.io.BufferedReader;
-2   import java.io.IOException;
-3   
-4   
-5   public class UseInitCause {
-6   
-7   	public String firstLine(BufferedReader r) {
-8   		try {
-9   			return r.readLine();
-10  		} catch (IOException e) {
-11  			throw (RuntimeException) new RuntimeException("IO Error").initCause(e);
-12  		}
-13  	}
-14  
-15  }
+1   import java.io.BufferedReader;
+2   import java.io.IOException;
+3   
+4   
+5   public class UseInitCause {
+6   
+7   	public String firstLine(BufferedReader r) {
+8   		try {
+9   			return r.readLine();
+10  		} catch (IOException e) {
+11  			throw (RuntimeException) new RuntimeException("IO Error").initCause(e);
+12  		}
+13  	}
+14  
+15  }
diff --git a/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html b/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html index 20db7572d..5b2565d4a 100644 --- a/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html +++ b/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html @@ -8,31 +8,31 @@ 
-1   import java.util.HashMap;
-2   
-3   public class UseOfNonHashableClassInHashDataStructure {
-4   
-5   
-6   	static class UMap extends HashMap<UseOfNonHashableClassInHashDataStructure, String> {};
-7   	static HashMap<UseOfNonHashableClassInHashDataStructure, String> m = new HashMap<UseOfNonHashableClassInHashDataStructure, String>();
-8   
-9   	static int foo(HashMap<UseOfNonHashableClassInHashDataStructure, String> map) {
-10  		return map.size();
-11  	}
-12  	@Override
-13  	public boolean equals(Object o) {
-14  		return hashCode() == o.hashCode();
-15  	}
-16  
-17  	public static String add(UseOfNonHashableClassInHashDataStructure b,
-18  			String s) {
-19  		return m.put(b, s);
-20  	}
-21  
-22  	public static String get(UseOfNonHashableClassInHashDataStructure b) {
-23  		return m.get(b);
-24  	}
-25  }
+1   import java.util.HashMap;
+2   
+3   public class UseOfNonHashableClassInHashDataStructure {
+4   
+5   
+6   	static class UMap extends HashMap<UseOfNonHashableClassInHashDataStructure, String> {};
+7   	static HashMap<UseOfNonHashableClassInHashDataStructure, String> m = new HashMap<UseOfNonHashableClassInHashDataStructure, String>();
+8   
+9   	static int foo(HashMap<UseOfNonHashableClassInHashDataStructure, String> map) {
+10  		return map.size();
+11  	}
+12  	@Override
+13  	public boolean equals(Object o) {
+14  		return hashCode() == o.hashCode();
+15  	}
+16  
+17  	public static String add(UseOfNonHashableClassInHashDataStructure b,
+18  			String s) {
+19  		return m.put(b, s);
+20  	}
+21  
+22  	public static String get(UseOfNonHashableClassInHashDataStructure b) {
+23  		return m.get(b);
+24  	}
+25  }
diff --git a/src/site/resources/examples/xref/UselessAssignments.html b/src/site/resources/examples/xref/UselessAssignments.html index 5da624fba..b6b6cad9c 100644 --- a/src/site/resources/examples/xref/UselessAssignments.html +++ b/src/site/resources/examples/xref/UselessAssignments.html @@ -8,43 +8,43 @@ 
-1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
-3   class UselessAssignments {
-4   	@ExpectWarning("UuF,UrF")
-5   	int foo, bar,g1,g2;
-6   
-7   	@ExpectWarning("DLS,SA")
-8   	public UselessAssignments(int Foo, int Bar) {
-9   		int x,y;
-10  		foo = foo;
-11  		Bar = Bar;
-12  		g1 = g1 = 0;
-13  		x = x = 0;
-14  	}
-15  
-16  	static void setFoo(UselessAssignments ua1, UselessAssignments ua2) {
-17  		ua1.foo = ua2.foo = 1;
-18  		ua1.bar = ua1.bar = ua1.bar = 2;
-19      }
-20  
-21  	int oops() {
-22  		int i = 7;
-23          i = ++i;
-24  		i = i++;
-25  		foo = foo++;
-26  		foo = ++foo;
-27          return i;
-28  	}
-29  
-30  	public static void report(UselessAssignments ua1, UselessAssignments ua2) {
-31  		ua1.foo = ua1.foo = ua1.foo = 17;
-32  	}
-33      public static void doNotReport(UselessAssignments ua1, UselessAssignments ua2) {
-34  		ua1.bar = ua2.bar = 42;
-35  	}
-36  
-37  }
+1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+2   
+3   class UselessAssignments {
+4   	@ExpectWarning("UuF,UrF")
+5   	int foo, bar,g1,g2;
+6   
+7   	@ExpectWarning("DLS,SA")
+8   	public UselessAssignments(int Foo, int Bar) {
+9   		int x,y;
+10  		foo = foo;
+11  		Bar = Bar;
+12  		g1 = g1 = 0;
+13  		x = x = 0;
+14  	}
+15  
+16  	static void setFoo(UselessAssignments ua1, UselessAssignments ua2) {
+17  		ua1.foo = ua2.foo = 1;
+18  		ua1.bar = ua1.bar = ua1.bar = 2;
+19      }
+20  
+21  	int oops() {
+22  		int i = 7;
+23          i = ++i;
+24  		i = i++;
+25  		foo = foo++;
+26  		foo = ++foo;
+27          return i;
+28  	}
+29  
+30  	public static void report(UselessAssignments ua1, UselessAssignments ua2) {
+31  		ua1.foo = ua1.foo = ua1.foo = 17;
+32  	}
+33      public static void doNotReport(UselessAssignments ua1, UselessAssignments ua2) {
+34  		ua1.bar = ua2.bar = 42;
+35  	}
+36  
+37  }
diff --git a/src/site/resources/examples/xref/UselessControlFlow.html b/src/site/resources/examples/xref/UselessControlFlow.html index a2a2431f8..d603da56a 100644 --- a/src/site/resources/examples/xref/UselessControlFlow.html +++ b/src/site/resources/examples/xref/UselessControlFlow.html @@ -8,47 +8,47 @@ 
-1   
-2   public class UselessControlFlow {
-3   
-4   	void harmless1(Object x, Object y) {
-5   		if (!x.equals(y)) {
-6   
-7   		} else {
-8   
-9   		}
-10  		System.out.println(x);
-11  		System.out.println(y);
-12  	}
-13  	void report0(Object x, Object y) {
-14  		if (!x.equals(y)); System.out.println(x);
-15  		System.out.println(y);
-16  	}
-17  	void report1(Object x, Object y) {
-18  		if (!x.equals(y));
-19  		  System.out.println(x);
-20  		System.out.println(y);
-21  	}
-22  	void report2(Object x, Object y) {
-23  		if (!x.equals(y));
-24  
-25  		  System.out.println(x);
-26  		System.out.println(y);
-27  	}
-28  	void report3(Object x, Object y) {
-29  		if (!x.equals(y));
-30  
-31  
-32  		  System.out.println(x);
-33  		System.out.println(y);
-34  	}
-35  	void report4(Object [] x, Object y) {
-36  		for(Object o : x) {
-37  			if (o.equals(y)) {
-38  			}
-39  		}
-40  	}
-41  }
+1   
+2   public class UselessControlFlow {
+3   
+4   	void harmless1(Object x, Object y) {
+5   		if (!x.equals(y)) {
+6   
+7   		} else {
+8   
+9   		}
+10  		System.out.println(x);
+11  		System.out.println(y);
+12  	}
+13  	void report0(Object x, Object y) {
+14  		if (!x.equals(y)); System.out.println(x);
+15  		System.out.println(y);
+16  	}
+17  	void report1(Object x, Object y) {
+18  		if (!x.equals(y));
+19  		  System.out.println(x);
+20  		System.out.println(y);
+21  	}
+22  	void report2(Object x, Object y) {
+23  		if (!x.equals(y));
+24  
+25  		  System.out.println(x);
+26  		System.out.println(y);
+27  	}
+28  	void report3(Object x, Object y) {
+29  		if (!x.equals(y));
+30  
+31  
+32  		  System.out.println(x);
+33  		System.out.println(y);
+34  	}
+35  	void report4(Object [] x, Object y) {
+36  		for(Object o : x) {
+37  			if (o.equals(y)) {
+38  			}
+39  		}
+40  	}
+41  }
diff --git a/src/site/resources/examples/xref/UselessCurrentThread.html b/src/site/resources/examples/xref/UselessCurrentThread.html index 9b5ae0385..1d745631b 100644 --- a/src/site/resources/examples/xref/UselessCurrentThread.html +++ b/src/site/resources/examples/xref/UselessCurrentThread.html @@ -8,43 +8,43 @@ 
-1   
-2   public class UselessCurrentThread implements Runnable {
-3   	private Thread unknownThread;
-4   
-5   	public UselessCurrentThread(Thread t) {
-6   		unknownThread = t;
-7   	}
-8   
-9   	public void run() {
-10  		try {
-11  			// The first should be ok, the next two are silly, the third is
-12  			// wrong
-13  			while (!Thread.interrupted()) {
-14  				System.out.println("huh?");
-15  				Thread.sleep(10000);
-16  			}
-17  
-18  			while (!Thread.currentThread().interrupted()) {
-19  				System.out.println("huh?");
-20  				Thread.sleep(10000);
-21  			}
-22  
-23  			Thread t = Thread.currentThread();
-24  			while (!t.interrupted()) {
-25  				System.out.println("huh?");
-26  				Thread.sleep(10000);
-27  			}
-28  
-29  			while (!unknownThread.interrupted()) {
-30  				System.out.println("huh?");
-31  				Thread.sleep(10000);
-32  			}
-33  		} catch (InterruptedException ie) {
-34  			System.out.println("Oh, ok");
-35  		}
-36  	}
-37  }
+1   
+2   public class UselessCurrentThread implements Runnable {
+3   	private Thread unknownThread;
+4   
+5   	public UselessCurrentThread(Thread t) {
+6   		unknownThread = t;
+7   	}
+8   
+9   	public void run() {
+10  		try {
+11  			// The first should be ok, the next two are silly, the third is
+12  			// wrong
+13  			while (!Thread.interrupted()) {
+14  				System.out.println("huh?");
+15  				Thread.sleep(10000);
+16  			}
+17  
+18  			while (!Thread.currentThread().interrupted()) {
+19  				System.out.println("huh?");
+20  				Thread.sleep(10000);
+21  			}
+22  
+23  			Thread t = Thread.currentThread();
+24  			while (!t.interrupted()) {
+25  				System.out.println("huh?");
+26  				Thread.sleep(10000);
+27  			}
+28  
+29  			while (!unknownThread.interrupted()) {
+30  				System.out.println("huh?");
+31  				Thread.sleep(10000);
+32  			}
+33  		} catch (InterruptedException ie) {
+34  			System.out.println("Oh, ok");
+35  		}
+36  	}
+37  }
diff --git a/src/site/resources/examples/xref/UselessFinalize.html b/src/site/resources/examples/xref/UselessFinalize.html index ed8e4e921..7327e10b7 100644 --- a/src/site/resources/examples/xref/UselessFinalize.html +++ b/src/site/resources/examples/xref/UselessFinalize.html @@ -8,12 +8,12 @@ 
-1   class UselessFinalize {
-2   	@Override
-3   	protected void finalize() throws Throwable {
-4   		super.finalize();
-5   	}
-6   }
+1   class UselessFinalize {
+2   	@Override
+3   	protected void finalize() throws Throwable {
+4   		super.finalize();
+5   	}
+6   }
diff --git a/src/site/resources/examples/xref/UselessSCMethods.html b/src/site/resources/examples/xref/UselessSCMethods.html index b13b6c7bc..d5bd63dd8 100644 --- a/src/site/resources/examples/xref/UselessSCMethods.html +++ b/src/site/resources/examples/xref/UselessSCMethods.html @@ -8,54 +8,54 @@ 
-1   
-2   class Super {
-3   	public void test1() {
-4   	}
-5   
-6   	public int test2(String s) {
-7   		return 1;
-8   	}
-9   
-10  	public double test3(double d, int i, Object o, float f, long l) {
-11  		return 0.0;
-12  	}
-13  
-14  	protected void test4(String s) {
-15  	}
-16  
-17  	public void test5(String[] s) {
-18  	}
-19  }
-20  
-21  public class UselessSCMethods extends Super {
-22  	@Override
-23  	public void test1() {
-24  		super.test1();
-25  	}
-26  
-27  	@Override
-28  	public int test2(String s) {
-29  		return super.test2(s);
-30  	}
-31  
-32  	@Override
-33  	public double test3(double d, int i, Object o, float f, long l) {
-34  		return super.test3(d, i, o, f, l);
-35  	}
-36  
-37  	@Override
-38  	public void test4(String s) { // don't report this, altho suspect, access
-39  									// has been widened
-40  		// perhaps this should be reported as another bug type, dunno
-41  		super.test4(s);
-42  	}
-43  
-44  	@Override
-45  	public void test5(String[] s) {
-46  		super.test5(s);
-47  	}
-48  }
+1   
+2   class Super {
+3   	public void test1() {
+4   	}
+5   
+6   	public int test2(String s) {
+7   		return 1;
+8   	}
+9   
+10  	public double test3(double d, int i, Object o, float f, long l) {
+11  		return 0.0;
+12  	}
+13  
+14  	protected void test4(String s) {
+15  	}
+16  
+17  	public void test5(String[] s) {
+18  	}
+19  }
+20  
+21  public class UselessSCMethods extends Super {
+22  	@Override
+23  	public void test1() {
+24  		super.test1();
+25  	}
+26  
+27  	@Override
+28  	public int test2(String s) {
+29  		return super.test2(s);
+30  	}
+31  
+32  	@Override
+33  	public double test3(double d, int i, Object o, float f, long l) {
+34  		return super.test3(d, i, o, f, l);
+35  	}
+36  
+37  	@Override
+38  	public void test4(String s) { // don't report this, altho suspect, access
+39  									// has been widened
+40  		// perhaps this should be reported as another bug type, dunno
+41  		super.test4(s);
+42  	}
+43  
+44  	@Override
+45  	public void test5(String[] s) {
+46  		super.test5(s);
+47  	}
+48  }
diff --git a/src/site/resources/examples/xref/UserAss3rtion.html b/src/site/resources/examples/xref/UserAss3rtion.html index a9d3b3c1a..3c4a6a949 100644 --- a/src/site/resources/examples/xref/UserAss3rtion.html +++ b/src/site/resources/examples/xref/UserAss3rtion.html @@ -8,17 +8,17 @@ 
-1   public class UserAss3rtion {
-2   	public static void makeSureItIsOK(boolean cond) {
-3   		if (!cond)
-4   			throw new IllegalStateException();
-5   	}
-6   
-7   	public void f(Object o) {
-8   		UserAss3rtion.makeSureItIsOK(o != null);
-9   		System.out.println(o.hashCode());
-10  	}
-11  }
+1   public class UserAss3rtion {
+2   	public static void makeSureItIsOK(boolean cond) {
+3   		if (!cond)
+4   			throw new IllegalStateException();
+5   	}
+6   
+7   	public void f(Object o) {
+8   		UserAss3rtion.makeSureItIsOK(o != null);
+9   		System.out.println(o.hashCode());
+10  	}
+11  }
diff --git a/src/site/resources/examples/xref/UserMistakes.html b/src/site/resources/examples/xref/UserMistakes.html index 194405082..83298dec0 100644 --- a/src/site/resources/examples/xref/UserMistakes.html +++ b/src/site/resources/examples/xref/UserMistakes.html @@ -8,55 +8,55 @@ 
-1   
-2   
-3   import java.io.BufferedReader;
-4   import java.io.FileNotFoundException;
-5   import java.io.FileReader;
-6   import java.io.IOException;
-7   import java.io.LineNumberReader;
-8   
-9   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-10  
-11  public class UserMistakes {
-12  	@ExpectWarning("RE,RV")
-13  	public static void main(String[] args) throws IOException {
-14  		String name="Mr. Ed";
-15  		name=name.replaceAll(".", "s.");
-16  		System.out.println(name);
-17  
-18  
-19  		//FIXME:SpotBugs only catches this error with name.indexOf(String)
-20  		if (name.indexOf("s") > 0)
-21  			System.out.println("Yay");
-22  		else
-23  			System.out.println("Boo");
-24  
-25  		String result;
-26  
-27  		try 
-28  		{
-29  			BufferedReader findFiles=new BufferedReader(new FileReader("/mainList.txt"));
-30  			if (findFiles.readLine()!=null)
-31  				result=findFiles.readLine();
-32  			findFiles.close();
-33  		} catch (FileNotFoundException e) {
-34  			System.exit(7);
-35  			e.printStackTrace();
-36  		} catch (IOException e) {
-37  			e.printStackTrace();
-38  		}
-39  
-40  
-41  
-42  		LineNumberReader tmp=new LineNumberReader(new FileReader("/mainList.txt"));
-43  		int count = 0;
-44  		while (tmp.readLine()!=null) count++;
-45            
-46  		tmp.close();
-47  }
-48  
-49  }
+1   
+2   
+3   import java.io.BufferedReader;
+4   import java.io.FileNotFoundException;
+5   import java.io.FileReader;
+6   import java.io.IOException;
+7   import java.io.LineNumberReader;
+8   
+9   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+10  
+11  public class UserMistakes {
+12  	@ExpectWarning("RE,RV")
+13  	public static void main(String[] args) throws IOException {
+14  		String id="Mr. Ed";
+15  		id=name.replaceAll(".", "s.");
+16  		System.out.println(name);
+17  
+18  
+19  		//FIXME:SpotBugs only catches this error with name.indexOf(String)
+20  		if (name.indexOf("s") > 0)
+21  			System.out.println("Yay");
+22  		else
+23  			System.out.println("Boo");
+24  
+25  		String result;
+26  
+27  		try 
+28  		{
+29  			BufferedReader findFiles=new BufferedReader(new FileReader("/mainList.txt"));
+30  			if (findFiles.readLine()!=null)
+31  				result=findFiles.readLine();
+32  			findFiles.close();
+33  		} catch (FileNotFoundException e) {
+34  			System.exit(7);
+35  			e.printStackTrace();
+36  		} catch (IOException e) {
+37  			e.printStackTrace();
+38  		}
+39  
+40  
+41  
+42  		LineNumberReader tmp=new LineNumberReader(new FileReader("/mainList.txt"));
+43  		int count = 0;
+44  		while (tmp.readLine()!=null) count++;
+45            
+46  		tmp.close();
+47  }
+48  
+49  }
diff --git a/src/site/resources/examples/xref/badNaming/package1/A.html b/src/site/resources/examples/xref/badNaming/package1/A.html index bc7436a6b..4f3f19407 100644 --- a/src/site/resources/examples/xref/badNaming/package1/A.html +++ b/src/site/resources/examples/xref/badNaming/package1/A.html @@ -8,11 +8,11 @@ 
-1   package badNaming.package1;
-2   
-3   public class A {
-4   
-5   }
+1   package badNaming.package1;
+2   
+3   public class A {
+4   
+5   }
diff --git a/src/site/resources/examples/xref/badNaming/package2/A.html b/src/site/resources/examples/xref/badNaming/package2/A.html index 0692408f8..58eb724f2 100644 --- a/src/site/resources/examples/xref/badNaming/package2/A.html +++ b/src/site/resources/examples/xref/badNaming/package2/A.html @@ -8,11 +8,11 @@ 
-1   package badNaming.package2;
-2   
-3   public class A {
-4   
-5   }
+1   package badNaming.package2;
+2   
+3   public class A {
+4   
+5   }
diff --git a/src/site/resources/examples/xref/badNaming/package2/AnInterface.html b/src/site/resources/examples/xref/badNaming/package2/AnInterface.html index 679ab78ea..9fe2c5f5e 100644 --- a/src/site/resources/examples/xref/badNaming/package2/AnInterface.html +++ b/src/site/resources/examples/xref/badNaming/package2/AnInterface.html @@ -8,12 +8,12 @@ 
-1   package badNaming.package2;
-2   
-3   public interface AnInterface {
-4   	public void test2(A a);
-5   
-6   }
+1   package badNaming.package2;
+2   
+3   public interface AnInterface {
+4   	public void test2(A a);
+5   
+6   }
diff --git a/src/site/resources/examples/xref/equals/ArrayEquality.html b/src/site/resources/examples/xref/equals/ArrayEquality.html index 7a67d2dc5..2e53ccb8c 100644 --- a/src/site/resources/examples/xref/equals/ArrayEquality.html +++ b/src/site/resources/examples/xref/equals/ArrayEquality.html @@ -8,45 +8,45 @@ 
-1   package equals;
-2   
-3   import java.io.Serializable;
-4   
-5   public class ArrayEquality {
-6   
-7   	boolean reportProblemsWithArrayEquality(String[] a, String b) {
-8   		return a.equals(b);
-9   	}
-10  
-11  	boolean reportProblemsWithArrayEquality2(String[] a, String b) {
-12  		return  b.equals(a);
-13  	}
-14  	boolean reportProblemsWithArrayEquality3(String[] a, String []b) {
-15  		return a.equals(b);
-16  	}
-17  	boolean reportProblemsWithArrayEquality4(String[][] a, String []b) {
-18  		return a.equals(b);
-19  	}
-20  	boolean reportProblemsWithArrayEquality5(String[] a, String [][]b) {
-21  		return a.equals(b);
-22  	}
-23  	boolean reportProblemsWithArrayEquality6(String[] a, int []b) {
-24  		return a.equals(b);
-25  	}
-26  	boolean reportProblemsWithArrayEquality7(int[] a, String []b) {
-27  		return a.equals(b);
-28  	}
-29  	boolean reportProblemsWithArrayEquality8(StringBuffer[] a, String []b) {
-30  		return a.equals(b);
-31  	}
-32  	boolean reportProblemsWithArrayEqualityFalsePositive1(String[] a, Serializable b) {
-33  		return a.equals(b) || b.equals(a);
-34  	}
-35  	boolean reportProblemsWithArrayEqualityFalsePositive2(String[] a, Cloneable b) {
-36  		return a.equals(b) || b.equals(a);
-37  	}
-38  
-39  }
+1   package equals;
+2   
+3   import java.io.Serializable;
+4   
+5   public class ArrayEquality {
+6   
+7   	boolean reportProblemsWithArrayEquality(String[] a, String b) {
+8   		return a.equals(b);
+9   	}
+10  
+11  	boolean reportProblemsWithArrayEquality2(String[] a, String b) {
+12  		return  b.equals(a);
+13  	}
+14  	boolean reportProblemsWithArrayEquality3(String[] a, String []b) {
+15  		return a.equals(b);
+16  	}
+17  	boolean reportProblemsWithArrayEquality4(String[][] a, String []b) {
+18  		return a.equals(b);
+19  	}
+20  	boolean reportProblemsWithArrayEquality5(String[] a, String [][]b) {
+21  		return a.equals(b);
+22  	}
+23  	boolean reportProblemsWithArrayEquality6(String[] a, int []b) {
+24  		return a.equals(b);
+25  	}
+26  	boolean reportProblemsWithArrayEquality7(int[] a, String []b) {
+27  		return a.equals(b);
+28  	}
+29  	boolean reportProblemsWithArrayEquality8(StringBuffer[] a, String []b) {
+30  		return a.equals(b);
+31  	}
+32  	boolean reportProblemsWithArrayEqualityFalsePositive1(String[] a, Serializable b) {
+33  		return a.equals(b) || b.equals(a);
+34  	}
+35  	boolean reportProblemsWithArrayEqualityFalsePositive2(String[] a, Cloneable b) {
+36  		return a.equals(b) || b.equals(a);
+37  	}
+38  
+39  }
diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html b/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html index bbdb924b9..8392c0f1a 100644 --- a/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html +++ b/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html @@ -8,163 +8,163 @@ 
-1   package gcUnrelatedTypes;
-2   
-3   import java.util.ArrayList;
-4   import java.util.Collection;
-5   import java.util.HashSet;
-6   import java.util.Iterator;
-7   import java.util.LinkedList;
-8   import java.util.List;
-9   import java.util.ListIterator;
-10  import java.util.Set;
-11  
-12  public class AllListsCouldBeEqual {
-13  	
-14  	static class MyList<E> implements List<E> {
-15  
-16  		public boolean add(E o) {
-17  	        // TODO Auto-generated method stub
-18  	        return false;
-19          }
-20  
-21  		public void add(int index, E element) {
-22  	        // TODO Auto-generated method stub
-23  	        
-24          }
-25  
-26  		public boolean addAll(Collection<? extends E> c) {
-27  	        // TODO Auto-generated method stub
-28  	        return false;
-29          }
-30  
-31  		public boolean addAll(int index, Collection<? extends E> c) {
-32  	        // TODO Auto-generated method stub
-33  	        return false;
-34          }
-35  
-36  		public void clear() {
-37  	        // TODO Auto-generated method stub
-38  	        
-39          }
-40  
-41  		public boolean contains(Object o) {
-42  	        // TODO Auto-generated method stub
-43  	        return false;
-44          }
-45  
-46  		public boolean containsAll(Collection<?> c) {
-47  	        // TODO Auto-generated method stub
-48  	        return false;
-49          }
-50  
-51  		public E get(int index) {
-52  	        // TODO Auto-generated method stub
-53  	        return null;
-54          }
-55  
-56  		public int indexOf(Object o) {
-57  	        // TODO Auto-generated method stub
-58  	        return 0;
-59          }
-60  
-61  		public boolean isEmpty() {
-62  	        // TODO Auto-generated method stub
-63  	        return false;
-64          }
-65  
-66  		public Iterator<E> iterator() {
-67  	        // TODO Auto-generated method stub
-68  	        return null;
-69          }
-70  
-71  		public int lastIndexOf(Object o) {
-72  	        // TODO Auto-generated method stub
-73  	        return 0;
-74          }
-75  
-76  		public ListIterator<E> listIterator() {
-77  	        // TODO Auto-generated method stub
-78  	        return null;
-79          }
-80  
-81  		public ListIterator<E> listIterator(int index) {
-82  	        // TODO Auto-generated method stub
-83  	        return null;
-84          }
-85  
-86  		public boolean remove(Object o) {
-87  	        // TODO Auto-generated method stub
-88  	        return false;
-89          }
-90  
-91  		public E remove(int index) {
-92  	        // TODO Auto-generated method stub
-93  	        return null;
-94          }
-95  
-96  		public boolean removeAll(Collection<?> c) {
-97  	        // TODO Auto-generated method stub
-98  	        return false;
-99          }
-100 
-101 		public boolean retainAll(Collection<?> c) {
-102 	        // TODO Auto-generated method stub
-103 	        return false;
-104         }
-105 
-106 		public E set(int index, E element) {
-107 	        // TODO Auto-generated method stub
-108 	        return null;
-109         }
-110 
-111 		public int size() {
-112 	        // TODO Auto-generated method stub
-113 	        return 0;
-114         }
-115 
-116 		public List<E> subList(int fromIndex, int toIndex) {
-117 	        // TODO Auto-generated method stub
-118 	        return null;
-119         }
-120 
-121 		public Object[] toArray() {
-122 	        // TODO Auto-generated method stub
-123 	        return null;
-124         }
-125 
-126 		public <T> T[] toArray(T[] a) {
-127 	        // TODO Auto-generated method stub
-128 	        return null;
-129         }}
-130 	public static void main(String arg[]) {
-131 		falsePositive();
-132 		
-133 		List<Integer> lst = new LinkedList<Integer>();
-134 		List<Integer> lst2 = (ArrayList<Integer>)lst;
-135 		
-136 		
-137 		List<ArrayList<String>> mlist = null;
-138 		mlist.contains(new LinkedList<String>());
-139 
-140 	}
-141 	public static void falsePositive() {
-142 		ArrayList<Integer> aLst = new ArrayList<Integer>();
-143 		LinkedList<Integer> lLst = new LinkedList<Integer>();
-144 		MyList<Integer> mLst = new MyList<Integer>();
-145 		
-146 		Set<ArrayList<Integer>> alSet = new HashSet<ArrayList<Integer>>();
-147 		Set<LinkedList<Integer>> llSet = new HashSet<LinkedList<Integer>>();
-148 		
-149 		System.out.println(aLst.equals(lLst));
-150 		System.out.println(mLst.equals(lLst));
-151 		
-152 		alSet.contains(lLst);
-153 		alSet.contains(mLst);
-154 		alSet.containsAll(llSet);
-155 
-156 	}
-157 }
+1   package gcUnrelatedTypes;
+2   
+3   import java.util.ArrayList;
+4   import java.util.Collection;
+5   import java.util.HashSet;
+6   import java.util.Iterator;
+7   import java.util.LinkedList;
+8   import java.util.List;
+9   import java.util.ListIterator;
+10  import java.util.Set;
+11  
+12  public class AllListsCouldBeEqual {
+13  	
+14  	static class MyList<E> implements List<E> {
+15  
+16  		public boolean add(E o) {
+17  	        // TODO Auto-generated method stub
+18  	        return false;
+19          }
+20  
+21  		public void add(int index, E element) {
+22  	        // TODO Auto-generated method stub
+23  	        
+24          }
+25  
+26  		public boolean addAll(Collection<? extends E> c) {
+27  	        // TODO Auto-generated method stub
+28  	        return false;
+29          }
+30  
+31  		public boolean addAll(int index, Collection<? extends E> c) {
+32  	        // TODO Auto-generated method stub
+33  	        return false;
+34          }
+35  
+36  		public void clear() {
+37  	        // TODO Auto-generated method stub
+38  	        
+39          }
+40  
+41  		public boolean contains(Object o) {
+42  	        // TODO Auto-generated method stub
+43  	        return false;
+44          }
+45  
+46  		public boolean containsAll(Collection<?> c) {
+47  	        // TODO Auto-generated method stub
+48  	        return false;
+49          }
+50  
+51  		public E get(int index) {
+52  	        // TODO Auto-generated method stub
+53  	        return null;
+54          }
+55  
+56  		public int indexOf(Object o) {
+57  	        // TODO Auto-generated method stub
+58  	        return 0;
+59          }
+60  
+61  		public boolean isEmpty() {
+62  	        // TODO Auto-generated method stub
+63  	        return false;
+64          }
+65  
+66  		public Iterator<E> iterator() {
+67  	        // TODO Auto-generated method stub
+68  	        return null;
+69          }
+70  
+71  		public int lastIndexOf(Object o) {
+72  	        // TODO Auto-generated method stub
+73  	        return 0;
+74          }
+75  
+76  		public ListIterator<E> listIterator() {
+77  	        // TODO Auto-generated method stub
+78  	        return null;
+79          }
+80  
+81  		public ListIterator<E> listIterator(int index) {
+82  	        // TODO Auto-generated method stub
+83  	        return null;
+84          }
+85  
+86  		public boolean remove(Object o) {
+87  	        // TODO Auto-generated method stub
+88  	        return false;
+89          }
+90  
+91  		public E remove(int index) {
+92  	        // TODO Auto-generated method stub
+93  	        return null;
+94          }
+95  
+96  		public boolean removeAll(Collection<?> c) {
+97  	        // TODO Auto-generated method stub
+98  	        return false;
+99          }
+100 
+101 		public boolean retainAll(Collection<?> c) {
+102 	        // TODO Auto-generated method stub
+103 	        return false;
+104         }
+105 
+106 		public E set(int index, E element) {
+107 	        // TODO Auto-generated method stub
+108 	        return null;
+109         }
+110 
+111 		public int size() {
+112 	        // TODO Auto-generated method stub
+113 	        return 0;
+114         }
+115 
+116 		public List<E> subList(int fromIndex, int toIndex) {
+117 	        // TODO Auto-generated method stub
+118 	        return null;
+119         }
+120 
+121 		public Object[] toArray() {
+122 	        // TODO Auto-generated method stub
+123 	        return null;
+124         }
+125 
+126 		public <T> T[] toArray(T[] a) {
+127 	        // TODO Auto-generated method stub
+128 	        return null;
+129         }}
+130 	public static void main(String arg[]) {
+131 		falsePositive();
+132 		
+133 		List<Integer> lst = new LinkedList<Integer>();
+134 		List<Integer> lst2 = (ArrayList<Integer>)lst;
+135 		
+136 		
+137 		List<ArrayList<String>> mlist = null;
+138 		mlist.contains(new LinkedList<String>());
+139 
+140 	}
+141 	public static void falsePositive() {
+142 		ArrayList<Integer> aLst = new ArrayList<Integer>();
+143 		LinkedList<Integer> lLst = new LinkedList<Integer>();
+144 		MyList<Integer> mLst = new MyList<Integer>();
+145 		
+146 		Set<ArrayList<Integer>> alSet = new HashSet<ArrayList<Integer>>();
+147 		Set<LinkedList<Integer>> llSet = new HashSet<LinkedList<Integer>>();
+148 		
+149 		System.out.println(aLst.equals(lLst));
+150 		System.out.println(mLst.equals(lLst));
+151 		
+152 		alSet.contains(lLst);
+153 		alSet.contains(mLst);
+154 		alSet.containsAll(llSet);
+155 
+156 	}
+157 }
diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html index 152e41e6d..3ef3e30d3 100644 --- a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html +++ b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html @@ -8,157 +8,157 @@ 
-1   package gcUnrelatedTypes;
-2   
-3   import java.util.ArrayList;
-4   
-5   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-6   
-7   public class ArrayListContains<T> {
-8   
-9   	static class Dummy {
-10  
-11  	}
-12  
-13  	static class DummyChild extends Dummy {
-14  
-15  	}
-16  
-17  	private ArrayList<?> wildcardF;
-18  
-19  	private ArrayList<Dummy> dummyF;
-20  	private ArrayList<? extends Dummy> dummyEF;
-21  	private ArrayList<? super Dummy> dummySF;
-22  
-23  	private ArrayList<DummyChild> childF;
-24  	private ArrayList<? extends DummyChild> childEF;
-25  	private ArrayList<? super DummyChild> childSF;
-26  
-27  	private ArrayList<T> genericF;		
-28  	private ArrayList<? extends T> genericEF;
-29  	private ArrayList<? super T> genericSF;		
-30  
-31  	@ExpectWarning("GC")
-32  	public ArrayListContains(
-33  			ArrayList<?> wildcardF, 
-34  			ArrayList<Dummy> dummyF, 
-35  			ArrayList<? extends Dummy> dummyEF, 
-36  			ArrayList<? super Dummy> dummySF, 
-37  			ArrayList<DummyChild> childF, 
-38  			ArrayList<? extends DummyChild> childEF, 
-39  			ArrayList<? super DummyChild> childSF, 
-40  			ArrayList<T> genericF, 
-41  			ArrayList<? extends T> genericEF, 
-42  			ArrayList<? super T> genericSF) {
-43  		this.wildcardF = wildcardF;
-44  		this.dummyF = dummyF;
-45  		this.dummyEF = dummyEF;
-46  		this.dummySF = dummySF;
-47  		this.childF = childF;
-48  		this.childEF = childEF;
-49  		this.childSF = childSF;
-50  		this.genericF = genericF;
-51  		this.genericEF = genericEF;
-52  		this.genericSF = genericSF;
-53  
-54  		Dummy dummy = new Dummy();
-55  		DummyChild dummyChild = new DummyChild();
-56  		String s = "Mismatched Type";
-57  
-58  		wildcardF.contains(dummy); 				// No warning
-59  		wildcardF.contains(dummyChild); 		// No warning
-60  		wildcardF.contains(s); 					// No warning
-61  
-62  		dummyF.contains(dummy); 				// No warning
-63  		dummyF.contains(dummyChild); 		 	// No warning
-64  		dummyF.contains(s); 					// HIGH
-65  
-66  		dummyEF.contains(dummy); 				// No warning
-67  		dummyEF.contains(dummyChild); 		 	// No warning
-68  		dummyEF.contains(s); 					// HIGH
-69  
-70  		dummySF.contains(dummy); 				// No warning
-71  		dummySF.contains(dummyChild); 		 	// No warning
-72  		dummySF.contains(s); 					// HIGH
-73  
-74  		childF.contains(dummy); 				// No warning
-75  		childF.contains(dummyChild); 		 	// No warning
-76  		childF.contains(s); 					// HIGH
-77  
-78  		childEF.contains(dummy); 				// No warning
-79  		childEF.contains(dummyChild); 		 	// No warning
-80  		childEF.contains(s); 					// HIGH
-81  
-82  		childSF.contains(dummy); 				// No warning
-83  		childSF.contains(dummyChild); 		 	// No warning
-84  		childSF.contains(s); 					// HIGH
-85  
-86  		genericF.contains(dummy); 				// No warning
-87  		genericF.contains(dummyChild); 		 	// No warning
-88  		genericF.contains(s); 					// No warning
-89  
-90  		genericEF.contains(dummy); 				// No warning
-91  		genericEF.contains(dummyChild); 		    // No warning
-92  		genericEF.contains(s); 					// No warning
-93  
-94  		genericSF.contains(dummy); 				// No warning
-95  		genericSF.contains(dummyChild); 		// No warning
-96  		genericSF.contains(s); 					// No warning
-97  
-98  	}
-99  
-100 	@ExpectWarning("GC")
-101 	public void testFields() {
-102 		Dummy dummy = new Dummy();
-103 		DummyChild dummyChild = new DummyChild();
-104 		String s = "Mismatched Type";
-105 
-106 		wildcardF.contains(dummy); 				// No warning
-107 		wildcardF.contains(dummyChild); 		// No warning
-108 		wildcardF.contains(s); 					// No warning
-109 
-110 		dummyF.contains(dummy); 				// No warning
-111 		dummyF.contains(dummyChild); 		 	// No warning
-112 		dummyF.contains(s); 					// HIGH
-113 
-114 		dummyEF.contains(dummy); 				// No warning
-115 		dummyEF.contains(dummyChild); 		 	// No warning
-116 		dummyEF.contains(s); 					// HIGH
-117 
-118 		dummySF.contains(dummy); 				// No warning
-119 		dummySF.contains(dummyChild); 		 	// No warning
-120 		dummySF.contains(s); 					// HIGH
-121 
-122 		childF.contains(dummy); 				// No warning
-123 		childF.contains(dummyChild); 		 	// No warning
-124 		childF.contains(s); 					// HIGH
-125 
-126 		childEF.contains(dummy); 				// No warning
-127 		childEF.contains(dummyChild); 		 	// No warning
-128 		childEF.contains(s); 					// HIGH
-129 
-130 		childSF.contains(dummy); 				// No warning
-131 		childSF.contains(dummyChild); 		 	// No warning
-132 		childSF.contains(s); 					// HIGH
-133 
-134 		genericF.contains(dummy); 				// No warning
-135 		genericF.contains(dummyChild); 		 	// No warning
-136 		genericF.contains(s); 					// No warning
-137 
-138 		genericEF.contains(dummy); 				// No warning
-139 		genericEF.contains(dummyChild); 		// No warning
-140 		genericEF.contains(s); 					// No warning
-141 
-142 		genericSF.contains(dummy); 				// No warning
-143 		genericSF.contains(dummyChild); 		// No warning
-144 		genericSF.contains(s); 					// No warning
-145 
-146 		// what if <T extends Dummy> in class definition? 
-147 		// Requires more analysis -- a future enhancement
-148 		// Can we be sure that the T is the same as the one in the class/method definition
-149 
-150 	}
-151 }
+1   package gcUnrelatedTypes;
+2   
+3   import java.util.ArrayList;
+4   
+5   import edu.umd.cs.findbugs.annotations.ExpectWarning;
+6   
+7   public class ArrayListContains<T> {
+8   
+9   	static class Dummy {
+10  
+11  	}
+12  
+13  	static class DummyChild extends Dummy {
+14  
+15  	}
+16  
+17  	private ArrayList<?> wildcardF;
+18  
+19  	private ArrayList<Dummy> dummyF;
+20  	private ArrayList<? extends Dummy> dummyEF;
+21  	private ArrayList<? super Dummy> dummySF;
+22  
+23  	private ArrayList<DummyChild> childF;
+24  	private ArrayList<? extends DummyChild> childEF;
+25  	private ArrayList<? super DummyChild> childSF;
+26  
+27  	private ArrayList<T> genericF;		
+28  	private ArrayList<? extends T> genericEF;
+29  	private ArrayList<? super T> genericSF;		
+30  
+31  	@ExpectWarning("GC")
+32  	public ArrayListContains(
+33  			ArrayList<?> wildcardF, 
+34  			ArrayList<Dummy> dummyF, 
+35  			ArrayList<? extends Dummy> dummyEF, 
+36  			ArrayList<? super Dummy> dummySF, 
+37  			ArrayList<DummyChild> childF, 
+38  			ArrayList<? extends DummyChild> childEF, 
+39  			ArrayList<? super DummyChild> childSF, 
+40  			ArrayList<T> genericF, 
+41  			ArrayList<? extends T> genericEF, 
+42  			ArrayList<? super T> genericSF) {
+43  		this.wildcardF = wildcardF;
+44  		this.dummyF = dummyF;
+45  		this.dummyEF = dummyEF;
+46  		this.dummySF = dummySF;
+47  		this.childF = childF;
+48  		this.childEF = childEF;
+49  		this.childSF = childSF;
+50  		this.genericF = genericF;
+51  		this.genericEF = genericEF;
+52  		this.genericSF = genericSF;
+53  
+54  		Dummy dummy = new Dummy();
+55  		DummyChild dummyChild = new DummyChild();
+56  		String s = "Mismatched Type";
+57  
+58  		wildcardF.contains(dummy); 				// No warning
+59  		wildcardF.contains(dummyChild); 		// No warning
+60  		wildcardF.contains(s); 					// No warning
+61  
+62  		dummyF.contains(dummy); 				// No warning
+63  		dummyF.contains(dummyChild); 		 	// No warning
+64  		dummyF.contains(s); 					// HIGH
+65  
+66  		dummyEF.contains(dummy); 				// No warning
+67  		dummyEF.contains(dummyChild); 		 	// No warning
+68  		dummyEF.contains(s); 					// HIGH
+69  
+70  		dummySF.contains(dummy); 				// No warning
+71  		dummySF.contains(dummyChild); 		 	// No warning
+72  		dummySF.contains(s); 					// HIGH
+73  
+74  		childF.contains(dummy); 				// No warning
+75  		childF.contains(dummyChild); 		 	// No warning
+76  		childF.contains(s); 					// HIGH
+77  
+78  		childEF.contains(dummy); 				// No warning
+79  		childEF.contains(dummyChild); 		 	// No warning
+80  		childEF.contains(s); 					// HIGH
+81  
+82  		childSF.contains(dummy); 				// No warning
+83  		childSF.contains(dummyChild); 		 	// No warning
+84  		childSF.contains(s); 					// HIGH
+85  
+86  		genericF.contains(dummy); 				// No warning
+87  		genericF.contains(dummyChild); 		 	// No warning
+88  		genericF.contains(s); 					// No warning
+89  
+90  		genericEF.contains(dummy); 				// No warning
+91  		genericEF.contains(dummyChild); 		    // No warning
+92  		genericEF.contains(s); 					// No warning
+93  
+94  		genericSF.contains(dummy); 				// No warning
+95  		genericSF.contains(dummyChild); 		// No warning
+96  		genericSF.contains(s); 					// No warning
+97  
+98  	}
+99  
+100 	@ExpectWarning("GC")
+101 	public void testFields() {
+102 		Dummy dummy = new Dummy();
+103 		DummyChild dummyChild = new DummyChild();
+104 		String s = "Mismatched Type";
+105 
+106 		wildcardF.contains(dummy); 				// No warning
+107 		wildcardF.contains(dummyChild); 		// No warning
+108 		wildcardF.contains(s); 					// No warning
+109 
+110 		dummyF.contains(dummy); 				// No warning
+111 		dummyF.contains(dummyChild); 		 	// No warning
+112 		dummyF.contains(s); 					// HIGH
+113 
+114 		dummyEF.contains(dummy); 				// No warning
+115 		dummyEF.contains(dummyChild); 		 	// No warning
+116 		dummyEF.contains(s); 					// HIGH
+117 
+118 		dummySF.contains(dummy); 				// No warning
+119 		dummySF.contains(dummyChild); 		 	// No warning
+120 		dummySF.contains(s); 					// HIGH
+121 
+122 		childF.contains(dummy); 				// No warning
+123 		childF.contains(dummyChild); 		 	// No warning
+124 		childF.contains(s); 					// HIGH
+125 
+126 		childEF.contains(dummy); 				// No warning
+127 		childEF.contains(dummyChild); 		 	// No warning
+128 		childEF.contains(s); 					// HIGH
+129 
+130 		childSF.contains(dummy); 				// No warning
+131 		childSF.contains(dummyChild); 		 	// No warning
+132 		childSF.contains(s); 					// HIGH
+133 
+134 		genericF.contains(dummy); 				// No warning
+135 		genericF.contains(dummyChild); 		 	// No warning
+136 		genericF.contains(s); 					// No warning
+137 
+138 		genericEF.contains(dummy); 				// No warning
+139 		genericEF.contains(dummyChild); 		// No warning
+140 		genericEF.contains(s); 					// No warning
+141 
+142 		genericSF.contains(dummy); 				// No warning
+143 		genericSF.contains(dummyChild); 		// No warning
+144 		genericSF.contains(s); 					// No warning
+145 
+146 		// what if <T extends Dummy> in class definition? 
+147 		// Requires more analysis -- a future enhancement
+148 		// Can we be sure that the T is the same as the one in the class/method definition
+149 
+150 	}
+151 }
diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html index b2126a391..2bc5aae0e 100644 --- a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html +++ b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html @@ -8,72 +8,72 @@ 
-1   package gcUnrelatedTypes;
-2   
-3   import java.util.ArrayList;
-4   
-5   public class ArrayListContains0<T> {
-6   
-7   	static class Dummy {
-8   
-9   	}
-10  
-11  	static class DummyChild extends Dummy {
-12  
-13  	}
-14  
-15  	private ArrayList<?> wildcardF;
-16  
-17  	private ArrayList<Dummy> dummyF;
-18  	private ArrayList<? extends Dummy> dummyEF;
-19  	private ArrayList<? super Dummy> dummySF;
-20  
-21  	private ArrayList<DummyChild> childF;
-22  	private ArrayList<? extends DummyChild> childEF;
-23  	private ArrayList<? super DummyChild> childSF;
-24  
-25  	private ArrayList<T> genericF;		
-26  	private ArrayList<? extends T> genericEF;
-27  	private ArrayList<? super T> genericSF;		
-28  
-29  
-30  	public ArrayListContains0(
-31  			ArrayList<?> wildcardF, 
-32  			ArrayList<Dummy> dummyF, 
-33  			ArrayList<? extends Dummy> dummyEF, 
-34  			ArrayList<? super Dummy> dummySF, 
-35  			ArrayList<DummyChild> childF, 
-36  			ArrayList<? extends DummyChild> childEF, 
-37  			ArrayList<? super DummyChild> childSF, 
-38  			ArrayList<T> genericF, 
-39  			ArrayList<? extends T> genericEF, 
-40  			ArrayList<? super T> genericSF) {
-41  
-42  		Dummy dummy = new Dummy();
-43  		DummyChild dummyChild = new DummyChild();
-44  		String s = "Mismatched Type";
-45  
-46  		wildcardF.contains(s); 					// No warning
-47  
-48  		dummyF.contains(s); 					// HIGH
-49  
-50  		dummyEF.contains(s); 					// HIGH
-51  
-52  		dummySF.contains(s); 					// HIGH
-53  
-54  		childF.contains(s); 					// HIGH
-55  
-56  		childEF.contains(s); 					// HIGH
-57  
-58  		childSF.contains(s); 					// HIGH
-59  
-60  
-61  
-62  	
-63  	}
-64  
-65  
-66  	}
+1   package gcUnrelatedTypes;
+2   
+3   import java.util.ArrayList;
+4   
+5   public class ArrayListContains0<T> {
+6   
+7   	static class Dummy {
+8   
+9   	}
+10  
+11  	static class DummyChild extends Dummy {
+12  
+13  	}
+14  
+15  	private ArrayList<?> wildcardF;
+16  
+17  	private ArrayList<Dummy> dummyF;
+18  	private ArrayList<? extends Dummy> dummyEF;
+19  	private ArrayList<? super Dummy> dummySF;
+20  
+21  	private ArrayList<DummyChild> childF;
+22  	private ArrayList<? extends DummyChild> childEF;
+23  	private ArrayList<? super DummyChild> childSF;
+24  
+25  	private ArrayList<T> genericF;		
+26  	private ArrayList<? extends T> genericEF;
+27  	private ArrayList<? super T> genericSF;		
+28  
+29  
+30  	public ArrayListContains0(
+31  			ArrayList<?> wildcardF, 
+32  			ArrayList<Dummy> dummyF, 
+33  			ArrayList<? extends Dummy> dummyEF, 
+34  			ArrayList<? super Dummy> dummySF, 
+35  			ArrayList<DummyChild> childF, 
+36  			ArrayList<? extends DummyChild> childEF, 
+37  			ArrayList<? super DummyChild> childSF, 
+38  			ArrayList<T> genericF, 
+39  			ArrayList<? extends T> genericEF, 
+40  			ArrayList<? super T> genericSF) {
+41  
+42  		Dummy dummy = new Dummy();
+43  		DummyChild dummyChild = new DummyChild();
+44  		String s = "Mismatched Type";
+45  
+46  		wildcardF.contains(s); 					// No warning
+47  
+48  		dummyF.contains(s); 					// HIGH
+49  
+50  		dummyEF.contains(s); 					// HIGH
+51  
+52  		dummySF.contains(s); 					// HIGH
+53  
+54  		childF.contains(s); 					// HIGH
+55  
+56  		childEF.contains(s); 					// HIGH
+57  
+58  		childSF.contains(s); 					// HIGH
+59  
+60  
+61  
+62  	
+63  	}
+64  
+65  
+66  	}
diff --git a/src/site/resources/examples/xref/jsr305/AlwaysBlue.html b/src/site/resources/examples/xref/jsr305/AlwaysBlue.html index e7aa58640..e2bf40ef8 100644 --- a/src/site/resources/examples/xref/jsr305/AlwaysBlue.html +++ b/src/site/resources/examples/xref/jsr305/AlwaysBlue.html @@ -8,20 +8,20 @@ 
-1   package jsr305;
-2   
-3   import java.lang.annotation.Retention;
-4   import java.lang.annotation.RetentionPolicy;
-5   
-6   import javax.annotation.meta.TypeQualifierNickname;
-7   import javax.annotation.meta.When;
-8   
-9   @ExhaustiveQualifier(value=ExhaustiveQualifier.Color.BLUE, when=When.ALWAYS)
-10  @TypeQualifierNickname
-11  @Retention(RetentionPolicy.RUNTIME)
-12  public @interface AlwaysBlue {
-13  
-14  }
+1   package jsr305;
+2   
+3   import java.lang.annotation.Retention;
+4   import java.lang.annotation.RetentionPolicy;
+5   
+6   import javax.annotation.meta.TypeQualifierNickname;
+7   import javax.annotation.meta.When;
+8   
+9   @ExhaustiveQualifier(value=ExhaustiveQualifier.Color.BLUE, when=When.ALWAYS)
+10  @TypeQualifierNickname
+11  @Retention(RetentionPolicy.RUNTIME)
+12  public @interface AlwaysBlue {
+13  
+14  }
diff --git a/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html b/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html index 0c8c32866..48a5aa346 100644 --- a/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html +++ b/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html @@ -8,43 +8,43 @@ 
-1   package npe;
-2   
-3   import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
-4   import java.util.concurrent.atomic.AtomicLongFieldUpdater;
-5   import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
-6   
-7   public class AtomicFieldUpdater {
-8   
-9   	volatile Object x;
-10  	volatile int y;
-11      volatile long z;
-12  
-13  	AtomicReferenceFieldUpdater<AtomicFieldUpdater  , Object> updaterX 
-14  	 = AtomicReferenceFieldUpdater.newUpdater(AtomicFieldUpdater.class, Object.class, "x");
-15      
-16  	AtomicIntegerFieldUpdater<AtomicFieldUpdater> updaterY
-17  	= AtomicIntegerFieldUpdater.newUpdater(AtomicFieldUpdater.class, "y");
-18  
-19      AtomicLongFieldUpdater<AtomicFieldUpdater> updaterZ
-20  	= AtomicLongFieldUpdater.newUpdater(AtomicFieldUpdater.class,  "z");
-21  
-22  	int f() {
-23          return x.hashCode();
-24  	}
-25  
-26  	void setX(Object foo) {
-27          updaterX.set(this, foo);
-28  	}
-29  	void setY(int foo) {
-30  		updaterY.set(this, foo);
-31      }
-32  
-33  	void setZ(long foo) {
-34  		updaterZ.set(this, foo);
-35      }
-36  
-37  }
+1   package npe;
+2   
+3   import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
+4   import java.util.concurrent.atomic.AtomicLongFieldUpdater;
+5   import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
+6   
+7   public class AtomicFieldUpdater {
+8   
+9   	volatile Object x;
+10  	volatile int y;
+11      volatile long z;
+12  
+13  	AtomicReferenceFieldUpdater<AtomicFieldUpdater  , Object> updaterX 
+14  	 = AtomicReferenceFieldUpdater.newUpdater(AtomicFieldUpdater.class, Object.class, "x");
+15      
+16  	AtomicIntegerFieldUpdater<AtomicFieldUpdater> updaterY
+17  	= AtomicIntegerFieldUpdater.newUpdater(AtomicFieldUpdater.class, "y");
+18  
+19      AtomicLongFieldUpdater<AtomicFieldUpdater> updaterZ
+20  	= AtomicLongFieldUpdater.newUpdater(AtomicFieldUpdater.class,  "z");
+21  
+22  	int f() {
+23          return x.hashCode();
+24  	}
+25  
+26  	void setX(Object foo) {
+27          updaterX.set(this, foo);
+28  	}
+29  	void setY(int foo) {
+30  		updaterY.set(this, foo);
+31      }
+32  
+33  	void setZ(long foo) {
+34  		updaterZ.set(this, foo);
+35      }
+36  
+37  }
diff --git a/src/site/resources/examples/xref/npe/UseCheckUse.html b/src/site/resources/examples/xref/npe/UseCheckUse.html index c13b8159e..c472d36e2 100644 --- a/src/site/resources/examples/xref/npe/UseCheckUse.html +++ b/src/site/resources/examples/xref/npe/UseCheckUse.html @@ -8,26 +8,26 @@ 
-1   package npe;
-2   
-3   public class UseCheckUse {
-4   	final Object x;
-5   	UseCheckUse(Object x) {
-6   		this.x = x;
-7       }
-8   	int f(boolean b) {
-9   		int result = x.hashCode();
-10  		if (x == null) {
-11              System.out.println("x is null");
-12  		}
-13  		if (b) 
-14  			result *= x.hashCode();
-15          else
-16  			result += x.hashCode();
-17  		return result;
-18  	}
-19  
-20  }
+1   package npe;
+2   
+3   public class UseCheckUse {
+4   	final Object x;
+5   	UseCheckUse(Object x) {
+6   		this.x = x;
+7       }
+8   	int f(boolean b) {
+9   		int result = x.hashCode();
+10  		if (x == null) {
+11              System.out.println("x is null");
+12  		}
+13  		if (b) 
+14  			result *= x.hashCode();
+15          else
+16  			result += x.hashCode();
+17  		return result;
+18  	}
+19  
+20  }
diff --git a/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html b/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html index f06f6ca8e..ffb9daca9 100644 --- a/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html +++ b/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html @@ -8,55 +8,55 @@ 
-1   package nullnessAnnotations;
-2   
-3   import javax.annotation.CheckForNull;
-4   import javax.annotation.Nonnull;
-5   
-6   public class UseAnnotations {
-7   	
-8   	@CheckForNull Object f(int x) {
-9   		if (x == 0) return null;
-10  		return (Integer) x;
-11  	}
-12  	
-13  	int g(@Nonnull Object x) {
-14  		return 42;
-15  	}
-16  	int foo() {
-17  		return g(f(12));  // should generate a warning here (but don't)
-18  	}
-19  	int foo2() {
-20  		return g(null);  // should and do generate a warning here
-21  	}
-22  	int foo3(int x) {
-23  		Object y = null;
-24  		if (x > 0) y = "";
-25  		return g(y);  // should generate a warning here (but don't)
-26  	}
-27  	int foo4() {
-28  		return f(12).hashCode();  // should generate a warning here (but don't)
-29  	}
-30  
-31  	int bar() {
-32  		return f(12).hashCode();  // should generate a warning here (but don't)
-33  	}
-34  	int bar2() {
-35  		Object x = null;
-36  		return x.hashCode();  // should and do generate a warning here
-37  	}
-38  	int bar3(int x) {
-39  		Object y = null;
-40  		if (x > 0) y = "";
-41  		return y.hashCode();  // should generate a warning here (but don't)
-42  	}
-43  	int bar4(int x) {
-44  		Object y = null;
-45  		if (x > 0) y = "";
-46  		return y.hashCode();  // should generate a warning here (but don't)
-47  	}
-48  
-49  }
+1   package nullnessAnnotations;
+2   
+3   import javax.annotation.CheckForNull;
+4   import javax.annotation.Nonnull;
+5   
+6   public class UseAnnotations {
+7   	
+8   	@CheckForNull Object f(int x) {
+9   		if (x == 0) return null;
+10  		return (Integer) x;
+11  	}
+12  	
+13  	int g(@Nonnull Object x) {
+14  		return 42;
+15  	}
+16  	int foo() {
+17  		return g(f(12));  // should generate a warning here (but don't)
+18  	}
+19  	int foo2() {
+20  		return g(null);  // should and do generate a warning here
+21  	}
+22  	int foo3(int x) {
+23  		Object y = null;
+24  		if (x > 0) y = "";
+25  		return g(y);  // should generate a warning here (but don't)
+26  	}
+27  	int foo4() {
+28  		return f(12).hashCode();  // should generate a warning here (but don't)
+29  	}
+30  
+31  	int bar() {
+32  		return f(12).hashCode();  // should generate a warning here (but don't)
+33  	}
+34  	int bar2() {
+35  		Object x = null;
+36  		return x.hashCode();  // should and do generate a warning here
+37  	}
+38  	int bar3(int x) {
+39  		Object y = null;
+40  		if (x > 0) y = "";
+41  		return y.hashCode();  // should generate a warning here (but don't)
+42  	}
+43  	int bar4(int x) {
+44  		Object y = null;
+45  		if (x > 0) y = "";
+46  		return y.hashCode();  // should generate a warning here (but don't)
+47  	}
+48  
+49  }
diff --git a/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html b/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html index c753e34b7..b216fc16b 100644 --- a/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html +++ b/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html @@ -8,41 +8,41 @@ 
-1   package obligation;
-2   
-3   import java.io.FileInputStream;
-4   import java.io.IOException;
-5   import java.io.InputStream;
-6   
-7   import javax.annotation.WillClose;
-8   
-9   import edu.umd.cs.findbugs.annotations.NoWarning;
-10  
-11  /**
-12   * Test to see if WillClose annotations are understood.
-13   */
-14  public class UsesWillCloseAnnotation {
-15  	@NoWarning("OBL")
-16  	public void ok(String filename) throws IOException {
-17  		InputStream in = new FileInputStream(filename);
-18  		try {
-19  			int c;
-20  			c = in.read();
-21  			System.out.println(c);
-22  		} finally {
-23  			cleanup(in);
-24  		}
-25  	}
-26  	
-27  	
-28  	public void cleanup(@WillClose InputStream in) {
-29  		try {
-30  			in.close();
-31  		} catch (IOException e) {
-32  			// ignore
-33  		}
-34  	}
-35  }
+1   package obligation;
+2   
+3   import java.io.FileInputStream;
+4   import java.io.IOException;
+5   import java.io.InputStream;
+6   
+7   import javax.annotation.WillClose;
+8   
+9   import edu.umd.cs.findbugs.annotations.NoWarning;
+10  
+11  /**
+12   * Test to see if WillClose annotations are understood.
+13   */
+14  public class UsesWillCloseAnnotation {
+15  	@NoWarning("OBL")
+16  	public void ok(String filename) throws IOException {
+17  		InputStream in = new FileInputStream(filename);
+18  		try {
+19  			int c;
+20  			c = in.read();
+21  			System.out.println(c);
+22  		} finally {
+23  			cleanup(in);
+24  		}
+25  	}
+26  	
+27  	
+28  	public void cleanup(@WillClose InputStream in) {
+29  		try {
+30  			in.close();
+31  		} catch (IOException e) {
+32  			// ignore
+33  		}
+34  	}
+35  }
diff --git a/src/site/resources/examples/xref/uselessThread/UsefulThread.html b/src/site/resources/examples/xref/uselessThread/UsefulThread.html index 302aa26dc..b207fe69c 100644 --- a/src/site/resources/examples/xref/uselessThread/UsefulThread.html +++ b/src/site/resources/examples/xref/uselessThread/UsefulThread.html @@ -8,18 +8,18 @@ 
-1   package uselessThread;
-2   
-3   class UsefulThread extends Thread {
-4   	public UsefulThread() {
-5   		super("Usefull-" + System.currentTimeMillis());
-6   	}
-7   
-8   	@Override
-9   	public void run() {
-10  		System.out.println("I am a useful thread!");
-11  	}
-12  }
+1   package uselessThread;
+2   
+3   class UsefulThread extends Thread {
+4   	public UsefulThread() {
+5   		super("Usefull-" + System.currentTimeMillis());
+6   	}
+7   
+8   	@Override
+9   	public void run() {
+10  		System.out.println("I am a useful thread!");
+11  	}
+12  }
From 5d2032c562f4c5e318d755dc4e855beb5cedb6f9 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 13:56:40 -0400 Subject: [PATCH 0368/1013] [secure] Use https license everywhere instead of http --- .mvn/wrapper/MavenWrapperDownloader.java | 2 +- LICENSE | 2 +- mvnw | 2 +- mvnw.cmd | 2 +- src/it-tools/build-tools/pom.xml | 2 +- src/it-tools/build-tools/verify.groovy | 2 +- src/it-tools/prime/pom.xml | 2 +- src/it-tools/prime/verify.groovy | 2 +- src/it/MFINDBUGS-145/pom.xml | 2 +- src/it/MFINDBUGS-178/pom.xml | 2 +- src/it/basic-1/pom.xml | 2 +- src/it/basic-1/verify.groovy | 2 +- src/it/change-xml-filename/pom.xml | 2 +- src/it/change-xml-filename/verify.groovy | 2 +- src/it/check-fail/pom.xml | 2 +- src/it/check-jvmargs/pom.xml | 2 +- src/it/check-jvmargs/verify.groovy | 2 +- src/it/check-multi/modules/module-1/pom.xml | 2 +- src/it/check-multi/modules/module-2/pom.xml | 2 +- src/it/check-multi/modules/pom.xml | 2 +- src/it/check-multi/pom.xml | 2 +- src/it/check-multi/verify.groovy | 2 +- src/it/check-nofail/pom.xml | 2 +- src/it/check-pluginList-repo/pom.xml | 2 +- src/it/check-pluginList-repo/verify.groovy | 2 +- src/it/check-skip/pom.xml | 2 +- src/it/check-skip/verify.groovy | 2 +- src/it/check-timeout/pom.xml | 2 +- src/it/check/pom.xml | 2 +- src/it/check/verify.groovy | 2 +- src/it/common.xml | 2 +- src/it/effort-default/pom.xml | 2 +- src/it/effort-default/verify.groovy | 2 +- src/it/effort-max/pom.xml | 2 +- src/it/effort-max/verify.groovy | 2 +- src/it/effort-min/pom.xml | 2 +- src/it/effort-min/verify.groovy | 2 +- src/it/empty/pom.xml | 2 +- src/it/empty/verify.groovy | 2 +- src/it/encoding-utf8/pom.xml | 2 +- src/it/encoding-utf8/verify.groovy | 2 +- src/it/exclude-modules/module1/pom.xml | 2 +- src/it/exclude-modules/module2/pom.xml | 2 +- src/it/exclude-modules/pom.xml | 2 +- src/it/exclude-modules/verify.groovy | 2 +- src/it/exclude-multi/pom.xml | 2 +- src/it/exclude-multi/verify.groovy | 2 +- src/it/exclude/pom.xml | 2 +- src/it/exclude/verify.groovy | 2 +- src/it/excludeBugsFile/pom.xml | 2 +- src/it/excludeBugsFile/verify.groovy | 2 +- src/it/experimental/pom.xml | 2 +- src/it/experimental/verify.groovy | 2 +- src/it/include-multi/pom.xml | 2 +- src/it/include-multi/verify.groovy | 2 +- src/it/include/pom.xml | 2 +- src/it/include/verify.groovy | 2 +- src/it/maxRank/pom.xml | 2 +- src/it/maxRank/verify.groovy | 2 +- src/it/multi-build/modules/module-1/pom.xml | 2 +- src/it/multi-build/modules/module-2/pom.xml | 2 +- src/it/multi-build/modules/pom.xml | 2 +- src/it/multi-build/pom.xml | 2 +- src/it/multi-build/verify.groovy | 2 +- src/it/multi/modules/module-1/pom.xml | 2 +- src/it/multi/modules/module-2/pom.xml | 2 +- src/it/multi/modules/pom.xml | 2 +- src/it/multi/pom.xml | 2 +- src/it/multi/verify.groovy | 2 +- src/it/nested/pom.xml | 2 +- src/it/nested/verify.groovy | 2 +- src/it/no-src/pom.xml | 2 +- .../no-src/src/test/java/EmptyJUnitTest.java | 2 +- src/it/no-src/verify.groovy | 2 +- src/it/no-testsrc/pom.xml | 2 +- src/it/no-testsrc/verify.groovy | 2 +- src/it/omitVisitors/pom.xml | 2 +- src/it/omitVisitors/verify.groovy | 2 +- src/it/onlyAnalyze/pom.xml | 2 +- src/it/onlyAnalyze/verify.groovy | 2 +- src/it/pluginList-repo/pom.xml | 19 ++++++++++++++----- src/it/pluginList-repo/verify.groovy | 2 +- src/it/pluginList/pom.xml | 2 +- src/it/pluginList/verify.groovy | 2 +- src/it/relaxed/pom.xml | 2 +- src/it/relaxed/verify.groovy | 2 +- src/it/settings.xml | 2 +- src/it/site-brazil/pom.xml | 2 +- src/it/site-brazil/verify.groovy | 2 +- src/it/site-default/pom.xml | 2 +- src/it/site-default/verify.groovy | 2 +- src/it/site-french/pom.xml | 2 +- src/it/site-french/verify.groovy | 2 +- src/it/site-spanish/pom.xml | 2 +- src/it/site-spanish/verify.groovy | 2 +- src/it/skip/pom.xml | 2 +- src/it/skip/verify.groovy | 2 +- src/it/skipEmpty/pom.xml | 2 +- src/it/skipEmpty/verify.groovy | 2 +- src/it/threaded/pom.xml | 2 +- src/it/threaded/verify.groovy | 2 +- src/it/threshold-experimental/pom.xml | 2 +- src/it/threshold-experimental/verify.groovy | 2 +- src/it/threshold-high/pom.xml | 2 +- src/it/threshold-high/verify.groovy | 2 +- src/it/threshold-low/pom.xml | 2 +- src/it/threshold-low/verify.groovy | 2 +- src/it/trace/pom.xml | 2 +- src/it/trace/verify.groovy | 2 +- src/it/userPrefs-override/pom.xml | 2 +- src/it/userPrefs-override/verify.groovy | 2 +- src/it/userPrefs/pom.xml | 2 +- src/it/userPrefs/verify.groovy | 2 +- .../mojo/spotbugs/ResourceHelper.groovy | 2 +- .../codehaus/mojo/spotbugs/SpotBugsGui.groovy | 2 +- .../mojo/spotbugs/SpotBugsInfo.groovy | 2 +- .../mojo/spotbugs/SpotBugsMojo.groovy | 2 +- .../mojo/spotbugs/SpotBugsPluginsTrait.groovy | 2 +- .../spotbugs/SpotbugsReportGenerator.groovy | 2 +- .../SpotbugsViolationCheckMojo.groovy | 2 +- .../mojo/spotbugs/XDocsReporter.groovy | 2 +- src/main/tools/jsr305.pom | 2 +- .../apt/examples/multi-module-config.apt.vm | 2 +- .../apt/examples/violationChecking.apt.vm | 2 +- src/site/apt/usage.apt.vm | 2 +- 125 files changed, 138 insertions(+), 129 deletions(-) diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java index b901097f2..e76d1f324 100644 --- a/.mvn/wrapper/MavenWrapperDownloader.java +++ b/.mvn/wrapper/MavenWrapperDownloader.java @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/LICENSE b/LICENSE index 6b0b1270f..c8118641c 100644 --- a/LICENSE +++ b/LICENSE @@ -193,7 +193,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/mvnw b/mvnw index 41c0f0c23..a16b5431b 100755 --- a/mvnw +++ b/mvnw @@ -8,7 +8,7 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # -# http://www.apache.org/licenses/LICENSE-2.0 +# https://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an diff --git a/mvnw.cmd b/mvnw.cmd index 86115719e..c8d43372c 100644 --- a/mvnw.cmd +++ b/mvnw.cmd @@ -7,7 +7,7 @@ @REM "License"); you may not use this file except in compliance @REM with the License. You may obtain a copy of the License at @REM -@REM http://www.apache.org/licenses/LICENSE-2.0 +@REM https://www.apache.org/licenses/LICENSE-2.0 @REM @REM Unless required by applicable law or agreed to in writing, @REM software distributed under the License is distributed on an diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml index 3666aee79..61744c134 100644 --- a/src/it-tools/build-tools/pom.xml +++ b/src/it-tools/build-tools/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it-tools/build-tools/verify.groovy b/src/it-tools/build-tools/verify.groovy index 8e883aa8a..f8124451f 100644 --- a/src/it-tools/build-tools/verify.groovy +++ b/src/it-tools/build-tools/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it-tools/prime/pom.xml b/src/it-tools/prime/pom.xml index c568e8b33..0e0f4ce4c 100644 --- a/src/it-tools/prime/pom.xml +++ b/src/it-tools/prime/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it-tools/prime/verify.groovy b/src/it-tools/prime/verify.groovy index 942760633..4b0cf8b2b 100644 --- a/src/it-tools/prime/verify.groovy +++ b/src/it-tools/prime/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml index de276316e..1c1ecf67f 100644 --- a/src/it/MFINDBUGS-145/pom.xml +++ b/src/it/MFINDBUGS-145/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml index aa72d33ec..14a84d571 100644 --- a/src/it/MFINDBUGS-178/pom.xml +++ b/src/it/MFINDBUGS-178/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/basic-1/pom.xml b/src/it/basic-1/pom.xml index 75442e864..4563503c4 100644 --- a/src/it/basic-1/pom.xml +++ b/src/it/basic-1/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/basic-1/verify.groovy b/src/it/basic-1/verify.groovy index 7ca6b56f1..f12cbc7ca 100644 --- a/src/it/basic-1/verify.groovy +++ b/src/it/basic-1/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/change-xml-filename/pom.xml b/src/it/change-xml-filename/pom.xml index eab359d33..aaa664f5f 100644 --- a/src/it/change-xml-filename/pom.xml +++ b/src/it/change-xml-filename/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/change-xml-filename/verify.groovy b/src/it/change-xml-filename/verify.groovy index a069a481d..84773c695 100644 --- a/src/it/change-xml-filename/verify.groovy +++ b/src/it/change-xml-filename/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml index dbd809e4e..0bb7616b1 100644 --- a/src/it/check-fail/pom.xml +++ b/src/it/check-fail/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-jvmargs/pom.xml b/src/it/check-jvmargs/pom.xml index 003f5c4f9..022195ae7 100644 --- a/src/it/check-jvmargs/pom.xml +++ b/src/it/check-jvmargs/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-jvmargs/verify.groovy b/src/it/check-jvmargs/verify.groovy index 932f29a2f..7ce882d90 100644 --- a/src/it/check-jvmargs/verify.groovy +++ b/src/it/check-jvmargs/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-multi/modules/module-1/pom.xml b/src/it/check-multi/modules/module-1/pom.xml index 2d92dcdf5..7980b0cbc 100644 --- a/src/it/check-multi/modules/module-1/pom.xml +++ b/src/it/check-multi/modules/module-1/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-multi/modules/module-2/pom.xml b/src/it/check-multi/modules/module-2/pom.xml index 20c80a6dd..963358fb1 100644 --- a/src/it/check-multi/modules/module-2/pom.xml +++ b/src/it/check-multi/modules/module-2/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-multi/modules/pom.xml b/src/it/check-multi/modules/pom.xml index 3edeafb35..bce5de65c 100644 --- a/src/it/check-multi/modules/pom.xml +++ b/src/it/check-multi/modules/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-multi/pom.xml b/src/it/check-multi/pom.xml index e61f3a8b0..d5f5e63fc 100644 --- a/src/it/check-multi/pom.xml +++ b/src/it/check-multi/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-multi/verify.groovy b/src/it/check-multi/verify.groovy index 4eaa8627a..f54885656 100644 --- a/src/it/check-multi/verify.groovy +++ b/src/it/check-multi/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml index 34c6977c6..8d4a2daa8 100644 --- a/src/it/check-nofail/pom.xml +++ b/src/it/check-nofail/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/check-pluginList-repo/pom.xml b/src/it/check-pluginList-repo/pom.xml index 0ccad2d2a..6ba00d915 100644 --- a/src/it/check-pluginList-repo/pom.xml +++ b/src/it/check-pluginList-repo/pom.xml @@ -2,7 +2,7 @@ + 4.0.0 diff --git a/src/it/pluginList-repo/verify.groovy b/src/it/pluginList-repo/verify.groovy index 7ca6b56f1..f12cbc7ca 100644 --- a/src/it/pluginList-repo/verify.groovy +++ b/src/it/pluginList-repo/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/pluginList/pom.xml b/src/it/pluginList/pom.xml index 104e5c973..7b6056294 100644 --- a/src/it/pluginList/pom.xml +++ b/src/it/pluginList/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/pluginList/verify.groovy b/src/it/pluginList/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/pluginList/verify.groovy +++ b/src/it/pluginList/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/relaxed/pom.xml b/src/it/relaxed/pom.xml index cf8c2c58a..f7d516a9a 100644 --- a/src/it/relaxed/pom.xml +++ b/src/it/relaxed/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/relaxed/verify.groovy b/src/it/relaxed/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/relaxed/verify.groovy +++ b/src/it/relaxed/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/settings.xml b/src/it/settings.xml index 82b87411b..58988002d 100644 --- a/src/it/settings.xml +++ b/src/it/settings.xml @@ -9,7 +9,7 @@ to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an diff --git a/src/it/site-brazil/pom.xml b/src/it/site-brazil/pom.xml index 2599620d8..56dfb8d98 100644 --- a/src/it/site-brazil/pom.xml +++ b/src/it/site-brazil/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-brazil/verify.groovy b/src/it/site-brazil/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/site-brazil/verify.groovy +++ b/src/it/site-brazil/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-default/pom.xml b/src/it/site-default/pom.xml index 064c913ae..3493d096b 100644 --- a/src/it/site-default/pom.xml +++ b/src/it/site-default/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-default/verify.groovy b/src/it/site-default/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/site-default/verify.groovy +++ b/src/it/site-default/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-french/pom.xml b/src/it/site-french/pom.xml index d349bac91..df32112fa 100644 --- a/src/it/site-french/pom.xml +++ b/src/it/site-french/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-french/verify.groovy b/src/it/site-french/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/site-french/verify.groovy +++ b/src/it/site-french/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-spanish/pom.xml b/src/it/site-spanish/pom.xml index 60e6ac92f..219c89b69 100644 --- a/src/it/site-spanish/pom.xml +++ b/src/it/site-spanish/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/site-spanish/verify.groovy b/src/it/site-spanish/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/site-spanish/verify.groovy +++ b/src/it/site-spanish/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/skip/pom.xml b/src/it/skip/pom.xml index d07523149..e9d979a6b 100644 --- a/src/it/skip/pom.xml +++ b/src/it/skip/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/skip/verify.groovy b/src/it/skip/verify.groovy index fcc0985ca..c7acf5b0a 100644 --- a/src/it/skip/verify.groovy +++ b/src/it/skip/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml index 35995bc4e..2593429ed 100644 --- a/src/it/skipEmpty/pom.xml +++ b/src/it/skipEmpty/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/skipEmpty/verify.groovy b/src/it/skipEmpty/verify.groovy index 309f689d7..c673ae575 100644 --- a/src/it/skipEmpty/verify.groovy +++ b/src/it/skipEmpty/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threaded/pom.xml b/src/it/threaded/pom.xml index bf86adb82..02975af2a 100644 --- a/src/it/threaded/pom.xml +++ b/src/it/threaded/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threaded/verify.groovy b/src/it/threaded/verify.groovy index c327dab24..8e39c9dd7 100644 --- a/src/it/threaded/verify.groovy +++ b/src/it/threaded/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-experimental/pom.xml b/src/it/threshold-experimental/pom.xml index 0a8a7c5d5..aeec3f248 100644 --- a/src/it/threshold-experimental/pom.xml +++ b/src/it/threshold-experimental/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-experimental/verify.groovy b/src/it/threshold-experimental/verify.groovy index 6568e3282..c88eef3a1 100644 --- a/src/it/threshold-experimental/verify.groovy +++ b/src/it/threshold-experimental/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-high/pom.xml b/src/it/threshold-high/pom.xml index 610c25ead..09d1c1fbf 100644 --- a/src/it/threshold-high/pom.xml +++ b/src/it/threshold-high/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-high/verify.groovy b/src/it/threshold-high/verify.groovy index 7ca6b56f1..f12cbc7ca 100644 --- a/src/it/threshold-high/verify.groovy +++ b/src/it/threshold-high/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-low/pom.xml b/src/it/threshold-low/pom.xml index fa2e1a40b..aab22b527 100644 --- a/src/it/threshold-low/pom.xml +++ b/src/it/threshold-low/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/threshold-low/verify.groovy b/src/it/threshold-low/verify.groovy index c4788f4f3..d89e93913 100644 --- a/src/it/threshold-low/verify.groovy +++ b/src/it/threshold-low/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/trace/pom.xml b/src/it/trace/pom.xml index 45886744c..7e31e37dd 100644 --- a/src/it/trace/pom.xml +++ b/src/it/trace/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/trace/verify.groovy b/src/it/trace/verify.groovy index 7ca6b56f1..f12cbc7ca 100644 --- a/src/it/trace/verify.groovy +++ b/src/it/trace/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/userPrefs-override/pom.xml b/src/it/userPrefs-override/pom.xml index 80ef07eb7..008d8c645 100644 --- a/src/it/userPrefs-override/pom.xml +++ b/src/it/userPrefs-override/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/userPrefs-override/verify.groovy b/src/it/userPrefs-override/verify.groovy index 7b342cea3..ad9133f2b 100644 --- a/src/it/userPrefs-override/verify.groovy +++ b/src/it/userPrefs-override/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/userPrefs/pom.xml b/src/it/userPrefs/pom.xml index 6d4b30458..96cbce103 100644 --- a/src/it/userPrefs/pom.xml +++ b/src/it/userPrefs/pom.xml @@ -6,7 +6,7 @@ you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 + https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/it/userPrefs/verify.groovy b/src/it/userPrefs/verify.groovy index 6aacdc4bb..77ced0780 100644 --- a/src/it/userPrefs/verify.groovy +++ b/src/it/userPrefs/verify.groovy @@ -5,7 +5,7 @@ * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy index 240f4d73e..fcedf6414 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy index 7c7720bff..4d7d43bdd 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index 5e9f27b7d..729cbec39 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 59da9df68..be0258d0b 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy index 203ff94a1..af6b0559f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index cb112772e..9c9e18b11 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index b84d011d7..3e6147772 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License"); you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 3a307bf35..21b32d534 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -9,7 +9,7 @@ package org.codehaus.mojo.spotbugs * "License") you may not use this file except in compliance * with the License. You may obtain a copy of the License at * - * http://www.apache.org/licenses/LICENSE-2.0 + * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, * software distributed under the License is distributed on an diff --git a/src/main/tools/jsr305.pom b/src/main/tools/jsr305.pom index b95ebb6bf..c28dab18c 100644 --- a/src/main/tools/jsr305.pom +++ b/src/main/tools/jsr305.pom @@ -12,7 +12,7 @@ The Apache Software License, Version 2.0 - http://www.apache.org/licenses/LICENSE-2.0.txt + https://www.apache.org/licenses/LICENSE-2.0.txt repo diff --git a/src/site/apt/examples/multi-module-config.apt.vm b/src/site/apt/examples/multi-module-config.apt.vm index 257782e26..5429816bb 100644 --- a/src/site/apt/examples/multi-module-config.apt.vm +++ b/src/site/apt/examples/multi-module-config.apt.vm @@ -12,7 +12,7 @@ ~~ "License"); you may not use this file except in compliance ~~ with the License. You may obtain a copy of the License at ~~ -~~ http://www.apache.org/licenses/LICENSE-2.0 +~~ https://www.apache.org/licenses/LICENSE-2.0 ~~ ~~ Unless required by applicable law or agreed to in writing, ~~ software distributed under the License is distributed on an diff --git a/src/site/apt/examples/violationChecking.apt.vm b/src/site/apt/examples/violationChecking.apt.vm index 92510481c..2924c9e3c 100644 --- a/src/site/apt/examples/violationChecking.apt.vm +++ b/src/site/apt/examples/violationChecking.apt.vm @@ -12,7 +12,7 @@ ~~ "License"); you may not use this file except in compliance ~~ with the License. You may obtain a copy of the License at ~~ - ~~ http://www.apache.org/licenses/LICENSE-2.0 + ~~ https://www.apache.org/licenses/LICENSE-2.0 ~~ ~~ Unless required by applicable law or agreed to in writing, ~~ software distributed under the License is distributed on an diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index b25884e76..52053841f 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -12,7 +12,7 @@ ~~ "License"); you may not use this file except in compliance ~~ with the License. You may obtain a copy of the License at ~~ -~~ http://www.apache.org/licenses/LICENSE-2.0 +~~ https://www.apache.org/licenses/LICENSE-2.0 ~~ ~~ Unless required by applicable law or agreed to in writing, ~~ software distributed under the License is distributed on an From 932024ba8740fbedbad5e8d642a0ef09088daeb0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 14:10:51 -0400 Subject: [PATCH 0369/1013] [secure] More https instead of http and correct some redirects / bad pages --- LICENSE | 2 +- pom.xml | 2 +- src/it/multi/modules/module-1/src/site/site.xml | 2 +- src/it/multi/modules/module-2/src/site/site.xml | 2 +- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 2 +- .../codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy | 2 +- src/main/tools/jFormatString.pom | 4 ++-- src/main/tools/spotbugs-annotations.pom | 2 +- src/main/tools/spotbugs-ant.pom | 2 +- src/main/tools/spotbugs.pom | 2 +- src/site/apt/examples/multi-module-config.apt.vm | 2 +- src/site/apt/examples/violationChecking.apt.vm | 2 +- src/site/apt/usage.apt.vm | 2 +- src/site/fml/faq.fml | 2 +- src/site/resources/examples/spotbugs.html | 2 +- 15 files changed, 16 insertions(+), 16 deletions(-) diff --git a/LICENSE b/LICENSE index c8118641c..ccd61dcfe 100644 --- a/LICENSE +++ b/LICENSE @@ -1,7 +1,7 @@ Apache License Version 2.0, January 2004 - http://www.apache.org/licenses/ + https://www.apache.org/licenses/ TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION diff --git a/pom.xml b/pom.xml index ba6189ccb..8dba43b6d 100644 --- a/pom.xml +++ b/pom.xml @@ -77,7 +77,7 @@ Rolf Kulemann roku@apache.org NEO Business Partners - http://www.neo-partners.com + https://www.axians.de/de/portfolio/sap-solutions-technology/ Java Developer diff --git a/src/it/multi/modules/module-1/src/site/site.xml b/src/it/multi/modules/module-1/src/site/site.xml index 91b1fd0a8..d588ac2de 100644 --- a/src/it/multi/modules/module-1/src/site/site.xml +++ b/src/it/multi/modules/module-1/src/site/site.xml @@ -3,7 +3,7 @@ - + ${reports} diff --git a/src/it/multi/modules/module-2/src/site/site.xml b/src/it/multi/modules/module-2/src/site/site.xml index 91b1fd0a8..d588ac2de 100644 --- a/src/it/multi/modules/module-2/src/site/site.xml +++ b/src/it/multi/modules/module-2/src/site/site.xml @@ -3,7 +3,7 @@ - + ${reports} diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index 729cbec39..65f38a985 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -23,7 +23,7 @@ package org.codehaus.mojo.spotbugs * Generates a Spotbugs Report when the site plugin is run. * The HTML report is generated for site commands only. * To see more documentation about Spotbugs' options, please see the - * Spotbugs Manual. + * Spotbugs Manual. */ interface SpotBugsInfo { diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index 3e6147772..542ff8b69 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -49,7 +49,7 @@ import org.codehaus.plexus.util.FileUtils /** * Fail the build if there were any SpotBugs violations in the source code. * An XML report is put out by default in the target directory with the errors. - * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. + * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. * * @since 2.0 */ diff --git a/src/main/tools/jFormatString.pom b/src/main/tools/jFormatString.pom index 9c6deee3e..a79c24ef1 100644 --- a/src/main/tools/jFormatString.pom +++ b/src/main/tools/jFormatString.pom @@ -6,13 +6,13 @@ jFormatString @Spotbugs.version@ jar - http://www.github.com/spotbugs/ + https://www.github.com/spotbugs/ SpotBugs-jFormatString jFormatString for Spotbugs GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html + https://www.gnu.org/licenses/lgpl.html repo diff --git a/src/main/tools/spotbugs-annotations.pom b/src/main/tools/spotbugs-annotations.pom index 5bc9b38bb..bb0a265a6 100644 --- a/src/main/tools/spotbugs-annotations.pom +++ b/src/main/tools/spotbugs-annotations.pom @@ -12,7 +12,7 @@ GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html + https://www.gnu.org/licenses/lgpl.html repo diff --git a/src/main/tools/spotbugs-ant.pom b/src/main/tools/spotbugs-ant.pom index 8f8257e69..99c7a1db3 100644 --- a/src/main/tools/spotbugs-ant.pom +++ b/src/main/tools/spotbugs-ant.pom @@ -12,7 +12,7 @@ GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html + https://www.gnu.org/licenses/lgpl.html repo diff --git a/src/main/tools/spotbugs.pom b/src/main/tools/spotbugs.pom index 520970f1e..426972e8f 100644 --- a/src/main/tools/spotbugs.pom +++ b/src/main/tools/spotbugs.pom @@ -12,7 +12,7 @@ GNU Lesser Public License - http://www.gnu.org/licenses/lgpl.html + https://www.gnu.org/licenses/lgpl.html repo diff --git a/src/site/apt/examples/multi-module-config.apt.vm b/src/site/apt/examples/multi-module-config.apt.vm index 5429816bb..4ea959212 100644 --- a/src/site/apt/examples/multi-module-config.apt.vm +++ b/src/site/apt/examples/multi-module-config.apt.vm @@ -22,7 +22,7 @@ ~~ under the License. ~~ NOTE: For help with the syntax of this file, see: -~~ http://maven.apache.org/doxia/references/apt-format.html +~~ https://maven.apache.org/doxia/references/apt-format.html Multimodule Configuration diff --git a/src/site/apt/examples/violationChecking.apt.vm b/src/site/apt/examples/violationChecking.apt.vm index 2924c9e3c..5ac98fe73 100644 --- a/src/site/apt/examples/violationChecking.apt.vm +++ b/src/site/apt/examples/violationChecking.apt.vm @@ -22,7 +22,7 @@ ~~ under the License. ~~ NOTE: For help with the syntax of this file, see: -~~ http://maven.apache.org/doxia/references/apt-format.html +~~ https://maven.apache.org/doxia/references/apt-format.html Violation Checking diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index 52053841f..a1e34fb3e 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -22,7 +22,7 @@ ~~ under the License. ~~ NOTE: For help with the syntax of this file, see: -~~ http://maven.apache.org/doxia/references/apt-format.html +~~ https://maven.apache.org/doxia/references/apt-format.html Usage ${projectVersion} diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml index 5acd357d0..58dfcc924 100644 --- a/src/site/fml/faq.fml +++ b/src/site/fml/faq.fml @@ -12,7 +12,7 @@

This may be addressed in the future by a module like - dashboard + dashboard to get an aggregate report.

diff --git a/src/site/resources/examples/spotbugs.html b/src/site/resources/examples/spotbugs.html index 4f66572df..2dbab9969 100644 --- a/src/site/resources/examples/spotbugs.html +++ b/src/site/resources/examples/spotbugs.html @@ -66,7 +66,7 @@
Project Documentation
- + Built by Maven From bc78edc9d24bdd8bef95a68007ce56d83777b742 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 14:43:03 -0400 Subject: [PATCH 0370/1013] [ci] Add note on releasing 4.0 --- src/changes/changes.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/changes/changes.xml b/src/changes/changes.xml index 1c8b0fb9e..75f85792c 100644 --- a/src/changes/changes.xml +++ b/src/changes/changes.xml @@ -6,6 +6,11 @@ + + + Releasing support for spot bugs 4.0 + + Rebrand and upgrade to using spotbugs From f6666dd7bea2ba1ed7c94249e5c0e38ff29104ad Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 14:44:17 -0400 Subject: [PATCH 0371/1013] [ci] Formatting --- .../java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java | 2 +- src/it-tools/build-tools/verify.groovy | 1 - src/it-tools/prime/src/main/resources/filters/lib-filter2.xml | 2 +- src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml | 2 +- src/it-tools/prime/verify.groovy | 1 - src/it/MFINDBUGS-178/pom.xml | 2 +- src/it/basic-1/pom.xml | 2 +- src/it/basic-1/verify.groovy | 1 - src/it/change-xml-filename/verify.groovy | 1 - src/it/check-fail/pom.xml | 2 +- src/it/check-jvmargs/pom.xml | 2 +- src/it/check-jvmargs/verify.groovy | 1 - src/it/check-multi/modules/module-1/pom.xml | 2 +- src/it/check-multi/modules/module-2/pom.xml | 2 +- src/it/check-multi/modules/pom.xml | 2 +- src/it/check-multi/pom.xml | 2 +- src/it/check-nofail/pom.xml | 2 +- src/it/check-pluginList-repo/pom.xml | 2 +- src/it/check-pluginList-repo/verify.groovy | 1 - src/it/check-skip/pom.xml | 2 +- src/it/check-timeout/pom.xml | 2 +- src/it/check/pom.xml | 2 +- src/it/check/verify.groovy | 1 - src/it/effort-default/pom.xml | 2 +- src/it/effort-default/verify.groovy | 1 - src/it/effort-max/pom.xml | 2 +- src/it/effort-max/verify.groovy | 1 - src/it/effort-min/pom.xml | 2 +- src/it/effort-min/verify.groovy | 1 - src/it/empty/pom.xml | 2 +- src/it/empty/verify.groovy | 2 -- src/it/encoding-utf8/pom.xml | 2 +- src/it/encoding-utf8/verify.groovy | 1 - src/it/exclude-modules/module1/pom.xml | 2 +- src/it/exclude-modules/module2/pom.xml | 2 +- src/it/exclude-modules/pom.xml | 2 +- src/it/exclude-multi/pom.xml | 2 +- src/it/exclude-multi/verify.groovy | 1 - src/it/exclude/pom.xml | 2 +- src/it/exclude/verify.groovy | 1 - src/it/excludeBugsFile/excludeBugs1.xml | 2 +- src/it/excludeBugsFile/excludeBugs2.xml | 2 +- src/it/excludeBugsFile/pom.xml | 2 +- src/it/excludeBugsFile/verify.groovy | 1 - src/it/experimental/pom.xml | 2 +- src/it/experimental/verify.groovy | 1 - src/it/include-multi/verify.groovy | 1 - src/it/include/verify.groovy | 1 - src/it/maxRank/pom.xml | 2 +- src/it/maxRank/verify.groovy | 1 - src/it/multi-build/modules/module-1/pom.xml | 2 +- src/it/multi-build/modules/module-2/pom.xml | 2 +- src/it/multi-build/modules/pom.xml | 2 +- src/it/multi-build/pom.xml | 2 +- src/it/multi-build/verify.groovy | 1 - src/it/multi/modules/module-1/pom.xml | 2 +- src/it/multi/modules/module-1/src/site/xdoc/index.xml | 2 +- src/it/multi/modules/module-2/pom.xml | 2 +- src/it/multi/modules/module-2/src/site/xdoc/index.xml | 2 +- src/it/multi/modules/pom.xml | 2 +- src/it/multi/pom.xml | 2 +- src/it/multi/verify.groovy | 1 - src/it/nested/pom.xml | 2 +- src/it/nested/verify.groovy | 1 - src/it/no-src/pom.xml | 1 + src/it/no-src/verify.groovy | 2 -- src/it/no-testsrc/verify.groovy | 1 - src/it/omitVisitors/pom.xml | 2 +- src/it/omitVisitors/verify.groovy | 1 - src/it/onlyAnalyze/pom.xml | 2 +- src/it/onlyAnalyze/verify.groovy | 1 - src/it/pluginList-repo/pom.xml | 2 +- src/it/pluginList-repo/verify.groovy | 1 - src/it/pluginList/pom.xml | 2 +- src/it/pluginList/verify.groovy | 1 - src/it/relaxed/pom.xml | 2 +- src/it/relaxed/verify.groovy | 1 - src/it/site-brazil/pom.xml | 2 +- src/it/site-brazil/verify.groovy | 1 - src/it/site-default/pom.xml | 2 +- src/it/site-default/verify.groovy | 1 - src/it/site-french/verify.groovy | 1 - src/it/site-spanish/pom.xml | 2 +- src/it/site-spanish/verify.groovy | 1 - src/it/skip/pom.xml | 2 +- src/it/skip/verify.groovy | 2 -- src/it/skipEmpty/pom.xml | 2 +- src/it/skipEmpty/verify.groovy | 1 - src/it/threaded/pom.xml | 2 +- src/it/threaded/verify.groovy | 1 - src/it/threshold-experimental/pom.xml | 2 +- src/it/threshold-experimental/verify.groovy | 1 - src/it/threshold-high/pom.xml | 2 +- src/it/threshold-high/verify.groovy | 1 - src/it/threshold-low/pom.xml | 2 +- src/it/threshold-low/verify.groovy | 1 - src/it/trace/pom.xml | 2 +- src/it/trace/verify.groovy | 1 - src/it/userPrefs-override/pom.xml | 2 +- src/it/userPrefs-override/verify.groovy | 1 - src/it/userPrefs/pom.xml | 2 +- src/it/userPrefs/verify.groovy | 1 - src/main/tools/fb2bundle.groovy | 1 - src/main/tools/fb2local.groovy | 2 -- src/main/tools/fb2repo.groovy | 1 - 105 files changed, 60 insertions(+), 108 deletions(-) diff --git a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java index b5ab4a1b1..c62b78aa0 100644 --- a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java +++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java @@ -21,4 +21,4 @@ void thisAlwaysPasses() { public void thisIsIgnored() { // Do nothing } -} \ No newline at end of file +} diff --git a/src/it-tools/build-tools/verify.groovy b/src/it-tools/build-tools/verify.groovy index f8124451f..84fb4e3f7 100644 --- a/src/it-tools/build-tools/verify.groovy +++ b/src/it-tools/build-tools/verify.groovy @@ -15,4 +15,3 @@ */ assert new File(basedir, 'target/build-tools-testing.jar').exists() - diff --git a/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml b/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml index c22ef69d2..adae72cb0 100644 --- a/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml +++ b/src/it-tools/prime/src/main/resources/filters/lib-filter2.xml @@ -3,4 +3,4 @@ - \ No newline at end of file + diff --git a/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml b/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml index 2937c2521..d861517b9 100644 --- a/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml +++ b/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml @@ -3,4 +3,4 @@ - \ No newline at end of file + diff --git a/src/it-tools/prime/verify.groovy b/src/it-tools/prime/verify.groovy index 4b0cf8b2b..c0771f01a 100644 --- a/src/it-tools/prime/verify.groovy +++ b/src/it-tools/prime/verify.groovy @@ -15,4 +15,3 @@ */ assert new File(basedir, 'target/prime-testing.jar').exists() - diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml index 14a84d571..eeb0c743b 100644 --- a/src/it/MFINDBUGS-178/pom.xml +++ b/src/it/MFINDBUGS-178/pom.xml @@ -66,4 +66,4 @@ - \ No newline at end of file + diff --git a/src/it/basic-1/pom.xml b/src/it/basic-1/pom.xml index 4563503c4..bcb7bbbe5 100644 --- a/src/it/basic-1/pom.xml +++ b/src/it/basic-1/pom.xml @@ -46,4 +46,4 @@ - \ No newline at end of file + diff --git a/src/it/basic-1/verify.groovy b/src/it/basic-1/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/basic-1/verify.groovy +++ b/src/it/basic-1/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/change-xml-filename/verify.groovy b/src/it/change-xml-filename/verify.groovy index 84773c695..e64496b82 100644 --- a/src/it/change-xml-filename/verify.groovy +++ b/src/it/change-xml-filename/verify.groovy @@ -32,4 +32,3 @@ println "BugInstance size is ${spotbugsXmlErrors}" assert spotbugsXmlErrors > 0 - diff --git a/src/it/check-fail/pom.xml b/src/it/check-fail/pom.xml index 0bb7616b1..680c6d868 100644 --- a/src/it/check-fail/pom.xml +++ b/src/it/check-fail/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/check-jvmargs/pom.xml b/src/it/check-jvmargs/pom.xml index 022195ae7..c88a06867 100644 --- a/src/it/check-jvmargs/pom.xml +++ b/src/it/check-jvmargs/pom.xml @@ -43,4 +43,4 @@ - \ No newline at end of file + diff --git a/src/it/check-jvmargs/verify.groovy b/src/it/check-jvmargs/verify.groovy index 7ce882d90..95ca6f98d 100644 --- a/src/it/check-jvmargs/verify.groovy +++ b/src/it/check-jvmargs/verify.groovy @@ -44,4 +44,3 @@ def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors - diff --git a/src/it/check-multi/modules/module-1/pom.xml b/src/it/check-multi/modules/module-1/pom.xml index 7980b0cbc..06ce1d9db 100644 --- a/src/it/check-multi/modules/module-1/pom.xml +++ b/src/it/check-multi/modules/module-1/pom.xml @@ -27,4 +27,4 @@ module-1 module-1 jar - \ No newline at end of file + diff --git a/src/it/check-multi/modules/module-2/pom.xml b/src/it/check-multi/modules/module-2/pom.xml index 963358fb1..9cde01f1c 100644 --- a/src/it/check-multi/modules/module-2/pom.xml +++ b/src/it/check-multi/modules/module-2/pom.xml @@ -27,4 +27,4 @@ module-2 module-2 jar - \ No newline at end of file + diff --git a/src/it/check-multi/modules/pom.xml b/src/it/check-multi/modules/pom.xml index bce5de65c..a09f03e9d 100644 --- a/src/it/check-multi/modules/pom.xml +++ b/src/it/check-multi/modules/pom.xml @@ -61,4 +61,4 @@ module-1 module-2 - \ No newline at end of file + diff --git a/src/it/check-multi/pom.xml b/src/it/check-multi/pom.xml index d5f5e63fc..b03611ef8 100644 --- a/src/it/check-multi/pom.xml +++ b/src/it/check-multi/pom.xml @@ -29,4 +29,4 @@ modules - \ No newline at end of file + diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml index 8d4a2daa8..1fa8c02bb 100644 --- a/src/it/check-nofail/pom.xml +++ b/src/it/check-nofail/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/check-pluginList-repo/pom.xml b/src/it/check-pluginList-repo/pom.xml index 6ba00d915..e4e1226a3 100644 --- a/src/it/check-pluginList-repo/pom.xml +++ b/src/it/check-pluginList-repo/pom.xml @@ -45,4 +45,4 @@ - \ No newline at end of file + diff --git a/src/it/check-pluginList-repo/verify.groovy b/src/it/check-pluginList-repo/verify.groovy index 679e49aae..85ccf8118 100644 --- a/src/it/check-pluginList-repo/verify.groovy +++ b/src/it/check-pluginList-repo/verify.groovy @@ -45,4 +45,3 @@ def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors - diff --git a/src/it/check-skip/pom.xml b/src/it/check-skip/pom.xml index bc399ae6f..10f3b0a28 100644 --- a/src/it/check-skip/pom.xml +++ b/src/it/check-skip/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/check-timeout/pom.xml b/src/it/check-timeout/pom.xml index 784f056f5..eeda491b1 100644 --- a/src/it/check-timeout/pom.xml +++ b/src/it/check-timeout/pom.xml @@ -38,4 +38,4 @@ - \ No newline at end of file + diff --git a/src/it/check/pom.xml b/src/it/check/pom.xml index 8d4a2daa8..1fa8c02bb 100644 --- a/src/it/check/pom.xml +++ b/src/it/check/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/check/verify.groovy b/src/it/check/verify.groovy index dba5ac0e7..ae8effc60 100644 --- a/src/it/check/verify.groovy +++ b/src/it/check/verify.groovy @@ -48,4 +48,3 @@ def xdocErrors = xNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors - diff --git a/src/it/effort-default/pom.xml b/src/it/effort-default/pom.xml index 07019d135..a83c27a9c 100644 --- a/src/it/effort-default/pom.xml +++ b/src/it/effort-default/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/effort-default/verify.groovy b/src/it/effort-default/verify.groovy index 4880e185d..6641183e6 100644 --- a/src/it/effort-default/verify.groovy +++ b/src/it/effort-default/verify.groovy @@ -70,4 +70,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLeve assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/effort-max/pom.xml b/src/it/effort-max/pom.xml index af8a00f29..1808535d3 100644 --- a/src/it/effort-max/pom.xml +++ b/src/it/effort-max/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/effort-max/verify.groovy b/src/it/effort-max/verify.groovy index 017c18dfe..21c57f77e 100644 --- a/src/it/effort-max/verify.groovy +++ b/src/it/effort-max/verify.groovy @@ -71,4 +71,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLeve assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/effort-min/pom.xml b/src/it/effort-min/pom.xml index ca3c324ac..402c80468 100644 --- a/src/it/effort-min/pom.xml +++ b/src/it/effort-min/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/effort-min/verify.groovy b/src/it/effort-min/verify.groovy index b763a98bc..97783bd52 100644 --- a/src/it/effort-min/verify.groovy +++ b/src/it/effort-min/verify.groovy @@ -71,4 +71,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLeve assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/empty/pom.xml b/src/it/empty/pom.xml index 49bc70963..4b003b3cd 100644 --- a/src/it/empty/pom.xml +++ b/src/it/empty/pom.xml @@ -60,4 +60,4 @@ - \ No newline at end of file + diff --git a/src/it/empty/verify.groovy b/src/it/empty/verify.groovy index 6da02fdad..64f82d36f 100644 --- a/src/it/empty/verify.groovy +++ b/src/it/empty/verify.groovy @@ -14,11 +14,9 @@ * limitations under the License. */ - assert !(new File(basedir, 'target/site/spotbugs.html').exists()) assert !(new File(basedir, 'target/spotbugs.xml').exists()) assert !(new File(basedir, 'target/spotbugsXml.xml').exists()) - diff --git a/src/it/encoding-utf8/pom.xml b/src/it/encoding-utf8/pom.xml index 82101a767..e41eb9839 100644 --- a/src/it/encoding-utf8/pom.xml +++ b/src/it/encoding-utf8/pom.xml @@ -48,4 +48,4 @@ - \ No newline at end of file + diff --git a/src/it/encoding-utf8/verify.groovy b/src/it/encoding-utf8/verify.groovy index e71aa8946..80d3f179d 100644 --- a/src/it/encoding-utf8/verify.groovy +++ b/src/it/encoding-utf8/verify.groovy @@ -64,4 +64,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/exclude-modules/module1/pom.xml b/src/it/exclude-modules/module1/pom.xml index 9260fd9dc..099ac1a70 100644 --- a/src/it/exclude-modules/module1/pom.xml +++ b/src/it/exclude-modules/module1/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/exclude-modules/module2/pom.xml b/src/it/exclude-modules/module2/pom.xml index 28e2d4e8e..9e6d7dfb9 100644 --- a/src/it/exclude-modules/module2/pom.xml +++ b/src/it/exclude-modules/module2/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/exclude-modules/pom.xml b/src/it/exclude-modules/pom.xml index 5de38a341..89229bde2 100644 --- a/src/it/exclude-modules/pom.xml +++ b/src/it/exclude-modules/pom.xml @@ -30,4 +30,4 @@ module1 module2 - \ No newline at end of file + diff --git a/src/it/exclude-multi/pom.xml b/src/it/exclude-multi/pom.xml index 678d4a39a..ed3636d0c 100644 --- a/src/it/exclude-multi/pom.xml +++ b/src/it/exclude-multi/pom.xml @@ -55,4 +55,4 @@ - \ No newline at end of file + diff --git a/src/it/exclude-multi/verify.groovy b/src/it/exclude-multi/verify.groovy index e71aa8946..80d3f179d 100644 --- a/src/it/exclude-multi/verify.groovy +++ b/src/it/exclude-multi/verify.groovy @@ -64,4 +64,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/exclude/pom.xml b/src/it/exclude/pom.xml index 32bb93fc9..de3321524 100644 --- a/src/it/exclude/pom.xml +++ b/src/it/exclude/pom.xml @@ -55,4 +55,4 @@ - \ No newline at end of file + diff --git a/src/it/exclude/verify.groovy b/src/it/exclude/verify.groovy index 62eb5df59..7e7530dc3 100644 --- a/src/it/exclude/verify.groovy +++ b/src/it/exclude/verify.groovy @@ -64,4 +64,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/excludeBugsFile/excludeBugs1.xml b/src/it/excludeBugsFile/excludeBugs1.xml index 4c733a96e..a611247db 100644 --- a/src/it/excludeBugsFile/excludeBugs1.xml +++ b/src/it/excludeBugsFile/excludeBugs1.xml @@ -165,4 +165,4 @@ final local variables. Because SpotBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. </p> - Suspicious calls to generic collection methodsUninitialized read of field in constructorDubious method usedEqual objects must have equal hashcodesRedundant comparison to nullSuspicious integer expressionComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceUseless self-operation \ No newline at end of file + Suspicious calls to generic collection methodsUninitialized read of field in constructorDubious method usedEqual objects must have equal hashcodesRedundant comparison to nullSuspicious integer expressionComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceUseless self-operation diff --git a/src/it/excludeBugsFile/excludeBugs2.xml b/src/it/excludeBugsFile/excludeBugs2.xml index ba077e7ab..9e8b20110 100644 --- a/src/it/excludeBugsFile/excludeBugs2.xml +++ b/src/it/excludeBugsFile/excludeBugs2.xml @@ -13,4 +13,4 @@ final local variables. Because FindBugs is a bytecode-based tool, there is no easy way to eliminate these false positives. </p> - Dead local store \ No newline at end of file + Dead local store diff --git a/src/it/excludeBugsFile/pom.xml b/src/it/excludeBugsFile/pom.xml index 72244ffac..694b75642 100644 --- a/src/it/excludeBugsFile/pom.xml +++ b/src/it/excludeBugsFile/pom.xml @@ -41,4 +41,4 @@ - \ No newline at end of file + diff --git a/src/it/excludeBugsFile/verify.groovy b/src/it/excludeBugsFile/verify.groovy index 58818ff6c..bf45731e7 100644 --- a/src/it/excludeBugsFile/verify.groovy +++ b/src/it/excludeBugsFile/verify.groovy @@ -45,4 +45,3 @@ def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${spotbugsXmlErrors}" assert xdocErrors == spotbugsXmlErrors - diff --git a/src/it/experimental/pom.xml b/src/it/experimental/pom.xml index f0392d942..bffddc4b2 100644 --- a/src/it/experimental/pom.xml +++ b/src/it/experimental/pom.xml @@ -45,4 +45,4 @@ - \ No newline at end of file + diff --git a/src/it/experimental/verify.groovy b/src/it/experimental/verify.groovy index ad4dcd837..1b0d24a33 100644 --- a/src/it/experimental/verify.groovy +++ b/src/it/experimental/verify.groovy @@ -69,4 +69,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@threshold.text() == thresho assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/include-multi/verify.groovy b/src/it/include-multi/verify.groovy index e71aa8946..80d3f179d 100644 --- a/src/it/include-multi/verify.groovy +++ b/src/it/include-multi/verify.groovy @@ -64,4 +64,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/include/verify.groovy b/src/it/include/verify.groovy index e71aa8946..80d3f179d 100644 --- a/src/it/include/verify.groovy +++ b/src/it/include/verify.groovy @@ -64,4 +64,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/maxRank/pom.xml b/src/it/maxRank/pom.xml index 90f14bae4..779bf6a20 100644 --- a/src/it/maxRank/pom.xml +++ b/src/it/maxRank/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/maxRank/verify.groovy b/src/it/maxRank/verify.groovy index 58818ff6c..bf45731e7 100644 --- a/src/it/maxRank/verify.groovy +++ b/src/it/maxRank/verify.groovy @@ -45,4 +45,3 @@ def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${spotbugsXmlErrors}" assert xdocErrors == spotbugsXmlErrors - diff --git a/src/it/multi-build/modules/module-1/pom.xml b/src/it/multi-build/modules/module-1/pom.xml index 7980b0cbc..06ce1d9db 100644 --- a/src/it/multi-build/modules/module-1/pom.xml +++ b/src/it/multi-build/modules/module-1/pom.xml @@ -27,4 +27,4 @@ module-1 module-1 jar - \ No newline at end of file + diff --git a/src/it/multi-build/modules/module-2/pom.xml b/src/it/multi-build/modules/module-2/pom.xml index 963358fb1..9cde01f1c 100644 --- a/src/it/multi-build/modules/module-2/pom.xml +++ b/src/it/multi-build/modules/module-2/pom.xml @@ -27,4 +27,4 @@ module-2 module-2 jar - \ No newline at end of file + diff --git a/src/it/multi-build/modules/pom.xml b/src/it/multi-build/modules/pom.xml index 8f2396446..f9c15a5b8 100644 --- a/src/it/multi-build/modules/pom.xml +++ b/src/it/multi-build/modules/pom.xml @@ -40,4 +40,4 @@ module-1 module-2 - \ No newline at end of file + diff --git a/src/it/multi-build/pom.xml b/src/it/multi-build/pom.xml index 36cb7f843..75dd64ea8 100644 --- a/src/it/multi-build/pom.xml +++ b/src/it/multi-build/pom.xml @@ -58,4 +58,4 @@ - \ No newline at end of file + diff --git a/src/it/multi-build/verify.groovy b/src/it/multi-build/verify.groovy index 590494136..5d994177e 100644 --- a/src/it/multi-build/verify.groovy +++ b/src/it/multi-build/verify.groovy @@ -154,4 +154,3 @@ spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == println "BugInstance with includes size is ${spotbugsXmlErrors}" assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/multi/modules/module-1/pom.xml b/src/it/multi/modules/module-1/pom.xml index 7980b0cbc..06ce1d9db 100644 --- a/src/it/multi/modules/module-1/pom.xml +++ b/src/it/multi/modules/module-1/pom.xml @@ -27,4 +27,4 @@ module-1 module-1 jar - \ No newline at end of file + diff --git a/src/it/multi/modules/module-1/src/site/xdoc/index.xml b/src/it/multi/modules/module-1/src/site/xdoc/index.xml index 6bab5b73e..6efb12a9a 100644 --- a/src/it/multi/modules/module-1/src/site/xdoc/index.xml +++ b/src/it/multi/modules/module-1/src/site/xdoc/index.xml @@ -11,4 +11,4 @@

- \ No newline at end of file + diff --git a/src/it/multi/modules/module-2/pom.xml b/src/it/multi/modules/module-2/pom.xml index 963358fb1..9cde01f1c 100644 --- a/src/it/multi/modules/module-2/pom.xml +++ b/src/it/multi/modules/module-2/pom.xml @@ -27,4 +27,4 @@ module-2 module-2 jar - \ No newline at end of file + diff --git a/src/it/multi/modules/module-2/src/site/xdoc/index.xml b/src/it/multi/modules/module-2/src/site/xdoc/index.xml index 925d6ac47..73c6f349a 100644 --- a/src/it/multi/modules/module-2/src/site/xdoc/index.xml +++ b/src/it/multi/modules/module-2/src/site/xdoc/index.xml @@ -11,4 +11,4 @@

- \ No newline at end of file + diff --git a/src/it/multi/modules/pom.xml b/src/it/multi/modules/pom.xml index 4ebea1c19..4883ec293 100644 --- a/src/it/multi/modules/pom.xml +++ b/src/it/multi/modules/pom.xml @@ -59,4 +59,4 @@ module-1 module-2 - \ No newline at end of file + diff --git a/src/it/multi/pom.xml b/src/it/multi/pom.xml index d5f5e63fc..b03611ef8 100644 --- a/src/it/multi/pom.xml +++ b/src/it/multi/pom.xml @@ -29,4 +29,4 @@ modules - \ No newline at end of file + diff --git a/src/it/multi/verify.groovy b/src/it/multi/verify.groovy index 3aa8d7fc7..f90f3ca9f 100644 --- a/src/it/multi/verify.groovy +++ b/src/it/multi/verify.groovy @@ -156,4 +156,3 @@ spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance' && it.@type == println "BugInstance with includes size is ${spotbugsXmlErrors}" assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/nested/pom.xml b/src/it/nested/pom.xml index 9f9470e03..8750e0f6c 100644 --- a/src/it/nested/pom.xml +++ b/src/it/nested/pom.xml @@ -46,4 +46,4 @@ - \ No newline at end of file + diff --git a/src/it/nested/verify.groovy b/src/it/nested/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/nested/verify.groovy +++ b/src/it/nested/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/no-src/pom.xml b/src/it/no-src/pom.xml index 761ada98d..79bba23fa 100644 --- a/src/it/no-src/pom.xml +++ b/src/it/no-src/pom.xml @@ -44,3 +44,4 @@ + diff --git a/src/it/no-src/verify.groovy b/src/it/no-src/verify.groovy index cac4e48ed..e1c0ea208 100644 --- a/src/it/no-src/verify.groovy +++ b/src/it/no-src/verify.groovy @@ -14,8 +14,6 @@ * limitations under the License. */ - - assert (new File(basedir, 'target/site/index.html').exists()) assert (new File(basedir, 'target/spotbugs.xml').exists()) assert (new File(basedir, 'target/spotbugsXml.xml').exists()) diff --git a/src/it/no-testsrc/verify.groovy b/src/it/no-testsrc/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/no-testsrc/verify.groovy +++ b/src/it/no-testsrc/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/omitVisitors/pom.xml b/src/it/omitVisitors/pom.xml index 7627878b2..f6878f749 100644 --- a/src/it/omitVisitors/pom.xml +++ b/src/it/omitVisitors/pom.xml @@ -46,4 +46,4 @@ - \ No newline at end of file + diff --git a/src/it/omitVisitors/verify.groovy b/src/it/omitVisitors/verify.groovy index 453dd067c..e1923cf5b 100644 --- a/src/it/omitVisitors/verify.groovy +++ b/src/it/omitVisitors/verify.groovy @@ -81,4 +81,3 @@ xdocErrors += allNodes.findAll {it.name() == 'BugInstance' && it.@type == "DLS_ println "BugInstance with includes size is ${xdocErrors}" assert 0 == xdocErrors - diff --git a/src/it/onlyAnalyze/pom.xml b/src/it/onlyAnalyze/pom.xml index 1b00cad5c..468e18c0c 100644 --- a/src/it/onlyAnalyze/pom.xml +++ b/src/it/onlyAnalyze/pom.xml @@ -46,4 +46,4 @@ - \ No newline at end of file + diff --git a/src/it/onlyAnalyze/verify.groovy b/src/it/onlyAnalyze/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/onlyAnalyze/verify.groovy +++ b/src/it/onlyAnalyze/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/pluginList-repo/pom.xml b/src/it/pluginList-repo/pom.xml index ae5d15e40..8a5b8f3cb 100644 --- a/src/it/pluginList-repo/pom.xml +++ b/src/it/pluginList-repo/pom.xml @@ -51,4 +51,4 @@ - \ No newline at end of file + diff --git a/src/it/pluginList-repo/verify.groovy b/src/it/pluginList-repo/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/pluginList-repo/verify.groovy +++ b/src/it/pluginList-repo/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/pluginList/pom.xml b/src/it/pluginList/pom.xml index 7b6056294..5a05a97e2 100644 --- a/src/it/pluginList/pom.xml +++ b/src/it/pluginList/pom.xml @@ -44,4 +44,4 @@ - \ No newline at end of file + diff --git a/src/it/pluginList/verify.groovy b/src/it/pluginList/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/pluginList/verify.groovy +++ b/src/it/pluginList/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/relaxed/pom.xml b/src/it/relaxed/pom.xml index f7d516a9a..01147e6d4 100644 --- a/src/it/relaxed/pom.xml +++ b/src/it/relaxed/pom.xml @@ -40,4 +40,4 @@ - \ No newline at end of file + diff --git a/src/it/relaxed/verify.groovy b/src/it/relaxed/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/relaxed/verify.groovy +++ b/src/it/relaxed/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/site-brazil/pom.xml b/src/it/site-brazil/pom.xml index 56dfb8d98..3230484fd 100644 --- a/src/it/site-brazil/pom.xml +++ b/src/it/site-brazil/pom.xml @@ -53,4 +53,4 @@ - \ No newline at end of file + diff --git a/src/it/site-brazil/verify.groovy b/src/it/site-brazil/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/site-brazil/verify.groovy +++ b/src/it/site-brazil/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/site-default/pom.xml b/src/it/site-default/pom.xml index 3493d096b..9d70e96e3 100644 --- a/src/it/site-default/pom.xml +++ b/src/it/site-default/pom.xml @@ -51,4 +51,4 @@ - \ No newline at end of file + diff --git a/src/it/site-default/verify.groovy b/src/it/site-default/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/site-default/verify.groovy +++ b/src/it/site-default/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/site-french/verify.groovy b/src/it/site-french/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/site-french/verify.groovy +++ b/src/it/site-french/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/site-spanish/pom.xml b/src/it/site-spanish/pom.xml index 219c89b69..4c01a5368 100644 --- a/src/it/site-spanish/pom.xml +++ b/src/it/site-spanish/pom.xml @@ -51,4 +51,4 @@ - \ No newline at end of file + diff --git a/src/it/site-spanish/verify.groovy b/src/it/site-spanish/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/site-spanish/verify.groovy +++ b/src/it/site-spanish/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/skip/pom.xml b/src/it/skip/pom.xml index e9d979a6b..62a529ea4 100644 --- a/src/it/skip/pom.xml +++ b/src/it/skip/pom.xml @@ -47,4 +47,4 @@ - \ No newline at end of file + diff --git a/src/it/skip/verify.groovy b/src/it/skip/verify.groovy index c7acf5b0a..74ea7b713 100644 --- a/src/it/skip/verify.groovy +++ b/src/it/skip/verify.groovy @@ -14,8 +14,6 @@ * limitations under the License. */ - assert !(new File(basedir, 'target/site/spotbugs.html').exists()) assert !(new File(basedir, 'target/spotbugs.xml').exists()) assert !(new File(basedir, 'target/spotbugsXml.xml').exists()) - diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml index 2593429ed..2e1ad72ac 100644 --- a/src/it/skipEmpty/pom.xml +++ b/src/it/skipEmpty/pom.xml @@ -67,4 +67,4 @@ - \ No newline at end of file + diff --git a/src/it/skipEmpty/verify.groovy b/src/it/skipEmpty/verify.groovy index c673ae575..213b199c4 100644 --- a/src/it/skipEmpty/verify.groovy +++ b/src/it/skipEmpty/verify.groovy @@ -37,4 +37,3 @@ def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() println "BugInstance size is ${spotbugsXmlErrors}" assert spotbugsXmlErrors == 0 - diff --git a/src/it/threaded/pom.xml b/src/it/threaded/pom.xml index 02975af2a..9a07e4a6a 100644 --- a/src/it/threaded/pom.xml +++ b/src/it/threaded/pom.xml @@ -45,4 +45,4 @@ - \ No newline at end of file + diff --git a/src/it/threaded/verify.groovy b/src/it/threaded/verify.groovy index 8e39c9dd7..605f2a6f9 100644 --- a/src/it/threaded/verify.groovy +++ b/src/it/threaded/verify.groovy @@ -68,4 +68,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/threshold-experimental/pom.xml b/src/it/threshold-experimental/pom.xml index aeec3f248..23578156d 100644 --- a/src/it/threshold-experimental/pom.xml +++ b/src/it/threshold-experimental/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/threshold-experimental/verify.groovy b/src/it/threshold-experimental/verify.groovy index c88eef3a1..f11e38ab2 100644 --- a/src/it/threshold-experimental/verify.groovy +++ b/src/it/threshold-experimental/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/threshold-high/pom.xml b/src/it/threshold-high/pom.xml index 09d1c1fbf..9d79d1c03 100644 --- a/src/it/threshold-high/pom.xml +++ b/src/it/threshold-high/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/threshold-high/verify.groovy b/src/it/threshold-high/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/threshold-high/verify.groovy +++ b/src/it/threshold-high/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/threshold-low/pom.xml b/src/it/threshold-low/pom.xml index aab22b527..4286f8d91 100644 --- a/src/it/threshold-low/pom.xml +++ b/src/it/threshold-low/pom.xml @@ -42,4 +42,4 @@ - \ No newline at end of file + diff --git a/src/it/threshold-low/verify.groovy b/src/it/threshold-low/verify.groovy index d89e93913..7c951e511 100644 --- a/src/it/threshold-low/verify.groovy +++ b/src/it/threshold-low/verify.groovy @@ -70,4 +70,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@threshold.text() == thresho assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/trace/pom.xml b/src/it/trace/pom.xml index 7e31e37dd..4ca0de78d 100644 --- a/src/it/trace/pom.xml +++ b/src/it/trace/pom.xml @@ -46,4 +46,4 @@ - \ No newline at end of file + diff --git a/src/it/trace/verify.groovy b/src/it/trace/verify.groovy index f12cbc7ca..50e5c4cfc 100644 --- a/src/it/trace/verify.groovy +++ b/src/it/trace/verify.groovy @@ -69,4 +69,3 @@ println "BugInstance size is ${xdocErrors}" assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/userPrefs-override/pom.xml b/src/it/userPrefs-override/pom.xml index 008d8c645..fedec21f9 100644 --- a/src/it/userPrefs-override/pom.xml +++ b/src/it/userPrefs-override/pom.xml @@ -43,4 +43,4 @@ - \ No newline at end of file + diff --git a/src/it/userPrefs-override/verify.groovy b/src/it/userPrefs-override/verify.groovy index ad9133f2b..ca86bb6ca 100644 --- a/src/it/userPrefs-override/verify.groovy +++ b/src/it/userPrefs-override/verify.groovy @@ -70,4 +70,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLeve assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/it/userPrefs/pom.xml b/src/it/userPrefs/pom.xml index 96cbce103..607f07fd8 100644 --- a/src/it/userPrefs/pom.xml +++ b/src/it/userPrefs/pom.xml @@ -45,4 +45,4 @@ - \ No newline at end of file + diff --git a/src/it/userPrefs/verify.groovy b/src/it/userPrefs/verify.groovy index 77ced0780..064d9a454 100644 --- a/src/it/userPrefs/verify.groovy +++ b/src/it/userPrefs/verify.groovy @@ -70,4 +70,3 @@ assert path.findAll {it.name() == 'BugCollection'}.@effort.text() == effortLeve assert xdocErrors == spotbugsXmlErrors assert spotbugsErrors == spotbugsXmlErrors - diff --git a/src/main/tools/fb2bundle.groovy b/src/main/tools/fb2bundle.groovy index c91997e21..f2b5ab5bc 100644 --- a/src/main/tools/fb2bundle.groovy +++ b/src/main/tools/fb2bundle.groovy @@ -26,4 +26,3 @@ modules.each(){ module -> proc = cmd.execute() println proc.text } - diff --git a/src/main/tools/fb2local.groovy b/src/main/tools/fb2local.groovy index a2f94c859..50cef8be1 100644 --- a/src/main/tools/fb2local.groovy +++ b/src/main/tools/fb2local.groovy @@ -39,5 +39,3 @@ modules.each(){ module -> } antBuilder.delete(file: "pom.xml") - - diff --git a/src/main/tools/fb2repo.groovy b/src/main/tools/fb2repo.groovy index c0f49fcea..e211abd28 100644 --- a/src/main/tools/fb2repo.groovy +++ b/src/main/tools/fb2repo.groovy @@ -40,4 +40,3 @@ modules.each(){ module -> println proc.text antBuilder.delete(file: "pom.xml") } - From 487afd677b9b63ba265f6509411480fc50c088bb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 14:44:27 -0400 Subject: [PATCH 0372/1013] [html] Cleanup html5 issues --- src/site/resources/examples/spotbugs.html | 273 ++++++++++++---------- 1 file changed, 147 insertions(+), 126 deletions(-) diff --git a/src/site/resources/examples/spotbugs.html b/src/site/resources/examples/spotbugs.html index 2dbab9969..715924066 100644 --- a/src/site/resources/examples/spotbugs.html +++ b/src/site/resources/examples/spotbugs.html @@ -78,17 +78,18 @@
Project Documentation

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

-

SpotBugs Version is 3.1.0

-

Threshold is medium

-

Effort is min

+

SpotBugs Version is 3.1.0

+

Threshold is medium

+

Effort is min

Summary

-
Bug
+
+ - - - - + + + + @@ -96,10 +97,11 @@

Summary

Spotbug Results
ClassesBugsErrorsMissing Classes
ClassesBugsErrorsMissing Classes
44 92 0

Files

- +
+ - - + + @@ -159,13 +161,14 @@

Files

Spotbug Results
ClassBugs
ClassBugs
AbstractMissingHashCode$StillMissingHashCode 2
2

AbstractMissingHashCode$StillMissingHashCode

- +
+ - - - - - + + + + + @@ -180,13 +183,14 @@

AbstractMissingHashC

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode() BAD_PRACTICEMedium

AccidentalNonConstructorInInnerClass$DoNotReport

- +
+ - - - - - + + + + + @@ -195,13 +199,14 @@

AccidentalNonCon

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Should AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class? PERFORMANCEMedium

AccidentalNonConstructorInInnerClass$Report

- +
+ - - - - - + + + + + @@ -210,13 +215,14 @@

AccidentalNonConstruc

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Should AccidentalNonConstructorInInnerClass$Report be a _static_ inner class? PERFORMANCEMedium

AppendingToAnObjectOutputStream

- +
+ - - - - - + + + + + @@ -243,13 +249,14 @@

AppendingToAnObjectOutputStream<

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object) CORRECTNESSHigh

ArrayToString

- +
+ - - - - - + + + + + @@ -276,13 +283,14 @@

ArrayToString

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Invocation of toString on an unnamed array in ArrayToString.print2() CORRECTNESS Medium

AssumeUnsignedBytes

- +
+ - - - - - + + + + + @@ -291,13 +299,14 @@

AssumeUnsignedBytes

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[]) CORRECTNESS High

UseOfNonHashableClassInHashDataStructure

- +
+ - - - - - + + + + + @@ -324,13 +333,14 @@

UseOfNonHashableClassIn

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
UseOfNonHashableClassInHashDataStructure.equals(Object) is unusual STYLEMedium

UselessAssignments

- +
+ - - - - - + + + + + @@ -417,13 +427,14 @@

UselessAssignments

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Dead store to $L2 in new UselessAssignments(int, int) STYLE Medium

UselessControlFlow

- +
+ - - - - - + + + + + @@ -450,13 +461,14 @@

UselessControlFlow

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Useless control flow in UselessControlFlow.report2(Object, Object) STYLE Medium

UselessCurrentThread

- +
+ - - - - - + + + + + @@ -465,13 +477,14 @@

UselessCurrentThread

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
UselessCurrentThread.run() invokes static Thread.interrupted() method on thread instance CORRECTNESS Medium

UselessFinalize

- +
+ - - - - - + + + + + @@ -480,13 +493,14 @@

UselessFinalize

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
UselessFinalize.finalize() does nothing except call super.finalize(); delete it BAD_PRACTICE Medium

UserMistakes

- +
+ - - - - - + + + + + @@ -519,13 +533,14 @@

UserMistakes

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Dead store to $L3 in UserMistakes.main(String[]) STYLE Medium

equals.ArrayEquality

- +
+ - - - - - + + + + + @@ -576,13 +591,14 @@

equals.ArrayEquality

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Calling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String) CORRECTNESS Medium

gcUnrelatedTypes.AllListsCouldBeEqual

- +
+ - - - - - + + + + + @@ -615,13 +631,14 @@

gcUnrelatedTypes.AllListsC

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Impossible cast from java.util.LinkedList to java.util.ArrayList in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[]) CORRECTNESSMedium

gcUnrelatedTypes.ArrayListContains

- +
+ - - - - - + + + + + @@ -690,13 +707,14 @@

gcUnrelatedTypes.ArrayListCon

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
String is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList) CORRECTNESSMedium

gcUnrelatedTypes.ArrayListContains0

- +
+ - - - - - + + + + + @@ -789,13 +807,14 @@

gcUnrelatedTypes.ArrayListCo

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Dead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList) STYLEMedium

npe.UseCheckUse

- +
+ - - - - - + + + + + @@ -804,13 +823,14 @@

npe.UseCheckUse

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Nullcheck of UseCheckUse.x at line 10 of value previously dereferenced in npe.UseCheckUse.f(boolean) CORRECTNESS High

nullnessAnnotations.UseAnnotations

- +
+ - - - - - + + + + + @@ -861,13 +881,14 @@

nullnessAnnotations.UseAnnota

Spotbug Results
BugCategoryDetailsLinePriority
BugCategoryDetailsLinePriority
Null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2() CORRECTNESSMedium

com.github.spotbugs.spotbugs-maven-plugin.it.App

- - - - - - - +
BugCategoryDetailsLinePriority
+ + + + + + + From e0d8383088d7c90555ad4945d2b33a7fc795fc5a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 14 Mar 2020 15:44:53 -0400 Subject: [PATCH 0373/1013] [cleanup] More formatting / html 5 --- src/site/fml/faq.fml | 2 +- src/site/resources/examples/css/maven-theme.css | 1 - src/site/resources/examples/css/site.css | 2 +- src/site/resources/examples/spotbugs.xml | 2 +- src/site/resources/examples/spotbugsXml.xml | 3 ++- .../spotbugs/spotbugs-maven-plugin/it/package-summary.html | 3 ++- src/site/resources/examples/xref-test/overview-summary.html | 3 ++- .../examples/xref/badNaming/package1/package-summary.html | 3 ++- .../examples/xref/badNaming/package2/package-summary.html | 3 ++- src/site/resources/examples/xref/equals/package-summary.html | 3 ++- .../examples/xref/gcUnrelatedTypes/package-summary.html | 3 ++- src/site/resources/examples/xref/jsr305/package-summary.html | 3 ++- src/site/resources/examples/xref/npe/package-summary.html | 3 ++- .../examples/xref/nullnessAnnotations/package-summary.html | 3 ++- .../resources/examples/xref/obligation/package-summary.html | 3 ++- src/site/resources/examples/xref/overview-summary.html | 3 ++- src/site/resources/examples/xref/package-summary.html | 3 ++- .../resources/examples/xref/uselessThread/package-summary.html | 3 ++- 18 files changed, 31 insertions(+), 18 deletions(-) diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml index 58dfcc924..250becf39 100644 --- a/src/site/fml/faq.fml +++ b/src/site/fml/faq.fml @@ -36,4 +36,4 @@ - \ No newline at end of file + diff --git a/src/site/resources/examples/css/maven-theme.css b/src/site/resources/examples/css/maven-theme.css index c982168bf..3725046d2 100644 --- a/src/site/resources/examples/css/maven-theme.css +++ b/src/site/resources/examples/css/maven-theme.css @@ -138,4 +138,3 @@ dt { .infomark { background-image: url(../images/icon_info_sml.gif); } - diff --git a/src/site/resources/examples/css/site.css b/src/site/resources/examples/css/site.css index 055e7e286..a7d41b2d0 100644 --- a/src/site/resources/examples/css/site.css +++ b/src/site/resources/examples/css/site.css @@ -1 +1 @@ -/* You can override this file with your own styles */ \ No newline at end of file +/* You can override this file with your own styles */ diff --git a/src/site/resources/examples/spotbugs.xml b/src/site/resources/examples/spotbugs.xml index 1e19c47f6..8a516863b 100644 --- a/src/site/resources/examples/spotbugs.xml +++ b/src/site/resources/examples/spotbugs.xml @@ -1,2 +1,2 @@ -/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java \ No newline at end of file +/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java diff --git a/src/site/resources/examples/spotbugsXml.xml b/src/site/resources/examples/spotbugsXml.xml index bf3a326fa..349a321e7 100644 --- a/src/site/resources/examples/spotbugsXml.xml +++ b/src/site/resources/examples/spotbugsXml.xml @@ -414,4 +414,5 @@ to use Object.clone(), which always returns an object of the correct type.</p Such assignments are useless, and may indicate a logic error or typo. </p> - Suspicious calls to generic collection methodsUninitialized read of field in constructorEqual objects must have equal hashcodesRegular expressionsComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceDubious method invocationUnused fieldProblems with implementation of equals()Dubious method usedUseless codeInner class could be made staticRedundant comparison to nullBad use of return value from methodUseless control flowSuspicious integer expressionUnread fieldBad casts of object referencesUseless/non-informative string generatedSuspicious Thread InterruptedBad implementation of cloneable idiomIncorrect use of finalizersUseless self-operation \ No newline at end of file + Suspicious calls to generic collection methodsUninitialized read of field in constructorEqual objects must have equal hashcodesRegular expressionsComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceDubious method invocationUnused fieldProblems with implementation of equals()Dubious method usedUseless codeInner class could be made staticRedundant comparison to nullBad use of return value from methodUseless control flowSuspicious integer expressionUnread fieldBad casts of object referencesUseless/non-informative string generatedSuspicious Thread InterruptedBad implementation of cloneable idiomIncorrect use of finalizersUseless self-operation + \ No newline at end of file diff --git a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-summary.html b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-summary.html index 1ab163d4e..5a460ab8e 100644 --- a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-summary.html +++ b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-summary.html @@ -30,9 +30,10 @@

Package com.github.spotbugs.spotbugs-maven-plugin.it

Spotbug Results
BugCategoryDetailsLinePriority
com.github.spotbugs.spotbugs-maven-plugin.it.App.clone() does not call super.clone() BAD_PRACTICE
+ - + diff --git a/src/site/resources/examples/xref-test/overview-summary.html b/src/site/resources/examples/xref-test/overview-summary.html index 791704778..e4a7c9f5d 100644 --- a/src/site/resources/examples/xref-test/overview-summary.html +++ b/src/site/resources/examples/xref-test/overview-summary.html @@ -28,9 +28,10 @@

basic-1 testing Reference

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/badNaming/package1/package-summary.html b/src/site/resources/examples/xref/badNaming/package1/package-summary.html index 775adafda..47edc4024 100644 --- a/src/site/resources/examples/xref/badNaming/package1/package-summary.html +++ b/src/site/resources/examples/xref/badNaming/package1/package-summary.html @@ -30,9 +30,10 @@

Package badNaming.package1

Packages
PackagesPackages
+ - + diff --git a/src/site/resources/examples/xref/badNaming/package2/package-summary.html b/src/site/resources/examples/xref/badNaming/package2/package-summary.html index 84ee650cd..c87989d8d 100644 --- a/src/site/resources/examples/xref/badNaming/package2/package-summary.html +++ b/src/site/resources/examples/xref/badNaming/package2/package-summary.html @@ -30,9 +30,10 @@

Package badNaming.package2

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/equals/package-summary.html b/src/site/resources/examples/xref/equals/package-summary.html index d03f78e48..15004beff 100644 --- a/src/site/resources/examples/xref/equals/package-summary.html +++ b/src/site/resources/examples/xref/equals/package-summary.html @@ -30,9 +30,10 @@

Package equals

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html b/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html index 4e32c4d96..4cdd4e15d 100644 --- a/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html +++ b/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html @@ -30,9 +30,10 @@

Package gcUnrelatedTypes

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/jsr305/package-summary.html b/src/site/resources/examples/xref/jsr305/package-summary.html index d14b8f8c0..2df39dd8c 100644 --- a/src/site/resources/examples/xref/jsr305/package-summary.html +++ b/src/site/resources/examples/xref/jsr305/package-summary.html @@ -30,9 +30,10 @@

Package jsr305

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/npe/package-summary.html b/src/site/resources/examples/xref/npe/package-summary.html index 2fb3004b5..b6b07f84b 100644 --- a/src/site/resources/examples/xref/npe/package-summary.html +++ b/src/site/resources/examples/xref/npe/package-summary.html @@ -30,9 +30,10 @@

Package npe

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html b/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html index 5ea1eb4f7..59f5d9157 100644 --- a/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html +++ b/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html @@ -30,9 +30,10 @@

Package nullnessAnnotations

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/obligation/package-summary.html b/src/site/resources/examples/xref/obligation/package-summary.html index b52f2108f..888ae8256 100644 --- a/src/site/resources/examples/xref/obligation/package-summary.html +++ b/src/site/resources/examples/xref/obligation/package-summary.html @@ -30,9 +30,10 @@

Package obligation

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/overview-summary.html b/src/site/resources/examples/xref/overview-summary.html index 103520907..7bb68a49e 100644 --- a/src/site/resources/examples/xref/overview-summary.html +++ b/src/site/resources/examples/xref/overview-summary.html @@ -28,9 +28,10 @@

basic-1 testing Reference

Class Summary
Class SummaryClass Summary
+ - + diff --git a/src/site/resources/examples/xref/package-summary.html b/src/site/resources/examples/xref/package-summary.html index d2e1a0dc3..1664578cd 100644 --- a/src/site/resources/examples/xref/package-summary.html +++ b/src/site/resources/examples/xref/package-summary.html @@ -30,9 +30,10 @@

Package (default package)

Packages
PackagesPackages
+ - + diff --git a/src/site/resources/examples/xref/uselessThread/package-summary.html b/src/site/resources/examples/xref/uselessThread/package-summary.html index 64e3c45d4..6c0e6288c 100644 --- a/src/site/resources/examples/xref/uselessThread/package-summary.html +++ b/src/site/resources/examples/xref/uselessThread/package-summary.html @@ -30,9 +30,10 @@

Package uselessThread

Class Summary
Class SummaryClass Summary
+ - + From 3ec226c29246b242d2dbc6d9afe305e628a7c96c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 15 Mar 2020 19:02:42 -0400 Subject: [PATCH 0374/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.0.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 8dba43b6d..9750d8668 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.0-SNAPSHOT + 4.0.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.0.0 GitHub Issues From 9abfdd17617b8db2b7908215003dbf6aa9b6d70a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 15 Mar 2020 19:02:43 -0400 Subject: [PATCH 0375/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 9750d8668..c7fa4b4f3 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.0 + 4.0.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.0.0 + HEAD GitHub Issues From a86d870958ef44d89eff459b933c0a34a082fbef Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 15 Mar 2020 19:10:07 -0400 Subject: [PATCH 0376/1013] [pom] Add patch for depedency check to latest 5.3.1 --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index c7fa4b4f3..15625a994 100644 --- a/pom.xml +++ b/pom.xml @@ -185,6 +185,9 @@ 2.6 3.9 1.6 + + + 5.3.1 From 00ba7287d1d638c923a5f1ea2242d9a844937a20 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 15 Mar 2020 19:25:06 -0400 Subject: [PATCH 0377/1013] [pom] Skip dependency check for system scope Recent updates in groovy now cause this to fail. --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index 15625a994..6de561b70 100644 --- a/pom.xml +++ b/pom.xml @@ -490,6 +490,15 @@ spotbugs-maven-plugin ${project.version} + + + + org.owasp + dependency-check-maven + + true + + From 3ff7bd2c498d4193430ed051baf229d51fec8dbb Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 16 Mar 2020 08:48:28 +0000 Subject: [PATCH 0378/1013] Bump org.eclipse.jgit from 5.7.0.202003090808-r to 5.7.0.202003110725-r Bumps org.eclipse.jgit from 5.7.0.202003090808-r to 5.7.0.202003110725-r. Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6de561b70..32db839f0 100644 --- a/pom.xml +++ b/pom.xml @@ -173,7 +173,7 @@ 4.0.3 7.4.7 - 5.7.0.202003090808-r + 5.7.0.202003110725-r 7.3.1 From 41db27d707b2fdaa9df39c1f81e31231ab881aeb Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 16 Mar 2020 13:24:53 +0000 Subject: [PATCH 0379/1013] Bump maven-javadoc-plugin from 3.1.1 to 3.2.0 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.1.1...maven-javadoc-plugin-3.2.0) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 32db839f0..3f0a95fd3 100644 --- a/pom.xml +++ b/pom.xml @@ -145,7 +145,7 @@ 1.8.1 3.0.0 3.2.1 - 3.1.1 + 3.2.0 3.6.0 1.11.2 3.9.0 From 9aa9cdf25ac1448e9a7e6584cf84a123a7694538 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 19 Mar 2020 08:17:59 +0000 Subject: [PATCH 0380/1013] Bump spotbugs from 4.0.0 to 4.0.1 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.0...4.0.1) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3f0a95fd3..b0e07e6fd 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.0 - 4.0.0 + 4.0.1 4.0.0 2.0.0-alpha1 From 0c368b5c7272a022160e92664ba2b50a0d74abad Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 17:01:26 -0400 Subject: [PATCH 0381/1013] [pom] Bump spotbugs to 4.0.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b0e07e6fd..165d3c24b 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ 5.6.0 4.0.1 - 4.0.0 + 4.0.1 2.0.0-alpha1 1.10.7 From fe6ade34761fc9cf95260855bfdf2cfddaccc064 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 17:01:51 -0400 Subject: [PATCH 0382/1013] [pom] Bump junit to 5.6.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 165d3c24b..78fbb16af 100644 --- a/pom.xml +++ b/pom.xml @@ -118,7 +118,7 @@ ${project.version} - 5.6.0 + 5.6.1 4.0.1 4.0.1 2.0.0-alpha1 From 2ffb2b2b69f4a47a16e1c3523a910613b80a9d06 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 20:44:20 -0400 Subject: [PATCH 0383/1013] [pom] Bump dependency check to 5.3.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 78fbb16af..d14c95b83 100644 --- a/pom.xml +++ b/pom.xml @@ -187,7 +187,7 @@ 1.6 - 5.3.1 + 5.3.2 From d9a1fca8a1325a865ec8c6144bc7b91969907b31 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 30 Mar 2020 09:41:17 +0000 Subject: [PATCH 0384/1013] Bump commons-lang3 from 3.9 to 3.10 Bumps commons-lang3 from 3.9 to 3.10. Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d14c95b83..a0493657e 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 3.2.2 2.1 2.6 - 3.9 + 3.10 1.6 From 8cb3f5ebe1de26f7f65d11256da3556e8098a4d8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 17:02:41 -0400 Subject: [PATCH 0385/1013] [ci] Formatting issues --- src/it/check-pluginList-repo/pom.xml | 26 +++++++++++------ src/it/excludeBugsFile/excludeBugs1.xml | 12 ++++---- src/it/settings.xml | 2 +- src/site/resources/examples/spotbugsXml.xml | 32 ++++++++++----------- 4 files changed, 41 insertions(+), 31 deletions(-) diff --git a/src/it/check-pluginList-repo/pom.xml b/src/it/check-pluginList-repo/pom.xml index e4e1226a3..32e4cfec8 100644 --- a/src/it/check-pluginList-repo/pom.xml +++ b/src/it/check-pluginList-repo/pom.xml @@ -1,12 +1,22 @@ - + diff --git a/src/it/excludeBugsFile/excludeBugs1.xml b/src/it/excludeBugsFile/excludeBugs1.xml index a611247db..b0d90bc69 100644 --- a/src/it/excludeBugsFile/excludeBugs1.xml +++ b/src/it/excludeBugsFile/excludeBugs1.xml @@ -62,16 +62,16 @@ disagree as to whether this value is allowed to be null. Either the check is red or the previous dereference is erroneous.</p> Method call passes null to a nonnull parameter
- + <p> This method passes a null value as the parameter of a method which must be nonnull. Either this parameter has been explicitly marked as @Nonnull, or analysis has determined that this parameter is always dereferenced. </p> - +
No relationship between generic parameter and method argument
- + <p> This call to a generic collection method contains an argument with an incompatible class from that of the collection's parameter (i.e., the type of the argument is neither a supertype nor a subtype @@ -95,9 +95,9 @@ or the previous dereference is erroneous.</p> a <code>Foo</code>, the equals method of argument (e.g., the equals method of the <code>Foo</code> class) used to perform the equality checks. </p> - +
Doomed attempt to append to an object output stream
- + <p> This code opens a file in append mode and then wraps the result in an object output stream. This won't allow you to append to an existing object output stream stored in a file. If you want to be @@ -111,7 +111,7 @@ or the previous dereference is erroneous.</p> <p> TODO: example. </p> - +
Bad comparison of signed byte
<p> Signed bytes can only have a value in the range -128 to 127. Comparing diff --git a/src/it/settings.xml b/src/it/settings.xml index 58988002d..0ca9717d6 100644 --- a/src/it/settings.xml +++ b/src/it/settings.xml @@ -47,7 +47,7 @@ under the License. true - + diff --git a/src/site/resources/examples/spotbugsXml.xml b/src/site/resources/examples/spotbugsXml.xml index 349a321e7..9ed269d34 100644 --- a/src/site/resources/examples/spotbugsXml.xml +++ b/src/site/resources/examples/spotbugsXml.xml @@ -33,7 +33,7 @@ that a cast will always throw an exception at runtime.
Return value of method without side effect is ignored
<p>This code calls a method and ignores the return value. However our analysis shows that -the method (including its implementations in subclasses if any) does not produce any effect +the method (including its implementations in subclasses if any) does not produce any effect other than return value. Thus this call can be removed. </p> <p>We are trying to reduce the false positives as much as possible, but in some cases this warning might be wrong. @@ -91,7 +91,7 @@ to use that non-null value. Calling readLine again will give you a different lin <p> This field is never used.&nbsp; Consider removing it from the class.</p>
No relationship between generic parameter and method argument
- + <p> This call to a generic collection method contains an argument with an incompatible class from that of the collection's parameter (i.e., the type of the argument is neither a supertype nor a subtype @@ -115,9 +115,9 @@ to use that non-null value. Calling readLine again will give you a different lin a <code>Foo</code>, the equals method of argument (e.g., the equals method of the <code>Foo</code> class) used to perform the equality checks. </p> - +
Doomed attempt to append to an object output stream
- + <p> This code opens a file in append mode and then wraps the result in an object output stream. This won't allow you to append to an existing object output stream stored in a file. If you want to be @@ -131,15 +131,15 @@ to use that non-null value. Calling readLine again will give you a different lin <p> TODO: example. </p> - +
Clone method may return null
- + <p> This clone method seems to return null in some circumstances, but clone is never allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError instead. </p> - +
Bad comparison of signed byte
<p> Signed bytes can only have a value in the range -128 to 127. Comparing @@ -166,23 +166,23 @@ block for an <code>if</code> statement:</p> </pre>
equals() method does not check for null argument
- + <p> This implementation of equals(Object) violates the contract defined by java.lang.Object.equals() because it does not check for null being passed as the argument. All equals() methods should return false if passed a null value. </p> - +
Method call passes null for non-null parameter
- + <p> This method call passes a null value for a non-null method parameter. Either the parameter is annotated as a parameter that should always be non-null, or analysis has shown that it will always be dereferenced. </p> - +
Possible null pointer dereference
<p> There is a branch of statement that, <em>if executed,</em> guarantees that @@ -287,21 +287,21 @@ String that gives the contents of the array. See Programming Puzzlers, chapter 3 </p>
Method call passes null to a non-null parameter
- + <p> This method passes a null value as the parameter of a method which must be non-null. Either this parameter has been explicitly marked as @Nonnull, or analysis has determined that this parameter is always dereferenced. </p> - +
Possible null pointer dereference due to return value of called method
- + <p> The return value from a method is dereferenced without a null check, and the return value of that method is one that should generally be checked for null. This may lead to a <code>NullPointerException</code> when the code is executed. </p> - +
Reliance on default encoding
<p> Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. </p> @@ -415,4 +415,4 @@ Such assignments are useless, and may indicate a logic error or typo. </p>
Suspicious calls to generic collection methodsUninitialized read of field in constructorEqual objects must have equal hashcodesRegular expressionsComparing incompatible types for equalityInput/Output problemDead local storeNull pointer dereferenceDubious method invocationUnused fieldProblems with implementation of equals()Dubious method usedUseless codeInner class could be made staticRedundant comparison to nullBad use of return value from methodUseless control flowSuspicious integer expressionUnread fieldBad casts of object referencesUseless/non-informative string generatedSuspicious Thread InterruptedBad implementation of cloneable idiomIncorrect use of finalizersUseless self-operation - \ No newline at end of file + From 8e97b6859ba5574ba7d6bb5eb8533a9193901bb6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 20:06:48 -0400 Subject: [PATCH 0386/1013] [ci] Tabs to spaces / formatting --- .../codehaus/mojo/spotbugs/SpotBugsGui.groovy | 15 +- .../mojo/spotbugs/SpotBugsInfo.groovy | 110 +- .../mojo/spotbugs/SpotBugsPluginsTrait.groovy | 7 +- .../spotbugs/SpotbugsReportGenerator.groovy | 1375 ++++++++--------- .../mojo/spotbugs/XDocsReporter.groovy | 411 ++--- 5 files changed, 957 insertions(+), 961 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy index 4d7d43bdd..32962e19d 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy @@ -179,14 +179,13 @@ class SpotBugsGui extends AbstractMojo implements SpotBugsPluginsTrait { @Parameter( property="spotbugs.maxHeap", defaultValue = "512" ) int maxHeap - /** - * Resource Manager. - * - * @since 2.0 - */ - @Component(role = ResourceManager.class) - ResourceManager resourceManager - + /** + * Resource Manager. + * + * @since 2.0 + */ + @Component(role = ResourceManager.class) + ResourceManager resourceManager void execute() { diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index 65f38a985..d66a7fdc8 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -27,77 +27,77 @@ package org.codehaus.mojo.spotbugs */ interface SpotBugsInfo { - /** - * The name of the Plug-In. - * - */ - static final String PLUGIN_NAME = "spotbugs" + /** + * The name of the Plug-In. + * + */ + static final String PLUGIN_NAME = "spotbugs" - /** - * The name of the property resource bundle (Filesystem). - * - */ - static final String BUNDLE_NAME = "spotbugs" + /** + * The name of the property resource bundle (Filesystem). + * + */ + static final String BUNDLE_NAME = "spotbugs" - /** - * The key to get the name of the Plug-In from the bundle. - * - */ - static final String NAME_KEY = "report.spotbugs.name" + /** + * The key to get the name of the Plug-In from the bundle. + * + */ + static final String NAME_KEY = "report.spotbugs.name" - /** - * The key to get the description of the Plug-In from the bundle. - * - */ - static final String DESCRIPTION_KEY = "report.spotbugs.description" + /** + * The key to get the description of the Plug-In from the bundle. + * + */ + static final String DESCRIPTION_KEY = "report.spotbugs.description" - /** - * The key to get the source directory message of the Plug-In from the bundle. - * - */ - static final String SOURCE_ROOT_KEY = "report.spotbugs.sourceRoot" + /** + * The key to get the source directory message of the Plug-In from the bundle. + * + */ + static final String SOURCE_ROOT_KEY = "report.spotbugs.sourceRoot" - /** - * The key to get the source directory message of the Plug-In from the bundle. - * - */ - static final String TEST_SOURCE_ROOT_KEY = "report.spotbugs.testSourceRoot" + /** + * The key to get the source directory message of the Plug-In from the bundle. + * + */ + static final String TEST_SOURCE_ROOT_KEY = "report.spotbugs.testSourceRoot" - /** - * The key to get the java source message of the Plug-In from the bundle. - * - */ - static final String JAVA_SOURCES_KEY = "report.spotbugs.javasources" + /** + * The key to get the java source message of the Plug-In from the bundle. + * + */ + static final String JAVA_SOURCES_KEY = "report.spotbugs.javasources" - /** - * The regex pattern to search for java class files. - * - */ - static final String JAVA_REGEX_PATTERN = "**/*.class" + /** + * The regex pattern to search for java class files. + * + */ + static final String JAVA_REGEX_PATTERN = "**/*.class" - static final String COMMA = "," + static final String COMMA = "," - static final String FORWARD_SLASH = '/' + static final String FORWARD_SLASH = '/' - /** - * The character to separate URL tokens. - * - */ - static final String URL_SEPARATOR = "/" + /** + * The character to separate URL tokens. + * + */ + static final String URL_SEPARATOR = "/" - static final String BLANK = " " + static final String BLANK = " " - static final String PERIOD = "." + static final String PERIOD = "." - static final EOL = "\n" + static final EOL = "\n" - public static final String URL = "url" + public static final String URL = "url" - static final String CLASS_SUFFIX = '.class' + static final String CLASS_SUFFIX = '.class' - def spotbugsEfforts = [Max: "max", Min: "min", Default: "default"] + def spotbugsEfforts = [Max: "max", Min: "min", Default: "default"] - def spotbugsThresholds = [High: "high", Exp: "experimental", Low: "low", Medium: "medium", Default: "medium"] + def spotbugsThresholds = [High: "high", Exp: "experimental", Low: "low", Medium: "medium", Default: "medium"] - def spotbugsPriority = ["unknown", "High", "Medium", "Low"] + def spotbugsPriority = ["unknown", "High", "Medium", "Low"] } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy index af6b0559f..0c7c95eb7 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy @@ -35,7 +35,6 @@ import org.codehaus.plexus.resource.ResourceManager /** * SpotBugs plugin support for Mojos. */ - trait SpotBugsPluginsTrait { // the trait needs certain objects to work, this need is expressed as abstract getters @@ -45,8 +44,8 @@ trait SpotBugsPluginsTrait { abstract List getRemoteRepositories() abstract ArtifactRepository getLocalRepository() abstract File getSpotbugsXmlOutputDirectory() - abstract Log getLog() - abstract ResourceManager getResourceManager() + abstract Log getLog() + abstract ResourceManager getResourceManager() // properties in traits should be supported but don't compile currently: // https://issues.apache.org/jira/browse/GROOVY-7536 @@ -113,7 +112,6 @@ trait SpotBugsPluginsTrait { } } - log.debug(" Plugin list is: ${urlPlugins}") return urlPlugins @@ -146,5 +144,4 @@ trait SpotBugsPluginsTrait { return "-effort:" + effortParameter } - } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 9c9e18b11..0b8aaf635 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -33,732 +33,731 @@ import org.codehaus.plexus.util.PathTool */ class SpotbugsReportGenerator implements SpotBugsInfo { - /** - * The key to get the value if the line number is not available. - * - */ - static final String NOLINE_KEY = "report.spotbugs.noline" - - /** - * The key to get the column title for the line. - * - */ - static final String COLUMN_LINE_KEY = "report.spotbugs.column.line" - - /** - * The key to get the column title for the bug. - * - */ - static final String COLUMN_BUG_KEY = "report.spotbugs.column.bug" - - /** - * The key to get the column title for the bugs. - * - */ - static final String COLUMN_BUGS_KEY = "report.spotbugs.column.bugs" - - /** - * The key to get the column title for the category. - * - */ - static final String COLUMN_CATEGORY_KEY = "report.spotbugs.column.category" - - /** - * The key to get the column title for the priority. - * - */ - static final String COLUMN_PRIORITY_KEY = "report.spotbugs.column.priority" - - /** - * The key to get the column title for the details. - * - */ - static final String COLUMN_DETAILS_KEY = "report.spotbugs.column.details" - - /** - * The key to get the report title of the Plug-In from the bundle. - * - */ - static final String REPORT_TITLE_KEY = "report.spotbugs.reporttitle" - - /** - * The key to get the report link title of the Plug-In from the bundle. - * - */ - static final String LINKTITLE_KEY = "report.spotbugs.linktitle" - - /** - * The key to get the report link of the Plug-In from the bundle. - * - */ - static final String LINK_KEY = "report.spotbugs.link" - - /** - * The key to get the files title of the Plug-In from the bundle. - * - */ - static final String FILES_KEY = "report.spotbugs.files" - - /** - * The key to get the threshold of the report from the bundle. - * - */ - static final String THRESHOLD_KEY = "report.spotbugs.threshold" - - /** - * The key to get the effort of the report from the bundle. - * - */ - static final String EFFORT_KEY = "report.spotbugs.effort" - - /** - * The key to get the link to SpotBugs description page from the bundle. - * - */ - static final String DETAILSLINK_KEY = "report.spotbugs.detailslink" - - /** - * The key to get the version title for SpotBugs from the bundle. - * - */ - static final String VERSIONTITLE_KEY = "report.spotbugs.versiontitle" - - /** - * The key to get the files title of the Plug-In from the bundle. - * - */ - static final String SUMMARY_KEY = "report.spotbugs.summary" - - /** - * The key to column title for the Class. - * - */ - static final String COLUMN_CLASS_KEY = "report.spotbugs.column.class" - - /** - * The key to column title for the Classes. - * - */ - static final String COLUMN_CLASSES_KEY = "report.spotbugs.column.classes" - - /** - * The key to column title for the errors. - * - */ - static final String COLUMN_ERRORS_KEY = "report.spotbugs.column.errors" - - /** - * The key to column title for the files. - * - */ - static final String COLUMN_FILES_KEY = "report.spotbugs.column.files" - - /** - * The key to column title for the files. - * - */ - static final String COLUMN_MISSINGCLASSES_KEY = "report.spotbugs.column.missingclasses" - - /** - * The sink to write the report to. - * - */ - Sink sink - - /** - * The bundle to get the messages from. - * - */ - ResourceBundle bundle - - /** - * The logger to write logs to. - * - */ - Log log - - /** - * The threshold of bugs severity. - * - */ - String threshold - - /** - * The used effort for searching bugs. - * - */ - String effort - - /** - * The name of the current class which is analysed by SpotBugs. - * - */ - String currentClassName - - /** - * Signals if the report for the current class is opened. - * - */ - boolean mIsCurrentClassReportOpened = false - - /** - * Signals if the jxr report plugin is enabled. - * - */ - boolean isJXRReportEnabled = false - - /** - * The running total of bugs reported. - * - */ - int bugCount - - /** - * The running total of missing classes reported. - * - */ - int missingClassCount - - /** - * The running total of files analyzed. - * - */ - int fileCount - - /** - * The Set of missing classes names reported. - * - */ - Set missingClassSet = new HashSet() - - /** - * The running total of errors reported. - * - */ - int errorCount - - /** - * Location where generated html will be created. - * - */ - File outputDirectory - - /** - * Location of the Xrefs to link to. - * - */ - File xrefLocation - - /** - * Location of the Test Xrefs to link to. - * - */ - File xrefTestLocation - - /** - * The directories containing the sources to be compiled. - * - */ - List compileSourceRoots - - /** - * The directories containing the test-sources to be compiled. - * - */ - List testSourceRoots - - /** - * Run Spotbugs on the tests. - * - */ - boolean includeTests - - /** - * "org.apache.maven.doxia.tools.SiteTool" - * - */ - SiteTool siteTool - - File basedir - - GPathResult spotbugsResults - - List bugClasses - - /** - * Default constructor. - * - * @param sink - * The sink to generate the report. - * @param bundle - * The resource bundle to get the messages from. - * @param basedir - * The project base directory. - * @param siteTool - * Doxia SiteTool Handle. - */ - SpotbugsReportGenerator(Sink sink, ResourceBundle bundle, File basedir, SiteTool siteTool) { - - assert sink - assert bundle - assert basedir - assert siteTool - - this.sink = sink - this.bundle = bundle - this.basedir = basedir - this.siteTool = siteTool - - this.bugClasses = [] - - this.currentClassName = "" - - this.bugCount = 0 - this.missingClassCount = 0 - this.errorCount = 0 - this.fileCount = 0 - } - - - /** - * @see edu.umd.cs.findbugs.BugReporter#finish() - */ - void printBody() { - log.debug("Finished searching for bugs!...") - log.debug("sink is " + sink) - - bugClasses.each() {bugClass -> - log.debug("finish bugClass is ${bugClass}") - - printBug(bugClass) - } - - // close the report, write it - sink.body_() - - } - - /** - * Prints the top header sections of the report. - */ - private void doHeading() { - sink.head() - sink.title() - sink.text(getReportTitle()) - sink.title_() - sink.head_() - - sink.body() - - // the title of the report - sink.section1() - sink.sectionTitle1() - sink.text(getReportTitle()) - sink.sectionTitle1_() - - // information about SpotBugs - sink.paragraph() - sink.text(bundle.getString(LINKTITLE_KEY) + SpotBugsInfo.BLANK) - sink.link(bundle.getString(LINK_KEY)) - sink.text(bundle.getString(SpotBugsInfo.NAME_KEY)) - sink.link_() - sink.paragraph_() - - sink.paragraph() - sink.text(bundle.getString(VERSIONTITLE_KEY) + SpotBugsInfo.BLANK) - sink.italic() - sink.text(edu.umd.cs.findbugs.Version.VERSION_STRING) - sink.italic_() - sink.paragraph_() - - sink.paragraph() - sink.text(bundle.getString(THRESHOLD_KEY) + SpotBugsInfo.BLANK) - sink.italic() - sink.text(SpotBugsInfo.spotbugsThresholds.get(threshold)) - sink.italic_() - sink.paragraph_() - - sink.paragraph() - sink.text(bundle.getString(EFFORT_KEY) + SpotBugsInfo.BLANK) - sink.italic() - sink.text(SpotBugsInfo.spotbugsEfforts.get(effort)) - sink.italic_() - sink.paragraph_() - sink.section1_() - - } - - /** - * Print the bug collection to a line in the table - * - * @param bugInstance - * the bug to print - */ - protected void printBug(String bugClass) { - - log.debug("printBug bugClass is ${bugClass}") - - openClassReportSection(bugClass) - - log.debug("printBug spotbugsResults is ${spotbugsResults}") - - spotbugsResults.BugInstance.each() {bugInstance -> - - - log.debug("bugInstance ---> ${bugInstance}") - - if ( bugInstance.Class[0].@classname.text() == bugClass ) { - - def type = bugInstance.@type.text() - def category = bugInstance.@category.text() - def message = bugInstance.LongMessage.text() - def priority = bugInstance.@priority.text() - def line = bugInstance.SourceLine[0] - log.debug("BugInstance message is ${message}") - - sink.tableRow() - - // bug - sink.tableCell() - sink.text(message) - sink.tableCell_() - - // category - sink.tableCell() - sink.text(category) - sink.tableCell_() - - // description link - sink.tableCell() - sink.link(bundle.getString(DETAILSLINK_KEY) + "#" + type) - sink.text(type) - sink.link_() - sink.tableCell_() - - // line - sink.tableCell() - - if ( isJXRReportEnabled ) { - log.debug("isJXRReportEnabled is enabled") - sink.rawText(assembleJxrHyperlink(line)) - } else { - sink.text(line.@start.text()) - } - - sink.tableCell_() - - // priority - sink.tableCell() - sink.text(spotbugsPriority[priority.toInteger()]) - sink.tableCell_() - - sink.tableRow_() - } - } - - sink.table_() - - sink.section2_() - - } - - /** - * Assembles the hyperlink to point to the source code. - * - * @param line - * The line number object with the bug. - * @param lineNumber - * The line number to show in the hyperlink. - * @return The hyperlink which points to the code. - * - */ - protected String assembleJxrHyperlink(GPathResult line) { - String hyperlink - String prefix - - log.debug("Inside assembleJxrHyperlink") - log.debug("line is " + line.text()) - log.debug("outputDirectory is " + outputDirectory.getAbsolutePath()) - log.debug("xrefLocation is " + xrefLocation.getAbsolutePath()) - log.debug("xrefTestLocation is " + xrefTestLocation.getAbsolutePath()) - - compileSourceRoots.each {compileSourceRoot -> - if ( new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { - prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) - - prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD - return - } - } - - if ( includeTests && !prefix ) { - testSourceRoots.each {testSourceRoot -> - if ( new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { - prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) - - prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD - return - } - } - } - - def path = prefix + line.@classname.text().replaceAll("[.]", "/").replaceAll("[\$].*", "") - String lineNumber = valueForLine(line) - - if ( lineNumber != bundle.getString(NOLINE_KEY) ) { - hyperlink = "" + lineNumber + "" - } else { - hyperlink = lineNumber - } - - return hyperlink - } - - /** - * Gets the report title. - * - * @return The report title. - * - */ - protected String getReportTitle() { - return bundle.getString(REPORT_TITLE_KEY) - } - - /** - * Initialized a bug report section in the report for a particular class. - */ - protected void openClassReportSection(String bugClass) { - String columnBugText = bundle.getString(COLUMN_BUG_KEY) - String columnBugCategory = bundle.getString(COLUMN_CATEGORY_KEY) - String columnDescriptionLink = bundle.getString(COLUMN_DETAILS_KEY) - String columnLineText = bundle.getString(COLUMN_LINE_KEY) - String priorityText = bundle.getString(COLUMN_PRIORITY_KEY) - - log.debug("openClassReportSection bugClass is ${bugClass}") - - log.debug("Opening Class Report Section") - - sink.anchor(bugClass) - sink.anchor_() - - sink.section2() - sink.sectionTitle2() - sink.text(bugClass) - sink.sectionTitle2_() - sink.table() - sink.tableRow() - - // bug - sink.tableHeaderCell() - sink.text(columnBugText) - sink.tableHeaderCell_() - - // category - sink.tableHeaderCell() - sink.text(columnBugCategory) - sink.tableHeaderCell_() - - // description link - sink.tableHeaderCell() - sink.text(columnDescriptionLink) - sink.tableHeaderCell_() - - // line - sink.tableHeaderCell() - sink.text(columnLineText) - sink.tableHeaderCell_() - - // priority - sink.tableHeaderCell() - sink.text(priorityText) - sink.tableHeaderCell_() - - sink.tableRow_() - } - - /** - * Print the Summary Section. - */ - protected void printSummary() { - - log.debug("Entering printSummary") - - sink.section1() - - // the summary section - sink.sectionTitle1() - sink.text(bundle.getString(SUMMARY_KEY)) - sink.sectionTitle1_() - - sink.table() - sink.tableRow() - - // classes - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_CLASSES_KEY)) - sink.tableHeaderCell_() - - // bugs - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_BUGS_KEY)) - sink.tableHeaderCell_() - - // Errors - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_ERRORS_KEY)) - sink.tableHeaderCell_() - - // Missing Classes - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_MISSINGCLASSES_KEY)) - sink.tableHeaderCell_() + /** + * The key to get the value if the line number is not available. + * + */ + static final String NOLINE_KEY = "report.spotbugs.noline" + + /** + * The key to get the column title for the line. + * + */ + static final String COLUMN_LINE_KEY = "report.spotbugs.column.line" + + /** + * The key to get the column title for the bug. + * + */ + static final String COLUMN_BUG_KEY = "report.spotbugs.column.bug" + + /** + * The key to get the column title for the bugs. + * + */ + static final String COLUMN_BUGS_KEY = "report.spotbugs.column.bugs" + + /** + * The key to get the column title for the category. + * + */ + static final String COLUMN_CATEGORY_KEY = "report.spotbugs.column.category" + + /** + * The key to get the column title for the priority. + * + */ + static final String COLUMN_PRIORITY_KEY = "report.spotbugs.column.priority" + + /** + * The key to get the column title for the details. + * + */ + static final String COLUMN_DETAILS_KEY = "report.spotbugs.column.details" + + /** + * The key to get the report title of the Plug-In from the bundle. + * + */ + static final String REPORT_TITLE_KEY = "report.spotbugs.reporttitle" + + /** + * The key to get the report link title of the Plug-In from the bundle. + * + */ + static final String LINKTITLE_KEY = "report.spotbugs.linktitle" + + /** + * The key to get the report link of the Plug-In from the bundle. + * + */ + static final String LINK_KEY = "report.spotbugs.link" + + /** + * The key to get the files title of the Plug-In from the bundle. + * + */ + static final String FILES_KEY = "report.spotbugs.files" + + /** + * The key to get the threshold of the report from the bundle. + * + */ + static final String THRESHOLD_KEY = "report.spotbugs.threshold" + + /** + * The key to get the effort of the report from the bundle. + * + */ + static final String EFFORT_KEY = "report.spotbugs.effort" + + /** + * The key to get the link to SpotBugs description page from the bundle. + * + */ + static final String DETAILSLINK_KEY = "report.spotbugs.detailslink" + + /** + * The key to get the version title for SpotBugs from the bundle. + * + */ + static final String VERSIONTITLE_KEY = "report.spotbugs.versiontitle" + + /** + * The key to get the files title of the Plug-In from the bundle. + * + */ + static final String SUMMARY_KEY = "report.spotbugs.summary" + + /** + * The key to column title for the Class. + * + */ + static final String COLUMN_CLASS_KEY = "report.spotbugs.column.class" + + /** + * The key to column title for the Classes. + * + */ + static final String COLUMN_CLASSES_KEY = "report.spotbugs.column.classes" + + /** + * The key to column title for the errors. + * + */ + static final String COLUMN_ERRORS_KEY = "report.spotbugs.column.errors" + + /** + * The key to column title for the files. + * + */ + static final String COLUMN_FILES_KEY = "report.spotbugs.column.files" + + /** + * The key to column title for the files. + * + */ + static final String COLUMN_MISSINGCLASSES_KEY = "report.spotbugs.column.missingclasses" + + /** + * The sink to write the report to. + * + */ + Sink sink + + /** + * The bundle to get the messages from. + * + */ + ResourceBundle bundle + + /** + * The logger to write logs to. + * + */ + Log log + + /** + * The threshold of bugs severity. + * + */ + String threshold + + /** + * The used effort for searching bugs. + * + */ + String effort + + /** + * The name of the current class which is analysed by SpotBugs. + * + */ + String currentClassName + + /** + * Signals if the report for the current class is opened. + * + */ + boolean mIsCurrentClassReportOpened = false + + /** + * Signals if the jxr report plugin is enabled. + * + */ + boolean isJXRReportEnabled = false + + /** + * The running total of bugs reported. + * + */ + int bugCount + + /** + * The running total of missing classes reported. + * + */ + int missingClassCount + + /** + * The running total of files analyzed. + * + */ + int fileCount + + /** + * The Set of missing classes names reported. + * + */ + Set missingClassSet = new HashSet() + + /** + * The running total of errors reported. + * + */ + int errorCount + + /** + * Location where generated html will be created. + * + */ + File outputDirectory + + /** + * Location of the Xrefs to link to. + * + */ + File xrefLocation + + /** + * Location of the Test Xrefs to link to. + * + */ + File xrefTestLocation + + /** + * The directories containing the sources to be compiled. + * + */ + List compileSourceRoots + + /** + * The directories containing the test-sources to be compiled. + * + */ + List testSourceRoots + + /** + * Run Spotbugs on the tests. + * + */ + boolean includeTests + + /** + * "org.apache.maven.doxia.tools.SiteTool" + * + */ + SiteTool siteTool + + File basedir + + GPathResult spotbugsResults + + List bugClasses + + /** + * Default constructor. + * + * @param sink + * The sink to generate the report. + * @param bundle + * The resource bundle to get the messages from. + * @param basedir + * The project base directory. + * @param siteTool + * Doxia SiteTool Handle. + */ + SpotbugsReportGenerator(Sink sink, ResourceBundle bundle, File basedir, SiteTool siteTool) { + + assert sink + assert bundle + assert basedir + assert siteTool + + this.sink = sink + this.bundle = bundle + this.basedir = basedir + this.siteTool = siteTool + + this.bugClasses = [] + + this.currentClassName = "" + + this.bugCount = 0 + this.missingClassCount = 0 + this.errorCount = 0 + this.fileCount = 0 + } + + /** + * @see edu.umd.cs.findbugs.BugReporter#finish() + */ + void printBody() { + log.debug("Finished searching for bugs!...") + log.debug("sink is " + sink) + + bugClasses.each() {bugClass -> + log.debug("finish bugClass is ${bugClass}") + + printBug(bugClass) + } + + // close the report, write it + sink.body_() + + } + + /** + * Prints the top header sections of the report. + */ + private void doHeading() { + sink.head() + sink.title() + sink.text(getReportTitle()) + sink.title_() + sink.head_() + + sink.body() + + // the title of the report + sink.section1() + sink.sectionTitle1() + sink.text(getReportTitle()) + sink.sectionTitle1_() + + // information about SpotBugs + sink.paragraph() + sink.text(bundle.getString(LINKTITLE_KEY) + SpotBugsInfo.BLANK) + sink.link(bundle.getString(LINK_KEY)) + sink.text(bundle.getString(SpotBugsInfo.NAME_KEY)) + sink.link_() + sink.paragraph_() + + sink.paragraph() + sink.text(bundle.getString(VERSIONTITLE_KEY) + SpotBugsInfo.BLANK) + sink.italic() + sink.text(edu.umd.cs.findbugs.Version.VERSION_STRING) + sink.italic_() + sink.paragraph_() + + sink.paragraph() + sink.text(bundle.getString(THRESHOLD_KEY) + SpotBugsInfo.BLANK) + sink.italic() + sink.text(SpotBugsInfo.spotbugsThresholds.get(threshold)) + sink.italic_() + sink.paragraph_() + + sink.paragraph() + sink.text(bundle.getString(EFFORT_KEY) + SpotBugsInfo.BLANK) + sink.italic() + sink.text(SpotBugsInfo.spotbugsEfforts.get(effort)) + sink.italic_() + sink.paragraph_() + sink.section1_() + + } + + /** + * Print the bug collection to a line in the table + * + * @param bugInstance + * the bug to print + */ + protected void printBug(String bugClass) { + + log.debug("printBug bugClass is ${bugClass}") + + openClassReportSection(bugClass) + + log.debug("printBug spotbugsResults is ${spotbugsResults}") + + spotbugsResults.BugInstance.each() {bugInstance -> + + + log.debug("bugInstance ---> ${bugInstance}") + + if ( bugInstance.Class[0].@classname.text() == bugClass ) { + + def type = bugInstance.@type.text() + def category = bugInstance.@category.text() + def message = bugInstance.LongMessage.text() + def priority = bugInstance.@priority.text() + def line = bugInstance.SourceLine[0] + log.debug("BugInstance message is ${message}") + + sink.tableRow() + + // bug + sink.tableCell() + sink.text(message) + sink.tableCell_() + + // category + sink.tableCell() + sink.text(category) + sink.tableCell_() + + // description link + sink.tableCell() + sink.link(bundle.getString(DETAILSLINK_KEY) + "#" + type) + sink.text(type) + sink.link_() + sink.tableCell_() + + // line + sink.tableCell() + + if ( isJXRReportEnabled ) { + log.debug("isJXRReportEnabled is enabled") + sink.rawText(assembleJxrHyperlink(line)) + } else { + sink.text(line.@start.text()) + } + + sink.tableCell_() + + // priority + sink.tableCell() + sink.text(spotbugsPriority[priority.toInteger()]) + sink.tableCell_() + + sink.tableRow_() + } + } + + sink.table_() + + sink.section2_() + + } + + /** + * Assembles the hyperlink to point to the source code. + * + * @param line + * The line number object with the bug. + * @param lineNumber + * The line number to show in the hyperlink. + * @return The hyperlink which points to the code. + * + */ + protected String assembleJxrHyperlink(GPathResult line) { + String hyperlink + String prefix + + log.debug("Inside assembleJxrHyperlink") + log.debug("line is " + line.text()) + log.debug("outputDirectory is " + outputDirectory.getAbsolutePath()) + log.debug("xrefLocation is " + xrefLocation.getAbsolutePath()) + log.debug("xrefTestLocation is " + xrefTestLocation.getAbsolutePath()) + + compileSourceRoots.each {compileSourceRoot -> + if ( new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { + prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) + + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD + return + } + } + + if ( includeTests && !prefix ) { + testSourceRoots.each {testSourceRoot -> + if ( new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { + prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) + + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD + return + } + } + } + + def path = prefix + line.@classname.text().replaceAll("[.]", "/").replaceAll("[\$].*", "") + String lineNumber = valueForLine(line) + + if ( lineNumber != bundle.getString(NOLINE_KEY) ) { + hyperlink = "" + lineNumber + "" + } else { + hyperlink = lineNumber + } + + return hyperlink + } + + /** + * Gets the report title. + * + * @return The report title. + * + */ + protected String getReportTitle() { + return bundle.getString(REPORT_TITLE_KEY) + } + + /** + * Initialized a bug report section in the report for a particular class. + */ + protected void openClassReportSection(String bugClass) { + String columnBugText = bundle.getString(COLUMN_BUG_KEY) + String columnBugCategory = bundle.getString(COLUMN_CATEGORY_KEY) + String columnDescriptionLink = bundle.getString(COLUMN_DETAILS_KEY) + String columnLineText = bundle.getString(COLUMN_LINE_KEY) + String priorityText = bundle.getString(COLUMN_PRIORITY_KEY) + + log.debug("openClassReportSection bugClass is ${bugClass}") + + log.debug("Opening Class Report Section") + + sink.anchor(bugClass) + sink.anchor_() + + sink.section2() + sink.sectionTitle2() + sink.text(bugClass) + sink.sectionTitle2_() + sink.table() + sink.tableRow() + + // bug + sink.tableHeaderCell() + sink.text(columnBugText) + sink.tableHeaderCell_() + + // category + sink.tableHeaderCell() + sink.text(columnBugCategory) + sink.tableHeaderCell_() + + // description link + sink.tableHeaderCell() + sink.text(columnDescriptionLink) + sink.tableHeaderCell_() + + // line + sink.tableHeaderCell() + sink.text(columnLineText) + sink.tableHeaderCell_() + + // priority + sink.tableHeaderCell() + sink.text(priorityText) + sink.tableHeaderCell_() + + sink.tableRow_() + } + + /** + * Print the Summary Section. + */ + protected void printSummary() { + + log.debug("Entering printSummary") + + sink.section1() + + // the summary section + sink.sectionTitle1() + sink.text(bundle.getString(SUMMARY_KEY)) + sink.sectionTitle1_() + + sink.table() + sink.tableRow() + + // classes + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_CLASSES_KEY)) + sink.tableHeaderCell_() + + // bugs + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_BUGS_KEY)) + sink.tableHeaderCell_() + + // Errors + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_ERRORS_KEY)) + sink.tableHeaderCell_() + + // Missing Classes + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_MISSINGCLASSES_KEY)) + sink.tableHeaderCell_() - sink.tableRow_() + sink.tableRow_() - sink.tableRow() + sink.tableRow() - // files - sink.tableCell() - sink.text(spotbugsResults.FindBugsSummary.@total_classes.text()) - sink.tableCell_() + // files + sink.tableCell() + sink.text(spotbugsResults.FindBugsSummary.@total_classes.text()) + sink.tableCell_() - // bug - sink.tableCell() - sink.text(spotbugsResults.FindBugsSummary.@total_bugs.text()) - sink.tableCell_() + // bug + sink.tableCell() + sink.text(spotbugsResults.FindBugsSummary.@total_bugs.text()) + sink.tableCell_() - // Errors - sink.tableCell() - sink.text(spotbugsResults.Errors.@errors.text()) - sink.tableCell_() + // Errors + sink.tableCell() + sink.text(spotbugsResults.Errors.@errors.text()) + sink.tableCell_() - // Missing Classes - sink.tableCell() - sink.text(spotbugsResults.Errors.@missingClasses.text()) - sink.tableCell_() + // Missing Classes + sink.tableCell() + sink.text(spotbugsResults.Errors.@missingClasses.text()) + sink.tableCell_() - sink.tableRow_() - sink.table_() + sink.tableRow_() + sink.table_() - sink.section1_() + sink.section1_() - log.debug("Exiting printSummary") - } + log.debug("Exiting printSummary") + } - /** - * Print the File Summary Section. - */ - protected void printFilesSummary() { - log.debug("Entering printFilesSummary") + /** + * Print the File Summary Section. + */ + protected void printFilesSummary() { + log.debug("Entering printFilesSummary") - sink.section1() + sink.section1() - // the Files section - sink.sectionTitle1() - sink.text(bundle.getString(FILES_KEY)) - sink.sectionTitle1_() + // the Files section + sink.sectionTitle1() + sink.text(bundle.getString(FILES_KEY)) + sink.sectionTitle1_() - /** - * Class Summary - */ + /** + * Class Summary + */ - sink.table() - sink.tableRow() + sink.table() + sink.tableRow() - // files - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_CLASS_KEY)) - sink.tableHeaderCell_() + // files + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_CLASS_KEY)) + sink.tableHeaderCell_() - // bugs - sink.tableHeaderCell() - sink.text(bundle.getString(COLUMN_BUGS_KEY)) - sink.tableHeaderCell_() + // bugs + sink.tableHeaderCell() + sink.text(bundle.getString(COLUMN_BUGS_KEY)) + sink.tableHeaderCell_() - sink.tableRow_() + sink.tableRow_() - spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> + spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> - def classStatsValue = classStats.'@class'.text() - def classStatsBugCount = classStats.'@bugs'.text() + def classStatsValue = classStats.'@class'.text() + def classStatsBugCount = classStats.'@bugs'.text() - if ( Integer.parseInt(classStatsBugCount) > 0 ) { - sink.tableRow() + if ( Integer.parseInt(classStatsBugCount) > 0 ) { + sink.tableRow() - // class name - sink.tableCell() - sink.link("#" + classStatsValue) - sink.text(classStatsValue) - sink.link_() - sink.tableCell_() + // class name + sink.tableCell() + sink.link("#" + classStatsValue) + sink.text(classStatsValue) + sink.link_() + sink.tableCell_() - // class bug total count - sink.tableCell() - sink.text(classStatsBugCount) - sink.tableCell_() + // class bug total count + sink.tableCell() + sink.text(classStatsBugCount) + sink.tableCell_() - sink.tableRow_() + sink.tableRow_() - bugClasses << classStatsValue - } - } + bugClasses << classStatsValue + } + } - sink.table_() + sink.table_() - sink.section1_() + sink.section1_() - log.debug("Exiting printFilesSummary") - } + log.debug("Exiting printFilesSummary") + } - public void generateReport() { + public void generateReport() { - log.debug("Reporter Locale is " + this.bundle.getLocale().getLanguage()) + log.debug("Reporter Locale is " + this.bundle.getLocale().getLanguage()) - doHeading() + doHeading() - printSummary() + printSummary() - printFilesSummary() + printFilesSummary() - printBody() + printBody() - log.debug("Closing up report....................") + log.debug("Closing up report....................") - sink.flush() - sink.close() - } + sink.flush() + sink.close() + } - /** - * Return the value to display. If SpotBugs does not provide a line number, a default message is returned. The line - * number otherwise. - * - * @param line - * The line to get the value from. - * @return The line number the bug appears or a statement that there is no source line available. - * - */ - protected String valueForLine(GPathResult line) - { - String value + /** + * Return the value to display. If SpotBugs does not provide a line number, a default message is returned. The line + * number otherwise. + * + * @param line + * The line to get the value from. + * @return The line number the bug appears or a statement that there is no source line available. + * + */ + protected String valueForLine(GPathResult line) + { + String value - if ( line ) { - def startLine = line.@start.text() - def endLine = line.@end.text() + if ( line ) { + def startLine = line.@start.text() + def endLine = line.@end.text() - if ( startLine == endLine ) { - if ( startLine ) { - value = startLine - } else { - value = bundle.getString(NOLINE_KEY) - } - } else { - value = startLine + "-" + endLine - } - } else { - value = bundle.getString(NOLINE_KEY) - } + if ( startLine == endLine ) { + if ( startLine ) { + value = startLine + } else { + value = bundle.getString(NOLINE_KEY) + } + } else { + value = startLine + "-" + endLine + } + } else { + value = bundle.getString(NOLINE_KEY) + } - return value - } + return value + } } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 21b32d534..18a776465 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -29,209 +29,210 @@ import org.apache.maven.plugin.logging.Log */ class XDocsReporter { - /** - * The key to get the value if the line number is not available. - * - */ - static final String NOLINE_KEY = "report.spotbugs.noline" - - /** - * The bundle to get the messages from. - * - */ - ResourceBundle bundle - - /** - * The logger to write logs to. - * - */ - Log log - - /** - * The threshold of bugs severity. - * - */ - String threshold - - /** - * The used effort for searching bugs. - * - */ - String effort - - /** - * The output Writer stream. - * - */ - Writer outputWriter - - GPathResult spotbugsResults - - List bugClasses - - /** - * The directories containing the sources to be compiled. - * - */ - List compileSourceRoots - - List testSourceRoots - - String outputEncoding - - /** - * Default constructor. - * - * @param bundle - The Resource Bundle to use - */ - XDocsReporter(ResourceBundle bundle, Log log, String threshold, String effort, String outputEncoding) { - assert bundle - assert log - assert threshold - assert effort - assert outputEncoding - - this.bundle = bundle - this.log = log - this.threshold = threshold - this.effort = effort - this.outputEncoding = outputEncoding - - this.outputWriter = null - this.spotbugsResults = null - - this.compileSourceRoots = [] - this.testSourceRoots = [] - this.bugClasses = [] - } - - /** - * Returns the threshold string value for the integer input. - * - * @param thresholdValue - * The ThresholdValue integer to evaluate. - * @return The string valueof the Threshold object. - * - */ - protected String evaluateThresholdParameter(String thresholdValue) { - String thresholdName - - switch ( thresholdValue ) { - case "1": - thresholdName = "High" - break - case "2": - thresholdName = "Normal" - break - case "3": - thresholdName = "Low" - break - case "4": - thresholdName = "Exp" - break - case "5": - thresholdName = "Ignore" - break - default: - thresholdName = "Invalid Priority" - } - - return thresholdName - } - - /** - * Gets the Spotbugs Version of the report. - * - * @return The Spotbugs Version used on the report. - * - */ - protected String getSpotBugsVersion() { - return edu.umd.cs.findbugs.Version.VERSION_STRING - } - - public void generateReport() { - - def xmlBuilder = new StreamingMarkupBuilder() - xmlBuilder.encoding = "UTF-8" - - def xdoc = { - mkp.xmlDeclaration() - log.debug("generateReport spotbugsResults is ${spotbugsResults}") - - BugCollection(version: getSpotBugsVersion(), threshold: SpotBugsInfo.spotbugsThresholds.get(threshold), effort: SpotBugsInfo.spotbugsEfforts.get(effort)) { - - log.debug("spotbugsResults.FindBugsSummary total_bugs is ${spotbugsResults.FindBugsSummary.@total_bugs.text()}") - - spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> - - def classStatsValue = classStats.'@class'.text() - def classStatsBugCount = classStats.'@bugs'.text() - - log.debug("classStats...") - log.debug("classStatsValue is ${classStatsValue}") - log.debug("classStatsBugCount is ${classStatsBugCount}") - - if ( Integer.parseInt(classStatsBugCount) > 0 ) { - bugClasses << classStatsValue - } - } - - bugClasses.each() {bugClass -> - log.debug("finish bugClass is ${bugClass}") - file(classname: bugClass) { - spotbugsResults.BugInstance.each() {bugInstance -> - - if ( bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass ) { - - def type = bugInstance.@type.text() - def category = bugInstance.@category.text() - def message = bugInstance.LongMessage.text() - def priority = evaluateThresholdParameter(bugInstance.@priority.text()) - def line = bugInstance.SourceLine.@start[0].text() - log.debug("BugInstance message is ${message}") - - BugInstance(type: type, priority: priority, category: category, message: message, lineNumber: ((line) ? line: "-1")) - } - } - } - } - - log.debug("Printing Errors") - Error() { - spotbugsResults.Error.analysisError.each() {analysisError -> - AnalysisError(analysisError.message.text()) - } - - log.debug("Printing Missing classes") - - spotbugsResults.Error.MissingClass.each() {missingClass -> - MissingClass(missingClass.text) - } - } - - Project() { - log.debug("Printing Source Roots") - - if ( !compileSourceRoots.isEmpty() ) { - compileSourceRoots.each() {srcDir -> - log.debug("SrcDir is ${srcDir}") - SrcDir(srcDir) - } - } - - if ( !testSourceRoots.isEmpty() ) { - testSourceRoots.each() {srcDir -> - log.debug("SrcDir is ${srcDir}") - SrcDir(srcDir) - } - } - } - } - } - - outputWriter << xmlBuilder.bind(xdoc) - outputWriter.flush() - outputWriter.close() - - } + /** + * The key to get the value if the line number is not available. + * + */ + static final String NOLINE_KEY = "report.spotbugs.noline" + + /** + * The bundle to get the messages from. + * + */ + ResourceBundle bundle + + /** + * The logger to write logs to. + * + */ + Log log + + /** + * The threshold of bugs severity. + * + */ + String threshold + + /** + * The used effort for searching bugs. + * + */ + String effort + + /** + * The output Writer stream. + * + */ + Writer outputWriter + + GPathResult spotbugsResults + + List bugClasses + + /** + * The directories containing the sources to be compiled. + * + */ + List compileSourceRoots + + List testSourceRoots + + String outputEncoding + + /** + * Default constructor. + * + * @param bundle - The Resource Bundle to use + */ + XDocsReporter(ResourceBundle bundle, Log log, String threshold, String effort, String outputEncoding) { + assert bundle + assert log + assert threshold + assert effort + assert outputEncoding + + this.bundle = bundle + this.log = log + this.threshold = threshold + this.effort = effort + this.outputEncoding = outputEncoding + + this.outputWriter = null + this.spotbugsResults = null + + this.compileSourceRoots = [] + this.testSourceRoots = [] + this.bugClasses = [] + } + + /** + * Returns the threshold string value for the integer input. + * + * @param thresholdValue + * The ThresholdValue integer to evaluate. + * @return The string valueof the Threshold object. + * + */ + protected String evaluateThresholdParameter(String thresholdValue) { + String thresholdName + + switch ( thresholdValue ) { + case "1": + thresholdName = "High" + break + case "2": + thresholdName = "Normal" + break + case "3": + thresholdName = "Low" + break + case "4": + thresholdName = "Exp" + break + case "5": + thresholdName = "Ignore" + break + default: + thresholdName = "Invalid Priority" + } + + return thresholdName + } + + /** + * Gets the Spotbugs Version of the report. + * + * @return The Spotbugs Version used on the report. + * + */ + protected String getSpotBugsVersion() { + return edu.umd.cs.findbugs.Version.VERSION_STRING + } + + public void generateReport() { + + def xmlBuilder = new StreamingMarkupBuilder() + xmlBuilder.encoding = "UTF-8" + + def xdoc = { + mkp.xmlDeclaration() + log.debug("generateReport spotbugsResults is ${spotbugsResults}") + + BugCollection(version: getSpotBugsVersion(), threshold: SpotBugsInfo.spotbugsThresholds.get(threshold), effort: SpotBugsInfo.spotbugsEfforts.get(effort)) { + + log.debug("spotbugsResults.FindBugsSummary total_bugs is ${spotbugsResults.FindBugsSummary.@total_bugs.text()}") + + spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> + + def classStatsValue = classStats.'@class'.text() + def classStatsBugCount = classStats.'@bugs'.text() + + log.debug("classStats...") + log.debug("classStatsValue is ${classStatsValue}") + log.debug("classStatsBugCount is ${classStatsBugCount}") + + if ( Integer.parseInt(classStatsBugCount) > 0 ) { + bugClasses << classStatsValue + } + } + + bugClasses.each() {bugClass -> + log.debug("finish bugClass is ${bugClass}") + file(classname: bugClass) { + spotbugsResults.BugInstance.each() {bugInstance -> + + if ( bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass ) { + + def type = bugInstance.@type.text() + def category = bugInstance.@category.text() + def message = bugInstance.LongMessage.text() + def priority = evaluateThresholdParameter(bugInstance.@priority.text()) + def line = bugInstance.SourceLine.@start[0].text() + log.debug("BugInstance message is ${message}") + + BugInstance(type: type, priority: priority, category: category, message: message, lineNumber: ((line) ? line: "-1")) + } + } + } + } + + log.debug("Printing Errors") + + Error() { + spotbugsResults.Error.analysisError.each() {analysisError -> + AnalysisError(analysisError.message.text()) + } + + log.debug("Printing Missing classes") + + spotbugsResults.Error.MissingClass.each() {missingClass -> + MissingClass(missingClass.text) + } + } + + Project() { + log.debug("Printing Source Roots") + + if ( !compileSourceRoots.isEmpty() ) { + compileSourceRoots.each() {srcDir -> + log.debug("SrcDir is ${srcDir}") + SrcDir(srcDir) + } + } + + if (!testSourceRoots.isEmpty()) { + testSourceRoots.each() {srcDir -> + log.debug("SrcDir is ${srcDir}") + SrcDir(srcDir) + } + } + } + } + } + + outputWriter << xmlBuilder.bind(xdoc) + outputWriter.flush() + outputWriter.close() + + } } From 1982ae130bcac9810d4c42b99af72dcba387f070 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 29 Mar 2020 01:47:19 -0400 Subject: [PATCH 0387/1013] [todo] Mark TODO around code noted to fix upon groovy fix which occurred in 2018 --- .../org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy index 0c7c95eb7..449d41631 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy @@ -47,6 +47,7 @@ trait SpotBugsPluginsTrait { abstract Log getLog() abstract ResourceManager getResourceManager() + // TODO This has been fixed for 2 years now, apply as noted... // properties in traits should be supported but don't compile currently: // https://issues.apache.org/jira/browse/GROOVY-7536 // when fixed, should move pluginList and plugins properties here From 471d7620955c79a1e857a3c9fe5e2720e17e4220 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Sun, 5 Apr 2020 01:05:22 +0000 Subject: [PATCH 0388/1013] Bump asm.version from 7.3.1 to 8.0.1 Bumps `asm.version` from 7.3.1 to 8.0.1. Updates `asm` from 7.3.1 to 8.0.1 Updates `asm-analysis` from 7.3.1 to 8.0.1 Updates `asm-commons` from 7.3.1 to 8.0.1 Updates `asm-tree` from 7.3.1 to 8.0.1 Updates `asm-util` from 7.3.1 to 8.0.1 Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a0493657e..4e581b1a0 100644 --- a/pom.xml +++ b/pom.xml @@ -176,7 +176,7 @@ 5.7.0.202003110725-r - 7.3.1 + 8.0.1 1.9.4 1.2 1.14 From 238f2f360c673811c32922f5a00ae7d75337ee80 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 29 Mar 2020 19:40:53 -0400 Subject: [PATCH 0389/1013] [pom] Use jcl-over-slf4j instead of obsolete commons-logging we use slf4j otherwise --- pom.xml | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 4e581b1a0..b8e844c64 100644 --- a/pom.xml +++ b/pom.xml @@ -199,9 +199,14 @@ - org.slf4j - slf4j-simple - ${slf4jVersion} + org.slf4j + jcl-over-slf4j + ${slf4jVersion} + + + org.slf4j + slf4j-simple + ${slf4jVersion} @@ -308,6 +313,12 @@ org.apache.maven.doxia doxia-core ${doxiaVersion} + + + commons-logging + commons-logging + + org.apache.maven.doxia @@ -348,6 +359,10 @@ dom4j dom4j + + commons-logging + commons-logging + @@ -361,6 +376,12 @@ commons-beanutils commons-beanutils ${beanutils.version} + + + commons-logging + commons-logging + + commons-chain @@ -381,6 +402,12 @@ commons-digester commons-digester ${digester.version} + + + commons-logging + commons-logging + + commons-io @@ -396,6 +423,12 @@ commons-validator commons-validator ${validator.version} + + + commons-logging + commons-logging + + From e73df298097599da2e7b6d65b2978ca72761ad87 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 28 Mar 2020 20:43:10 -0400 Subject: [PATCH 0390/1013] [ci] Add missing @override --- .../org/codehaus/mojo/spotbugs/SpotBugsGui.groovy | 1 + .../org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 10 ++++++++++ .../mojo/spotbugs/SpotbugsViolationCheckMojo.groovy | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy index 32962e19d..936909be0 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy @@ -187,6 +187,7 @@ class SpotBugsGui extends AbstractMojo implements SpotBugsPluginsTrait { @Component(role = ResourceManager.class) ResourceManager resourceManager + @Override void execute() { def ant = new AntBuilder() diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index be0258d0b..75b4c0e58 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -534,6 +534,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return true if report can be generated, otherwise false * @see org.apache.maven.reporting.MavenReport#canGenerateReport() */ + @Override boolean canGenerateReport() { def canGenerate = false @@ -591,6 +592,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return description of the report * @see org.apache.maven.reporting.MavenReport#getDescription(java.util.Locale) */ + @Override String getDescription(Locale locale) { return getBundle(locale).getString(SpotBugsInfo.DESCRIPTION_KEY) } @@ -604,6 +606,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return name of the report * @see org.apache.maven.reporting.MavenReport#getName(java.util.Locale) */ + @Override String getName(Locale locale) { return getBundle(locale).getString(SpotBugsInfo.NAME_KEY) } @@ -616,6 +619,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return name of the generated page * @see org.apache.maven.reporting.MavenReport#getOutputName() */ + @Override String getOutputName() { return SpotBugsInfo.PLUGIN_NAME } @@ -629,6 +633,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * * @see org.apache.maven.reporting.MavenReport #executeReport(java.util.Locale) */ + @Override void executeReport(Locale locale) { log.debug("****** SpotBugsMojo executeReport *******") @@ -695,6 +700,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } } + @Override public void execute() { log.debug("****** SpotBugsMojo execute *******") @@ -754,6 +760,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return full path to the directory where the files in the site get copied to * @see org.apache.maven.reporting.AbstractMavenReport#getOutputDirectory() */ + @Override protected String getOutputDirectory() { return outputDirectory.getAbsolutePath() } @@ -764,6 +771,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * @return the project. * @see org.apache.maven.reporting.AbstractMavenReport#getProject() */ + @Override protected MavenProject getProject() { return this.project } @@ -772,6 +780,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * Return the Site Renderer. * */ + @Override protected Renderer getSiteRenderer() { return this.siteRenderer } @@ -1187,6 +1196,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * @see org.apache.maven.reporting.AbstractMavenReport#setReportOutputDirectory(java.io.File) */ + @Override public void setReportOutputDirectory(File reportOutputDirectory) { super.setReportOutputDirectory(reportOutputDirectory) this.outputDirectory = reportOutputDirectory diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index 542ff8b69..c0ab75193 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -480,7 +480,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { @Parameter( property="spotbugs.maxAllowedViolations" , defaultValue = "0") int maxAllowedViolations - + @Override void execute() { Locale locale = Locale.getDefault() List sourceFiles From 48cf438479a04f23fb22526a3653f8e46a6758db Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 29 Mar 2020 19:41:41 -0400 Subject: [PATCH 0391/1013] [pom] Use groovy indy components only, we require java 8 so no need to care about java 6 we use slf4j otherwise --- pom.xml | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 80 insertions(+), 8 deletions(-) diff --git a/pom.xml b/pom.xml index b8e844c64..b8a3f1307 100644 --- a/pom.xml +++ b/pom.xml @@ -229,14 +229,22 @@ ${groovyVersion} indy - - org.apache.ant - ant-junit - - - org.apache.ant - ant-antlr - + + org.apache.ant + ant-junit + + + org.apache.ant + ant-antlr + + + org.codehaus.groovy + groovy + + + org.codehaus.groovy + groovy-groovydoc + @@ -245,18 +253,82 @@ groovy-dateutil ${groovyVersion} indy + + + org.codehaus.groovy + groovy + + + + + + org.codehaus.groovy + groovy-docgenerator + ${groovyVersion} + runtime + indy + + + org.codehaus.groovy + groovy + + + org.codehaus.groovy + groovy-templates + + org.codehaus.groovy groovy-groovydoc ${groovyVersion} + indy + + + org.codehaus.groovy + groovy + + + org.codehaus.groovy + groovy-docgenerator + + + org.codehaus.groovy + groovy-templates + + + + + + org.codehaus.groovy + groovy-templates + ${groovyVersion} + runtime + indy + + + org.codehaus.groovy + groovy + + + org.codehaus.groovy + groovy-xml + + org.codehaus.groovy groovy-xml ${groovyVersion} + indy + + + org.codehaus.groovy + groovy + + From df735f30b2249d32d6e55f476eb32ffe3d42fe90 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 17:13:30 -0400 Subject: [PATCH 0392/1013] [pom] Bump gmaven plugin to 1.9.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b8a3f1307..d401ccbf1 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 1.8 1.8 0.22-1 - 1.8.1 + 1.9.0 3.0.0 3.2.1 3.2.0 From 08b09ae75da7cab60e718e0ec2ff7bdfee52f467 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 17:13:56 -0400 Subject: [PATCH 0393/1013] [pom] Use invoke dynamic on our code (indy only) - we require jdk8 --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index d401ccbf1..ebc4aa91b 100644 --- a/pom.xml +++ b/pom.xml @@ -634,6 +634,7 @@ ${gmavenPluginVersion} ${project.reporting.outputDirectory}/gapidocs + true From 72a72ef50fe611bccf6c80e17fcf076aa3ed06fd Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 17:33:16 -0400 Subject: [PATCH 0394/1013] [travis] Drop openjdk 13 as now obsolete by official 14 --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2957e0021..c9e708252 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,6 @@ language: java jdk: - openjdk15 - openjdk14 - - openjdk13 - openjdk11 - openjdk8 From 213492845243d067946aba7626df1e86179f8a33 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 17:33:32 -0400 Subject: [PATCH 0395/1013] [travis] Move onto bionic beaver builds --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index c9e708252..fbeac5982 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,5 +1,5 @@ # See https://docs.travis-ci.com/user/reference/overview/ -dist: xenial +dist: bionic language: java From a5613b620600757804d4f8d780026443c104283a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 18:00:52 -0400 Subject: [PATCH 0396/1013] [pom] Remove commons-validator as no longer used and thus no need to override now --- pom.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/pom.xml b/pom.xml index ebc4aa91b..f943c8b28 100644 --- a/pom.xml +++ b/pom.xml @@ -184,7 +184,6 @@ 2.1 2.6 3.10 - 1.6 5.3.2 @@ -491,17 +490,6 @@ commons-lang3 ${lang3.version} - - commons-validator - commons-validator - ${validator.version} - - - commons-logging - commons-logging - - - From 28987a79508f529828cdd9872d196e25113349b9 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 17:51:31 -0400 Subject: [PATCH 0397/1013] [pom] Remove really old duplicate of sisu-guice --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index f943c8b28..485ef42ed 100644 --- a/pom.xml +++ b/pom.xml @@ -371,6 +371,12 @@ org.apache.maven.shared maven-artifact-transfer ${mavenTransferVersion} + + + org.sonatype.sisu + sisu-guice + + From 6ee9325bb445170f6d4b177b82939bb67b3bf45d Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Fri, 10 Apr 2020 08:48:01 +0000 Subject: [PATCH 0398/1013] Bump groovyVersion from 3.0.2 to 3.0.3 Bumps `groovyVersion` from 3.0.2 to 3.0.3. Updates `groovy` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.2 to 3.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 485ef42ed..29b04b57d 100644 --- a/pom.xml +++ b/pom.xml @@ -124,7 +124,7 @@ 2.0.0-alpha1 1.10.7 - 3.0.2 + 3.0.3 1.9.1 1.9.2 From 2a975226ec6f27a0f0f8cabe830634e4d6ae87de Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 13 Apr 2020 09:07:53 +0000 Subject: [PATCH 0399/1013] Bump base-parent from 24 to 25 Bumps [base-parent](https://github.com/hazendaz/base-parent) from 24 to 25. - [Release notes](https://github.com/hazendaz/base-parent/releases) - [Commits](https://github.com/hazendaz/base-parent/commits) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 29b04b57d..292a77e84 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 24 + 25 From c7128ea74ad39f94885f8fd23826400cc79e688d Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 16 Apr 2020 08:26:35 +0000 Subject: [PATCH 0400/1013] Bump maven-antrun-plugin from 1.8 to 3.0.0 Bumps [maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin) from 1.8 to 3.0.0. - [Release notes](https://github.com/apache/maven-antrun-plugin/releases) - [Commits](https://github.com/apache/maven-antrun-plugin/compare/maven-antrun-plugin-1.8...maven-antrun-plugin-3.0.0) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 292a77e84..391248282 100644 --- a/pom.xml +++ b/pom.xml @@ -139,7 +139,7 @@ 1.1.0 3.3.0 - 1.8 + 3.0.0 1.8 0.22-1 1.9.0 From d85f4bf8f1927221dc82241723b1c7ff3bcb38f8 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 16 Apr 2020 13:08:10 +0000 Subject: [PATCH 0401/1013] Bump spotbugs from 4.0.1 to 4.0.2 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.1 to 4.0.2. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.1...4.0.2) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 391248282..b7975926c 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.1 - 4.0.1 + 4.0.2 4.0.1 2.0.0-alpha1 From 550fae5629a84799cc78ca627fa93ce9234cfcdb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 20:52:10 -0400 Subject: [PATCH 0402/1013] [ci] Formatting - spaces --- .../mojo/spotbugs/SpotBugsMojo.groovy | 6 +- .../SpotbugsViolationCheckMojo.groovy | 88 +++++++++---------- 2 files changed, 47 insertions(+), 47 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 75b4c0e58..9b8f13f33 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -169,7 +169,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { boolean addSourceDirs /** - * List of artifacts this plugin depends on. Used for resolving the Spotbugs coreplugin. + * List of artifacts this plugin depends on. Used for resolving the Spotbugs core plugin. * */ @Parameter(property = "plugin.artifacts", required = true, readonly = true) @@ -330,7 +330,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String effort /** - * turn on Spotbugs debugging + * Turn on Spotbugs debugging. * */ @Parameter(defaultValue = "false", property = "spotbugs.debug") @@ -461,7 +461,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { boolean failOnError /** - * Fork a VM for Spotbugs analysis. This will allow you to set timeouts and heap size + * Fork a VM for Spotbugs analysis. This will allow you to set timeouts and heap size. * * @since 2.3.2 */ diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index c0ab75193..a04af08a3 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -61,7 +61,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * Location where generated html will be created. * */ - @Parameter( defaultValue = '${project.reporting.outputDirectory}', required = true ) + @Parameter(defaultValue = '${project.reporting.outputDirectory}', required = true) File outputDirectory /** @@ -69,7 +69,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0.0 */ - @Parameter( defaultValue = "false", property="spotbugs.xmlOutput", required = true ) + @Parameter(defaultValue = "false", property = "spotbugs.xmlOutput", required = true) boolean xmlOutput /** @@ -77,7 +77,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0.0 */ - @Parameter( defaultValue = '${project.build.directory}', required = true ) + @Parameter(defaultValue = '${project.build.directory}', required = true) File xmlOutputDirectory /** @@ -87,7 +87,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * */ @Deprecated - @Parameter( defaultValue = "true" ) + @Parameter(defaultValue = "true") boolean spotbugsXmlOutput /** @@ -95,7 +95,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.2.0 */ - @Parameter( defaultValue = '${project.build.directory}', required = true ) + @Parameter(defaultValue = '${project.build.directory}', required = true) File spotbugsXmlOutputDirectory /** @@ -109,41 +109,41 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { /** * Doxia Site Renderer. */ - @Component( role = Renderer.class) + @Component(role = Renderer.class) Renderer siteRenderer /** * Directory containing the class files for Spotbugs to analyze. */ - @Parameter( defaultValue = '${project.build.outputDirectory}', required = true ) + @Parameter(defaultValue = '${project.build.outputDirectory}', required = true) File classFilesDirectory /** * Directory containing the test class files for Spotbugs to analyze. * */ - @Parameter( defaultValue = '${project.build.testOutputDirectory}', required = true ) + @Parameter(defaultValue = '${project.build.testOutputDirectory}', required = true) File testClassFilesDirectory /** * Location of the Xrefs to link to. * */ - @Parameter( defaultValue = '${project.reporting.outputDirectory}/xref' ) + @Parameter(defaultValue = '${project.reporting.outputDirectory}/xref') File xrefLocation /** * Location of the Test Xrefs to link to. * */ - @Parameter( defaultValue = '${project.reporting.outputDirectory}/xref-test' ) + @Parameter(defaultValue = '${project.reporting.outputDirectory}/xref-test') File xrefTestLocation /** * The directories containing the sources to be compiled. * */ - @Parameter( defaultValue = '${project.compileSourceRoots}', required = true, readonly = true ) + @Parameter(defaultValue = '${project.compileSourceRoots}', required = true, readonly = true) List compileSourceRoots /** @@ -151,7 +151,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.0 */ - @Parameter( defaultValue = '${project.testCompileSourceRoots}', required = true, readonly = true ) + @Parameter(defaultValue = '${project.testCompileSourceRoots}', required = true, readonly = true) List testSourceRoots /** @@ -159,28 +159,28 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.0 */ - @Parameter( defaultValue = "false", property="spotbugs.includeTests" ) + @Parameter(defaultValue = "false", property = "spotbugs.includeTests") boolean includeTests /** * List of artifacts this plugin depends on. Used for resolving the Spotbugs core plugin. * */ - @Parameter( property="plugin.artifacts", required = true, readonly = true ) + @Parameter(property = "plugin.artifacts", required = true, readonly = true) List pluginArtifacts /** * The local repository, needed to download the coreplugin jar. * */ - @Parameter( property="localRepository", required = true, readonly = true ) + @Parameter(property = "localRepository", required = true, readonly = true) ArtifactRepository localRepository /** * Remote repositories which will be searched for the coreplugin jar. * */ - @Parameter( property="project.remoteArtifactRepositories", required = true, readonly = true ) + @Parameter(property = "project.remoteArtifactRepositories", required = true, readonly = true) List remoteArtifactRepositories /** @@ -193,14 +193,14 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * Maven Project. * */ - @Parameter( property="project", required = true, readonly = true ) + @Parameter(property = "project", required = true, readonly = true) MavenProject project /** * Encoding used for xml files. Default value is UTF-8. * */ - @Parameter( defaultValue = "UTF-8", readonly = true ) + @Parameter(defaultValue = "UTF-8", readonly = true) String xmlEncoding /** @@ -209,7 +209,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.2 */ - @Parameter( defaultValue = '${project.build.sourceEncoding}', property="encoding" ) + @Parameter(defaultValue = '${project.build.sourceEncoding}', property = "encoding") String sourceEncoding /** @@ -218,20 +218,20 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.2 */ - @Parameter( defaultValue = '${project.reporting.outputEncoding}', property="outputEncoding" ) + @Parameter(defaultValue = '${project.reporting.outputEncoding}', property = "outputEncoding") String outputEncoding /** * Threshold of minimum bug severity to report. Valid values are High, Default, Low, Ignore, and Exp (for experimental). * */ - @Parameter( defaultValue = "Default", property="spotbugs.threshold" ) + @Parameter(defaultValue = "Default", property = "spotbugs.threshold") String threshold /** * Artifact resolver, needed to download the coreplugin jar. */ - @Component( role = ArtifactResolver.class ) + @Component(role = ArtifactResolver.class) ArtifactResolver artifactResolver /** @@ -253,7 +253,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="spotbugs.includeFilterFile" ) + @Parameter(property = "spotbugs.includeFilterFile") String includeFilterFile /** @@ -275,7 +275,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="spotbugs.excludeFilterFile" ) + @Parameter(property = "spotbugs.excludeFilterFile") String excludeFilterFile /** @@ -298,7 +298,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="spotbugs.excludeBugsFile" ) + @Parameter(property = "spotbugs.excludeBugsFile") String excludeBugsFile /** @@ -306,14 +306,14 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( defaultValue = "Default", property="spotbugs.effort" ) + @Parameter(defaultValue = "Default", property = "spotbugs.effort") String effort /** * Turn on Spotbugs debugging. * */ - @Parameter( defaultValue = "false", property="spotbugs.debug" ) + @Parameter(defaultValue = "false", property = "spotbugs.debug") Boolean debug /** @@ -322,7 +322,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( defaultValue = "false", property="spotbugs.relaxed" ) + @Parameter(defaultValue = "false", property = "spotbugs.relaxed") Boolean relaxed /** @@ -330,7 +330,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="spotbugs.visitors" ) + @Parameter(property = "spotbugs.visitors") String visitors /** @@ -338,7 +338,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.0-beta-1 */ - @Parameter( property="spotbugs.omitVisitors" ) + @Parameter(property = "spotbugs.omitVisitors") String omitVisitors /** @@ -367,7 +367,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( property="spotbugs.onlyAnalyze" ) + @Parameter(property = "spotbugs.onlyAnalyze") String onlyAnalyze /** @@ -376,7 +376,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.3.2 */ - @Parameter( property="spotbugs.nested", defaultValue = "false" ) + @Parameter(property = "spotbugs.nested", defaultValue = "false") Boolean nested /** @@ -385,7 +385,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.3.2 */ - @Parameter( property="spotbugs.trace", defaultValue = "false" ) + @Parameter(property = "spotbugs.trace", defaultValue = "false") Boolean trace /** @@ -393,7 +393,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="spotbugs.maxRank" ) + @Parameter(property = "spotbugs.maxRank") int maxRank /** @@ -401,7 +401,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 1.1 */ - @Parameter( property="spotbugs.skip", defaultValue = "false" ) + @Parameter(property = "spotbugs.skip", defaultValue = "false") boolean skip /** @@ -409,7 +409,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.0 */ - @Component( role = ResourceManager.class) + @Component(role = ResourceManager.class) ResourceManager resourceManager /** @@ -417,7 +417,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.1-SNAPSHOT */ - @Component( role = SiteTool.class) + @Component(role = SiteTool.class) SiteTool siteTool /** @@ -425,7 +425,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.0 */ - @Parameter( property="spotbugs.failOnError", defaultValue = "true" ) + @Parameter(property = "spotbugs.failOnError", defaultValue = "true") boolean failOnError /** @@ -433,7 +433,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.3.2 */ - @Parameter( property="spotbugs.fork", defaultValue = "true" ) + @Parameter(property = "spotbugs.fork", defaultValue = "true") boolean fork /** @@ -442,7 +442,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.2 */ - @Parameter( property="spotbugs.maxHeap", defaultValue = "512" ) + @Parameter(property = "spotbugs.maxHeap", defaultValue = "512") int maxHeap /** @@ -453,7 +453,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.2 */ - @Parameter( property="spotbugs.timeout", defaultValue = "600000" ) + @Parameter(property = "spotbugs.timeout", defaultValue = "600000") int timeout /** @@ -463,7 +463,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="spotbugs.jvmArgs" ) + @Parameter(property = "spotbugs.jvmArgs") String jvmArgs int bugCount @@ -477,7 +477,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { * * @since 2.4.1 */ - @Parameter( property="spotbugs.maxAllowedViolations" , defaultValue = "0") + @Parameter(property = "spotbugs.maxAllowedViolations", defaultValue = "0") int maxAllowedViolations @Override @@ -498,7 +498,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { log.debug("Here goes...............Executing spotbugs:check") if (!spotbugsXmlOutputDirectory.exists()) { - if ( !spotbugsXmlOutputDirectory.mkdirs() ) { + if (!spotbugsXmlOutputDirectory.mkdirs()) { throw new MojoExecutionException("Cannot create xml output directory") } } From 92d19ccf8f591e9de280f81f184a4f428e9083ef Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 5 Apr 2020 20:56:05 -0400 Subject: [PATCH 0403/1013] [cleanup] Extract embedded class to it's own file. --- .../org/codehaus/mojo/spotbugs/PluginArtifact.groovy | 7 +++++++ .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 7 ------- 2 files changed, 7 insertions(+), 7 deletions(-) create mode 100644 src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy new file mode 100644 index 000000000..e355f8271 --- /dev/null +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy @@ -0,0 +1,7 @@ +package org.codehaus.mojo.spotbugs + +class PluginArtifact { + String groupId, artifactId, version + + String type = "jar" +} diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 9b8f13f33..8768cb8d3 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1225,10 +1225,3 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } } - -class PluginArtifact { - String groupId, artifactId, version - - String type = "jar" -} - From 96d23130f014cacea43822c90a124c2c1da1dae7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Apr 2020 17:10:35 -0400 Subject: [PATCH 0404/1013] [pom] Allign completely to spotbugs 4.0.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index b7975926c..3309892a2 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.1-SNAPSHOT + 4.0.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -120,7 +120,7 @@ 5.6.1 4.0.2 - 4.0.1 + 4.0.2 2.0.0-alpha1 1.10.7 From 517399623208080820563c2ea28494031d70e4fb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Apr 2020 17:10:45 -0400 Subject: [PATCH 0405/1013] [pom] Bump junit to 5.6.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3309892a2..085171d43 100644 --- a/pom.xml +++ b/pom.xml @@ -118,7 +118,7 @@ ${project.version} - 5.6.1 + 5.6.2 4.0.2 4.0.2 2.0.0-alpha1 From 2a33762125b5f1013dc2cdbe94c8b476ea29913c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Apr 2020 17:15:35 -0400 Subject: [PATCH 0406/1013] [cleanup] Remove maven 2.2.1 related issue This project requires maven 3.2.5. The error in question and related fix is from 2005. --- .../org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 8768cb8d3..6b740b809 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -563,15 +563,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { if (canGenerate && outputSpotbugsFile == null) { outputSpotbugsFile = new File("${spotbugsXmlOutputDirectory}/${spotbugsXmlOutputFilename}") - ClassLoader tccl = Thread.currentThread().getContextClassLoader(); - try { - // The SAX parser factory will fail with CCE if the TCCL is out of sync with our class loader - // This for Maven 2.2.1 only MFINDBUGS-178 - Thread.currentThread().setContextClassLoader(getClass().getClassLoader()); - executeSpotbugs(outputSpotbugsFile) - } finally { - Thread.currentThread().setContextClassLoader(tccl); - } + executeSpotbugs(outputSpotbugsFile) if (skipEmptyReport && bugCount == 0) { canGenerate = false From 3f3b6bfc57bd7a3419bc4b49059b5bb675bcfcf6 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Wed, 13 May 2020 09:05:34 +0000 Subject: [PATCH 0407/1013] Bump spotbugs from 4.0.2 to 4.0.3 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.2...4.0.3) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 085171d43..a124d87b6 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.0.2 + 4.0.3 4.0.2 2.0.0-alpha1 From 2149b19f372777aae069d9b0020304762b848fc1 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 14 May 2020 08:45:23 +0000 Subject: [PATCH 0408/1013] Bump ant from 1.10.7 to 1.10.8 Bumps ant from 1.10.7 to 1.10.8. Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a124d87b6..e8b24a6af 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 4.0.2 2.0.0-alpha1 - 1.10.7 + 1.10.8 3.0.3 1.9.1 From bdbb6face71de747e7b280ddd79bf74b493a3936 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Fri, 22 May 2020 08:53:15 +0000 Subject: [PATCH 0409/1013] Bump groovyVersion from 3.0.3 to 3.0.4 Bumps `groovyVersion` from 3.0.3 to 3.0.4. Updates `groovy` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.3 to 3.0.4 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e8b24a6af..be492a227 100644 --- a/pom.xml +++ b/pom.xml @@ -124,7 +124,7 @@ 2.0.0-alpha1 1.10.8 - 3.0.3 + 3.0.4 1.9.1 1.9.2 From ef22be2128cea802848c4feaf4ce5b22cfa4fff9 Mon Sep 17 00:00:00 2001 From: Falko Modler Date: Sat, 16 May 2020 19:35:13 +0200 Subject: [PATCH 0410/1013] CheckMojo: parse outputFile only once --- .../SpotbugsViolationCheckMojo.groovy | 29 +++++++------------ 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index a04af08a3..f73942c17 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -466,10 +466,6 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { @Parameter(property = "spotbugs.jvmArgs") String jvmArgs - int bugCount - - int errorCount - /** *

* specified max number of violations which can be ignored by the spotbugs. @@ -507,31 +503,26 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { if (outputFile.exists()) { - def path = new XmlSlurper().parse(outputFile) - - def allNodes = path.depthFirst().collect { it } + def xml = new XmlParser().parse(outputFile) - bugCount = allNodes.findAll {it.name() == 'BugInstance'}.size() + def bugs = xml.BugInstance + def bugCount = bugs.size() log.info("BugInstance size is ${bugCount}") - errorCount = allNodes.findAll {it.name() == 'Error'}.size() + def errorCount = xml.Error.size() log.info("Error size is ${errorCount}") - def xml = new XmlParser().parse(outputFile) - def bugs = xml.BugInstance - def total = bugs.size() - - if (total <= 0) { + if (bugCount <= 0) { log.info('No errors/warnings found') return - }else if( maxAllowedViolations > 0 && total <= maxAllowedViolations){ - log.info("total ${total} violations are found which is set to be acceptable using configured property maxAllowedViolations :"+maxAllowedViolations +".\nBelow are list of bugs ignored :\n") - printBugs(total, bugs) + } else if (maxAllowedViolations > 0 && bugCount <= maxAllowedViolations) { + log.info("total ${bugCount} violations are found which is set to be acceptable using configured property maxAllowedViolations :"+maxAllowedViolations +".\nBelow are list of bugs ignored :\n") + printBugs(bugCount, bugs) return; } - log.info('Total bugs: ' + total) - for (i in 0..total-1) { + log.info('Total bugs: ' + bugCount) + for (i in 0..bugCount-1) { def bug = bugs[i] log.error( bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type') } From 0cea25a591970f8aa53ee152f690ab7316d17a8a Mon Sep 17 00:00:00 2001 From: Falko Modler Date: Mon, 25 May 2020 22:04:20 +0200 Subject: [PATCH 0411/1013] CheckMojo: introduce failThreshold --- src/it/check-fail/verify.groovy | 18 ++++++++ src/it/check-failThreshold/invoker.properties | 4 ++ src/it/check-failThreshold/pom.xml | 44 +++++++++++++++++++ src/it/check-failThreshold/verify.groovy | 19 ++++++++ .../SpotbugsViolationCheckMojo.groovy | 31 +++++++++++-- 5 files changed, 113 insertions(+), 3 deletions(-) create mode 100644 src/it/check-fail/verify.groovy create mode 100644 src/it/check-failThreshold/invoker.properties create mode 100644 src/it/check-failThreshold/pom.xml create mode 100644 src/it/check-failThreshold/verify.groovy diff --git a/src/it/check-fail/verify.groovy b/src/it/check-fail/verify.groovy new file mode 100644 index 000000000..c509ec221 --- /dev/null +++ b/src/it/check-fail/verify.groovy @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/it/check-failThreshold/invoker.properties b/src/it/check-failThreshold/invoker.properties new file mode 100644 index 000000000..14379f58c --- /dev/null +++ b/src/it/check-failThreshold/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = failure diff --git a/src/it/check-failThreshold/pom.xml b/src/it/check-failThreshold/pom.xml new file mode 100644 index 000000000..6a365d6a0 --- /dev/null +++ b/src/it/check-failThreshold/pom.xml @@ -0,0 +1,44 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check + check + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + High + + + + + diff --git a/src/it/check-failThreshold/verify.groovy b/src/it/check-failThreshold/verify.groovy new file mode 100644 index 000000000..cc50632c2 --- /dev/null +++ b/src/it/check-failThreshold/verify.groovy @@ -0,0 +1,19 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.text.contains( '[WARNING] Medium: Unused public or protected field:' ) +assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index f73942c17..bc97b2b68 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -428,6 +428,15 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { @Parameter(property = "spotbugs.failOnError", defaultValue = "true") boolean failOnError + /** + * Prioritiy threshold which bugs have to reach to cause a failure. Valid values are High, Medium or Low. + * Bugs below this threshold will just issue a warning log entry. + * + * @since 4.0.1 + */ + @Parameter(property = "spotbugs.failThreshold") + String failThreshold + /** * Fork a VM for Spotbugs analysis. This will allow you to set timeouts and heap size. * @@ -522,15 +531,31 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { } log.info('Total bugs: ' + bugCount) + def bugCountAboveThreshold = 0 + def priorityThresholdNum = failThreshold ? SpotBugsInfo.spotbugsPriority.indexOf(failThreshold) : Integer.MAX_VALUE + if (priorityThresholdNum == -1) { + throw new MojoExecutionException("Invalid value for failThreshold: ${failThreshold}") + } + for (i in 0..bugCount-1) { def bug = bugs[i] - log.error( bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type') + def priorityNum = bug.'@priority' as int + def priorityName = SpotBugsInfo.spotbugsPriority[priorityNum] + def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' + + if (priorityNum <= priorityThresholdNum) { // lower is more severe + bugCountAboveThreshold += 1 + log.error(logMsg) + } else { + log.warn(logMsg) + } } log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n') - if ( (bugCount || errorCount) && failOnError ) { - throw new MojoExecutionException("failed with ${bugCount} bugs and ${errorCount} errors ") + if ( (bugCountAboveThreshold || errorCount) && failOnError ) { + throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ") } } } From d8c17faca6c48120b441fec488dc4209d8d97fd4 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 28 May 2020 08:58:16 +0000 Subject: [PATCH 0412/1013] Bump commons-io from 2.6 to 2.7 Bumps commons-io from 2.6 to 2.7. Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index be492a227..98152b4cd 100644 --- a/pom.xml +++ b/pom.xml @@ -182,7 +182,7 @@ 1.14 3.2.2 2.1 - 2.6 + 2.7 3.10 From f409ca2bfe9228bd1ba3bd964a49be0828252244 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Wed, 3 Jun 2020 09:06:58 +0000 Subject: [PATCH 0413/1013] Bump maven-project-info-reports-plugin from 3.0.0 to 3.1.0 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.0.0...maven-project-info-reports-plugin-3.1.0) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 98152b4cd..61aba9bc7 100644 --- a/pom.xml +++ b/pom.xml @@ -143,7 +143,7 @@ 1.8 0.22-1 1.9.0 - 3.0.0 + 3.1.0 3.2.1 3.2.0 3.6.0 From 045bdf1b5c8784a13c08ddf067f32303abce2c74 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 6 Jun 2020 13:44:15 -0400 Subject: [PATCH 0414/1013] [pom] Exclude groovy testng as we do not use it see https://groovy-lang.org/releasenotes/groovy-3.0.html due to incorrectly upgrading too soon. While testng showed 7.2.0 released, they have also since retrated the release so it was likely a problem in my opinion. --- pom.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pom.xml b/pom.xml index 98152b4cd..9f7cfe07e 100644 --- a/pom.xml +++ b/pom.xml @@ -836,6 +836,13 @@ groovy-all ${groovyVersion} pom + + + + org.codehaus.groovy + groovy-testng + + From 6cdd6842217c1e04036109d89d3e4c1da38c7cad Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Tue, 9 Jun 2020 08:47:47 +0000 Subject: [PATCH 0415/1013] Bump spotbugs from 4.0.3 to 4.0.4 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.3 to 4.0.4. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.3...4.0.4) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 456240cfb..05b0cd692 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.0.3 + 4.0.4 4.0.2 2.0.0-alpha1 From ff24ceed00f1e4bee8dd4329ed67a6c0bd205664 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 19 Jun 2020 19:43:55 -0400 Subject: [PATCH 0416/1013] [pom] Bump spotbugs tag to 4.0.4 / version to 4.0.4 snapshot --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 05b0cd692..1a61073b2 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.2-SNAPSHOT + 4.0.4-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -120,7 +120,7 @@ 5.6.2 4.0.4 - 4.0.2 + 4.0.4 2.0.0-alpha1 1.10.8 From 084211429b279980589e8b9229d8bf95086189e8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 19 Jun 2020 20:23:32 -0400 Subject: [PATCH 0417/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.0.4 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 1a61073b2..78184ed75 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.4-SNAPSHOT + 4.0.4 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.0.4 GitHub Issues From da7d20abffd61771c46258c546157de4b2496bc7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 19 Jun 2020 20:23:34 -0400 Subject: [PATCH 0418/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 78184ed75..55b635ba7 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.4 + 4.0.5-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.0.4 + HEAD GitHub Issues From aed2d7e42339bbdef411631c82538dea71a66e32 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Mon, 22 Jun 2020 10:25:44 +0000 Subject: [PATCH 0419/1013] Bump base-parent from 25 to 26 Bumps [base-parent](https://github.com/hazendaz/base-parent) from 25 to 26. - [Release notes](https://github.com/hazendaz/base-parent/releases) - [Commits](https://github.com/hazendaz/base-parent/commits) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 55b635ba7..78a722aa3 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 25 + 26 From 0130a5d4645342f637e75dadd44d20d5a650ca35 Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Tue, 23 Jun 2020 09:24:34 +0000 Subject: [PATCH 0420/1013] Bump spotbugs from 4.0.4 to 4.0.6 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.4 to 4.0.6. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.4...4.0.6) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 78a722aa3..fa00175bf 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.0.4 + 4.0.6 4.0.4 2.0.0-alpha1 From 8538eca70b6997c1a70e6a5c7944fd91487e256d Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Thu, 25 Jun 2020 09:04:09 +0000 Subject: [PATCH 0421/1013] Bump maven-site-plugin from 3.9.0 to 3.9.1 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.0 to 3.9.1. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.9.0...maven-site-plugin-3.9.1) Signed-off-by: dependabot-preview[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fa00175bf..595956d94 100644 --- a/pom.xml +++ b/pom.xml @@ -148,7 +148,7 @@ 3.2.0 3.6.0 1.11.2 - 3.9.0 + 3.9.1 3.6 2.7 From 2697ed516334dd10b9b91ce6bc017817b041311a Mon Sep 17 00:00:00 2001 From: "Sean C. Sullivan" Date: Sat, 4 Jul 2020 05:02:37 -0700 Subject: [PATCH 0422/1013] enable Dependabot v2 https://github.blog/2020-06-01-keep-all-your-packages-up-to-date-with-dependabot/ --- .github/dependabot.yml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .github/dependabot.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml new file mode 100644 index 000000000..daec31893 --- /dev/null +++ b/.github/dependabot.yml @@ -0,0 +1,6 @@ +version: 2 +updates: + - package-ecosystem: "maven" + directory: "/" + schedule: + interval: "daily" From 973fb04f5e02a0dc80b4d532dfa4448556c28ec2 Mon Sep 17 00:00:00 2001 From: Falko Modler Date: Wed, 8 Jul 2020 16:23:01 +0200 Subject: [PATCH 0423/1013] CheckMojo: reduce log to info when bug below threshold --- src/it/check-failThreshold/verify.groovy | 2 +- .../codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/it/check-failThreshold/verify.groovy b/src/it/check-failThreshold/verify.groovy index cc50632c2..00cab90ba 100644 --- a/src/it/check-failThreshold/verify.groovy +++ b/src/it/check-failThreshold/verify.groovy @@ -15,5 +15,5 @@ */ File buildLog = new File( basedir, 'build.log' ) -assert buildLog.text.contains( '[WARNING] Medium: Unused public or protected field:' ) +assert buildLog.text.contains( '[INFO] Medium: Unused public or protected field:' ) assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy index bc97b2b68..197f12461 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy @@ -548,7 +548,7 @@ class SpotbugsViolationCheckMojo extends AbstractMojo { bugCountAboveThreshold += 1 log.error(logMsg) } else { - log.warn(logMsg) + log.info(logMsg) } } From 10909993b29480692c219961a97ad01ac4535b3f Mon Sep 17 00:00:00 2001 From: Thomas Kalmar Date: Wed, 8 Jul 2020 17:40:20 +0200 Subject: [PATCH 0424/1013] Use File api to parse filenames, Fix #34 --- .../org/codehaus/mojo/spotbugs/ResourceHelper.groovy | 11 ++++++----- .../org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 2 -- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy index fcedf6414..857b23eb6 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy @@ -25,6 +25,8 @@ import org.codehaus.plexus.resource.loader.FileResourceLoader import org.codehaus.plexus.resource.ResourceManager import org.codehaus.plexus.util.FileUtils +import java.nio.file.Paths + final class ResourceHelper { Log log @@ -53,12 +55,11 @@ final class ResourceHelper { String location = null String artifact = resource - if (resource.indexOf(SpotBugsInfo.FORWARD_SLASH) != -1) { - artifact = resource.substring(resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH) + 1) - } + def file = new File(resource) - if (resource.indexOf(SpotBugsInfo.FORWARD_SLASH) != -1) { - location = resource.substring(0, resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH)) + if (file.exists()) { + artifact = file.getName() + location = file.getAbsolutePath() } // replace all occurrences of the following characters: ? : & = diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index d66a7fdc8..3c40ceccd 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -77,8 +77,6 @@ interface SpotBugsInfo { static final String COMMA = "," - static final String FORWARD_SLASH = '/' - /** * The character to separate URL tokens. * From 236b92d9fab90a57ab0e0c18a2ad546c13b0603a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 17 Jul 2020 05:19:31 +0000 Subject: [PATCH 0425/1013] Bump commons-lang3 from 3.10 to 3.11 Bumps commons-lang3 from 3.10 to 3.11. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 595956d94..158087713 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 3.2.2 2.1 2.7 - 3.10 + 3.11 5.3.2 From 1d93120cdbd3d59232484bd110fec2c9df394bbe Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 23 Jul 2020 05:44:54 +0000 Subject: [PATCH 0426/1013] Bump groovyVersion from 3.0.4 to 3.0.5 Bumps `groovyVersion` from 3.0.4 to 3.0.5. Updates `groovy` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.4 to 3.0.5 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 158087713..8347e8f95 100644 --- a/pom.xml +++ b/pom.xml @@ -124,7 +124,7 @@ 2.0.0-alpha1 1.10.8 - 3.0.4 + 3.0.5 1.9.1 1.9.2 From 6601195dbd94fa811dcd532d7ba479a5c616eacf Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 31 Jul 2020 05:18:48 +0000 Subject: [PATCH 0427/1013] Bump spotbugs from 4.0.6 to 4.1.1 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.0.6 to 4.1.1. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.0.6...4.1.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8347e8f95..fc677dd2b 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.0.6 + 4.1.1 4.0.4 2.0.0-alpha1 From e01af9bbfbaa514015ffafc746ae7a2c8b0070ae Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 5 Aug 2020 06:37:43 +0000 Subject: [PATCH 0428/1013] Bump gmavenplus-plugin from 1.9.0 to 1.10.0 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.9.0 to 1.10.0. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.9.0...1.10.0) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fc677dd2b..da9c80878 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.9.0 + 1.10.0 3.1.0 3.2.1 3.2.0 From 79100c41f70d1cc36be167bc4ca0a6cce1057ca4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 19 Aug 2020 05:39:31 +0000 Subject: [PATCH 0429/1013] Bump spotbugs from 4.1.1 to 4.1.2 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.1.1...4.1.2) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index da9c80878..b41f1c005 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.1.1 + 4.1.2 4.0.4 2.0.0-alpha1 From 6c97dfea0bf92d29a00e510d1b6937604c196b3d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 2 Sep 2020 05:38:21 +0000 Subject: [PATCH 0430/1013] Bump commons-codec from 1.14 to 1.15 Bumps [commons-codec](https://github.com/apache/commons-codec) from 1.14 to 1.15. - [Release notes](https://github.com/apache/commons-codec/releases) - [Changelog](https://github.com/apache/commons-codec/blob/master/RELEASE-NOTES.txt) - [Commits](https://github.com/apache/commons-codec/compare/commons-codec-1.14...rel/commons-codec-1.15) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b41f1c005..9a25e4a6b 100644 --- a/pom.xml +++ b/pom.xml @@ -179,7 +179,7 @@ 8.0.1 1.9.4 1.2 - 1.14 + 1.15 3.2.2 2.1 2.7 From 1468586e48f8745fb28f260d5cb362c6e4681960 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 7 Sep 2020 05:18:28 +0000 Subject: [PATCH 0431/1013] Bump maven-project-info-reports-plugin from 3.1.0 to 3.1.1 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.1.0...maven-project-info-reports-plugin-3.1.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9a25e4a6b..aee35752f 100644 --- a/pom.xml +++ b/pom.xml @@ -143,7 +143,7 @@ 1.8 0.22-1 1.10.0 - 3.1.0 + 3.1.1 3.2.1 3.2.0 3.6.0 From deea53b3ec319b1f59de8d26078855d6dc1ceafc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 10 Sep 2020 05:47:37 +0000 Subject: [PATCH 0432/1013] Bump commons-io from 2.7 to 2.8.0 Bumps commons-io from 2.7 to 2.8.0. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index aee35752f..2f0e28cd0 100644 --- a/pom.xml +++ b/pom.xml @@ -182,7 +182,7 @@ 1.15 3.2.2 2.1 - 2.7 + 2.8.0 3.11 From b0332b917fbfa8a9564e88c02fcfd51acac44835 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 21 Sep 2020 06:16:50 +0000 Subject: [PATCH 0433/1013] Bump gmavenplus-plugin from 1.10.0 to 1.10.1 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.10.0 to 1.10.1. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.10.0...1.10.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2f0e28cd0..bdb06d90b 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.10.0 + 1.10.1 3.1.1 3.2.1 3.2.0 From d95e2680d2a7ecb4616ae063abc31a45b2dbe8f1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 22 Sep 2020 05:41:26 +0000 Subject: [PATCH 0434/1013] Bump asm.version from 8.0.1 to 9.0 Bumps `asm.version` from 8.0.1 to 9.0. Updates `asm` from 8.0.1 to 9.0 Updates `asm-analysis` from 8.0.1 to 9.0 Updates `asm-commons` from 8.0.1 to 9.0 Updates `asm-tree` from 8.0.1 to 9.0 Updates `asm-util` from 8.0.1 to 9.0 Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index bdb06d90b..3d2fa5a46 100644 --- a/pom.xml +++ b/pom.xml @@ -176,7 +176,7 @@ 5.7.0.202003110725-r - 8.0.1 + 9.0 1.9.4 1.2 1.15 From 4547ffa6496f608e49bb402bd5c6eed33d80253e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 25 Sep 2020 05:38:55 +0000 Subject: [PATCH 0435/1013] Bump spotbugs from 4.1.2 to 4.1.3 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.1.2...4.1.3) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3d2fa5a46..6c7a19f0d 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.6.2 - 4.1.2 + 4.1.3 4.0.4 2.0.0-alpha1 From 0d5e1821edaba0c8eeeccbb7b6a02e48f052c6c0 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat, 26 Sep 2020 19:44:13 +0000 Subject: [PATCH 0436/1013] Bump versions-maven-plugin from 2.7 to 2.8.1 Bumps [versions-maven-plugin](https://github.com/mojohaus/versions-maven-plugin) from 2.7 to 2.8.1. - [Release notes](https://github.com/mojohaus/versions-maven-plugin/releases) - [Changelog](https://github.com/mojohaus/versions-maven-plugin/blob/master/ReleaseNotes.md) - [Commits](https://github.com/mojohaus/versions-maven-plugin/compare/versions-maven-plugin-2.7...versions-maven-plugin-2.8.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6c7a19f0d..0a09d3702 100644 --- a/pom.xml +++ b/pom.xml @@ -150,7 +150,7 @@ 1.11.2 3.9.1 3.6 - 2.7 + 2.8.1 false ${project.build.directory}/it-src-spotbugs From a11c8f9beb9a156d1ca323d8f119345263935ac2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 16 Aug 2020 16:56:44 -0400 Subject: [PATCH 0437/1013] [pom] Make sure we are on spotbugs 4.1.3 fully --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 6c7a19f0d..84efc9f06 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.0.5-SNAPSHOT + 4.1.3.SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -120,7 +120,7 @@ 5.6.2 4.1.3 - 4.0.4 + 4.1.3 2.0.0-alpha1 1.10.8 From 77ab2e1d7443c5ec5b2cd107ba38f6adeee5382d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 16 Aug 2020 16:57:05 -0400 Subject: [PATCH 0438/1013] [pom] Bump servlet api to 4.0.4 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 84efc9f06..a67f438e8 100644 --- a/pom.xml +++ b/pom.xml @@ -170,7 +170,7 @@ 3.0.0 3.0.0-M4 8.0.0 - 4.0.3 + 4.0.4 7.4.7 5.7.0.202003110725-r From 9cceeabcd2ce49abd6b9c36e615e29c968b2a0bf Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 16 Aug 2020 16:57:17 -0400 Subject: [PATCH 0439/1013] [pom] Bump surefire to 3.0.0-M5 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a67f438e8..d2a39d294 100644 --- a/pom.xml +++ b/pom.xml @@ -168,7 +168,7 @@ 3.8.1 1.10.1 3.0.0 - 3.0.0-M4 + 3.0.0-M5 8.0.0 4.0.4 7.4.7 From 9c03371249125a85d3a772adcbc5175887dcede8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 16 Aug 2020 16:57:44 -0400 Subject: [PATCH 0440/1013] [pom] Remove dependency check override as fixed after base-parent 25 upgrade (on 26 now) --- pom.xml | 3 --- 1 file changed, 3 deletions(-) diff --git a/pom.xml b/pom.xml index d2a39d294..e127a5a01 100644 --- a/pom.xml +++ b/pom.xml @@ -184,9 +184,6 @@ 2.1 2.8.0 3.11 - - - 5.3.2 From 9b44ec365a3d9b3d938f6b04e31cc56c7b42c735 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 28 Sep 2020 20:28:47 -0400 Subject: [PATCH 0441/1013] [travis] Drop openjdk14 --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fbeac5982..a38fbf085 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,6 @@ language: java jdk: - openjdk15 - - openjdk14 - openjdk11 - openjdk8 From c31ac2a9deda5aed7955b5b87cdb6a46197a4834 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 28 Sep 2020 20:28:56 -0400 Subject: [PATCH 0442/1013] [pom] Bump junit to 5.7.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6830511e6..6ba4df808 100644 --- a/pom.xml +++ b/pom.xml @@ -118,7 +118,7 @@ ${project.version} - 5.6.2 + 5.7.0 4.1.3 4.1.3 2.0.0-alpha1 From ffeca0844cd3b02c6fb68a4538689438928b326f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 28 Sep 2020 20:30:40 -0400 Subject: [PATCH 0443/1013] [pom] Bump jgit to 5.9.0.x --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6ba4df808..485ef24c7 100644 --- a/pom.xml +++ b/pom.xml @@ -173,7 +173,7 @@ 4.0.4 7.4.7 - 5.7.0.202003110725-r + 5.9.0.202009080501-r 9.0 From 1328f9c90e8434ea6b77ff9be34d2f5c78f3540a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 28 Sep 2020 20:59:04 -0400 Subject: [PATCH 0444/1013] [pom] Fix version string - not period --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 485ef24c7..72aea1297 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.3.SNAPSHOT + 4.1.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin From c69dab04621247e89a8f3e1776984636c6405976 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 28 Sep 2020 21:06:57 -0400 Subject: [PATCH 0445/1013] [pom] Added jgit support module --- pom.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pom.xml b/pom.xml index 72aea1297..3c36e1c2e 100644 --- a/pom.xml +++ b/pom.xml @@ -891,6 +891,11 @@ org.eclipse.jgit ${jgit.version} + + org.eclipse.jgit + org.eclipse.jgit.ssh.jsch + ${jgit.version} + From 9e3348246c1c946543d7fff454d292b9f5f03b70 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 29 Sep 2020 08:12:44 -0400 Subject: [PATCH 0446/1013] [groovy] Bump to 3.0.6 for jdk 16 support --- pom.xml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3c36e1c2e..feec1b13f 100644 --- a/pom.xml +++ b/pom.xml @@ -124,7 +124,7 @@ 2.0.0-alpha1 1.10.8 - 3.0.5 + 3.0.6 1.9.1 1.9.2 @@ -627,6 +627,13 @@ ${project.reporting.outputDirectory}/gapidocs true + + + org.codehaus.groovy + groovy + ${groovyVersion} + + compileGroovy From 085c57bd55f9eacb9b7dc6a01df96b1b36440863 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 29 Sep 2020 08:13:10 -0400 Subject: [PATCH 0447/1013] [ci] Add openjdk16 --- .travis.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.travis.yml b/.travis.yml index a38fbf085..1cb7d165d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ dist: bionic language: java jdk: + - openjdk16 - openjdk15 - openjdk11 - openjdk8 From 17aa082f1b21c9119a81ced1a0280128d9bcea51 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 30 Sep 2020 08:19:38 -0400 Subject: [PATCH 0448/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.1.3 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index feec1b13f..bd92c6708 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.3-SNAPSHOT + 4.1.3 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.1.3 GitHub Issues From abcddd85b8403dfd9a5c961758d9dbc3aadffee8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 30 Sep 2020 08:19:39 -0400 Subject: [PATCH 0449/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index bd92c6708..b9f01b546 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.3 + 4.1.4-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.1.3 + HEAD GitHub Issues From e9a541eb2753738251134546f197bf9a7d559634 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 1 Oct 2020 05:50:59 +0000 Subject: [PATCH 0450/1013] Bump ant from 1.10.8 to 1.10.9 Bumps ant from 1.10.8 to 1.10.9. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b9f01b546..5d4019bfa 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 4.1.3 2.0.0-alpha1 - 1.10.8 + 1.10.9 3.0.6 1.9.1 From dedf1c5b5459f8e2f33c28578408712664becec8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 12 Oct 2020 06:15:18 +0000 Subject: [PATCH 0451/1013] Bump gmavenplus-plugin from 1.10.1 to 1.11.0 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.10.1 to 1.11.0. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.10.1...1.11.0) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5d4019bfa..aaf01d2a2 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.10.1 + 1.11.0 3.1.1 3.2.1 3.2.0 From 1036d313faf37c2e0d26a8c7a00a0a3e50d42635 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 19 Oct 2020 11:04:36 -0400 Subject: [PATCH 0452/1013] [pom] Bump spotbugs to 4.1.4 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index aaf01d2a2..fdf4cf305 100644 --- a/pom.xml +++ b/pom.xml @@ -119,8 +119,8 @@ ${project.version} 5.7.0 - 4.1.3 - 4.1.3 + 4.1.4 + 4.1.4 2.0.0-alpha1 1.10.9 From b3dfcdc91065ec15a230e9a540ec4c317b32594a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 19 Oct 2020 11:38:32 -0400 Subject: [PATCH 0453/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.1.4 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index fdf4cf305..3cd6174e6 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.4-SNAPSHOT + 4.1.4 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.1.4 GitHub Issues From 7c60737846c892e05bf4fb9bb8db762fd9881038 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 19 Oct 2020 11:38:33 -0400 Subject: [PATCH 0454/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 3cd6174e6..43e3acbc2 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.4 + 4.1.5-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.1.4 + HEAD GitHub Issues From 801bf4743ec859b6c91a24b86cd90bfb0d5b4be7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 25 Nov 2020 22:24:14 -0500 Subject: [PATCH 0455/1013] [actions] Add github actions ci builds --- .github/workflows/ci.yaml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/ci.yaml diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml new file mode 100644 index 000000000..3712a9dd1 --- /dev/null +++ b/.github/workflows/ci.yaml @@ -0,0 +1,23 @@ +name: Java CI + +on: [push] + +jobs: + test: + runs-on: ${{ matrix.os }} + strategy: + matrix: + os: [ubuntu-latest, macOS-latest, windows-latest] + java: [8, 11, 15, 16-ea] + fail-fast: false + max-parallel: 4 + name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: ${{ matrix.java }} + - name: Test with Maven + run: mvn test -B From e8f21891465995b988cd0a5b70653e6fee430119 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 26 Nov 2020 00:47:34 -0500 Subject: [PATCH 0456/1013] [travis] Revert change to condition check on master This appears to not be regex as discovered by eclipse but rather doesn't work if not set this way at all. --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1cb7d165d..1c77b140c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,7 +26,7 @@ deploy: repo: spotbugs/spotbugs-maven-plugin branch: spotbugs jdk: openjdk11 - condition: $TRAVIS_COMMIT_MESSAGE !~ ^\[maven-release-plugin\]* + condition: $TRAVIS_COMMIT_MESSAGE != ^\[maven-release-plugin\]* - provider: pages skip_cleanup: true @@ -37,4 +37,4 @@ deploy: repo: spotbugs/spotbugs-maven-plugin branch: spotbugs jdk: openjdk11 - condition: $TRAVIS_COMMIT_MESSAGE !~ ^\[maven-release-plugin\]* + condition: $TRAVIS_COMMIT_MESSAGE != ^\[maven-release-plugin\]* From 3237da18f4214d414a09abe7d1005018baa5691a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 30 Nov 2020 06:15:36 +0000 Subject: [PATCH 0457/1013] Bump spotbugs from 4.1.4 to 4.2.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.1.4 to 4.2.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.1.4...4.2.0) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 43e3acbc2..92abc3157 100644 --- a/pom.xml +++ b/pom.xml @@ -119,7 +119,7 @@ ${project.version} 5.7.0 - 4.1.4 + 4.2.0 4.1.4 2.0.0-alpha1 From 5e8c21467698099bd8fc5b75ca1a8f9b3fe3019e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 1 Dec 2020 05:58:10 +0000 Subject: [PATCH 0458/1013] Bump gmavenplus-plugin from 1.11.0 to 1.11.1 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.11.0 to 1.11.1. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.11.0...1.11.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 92abc3157..bbc3a7051 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.11.0 + 1.11.1 3.1.1 3.2.1 3.2.0 From dcc7ec4c16b4ce5c3a37a9332063b2b46b8390fb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 4 Dec 2020 05:41:53 +0000 Subject: [PATCH 0459/1013] Bump groovyVersion from 3.0.6 to 3.0.7 Bumps `groovyVersion` from 3.0.6 to 3.0.7. Updates `groovy` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.6 to 3.0.7 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index bbc3a7051..0c07c7b53 100644 --- a/pom.xml +++ b/pom.xml @@ -124,7 +124,7 @@ 2.0.0-alpha1 1.10.9 - 3.0.6 + 3.0.7 1.9.1 1.9.2 From 1512b8c38199359651ff208f67116427f100798a Mon Sep 17 00:00:00 2001 From: Alberto Otero Lorenzo Date: Tue, 15 Dec 2020 15:17:29 +0100 Subject: [PATCH 0460/1013] Add IT test to check excludeFiltersFile duplications on multi-module projects --- .../invoker.properties | 4 ++ .../check-multi-filter-dups/module1/pom.xml | 38 ++++++++++++ .../check-multi-filter-dups/module2/pom.xml | 38 ++++++++++++ src/it/check-multi-filter-dups/pom.xml | 60 +++++++++++++++++++ .../main/config/spotbugs-exclude-filters.xml | 6 ++ src/it/check-multi-filter-dups/verify.groovy | 29 +++++++++ 6 files changed, 175 insertions(+) create mode 100644 src/it/check-multi-filter-dups/invoker.properties create mode 100644 src/it/check-multi-filter-dups/module1/pom.xml create mode 100644 src/it/check-multi-filter-dups/module2/pom.xml create mode 100644 src/it/check-multi-filter-dups/pom.xml create mode 100644 src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml create mode 100644 src/it/check-multi-filter-dups/verify.groovy diff --git a/src/it/check-multi-filter-dups/invoker.properties b/src/it/check-multi-filter-dups/invoker.properties new file mode 100644 index 000000000..d5da9063b --- /dev/null +++ b/src/it/check-multi-filter-dups/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/check-multi-filter-dups/module1/pom.xml b/src/it/check-multi-filter-dups/module1/pom.xml new file mode 100644 index 000000000..9c30b2e3b --- /dev/null +++ b/src/it/check-multi-filter-dups/module1/pom.xml @@ -0,0 +1,38 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + check-multi-parent-relative-path + testing + .. + + module1 + module1 + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + + + diff --git a/src/it/check-multi-filter-dups/module2/pom.xml b/src/it/check-multi-filter-dups/module2/pom.xml new file mode 100644 index 000000000..b3117c81f --- /dev/null +++ b/src/it/check-multi-filter-dups/module2/pom.xml @@ -0,0 +1,38 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + check-multi-parent-relative-path + testing + .. + + module2 + module2 + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + + + diff --git a/src/it/check-multi-filter-dups/pom.xml b/src/it/check-multi-filter-dups/pom.xml new file mode 100644 index 000000000..dbef936e3 --- /dev/null +++ b/src/it/check-multi-filter-dups/pom.xml @@ -0,0 +1,60 @@ + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check-multi-parent-relative-path + check-multi-parent-relative-path + pom + + module1 + module2 + + + + + com.github.spotbugs + spotbugs-maven-plugin + + false + ${project.parent.relativePath}/src/main/config/spotbugs-exclude-filters.xml + + + + spotbugs + prepare-package + + check + + + + + + + + + .. + + + + diff --git a/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml new file mode 100644 index 000000000..b9b77c524 --- /dev/null +++ b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml @@ -0,0 +1,6 @@ + + + \ No newline at end of file diff --git a/src/it/check-multi-filter-dups/verify.groovy b/src/it/check-multi-filter-dups/verify.groovy new file mode 100644 index 000000000..021a82986 --- /dev/null +++ b/src/it/check-multi-filter-dups/verify.groovy @@ -0,0 +1,29 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + + + +// check module 1 + +File spotbugXmlInModule = new File(basedir, "module1/src/main/config/spotbugs-exclude-filters.xml") +assert !spotbugXmlInModule.exists() + + +// check module 2 + +spotbugXmlInModule = new File(basedir, "module2/src/main/config/spotbugs-exclude-filters.xml") +assert !spotbugXmlInModule.exists() + From 86139c1a48ecac3ba80533bdf9802b3a98cca699 Mon Sep 17 00:00:00 2001 From: Alberto Otero Lorenzo Date: Tue, 15 Dec 2020 16:31:07 +0100 Subject: [PATCH 0461/1013] Remove playground lines --- src/it/check-multi-filter-dups/pom.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/it/check-multi-filter-dups/pom.xml b/src/it/check-multi-filter-dups/pom.xml index dbef936e3..ff5d206d4 100644 --- a/src/it/check-multi-filter-dups/pom.xml +++ b/src/it/check-multi-filter-dups/pom.xml @@ -51,10 +51,6 @@ - - - .. - From 125ac2d27514b41c14182ca7d1b3357e3209f77d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 17:56:10 -0500 Subject: [PATCH 0462/1013] [actions] Add sonar / coverity --- .github/workflows/coverity.yaml | 32 ++++++++++++++++++++++++++++++++ .github/workflows/sonar.yaml | 25 +++++++++++++++++++++++++ 2 files changed, 57 insertions(+) create mode 100644 .github/workflows/coverity.yaml create mode 100644 .github/workflows/sonar.yaml diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml new file mode 100644 index 000000000..8d7aa13a2 --- /dev/null +++ b/.github/workflows/coverity.yaml @@ -0,0 +1,32 @@ +name: Coverity + +on: + push: + branches: + - coverity_scan + +jobs: + build: + if: github.repository_owner == 'spotbugs' + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Analyze with Coverity + run: | + wget -q https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_TOKEN&project=spotbugs%2Fspotbugs-maven-plugin" -O coverity_tool.tgz + tar -xf coverity_tool.tgz + ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -DskipTests=true verify + tar czvf spotbugs-maven-plugin.tgz cov-int + curl --form token=$COVERITY_TOKEN \ + --form email=$EMAIL \ + --form file=@spotbugs-maven-plugin.tgz \ + --form version="spotbugs-maven-plugin/coverity_scan" \ + --form description="Spotbugs Maven Plugin Coverity Scan" \ + https://scan.coverity.com/builds?project=spotbugs%2Fspotbugs-maven-plugin + env: + COVERITY_TOKEN: ${{ secrets.COVERITY_TOKEN }} + EMAIL: ${{ secrets.EMAIL }} diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml new file mode 100644 index 000000000..786cd5c2f --- /dev/null +++ b/.github/workflows/sonar.yaml @@ -0,0 +1,25 @@ +name: SonarCloud + +on: + push: + branches: + - master + +jobs: + build: + if: github.repository_owner == 'spotbugs' + runs-on: windows-latest + steps: + - uses: actions/checkout@v2 + with: + # Disabling shallow clone is recommended for improving relevancy of reporting + fetch-depth: 0 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Analyze with SonarCloud + run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} From 7f5e0622a6b588199f63ee6927c02f3221157d83 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 17:58:03 -0500 Subject: [PATCH 0463/1013] [pom] Bump to spotbugs 4.2.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0c07c7b53..3b7ba7c0f 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.1.5-SNAPSHOT + 4.2.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -120,7 +120,7 @@ 5.7.0 4.2.0 - 4.1.4 + 4.2.0 2.0.0-alpha1 1.10.9 From 67a1a7f90b663ce948705c44a380a18cc68c948c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:34:57 -0500 Subject: [PATCH 0464/1013] [actions] Run on PRs as well / drop jdk 16 as error prone doesn't support yet --- .github/workflows/ci.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3712a9dd1..7f8b9a105 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -1,6 +1,6 @@ name: Java CI -on: [push] +on: [push, pull_request] jobs: test: @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 15, 16-ea] + java: [8, 11, 15] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} @@ -20,4 +20,4 @@ jobs: with: java-version: ${{ matrix.java }} - name: Test with Maven - run: mvn test -B + run: ./mvnw test -B From c8948d4d6d841bb0eaec6d07609a60c3960c3164 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:35:54 -0500 Subject: [PATCH 0465/1013] [actions] Add initial coverals but note it won't work yet nor set to pull tests as we need (ie integration tests) --- .github/workflows/coveralls.yaml | 41 ++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/coveralls.yaml diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml new file mode 100644 index 000000000..931999a91 --- /dev/null +++ b/.github/workflows/coveralls.yaml @@ -0,0 +1,41 @@ +# +# Copyright 2015-2020 the original author or authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +name: Coveralls + +on: [push, pull_request] + +jobs: + build: + if: github.repository_owner == 'spotbugs' + runs-on: windows-latest + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Report Coverage to Coveralls for Pull Requests + if: github.event_name == 'pull_request' + run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + PR_NUMBER: ${{ github.event.number }} + - name: Report Coverage to Coveralls for General Push + if: github.event_name == 'push' + run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 3606a3d0f4d11dfb42d425f5080b25673d1b10d0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:36:13 -0500 Subject: [PATCH 0466/1013] [actions] Add initial drop in for site distribution - will get working later --- .github/workflows/site.yaml | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/workflows/site.yaml diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml new file mode 100644 index 000000000..23961d6c7 --- /dev/null +++ b/.github/workflows/site.yaml @@ -0,0 +1,33 @@ +name: Site + +on: + push: + branches: + - site + +jobs: + build: + if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]') + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - uses: webfactory/ssh-agent@master + with: + ssh-private-key: ${{ secrets.DEPLOY_KEY }} + - name: Build site + run: ./mvnw site site:stage -DskipTests -B + env: + CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + - name: Deploy Site to gh-pages + uses: JamesIves/github-pages-deploy-action@3.7.1 + with: + SSH: true + BRANCH: gh-pages + FOLDER: target/staging + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 502932627dfe06d0a1e90c4028d4025ce6d3ed80 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:36:25 -0500 Subject: [PATCH 0467/1013] [actions] Enable sonatype --- .github/workflows/sonatype.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 .github/workflows/sonatype.yaml diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml new file mode 100644 index 000000000..514e43771 --- /dev/null +++ b/.github/workflows/sonatype.yaml @@ -0,0 +1,22 @@ +name: Sonatype + +on: + push: + branches: + - master + +jobs: + build: + if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]') + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Deploy to Sonatype + run: ./mvnw deploy -DskipTests -B --settings ./.mvn/settings.xml + env: + CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} + CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }} From bd743f0862b8ecbda1ac6457f9845db83db14c46 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:38:56 -0500 Subject: [PATCH 0468/1013] [travis] Drop jdk 16, 15, and 8 as these are done in actions now Will eventually drop travis entirely once all pieces are up to date. --- .travis.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1c77b140c..ad13a07b0 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,10 +4,7 @@ dist: bionic language: java jdk: - - openjdk16 - - openjdk15 - openjdk11 - - openjdk8 env: global: From ad6fb67c5f4d25de6dca4a9d691d08a4066e1774 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 19:53:09 -0500 Subject: [PATCH 0469/1013] [actions] Change the default branch for sonar/sonatype --- .github/workflows/sonar.yaml | 2 +- .github/workflows/sonatype.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index 786cd5c2f..c5a4743d5 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -3,7 +3,7 @@ name: SonarCloud on: push: branches: - - master + - spotbugs jobs: build: diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 514e43771..d30af7834 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -3,7 +3,7 @@ name: Sonatype on: push: branches: - - master + - spotbugs jobs: build: From 4d8f3e78b9f9c9ba0507c0d51bec3b8f0e88794f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 15 Dec 2020 20:48:14 -0500 Subject: [PATCH 0470/1013] [maven] Add settings so we can do various actions --- .mvn/extensions.xml | 8 ++++++++ .mvn/settings.xml | 19 +++++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 .mvn/extensions.xml create mode 100644 .mvn/settings.xml diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml new file mode 100644 index 000000000..1c87ce310 --- /dev/null +++ b/.mvn/extensions.xml @@ -0,0 +1,8 @@ + + + + fr.jcgay.maven + maven-profiler + 3.0 + + diff --git a/.mvn/settings.xml b/.mvn/settings.xml new file mode 100644 index 000000000..5b91cb639 --- /dev/null +++ b/.mvn/settings.xml @@ -0,0 +1,19 @@ + + + + + ossrh + ${env.CI_DEPLOY_USERNAME} + ${env.CI_DEPLOY_PASSWORD} + + + gh-pages + + + github + ${env.CI_DEPLOY_USERNAME} + ${env.GITHUB_TOKEN} + + + From 4aace5c80f2ea74e4e1812e76bfdc88bd05798cf Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 16 Dec 2020 05:38:44 +0000 Subject: [PATCH 0471/1013] Bump jgit.version from 5.9.0.202009080501-r to 5.10.0.202012080955-r Bumps `jgit.version` from 5.9.0.202009080501-r to 5.10.0.202012080955-r. Updates `org.eclipse.jgit` from 5.9.0.202009080501-r to 5.10.0.202012080955-r Updates `org.eclipse.jgit.ssh.jsch` from 5.9.0.202009080501-r to 5.10.0.202012080955-r Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3b7ba7c0f..97a847bb3 100644 --- a/pom.xml +++ b/pom.xml @@ -173,7 +173,7 @@ 4.0.4 7.4.7 - 5.9.0.202009080501-r + 5.10.0.202012080955-r 9.0 From cd6c5d3388212bec63857aaf9bf331e034724c22 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 16 Dec 2020 05:38:57 +0000 Subject: [PATCH 0472/1013] Bump gmavenplus-plugin from 1.11.1 to 1.12.0 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.11.1 to 1.12.0. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.11.1...1.12.0) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3b7ba7c0f..942b8e26d 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.11.1 + 1.12.0 3.1.1 3.2.1 3.2.0 From b81c32d6f5fd3d1e93efaaef251f3b2f16be9527 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 28 Dec 2020 06:17:03 +0000 Subject: [PATCH 0473/1013] Bump maven-artifact-transfer from 0.12.0 to 0.13.1 Bumps [maven-artifact-transfer](https://github.com/apache/maven-artifact-transfer) from 0.12.0 to 0.13.1. - [Release notes](https://github.com/apache/maven-artifact-transfer/releases) - [Commits](https://github.com/apache/maven-artifact-transfer/compare/maven-artifact-transfer-0.12.0...maven-artifact-transfer-0.13.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 12bfe0609..56a3dd992 100644 --- a/pom.xml +++ b/pom.xml @@ -130,7 +130,7 @@ 1.9.2 3.2.5 - 0.12.0 + 0.13.1 3.0 3.0.0 3.5.2 From c1a491373c8e099f6bc7ff05727e9d06044ed83f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 31 Dec 2020 13:07:24 -0500 Subject: [PATCH 0474/1013] [actions] Move integration tests to github actions --- .github/workflows/it.yaml | 37 +++++++++++++++++++++++++++++++++++++ .travis.yml | 3 --- 2 files changed, 37 insertions(+), 3 deletions(-) create mode 100644 .github/workflows/it.yaml diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml new file mode 100644 index 000000000..520976090 --- /dev/null +++ b/.github/workflows/it.yaml @@ -0,0 +1,37 @@ +# +# Copyright 2011-2020 the original author or authors. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# You may obtain a copy of the License at +# +# https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +name: Java Integration Tests + +on: [push, pull_request] + +jobs: + test: + runs-on: ubuntu-latest + name: Integration Tests + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v1 + with: + java-version: 11 + - name: Build Setup + run: ./mvnw clean install + - name: Integration Test with Maven + run: ./mvnw -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 diff --git a/.travis.yml b/.travis.yml index ad13a07b0..769f0c803 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,9 +11,6 @@ env: # GITHUB_TOKEN value to push changes to GitHub; Currently it is used to update gh-pages. - secure: "KqPuq9TiiqdOUfGq3k+XYObNjV8FxbgJeqSWK0pcWFFs5w5c4vcGmrfUSSSqNa/JJkKOBWQ6S3tJP7CRxx0uow5BvU4ZQAZLFt6VjzcUZFKGTl5soMTF2gQdyAAcwUnRX2gQKt0doO8Fid6xzfsn1KdTIWXmeqMrcTvC+d7EhxU=" -script: - - ./mvnw verify -B -P run-its -DtestSrc=remote -Dinvoker.parallelThreads=4 - deploy: - provider: script skip_cleanup: true From ac9c5747e5c99fcae2fb0e79c6347d3efb49a389 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 1 Jan 2021 05:57:28 +0000 Subject: [PATCH 0475/1013] Bump base-parent from 26 to 27 Bumps [base-parent](https://github.com/hazendaz/base-parent) from 26 to 27. - [Release notes](https://github.com/hazendaz/base-parent/releases) - [Commits](https://github.com/hazendaz/base-parent/commits) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 56a3dd992..0f05aa0c0 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 26 + 27 From d8a1d0e7872a582a97bb2f7d753790f7bf5f97da Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 19 Jun 2020 19:50:21 -0400 Subject: [PATCH 0476/1013] [ci] Update deprecated toInteger to simple cast int --- .../org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 0b8aaf635..ed530967f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -448,7 +448,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { // priority sink.tableCell() - sink.text(spotbugsPriority[priority.toInteger()]) + sink.text(spotbugsPriority[priority as Integer]) sink.tableCell_() sink.tableRow_() From 86c4f910fbe6e3b08d542962308ed5ec38208484 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:13:54 -0500 Subject: [PATCH 0477/1013] [pom] Use newer site generation --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0f05aa0c0..27a9863f8 100644 --- a/pom.xml +++ b/pom.xml @@ -110,8 +110,8 @@ https://oss.sonatype.org/content/repositories/snapshots - gh-pages - github:ssh://spotbugs.github.io/spotbugs-maven-plugin/ + gh-pages-scm + scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git From e9d7bfa14b952d42fd1d4da50b7bc61f0289fcb0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:22:52 -0500 Subject: [PATCH 0478/1013] [ci] Drop travis-ci / add ignore on keys --- .gitignore | 1 + .travis.yml | 34 ---------------------------------- 2 files changed, 1 insertion(+), 34 deletions(-) delete mode 100644 .travis.yml diff --git a/.gitignore b/.gitignore index f3e2d95f2..0a6ebbc0f 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,5 @@ .classpath +.github/keys .project .settings target/ diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 769f0c803..000000000 --- a/.travis.yml +++ /dev/null @@ -1,34 +0,0 @@ -# See https://docs.travis-ci.com/user/reference/overview/ -dist: bionic - -language: java - -jdk: - - openjdk11 - -env: - global: - # GITHUB_TOKEN value to push changes to GitHub; Currently it is used to update gh-pages. - - secure: "KqPuq9TiiqdOUfGq3k+XYObNjV8FxbgJeqSWK0pcWFFs5w5c4vcGmrfUSSSqNa/JJkKOBWQ6S3tJP7CRxx0uow5BvU4ZQAZLFt6VjzcUZFKGTl5soMTF2gQdyAAcwUnRX2gQKt0doO8Fid6xzfsn1KdTIWXmeqMrcTvC+d7EhxU=" - -deploy: - - provider: script - skip_cleanup: true - script: ./mvnw site -B -Ddownloader.tls.protocols=TLSv1.2,TLSv1.3 - email: jeremylandis@hotmail.com - on: - repo: spotbugs/spotbugs-maven-plugin - branch: spotbugs - jdk: openjdk11 - condition: $TRAVIS_COMMIT_MESSAGE != ^\[maven-release-plugin\]* - - - provider: pages - skip_cleanup: true - github_token: $GITHUB_TOKEN - local_dir: target/site - email: skypencil+spotbugs-bot@gmail.com - on: - repo: spotbugs/spotbugs-maven-plugin - branch: spotbugs - jdk: openjdk11 - condition: $TRAVIS_COMMIT_MESSAGE != ^\[maven-release-plugin\]* From 7d6cbd8869500636c9ed9693fbd15ca29ea2bf1b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:31:08 -0500 Subject: [PATCH 0479/1013] [pom] Bump gmavenplus to 1.12.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 27a9863f8..7ac53e61b 100644 --- a/pom.xml +++ b/pom.xml @@ -142,7 +142,7 @@ 3.0.0 1.8 0.22-1 - 1.12.0 + 1.12.1 3.1.1 3.2.1 3.2.0 From b2f85c64e5e618b3124b330f05e41a5149d9187b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:49:51 -0500 Subject: [PATCH 0480/1013] [pom] Set the source directory for some plugins that don't directly handle groovy --- pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pom.xml b/pom.xml index 7ac53e61b..1c43486b1 100644 --- a/pom.xml +++ b/pom.xml @@ -116,6 +116,8 @@ + ${project.basedir}/src/main/groovy + ${project.version} 5.7.0 From ff95b2b0617bcaea8e6f5cc1a0f1f3ae1c603833 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:55:10 -0500 Subject: [PATCH 0481/1013] [maven] Setup for releasing 'site' from local during release cycle with new pages end point --- .mvn/settings.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.mvn/settings.xml b/.mvn/settings.xml index 5b91cb639..d192f1b36 100644 --- a/.mvn/settings.xml +++ b/.mvn/settings.xml @@ -8,7 +8,11 @@ ${env.CI_DEPLOY_PASSWORD} - gh-pages + gh-pages-scm + + branch + gh-pages + github From f559ece76d52144f6afbf880566938724b7f5a95 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 14:57:56 -0500 Subject: [PATCH 0482/1013] [actions] Turn off coveralls as this project doesn't yet have in-line tests just integration tests, need to figure that out still for coveralls so disable so this stops running for now. --- .github/workflows/coveralls.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 931999a91..53a8bee3d 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -20,7 +20,7 @@ on: [push, pull_request] jobs: build: - if: github.repository_owner == 'spotbugs' + if: github.repository_owner == 'spotbugs-OFF' runs-on: windows-latest steps: - uses: actions/checkout@v2 From e49c19090662ab775848c7c9fbe42c4b7b231893 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 17:00:56 -0500 Subject: [PATCH 0483/1013] Revert "Merge pull request #238 from tkalmar/spotbugs" This reverts commit 2e711898660b8fd3486680fbb72ed849ae76a3a5, reversing changes made to bf0fbab1e844ba5cb64887e992f0327813844b4a. --- .../org/codehaus/mojo/spotbugs/ResourceHelper.groovy | 11 +++++------ .../org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 2 ++ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy index 857b23eb6..fcedf6414 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy @@ -25,8 +25,6 @@ import org.codehaus.plexus.resource.loader.FileResourceLoader import org.codehaus.plexus.resource.ResourceManager import org.codehaus.plexus.util.FileUtils -import java.nio.file.Paths - final class ResourceHelper { Log log @@ -55,11 +53,12 @@ final class ResourceHelper { String location = null String artifact = resource - def file = new File(resource) + if (resource.indexOf(SpotBugsInfo.FORWARD_SLASH) != -1) { + artifact = resource.substring(resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH) + 1) + } - if (file.exists()) { - artifact = file.getName() - location = file.getAbsolutePath() + if (resource.indexOf(SpotBugsInfo.FORWARD_SLASH) != -1) { + location = resource.substring(0, resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH)) } // replace all occurrences of the following characters: ? : & = diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index 3c40ceccd..d66a7fdc8 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -77,6 +77,8 @@ interface SpotBugsInfo { static final String COMMA = "," + static final String FORWARD_SLASH = '/' + /** * The character to separate URL tokens. * From 66fe09c24c70271ba62a59ed8f08f2a39be258da Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 17:28:40 -0500 Subject: [PATCH 0484/1013] [windows] Add fix to support processing properly on windows by not ending up with long c_ path to jar files Fix on #238 only resulted in cleaning up unnecessary copies but made other processing worse. As a result, #238 is being reverted. This patch is to make windows usage behave like linux usage. It still expected to copy the jar files (even if unnecessary) but not nexted into a deep folder structure, rather just the artifact name. The original logic did not handle windows at all. It now does but is still not a great solution. --- .../org/codehaus/mojo/spotbugs/ResourceHelper.groovy | 10 ++++++++++ .../org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy index fcedf6414..fa9b96fcc 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/ResourceHelper.groovy @@ -53,6 +53,7 @@ final class ResourceHelper { String location = null String artifact = resource + // Linux Checks if (resource.indexOf(SpotBugsInfo.FORWARD_SLASH) != -1) { artifact = resource.substring(resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH) + 1) } @@ -61,6 +62,15 @@ final class ResourceHelper { location = resource.substring(0, resource.lastIndexOf(SpotBugsInfo.FORWARD_SLASH)) } + // Windows Checks + if (resource.indexOf(SpotBugsInfo.BACKWARD_SLASH) != -1) { + artifact = resource.substring(resource.lastIndexOf(SpotBugsInfo.BACKWARD_SLASH) + 1) + } + + if (resource.indexOf(SpotBugsInfo.BACKWARD_SLASH) != -1) { + location = resource.substring(0, resource.lastIndexOf(SpotBugsInfo.BACKWARD_SLASH)) + } + // replace all occurrences of the following characters: ? : & = location = location?.replaceAll("[\\?\\:\\&\\=\\%]", "_") artifact = artifact?.replaceAll("[\\?\\:\\&\\=\\%]", "_") diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index d66a7fdc8..a4ff7b221 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -79,6 +79,8 @@ interface SpotBugsInfo { static final String FORWARD_SLASH = '/' + static final String BACKWARD_SLASH = '\\' + /** * The character to separate URL tokens. * From d5ee2c1ecfc2b58940146437c7ea5e03b786f673 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 18:04:56 -0500 Subject: [PATCH 0485/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.2.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 1c43486b1..51c6b772a 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.0-SNAPSHOT + 4.2.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.2.0 GitHub Issues From 6097f032bdfb95e4a388d82c583a840819d3d908 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 18:04:57 -0500 Subject: [PATCH 0486/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 51c6b772a..b43e61b94 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.0 + 4.2.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.2.0 + HEAD GitHub Issues From 84779435b4441e53907d4b7bb63754eecb9cd3be Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 3 Jan 2021 18:15:16 -0500 Subject: [PATCH 0487/1013] [ci] Switch out badge from travis to github actions and add in integration tests --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 5122e9a36..59742bde4 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,7 @@ # Spotbugs Maven Plugin -[![Build Status](https://travis-ci.org/spotbugs/spotbugs-maven-plugin.svg?branch=spotbugs)](https://travis-ci.org/spotbugs/spotbugs-maven-plugin) +[![Java CI](https://github.com/spotbugs/spotbugs-maven-plugin/workflows/Java%20CI/badge.svg)](https://github.com/spotbugs/spotbugs-maven-plugin/actions?query=workflow%3A%22Java+CI%22) +[![Java Integration Tests](https://github.com/spotbugs/spotbugs-maven-plugin/workflows/Java%20Integration%20Tests/badge.svg)](https://github.com/spotbugs/spotbugs-maven-plugin/actions?query=workflow%3A%22Java+Integration+Tests%22) [![Maven central](https://maven-badges.herokuapp.com/maven-central/com.github.spotbugs/spotbugs-maven-plugin/badge.svg)](https://maven-badges.herokuapp.com/maven-central/com.github.spotbugs/spotbugs-maven-plugin) [![Apache 2](https://img.shields.io/badge/license-Apache%202-blue.svg)](https://www.apache.org/licenses/LICENSE-2.0) From b498d5ca95427d3c153c53adf6ece77c5396e69b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 5 Jan 2021 20:41:19 -0500 Subject: [PATCH 0488/1013] [site] Fix site on github actions Not sure exactly how it gets the folder name other than that is part of scm piece site was moved onto for deployment. This sort of made sense it has use of a super pom and the site gets messed up trying to push back to a parent. I would have thought name would work out differently then --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 23961d6c7..a9309bfeb 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -28,6 +28,6 @@ jobs: with: SSH: true BRANCH: gh-pages - FOLDER: target/staging + FOLDER: spotbugs/spotbugs-maven-plugin.git env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From f20be3f2895e1fb00bccb8eb1edb59cf38c01803 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 5 Feb 2021 05:28:20 +0000 Subject: [PATCH 0489/1013] Bump spotbugs from 4.2.0 to 4.2.1 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.0 to 4.2.1. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.0...4.2.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b43e61b94..5d3e29918 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.0 - 4.2.0 + 4.2.1 4.2.0 2.0.0-alpha1 From 88329260615029fbd51e98e279c2580bd72c8928 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 8 Feb 2021 05:43:24 +0000 Subject: [PATCH 0490/1013] Bump asm.version from 9.0 to 9.1 Bumps `asm.version` from 9.0 to 9.1. Updates `asm` from 9.0 to 9.1 Updates `asm-analysis` from 9.0 to 9.1 Updates `asm-commons` from 9.0 to 9.1 Updates `asm-tree` from 9.0 to 9.1 Updates `asm-util` from 9.0 to 9.1 Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5d3e29918..a39973e43 100644 --- a/pom.xml +++ b/pom.xml @@ -178,7 +178,7 @@ 5.10.0.202012080955-r - 9.0 + 9.1 1.9.4 1.2 1.15 From d689621742517ff4b3dd3a22c4e64b74ed74ef7a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 22 Feb 2021 05:47:35 +0000 Subject: [PATCH 0491/1013] Bump maven-invoker-plugin from 3.2.1 to 3.2.2 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/apache/maven-invoker-plugin/releases) - [Commits](https://github.com/apache/maven-invoker-plugin/compare/maven-invoker-plugin-3.2.1...maven-invoker-plugin-3.2.2) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a39973e43..7c2985037 100644 --- a/pom.xml +++ b/pom.xml @@ -146,7 +146,7 @@ 0.22-1 1.12.1 3.1.1 - 3.2.1 + 3.2.2 3.2.0 3.6.0 1.11.2 From 051b6cb9306689cc45b956bcea6eee17f7c07060 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 2 Mar 2021 05:10:08 +0000 Subject: [PATCH 0492/1013] Bump commons-lang3 from 3.11 to 3.12.0 Bumps commons-lang3 from 3.11 to 3.12.0. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7c2985037..c41f03848 100644 --- a/pom.xml +++ b/pom.xml @@ -185,7 +185,7 @@ 3.2.2 2.1 2.8.0 - 3.11 + 3.12.0 From 25f71b8e7cf6bad46dafe7190c63f52637306a4c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 3 Mar 2021 05:11:34 +0000 Subject: [PATCH 0493/1013] Bump spotbugs from 4.2.1 to 4.2.2 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.1 to 4.2.2. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.1...4.2.2) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c41f03848..dd1b9ccbd 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.0 - 4.2.1 + 4.2.2 4.2.0 2.0.0-alpha1 From e37eb512a557e350eeee2458017ef87e6d14e508 Mon Sep 17 00:00:00 2001 From: cindyoliver-se Date: Fri, 19 Mar 2021 12:42:29 +0800 Subject: [PATCH 0494/1013] fix issue306 --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 6b740b809..d5adea5c4 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1062,7 +1062,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } if (debug || trace) { - sysproperty(key: "spotbugs.debug", value: true) + sysproperty(key: "findbugs.debug", value: true) } classpath() { From cfb8fdb5131475aff9e1d8a4e2ba0551a7e48ded Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun, 21 Mar 2021 22:52:53 +0000 Subject: [PATCH 0495/1013] Bump jgit.version from 5.10.0.202012080955-r to 5.11.0.202103091610-r Bumps `jgit.version` from 5.10.0.202012080955-r to 5.11.0.202103091610-r. Updates `org.eclipse.jgit` from 5.10.0.202012080955-r to 5.11.0.202103091610-r Updates `org.eclipse.jgit.ssh.jsch` from 5.10.0.202012080955-r to 5.11.0.202103091610-r Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dd1b9ccbd..a584c74dd 100644 --- a/pom.xml +++ b/pom.xml @@ -175,7 +175,7 @@ 4.0.4 7.4.7 - 5.10.0.202012080955-r + 5.11.0.202103091610-r 9.1 From 0f6288db3a82033505a9f9ee27973d36bb8bb991 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 21 Mar 2021 23:16:48 -0400 Subject: [PATCH 0496/1013] [pom] Add some additional notes to revisit getting off legacy support when spotbugs gets to 4.3 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index a584c74dd..335f5cfe4 100644 --- a/pom.xml +++ b/pom.xml @@ -135,7 +135,7 @@ 0.13.1 3.0 3.0.0 - 3.5.2 + 3.5.2 2.1.0 1.1.0 @@ -151,7 +151,7 @@ 3.6.0 1.11.2 3.9.1 - 3.6 + 3.6 2.8.1 false From 9609a1af6e928ce6d5cb2d263d47e64850e78c49 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 21 Mar 2021 23:17:00 -0400 Subject: [PATCH 0497/1013] [pom] Bump spotbugs to 4.2.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 335f5cfe4..791e19503 100644 --- a/pom.xml +++ b/pom.xml @@ -122,7 +122,7 @@ 5.7.0 4.2.2 - 4.2.0 + 4.2.2 2.0.0-alpha1 1.10.9 From bef37f63d2d1ca9834e9a91e6b011c0ae2ac80c8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 21 Mar 2021 23:49:59 -0400 Subject: [PATCH 0498/1013] [maven-release-plugin] prepare release 4.2.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 791e19503..74bb21744 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.1-SNAPSHOT + 4.2.2 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + 4.2.2 GitHub Issues From 063974565e40d2829b6a80db7c6c6547b63d483e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 21 Mar 2021 23:50:00 -0400 Subject: [PATCH 0499/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 74bb21744..063e6d693 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.2 + 4.2.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - 4.2.2 + HEAD GitHub Issues From a39ea77c9f14edca7740d9142c36c738bf263cac Mon Sep 17 00:00:00 2001 From: sullis Date: Sun, 28 Mar 2021 09:59:05 -0700 Subject: [PATCH 0500/1013] ci: add JDK 16 --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7f8b9a105..ebffca208 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 15] + java: [8, 11, 15, 16] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From b66fa99ae4f0f2df8c97105b735d3fbafa23dff6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 11 Apr 2021 14:22:38 -0400 Subject: [PATCH 0501/1013] [pom] Bump base-parent to 28 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 063e6d693..f90d1c5df 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 27 + 28 From 15342e83c94acc8cd8691725d83a2b00ff94d505 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 11 Apr 2021 14:23:25 -0400 Subject: [PATCH 0502/1013] [actions] Drop jdk 15 --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ebffca208..c09ea2d7d 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 15, 16] + java: [8, 11, 16] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From adbb54a14cdb7a7a83f6ae451fb3b15afa7c2fa3 Mon Sep 17 00:00:00 2001 From: sullis Date: Sun, 11 Apr 2021 14:01:06 -0700 Subject: [PATCH 0503/1013] [actions] setup-java v2 --- .github/workflows/ci.yaml | 3 ++- .github/workflows/coveralls.yaml | 3 ++- .github/workflows/coverity.yaml | 3 ++- .github/workflows/it.yaml | 3 ++- .github/workflows/site.yaml | 3 ++- .github/workflows/sonar.yaml | 3 ++- .github/workflows/sonatype.yaml | 3 ++- 7 files changed, 14 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index c09ea2d7d..736e89164 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -16,8 +16,9 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: ${{ matrix.java }} + distribution: 'zulu' - name: Test with Maven run: ./mvnw test -B diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 53a8bee3d..0e3d5d44b 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -25,9 +25,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - name: Report Coverage to Coveralls for Pull Requests if: github.event_name == 'pull_request' run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml index 8d7aa13a2..fb4f575d8 100644 --- a/.github/workflows/coverity.yaml +++ b/.github/workflows/coverity.yaml @@ -12,9 +12,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - name: Analyze with Coverity run: | wget -q https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_TOKEN&project=spotbugs%2Fspotbugs-maven-plugin" -O coverity_tool.tgz diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml index 520976090..020183f1b 100644 --- a/.github/workflows/it.yaml +++ b/.github/workflows/it.yaml @@ -28,9 +28,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - name: Build Setup run: ./mvnw clean install - name: Integration Test with Maven diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index a9309bfeb..0e64d256e 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -12,9 +12,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - uses: webfactory/ssh-agent@master with: ssh-private-key: ${{ secrets.DEPLOY_KEY }} diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index c5a4743d5..339ea53dd 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -15,9 +15,10 @@ jobs: # Disabling shallow clone is recommended for improving relevancy of reporting fetch-depth: 0 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - name: Analyze with SonarCloud run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" env: diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index d30af7834..13dcffa8f 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -12,9 +12,10 @@ jobs: steps: - uses: actions/checkout@v2 - name: Set up JDK - uses: actions/setup-java@v1 + uses: actions/setup-java@v2 with: java-version: 11 + distribution: 'zulu' - name: Deploy to Sonatype run: ./mvnw deploy -DskipTests -B --settings ./.mvn/settings.xml env: From 6750230f64e25b957db4639f713508423c777a47 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 16 Apr 2021 05:23:58 +0000 Subject: [PATCH 0504/1013] Bump spotbugs from 4.2.2 to 4.2.3 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.2 to 4.2.3. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.2...4.2.3) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f90d1c5df..e6c00dd81 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.0 - 4.2.2 + 4.2.3 4.2.2 2.0.0-alpha1 From 52d45f6472696f8a294a0a3e867ad69784297077 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:09:24 -0400 Subject: [PATCH 0505/1013] [actions] Move coveralls to ubuntu so it works --- .github/workflows/coveralls.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 0e3d5d44b..05af3f4b9 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -21,7 +21,7 @@ on: [push, pull_request] jobs: build: if: github.repository_owner == 'spotbugs-OFF' - runs-on: windows-latest + runs-on: ubuntu-latest steps: - uses: actions/checkout@v2 - name: Set up JDK From b95aa1972c436121b43008b57e6957a76ae1284c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:11:01 -0400 Subject: [PATCH 0506/1013] [pom] Bump junit to 5.7.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e6c00dd81..9197753b7 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ ${project.version} - 5.7.0 + 5.7.1 4.2.3 4.2.2 2.0.0-alpha1 From c4f5bc1c83e5ff37936c5465ba51c53c79f29ede Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:11:16 -0400 Subject: [PATCH 0507/1013] [pom] BUmp spotbugs tag to 4.2.3 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9197753b7..817e48251 100644 --- a/pom.xml +++ b/pom.xml @@ -122,7 +122,7 @@ 5.7.1 4.2.3 - 4.2.2 + 4.2.3 2.0.0-alpha1 1.10.9 From ae9844c2fa333b82ab055722aaecae0810603f83 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:18:26 -0400 Subject: [PATCH 0508/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.2.3 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 817e48251..0e5b83cc9 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.3-SNAPSHOT + 4.2.3 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.2.3 GitHub Issues From 03f99d37b18fa24335ad02f3e6c8e4b0c12a6061 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:18:27 -0400 Subject: [PATCH 0509/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0e5b83cc9..9765c5d15 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.3 + 4.2.4-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.2.3 + HEAD GitHub Issues From 0e3d99e43ec5966697c9f88d3b173ad99a764a3e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 16 Apr 2021 21:25:03 -0400 Subject: [PATCH 0510/1013] [pom] Remove the release plugin overrides as its ok to push changes immediately --- pom.xml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pom.xml b/pom.xml index 9765c5d15..27908c34d 100644 --- a/pom.xml +++ b/pom.xml @@ -669,14 +669,6 @@ true - - org.apache.maven.plugins - maven-release-plugin - - false - true - - From bd35116a6de47afbee11fb4d536f9d481b403e38 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 20 Apr 2021 05:19:54 +0000 Subject: [PATCH 0511/1013] Bump groovyVersion from 3.0.7 to 3.0.8 Bumps `groovyVersion` from 3.0.7 to 3.0.8. Updates `groovy` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.7 to 3.0.8 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 27908c34d..c8bbe232c 100644 --- a/pom.xml +++ b/pom.xml @@ -126,7 +126,7 @@ 2.0.0-alpha1 1.10.9 - 3.0.7 + 3.0.8 1.9.1 1.9.2 From 0b576078c15f2e5ba92bf2f97180f6cd516380be Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 20 Apr 2021 16:03:39 +0000 Subject: [PATCH 0512/1013] Bump ant from 1.10.9 to 1.10.10 Bumps ant from 1.10.9 to 1.10.10. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c8bbe232c..9d59a93e7 100644 --- a/pom.xml +++ b/pom.xml @@ -125,7 +125,7 @@ 4.2.3 2.0.0-alpha1 - 1.10.9 + 1.10.10 3.0.8 1.9.1 From 79d12355e211659aba6e0a8b49089589511b58b1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 27 Apr 2021 05:24:08 +0000 Subject: [PATCH 0513/1013] Bump pluginPluginVersion from 3.6.0 to 3.6.1 Bumps `pluginPluginVersion` from 3.6.0 to 3.6.1. Updates `maven-plugin-annotations` from 3.6.0 to 3.6.1 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1) Updates `maven-plugin-plugin` from 3.6.0 to 3.6.1 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.0...maven-plugin-tools-3.6.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9d59a93e7..fd5376f27 100644 --- a/pom.xml +++ b/pom.xml @@ -148,7 +148,7 @@ 3.1.1 3.2.2 3.2.0 - 3.6.0 + 3.6.1 1.11.2 3.9.1 3.6 From f82016489db6eb74984bdafe78b395ec040c8018 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 3 May 2021 05:41:32 +0000 Subject: [PATCH 0514/1013] Bump maven-project-info-reports-plugin from 3.1.1 to 3.1.2 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.1 to 3.1.2. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.1.1...maven-project-info-reports-plugin-3.1.2) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fd5376f27..fdb0f91ba 100644 --- a/pom.xml +++ b/pom.xml @@ -145,7 +145,7 @@ 1.8 0.22-1 1.12.1 - 3.1.1 + 3.1.2 3.2.2 3.2.0 3.6.1 From d32d011ec7b979a50c341f309facde5368ca4c17 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81d=C3=A1m=20Balogh?= Date: Wed, 12 May 2021 14:17:23 +0200 Subject: [PATCH 0515/1013] Add configuration parameter systemPropertyVariables Some SpotBugs plugins such as FindSecBugs take their options using system properties. These system properties can be set either before calling Maven (as environmental variables) or as the parameter to Maven (using the -D command line option). However, for many users the best way is to include these option to pom.xml. This patch makes it possible for the SpotBugs Maven plugin using configuration parameter systemPropertyVariables. --- .../invoker.properties | 4 ++ src/it/systemPropertyVariables/pom.xml | 53 +++++++++++++++++++ src/it/systemPropertyVariables/verify.groovy | 18 +++++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 15 ++++++ 4 files changed, 90 insertions(+) create mode 100644 src/it/systemPropertyVariables/invoker.properties create mode 100644 src/it/systemPropertyVariables/pom.xml create mode 100644 src/it/systemPropertyVariables/verify.groovy diff --git a/src/it/systemPropertyVariables/invoker.properties b/src/it/systemPropertyVariables/invoker.properties new file mode 100644 index 000000000..7fbf7d99f --- /dev/null +++ b/src/it/systemPropertyVariables/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile site + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/systemPropertyVariables/pom.xml b/src/it/systemPropertyVariables/pom.xml new file mode 100644 index 000000000..e2d901322 --- /dev/null +++ b/src/it/systemPropertyVariables/pom.xml @@ -0,0 +1,53 @@ + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + systemPropertyVariables + systemPropertyVariables + jar + + true + + + com.github.spotbugs + spotbugs-maven-plugin + + + true + + + true + true + + + com.h3xstream.findsecbugs + findsecbugs-plugin + @findsecbugsVersion@ + + + + + + + diff --git a/src/it/systemPropertyVariables/verify.groovy b/src/it/systemPropertyVariables/verify.groovy new file mode 100644 index 000000000..1d5d6a834 --- /dev/null +++ b/src/it/systemPropertyVariables/verify.groovy @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.text.contains( '[java] INFO: System variables are considered to be tainted' ) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index d5adea5c4..ddd7145b1 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -520,6 +520,16 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(property = "spotbugs.userPrefs") String userPrefs + /** + *

+ * System properties to set in the VM (or the forked VM if fork is enabled). + *

+ * + * @since 4.2.4 + */ + @Parameter(property = "spotbugs.systemPropertyVariables") + Map systemPropertyVariables + int bugCount int errorCount @@ -1079,6 +1089,11 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { arg(value: spotbugsArg) } + systemPropertyVariables.each { sysProp -> + log.debug("System property ${sysProp.key} is ${sysProp.value}") + sysproperty(key: sysProp.key, value: sysProp.value) + } + } if (log.isDebugEnabled()) { From 6768e81358c11d2af1597b05fe868006203c68ff Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 17 May 2021 05:47:19 +0000 Subject: [PATCH 0516/1013] Bump jgit.version from 5.11.0.202103091610-r to 5.11.1.202105131744-r Bumps `jgit.version` from 5.11.0.202103091610-r to 5.11.1.202105131744-r. Updates `org.eclipse.jgit` from 5.11.0.202103091610-r to 5.11.1.202105131744-r Updates `org.eclipse.jgit.ssh.jsch` from 5.11.0.202103091610-r to 5.11.1.202105131744-r Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fdb0f91ba..2c9879758 100644 --- a/pom.xml +++ b/pom.xml @@ -175,7 +175,7 @@ 4.0.4 7.4.7 - 5.11.0.202103091610-r + 5.11.1.202105131744-r 9.1 From 43fcb930b8bad971e221866974ab130538245a19 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 24 May 2021 05:42:04 +0000 Subject: [PATCH 0517/1013] Bump maven-javadoc-plugin from 3.2.0 to 3.3.0 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.2.0 to 3.3.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.2.0...maven-javadoc-plugin-3.3.0) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2c9879758..0e67230b2 100644 --- a/pom.xml +++ b/pom.xml @@ -147,7 +147,7 @@ 1.12.1 3.1.2 3.2.2 - 3.2.0 + 3.3.0 3.6.1 1.11.2 3.9.1 From 096f0cd9aa6a40ad5313bc2586f05b1b4de83ecf Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 26 May 2021 05:04:52 +0000 Subject: [PATCH 0518/1013] Bump commons-io from 2.8.0 to 2.9.0 Bumps commons-io from 2.8.0 to 2.9.0. Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0e67230b2..daa772356 100644 --- a/pom.xml +++ b/pom.xml @@ -184,7 +184,7 @@ 1.15 3.2.2 2.1 - 2.8.0 + 2.9.0 3.12.0 From bf81b270aec914f81a112c115b588f00ae9222cd Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 8 Jun 2021 05:07:54 +0000 Subject: [PATCH 0519/1013] Bump jgit.version from 5.11.1.202105131744-r to 5.12.0.202106070339-r Bumps `jgit.version` from 5.11.1.202105131744-r to 5.12.0.202106070339-r. Updates `org.eclipse.jgit` from 5.11.1.202105131744-r to 5.12.0.202106070339-r Updates `org.eclipse.jgit.ssh.jsch` from 5.11.1.202105131744-r to 5.12.0.202106070339-r --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.eclipse.jgit:org.eclipse.jgit.ssh.jsch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index daa772356..3bcb15520 100644 --- a/pom.xml +++ b/pom.xml @@ -175,7 +175,7 @@ 4.0.4 7.4.7 - 5.11.1.202105131744-r + 5.12.0.202106070339-r 9.1 From fb638bb96017e78acb1d84c2c884e84b58cf511e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 14 Jun 2021 05:58:05 +0000 Subject: [PATCH 0520/1013] Bump commons-io from 2.9.0 to 2.10.0 Bumps commons-io from 2.9.0 to 2.10.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3bcb15520..3f4230cbf 100644 --- a/pom.xml +++ b/pom.xml @@ -184,7 +184,7 @@ 1.15 3.2.2 2.1 - 2.9.0 + 2.10.0 3.12.0 From 608892afcde7379c72a30553d6ae4767ac25f873 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 25 Jun 2021 19:01:15 +0000 Subject: [PATCH 0521/1013] Bump doxiaVersion from 1.9.1 to 1.10 Bumps `doxiaVersion` from 1.9.1 to 1.10. Updates `doxia-core` from 1.9.1 to 1.10 - [Release notes](https://github.com/apache/maven-doxia/releases) - [Commits](https://github.com/apache/maven-doxia/compare/doxia-1.9.1...doxia-1.10) Updates `doxia-sink-api` from 1.9.1 to 1.10 - [Release notes](https://github.com/apache/maven-doxia/releases) - [Commits](https://github.com/apache/maven-doxia/compare/doxia-1.9.1...doxia-1.10) --- updated-dependencies: - dependency-name: org.apache.maven.doxia:doxia-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-sink-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 3f4230cbf..8339134a2 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.10.10 3.0.8 - 1.9.1 + 1.10 1.9.2 3.2.5 From 16675bed90fa28c0d6df7fecf42756f721343493 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 28 Jun 2021 19:01:26 +0000 Subject: [PATCH 0522/1013] Bump asm.version from 9.1 to 9.2 Bumps `asm.version` from 9.1 to 9.2. Updates `asm` from 9.1 to 9.2 Updates `asm-analysis` from 9.1 to 9.2 Updates `asm-commons` from 9.1 to 9.2 Updates `asm-tree` from 9.1 to 9.2 Updates `asm-util` from 9.1 to 9.2 --- updated-dependencies: - dependency-name: org.ow2.asm:asm dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-analysis dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-commons dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-tree dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-util dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8339134a2..7056740f2 100644 --- a/pom.xml +++ b/pom.xml @@ -178,7 +178,7 @@ 5.12.0.202106070339-r - 9.1 + 9.2 1.9.4 1.2 1.15 From a0199d534011091c800dd76bf692789f02b75ad9 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 1 Jul 2021 19:02:18 +0000 Subject: [PATCH 0523/1013] Bump doxiaSiteToolsVersion from 1.9.2 to 1.10 Bumps `doxiaSiteToolsVersion` from 1.9.2 to 1.10. Updates `doxia-decoration-model` from 1.9.2 to 1.10 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.9.2...doxia-sitetools-1.10) Updates `doxia-site-renderer` from 1.9.2 to 1.10 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.9.2...doxia-sitetools-1.10) Updates `doxia-integration-tools` from 1.9.2 to 1.10 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.9.2...doxia-sitetools-1.10) --- updated-dependencies: - dependency-name: org.apache.maven.doxia:doxia-decoration-model dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-site-renderer dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-integration-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7056740f2..6719b157f 100644 --- a/pom.xml +++ b/pom.xml @@ -129,7 +129,7 @@ 3.0.8 1.10 - 1.9.2 + 1.10 3.2.5 0.13.1 From f1832b0039e25bdec054b2aebdca85e5cb5c19a8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 1 Jul 2021 21:08:45 +0000 Subject: [PATCH 0524/1013] Bump mavenVersion from 3.5.2 to 3.8.1 Bumps `mavenVersion` from 3.5.2 to 3.8.1. Updates `maven-plugin-api` from 3.5.2 to 3.8.1 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.5.2...maven-3.8.1) Updates `maven-artifact` from 3.5.2 to 3.8.1 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.5.2...maven-3.8.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6719b157f..9d1a284ce 100644 --- a/pom.xml +++ b/pom.xml @@ -135,7 +135,7 @@ 0.13.1 3.0 3.0.0 - 3.5.2 + 3.8.1 2.1.0 1.1.0 From 787d0374f81c747bd3a48b57ec171d1af6c563b4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 1 Jul 2021 21:08:50 +0000 Subject: [PATCH 0525/1013] Bump maven-core from 3.2.5 to 3.8.1 Bumps [maven-core](https://github.com/apache/maven) from 3.2.5 to 3.8.1. - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.2.5...maven-3.8.1) Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6719b157f..c8159a7cd 100644 --- a/pom.xml +++ b/pom.xml @@ -131,7 +131,7 @@ 1.10 1.10 - 3.2.5 + 3.8.1 0.13.1 3.0 3.0.0 From 9f1fdbf2570793931275e53eb431b34e976d3445 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 2 Jul 2021 19:01:36 +0000 Subject: [PATCH 0526/1013] Bump slf4jVersion from 2.0.0-alpha1 to 2.0.0-alpha2 Bumps `slf4jVersion` from 2.0.0-alpha1 to 2.0.0-alpha2. Updates `jcl-over-slf4j` from 2.0.0-alpha1 to 2.0.0-alpha2 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits) Updates `slf4j-simple` from 2.0.0-alpha1 to 2.0.0-alpha2 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits) Updates `slf4j-api` from 2.0.0-alpha1 to 2.0.0-alpha2 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6719b157f..ff4dfc09a 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 5.7.1 4.2.3 4.2.3 - 2.0.0-alpha1 + 2.0.0-alpha2 1.10.10 3.0.8 From 555efeeffe15b9ec4919fed1e452122c22ae1d2a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 2 Jul 2021 19:01:51 +0000 Subject: [PATCH 0527/1013] Bump spotbugs from 4.2.3 to 4.3.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.2.3 to 4.3.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.2.3...4.3.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6719b157f..159caee36 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.1 - 4.2.3 + 4.3.0 4.2.3 2.0.0-alpha1 From 8ebfd75f70571ebfffae7781dae3783547fba007 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 3 Jul 2021 15:38:48 -0400 Subject: [PATCH 0528/1013] [ci] Update since date as we switched to 4.3.x --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index ddd7145b1..3d41ca1eb 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -525,7 +525,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * System properties to set in the VM (or the forked VM if fork is enabled). *

* - * @since 4.2.4 + * @since 4.3.0 */ @Parameter(property = "spotbugs.systemPropertyVariables") Map systemPropertyVariables From 92876e8d7091b4e5a572178807d835636add3294 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 3 Jul 2021 15:40:08 -0400 Subject: [PATCH 0529/1013] [pom] Remove old maven comment as we are now going to latest 3.8.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ad96ad6f9..f3f45f952 100644 --- a/pom.xml +++ b/pom.xml @@ -135,7 +135,7 @@ 0.13.1 3.0 3.0.0 - 3.8.1 + 3.8.1 2.1.0 1.1.0 From c9733e9bb4f4545a14e2bed2147f17f9e20d1ca6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 3 Jul 2021 15:40:20 -0400 Subject: [PATCH 0530/1013] [pom] Bump spotbugs to 4.3.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f3f45f952..96176af9f 100644 --- a/pom.xml +++ b/pom.xml @@ -122,7 +122,7 @@ 5.7.1 4.3.0 - 4.2.3 + 4.3.0 2.0.0-alpha2 1.10.10 From a32d2b36c5679a16f776486913d7d2484cbc5225 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 9 Jul 2021 23:49:06 -0400 Subject: [PATCH 0531/1013] [pom] Bump junit to 5.7.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 96176af9f..5e04371f1 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ ${project.version} - 5.7.1 + 5.7.2 4.3.0 4.3.0 2.0.0-alpha2 From 5530040d7940f5326f844f2ef38b8e487da1537b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 9 Jul 2021 23:53:39 -0400 Subject: [PATCH 0532/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.3.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 5e04371f1..11cc39a19 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.2.4-SNAPSHOT + 4.3.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.3.0 GitHub Issues From d06e99448168d7a0252db8e1f7f7c492225f0cf2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 9 Jul 2021 23:53:45 -0400 Subject: [PATCH 0533/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 11cc39a19..0ab86fc66 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.3.0 + 4.3.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.3.0 + HEAD GitHub Issues From 00d51ee6392841806601c354df08c69d9a468996 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 13 Jul 2021 19:01:17 +0000 Subject: [PATCH 0534/1013] Bump commons-io from 2.10.0 to 2.11.0 Bumps commons-io from 2.10.0 to 2.11.0. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0ab86fc66..5ada094d7 100644 --- a/pom.xml +++ b/pom.xml @@ -184,7 +184,7 @@ 1.15 3.2.2 2.1 - 2.10.0 + 2.11.0 3.12.0 From 02a2c8b56d4a733157f063788a91044ac3ba20eb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 13 Jul 2021 19:01:20 +0000 Subject: [PATCH 0535/1013] Bump ant from 1.10.10 to 1.10.11 Bumps ant from 1.10.10 to 1.10.11. --- updated-dependencies: - dependency-name: org.apache.ant:ant dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0ab86fc66..fe803fb7c 100644 --- a/pom.xml +++ b/pom.xml @@ -125,7 +125,7 @@ 4.3.0 2.0.0-alpha2 - 1.10.10 + 1.10.11 3.0.8 1.10 From 9c512844d5a8a5320295972884d5fc9f0ee9ccf3 Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Thu, 29 Jul 2021 09:43:43 -0400 Subject: [PATCH 0536/1013] Add support for SARIF format with the argument -Dspotbugs.sarifOutput=true --- pom.xml | 13 +++ .../mojo/spotbugs/SpotBugsMojo.groovy | 80 ++++++++++++++----- 2 files changed, 75 insertions(+), 18 deletions(-) diff --git a/pom.xml b/pom.xml index 934761afd..64b109ab9 100644 --- a/pom.xml +++ b/pom.xml @@ -329,6 +329,19 @@ + + org.codehaus.groovy + groovy-json + ${groovyVersion} + indy + + + org.codehaus.groovy + groovy + + + + org.apache.maven.reporting maven-reporting-impl diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 3d41ca1eb..7be2b5dd2 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -19,10 +19,9 @@ package org.codehaus.mojo.spotbugs * under the License. */ +import groovy.json.JsonSlurper import groovy.xml.XmlSlurper import groovy.xml.StreamingMarkupBuilder - -import org.apache.maven.artifact.Artifact import org.apache.maven.artifact.repository.ArtifactRepository import org.apache.maven.doxia.siterenderer.Renderer @@ -32,8 +31,7 @@ import org.apache.maven.execution.MavenSession import org.apache.maven.plugin.MojoExecutionException -import org.apache.maven.plugins.annotations.Component; -import org.apache.maven.plugins.annotations.LifecyclePhase +import org.apache.maven.plugins.annotations.Component import org.apache.maven.plugins.annotations.Mojo import org.apache.maven.plugins.annotations.Parameter import org.apache.maven.plugins.annotations.ResolutionScope @@ -46,7 +44,6 @@ import org.apache.maven.repository.RepositorySystem import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResolver import org.codehaus.plexus.resource.ResourceManager -import org.codehaus.plexus.resource.loader.FileResourceCreationException import org.codehaus.plexus.resource.loader.FileResourceLoader /** @@ -71,6 +68,16 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(defaultValue = "false", property = "spotbugs.xmlOutput", required = true) boolean xmlOutput + /** + * Turn on and off SARIF output of the Spotbugs report. + * SARIF is a JSON format standardize for all code scanning tools. + * https://docs.github.com/en/code-security/secure-coding/integrating-with-code-scanning/sarif-support-for-code-scanning + * + * @since 4.3.1 + */ + @Parameter(defaultValue = "false", property = "spotbugs.sarifOutput", required = true) + boolean sarifOutput + /** * Specifies the directory where the xml output will be generated. * @@ -845,7 +852,12 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << resourceHelper.getResourceFile(userPrefs.trim()) } - args << "-xml:withMessages" + if(!sarifOutput) { + args << "-xml:withMessages" + } + else { + args << "-sarif" + } args << "-auxclasspathFromInput" @@ -1000,6 +1012,21 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { return auxClasspath } + /** + * For the file creation by creating the file AND folder if needed. + * The file created will be empty. + * + * @param file Destination file to create. + */ + private void forceFileCreation(File file) { + if (file.exists()) { + file.delete() + } + + file.getParentFile().mkdirs() + file.createNewFile() + } + /** * Set up and run the Spotbugs engine. * @@ -1012,14 +1039,16 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("****** SpotBugsMojo executeSpotbugs *******") long startTime, duration - File tempFile = new File("${project.build.directory}/spotbugsTemp.xml") + File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") + File sarifTempFile = new File("${project.build.directory}/spotbugsSarif.json") - if (tempFile.exists()) { - tempFile.delete() + if (xmlOutput || !sarifOutput) { + forceFileCreation(xmlTempFile) + } + else { + forceFileCreation(sarifTempFile) } - tempFile.getParentFile().mkdirs() - tempFile.createNewFile() outputEncoding = outputEncoding ?: 'UTF-8' @@ -1035,7 +1064,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug(" Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") log.debug("outputFile is " + outputFile.getCanonicalPath()) log.debug("output Directory is " + spotbugsXmlOutputDirectory.getAbsolutePath()) - log.debug("Temp File is " + tempFile.getCanonicalPath()) + log.debug("Temp File is " + xmlTempFile.getCanonicalPath()) } def ant = new AntBuilder() @@ -1046,7 +1075,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { startTime = System.nanoTime() } - def spotbugsArgs = getSpotbugsArgs(tempFile) + def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifTempFile) def effectiveEncoding = System.getProperty("file.encoding", "UTF-8") @@ -1055,7 +1084,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } ant.java(classname: "edu.umd.cs.findbugs.FindBugs2", inputstring: getSpotbugsAuxClasspath(), fork: "${fork}", failonerror: "true", clonevm: "false", timeout: "${timeout}", maxmemory: "${maxHeap}m") { - + //this.executeSpotbugs() log.debug("File Encoding is " + effectiveEncoding) sysproperty(key: "file.encoding", value: effectiveEncoding) @@ -1103,10 +1132,10 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.info("Done SpotBugs Analysis....") - if (tempFile.exists()) { + if (xmlTempFile.exists() && !sarifOutput) { - if (tempFile.size() > 0) { - def path = new XmlSlurper().parse(tempFile) + if (xmlTempFile.size() > 0) { + def path = new XmlSlurper().parse(xmlTempFile) def allNodes = path.depthFirst().collect { it } @@ -1159,11 +1188,26 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } if (!log.isDebugEnabled()) { - tempFile.delete() + xmlTempFile.delete() } } + if(sarifTempFile && sarifOutput) { + if (sarifTempFile.size() > 0) { + def path = new JsonSlurper().parse(sarifTempFile) + + try { + + def results = path.runs.results[0] + log.debug("BugInstance size is ${results.size()}") + } + catch (Exception e) { + log.error("Unexpected format for the file $sarifTempFile",e) + } + } + } + } /** From 0aaac98615c54ded66d28fbcc1c5806147510497 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 29 Jul 2021 19:01:23 +0000 Subject: [PATCH 0537/1013] Bump plexus-utils from 3.3.0 to 3.4.0 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.3.0...plexus-utils-3.4.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 934761afd..390270537 100644 --- a/pom.xml +++ b/pom.xml @@ -139,7 +139,7 @@ 2.1.0 1.1.0 - 3.3.0 + 3.4.0 3.0.0 1.8 From e5ad8f2138752c0590cfbc73e15fc56c1c937849 Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Fri, 30 Jul 2021 15:27:16 -0400 Subject: [PATCH 0538/1013] Change output to show SARIF file when debug is enable. +Minor refactoring for the same code block --- .../org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 7be2b5dd2..5540cd6b4 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1060,11 +1060,11 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { resourceManager.setOutputDirectory(new File(project.getBuild().getDirectory())) if (log.isDebugEnabled()) { - log.debug("resourceManager outputDirectory is ${resourceManager.outputDirectory}") - log.debug(" Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") - log.debug("outputFile is " + outputFile.getCanonicalPath()) - log.debug("output Directory is " + spotbugsXmlOutputDirectory.getAbsolutePath()) - log.debug("Temp File is " + xmlTempFile.getCanonicalPath()) + log.debug("resourceManager.outputDirectory is ${resourceManager.outputDirectory}") + log.debug("Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") + log.debug("outputFile is ${outputFile.getCanonicalPath()}") + log.debug("output Directory is ${spotbugsXmlOutputDirectory.getAbsolutePath()}") + log.debug("TempFile is ${(sarifOutput ? sarifTempFile : xmlTempFile).getCanonicalPath()}"); } def ant = new AntBuilder() From cd0db6c94addfaa9bdd3bfdd456518d5af2a3dfe Mon Sep 17 00:00:00 2001 From: Michael Keppler Date: Sat, 7 Aug 2021 16:09:11 +0200 Subject: [PATCH 0539/1013] Fix typo --- src/site/fml/faq.fml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml index 250becf39..fbd15e851 100644 --- a/src/site/fml/faq.fml +++ b/src/site/fml/faq.fml @@ -30,7 +30,7 @@

- You can also use the fork option which will for a new JVM. You then use the maxHeap option to control the heap size.

+ You can also use the fork option which will fork a new JVM. You then use the maxHeap option to control the heap size.

From 514eb1a8075cef2bf7fad1b1d0c9f4e8f7004003 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 10 Aug 2021 19:01:55 +0000 Subject: [PATCH 0540/1013] Bump slf4jVersion from 2.0.0-alpha2 to 2.0.0-alpha3 Bumps `slf4jVersion` from 2.0.0-alpha2 to 2.0.0-alpha3. Updates `jcl-over-slf4j` from 2.0.0-alpha2 to 2.0.0-alpha3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits/v_2.0.0-alpha3) Updates `slf4j-simple` from 2.0.0-alpha2 to 2.0.0-alpha3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits/v_2.0.0-alpha3) Updates `slf4j-api` from 2.0.0-alpha2 to 2.0.0-alpha3 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/commits/v_2.0.0-alpha3) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 390270537..e7707428b 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 5.7.2 4.3.0 4.3.0 - 2.0.0-alpha2 + 2.0.0-alpha3 1.10.11 3.0.8 From b7438dbf1cb4c57326054057fae0d8e09e5da95f Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Tue, 10 Aug 2021 15:38:11 -0400 Subject: [PATCH 0541/1013] Add an integration test for SARIF support --- .gitignore | 1 + src/it/sarif-1/invoker.properties | 4 +++ src/it/sarif-1/pom.xml | 48 +++++++++++++++++++++++++++++++ src/it/sarif-1/verify.groovy | 36 +++++++++++++++++++++++ 4 files changed, 89 insertions(+) create mode 100644 src/it/sarif-1/invoker.properties create mode 100644 src/it/sarif-1/pom.xml create mode 100644 src/it/sarif-1/verify.groovy diff --git a/.gitignore b/.gitignore index 0a6ebbc0f..9a39a682a 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,7 @@ .project .settings target/ +.idea/ *.ipr *.iws *.iml diff --git a/src/it/sarif-1/invoker.properties b/src/it/sarif-1/invoker.properties new file mode 100644 index 000000000..ccba96b66 --- /dev/null +++ b/src/it/sarif-1/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile compiler:testCompile site + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/sarif-1/pom.xml b/src/it/sarif-1/pom.xml new file mode 100644 index 000000000..5a201afa8 --- /dev/null +++ b/src/it/sarif-1/pom.xml @@ -0,0 +1,48 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + sarif-1 + sarif-1 + jar + + true + + + org.apache.maven.plugins + maven-jxr-plugin + @jxrPluginVersion@ + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + + + + + diff --git a/src/it/sarif-1/verify.groovy b/src/it/sarif-1/verify.groovy new file mode 100644 index 000000000..b8fcad162 --- /dev/null +++ b/src/it/sarif-1/verify.groovy @@ -0,0 +1,36 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.json.JsonSlurper + +def effortLevel = 'default' + + +File spotbugSarifFile = new File(basedir, 'target/spotbugsSarif.json') +assert spotbugSarifFile.exists() + + +println '**********************************' +println "Checking SARIF file" +println '**********************************' + +def path = new JsonSlurper().parse(spotbugSarifFile) + +def results = path.runs.results[0] +println "BugInstance size is ${results.size()}" + + +assert results.size() > 0 \ No newline at end of file From 545f79864c911cdc2127d5098fe9c705a43b1316 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 11 Aug 2021 19:02:30 +0000 Subject: [PATCH 0542/1013] Bump scmPluginVersion from 1.11.2 to 1.11.3 Bumps `scmPluginVersion` from 1.11.2 to 1.11.3. Updates `maven-scm-provider-jgit` from 1.11.2 to 1.11.3 Updates `maven-scm-plugin` from 1.11.2 to 1.11.3 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.11.2...maven-scm-1.11.3) --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-provider-jgit dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-scm-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 390270537..1179eccb8 100644 --- a/pom.xml +++ b/pom.xml @@ -149,7 +149,7 @@ 3.2.2 3.3.0 3.6.1 - 1.11.2 + 1.11.3 3.9.1 3.6 2.8.1 From 4c9882867d4d20920542ef328dca656f3a7ebafd Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Wed, 11 Aug 2021 23:13:32 -0400 Subject: [PATCH 0543/1013] Remove commented code (commit by accident) --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 5540cd6b4..25a324499 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1084,7 +1084,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } ant.java(classname: "edu.umd.cs.findbugs.FindBugs2", inputstring: getSpotbugsAuxClasspath(), fork: "${fork}", failonerror: "true", clonevm: "false", timeout: "${timeout}", maxmemory: "${maxHeap}m") { - //this.executeSpotbugs() + log.debug("File Encoding is " + effectiveEncoding) sysproperty(key: "file.encoding", value: effectiveEncoding) From 7e4e5de20b3526b6c9d8ed33f152c0278fd551c2 Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Wed, 11 Aug 2021 23:16:08 -0400 Subject: [PATCH 0544/1013] Rename sarifTempFile to sarifFile to emphasis that it is the final file and not something temporary --- .../codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 25a324499..2f2733080 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1040,13 +1040,13 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { long startTime, duration File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") - File sarifTempFile = new File("${project.build.directory}/spotbugsSarif.json") + File sarifFile = new File("${project.build.directory}/spotbugsSarif.json") if (xmlOutput || !sarifOutput) { forceFileCreation(xmlTempFile) } else { - forceFileCreation(sarifTempFile) + forceFileCreation(sarifFile) } @@ -1064,7 +1064,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") log.debug("outputFile is ${outputFile.getCanonicalPath()}") log.debug("output Directory is ${spotbugsXmlOutputDirectory.getAbsolutePath()}") - log.debug("TempFile is ${(sarifOutput ? sarifTempFile : xmlTempFile).getCanonicalPath()}"); + log.debug("TempFile is ${(sarifOutput ? sarifFile : xmlTempFile).getCanonicalPath()}"); } def ant = new AntBuilder() @@ -1075,7 +1075,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { startTime = System.nanoTime() } - def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifTempFile) + def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifFile) def effectiveEncoding = System.getProperty("file.encoding", "UTF-8") @@ -1193,9 +1193,9 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } - if(sarifTempFile && sarifOutput) { - if (sarifTempFile.size() > 0) { - def path = new JsonSlurper().parse(sarifTempFile) + if(sarifFile && sarifOutput) { + if (sarifFile.size() > 0) { + def path = new JsonSlurper().parse(sarifFile) try { @@ -1203,7 +1203,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("BugInstance size is ${results.size()}") } catch (Exception e) { - log.error("Unexpected format for the file $sarifTempFile",e) + log.error("Unexpected format for the file $sarifFile",e) } } } From 16c8bbcd9354790474f3f2959ad46eac6427b448 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 13 Aug 2021 19:01:39 +0000 Subject: [PATCH 0545/1013] Bump slf4jVersion from 2.0.0-alpha3 to 2.0.0-alpha4 Bumps `slf4jVersion` from 2.0.0-alpha3 to 2.0.0-alpha4. Updates `jcl-over-slf4j` from 2.0.0-alpha3 to 2.0.0-alpha4 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha3...v_2.0.0-alpha4) Updates `slf4j-simple` from 2.0.0-alpha3 to 2.0.0-alpha4 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha3...v_2.0.0-alpha4) Updates `slf4j-api` from 2.0.0-alpha3 to 2.0.0-alpha4 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha3...v_2.0.0-alpha4) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 047c7bfa8..9315a4190 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 5.7.2 4.3.0 4.3.0 - 2.0.0-alpha3 + 2.0.0-alpha4 1.10.11 3.0.8 From 77a86a770c14e7ce1c92482df49497becc3061ac Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 19:01:23 +0000 Subject: [PATCH 0546/1013] Bump spotbugs from 4.3.0 to 4.4.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.3.0 to 4.4.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.3.0...4.4.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9315a4190..7d05baa7c 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.2 - 4.3.0 + 4.4.0 4.3.0 2.0.0-alpha4 From 04264e583c89981e2bd0cf8a164d0eb849854dff Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 19:01:32 +0000 Subject: [PATCH 0547/1013] Bump maven-core from 3.8.1 to 3.8.2 Bumps [maven-core](https://github.com/apache/maven) from 3.8.1 to 3.8.2. - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.1...maven-3.8.2) --- updated-dependencies: - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9315a4190..218f9639a 100644 --- a/pom.xml +++ b/pom.xml @@ -131,7 +131,7 @@ 1.10 1.10 - 3.8.1 + 3.8.2 0.13.1 3.0 3.0.0 From 56bcea4ba1c59124742c8a01f9aed307fe2ad871 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 16 Aug 2021 19:01:40 +0000 Subject: [PATCH 0548/1013] Bump mavenVersion from 3.8.1 to 3.8.2 Bumps `mavenVersion` from 3.8.1 to 3.8.2. Updates `maven-plugin-api` from 3.8.1 to 3.8.2 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.1...maven-3.8.2) Updates `maven-artifact` from 3.8.1 to 3.8.2 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.1...maven-3.8.2) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9315a4190..f3cd235c7 100644 --- a/pom.xml +++ b/pom.xml @@ -135,7 +135,7 @@ 0.13.1 3.0 3.0.0 - 3.8.1 + 3.8.2 2.1.0 1.1.0 From 314171e76274da14ee57ad34953b849174b5e93b Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Thu, 19 Aug 2021 14:06:22 -0400 Subject: [PATCH 0549/1013] Add the option to transform relative path to complete path in SARIF report Complement to the SARIF mode introduce in #339 --- .../mojo/spotbugs/SourceFileIndexer.groovy | 144 ++++++++++++++++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 64 ++++++-- 2 files changed, 194 insertions(+), 14 deletions(-) create mode 100644 src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy new file mode 100644 index 000000000..86c8daa32 --- /dev/null +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -0,0 +1,144 @@ +package org.codehaus.mojo.spotbugs + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.execution.MavenSession +import org.apache.maven.model.Resource +import org.apache.maven.project.MavenProject + +import java.nio.file.Paths + +/** + * Utility class used to transform path relative to the source directory + * to their path relative to the root directory. + */ +class SourceFileIndexer { + + /** + * List of source files found in the current Maven project + */ + private List allSourceFiles; + + /** + * Initialize the complete list of source files with their + * + * @param project Reference to the Maven project to get the list of source directories + * @param session Reference to the Maven session used to get the location of the root directory + */ + protected void buildListSourceFiles(MavenProject project, MavenSession session) { + + //String basePath = project.basedir.absolutePath + String basePath = session.getExecutionRootDirectory() + + def allSourceFiles = new ArrayList<>() + //Resource + for(Resource r in project.getResources()) { + scanDirectory(new File(r.directory), allSourceFiles, basePath) + } + for(Resource r in project.getTestResources()) { + scanDirectory(new File(r.directory), allSourceFiles, basePath) + } + //Source files + for(String sourceRoot in project.getCompileSourceRoots()) { + scanDirectory(new File(sourceRoot), allSourceFiles, basePath) + } + for(String sourceRoot in project.getTestCompileSourceRoots()) { + scanDirectory(new File(sourceRoot), allSourceFiles, basePath) + } + + for(String sourceRoot in project.getScriptSourceRoots()) { + scanDirectory(new File(sourceRoot), allSourceFiles, basePath) + } + + //While not perfect, add the following paths will add basic support for Kotlin and Groovy + scanDirectory(new File(project.getBasedir(),"src/main/webapp"), allSourceFiles, basePath) + scanDirectory(new File(project.getBasedir(),"src/main/groovy"), allSourceFiles, basePath) + scanDirectory(new File(project.getBasedir(),"src/main/kotlin"), allSourceFiles, basePath) + + this.allSourceFiles = allSourceFiles + } + + /** + * Recursively scan the directory given and add all files found to the files array list. + * The base directory will be truncated from the path stored. + * + * @param directory Directory to scan + * @param files ArrayList where files found will be stored + * @param baseDirectory This part will be truncated from path stored + * @throws IOException + */ + private void scanDirectory(File directory,List files,String baseDirectory) throws IOException { + + if(directory.exists()) { + for(File child : directory.listFiles()) { + if(child.isDirectory()) { + scanDirectory(child,files,baseDirectory); + } + else { + if(child.canonicalPath.startsWith(baseDirectory)) { + //The project will not be at the root of our file system. + //It will most likely be stored in a work directory. + // /work/project-code-to-scan/src/main/java/File.java => src/main/java/File.java + // (Here baseDirectory is /work/project-code-to-scan/) + String relativePath = Paths.get(baseDirectory).relativize(Paths.get(child.path)) + files.add(normalizePath(relativePath)) + } + else { + files.add(normalizePath(child.path)) + } + } + } + } + } + + /** + * Normalize path to use forward slash. + * This will facilitate searches. + * + * @param path Path to clean up + * @return Path safe to use for comparison + */ + private String normalizePath(String path) { + return path.replaceAll("\\\\","/"); + } + + /** + * Transform partial path to complete path + * + * @param filename Partial name to search + * @return Complete path found. Null is not found! + */ + protected String searchActualFilesLocation(String filename) { + + if(allSourceFiles == null) { + throw new RuntimeException("Source files cache must be built prior to searches.") + } + + for(String fileFound in allSourceFiles) { + + if(fileFound.endsWith(filename)) { + return fileFound + } + + } + + return null //Not found + } +} diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 2f2733080..02fe741b1 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -19,6 +19,8 @@ package org.codehaus.mojo.spotbugs * under the License. */ +import groovy.json.JsonBuilder + import groovy.json.JsonSlurper import groovy.xml.XmlSlurper import groovy.xml.StreamingMarkupBuilder @@ -28,7 +30,6 @@ import org.apache.maven.doxia.siterenderer.Renderer import org.apache.maven.doxia.tools.SiteTool import org.apache.maven.execution.MavenSession - import org.apache.maven.plugin.MojoExecutionException import org.apache.maven.plugins.annotations.Component @@ -78,6 +79,9 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(defaultValue = "false", property = "spotbugs.sarifOutput", required = true) boolean sarifOutput + @Parameter(defaultValue = "false", property = "spotbugs.sarifFullPath", required = true) + boolean sarifFullPath + /** * Specifies the directory where the xml output will be generated. * @@ -1040,13 +1044,14 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { long startTime, duration File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") - File sarifFile = new File("${project.build.directory}/spotbugsSarif.json") + File sarifTempFile = new File("${project.build.directory}/spotbugsTempSarif.json") + File sarifFinalFile = new File("${project.build.directory}/spotbugsSarif.json") if (xmlOutput || !sarifOutput) { forceFileCreation(xmlTempFile) } else { - forceFileCreation(sarifFile) + forceFileCreation(sarifTempFile) } @@ -1064,7 +1069,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") log.debug("outputFile is ${outputFile.getCanonicalPath()}") log.debug("output Directory is ${spotbugsXmlOutputDirectory.getAbsolutePath()}") - log.debug("TempFile is ${(sarifOutput ? sarifFile : xmlTempFile).getCanonicalPath()}"); + log.debug("TempFile is ${(sarifOutput ? sarifTempFile : xmlTempFile).getCanonicalPath()}"); } def ant = new AntBuilder() @@ -1075,7 +1080,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { startTime = System.nanoTime() } - def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifFile) + def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifTempFile) def effectiveEncoding = System.getProperty("file.encoding", "UTF-8") @@ -1193,19 +1198,50 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } - if(sarifFile && sarifOutput) { - if (sarifFile.size() > 0) { - def path = new JsonSlurper().parse(sarifFile) + if(sarifTempFile && sarifOutput && sarifTempFile.size() > 0) { - try { + def slurpedResult = new JsonSlurper().parse(sarifTempFile) + def builder = new JsonBuilder(slurpedResult) + + // With -Dspotbugs.sarifFullPath=true + // The location uri will be replace by path relative to the root of project + // SomeFile.java => src/main/java/SomeFile.java + //This change is required for some tool including Github code scanning API + if (sarifFullPath) { + + def indexer = new SourceFileIndexer() + + indexer.buildListSourceFiles(getProject(),getSession()) + + for (result in slurpedResult.runs.results[0]) { + + for (loc in result.locations) { + def originalFullPath = loc.physicalLocation.artifactLocation.uri + + //We replace relative path to the complete path + String newFileName = indexer.searchActualFilesLocation(originalFullPath) + + if (newFileName != null) { + if(getLog().isDebugEnabled()) { + getLog().info("$originalFullPath modified to $newFileName") + } + loc.physicalLocation.artifactLocation.uri = newFileName + } else { + getLog().warn("No source file found for $originalFullPath. " + + "The path include in the SARIF report could be incomplete.") + } + } - def results = path.runs.results[0] - log.debug("BugInstance size is ${results.size()}") - } - catch (Exception e) { - log.error("Unexpected format for the file $sarifFile",e) } } + + sarifFinalFile.withWriter { + builder.writeTo(it) + } + + if (!log.isDebugEnabled()) { + sarifTempFile.delete() + } } } From aec888776e0f6b3c71538f88a2c55d3d2e613c9b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 19 Aug 2021 19:01:16 +0000 Subject: [PATCH 0550/1013] Bump maven-profiler from 3.0 to 3.1.1 Bumps [maven-profiler](https://github.com/jcgay/maven-profiler) from 3.0 to 3.1.1. - [Release notes](https://github.com/jcgay/maven-profiler/releases) - [Changelog](https://github.com/jcgay/maven-profiler/blob/master/CHANGELOG.md) - [Commits](https://github.com/jcgay/maven-profiler/compare/v3.0...v3.1.1) --- updated-dependencies: - dependency-name: fr.jcgay.maven:maven-profiler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .mvn/extensions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml index 1c87ce310..4a35ac239 100644 --- a/.mvn/extensions.xml +++ b/.mvn/extensions.xml @@ -3,6 +3,6 @@ fr.jcgay.maven maven-profiler - 3.0 + 3.1.1 From 7161037bf93562b339a4a2ba695fb07ec6062dae Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Tue, 24 Aug 2021 12:19:12 -0400 Subject: [PATCH 0551/1013] Integration to cover full path expansion for sarif report file #348 --- src/it/sarif-2/invoker.properties | 4 ++ src/it/sarif-2/pom.xml | 49 +++++++++++++++++++ src/it/sarif-2/verify.groovy | 47 ++++++++++++++++++ .../mojo/spotbugs/SourceFileIndexer.groovy | 12 +++-- 4 files changed, 108 insertions(+), 4 deletions(-) create mode 100644 src/it/sarif-2/invoker.properties create mode 100644 src/it/sarif-2/pom.xml create mode 100644 src/it/sarif-2/verify.groovy diff --git a/src/it/sarif-2/invoker.properties b/src/it/sarif-2/invoker.properties new file mode 100644 index 000000000..ccba96b66 --- /dev/null +++ b/src/it/sarif-2/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile compiler:testCompile site + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/sarif-2/pom.xml b/src/it/sarif-2/pom.xml new file mode 100644 index 000000000..c90ebfc7a --- /dev/null +++ b/src/it/sarif-2/pom.xml @@ -0,0 +1,49 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + sarif-2 + sarif-2 + jar + + true + + + org.apache.maven.plugins + maven-jxr-plugin + @jxrPluginVersion@ + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + true + + + + + diff --git a/src/it/sarif-2/verify.groovy b/src/it/sarif-2/verify.groovy new file mode 100644 index 000000000..ed3ab444f --- /dev/null +++ b/src/it/sarif-2/verify.groovy @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.json.JsonSlurper + +def effortLevel = 'default' + + +File spotbugSarifFile = new File(basedir, 'target/spotbugsSarif.json') +assert spotbugSarifFile.exists() + + +println '**********************************' +println "Checking SARIF file" +println '**********************************' + +def slurpedResult = new JsonSlurper().parse(spotbugSarifFile) + +def results = slurpedResult.runs.results[0] + +for (result in slurpedResult.runs.results[0]) { + + for (loc in result.locations) { + String location = loc.physicalLocation.artifactLocation.uri + //Making sure that the path was expanded + assert location.contains("src/it-src/test/java") + } +} + + +println "BugInstance size is ${results.size()}" + + +assert results.size() > 0 \ No newline at end of file diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy index 86c8daa32..7ec02aba5 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -45,7 +45,7 @@ class SourceFileIndexer { protected void buildListSourceFiles(MavenProject project, MavenSession session) { //String basePath = project.basedir.absolutePath - String basePath = session.getExecutionRootDirectory() + String basePath = normalizePath(session.getExecutionRootDirectory()) def allSourceFiles = new ArrayList<>() //Resource @@ -92,16 +92,20 @@ class SourceFileIndexer { scanDirectory(child,files,baseDirectory); } else { - if(child.canonicalPath.startsWith(baseDirectory)) { + String newSourceFile = normalizePath(child.canonicalPath) + if(newSourceFile.startsWith(baseDirectory)) { //The project will not be at the root of our file system. //It will most likely be stored in a work directory. // /work/project-code-to-scan/src/main/java/File.java => src/main/java/File.java // (Here baseDirectory is /work/project-code-to-scan/) - String relativePath = Paths.get(baseDirectory).relativize(Paths.get(child.path)) + String relativePath = Paths.get(baseDirectory).relativize(Paths.get(newSourceFile)) files.add(normalizePath(relativePath)) } else { - files.add(normalizePath(child.path)) + //Use the full path instead: + //This will occurs in many cases including when the pom.xml is + // not in the same directory tree as the sources. + files.add(newSourceFile) } } } From 82b51ccb0d7520977d077a62244ef3b097f4e3e4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 27 Aug 2021 19:01:30 +0000 Subject: [PATCH 0552/1013] Bump plexus-utils from 3.4.0 to 3.4.1 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.0 to 3.4.1. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.4.0...plexus-utils-3.4.1) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c4185d0a8..fb6802de6 100644 --- a/pom.xml +++ b/pom.xml @@ -139,7 +139,7 @@ 2.1.0 1.1.0 - 3.4.0 + 3.4.1 3.0.0 1.8 From b927a7da6e2509b09e5669f05ca9dcfb2fb54b91 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 30 Aug 2021 19:01:47 +0000 Subject: [PATCH 0553/1013] Bump slf4jVersion from 2.0.0-alpha4 to 2.0.0-alpha5 Bumps `slf4jVersion` from 2.0.0-alpha4 to 2.0.0-alpha5. Updates `jcl-over-slf4j` from 2.0.0-alpha4 to 2.0.0-alpha5 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha4...v_2.0.0-alpha5) Updates `slf4j-simple` from 2.0.0-alpha4 to 2.0.0-alpha5 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha4...v_2.0.0-alpha5) Updates `slf4j-api` from 2.0.0-alpha4 to 2.0.0-alpha5 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_2.0.0-alpha4...v_2.0.0-alpha5) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fb6802de6..607746bda 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 5.7.2 4.4.0 4.3.0 - 2.0.0-alpha4 + 2.0.0-alpha5 1.10.11 3.0.8 From 1f6c7feba3bd4a081e7af2cddc14a813891bcc07 Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Tue, 31 Aug 2021 08:50:12 -0400 Subject: [PATCH 0554/1013] SARIF integration test 2: More verbose error message when assertion is failing --- src/it/sarif-2/verify.groovy | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/it/sarif-2/verify.groovy b/src/it/sarif-2/verify.groovy index ed3ab444f..518b14d96 100644 --- a/src/it/sarif-2/verify.groovy +++ b/src/it/sarif-2/verify.groovy @@ -27,6 +27,11 @@ println '**********************************' println "Checking SARIF file" println '**********************************' + +def String normalizePath(String path) { + return path.replaceAll("\\\\","/"); +} + def slurpedResult = new JsonSlurper().parse(spotbugSarifFile) def results = slurpedResult.runs.results[0] @@ -34,9 +39,9 @@ def results = slurpedResult.runs.results[0] for (result in slurpedResult.runs.results[0]) { for (loc in result.locations) { - String location = loc.physicalLocation.artifactLocation.uri + String location = normalizePath(loc.physicalLocation.artifactLocation.uri) //Making sure that the path was expanded - assert location.contains("src/it-src/test/java") + assert location.contains("src/it-src/test/java") : "$location does not contain 'src/it-src/test/java'" } } From eff7162ea69d61c08e86210b8ecff82f3010e5df Mon Sep 17 00:00:00 2001 From: Philippe Arteau Date: Tue, 31 Aug 2021 10:31:46 -0400 Subject: [PATCH 0555/1013] Adjust assert to support the path 'spotbugsTestCases/src/java/AbstractMissingHashCode.java' --- src/it/sarif-2/verify.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/it/sarif-2/verify.groovy b/src/it/sarif-2/verify.groovy index 518b14d96..a41a8c0a8 100644 --- a/src/it/sarif-2/verify.groovy +++ b/src/it/sarif-2/verify.groovy @@ -41,7 +41,7 @@ for (result in slurpedResult.runs.results[0]) { for (loc in result.locations) { String location = normalizePath(loc.physicalLocation.artifactLocation.uri) //Making sure that the path was expanded - assert location.contains("src/it-src/test/java") : "$location does not contain 'src/it-src/test/java'" + assert location.contains("src/it-src/test/java") || location.contains("src/java") : "$location does not contain 'src/it-src/test/java'" } } From 6a8cf274c851d3bd1d54fce812de8505c45b5d5a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 6 Sep 2021 19:01:51 +0000 Subject: [PATCH 0556/1013] Bump groovyVersion from 3.0.8 to 3.0.9 Bumps `groovyVersion` from 3.0.8 to 3.0.9. Updates `groovy` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-groovydoc` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-json` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 3.0.8 to 3.0.9 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.codehaus.groovy:groovy:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-ant:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-dateutil:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-docgenerator:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-groovydoc:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-templates:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-xml:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-json:indy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 607746bda..49acbf23c 100644 --- a/pom.xml +++ b/pom.xml @@ -126,7 +126,7 @@ 2.0.0-alpha5 1.10.11 - 3.0.8 + 3.0.9 1.10 1.10 From a13710d0277a65e2ce70a9d31b28583eddf859dc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 7 Sep 2021 19:02:15 +0000 Subject: [PATCH 0557/1013] Bump maven-javadoc-plugin from 3.3.0 to 3.3.1 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.0...maven-javadoc-plugin-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 49acbf23c..7872dde26 100644 --- a/pom.xml +++ b/pom.xml @@ -147,7 +147,7 @@ 1.12.1 3.1.2 3.2.2 - 3.3.0 + 3.3.1 3.6.1 1.11.3 3.9.1 From c6e767bad391fc736a82728ff31504c1010d6e63 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 10 Sep 2021 19:01:26 +0000 Subject: [PATCH 0558/1013] Bump spotbugs from 4.4.0 to 4.4.1 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.0 to 4.4.1. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.4.0...4.4.1) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7872dde26..a97331231 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.7.2 - 4.4.0 + 4.4.1 4.3.0 2.0.0-alpha5 From febf924641a1f006bc6b424321b6bad42abfc2f6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 10 Sep 2021 22:24:23 -0400 Subject: [PATCH 0559/1013] [pom] Bump spotbugs to 4.4.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index a97331231..5e09e91ee 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.3.1-SNAPSHOT + 4.4.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -122,7 +122,7 @@ 5.7.2 4.4.1 - 4.3.0 + 4.4.1 2.0.0-alpha5 1.10.11 From 39d9fc641b99c9df7c567451abda5e5d4f9f8eab Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 10 Sep 2021 22:29:57 -0400 Subject: [PATCH 0560/1013] Create codeql-analysis.yml --- .github/workflows/codeql-analysis.yml | 71 +++++++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 .github/workflows/codeql-analysis.yml diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml new file mode 100644 index 000000000..f23c2484d --- /dev/null +++ b/.github/workflows/codeql-analysis.yml @@ -0,0 +1,71 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your repository. +# +# You may wish to alter this file to override the set of languages analyzed, +# or to provide custom queries or build logic. +# +# ******** NOTE ******** +# We have attempted to detect the languages in your repository. Please check +# the `language` matrix defined below to confirm you have the correct set of +# supported CodeQL languages. +# +name: "CodeQL" + +on: + push: + branches: [ spotbugs ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ spotbugs ] + schedule: + - cron: '27 0 * * 3' + +jobs: + analyze: + name: Analyze + runs-on: ubuntu-latest + permissions: + actions: read + contents: read + security-events: write + + strategy: + fail-fast: false + matrix: + language: [ 'java' ] + # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ] + # Learn more: + # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed + + steps: + - name: Checkout repository + uses: actions/checkout@v2 + + # Initializes the CodeQL tools for scanning. + - name: Initialize CodeQL + uses: github/codeql-action/init@v1 + with: + languages: ${{ matrix.language }} + # If you wish to specify custom queries, you can do so here or in a config file. + # By default, queries listed here will override any specified in a config file. + # Prefix the list here with "+" to use these queries and those in the config file. + # queries: ./path/to/local/query, your-org/your-repo/queries@main + + # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). + # If this step fails, then you should remove it and run the build manually (see below) + - name: Autobuild + uses: github/codeql-action/autobuild@v1 + + # ℹ️ Command-line programs to run using the OS shell. + # 📚 https://git.io/JvXDl + + # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines + # and modify them (or add more) to build your code if your project + # uses a compiled language + + #- run: | + # make bootstrap + # make release + + - name: Perform CodeQL Analysis + uses: github/codeql-action/analyze@v1 From 915e5a027908d1ee01d87dcf1092c64a65096756 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 13 Sep 2021 19:01:53 +0000 Subject: [PATCH 0561/1013] Bump jgit.version from 5.12.0.202106070339-r to 5.13.0.202109080827-r Bumps `jgit.version` from 5.12.0.202106070339-r to 5.13.0.202109080827-r. Updates `org.eclipse.jgit` from 5.12.0.202106070339-r to 5.13.0.202109080827-r Updates `org.eclipse.jgit.ssh.jsch` from 5.12.0.202106070339-r to 5.13.0.202109080827-r --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.eclipse.jgit:org.eclipse.jgit.ssh.jsch dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5e09e91ee..6144a8c53 100644 --- a/pom.xml +++ b/pom.xml @@ -175,7 +175,7 @@ 4.0.4 7.4.7 - 5.12.0.202106070339-r + 5.13.0.202109080827-r 9.2 From 34c1c995c0f8af3685b6f81f4cd12a5f00500700 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 17 Sep 2021 19:01:40 +0000 Subject: [PATCH 0562/1013] Bump scmPluginVersion from 1.11.3 to 1.12.0 Bumps `scmPluginVersion` from 1.11.3 to 1.12.0. Updates `maven-scm-provider-jgit` from 1.11.3 to 1.12.0 Updates `maven-scm-plugin` from 1.11.3 to 1.12.0 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.11.3...maven-scm-1.12.0) --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-provider-jgit dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.plugins:maven-scm-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6144a8c53..89d90e37a 100644 --- a/pom.xml +++ b/pom.xml @@ -149,7 +149,7 @@ 3.2.2 3.3.1 3.6.1 - 1.11.3 + 1.12.0 3.9.1 3.6 2.8.1 From c8c8a689788a252bfeab6f323995e9ff2ce6dcd8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Sep 2021 18:25:01 -0400 Subject: [PATCH 0563/1013] [maven] Bump maven wrapper to 3.8.2 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index 642d572ce..abd303b67 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -1,2 +1,2 @@ -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.2/apache-maven-3.8.2-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar From 4dacc01757f654035fb0b73a13fc2fe8dace83d5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Sep 2021 18:25:09 -0400 Subject: [PATCH 0564/1013] [pom] Bump junit to 5.8.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 89d90e37a..877580154 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ ${project.version} - 5.7.2 + 5.8.0 4.4.1 4.4.1 2.0.0-alpha5 From 741f662a0d32ca1d4307d5bf47f75424893104ff Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Sep 2021 18:27:21 -0400 Subject: [PATCH 0565/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 877580154..b1e9305c5 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.1-SNAPSHOT + 4.4.1 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.4.1 GitHub Issues From 555c6a70854436539567be64187a9f8949a7e47e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 19 Sep 2021 18:27:25 -0400 Subject: [PATCH 0566/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index b1e9305c5..452e5cdc3 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.1 + 4.4.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.4.1 + HEAD GitHub Issues From 34e8c2a1eafc7eb2c1e52950b4ac03b255f9d726 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 20 Sep 2021 19:02:01 +0000 Subject: [PATCH 0567/1013] Bump gmavenplus-plugin from 1.12.1 to 1.13.0 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.12.1 to 1.13.0. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.12.1...1.13.0) --- updated-dependencies: - dependency-name: org.codehaus.gmavenplus:gmavenplus-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 452e5cdc3..8856f9ab9 100644 --- a/pom.xml +++ b/pom.xml @@ -144,7 +144,7 @@ 3.0.0 1.8 0.22-1 - 1.12.1 + 1.13.0 3.1.2 3.2.2 3.3.1 From 995228f7d834fed442e0fecf360f3eaf70df43c2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Oct 2021 19:02:00 +0000 Subject: [PATCH 0568/1013] Bump plexus-resources from 1.1.0 to 1.2.0 Bumps [plexus-resources](https://github.com/codehaus-plexus/plexus-resources) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/codehaus-plexus/plexus-resources/releases) - [Commits](https://github.com/codehaus-plexus/plexus-resources/compare/plexus-resources-1.1.0...plexus-resources-1.2.0) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-resources dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8856f9ab9..24355d86f 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 3.8.2 2.1.0 - 1.1.0 + 1.2.0 3.4.1 3.0.0 From 0f0eb0460296cb01625047576ffb1611e60ae6c5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Oct 2021 19:02:06 +0000 Subject: [PATCH 0569/1013] Bump maven-core from 3.8.2 to 3.8.3 Bumps [maven-core](https://github.com/apache/maven) from 3.8.2 to 3.8.3. - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.2...maven-3.8.3) --- updated-dependencies: - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8856f9ab9..062de3240 100644 --- a/pom.xml +++ b/pom.xml @@ -131,7 +131,7 @@ 1.10 1.10 - 3.8.2 + 3.8.3 0.13.1 3.0 3.0.0 From a41e00aac469a77f025ab02d6cb534266937ccbe Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Oct 2021 19:02:15 +0000 Subject: [PATCH 0570/1013] Bump mavenVersion from 3.8.2 to 3.8.3 Bumps `mavenVersion` from 3.8.2 to 3.8.3. Updates `maven-plugin-api` from 3.8.2 to 3.8.3 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.2...maven-3.8.3) Updates `maven-artifact` from 3.8.2 to 3.8.3 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.2...maven-3.8.3) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8856f9ab9..5eb59bc81 100644 --- a/pom.xml +++ b/pom.xml @@ -135,7 +135,7 @@ 0.13.1 3.0 3.0.0 - 3.8.2 + 3.8.3 2.1.0 1.1.0 From e1ec3346cc6d1248afaf30286df13ba658a82454 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 12 Oct 2021 19:02:01 +0000 Subject: [PATCH 0571/1013] Bump spotbugs from 4.4.1 to 4.4.2 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.4.1...4.4.2) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 22e4f1cdd..896bbfec4 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.8.0 - 4.4.1 + 4.4.2 4.4.1 2.0.0-alpha5 From 7375bb02ddf491226a20539e336f18ffc14163a9 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:05:28 -0400 Subject: [PATCH 0572/1013] [pom] Bump base parent to 29 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 896bbfec4..65d8ca2b2 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 28 + 29 From 6079393cd1a3631f076150b07e5467f5e910bd33 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:05:36 -0400 Subject: [PATCH 0573/1013] [pom] Bump junit to 5.8.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 65d8ca2b2..0fc5ca680 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ ${project.version} - 5.8.0 + 5.8.1 4.4.2 4.4.1 2.0.0-alpha5 From ff9d8c55b8bbe9c50f6564896b3b5d0bb81b08d1 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:05:45 -0400 Subject: [PATCH 0574/1013] [pom] Bump spotbugs tag to 4.4.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0fc5ca680..56058fd44 100644 --- a/pom.xml +++ b/pom.xml @@ -122,7 +122,7 @@ 5.8.1 4.4.2 - 4.4.1 + 4.4.2 2.0.0-alpha5 1.10.11 From 9004f5240812bf27e05e28f591ebedff83391017 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:08:21 -0400 Subject: [PATCH 0575/1013] [maven] Bump to 3.8.3 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index abd303b67..a9f1ef87b 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -1,2 +1,2 @@ -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.2/apache-maven-3.8.2-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.3-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar From a71eea9b92e6c4a9cafed6b4366ffea7209cde88 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:08:33 -0400 Subject: [PATCH 0576/1013] [actions] Replace jdk 16 with 17 and 18-ea --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 736e89164..757725358 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 16] + java: [8, 11, 17, 18-ea] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From d2ede7f4c3ec379b5e70e4d8e9270df725924f09 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:16:24 -0400 Subject: [PATCH 0577/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 56058fd44..725ccc6c8 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2-SNAPSHOT + 4.4.2 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.4.2 GitHub Issues From a277cb34010d39d81e07693addd334c39987622b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 13 Oct 2021 20:16:28 -0400 Subject: [PATCH 0578/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 725ccc6c8..51250a526 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2 + 4.4.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.4.2 + HEAD GitHub Issues From 4bfe64e837daa8378963bd1cfd5fedf84f9210c8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:24:35 -0400 Subject: [PATCH 0579/1013] [pom] Change version number to allow for patches since this wraps spotbugs While spotbugs uses semantic versioning, us doing the same does not allow for any patches. Using this style with one extra position allows us to patch. It will most often be .0 but in this first case, I need to release a patch to patch vulnerable library usage. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 51250a526..c1d05aa6c 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.3-SNAPSHOT + 4.4.2.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin From 6a0fd8bddd894743ac189a1a8c32c2a603463ecb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:25:30 -0400 Subject: [PATCH 0580/1013] [pom] Require maven 3.3.9 This most likely actually requires even newer, but still stating 3.2.5 which is extremely old is not ideal. No one really should use less than 3.8.1 due to vulnerabilities anyways. So this is not exactly what we want yet but is moving it forwards to block attempted old usage we don't even test for. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c1d05aa6c..9b1210ec9 100644 --- a/pom.xml +++ b/pom.xml @@ -87,7 +87,7 @@ - 3.2.5 + 3.3.9 From 95176c4a15f8ee0cbf3abbfb1bf93c39661a2fd8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:35:10 -0400 Subject: [PATCH 0581/1013] [pom] Override maven-common-artifact-filters to 3.2.0 --- pom.xml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9b1210ec9..0f20dfadf 100644 --- a/pom.xml +++ b/pom.xml @@ -133,6 +133,7 @@ 3.8.3 0.13.1 + 3.2.0 3.0 3.0.0 3.8.3 @@ -151,7 +152,7 @@ 3.6.1 1.12.0 3.9.1 - 3.6 + 3.6 2.8.1 false @@ -390,6 +391,11 @@ + + org.apache.maven.shared + maven-common-artifact-filters + ${mavenCommonArtifactFilters} + org.apache.maven From 06a2e8b83a5649c3c3d087d66f541895e0fd5414 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:40:45 -0400 Subject: [PATCH 0582/1013] [pom] Override commons lang2 to 2.6 --- pom.xml | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index 0f20dfadf..3b576b4df 100644 --- a/pom.xml +++ b/pom.xml @@ -186,6 +186,7 @@ 3.2.2 2.1 2.11.0 + 2.6 3.12.0 @@ -385,10 +386,10 @@ maven-artifact-transfer ${mavenTransferVersion} - - org.sonatype.sisu - sisu-guice - + + org.sonatype.sisu + sisu-guice + @@ -509,6 +510,11 @@ commons-io ${io.version} + + commons-lang + commons-lang + ${lang2.version} + org.apache.commons commons-lang3 From bc67d6b48ef142b108395728ccda0e1b9588f057 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:41:02 -0400 Subject: [PATCH 0583/1013] [pom] Override maven shared utils to 3.3.4 others are vulnerable. --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 3b576b4df..346c5cbe9 100644 --- a/pom.xml +++ b/pom.xml @@ -132,6 +132,7 @@ 1.10 3.8.3 + 3.3.4 0.13.1 3.2.0 3.0 @@ -403,6 +404,11 @@ maven-core ${mavenCoreVersion} + + org.apache.maven.shared + maven-shared-utils + ${mavenSharedUtilsVersion} + From 9e2368119da25f2edcbd820bb25f18c716ddd5b5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 16 Oct 2021 23:41:40 -0400 Subject: [PATCH 0584/1013] [pom] Formatting --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 346c5cbe9..435a4db50 100644 --- a/pom.xml +++ b/pom.xml @@ -458,8 +458,8 @@ struts-core - dom4j - dom4j + dom4j + dom4j commons-logging From 20bbdd5e9630f423d9943a8ef46879c4b9a0efac Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 17 Oct 2021 00:05:07 -0400 Subject: [PATCH 0585/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 435a4db50..e1e2e86ae 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2.1-SNAPSHOT + 4.4.2.1 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.4.2.1 GitHub Issues From 2b57e82ca7c5eadcde1f4479436ef53a1317f685 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 17 Oct 2021 00:05:11 -0400 Subject: [PATCH 0586/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e1e2e86ae..bcb27b58e 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2.1 + 4.4.2.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.4.2.1 + HEAD GitHub Issues From cdcecc47ac78d4efa1f0beedc139e11b45ca4168 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 19 Oct 2021 19:01:47 +0000 Subject: [PATCH 0587/1013] Bump ant from 1.10.11 to 1.10.12 Bumps ant from 1.10.11 to 1.10.12. --- updated-dependencies: - dependency-name: org.apache.ant:ant dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index bcb27b58e..9acd94b24 100644 --- a/pom.xml +++ b/pom.xml @@ -125,7 +125,7 @@ 4.4.2 2.0.0-alpha5 - 1.10.11 + 1.10.12 3.0.9 1.10 From 8c16d9704f00193c736d385b599496b64bb86880 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 21 Oct 2021 07:53:20 -0400 Subject: [PATCH 0588/1013] [pom] Update base parent without maven url attributes that break older artifactory --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 9acd94b24..b187a66bc 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 29 + 30 From a00e29d56997b9f4247748355a549e837c304629 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 21 Oct 2021 07:54:19 -0400 Subject: [PATCH 0589/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.4.2.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index b187a66bc..3989f3542 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2.2-SNAPSHOT + 4.4.2.2 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.4.2.2 GitHub Issues From ac416fe31ec0f0f7118f8f9022e120c55b6b2279 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 21 Oct 2021 07:54:23 -0400 Subject: [PATCH 0590/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 3989f3542..944ab7f5d 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2.2 + 4.4.2.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.4.2.2 + HEAD GitHub Issues From 967ce4e4f53570ccff2e75214627826c932f685a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 11 Nov 2021 19:01:42 +0000 Subject: [PATCH 0591/1013] Bump spotbugs from 4.4.2 to 4.5.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.4.2 to 4.5.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.4.2...4.5.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 944ab7f5d..6f3e6fc39 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.8.1 - 4.4.2 + 4.5.0 4.4.2 2.0.0-alpha5 From fa72729a632810eb24998decb707487af7623b30 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 18 Nov 2021 11:13:12 -0500 Subject: [PATCH 0592/1013] [pom] Bump remainder of spotbugs to 4.5.0 and plugin to 4.5.0.0 snapshot --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 6f3e6fc39..357a9dbd5 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.4.2.3-SNAPSHOT + 4.5.0.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -122,8 +122,8 @@ 5.8.1 4.5.0 - 4.4.2 2.0.0-alpha5 + 4.5.0 1.10.12 3.0.9 From 66857ad3847c11999c9b802b475b7f8ac15d9e0b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 18 Nov 2021 11:13:20 -0500 Subject: [PATCH 0593/1013] [pom] Drop slf4j to 1.7.32 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 357a9dbd5..26adf7a2b 100644 --- a/pom.xml +++ b/pom.xml @@ -122,8 +122,8 @@ 5.8.1 4.5.0 - 2.0.0-alpha5 4.5.0 + 1.7.32 1.10.12 3.0.9 From e6f455711fa5d823ca67bbdabd51cd2cd9fe7858 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 18 Nov 2021 17:18:04 -0500 Subject: [PATCH 0594/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.5.0.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 26adf7a2b..190723607 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.0.0-SNAPSHOT + 4.5.0.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.5.0.0 GitHub Issues From 2579c4835099f294c66dfe469c432f3a54581758 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 18 Nov 2021 17:18:08 -0500 Subject: [PATCH 0595/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 190723607..cdae4b48d 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.0.0 + 4.5.0.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.5.0.0 + HEAD GitHub Issues From f7a4e14577b3cdd99e82bf17c0773fd60df4833b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 22 Nov 2021 19:02:35 +0000 Subject: [PATCH 0596/1013] Bump maven-core from 3.8.3 to 3.8.4 Bumps [maven-core](https://github.com/apache/maven) from 3.8.3 to 3.8.4. - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.3...maven-3.8.4) --- updated-dependencies: - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index cdae4b48d..8e4a30219 100644 --- a/pom.xml +++ b/pom.xml @@ -131,7 +131,7 @@ 1.10 1.10 - 3.8.3 + 3.8.4 3.3.4 0.13.1 3.2.0 From 574256d48212c46cb29a39973851630ac189ce4a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 23 Nov 2021 03:27:26 +0000 Subject: [PATCH 0597/1013] Bump mavenVersion from 3.8.3 to 3.8.4 Bumps `mavenVersion` from 3.8.3 to 3.8.4. Updates `maven-plugin-api` from 3.8.3 to 3.8.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.3...maven-3.8.4) Updates `maven-artifact` from 3.8.3 to 3.8.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.3...maven-3.8.4) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8e4a30219..d63b5d539 100644 --- a/pom.xml +++ b/pom.xml @@ -137,7 +137,7 @@ 3.2.0 3.0 3.0.0 - 3.8.3 + 3.8.4 2.1.0 1.2.0 From 5741fe9aeaad54df241c57355a99f7336dfdbc68 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 24 Nov 2021 19:01:39 +0000 Subject: [PATCH 0598/1013] Bump gmavenplus-plugin from 1.13.0 to 1.13.1 Bumps [gmavenplus-plugin](https://github.com/groovy/GMavenPlus) from 1.13.0 to 1.13.1. - [Release notes](https://github.com/groovy/GMavenPlus/releases) - [Commits](https://github.com/groovy/GMavenPlus/compare/1.13.0...1.13.1) --- updated-dependencies: - dependency-name: org.codehaus.gmavenplus:gmavenplus-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d63b5d539..db77d65d2 100644 --- a/pom.xml +++ b/pom.xml @@ -146,7 +146,7 @@ 3.0.0 1.8 0.22-1 - 1.13.0 + 1.13.1 3.1.2 3.2.2 3.3.1 From f4cf83deda1fcd0d5e6bb98d9b987ca10e0c334f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 26 Nov 2021 19:01:22 +0000 Subject: [PATCH 0599/1013] Bump pluginPluginVersion from 3.6.1 to 3.6.2 Bumps `pluginPluginVersion` from 3.6.1 to 3.6.2. Updates `maven-plugin-annotations` from 3.6.1 to 3.6.2 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.1...maven-plugin-tools-3.6.2) Updates `maven-plugin-plugin` from 3.6.1 to 3.6.2 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.1...maven-plugin-tools-3.6.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugin-tools:maven-plugin-annotations dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-plugin-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index db77d65d2..a5199c210 100644 --- a/pom.xml +++ b/pom.xml @@ -150,7 +150,7 @@ 3.1.2 3.2.2 3.3.1 - 3.6.1 + 3.6.2 1.12.0 3.9.1 3.6 From a0b6dff5ca711bca8994481d26fe38c8457003b2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 30 Nov 2021 19:01:43 +0000 Subject: [PATCH 0600/1013] Bump jgit.version from 5.13.0.202109080827-r to 6.0.0.202111291000-r Bumps `jgit.version` from 5.13.0.202109080827-r to 6.0.0.202111291000-r. Updates `org.eclipse.jgit` from 5.13.0.202109080827-r to 6.0.0.202111291000-r Updates `org.eclipse.jgit.ssh.jsch` from 5.13.0.202109080827-r to 6.0.0.202111291000-r --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.eclipse.jgit:org.eclipse.jgit.ssh.jsch dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a5199c210..718b59409 100644 --- a/pom.xml +++ b/pom.xml @@ -177,7 +177,7 @@ 4.0.4 7.4.7 - 5.13.0.202109080827-r + 6.0.0.202111291000-r 9.2 From c9dc62765c4305bb61ef68542ad46296d42f7139 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 2 Dec 2021 19:01:43 +0000 Subject: [PATCH 0601/1013] Bump doxiaVersion from 1.10 to 1.11.1 Bumps `doxiaVersion` from 1.10 to 1.11.1. Updates `doxia-core` from 1.10 to 1.11.1 - [Release notes](https://github.com/apache/maven-doxia/releases) - [Commits](https://github.com/apache/maven-doxia/compare/doxia-1.10...doxia-1.11.1) Updates `doxia-sink-api` from 1.10 to 1.11.1 - [Release notes](https://github.com/apache/maven-doxia/releases) - [Commits](https://github.com/apache/maven-doxia/compare/doxia-1.10...doxia-1.11.1) --- updated-dependencies: - dependency-name: org.apache.maven.doxia:doxia-core dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-sink-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 718b59409..1cdaa9a3d 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.10.12 3.0.9 - 1.10 + 1.11.1 1.10 3.8.4 From 75ef4c34f4525b7a7129577e766a49f4ad7bde57 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 8 Dec 2021 19:02:07 +0000 Subject: [PATCH 0602/1013] Bump spotbugs from 4.5.0 to 4.5.1 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.5.0 to 4.5.1. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.5.0...4.5.1) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1cdaa9a3d..e0c7612a6 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.8.1 - 4.5.0 + 4.5.1 4.5.0 1.7.32 From 76b0f2c13b84c4260a69c95ffe16b65ccf82164e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 14 Dec 2021 19:02:22 +0000 Subject: [PATCH 0603/1013] Bump spotbugs from 4.5.1 to 4.5.2 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.5.1 to 4.5.2. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.5.1...4.5.2) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e0c7612a6..6ae02ba06 100644 --- a/pom.xml +++ b/pom.xml @@ -121,7 +121,7 @@ ${project.version} 5.8.1 - 4.5.1 + 4.5.2 4.5.0 1.7.32 From eaf27b75d2a10c861051e01a31cef9e784d202d5 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 20 Dec 2021 19:01:48 +0000 Subject: [PATCH 0604/1013] Bump doxiaSiteToolsVersion from 1.10 to 1.11.1 Bumps `doxiaSiteToolsVersion` from 1.10 to 1.11.1. Updates `doxia-decoration-model` from 1.10 to 1.11.1 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.10...doxia-sitetools-1.11.1) Updates `doxia-site-renderer` from 1.10 to 1.11.1 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.10...doxia-sitetools-1.11.1) Updates `doxia-integration-tools` from 1.10 to 1.11.1 - [Release notes](https://github.com/apache/maven-doxia-sitetools/releases) - [Commits](https://github.com/apache/maven-doxia-sitetools/compare/doxia-sitetools-1.10...doxia-sitetools-1.11.1) --- updated-dependencies: - dependency-name: org.apache.maven.doxia:doxia-decoration-model dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-site-renderer dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.doxia:doxia-integration-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6ae02ba06..31135cc6c 100644 --- a/pom.xml +++ b/pom.xml @@ -129,7 +129,7 @@ 3.0.9 1.11.1 - 1.10 + 1.11.1 3.8.4 3.3.4 From 2d5eecac972f34d6e1a61c0a84ea0f489fdb5b76 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Dec 2021 14:06:12 -0500 Subject: [PATCH 0605/1013] [pom] Drop jgit back to 5.13.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 31135cc6c..db3dc5123 100644 --- a/pom.xml +++ b/pom.xml @@ -177,7 +177,7 @@ 4.0.4 7.4.7 - 6.0.0.202111291000-r + 5.13.0.202109080827-r 9.2 From 845c31b342c201c9c4db01c8b9a4f7322d7ad421 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Dec 2021 14:06:24 -0500 Subject: [PATCH 0606/1013] [pom] Bump spotbugs to 4.5.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index db3dc5123..28b0f0f2c 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.0.1-SNAPSHOT + 4.5.2.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -122,7 +122,7 @@ 5.8.1 4.5.2 - 4.5.0 + 4.5.2 1.7.32 1.10.12 From ad7e95d3ed6ed689f83a676a09239511f194be42 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Dec 2021 14:06:33 -0500 Subject: [PATCH 0607/1013] [pom] Bump junit to 5.8.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 28b0f0f2c..0543f383c 100644 --- a/pom.xml +++ b/pom.xml @@ -120,7 +120,7 @@ ${project.version} - 5.8.1 + 5.8.2 4.5.2 4.5.2 1.7.32 From e047ca3d6b3c00c844eccebb443048ee0a5cc822 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Dec 2021 16:18:21 -0500 Subject: [PATCH 0608/1013] [alignment] Update deprecated output argument for spotbugs 4.5.x fixes #369 --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 02fe741b1..5e6090508 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -857,10 +857,10 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } if(!sarifOutput) { - args << "-xml:withMessages" + args << "-xml:withMessages=" + tempFile.getAbsolutePath() } else { - args << "-sarif" + args << "-sarif=" + tempFile.getAbsolutePath() } args << "-auxclasspathFromInput" @@ -956,10 +956,6 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << maxRank } - args << "-output" - args << tempFile.getAbsolutePath() - - if (classFilesDirectory.exists() && classFilesDirectory.isDirectory()) { log.debug(" Adding to Source Directory ->" + classFilesDirectory.absolutePath) args << classFilesDirectory.absolutePath From 31d625f335d5403908b17b6a8d1957136f8f6bf3 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 21 Dec 2021 18:24:56 -0500 Subject: [PATCH 0609/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.5.2.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 0543f383c..26d605a6a 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.2.0-SNAPSHOT + 4.5.2.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.5.2.0 GitHub Issues From 12d83813848402daec664b3a0889ca284b3f1d54 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 21 Dec 2021 18:25:01 -0500 Subject: [PATCH 0610/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 26d605a6a..7bba7d42e 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.2.0 + 4.5.2.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.5.2.0 + HEAD GitHub Issues From ed83eb49ae3cc1f59cab8fed826015d6f78d132a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 23 Dec 2021 19:01:50 +0000 Subject: [PATCH 0611/1013] Bump plexus-container-default from 2.1.0 to 2.1.1 Bumps [plexus-container-default](https://github.com/codehaus-plexus/plexus-containers) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/codehaus-plexus/plexus-containers/releases) - [Changelog](https://github.com/codehaus-plexus/plexus-containers/blob/master/ReleaseNotes.md) - [Commits](https://github.com/codehaus-plexus/plexus-containers/compare/plexus-containers-2.1.0...plexus-containers-2.1.1) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-container-default dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7bba7d42e..5f4258ef7 100644 --- a/pom.xml +++ b/pom.xml @@ -139,7 +139,7 @@ 3.0.0 3.8.4 - 2.1.0 + 2.1.1 1.2.0 3.4.1 From f08e3b52736ed15cace20498a8602a734b4b368f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 27 Dec 2021 19:01:45 +0000 Subject: [PATCH 0612/1013] Bump maven-site-plugin from 3.9.1 to 3.10.0 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.9.1 to 3.10.0. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.9.1...maven-site-plugin-3.10.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5f4258ef7..dffbc8a3f 100644 --- a/pom.xml +++ b/pom.xml @@ -152,7 +152,7 @@ 3.3.1 3.6.2 1.12.0 - 3.9.1 + 3.10.0 3.6 2.8.1 From b727d9b987c3fccdb12674a84f2b1e46c799c69b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 3 Jan 2022 19:02:15 +0000 Subject: [PATCH 0613/1013] Bump scmPluginVersion from 1.12.0 to 1.12.2 Bumps `scmPluginVersion` from 1.12.0 to 1.12.2. Updates `maven-scm-provider-jgit` from 1.12.0 to 1.12.2 Updates `maven-scm-plugin` from 1.12.0 to 1.12.2 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.12.0...maven-scm-1.12.2) --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-provider-jgit dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-scm-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dffbc8a3f..189686eb6 100644 --- a/pom.xml +++ b/pom.xml @@ -151,7 +151,7 @@ 3.2.2 3.3.1 3.6.2 - 1.12.0 + 1.12.2 3.10.0 3.6 2.8.1 From bb1b1dffb91f41e41e31cf3eeb3a5cde8c54836b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 21 Dec 2021 19:00:18 -0500 Subject: [PATCH 0614/1013] [pom] Use provided for maven dependencies --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index dffbc8a3f..b890cd336 100644 --- a/pom.xml +++ b/pom.xml @@ -374,12 +374,14 @@ org.apache.maven maven-plugin-api ${mavenVersion} + provided org.apache.maven maven-artifact ${mavenVersion} + provided @@ -403,6 +405,13 @@ org.apache.maven maven-core ${mavenCoreVersion} + provided + + + org.apache.maven + maven-model + ${mavenCoreVersion} + provided org.apache.maven.shared From 196b77ff23e457b82a0ea624c19bf0e8ae60d662 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 4 Jan 2022 09:08:26 -0500 Subject: [PATCH 0615/1013] [mvn] Update maven wrapper --- .mvn/wrapper/MavenWrapperDownloader.java | 151 +++++++++++++---------- .mvn/wrapper/maven-wrapper.properties | 20 ++- mvnw | 20 +-- mvnw.cmd | 32 +++-- 4 files changed, 138 insertions(+), 85 deletions(-) diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java index e76d1f324..17add53ea 100644 --- a/.mvn/wrapper/MavenWrapperDownloader.java +++ b/.mvn/wrapper/MavenWrapperDownloader.java @@ -1,115 +1,140 @@ /* - * Copyright 2007-present the original author or authors. + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 * - * https://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. */ + import java.net.*; import java.io.*; import java.nio.channels.*; import java.util.Properties; -public class MavenWrapperDownloader { +public class MavenWrapperDownloader +{ + private static final String WRAPPER_VERSION = "3.1.0"; - private static final String WRAPPER_VERSION = "0.5.6"; /** * Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' is provided. */ - private static final String DEFAULT_DOWNLOAD_URL = "https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/" - + WRAPPER_VERSION + "/maven-wrapper-" + WRAPPER_VERSION + ".jar"; + private static final String DEFAULT_DOWNLOAD_URL = + "https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/" + WRAPPER_VERSION + + "/maven-wrapper-" + WRAPPER_VERSION + ".jar"; /** - * Path to the maven-wrapper.properties file, which might contain a downloadUrl property to - * use instead of the default one. + * Path to the maven-wrapper.properties file, which might contain a downloadUrl property to use instead of the + * default one. */ - private static final String MAVEN_WRAPPER_PROPERTIES_PATH = - ".mvn/wrapper/maven-wrapper.properties"; + private static final String MAVEN_WRAPPER_PROPERTIES_PATH = ".mvn/wrapper/maven-wrapper.properties"; /** * Path where the maven-wrapper.jar will be saved to. */ - private static final String MAVEN_WRAPPER_JAR_PATH = - ".mvn/wrapper/maven-wrapper.jar"; + private static final String MAVEN_WRAPPER_JAR_PATH = ".mvn/wrapper/maven-wrapper.jar"; /** * Name of the property which should be used to override the default download url for the wrapper. */ private static final String PROPERTY_NAME_WRAPPER_URL = "wrapperUrl"; - public static void main(String args[]) { - System.out.println("- Downloader started"); - File baseDirectory = new File(args[0]); - System.out.println("- Using base directory: " + baseDirectory.getAbsolutePath()); + public static void main( String args[] ) + { + System.out.println( "- Downloader started" ); + File baseDirectory = new File( args[0] ); + System.out.println( "- Using base directory: " + baseDirectory.getAbsolutePath() ); // If the maven-wrapper.properties exists, read it and check if it contains a custom // wrapperUrl parameter. - File mavenWrapperPropertyFile = new File(baseDirectory, MAVEN_WRAPPER_PROPERTIES_PATH); + File mavenWrapperPropertyFile = new File( baseDirectory, MAVEN_WRAPPER_PROPERTIES_PATH ); String url = DEFAULT_DOWNLOAD_URL; - if(mavenWrapperPropertyFile.exists()) { + if ( mavenWrapperPropertyFile.exists() ) + { FileInputStream mavenWrapperPropertyFileInputStream = null; - try { - mavenWrapperPropertyFileInputStream = new FileInputStream(mavenWrapperPropertyFile); + try + { + mavenWrapperPropertyFileInputStream = new FileInputStream( mavenWrapperPropertyFile ); Properties mavenWrapperProperties = new Properties(); - mavenWrapperProperties.load(mavenWrapperPropertyFileInputStream); - url = mavenWrapperProperties.getProperty(PROPERTY_NAME_WRAPPER_URL, url); - } catch (IOException e) { - System.out.println("- ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'"); - } finally { - try { - if(mavenWrapperPropertyFileInputStream != null) { + mavenWrapperProperties.load( mavenWrapperPropertyFileInputStream ); + url = mavenWrapperProperties.getProperty( PROPERTY_NAME_WRAPPER_URL, url ); + } + catch ( IOException e ) + { + System.out.println( "- ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'" ); + } + finally + { + try + { + if ( mavenWrapperPropertyFileInputStream != null ) + { mavenWrapperPropertyFileInputStream.close(); } - } catch (IOException e) { + } + catch ( IOException e ) + { // Ignore ... } } } - System.out.println("- Downloading from: " + url); + System.out.println( "- Downloading from: " + url ); - File outputFile = new File(baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH); - if(!outputFile.getParentFile().exists()) { - if(!outputFile.getParentFile().mkdirs()) { - System.out.println( - "- ERROR creating output directory '" + outputFile.getParentFile().getAbsolutePath() + "'"); + File outputFile = new File( baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH ); + if ( !outputFile.getParentFile().exists() ) + { + if ( !outputFile.getParentFile().mkdirs() ) + { + System.out.println( "- ERROR creating output directory '" + outputFile.getParentFile().getAbsolutePath() + + "'" ); } } - System.out.println("- Downloading to: " + outputFile.getAbsolutePath()); - try { - downloadFileFromURL(url, outputFile); - System.out.println("Done"); - System.exit(0); - } catch (Throwable e) { - System.out.println("- Error downloading"); + System.out.println( "- Downloading to: " + outputFile.getAbsolutePath() ); + try + { + downloadFileFromURL( url, outputFile ); + System.out.println( "Done" ); + System.exit( 0 ); + } + catch ( Throwable e ) + { + System.out.println( "- Error downloading" ); e.printStackTrace(); - System.exit(1); + System.exit( 1 ); } } - private static void downloadFileFromURL(String urlString, File destination) throws Exception { - if (System.getenv("MVNW_USERNAME") != null && System.getenv("MVNW_PASSWORD") != null) { - String username = System.getenv("MVNW_USERNAME"); - char[] password = System.getenv("MVNW_PASSWORD").toCharArray(); - Authenticator.setDefault(new Authenticator() { + private static void downloadFileFromURL( String urlString, File destination ) + throws Exception + { + if ( System.getenv( "MVNW_USERNAME" ) != null && System.getenv( "MVNW_PASSWORD" ) != null ) + { + String username = System.getenv( "MVNW_USERNAME" ); + char[] password = System.getenv( "MVNW_PASSWORD" ).toCharArray(); + Authenticator.setDefault( new Authenticator() + { @Override - protected PasswordAuthentication getPasswordAuthentication() { - return new PasswordAuthentication(username, password); + protected PasswordAuthentication getPasswordAuthentication() + { + return new PasswordAuthentication( username, password ); } - }); + } ); } - URL website = new URL(urlString); + URL website = new URL( urlString ); ReadableByteChannel rbc; - rbc = Channels.newChannel(website.openStream()); - FileOutputStream fos = new FileOutputStream(destination); - fos.getChannel().transferFrom(rbc, 0, Long.MAX_VALUE); + rbc = Channels.newChannel( website.openStream() ); + FileOutputStream fos = new FileOutputStream( destination ); + fos.getChannel().transferFrom( rbc, 0, Long.MAX_VALUE ); fos.close(); rbc.close(); } diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index a9f1ef87b..8c79a83ae 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -1,2 +1,18 @@ -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.3/apache-maven-3.8.3-bin.zip -wrapperUrl=https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip +wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar diff --git a/mvnw b/mvnw index a16b5431b..5643201c7 100755 --- a/mvnw +++ b/mvnw @@ -8,7 +8,7 @@ # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at # -# https://www.apache.org/licenses/LICENSE-2.0 +# http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an @@ -36,6 +36,10 @@ if [ -z "$MAVEN_SKIP_RC" ] ; then + if [ -f /usr/local/etc/mavenrc ] ; then + . /usr/local/etc/mavenrc + fi + if [ -f /etc/mavenrc ] ; then . /etc/mavenrc fi @@ -145,7 +149,7 @@ if [ -z "$JAVACMD" ] ; then JAVACMD="$JAVA_HOME/bin/java" fi else - JAVACMD="`which java`" + JAVACMD="`\\unset -f command; \\command -v java`" fi fi @@ -212,9 +216,9 @@ else echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..." fi if [ -n "$MVNW_REPOURL" ]; then - jarUrl="$MVNW_REPOURL/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar" + jarUrl="$MVNW_REPOURL/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar" else - jarUrl="https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar" + jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar" fi while IFS="=" read key value; do case "$key" in (wrapperUrl) jarUrl="$value"; break ;; @@ -233,9 +237,9 @@ else echo "Found wget ... using wget" fi if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then - wget "$jarUrl" -O "$wrapperJarPath" + wget "$jarUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath" else - wget --http-user=$MVNW_USERNAME --http-password=$MVNW_PASSWORD "$jarUrl" -O "$wrapperJarPath" + wget --http-user=$MVNW_USERNAME --http-password=$MVNW_PASSWORD "$jarUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath" fi elif command -v curl > /dev/null; then if [ "$MVNW_VERBOSE" = true ]; then @@ -305,6 +309,8 @@ WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain exec "$JAVACMD" \ $MAVEN_OPTS \ + $MAVEN_DEBUG_OPTS \ -classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \ - "-Dmaven.home=${M2_HOME}" "-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \ + "-Dmaven.home=${M2_HOME}" \ + "-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \ ${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@" diff --git a/mvnw.cmd b/mvnw.cmd index c8d43372c..8a15b7f31 100644 --- a/mvnw.cmd +++ b/mvnw.cmd @@ -7,7 +7,7 @@ @REM "License"); you may not use this file except in compliance @REM with the License. You may obtain a copy of the License at @REM -@REM https://www.apache.org/licenses/LICENSE-2.0 +@REM http://www.apache.org/licenses/LICENSE-2.0 @REM @REM Unless required by applicable law or agreed to in writing, @REM software distributed under the License is distributed on an @@ -46,8 +46,8 @@ if "%HOME%" == "" (set "HOME=%HOMEDRIVE%%HOMEPATH%") @REM Execute a user defined script before this one if not "%MAVEN_SKIP_RC%" == "" goto skipRcPre @REM check for pre script, once with legacy .bat ending and once with .cmd ending -if exist "%HOME%\mavenrc_pre.bat" call "%HOME%\mavenrc_pre.bat" -if exist "%HOME%\mavenrc_pre.cmd" call "%HOME%\mavenrc_pre.cmd" +if exist "%USERPROFILE%\mavenrc_pre.bat" call "%USERPROFILE%\mavenrc_pre.bat" %* +if exist "%USERPROFILE%\mavenrc_pre.cmd" call "%USERPROFILE%\mavenrc_pre.cmd" %* :skipRcPre @setlocal @@ -120,9 +120,9 @@ SET MAVEN_JAVA_EXE="%JAVA_HOME%\bin\java.exe" set WRAPPER_JAR="%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.jar" set WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain -set DOWNLOAD_URL="https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar" +set DOWNLOAD_URL="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar" -FOR /F "tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.properties") DO ( +FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.properties") DO ( IF "%%A"=="wrapperUrl" SET DOWNLOAD_URL=%%B ) @@ -134,7 +134,7 @@ if exist %WRAPPER_JAR% ( ) ) else ( if not "%MVNW_REPOURL%" == "" ( - SET DOWNLOAD_URL="%MVNW_REPOURL%/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar" + SET DOWNLOAD_URL="%MVNW_REPOURL%/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar" ) if "%MVNW_VERBOSE%" == "true" ( echo Couldn't find %WRAPPER_JAR%, downloading it ... @@ -158,7 +158,13 @@ if exist %WRAPPER_JAR% ( @REM work with both Windows and non-Windows executions. set MAVEN_CMD_LINE_ARGS=%* -%MAVEN_JAVA_EXE% %JVM_CONFIG_MAVEN_PROPS% %MAVEN_OPTS% %MAVEN_DEBUG_OPTS% -classpath %WRAPPER_JAR% "-Dmaven.multiModuleProjectDirectory=%MAVEN_PROJECTBASEDIR%" %WRAPPER_LAUNCHER% %MAVEN_CONFIG% %* +%MAVEN_JAVA_EXE% ^ + %JVM_CONFIG_MAVEN_PROPS% ^ + %MAVEN_OPTS% ^ + %MAVEN_DEBUG_OPTS% ^ + -classpath %WRAPPER_JAR% ^ + "-Dmaven.multiModuleProjectDirectory=%MAVEN_PROJECTBASEDIR%" ^ + %WRAPPER_LAUNCHER% %MAVEN_CONFIG% %* if ERRORLEVEL 1 goto error goto end @@ -168,15 +174,15 @@ set ERROR_CODE=1 :end @endlocal & set ERROR_CODE=%ERROR_CODE% -if not "%MAVEN_SKIP_RC%" == "" goto skipRcPost +if not "%MAVEN_SKIP_RC%"=="" goto skipRcPost @REM check for post script, once with legacy .bat ending and once with .cmd ending -if exist "%HOME%\mavenrc_post.bat" call "%HOME%\mavenrc_post.bat" -if exist "%HOME%\mavenrc_post.cmd" call "%HOME%\mavenrc_post.cmd" +if exist "%USERPROFILE%\mavenrc_post.bat" call "%USERPROFILE%\mavenrc_post.bat" +if exist "%USERPROFILE%\mavenrc_post.cmd" call "%USERPROFILE%\mavenrc_post.cmd" :skipRcPost @REM pause the script if MAVEN_BATCH_PAUSE is set to 'on' -if "%MAVEN_BATCH_PAUSE%" == "on" pause +if "%MAVEN_BATCH_PAUSE%"=="on" pause -if "%MAVEN_TERMINATE_CMD%" == "on" exit %ERROR_CODE% +if "%MAVEN_TERMINATE_CMD%"=="on" exit %ERROR_CODE% -exit /B %ERROR_CODE% +cmd /C exit /B %ERROR_CODE% From 15b5b51bb0d0c81d9cd84685354be31510fbe142 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 4 Jan 2022 10:00:02 -0500 Subject: [PATCH 0616/1013] [actions] Add github action to run entirely through maven 3.3.9 In order to show that plugin is compatible with 3.3.9 --- .github/workflows/it-maven339.yaml | 40 ++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 .github/workflows/it-maven339.yaml diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml new file mode 100644 index 000000000..efc993826 --- /dev/null +++ b/.github/workflows/it-maven339.yaml @@ -0,0 +1,40 @@ +# +# Copyright 2011-2020 the original author or authors. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# You may obtain a copy of the License at +# +# https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# + +name: Java Integration Tests + +on: [push, pull_request] + +jobs: + test: + runs-on: ubuntu-latest + name: Integration Tests + + steps: + - uses: actions/checkout@v2 + - name: Set up JDK + uses: actions/setup-java@v2 + with: + java-version: 11 + distribution: 'zulu' + - name: Load Maven 3.3.9 + run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.0 -DmavenVersion=3.3.9 + - name: Build Setup + run: ./mvnw clean install -Dmaven.min-version=3.3.9 + - name: Integration Test with Maven + run: ./mvnw -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 From 7ceb76b9bb290eb393eea8f52eaced6cdc8281f5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 4 Jan 2022 10:02:25 -0500 Subject: [PATCH 0617/1013] [actions] Adjust name for wrapper 3.3.9 usage and wrapper goal --- .github/workflows/it-maven339.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index efc993826..b92cbbdf4 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -16,7 +16,7 @@ # GNU General Public License for more details. # -name: Java Integration Tests +name: Java Integration Tests Maven 3.3.9 on: [push, pull_request] @@ -33,7 +33,7 @@ jobs: java-version: 11 distribution: 'zulu' - name: Load Maven 3.3.9 - run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.0 -DmavenVersion=3.3.9 + run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper -DmavenVersion=3.3.9 - name: Build Setup run: ./mvnw clean install -Dmaven.min-version=3.3.9 - name: Integration Test with Maven From 477b67e3277a419386c384830b831b59fd2bf188 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 08:56:40 -0500 Subject: [PATCH 0618/1013] [pom] Bump spotbugs to 4.5.3 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index e863e4e89..d4a5c4ff8 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.2.1-SNAPSHOT + 4.5.3.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -121,8 +121,8 @@ ${project.version} 5.8.2 - 4.5.2 - 4.5.2 + 4.5.3 + 4.5.3 1.7.32 1.10.12 From ae3658622b8590836b7994801526c39e52f2e76f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 11:39:30 -0500 Subject: [PATCH 0619/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.5.3.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index d4a5c4ff8..156998e78 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.3.0-SNAPSHOT + 4.5.3.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.5.3.0 GitHub Issues From 0ff6b2544441c242300ceed937b08f47f67a08c4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 11:39:34 -0500 Subject: [PATCH 0620/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 156998e78..c26d4f0a5 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.3.0 + 4.5.3.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.5.3.0 + HEAD GitHub Issues From 56a8edd22b6b75bbcdbf208f3a6861ad312d920d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 11:46:20 -0500 Subject: [PATCH 0621/1013] [site] Bump maven-fluido-skin to 1.10.0 --- src/site/site.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/site/site.xml b/src/site/site.xml index 885011da8..2080b3e4a 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -10,7 +10,7 @@ org.apache.maven.skins maven-fluido-skin - 1.7 + 1.10.0 From fb2b3fc4996f3b2a0d8e636b552f791f80181d45 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 12:05:58 -0500 Subject: [PATCH 0622/1013] [pom] Add patches to ensure site works after recent deprecation changes --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index c26d4f0a5..c9f3b2c16 100644 --- a/pom.xml +++ b/pom.xml @@ -120,6 +120,12 @@ ${project.version} + + 4.5.3 + + + 1.5.1 + 5.8.2 4.5.3 4.5.3 From 0e0029a7847aba2a9657bb6a8e5fd9191072d5fd Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 5 Jan 2022 12:16:38 -0500 Subject: [PATCH 0623/1013] [actions] Further rename on integration tests for maven 3.3.9 --- .github/workflows/it-maven339.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index b92cbbdf4..2cb56c346 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -23,7 +23,7 @@ on: [push, pull_request] jobs: test: runs-on: ubuntu-latest - name: Integration Tests + name: Integration Tests Maven 3.3.9 steps: - uses: actions/checkout@v2 From 00e07597a8c44161210b5ed450738fc7b02abf03 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 13 Jan 2022 19:02:23 +0000 Subject: [PATCH 0624/1013] Bump slf4jVersion from 1.7.32 to 1.7.33 Bumps `slf4jVersion` from 1.7.32 to 1.7.33. Updates `jcl-over-slf4j` from 1.7.32 to 1.7.33 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33) Updates `slf4j-simple` from 1.7.32 to 1.7.33 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33) Updates `slf4j-api` from 1.7.32 to 1.7.33 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.32...v_1.7.33) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c9f3b2c16..ee45e608d 100644 --- a/pom.xml +++ b/pom.xml @@ -129,7 +129,7 @@ 5.8.2 4.5.3 4.5.3 - 1.7.32 + 1.7.33 1.10.12 3.0.9 From 67626366d33b3df0cbfc74e7016af778a8420b86 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 18 Jan 2022 19:01:51 +0000 Subject: [PATCH 0625/1013] Bump pluginPluginVersion from 3.6.2 to 3.6.4 Bumps `pluginPluginVersion` from 3.6.2 to 3.6.4. Updates `maven-plugin-annotations` from 3.6.2 to 3.6.4 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4) Updates `maven-plugin-plugin` from 3.6.2 to 3.6.4 - [Release notes](https://github.com/apache/maven-plugin-tools/releases) - [Commits](https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.6.2...maven-plugin-tools-3.6.4) --- updated-dependencies: - dependency-name: org.apache.maven.plugin-tools:maven-plugin-annotations dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-plugin-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ee45e608d..e5b5656f0 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ 3.1.2 3.2.2 3.3.1 - 3.6.2 + 3.6.4 1.12.2 3.10.0 3.6 From 622c9bc6ea25c2c9a33cbeb4540e3cff971d6d10 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 21:50:15 -0500 Subject: [PATCH 0626/1013] [pom] Bump to base-parent 31 and remove pdf override as in parent --- pom.xml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index e5b5656f0..ab0180df6 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 30 + 31 @@ -123,9 +123,6 @@ 4.5.3 - - 1.5.1 - 5.8.2 4.5.3 4.5.3 From ba9daa65f4e5bd0f0533f4d46c24dbb944e75e2f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 21:52:28 -0500 Subject: [PATCH 0627/1013] [pom] Bump maven compiler plugin to 3.9.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ab0180df6..e6da12b19 100644 --- a/pom.xml +++ b/pom.xml @@ -172,7 +172,7 @@ true - 3.8.1 + 3.9.0 1.10.1 3.0.0 3.0.0-M5 From 1d5492c54666d841ade45f58f57a254b7c516459 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 21:54:29 -0500 Subject: [PATCH 0628/1013] [pom] Add ci management and adjust name on issue management --- pom.xml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e6da12b19..0c81ae0c2 100644 --- a/pom.xml +++ b/pom.xml @@ -97,9 +97,13 @@ HEAD - GitHub Issues + Github https://github.com/spotbugs/spotbugs-maven-plugin/issues + + Github + https://github.com/spotbugs/spotbugs-maven-plugin/actions + ossrh From 4d10aca752d5fbbf5179a050dd81d5752b50afdd Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 21:55:27 -0500 Subject: [PATCH 0629/1013] [pom] Remove duplication of distro located in parent --- pom.xml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pom.xml b/pom.xml index 0c81ae0c2..2fcd6e3e5 100644 --- a/pom.xml +++ b/pom.xml @@ -105,14 +105,6 @@ https://github.com/spotbugs/spotbugs-maven-plugin/actions - - ossrh - https://oss.sonatype.org/service/local/staging/deploy/maven2/ - - - ossrh - https://oss.sonatype.org/content/repositories/snapshots - gh-pages-scm scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git From e3afea8b3720549c79c189e598ae0beb3196b71e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 21:56:48 -0500 Subject: [PATCH 0630/1013] [pom] Modify organization to spotbugs --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 2fcd6e3e5..a1c53e362 100644 --- a/pom.xml +++ b/pom.xml @@ -26,8 +26,8 @@ - Garvin Leclaire - https://github.com/gleclaire + Spotbugs + https://spotbugs.github.io/ From 822b74ac8f41767620d5618a1c6a7da062c65a08 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 22:00:29 -0500 Subject: [PATCH 0631/1013] [pom] Fix ci management tag --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a1c53e362..d1897aa1e 100644 --- a/pom.xml +++ b/pom.xml @@ -103,7 +103,7 @@ Github https://github.com/spotbugs/spotbugs-maven-plugin/actions - + gh-pages-scm From e66ac4b9cf39eb438cfea8116a79be98c06cb3b6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 18 Jan 2022 22:03:42 -0500 Subject: [PATCH 0632/1013] [pom] Use '1.8' for java.version as groovy dislikes '8' --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index d1897aa1e..8f83d744b 100644 --- a/pom.xml +++ b/pom.xml @@ -119,6 +119,9 @@ 4.5.3 + + 1.8 + 5.8.2 4.5.3 4.5.3 From ff57b229e80ede24837d54f737dbdb738845b6c8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 21 Jan 2022 19:03:34 +0000 Subject: [PATCH 0633/1013] Bump versions-maven-plugin from 2.8.1 to 2.9.0 Bumps [versions-maven-plugin](https://github.com/mojohaus/versions-maven-plugin) from 2.8.1 to 2.9.0. - [Release notes](https://github.com/mojohaus/versions-maven-plugin/releases) - [Changelog](https://github.com/mojohaus/versions-maven-plugin/blob/master/ReleaseNotes.md) - [Commits](https://github.com/mojohaus/versions-maven-plugin/compare/versions-maven-plugin-2.8.1...versions-maven-plugin-2.9.0) --- updated-dependencies: - dependency-name: org.codehaus.mojo:versions-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8f83d744b..120d50643 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ 1.12.2 3.10.0 3.6 - 2.8.1 + 2.9.0 false ${project.build.directory}/it-src-spotbugs From 017d7630766ff393f2844930d3d2ebbe12e7a409 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 25 Jan 2022 19:02:16 +0000 Subject: [PATCH 0634/1013] Bump slf4jVersion from 1.7.33 to 1.7.35 Bumps `slf4jVersion` from 1.7.33 to 1.7.35. Updates `jcl-over-slf4j` from 1.7.33 to 1.7.35 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.33...v_1.7.35) Updates `slf4j-simple` from 1.7.33 to 1.7.35 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.33...v_1.7.35) Updates `slf4j-api` from 1.7.33 to 1.7.35 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.33...v_1.7.35) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 120d50643..8576b9662 100644 --- a/pom.xml +++ b/pom.xml @@ -125,7 +125,7 @@ 5.8.2 4.5.3 4.5.3 - 1.7.33 + 1.7.35 1.10.12 3.0.9 From 3b2e6e8c12b535097ac626afe94d2e72150a92f7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 31 Jan 2022 19:02:00 +0000 Subject: [PATCH 0635/1013] Bump maven-profiler from 3.1.1 to 3.2 Bumps [maven-profiler](https://github.com/jcgay/maven-profiler) from 3.1.1 to 3.2. - [Release notes](https://github.com/jcgay/maven-profiler/releases) - [Changelog](https://github.com/jcgay/maven-profiler/blob/master/CHANGELOG.md) - [Commits](https://github.com/jcgay/maven-profiler/compare/v3.1.1...v3.2) --- updated-dependencies: - dependency-name: fr.jcgay.maven:maven-profiler dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .mvn/extensions.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml index 4a35ac239..6463f95c7 100644 --- a/.mvn/extensions.xml +++ b/.mvn/extensions.xml @@ -3,6 +3,6 @@ fr.jcgay.maven maven-profiler - 3.1.1 + 3.2 From 79440ba679d48ef647bc5f0e8becacc6bf6c756f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 1 Feb 2022 12:47:22 -0500 Subject: [PATCH 0636/1013] [groovy] First pass to upgrade to groovy 4 will address cleaning up exclusions afterwards as those were related to using indy and groovy pulling in non indy artifacts we did not want so we stayed modern. Now groovy uses the indy (jdk7+) style and dropped the 'indy' items. So all exclusions here need reviewed as likely will just be removed. --- pom.xml | 56 ++++++++----------- .../mojo/spotbugs/SpotBugsMojo.groovy | 11 +--- 2 files changed, 27 insertions(+), 40 deletions(-) diff --git a/pom.xml b/pom.xml index 8576b9662..bba73ae83 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.7.35 1.10.12 - 3.0.9 + 4.0.0 1.11.1 1.11.1 @@ -220,17 +220,15 @@ - org.codehaus.groovy + org.apache.groovy groovy ${groovyVersion} - indy - org.codehaus.groovy + org.apache.groovy groovy-ant ${groovyVersion} - indy org.apache.ant @@ -241,107 +239,101 @@ ant-antlr - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-groovydoc - org.codehaus.groovy + org.apache.groovy groovy-dateutil ${groovyVersion} - indy - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-docgenerator ${groovyVersion} runtime - indy - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-templates - org.codehaus.groovy + org.apache.groovy groovy-groovydoc ${groovyVersion} - indy - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-docgenerator - org.codehaus.groovy + org.apache.groovy groovy-templates - org.codehaus.groovy + org.apache.groovy groovy-templates ${groovyVersion} runtime - indy - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-xml - org.codehaus.groovy + org.apache.groovy groovy-xml ${groovyVersion} - indy - org.codehaus.groovy + org.apache.groovy groovy - org.codehaus.groovy + org.apache.groovy groovy-json ${groovyVersion} - indy - org.codehaus.groovy + org.apache.groovy groovy @@ -673,7 +665,7 @@ - org.codehaus.groovy + org.apache.groovy groovy ${groovyVersion} @@ -872,14 +864,14 @@ - org.codehaus.groovy + org.apache.groovy groovy-all ${groovyVersion} pom - org.codehaus.groovy + org.apache.groovy groovy-testng diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 5e6090508..7f12ac041 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -19,31 +19,26 @@ package org.codehaus.mojo.spotbugs * under the License. */ +import groovy.ant.AntBuilder import groovy.json.JsonBuilder - import groovy.json.JsonSlurper import groovy.xml.XmlSlurper import groovy.xml.StreamingMarkupBuilder -import org.apache.maven.artifact.repository.ArtifactRepository +import org.apache.maven.artifact.repository.ArtifactRepository import org.apache.maven.doxia.siterenderer.Renderer import org.apache.maven.doxia.tools.SiteTool - import org.apache.maven.execution.MavenSession import org.apache.maven.plugin.MojoExecutionException - import org.apache.maven.plugins.annotations.Component import org.apache.maven.plugins.annotations.Mojo import org.apache.maven.plugins.annotations.Parameter import org.apache.maven.plugins.annotations.ResolutionScope - import org.apache.maven.project.MavenProject - import org.apache.maven.reporting.AbstractMavenReport - import org.apache.maven.repository.RepositorySystem - import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResolver + import org.codehaus.plexus.resource.ResourceManager import org.codehaus.plexus.resource.loader.FileResourceLoader From cf19a621265d3d5f8e6a4e6d863a9d057cfeb22e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 1 Feb 2022 13:04:33 -0500 Subject: [PATCH 0637/1013] [pom] Cleanup groovy exclusions --- pom.xml | 60 --------------------------------------------------------- 1 file changed, 60 deletions(-) diff --git a/pom.xml b/pom.xml index bba73ae83..68a506627 100644 --- a/pom.xml +++ b/pom.xml @@ -238,14 +238,6 @@ org.apache.ant ant-antlr - - org.apache.groovy - groovy - - - org.apache.groovy - groovy-groovydoc - @@ -253,12 +245,6 @@ org.apache.groovy groovy-dateutil ${groovyVersion} - - - org.apache.groovy - groovy - - @@ -266,36 +252,12 @@ groovy-docgenerator ${groovyVersion} runtime - - - org.apache.groovy - groovy - - - org.apache.groovy - groovy-templates - - org.apache.groovy groovy-groovydoc ${groovyVersion} - - - org.apache.groovy - groovy - - - org.apache.groovy - groovy-docgenerator - - - org.apache.groovy - groovy-templates - - @@ -303,40 +265,18 @@ groovy-templates ${groovyVersion} runtime - - - org.apache.groovy - groovy - - - org.apache.groovy - groovy-xml - - org.apache.groovy groovy-xml ${groovyVersion} - - - org.apache.groovy - groovy - - org.apache.groovy groovy-json ${groovyVersion} - - - org.apache.groovy - groovy - - From 6fdda76dcadeccb8c6d96fdcc3fe2673d4e820e0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 1 Feb 2022 13:48:54 -0500 Subject: [PATCH 0638/1013] [pom] Drop direct call on groovy-groovydoc as pulled in via groovy-ant --- pom.xml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/pom.xml b/pom.xml index 68a506627..f75c64a1a 100644 --- a/pom.xml +++ b/pom.xml @@ -254,12 +254,6 @@ runtime - - org.apache.groovy - groovy-groovydoc - ${groovyVersion} - - org.apache.groovy groovy-templates From 7107e8a17aa9bf5f6a6f7a1b7e997375a40f8062 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 1 Feb 2022 14:04:59 -0500 Subject: [PATCH 0639/1013] [pom] Move around groovy artifacts to order them --- pom.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index f75c64a1a..6971e7893 100644 --- a/pom.xml +++ b/pom.xml @@ -256,20 +256,20 @@ org.apache.groovy - groovy-templates + groovy-json ${groovyVersion} - runtime org.apache.groovy - groovy-xml + groovy-templates ${groovyVersion} + runtime org.apache.groovy - groovy-json + groovy-xml ${groovyVersion} From 11c64039e2d5d061f5122d7337ef3ce3ae1b2c66 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 1 Feb 2022 19:25:17 -0500 Subject: [PATCH 0640/1013] [pom] Reorganize some dependencies and add some comments on sections --- pom.xml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/pom.xml b/pom.xml index 6971e7893..f9fd62e57 100644 --- a/pom.xml +++ b/pom.xml @@ -195,17 +195,24 @@ + com.github.spotbugs spotbugs ${spotbugsVersion} + org.slf4j jcl-over-slf4j ${slf4jVersion} + + org.slf4j + slf4j-api + ${slf4jVersion} + org.slf4j slf4j-simple @@ -219,6 +226,7 @@ ${antVersion} + org.apache.groovy groovy @@ -273,6 +281,7 @@ ${groovyVersion} + org.apache.maven.reporting maven-reporting-impl @@ -493,13 +502,6 @@ ${plexusUtilsVersion} - - - org.slf4j - slf4j-api - ${slf4jVersion} - - org.ow2.asm From fe061ae0a03897c40afd2f319680ca8890d2cfda Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 7 Feb 2022 19:02:27 +0000 Subject: [PATCH 0641/1013] Bump maven-reporting-api from 3.0 to 3.1.0 Bumps [maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.0 to 3.1.0. - [Release notes](https://github.com/apache/maven-reporting-api/releases) - [Commits](https://github.com/apache/maven-reporting-api/compare/maven-reporting-api-3.0...maven-reporting-api-3.1.0) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f9fd62e57..6a53af314 100644 --- a/pom.xml +++ b/pom.xml @@ -137,7 +137,7 @@ 3.3.4 0.13.1 3.2.0 - 3.0 + 3.1.0 3.0.0 3.8.4 From 76d6cddaf9d13adea3b0210d7e53ed91a15043f7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 7 Feb 2022 19:02:36 +0000 Subject: [PATCH 0642/1013] Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.1 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.1.2 to 3.2.1. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.1.2...maven-project-info-reports-plugin-3.2.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f9fd62e57..6085d2f44 100644 --- a/pom.xml +++ b/pom.xml @@ -149,7 +149,7 @@ 1.8 0.22-1 1.13.1 - 3.1.2 + 3.2.1 3.2.2 3.3.1 3.6.4 From 71022a3ec9d64a9c610842e7c5d43973825d6c01 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 8 Feb 2022 19:01:38 +0000 Subject: [PATCH 0643/1013] Bump slf4jVersion from 1.7.35 to 1.7.36 Bumps `slf4jVersion` from 1.7.35 to 1.7.36. Updates `jcl-over-slf4j` from 1.7.35 to 1.7.36 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.35...v_1.7.36) Updates `slf4j-api` from 1.7.35 to 1.7.36 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.35...v_1.7.36) Updates `slf4j-simple` from 1.7.35 to 1.7.36 - [Release notes](https://github.com/qos-ch/slf4j/releases) - [Commits](https://github.com/qos-ch/slf4j/compare/v_1.7.35...v_1.7.36) --- updated-dependencies: - dependency-name: org.slf4j:jcl-over-slf4j dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.slf4j:slf4j-simple dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a13223e17..f4194711d 100644 --- a/pom.xml +++ b/pom.xml @@ -125,7 +125,7 @@ 5.8.2 4.5.3 4.5.3 - 1.7.35 + 1.7.36 1.10.12 4.0.0 From c4ddf17e4a49fe18aca35154be950938e8cc58d1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 10 Feb 2022 19:02:24 +0000 Subject: [PATCH 0644/1013] Bump maven-reporting-impl from 3.0.0 to 3.1.0 Bumps [maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/apache/maven-reporting-impl/releases) - [Commits](https://github.com/apache/maven-reporting-impl/commits/maven-reporting-impl-3.1.0) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-impl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f4194711d..1b4ed11f5 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 0.13.1 3.2.0 3.1.0 - 3.0.0 + 3.1.0 3.8.4 2.1.1 From a2ec4301819c6658b67666f94375b97773bb20d8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 11 Feb 2022 19:02:00 +0000 Subject: [PATCH 0645/1013] Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.3.2. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.1...maven-javadoc-plugin-3.3.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1b4ed11f5..1cab753c8 100644 --- a/pom.xml +++ b/pom.xml @@ -151,7 +151,7 @@ 1.13.1 3.2.1 3.2.2 - 3.3.1 + 3.3.2 3.6.4 1.12.2 3.10.0 From 11798afebb42d08e1f366d16167b0058a88a963b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Siersze=C5=84?= Date: Tue, 15 Feb 2022 18:03:27 +0100 Subject: [PATCH 0646/1013] Added separate goals for check and verify (fixes #114) --- README.md | 7 +++ src/it/verify-fail/invoker.properties | 4 ++ src/it/verify-fail/pom.xml | 59 +++++++++++++++++++ src/it/verify-fail/verify.groovy | 18 ++++++ src/it/verify/invoker.properties | 4 ++ src/it/verify/pom.xml | 59 +++++++++++++++++++ src/it/verify/verify.groovy | 50 ++++++++++++++++ ...o.groovy => BaseViolationCheckMojo.groovy} | 11 +--- .../codehaus/mojo/spotbugs/CheckMojo.groovy | 37 ++++++++++++ .../codehaus/mojo/spotbugs/VerifyMojo.groovy | 35 +++++++++++ 10 files changed, 274 insertions(+), 10 deletions(-) create mode 100644 src/it/verify-fail/invoker.properties create mode 100644 src/it/verify-fail/pom.xml create mode 100644 src/it/verify-fail/verify.groovy create mode 100644 src/it/verify/invoker.properties create mode 100644 src/it/verify/pom.xml create mode 100644 src/it/verify/verify.groovy rename src/main/groovy/org/codehaus/mojo/spotbugs/{SpotbugsViolationCheckMojo.groovy => BaseViolationCheckMojo.groovy} (96%) create mode 100644 src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy create mode 100644 src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy diff --git a/README.md b/README.md index 59742bde4..d7614fd0e 100644 --- a/README.md +++ b/README.md @@ -63,3 +63,10 @@ Run gui with a specific version ``` mvn com.github.spotbugs:spotbugs-maven-plugin:4.0.0:gui ``` + +## Contributing ## + +Run integration tests +``` +mvn clean install -P run-its -DtestSrc=remote +``` diff --git a/src/it/verify-fail/invoker.properties b/src/it/verify-fail/invoker.properties new file mode 100644 index 000000000..bf0b3fc59 --- /dev/null +++ b/src/it/verify-fail/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean verify + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = failure diff --git a/src/it/verify-fail/pom.xml b/src/it/verify-fail/pom.xml new file mode 100644 index 000000000..fdfe5776f --- /dev/null +++ b/src/it/verify-fail/pom.xml @@ -0,0 +1,59 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check + check + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + High + + + + run-analysis + process-classes + + spotbugs + + + + process-results + + verify + + + + + + + diff --git a/src/it/verify-fail/verify.groovy b/src/it/verify-fail/verify.groovy new file mode 100644 index 000000000..c509ec221 --- /dev/null +++ b/src/it/verify-fail/verify.groovy @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/it/verify/invoker.properties b/src/it/verify/invoker.properties new file mode 100644 index 000000000..878b37e9e --- /dev/null +++ b/src/it/verify/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean verify + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/verify/pom.xml b/src/it/verify/pom.xml new file mode 100644 index 000000000..e2e69cb66 --- /dev/null +++ b/src/it/verify/pom.xml @@ -0,0 +1,59 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check + check + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + false + @spotbugsTestDebug@ + High + + + + run-analysis + process-classes + + spotbugs + + + + process-results + + verify + + + + + + + diff --git a/src/it/verify/verify.groovy b/src/it/verify/verify.groovy new file mode 100644 index 000000000..ae8effc60 --- /dev/null +++ b/src/it/verify/verify.groovy @@ -0,0 +1,50 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert !spotbugsHtml.exists() + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +def path = new XmlSlurper().parse(spotbugXdoc) + +xNodes = path.depthFirst().collect{ it } +def xdocErrors = xNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + +assert xdocErrors == spotbugsXmlErrors diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy similarity index 96% rename from src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy rename to src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 197f12461..8f02039bc 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -46,16 +46,7 @@ import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResolver import org.codehaus.plexus.resource.ResourceManager import org.codehaus.plexus.util.FileUtils -/** - * Fail the build if there were any SpotBugs violations in the source code. - * An XML report is put out by default in the target directory with the errors. - * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. - * - * @since 2.0 - */ -@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) -@Execute( goal = "spotbugs") -class SpotbugsViolationCheckMojo extends AbstractMojo { +abstract class BaseViolationCheckMojo extends AbstractMojo { /** * Location where generated html will be created. diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy new file mode 100644 index 000000000..f37c9e49b --- /dev/null +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy @@ -0,0 +1,37 @@ +package org.codehaus.mojo.spotbugs + +import org.apache.maven.plugins.annotations.Execute +import org.apache.maven.plugins.annotations.LifecyclePhase +import org.apache.maven.plugins.annotations.Mojo +import org.apache.maven.plugins.annotations.ResolutionScope + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * Fail the build if there were any SpotBugs violations in the source code. + * An XML report is put out by default in the target directory with the errors. + * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. + * + * @since 2.0 + */ +@Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) +@Execute( goal = "spotbugs") +class CheckMojo extends BaseViolationCheckMojo { +} diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy new file mode 100644 index 000000000..53be7a588 --- /dev/null +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy @@ -0,0 +1,35 @@ +package org.codehaus.mojo.spotbugs + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.maven.plugins.annotations.LifecyclePhase +import org.apache.maven.plugins.annotations.Mojo +import org.apache.maven.plugins.annotations.ResolutionScope + +/** + * Fail the build if any SpotBugs violations can be found in a preexisting {@code spotBugs.xml} file. + * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. + * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. + * + * @since 4.5 + */ +@Mojo( name = "verify", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) +class VerifyMojo extends BaseViolationCheckMojo { +} From af271382f9aecd63a2053f78cb769b6e469737e7 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 17 Feb 2022 19:01:37 +0000 Subject: [PATCH 0647/1013] Bump maven-site-plugin from 3.10.0 to 3.11.0 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.10.0 to 3.11.0. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.10.0...maven-site-plugin-3.11.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1cab753c8..e1fe609c6 100644 --- a/pom.xml +++ b/pom.xml @@ -154,7 +154,7 @@ 3.3.2 3.6.4 1.12.2 - 3.10.0 + 3.11.0 3.6 2.9.0 From 0e4d1ea80a1ba8d2f9ad48995409dd6d1d819f7f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 25 Feb 2022 19:01:50 +0000 Subject: [PATCH 0648/1013] Bump maven-project-info-reports-plugin from 3.2.1 to 3.2.2 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.2.1...maven-project-info-reports-plugin-3.2.2) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e1fe609c6..4fa800f61 100644 --- a/pom.xml +++ b/pom.xml @@ -149,7 +149,7 @@ 1.8 0.22-1 1.13.1 - 3.2.1 + 3.2.2 3.2.2 3.3.2 3.6.4 From aaacd2efee123d6326cc523c44bac3097b40095b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 8 Mar 2022 19:12:49 +0000 Subject: [PATCH 0649/1013] Bump spotbugs from 4.5.3 to 4.6.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.5.3 to 4.6.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.5.3...4.6.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4fa800f61..9c111a100 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 1.8 5.8.2 - 4.5.3 + 4.6.0 4.5.3 1.7.36 From 9e2265fb56bfd9e9409328f9babd01c55f25711d Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 8 Mar 2022 19:13:01 +0000 Subject: [PATCH 0650/1013] Bump groovyVersion from 4.0.0 to 4.0.1 Bumps `groovyVersion` from 4.0.0 to 4.0.1. Updates `groovy` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-json` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 4.0.0 to 4.0.1 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.apache.groovy:groovy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-ant dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-dateutil dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-docgenerator dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-json dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-templates dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-xml dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4fa800f61..0ffbc211a 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.7.36 1.10.12 - 4.0.0 + 4.0.1 1.11.1 1.11.1 From 047836cedbf0e76cffda1051fb90df7e911959e3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 14 Mar 2022 19:02:12 +0000 Subject: [PATCH 0651/1013] Bump mavenCoreVersion from 3.8.4 to 3.8.5 Bumps `mavenCoreVersion` from 3.8.4 to 3.8.5. Updates `maven-core` from 3.8.4 to 3.8.5 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5) Updates `maven-model` from 3.8.4 to 3.8.5 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5) --- updated-dependencies: - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-model dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index cc8dff826..d8e3af8d6 100644 --- a/pom.xml +++ b/pom.xml @@ -133,7 +133,7 @@ 1.11.1 1.11.1 - 3.8.4 + 3.8.5 3.3.4 0.13.1 3.2.0 From 4b591e2ad1f8d3fd14c583d1badb319580b4cfd4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 14 Mar 2022 22:33:24 +0000 Subject: [PATCH 0652/1013] Bump mavenVersion from 3.8.4 to 3.8.5 Bumps `mavenVersion` from 3.8.4 to 3.8.5. Updates `maven-plugin-api` from 3.8.4 to 3.8.5 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5) Updates `maven-artifact` from 3.8.4 to 3.8.5 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d8e3af8d6..0aa0acc2e 100644 --- a/pom.xml +++ b/pom.xml @@ -139,7 +139,7 @@ 3.2.0 3.1.0 3.1.0 - 3.8.4 + 3.8.5 2.1.1 1.2.0 From c51b51c842ada8f91085fec4090e31a0ebc72ca8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 15 Mar 2022 19:01:54 +0000 Subject: [PATCH 0653/1013] Bump versions-maven-plugin from 2.9.0 to 2.10.0 Bumps [versions-maven-plugin](https://github.com/mojohaus/versions-maven-plugin) from 2.9.0 to 2.10.0. - [Release notes](https://github.com/mojohaus/versions-maven-plugin/releases) - [Changelog](https://github.com/mojohaus/versions-maven-plugin/blob/master/ReleaseNotes.md) - [Commits](https://github.com/mojohaus/versions-maven-plugin/compare/versions-maven-plugin-2.9.0...versions-maven-plugin-2.10.0) --- updated-dependencies: - dependency-name: org.codehaus.mojo:versions-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0aa0acc2e..f932aef63 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ 1.12.2 3.11.0 3.6 - 2.9.0 + 2.10.0 false ${project.build.directory}/it-src-spotbugs From 7e022d79676d398e9a1ad207af10327a783998e2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 14:01:53 -0400 Subject: [PATCH 0654/1013] [pom] Bump remainder to spotbugs 4.6.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index f932aef63..d2de219e2 100644 --- a/pom.xml +++ b/pom.xml @@ -117,14 +117,14 @@ ${project.version} - 4.5.3 + 4.6.0 1.8 5.8.2 4.6.0 - 4.5.3 + 4.6.0 1.7.36 1.10.12 From 1757c7fbfcb997e1d5d0cb696138bac199e4314c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 14:31:34 -0400 Subject: [PATCH 0655/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.6.0.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index d2de219e2..671518677 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.5.3.1-SNAPSHOT + 4.6.0.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.6.0.0 Github From 83aa566680c4b82632c07f8188b6b799dfd23a71 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 14:31:38 -0400 Subject: [PATCH 0656/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 671518677..437da92a6 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.0 + 4.6.0.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.6.0.0 + HEAD Github From b04feab8b50e50917ff7bed21218429874fc8ce0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 15:31:50 -0400 Subject: [PATCH 0657/1013] [pom] Add javaparser 3.24.0 --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 437da92a6..7443297b6 100644 --- a/pom.xml +++ b/pom.xml @@ -129,6 +129,7 @@ 1.10.12 4.0.1 + 3.24.0 1.11.1 1.11.1 @@ -605,6 +606,11 @@ groovy ${groovyVersion} + + com.github.javaparser + javaparser-core + ${javaparserVersion} + From 63d78dd37d2fb76dc7ab132f0c79adbea42c05e1 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 15:44:21 -0400 Subject: [PATCH 0658/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.6.0.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 7443297b6..3f51d38d2 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.1-SNAPSHOT + 4.6.0.1 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.6.0.1 Github From 04f6a7d36a6a0fe4f55bfaf4c38ebe04568606d7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 15:44:25 -0400 Subject: [PATCH 0659/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 3f51d38d2..2848d54db 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.1 + 4.6.0.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.6.0.1 + HEAD Github From 3fca80be7940596ccf8d17b3ee72015d53430408 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 15:49:39 -0400 Subject: [PATCH 0660/1013] [ci] Add note about groovy conflict potential and remediation --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 59742bde4..3badcc788 100644 --- a/README.md +++ b/README.md @@ -63,3 +63,5 @@ Run gui with a specific version ``` mvn com.github.spotbugs:spotbugs-maven-plugin:4.0.0:gui ``` + +Note on Groovy: If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in dependency management in order to force the loaded version correctly on your usage. From 3aeb88cb2066e5860eb188a778e7d6b3cf7a3940 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:08:53 -0400 Subject: [PATCH 0661/1013] [site] Remove duplicate section per issue #266 --- src/site/apt/usage.apt.vm | 40 --------------------------------------- 1 file changed, 40 deletions(-) diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index a1e34fb3e..e99ee18e4 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -96,46 +96,6 @@ mvn site mvn site +-----+ - -* Filter bugs to report - - To filter the classes and methods which are analyzed or omitted from analysis - you can use filters. - The filters allow specifying by class and method which bug categories to - include/exclude in/from the reports. The - {{{https://spotbugs.readthedocs.io/en/latest/filter.html}filter format specification}} - also contains useful examples. - -+-----+ - - ... - - - - com.github.spotbugs - spotbugs-maven-plugin - ${projectVersion} - - spotbugs-exclude.xml - spotbugs-include.xml - - - - - ... - -+-----+ - - Then, execute the site plugin to generate the report. - - -+-----+ -mvn site -+-----+ - - - * Specifying which bug filters to run To filter the classes and methods which are analyzed or omitted from analysis From 8c76f1602d889fb82e9e0ea1d815394560940b43 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:09:04 -0400 Subject: [PATCH 0662/1013] [site] Remove extra blank lines --- src/site/apt/usage.apt.vm | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index e99ee18e4..521bb049b 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -91,7 +91,6 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ @@ -128,12 +127,10 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ - * Specifying which bug detectors to run The <<>> option specifies a comma-separated list of bug detectors which @@ -163,12 +160,10 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ - * Specifying which bug detectors to skip The <<>> option is like the visitors attribute, except it specifies @@ -196,12 +191,10 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ - * Specifying which classes to analyze The <<>> option restricts analysis to the given comma-separated @@ -229,13 +222,10 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ - - * Using Third party or your own detectors The <<>> option specifies a comma-separated list of optional BugDetector @@ -263,12 +253,10 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ - * Using Detectors from a Repository The <<>> option defines a collection of PluginArtifact to work on. (PluginArtifact contains groupId, artifactId, version, type.) @@ -301,7 +289,6 @@ mvn site Then, execute the site plugin to generate the report. - +-----+ mvn site +-----+ @@ -335,7 +322,6 @@ mvn site Then, execute the spotbugs plugin with the gui option. - +-----+ mvn spotbugs:gui +-----+ From 2c285ffa75436a616bc795c1709e8920136449ef Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:09:42 -0400 Subject: [PATCH 0663/1013] [site] Remove trailing spaces --- src/site/apt/usage.apt.vm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm index 521bb049b..ede98c890 100644 --- a/src/site/apt/usage.apt.vm +++ b/src/site/apt/usage.apt.vm @@ -89,7 +89,7 @@ mvn site +-----+ - Then, execute the site plugin to generate the report. + Then, execute the site plugin to generate the report. +-----+ mvn site From 01bafdb2d4962b35cf6960545a7c295b9444ac0b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:16:29 -0400 Subject: [PATCH 0664/1013] [site] Add FAQ for conflicts with groovy --- src/site/fml/faq.fml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml index fbd15e851..a9d090873 100644 --- a/src/site/fml/faq.fml +++ b/src/site/fml/faq.fml @@ -4,7 +4,7 @@ id="FAQ" title="Frequently Asked Questions"> - Is there an easy way to generate the aggregate report ? + Is there an easy way to generate the aggregate report?

Unfortunately Maven's internal support for report aggregation @@ -34,6 +34,16 @@

+ + + How do I avoid groovy module conflicts when using groovy along with this plugin? + +

+ If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), + an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in + dependency management in order to force the loaded version correctly on your usage. +

+ From 4176c26ee5f05f8657f484eed2eb524589ad84ec Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:33:18 -0400 Subject: [PATCH 0665/1013] [pom] Try moving javaparser to site release has an issue here with javaparser not found. not exactly clear on why as site works. the plugin it fails with is gmavenplus at groovydoc but that works with direct site. prior patch didn't work so moving this to try again. --- pom.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 2848d54db..e99f8921f 100644 --- a/pom.xml +++ b/pom.xml @@ -552,6 +552,11 @@ doxia-sink-api ${doxiaVersion} + + com.github.javaparser + javaparser-core + ${javaparserVersion} + @@ -606,11 +611,6 @@ groovy ${groovyVersion} - - com.github.javaparser - javaparser-core - ${javaparserVersion} - From dfee99afd5ffcbd79a7cf5efc0a5edefde5071cd Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:34:35 -0400 Subject: [PATCH 0666/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.6.0.2 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e99f8921f..e2976daea 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.2-SNAPSHOT + 4.6.0.2 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.6.0.2 Github From 20c3f3332219848bca339a45378b409f4ade4476 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:34:40 -0400 Subject: [PATCH 0667/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e2976daea..0fb41c06a 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.2 + 4.6.0.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.6.0.2 + HEAD Github From bce921d0dae201161a49d32e2f3dca089a82a99e Mon Sep 17 00:00:00 2001 From: Kengo TODA Date: Mon, 2 Jul 2018 09:37:35 +0800 Subject: [PATCH 0668/1013] close #68: fix lifecycle mapping metadata --- src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml b/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml index 876d95d85..347205a3e 100644 --- a/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml +++ b/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml @@ -3,7 +3,7 @@ - compile + check From 8055de275d6166474e4fd2914bd92dc2d14a38f1 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:40:06 -0400 Subject: [PATCH 0669/1013] [mvn] Update maven wrapper --- .mvn/settings.xml | 4 ++-- .mvn/wrapper/maven-wrapper.properties | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.mvn/settings.xml b/.mvn/settings.xml index d192f1b36..286ffa682 100644 --- a/.mvn/settings.xml +++ b/.mvn/settings.xml @@ -1,6 +1,6 @@ - + ossrh diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index 8c79a83ae..db95c131d 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.4/apache-maven-3.8.4-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.5/apache-maven-3.8.5-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar From 2df24b868e6f77f68897bae147b277868665d8ed Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:42:35 -0400 Subject: [PATCH 0670/1013] [actions] Move to official jdk 18 and add 19-ea --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 757725358..830c681e8 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 17, 18-ea] + java: [8, 11, 17, 18, 19-ea] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From ee499b6feb32e9b864578d055e3c33e0155ae3a4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 29 Mar 2022 19:01:59 +0000 Subject: [PATCH 0671/1013] Bump javaparser-core from 3.24.0 to 3.24.2 Bumps [javaparser-core](https://github.com/javaparser/javaparser) from 3.24.0 to 3.24.2. - [Release notes](https://github.com/javaparser/javaparser/releases) - [Changelog](https://github.com/javaparser/javaparser/blob/master/changelog.md) - [Commits](https://github.com/javaparser/javaparser/compare/javaparser-parent-3.24.0...javaparser-parent-3.24.2) --- updated-dependencies: - dependency-name: com.github.javaparser:javaparser-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0fb41c06a..56e0a63aa 100644 --- a/pom.xml +++ b/pom.xml @@ -129,7 +129,7 @@ 1.10.12 4.0.1 - 3.24.0 + 3.24.2 1.11.1 1.11.1 From 474455152cf98d8fd9386c40c46cd36ec3d8046e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Apr 2022 19:01:59 +0000 Subject: [PATCH 0672/1013] Bump asm.version from 9.2 to 9.3 Bumps `asm.version` from 9.2 to 9.3. Updates `asm` from 9.2 to 9.3 Updates `asm-analysis` from 9.2 to 9.3 Updates `asm-commons` from 9.2 to 9.3 Updates `asm-tree` from 9.2 to 9.3 Updates `asm-util` from 9.2 to 9.3 --- updated-dependencies: - dependency-name: org.ow2.asm:asm dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-analysis dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-commons dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-tree dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.ow2.asm:asm-util dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 56e0a63aa..5fda1f0e0 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 5.13.0.202109080827-r - 9.2 + 9.3 1.9.4 1.2 1.15 From e0e272584378f0f0d42f0f0f68bf57e1f5414093 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 5 Apr 2022 00:25:25 +0000 Subject: [PATCH 0673/1013] Bump base-parent from 31 to 35 Bumps [base-parent](https://github.com/hazendaz/base-parent) from 31 to 35. - [Release notes](https://github.com/hazendaz/base-parent/releases) - [Commits](https://github.com/hazendaz/base-parent/commits) --- updated-dependencies: - dependency-name: com.github.hazendaz:base-parent dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5fda1f0e0..94f1b71e9 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 31 + 35 From cec407c877da4062de8dcabded48b720e3ee5f24 Mon Sep 17 00:00:00 2001 From: sullis Date: Thu, 7 Apr 2022 15:31:55 -0700 Subject: [PATCH 0674/1013] setup-java v3 --- .github/workflows/ci.yaml | 4 ++-- .github/workflows/codeql-analysis.yml | 2 +- .github/workflows/coveralls.yaml | 4 ++-- .github/workflows/coverity.yaml | 4 ++-- .github/workflows/it-maven339.yaml | 4 ++-- .github/workflows/it.yaml | 4 ++-- .github/workflows/site.yaml | 4 ++-- .github/workflows/sonar.yaml | 4 ++-- .github/workflows/sonatype.yaml | 4 ++-- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 830c681e8..77f10b8c0 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -14,9 +14,9 @@ jobs: name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: ${{ matrix.java }} distribution: 'zulu' diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index f23c2484d..0f7025196 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -39,7 +39,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v2 + uses: actions/checkout@v3 # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 05af3f4b9..92c5c5ecb 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -23,9 +23,9 @@ jobs: if: github.repository_owner == 'spotbugs-OFF' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml index fb4f575d8..87f593ee5 100644 --- a/.github/workflows/coverity.yaml +++ b/.github/workflows/coverity.yaml @@ -10,9 +10,9 @@ jobs: if: github.repository_owner == 'spotbugs' runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index 2cb56c346..a3c6281a9 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -26,9 +26,9 @@ jobs: name: Integration Tests Maven 3.3.9 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml index 020183f1b..62be1a879 100644 --- a/.github/workflows/it.yaml +++ b/.github/workflows/it.yaml @@ -26,9 +26,9 @@ jobs: name: Integration Tests steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 0e64d256e..d5f977285 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -10,9 +10,9 @@ jobs: if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]') runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index 339ea53dd..fa3b956bd 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -10,12 +10,12 @@ jobs: if: github.repository_owner == 'spotbugs' runs-on: windows-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 with: # Disabling shallow clone is recommended for improving relevancy of reporting fetch-depth: 0 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 13dcffa8f..00cbde358 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -10,9 +10,9 @@ jobs: if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]') runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Set up JDK - uses: actions/setup-java@v2 + uses: actions/setup-java@v3 with: java-version: 11 distribution: 'zulu' From 4b130512f8d9f42bd30101ecfe2a0b000bd6adc8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 24 Mar 2022 16:52:18 -0400 Subject: [PATCH 0675/1013] [todo] Add note about issue with current release build --- TODO.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 TODO.md diff --git a/TODO.md b/TODO.md new file mode 100644 index 000000000..c137938cc --- /dev/null +++ b/TODO.md @@ -0,0 +1,3 @@ +issue +----- +- maven release plugin site is failing with gmavenplus groovydoc regarding missing javaparser class. Tried adding that both at gmavenplus and at site plugin, neither worked. It is at site plugin currently. Running site on its own runs this same step without issue. From 59a88341ff94fe24d38bc63f6754680e93b4eb75 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 9 Apr 2022 20:39:43 -0400 Subject: [PATCH 0676/1013] [actions] Drop jdk 8 from build --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 77f10b8c0..2aa873087 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [8, 11, 17, 18, 19-ea] + java: [11, 17, 18, 19-ea] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From aa0044ff74e2ec1325dda958e2a882db6118ca97 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 9 Apr 2022 20:39:54 -0400 Subject: [PATCH 0677/1013] [actions] Use jdk 17 for site generation --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index d5f977285..68ab3acfc 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -14,7 +14,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - uses: webfactory/ssh-agent@master with: From b0f69dfe7eb3af6a17624383b1e96e555d6bd36a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 9 Apr 2022 20:40:05 -0400 Subject: [PATCH 0678/1013] [actions] Use jdk 17 for sonar generation --- .github/workflows/sonar.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index fa3b956bd..e454023f1 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -17,7 +17,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Analyze with SonarCloud run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" From 87c424ecffddaea63e2b6d53b87a4cf46cde67e8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 9 Apr 2022 20:40:14 -0400 Subject: [PATCH 0679/1013] [actions] Use jdk 17 for sonatype generation --- .github/workflows/sonatype.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 00cbde358..046b408a7 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -14,7 +14,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Deploy to Sonatype run: ./mvnw deploy -DskipTests -B --settings ./.mvn/settings.xml From 730e60fc60164983c2775061d7e79556fa10adc6 Mon Sep 17 00:00:00 2001 From: sullis Date: Tue, 12 Apr 2022 20:24:44 -0700 Subject: [PATCH 0680/1013] mvn no transfer progress --- .github/workflows/ci.yaml | 2 +- .github/workflows/site.yaml | 2 +- .github/workflows/sonatype.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 2aa873087..147064789 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -21,4 +21,4 @@ jobs: java-version: ${{ matrix.java }} distribution: 'zulu' - name: Test with Maven - run: ./mvnw test -B + run: ./mvnw test -B --no-transfer-progress diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 68ab3acfc..66b08e969 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -20,7 +20,7 @@ jobs: with: ssh-private-key: ${{ secrets.DEPLOY_KEY }} - name: Build site - run: ./mvnw site site:stage -DskipTests -B + run: ./mvnw site site:stage -DskipTests -B --no-transfer-progress env: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 046b408a7..0080c698c 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -17,7 +17,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Deploy to Sonatype - run: ./mvnw deploy -DskipTests -B --settings ./.mvn/settings.xml + run: ./mvnw deploy -DskipTests -B --no-transfer-progress --settings ./.mvn/settings.xml env: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }} From ee540228077b6d04cb7b1ad75c2107303bddf4f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Siersze=C5=84?= Date: Sat, 16 Apr 2022 12:17:19 +0200 Subject: [PATCH 0681/1013] chore(verify): Since tag bump --- src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy index 53be7a588..f3bbf9e6d 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy @@ -28,7 +28,7 @@ import org.apache.maven.plugins.annotations.ResolutionScope * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. * - * @since 4.5 + * @since 4.7 */ @Mojo( name = "verify", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) class VerifyMojo extends BaseViolationCheckMojo { From f29d7b3e249cd491c58f8c72f2606c6f3f68055e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20Siersze=C5=84?= Date: Sat, 16 Apr 2022 12:19:11 +0200 Subject: [PATCH 0682/1013] feat(verify): Updated Javadoc --- src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy index f3bbf9e6d..5cde89d15 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy @@ -25,7 +25,9 @@ import org.apache.maven.plugins.annotations.ResolutionScope /** * Fail the build if any SpotBugs violations can be found in a preexisting {@code spotBugs.xml} file. - * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. + * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. + * This way, it is possible to split the analysis and verification into lifecycle phases of one's choosing. + * One use case for that is running multiple code analyzers at once and only failing the build at a later stage, so that all of them have a chance to run. * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. * * @since 4.7 From 522f13e7dccb7234cf250ed1f7b73af9869d7879 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Apr 2022 19:02:05 +0000 Subject: [PATCH 0683/1013] Bump maven-site-plugin from 3.11.0 to 3.12.0 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.11.0 to 3.12.0. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.11.0...maven-site-plugin-3.12.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 94f1b71e9..d8cec291a 100644 --- a/pom.xml +++ b/pom.xml @@ -155,7 +155,7 @@ 3.3.2 3.6.4 1.12.2 - 3.11.0 + 3.12.0 3.6 2.10.0 From 210af16ae7581e93eb6bb191fcf89145888b2be8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Apr 2022 19:02:15 +0000 Subject: [PATCH 0684/1013] Bump maven-javadoc-plugin from 3.3.2 to 3.4.0 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.2 to 3.4.0. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.2...maven-javadoc-plugin-3.4.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 94f1b71e9..13eeef823 100644 --- a/pom.xml +++ b/pom.xml @@ -152,7 +152,7 @@ 1.13.1 3.2.2 3.2.2 - 3.3.2 + 3.4.0 3.6.4 1.12.2 3.11.0 From c4123f7d9f3d768aebba1754e70f00d5d6b65f44 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 22 Apr 2022 19:04:52 +0000 Subject: [PATCH 0685/1013] Bump groovyVersion from 4.0.1 to 4.0.2 Bumps `groovyVersion` from 4.0.1 to 4.0.2. Updates `groovy` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-json` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 4.0.1 to 4.0.2 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.apache.groovy:groovy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-ant dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-dateutil dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-docgenerator dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-json dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-templates dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-xml dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2ba61d368..54a46a14e 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.7.36 1.10.12 - 4.0.1 + 4.0.2 3.24.2 1.11.1 From 1f92d53958704305a27ac781e6c2a885544d9bea Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 22 Apr 2022 19:04:58 +0000 Subject: [PATCH 0686/1013] Bump maven-antrun-plugin from 3.0.0 to 3.1.0 Bumps [maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin) from 3.0.0 to 3.1.0. - [Release notes](https://github.com/apache/maven-antrun-plugin/releases) - [Commits](https://github.com/apache/maven-antrun-plugin/compare/maven-antrun-plugin-3.0.0...maven-antrun-plugin-3.1.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-antrun-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2ba61d368..f18cd9152 100644 --- a/pom.xml +++ b/pom.xml @@ -146,7 +146,7 @@ 1.2.0 3.4.1 - 3.0.0 + 3.1.0 1.8 0.22-1 1.13.1 From 4909fb25b8f430939881b1ad974f088c0e0beb49 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Apr 2022 09:13:58 -0400 Subject: [PATCH 0687/1013] [ci] Add more information on groovy considerations --- README.md | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 1252d5152..1fcc674b7 100644 --- a/README.md +++ b/README.md @@ -70,4 +70,13 @@ Run integration tests ``` mvn clean install -P run-its -DtestSrc=remote ``` -Note on Groovy: If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in dependency management in order to force the loaded version correctly on your usage. + +## Groovy ## + +This plugin is written entirey in groovy. It does have limitations when it comes to groovy in relation to java releases. Every attempt is made to ensure fast releases to pick up groovy changes related to java. + +Known issues + +The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using JAVA_OPTS to -Djava.security.manager=allow. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details. + +If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in dependency management in order to force the loaded version correctly on your usage. From 8190c4061d89e39af3f1ff56e60107a789b52466 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Apr 2022 09:19:57 -0400 Subject: [PATCH 0688/1013] [ci] Adjust data --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 1fcc674b7..e0423a5fe 100644 --- a/README.md +++ b/README.md @@ -77,6 +77,6 @@ This plugin is written entirey in groovy. It does have limitations when it come Known issues -The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using JAVA_OPTS to -Djava.security.manager=allow. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details. +The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using ```JAVA_OPTS``` to ```-Djava.security.manager=allow```. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details. If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in dependency management in order to force the loaded version correctly on your usage. From 69a2692e50747e65ec064afe2b88c96fd81dbaff Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Apr 2022 09:21:15 -0400 Subject: [PATCH 0689/1013] [ci] More adjustments around groovy --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e0423a5fe..5e366857c 100644 --- a/README.md +++ b/README.md @@ -79,4 +79,4 @@ Known issues The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using ```JAVA_OPTS``` to ```-Djava.security.manager=allow```. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details. -If using groovy with same group id (org.codehaus.groovy 3.x or before or org.apache.groovy 4.x or above), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in dependency management in order to force the loaded version correctly on your usage. +If using groovy with same group id (```org.codehaus.groovy 3.x``` or before or ```org.apache.groovy 4.x or above```), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in ```dependency management``` in order to force the loaded version correctly on your usage. From 15d43b45c369c2a3eb8172dc1136e3046c90866f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Apr 2022 10:12:23 -0400 Subject: [PATCH 0690/1013] [m2e] Add spotbugs and verify to execution filter note: Due to how eclipse works, this will show up but not do anything , use https://github.com/m2e-code-quality/m2e-code-quality/ to get full lifecycle processing --- src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml b/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml index 347205a3e..fc175f3b2 100644 --- a/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml +++ b/src/main/resources/META-INF/m2e/lifecycle-mapping-metadata.xml @@ -4,6 +4,8 @@ check + spotbugs + verify From 1386ea4421782d75a544dc5391dfbc6a85b67bcf Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Apr 2022 10:15:29 -0400 Subject: [PATCH 0691/1013] [ci] Add note about m2e requirements --- README.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/README.md b/README.md index 5e366857c..2ed52ee64 100644 --- a/README.md +++ b/README.md @@ -80,3 +80,8 @@ Known issues The security manager is turned off by default in jdk 18/19 and scheduled from removal in a future java release, therefore to use this plugin with jdk 18/19, the security manager may need turned back on using ```JAVA_OPTS``` to ```-Djava.security.manager=allow```. See [groovy](https://groovy-lang.org/releasenotes/groovy-4.0.html) for more details. If using groovy with same group id (```org.codehaus.groovy 3.x``` or before or ```org.apache.groovy 4.x or above```), an error may occur if not on same version. To alleviate that, make sure groovy artifacts are defined in ```dependency management``` in order to force the loaded version correctly on your usage. + + +## Eclipse m2e Integration ## + +The plugin cycles controlled by Eclipse require compilation phase for m2e without further help. This plugin runs verify and during site generation. Therefore Eclipse m2e will show up but not do anything with this plugin alone. In order to have proper execution within Ecipse m2e, use [m2e-code-quality](https://github.com/m2e-code-quality/m2e-code-quality) plugin for spotbugs. From fdc08760cb86c5697f7a53f2946bd1ad8a0ace4b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 28 Apr 2022 19:01:49 +0000 Subject: [PATCH 0692/1013] Bump maven-project-info-reports-plugin from 3.2.2 to 3.3.0 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.2.2 to 3.3.0. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.2.2...maven-project-info-reports-plugin-3.3.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e0ce6baa2..eae0fc205 100644 --- a/pom.xml +++ b/pom.xml @@ -150,7 +150,7 @@ 1.8 0.22-1 1.13.1 - 3.2.2 + 3.3.0 3.2.2 3.4.0 3.6.4 From 49335c4042c3959b8d6a15b053b36eecaf6caa63 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 5 May 2022 19:01:41 +0000 Subject: [PATCH 0693/1013] Bump spotbugs from 4.6.0 to 4.7.0 Bumps [spotbugs](https://github.com/spotbugs/spotbugs) from 4.6.0 to 4.7.0. - [Release notes](https://github.com/spotbugs/spotbugs/releases) - [Changelog](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md) - [Commits](https://github.com/spotbugs/spotbugs/compare/4.6.0...4.7.0) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index eae0fc205..55e8614fd 100644 --- a/pom.xml +++ b/pom.xml @@ -123,7 +123,7 @@ 1.8 5.8.2 - 4.6.0 + 4.7.0 4.6.0 1.7.36 From 67c08443e8d864aa3981551d0c7969d4d6ea78e0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 7 May 2022 16:49:55 -0400 Subject: [PATCH 0694/1013] [pom] Adjust fully to spotbugs 4.7.0 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 55e8614fd..971485740 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.6.0.3-SNAPSHOT + 4.7.0.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -117,14 +117,14 @@ ${project.version} - 4.6.0 + 4.7.0 1.8 5.8.2 4.7.0 - 4.6.0 + 4.7.0 1.7.36 1.10.12 From 0904be4903ed53dc5f1d039878de63344540786b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 7 May 2022 16:50:08 -0400 Subject: [PATCH 0695/1013] [pom] Bump maven surefire to 3.0.0-M6 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 971485740..b07ee8ecc 100644 --- a/pom.xml +++ b/pom.xml @@ -175,7 +175,7 @@ 3.9.0 1.10.1 3.0.0 - 3.0.0-M5 + 3.0.0-M6 8.0.0 4.0.4 7.4.7 From e9bf09ce01072c610b43325f068527bc0f717cad Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 18 May 2022 19:02:14 +0000 Subject: [PATCH 0696/1013] Bump plexus-utils from 3.4.1 to 3.4.2 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.4.1 to 3.4.2. - [Release notes](https://github.com/codehaus-plexus/plexus-utils/releases) - [Commits](https://github.com/codehaus-plexus/plexus-utils/compare/plexus-utils-3.4.1...plexus-utils-3.4.2) --- updated-dependencies: - dependency-name: org.codehaus.plexus:plexus-utils dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b07ee8ecc..d40d5fc1c 100644 --- a/pom.xml +++ b/pom.xml @@ -144,7 +144,7 @@ 2.1.1 1.2.0 - 3.4.1 + 3.4.2 3.1.0 1.8 From c5bff4703bc7146948b52bb2c209dd8442293530 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 21:29:29 -0400 Subject: [PATCH 0697/1013] [pom] Update comment in pom --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b07ee8ecc..98f90d4cc 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ 3.6.4 1.12.2 3.12.0 - 3.6 + 3.6 2.10.0 false From c21d15a63ab5ada3798c17cff808a6453320d36b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 21:37:44 -0400 Subject: [PATCH 0698/1013] [actions] Use jdk 11 with site for now --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 66b08e969..1953cc2fc 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -14,7 +14,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 17 + java-version: 11 distribution: 'zulu' - uses: webfactory/ssh-agent@master with: From 623220ea4a62b58e965c7b6159929e1bd9b74233 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 21:37:57 -0400 Subject: [PATCH 0699/1013] [pom] Bump IT compiler to 3.10.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 98f90d4cc..6b6432878 100644 --- a/pom.xml +++ b/pom.xml @@ -172,9 +172,9 @@ true - 3.9.0 1.10.1 3.0.0 + 3.10.1 3.0.0-M6 8.0.0 4.0.4 From 0036acfefcc3729b83874631db84949a2025de7d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 21:38:12 -0400 Subject: [PATCH 0700/1013] [pom] Bump findsecbugs IT to 1.12.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6b6432878..f1e2da53b 100644 --- a/pom.xml +++ b/pom.xml @@ -172,9 +172,9 @@ true - 1.10.1 3.0.0 3.10.1 + 1.12.0 3.0.0-M6 8.0.0 4.0.4 From 02a5e756ce695aec8849a9ecc2c5894a47f8a2eb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 21:38:29 -0400 Subject: [PATCH 0701/1013] [pom] Bump jxr plugin to 3.2.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f1e2da53b..207b95607 100644 --- a/pom.xml +++ b/pom.xml @@ -172,9 +172,9 @@ true - 3.0.0 3.10.1 1.12.0 + 3.2.0 3.0.0-M6 8.0.0 4.0.4 From a45eac35b7f2cdb017aec29f107f3637fd023352 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 22:25:15 -0400 Subject: [PATCH 0702/1013] [pom] Skip pdf plugin as it doesn't work well --- pom.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pom.xml b/pom.xml index 3d928a279..e122a817d 100644 --- a/pom.xml +++ b/pom.xml @@ -573,6 +573,15 @@ true + + + + org.apache.maven.plugins + maven-pdf-plugin + + false + + From f08f5990d4173d7b0e64939b0f3d7c9da5da39ca Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 22:40:32 -0400 Subject: [PATCH 0703/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.0.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index e122a817d..35b695f13 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.0.0-SNAPSHOT + 4.7.0.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.0.0 Github From 61b77bbc232e2ba10945311303b5f9572809cafe Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 19 May 2022 22:40:38 -0400 Subject: [PATCH 0704/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 35b695f13..b6454f665 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.0.0 + 4.7.0.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.0.0 + HEAD Github From e23aecf3e4ada0dfdb15e6a6ec568c084f4710b3 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 20 May 2022 19:02:01 +0000 Subject: [PATCH 0705/1013] Bump versions-maven-plugin from 2.10.0 to 2.11.0 Bumps [versions-maven-plugin](https://github.com/mojohaus/versions-maven-plugin) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/mojohaus/versions-maven-plugin/releases) - [Changelog](https://github.com/mojohaus/versions-maven-plugin/blob/master/ReleaseNotes.md) - [Commits](https://github.com/mojohaus/versions-maven-plugin/compare/versions-maven-plugin-2.10.0...versions-maven-plugin-2.11.0) --- updated-dependencies: - dependency-name: org.codehaus.mojo:versions-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b6454f665..f35b81388 100644 --- a/pom.xml +++ b/pom.xml @@ -157,7 +157,7 @@ 1.12.2 3.12.0 3.6 - 2.10.0 + 2.11.0 false ${project.build.directory}/it-src-spotbugs From 128534ba6ed35fc679ed5e7c44dbd042de1348cc Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 30 May 2022 19:02:18 +0000 Subject: [PATCH 0706/1013] Bump scmPluginVersion from 1.12.2 to 1.13.0 Bumps `scmPluginVersion` from 1.12.2 to 1.13.0. Updates `maven-scm-provider-jgit` from 1.12.2 to 1.13.0 Updates `maven-scm-plugin` from 1.12.2 to 1.13.0 - [Release notes](https://github.com/apache/maven-scm/releases) - [Commits](https://github.com/apache/maven-scm/compare/maven-scm-1.12.2...maven-scm-1.13.0) --- updated-dependencies: - dependency-name: org.apache.maven.scm:maven-scm-provider-jgit dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: org.apache.maven.plugins:maven-scm-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f35b81388..f0230ad16 100644 --- a/pom.xml +++ b/pom.xml @@ -154,7 +154,7 @@ 3.2.2 3.4.0 3.6.4 - 1.12.2 + 1.13.0 3.12.0 3.6 2.11.0 From 06c49c89adc79ca830ebb6fa2f79eb58d6937fc2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 6 Jun 2022 19:07:00 +0000 Subject: [PATCH 0707/1013] Bump groovyVersion from 4.0.2 to 4.0.3 Bumps `groovyVersion` from 4.0.2 to 4.0.3. Updates `groovy` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-ant` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-dateutil` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-docgenerator` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-json` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-templates` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-xml` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) Updates `groovy-all` from 4.0.2 to 4.0.3 - [Release notes](https://github.com/apache/groovy/releases) - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.apache.groovy:groovy dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-ant dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-dateutil dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-docgenerator dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-json dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-templates dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-xml dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.groovy:groovy-all dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f0230ad16..fdbb65130 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.7.36 1.10.12 - 4.0.2 + 4.0.3 3.24.2 1.11.1 From a280674c033652d2e227f7d332d1ff064f285ac1 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 13 Jun 2022 19:02:10 +0000 Subject: [PATCH 0708/1013] Bump mavenCoreVersion from 3.8.5 to 3.8.6 Bumps `mavenCoreVersion` from 3.8.5 to 3.8.6. Updates `maven-core` from 3.8.5 to 3.8.6 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6) Updates `maven-model` from 3.8.5 to 3.8.6 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6) --- updated-dependencies: - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-model dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fdbb65130..789c0a99b 100644 --- a/pom.xml +++ b/pom.xml @@ -134,7 +134,7 @@ 1.11.1 1.11.1 - 3.8.5 + 3.8.6 3.3.4 0.13.1 3.2.0 From 0e6835b638e840b22e073628b719ed1c687a7493 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 13 Jun 2022 19:02:26 +0000 Subject: [PATCH 0709/1013] Bump mavenVersion from 3.8.5 to 3.8.6 Bumps `mavenVersion` from 3.8.5 to 3.8.6. Updates `maven-plugin-api` from 3.8.5 to 3.8.6 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6) Updates `maven-artifact` from 3.8.5 to 3.8.6 - [Release notes](https://github.com/apache/maven/releases) - [Commits](https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fdbb65130..8557c4007 100644 --- a/pom.xml +++ b/pom.xml @@ -140,7 +140,7 @@ 3.2.0 3.1.0 3.1.0 - 3.8.5 + 3.8.6 2.1.1 1.2.0 From d93973e31b53acd10a014fb00c6460891bbf7c31 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 10:25:00 -0400 Subject: [PATCH 0710/1013] [pom] Bump spotbugs to 4.7.1 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index e089393c5..e3d08b762 100644 --- a/pom.xml +++ b/pom.xml @@ -117,14 +117,14 @@ ${project.version} - 4.7.0 + 4.7.1 1.8 5.8.2 - 4.7.0 - 4.7.0 + 4.7.1 + 4.7.1 1.7.36 1.10.12 From de4857667c547143959192994e3bf368f7dee8ce Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 10:45:52 -0400 Subject: [PATCH 0711/1013] [pom] Add groovy-bom - note that we still need to call versions on plugins that use groovy otherwise as maven doesn't seem to pass that information along and it does not have same dependency management as a solution either. --- pom.xml | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/pom.xml b/pom.xml index e3d08b762..6bd1e57ab 100644 --- a/pom.xml +++ b/pom.xml @@ -194,6 +194,18 @@ 3.12.0 + + + + org.apache.groovy + groovy-bom + ${groovyVersion} + pom + import + + + + @@ -231,13 +243,11 @@ org.apache.groovy groovy - ${groovyVersion} org.apache.groovy groovy-ant - ${groovyVersion} org.apache.ant @@ -253,33 +263,28 @@ org.apache.groovy groovy-dateutil - ${groovyVersion} org.apache.groovy groovy-docgenerator - ${groovyVersion} runtime org.apache.groovy groovy-json - ${groovyVersion} org.apache.groovy groovy-templates - ${groovyVersion} runtime org.apache.groovy groovy-xml - ${groovyVersion} From 242285734ea481f1ce72c46c56129e8532ab4098 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 17:49:52 -0400 Subject: [PATCH 0712/1013] [pom] Stream output to console on failures helpful when running in the cloud or just unsure where the logs are after not having to look in a long time :+1: --- pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pom.xml b/pom.xml index 6bd1e57ab..b5c3212c7 100644 --- a/pom.xml +++ b/pom.xml @@ -798,6 +798,7 @@ install ${project.basedir}/src/it/settings.xml + true @@ -815,6 +816,7 @@ verify ${project.build.directory}/local-repo ${project.basedir}/src/it/settings.xml + true From b090061510523cb8b7499fd55caa17189c4b25cc Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 18:35:35 -0400 Subject: [PATCH 0713/1013] [pom] Fix groovy for invoker plugin (still on 3 and breaking changes..) was not actually overriding groovy to latest. this was missed when moving from groovy 3 to 4. We still need 3 with invoker plugin. The current release of invoker with a breaking change on groovy exposed this and didn't have much in the logs to help. Basically they dropped all but groovy, json, and xml. We need nio as well. --- pom.xml | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/pom.xml b/pom.xml index b5c3212c7..e2b5a191b 100644 --- a/pom.xml +++ b/pom.xml @@ -129,6 +129,7 @@ 1.10.12 4.0.3 + 3.0.11 3.24.2 1.11.1 @@ -822,17 +823,24 @@ - org.apache.groovy - groovy-all - ${groovyVersion} - pom - - - - org.apache.groovy - groovy-testng - - + org.codehaus.groovy + groovy + ${groovy3.version} + + + org.codehaus.groovy + groovy-json + ${groovy3.version} + + + org.codehaus.groovy + groovy-nio + ${groovy3.version} + + + org.codehaus.groovy + groovy-xml + ${groovy3.version} From 0843f6e613778bd2bc9ae63979790debf1d9c052 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 18:51:53 -0400 Subject: [PATCH 0714/1013] [pom] Correct groovy version property --- pom.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pom.xml b/pom.xml index e2b5a191b..d8c9f700d 100644 --- a/pom.xml +++ b/pom.xml @@ -825,22 +825,22 @@ org.codehaus.groovy groovy - ${groovy3.version} + ${groovy3Version} org.codehaus.groovy groovy-json - ${groovy3.version} + ${groovy3Version} org.codehaus.groovy groovy-nio - ${groovy3.version} + ${groovy3Version} org.codehaus.groovy groovy-xml - ${groovy3.version} + ${groovy3Version} From e929ce758d4a2fab998859aa5bd78ecef41ec2a0 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 18:53:29 -0400 Subject: [PATCH 0715/1013] [pom] Bump maven common artifacts filters to 3.3.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d8c9f700d..23e3bc548 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 3.8.6 3.3.4 0.13.1 - 3.2.0 + 3.3.0 3.1.0 3.1.0 3.8.6 From 046cf1b81d9502e4000d5a3e530d3a243912ae3e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 18:53:39 -0400 Subject: [PATCH 0716/1013] [pom] Bump invoker plugin to 3.3.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 23e3bc548..c2f41c399 100644 --- a/pom.xml +++ b/pom.xml @@ -152,7 +152,7 @@ 0.22-1 1.13.1 3.3.0 - 3.2.2 + 3.3.0 3.4.0 3.6.4 1.13.0 From c3e458dcac43954e3e2bc6c7db9eec5d8f5522af Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 23:37:52 -0400 Subject: [PATCH 0717/1013] [pom] Add comment about invoker still using groovy 3 --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index c2f41c399..bc3743fcc 100644 --- a/pom.xml +++ b/pom.xml @@ -822,6 +822,7 @@ + org.codehaus.groovy groovy From 63fe4ab033c0ba2c63a730ee071577d90724d112 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 29 Jun 2022 23:49:57 -0400 Subject: [PATCH 0718/1013] [pom] Drop maven common artifact filters back to 3.2.0 more to review on this as it is failing. --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index bc3743fcc..81549348f 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 3.8.6 3.3.4 0.13.1 - 3.3.0 + 3.2.0 3.1.0 3.1.0 3.8.6 From 959f23807ae6cbab6bf573f83595ad99119b9362 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 17:21:17 -0400 Subject: [PATCH 0719/1013] [pom] Bump version of project to 4.7.1.0 snapshot --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 81549348f..f15109542 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.0.1-SNAPSHOT + 4.7.1.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin From 09fd232697c441c996f4274dca7d9edc8ba1b947 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 00:06:08 -0400 Subject: [PATCH 0720/1013] [pom] Add versions into build tools pom --- src/it-tools/build-tools/pom.xml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml index 61744c134..fa654071e 100644 --- a/src/it-tools/build-tools/pom.xml +++ b/src/it-tools/build-tools/pom.xml @@ -30,6 +30,7 @@ org.apache.maven.plugins maven-compiler-plugin + @compilerPluginVersion@ false 1.8 @@ -48,6 +49,7 @@ org.apache.maven.plugins maven-surefire-plugin + @mavenSurefireVersion@ true From b42c3dde1bc0ea7b9f1fa37f67f696d07499f174 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 17:32:21 -0400 Subject: [PATCH 0721/1013] [pom] Bump surefire to 3.0.0-M7 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f15109542..0b995847c 100644 --- a/pom.xml +++ b/pom.xml @@ -176,7 +176,7 @@ 3.10.1 1.12.0 3.2.0 - 3.0.0-M6 + 3.0.0-M7 8.0.0 4.0.4 7.4.7 From 6366723267ff00ca12628e45b44ea8b5eef835e9 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 30 Jun 2022 00:30:56 -0400 Subject: [PATCH 0722/1013] [pom] Bump maven common artifacts filters back to 3.3.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0b995847c..dbf3d9845 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 3.8.6 3.3.4 0.13.1 - 3.2.0 + 3.3.0 3.1.0 3.1.0 3.8.6 From 3ed4ae38451135446deda4e06b110741b4d4cda8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 17:51:14 -0400 Subject: [PATCH 0723/1013] [pom] Add asm bom to enforce asm version to 9.3 --- pom.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pom.xml b/pom.xml index dbf3d9845..ef2120357 100644 --- a/pom.xml +++ b/pom.xml @@ -197,6 +197,13 @@ + + org.ow2.asm + asm-bom + ${asm.version} + pom + import + org.apache.groovy groovy-bom From e6f353f4449605fa6babbf569ac4fe980e93b587 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 19:22:50 -0400 Subject: [PATCH 0724/1013] [pom] Add better control of plugins to be recent in 'it' tests will still pick up old where its not calling out the parent setup which is ok. --- src/it-tools/build-tools/pom.xml | 56 ++++++++++++++++++++++++++++++++ src/it-tools/prime/pom.xml | 53 ++++++++++++++++++++++++++++++ src/it/common.xml | 53 ++++++++++++++++++++++++++++++ 3 files changed, 162 insertions(+) diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml index fa654071e..5a2d63255 100644 --- a/src/it-tools/build-tools/pom.xml +++ b/src/it-tools/build-tools/pom.xml @@ -26,6 +26,62 @@ testing + + + + + org.apache.maven.plugins + maven-antrun-plugin + @antrun.plugin@ + + + org.apache.maven.plugins + maven-assembly-plugin + @assembly.plugin@ + + + org.apache.maven.plugins + maven-clean-plugin + @clean.plugin@ + + + org.apache.maven.plugins + maven-dependency-plugin + @dependency.plugin@ + + + org.apache.maven.plugins + maven-deploy-plugin + @deploy.plugin@ + + + org.apache.maven.plugins + maven-install-plugin + @install.plugin@ + + + org.apache.maven.plugins + maven-jar-plugin + @jar.plugin@ + + + org.apache.maven.plugins + maven-release-plugin + @release.plugin@ + + + org.apache.maven.plugins + maven-resources-plugin + @resources.plugin@ + + + org.apache.maven.plugins + maven-jxr-plugin + @jxr.plugin@ + + + + org.apache.maven.plugins diff --git a/src/it-tools/prime/pom.xml b/src/it-tools/prime/pom.xml index 0e0f4ce4c..0b6d1ab21 100644 --- a/src/it-tools/prime/pom.xml +++ b/src/it-tools/prime/pom.xml @@ -26,6 +26,59 @@ testing + + + org.apache.maven.plugins + maven-antrun-plugin + @antrun.plugin@ + + + org.apache.maven.plugins + maven-assembly-plugin + @assembly.plugin@ + + + org.apache.maven.plugins + maven-clean-plugin + @clean.plugin@ + + + org.apache.maven.plugins + maven-dependency-plugin + @dependency.plugin@ + + + org.apache.maven.plugins + maven-deploy-plugin + @deploy.plugin@ + + + org.apache.maven.plugins + maven-install-plugin + @install.plugin@ + + + org.apache.maven.plugins + maven-jar-plugin + @jar.plugin@ + + + org.apache.maven.plugins + maven-release-plugin + @release.plugin@ + + + org.apache.maven.plugins + maven-resources-plugin + @resources.plugin@ + + + org.apache.maven.plugins + maven-jxr-plugin + @jxr.plugin@ + + + com.github.spotbugs spotbugs diff --git a/src/it/common.xml b/src/it/common.xml index 15a264fa2..b4b121ac7 100644 --- a/src/it/common.xml +++ b/src/it/common.xml @@ -57,6 +57,59 @@ @project.basedir@/src/it-src/test/java + + + org.apache.maven.plugins + maven-antrun-plugin + @antrun.plugin@ + + + org.apache.maven.plugins + maven-assembly-plugin + @assembly.plugin@ + + + org.apache.maven.plugins + maven-clean-plugin + @clean.plugin@ + + + org.apache.maven.plugins + maven-dependency-plugin + @dependency.plugin@ + + + org.apache.maven.plugins + maven-deploy-plugin + @deploy.plugin@ + + + org.apache.maven.plugins + maven-install-plugin + @install.plugin@ + + + org.apache.maven.plugins + maven-jar-plugin + @jar.plugin@ + + + org.apache.maven.plugins + maven-release-plugin + @release.plugin@ + + + org.apache.maven.plugins + maven-resources-plugin + @resources.plugin@ + + + org.apache.maven.plugins + maven-jxr-plugin + @jxr.plugin@ + + + com.github.spotbugs spotbugs-maven-plugin From c73479aedcf43c925c7f072ab7c2d58f0dd3fd3f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 19:24:13 -0400 Subject: [PATCH 0725/1013] [pom] As asm now bom, remove duplicate version declarations --- pom.xml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pom.xml b/pom.xml index ef2120357..ebd535269 100644 --- a/pom.xml +++ b/pom.xml @@ -520,27 +520,22 @@ org.ow2.asm asm - ${asm.version} org.ow2.asm asm-analysis - ${asm.version} org.ow2.asm asm-commons - ${asm.version} org.ow2.asm asm-tree - ${asm.version} org.ow2.asm asm-util - ${asm.version} From 21453a33a7bdf620446dd0a2044bee81fb6e9318 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 19:29:33 -0400 Subject: [PATCH 0726/1013] [pom] Formatting --- src/it/systemPropertyVariables/pom.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/it/systemPropertyVariables/pom.xml b/src/it/systemPropertyVariables/pom.xml index e2d901322..712126d8f 100644 --- a/src/it/systemPropertyVariables/pom.xml +++ b/src/it/systemPropertyVariables/pom.xml @@ -34,8 +34,7 @@ spotbugs-maven-plugin - true - + true true true From ffbbf4d2e2b94e92c0b197c0e91ad792f558d452 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 19:37:06 -0400 Subject: [PATCH 0727/1013] [pom] More formatting --- src/it/skipEmpty/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/it/skipEmpty/pom.xml b/src/it/skipEmpty/pom.xml index 2e1ad72ac..0d61e5ff5 100644 --- a/src/it/skipEmpty/pom.xml +++ b/src/it/skipEmpty/pom.xml @@ -16,7 +16,7 @@ --> -4.0.0 + 4.0.0 + + org.ow2.asm + asm + + + org.ow2.asm + asm-analysis + + + org.ow2.asm + asm-commons + + + org.ow2.asm + asm-tree + + + org.ow2.asm + asm-util + + org.apache.ant @@ -515,28 +537,6 @@ plexus-utils ${plexusUtilsVersion} - - - - org.ow2.asm - asm - - - org.ow2.asm - asm-analysis - - - org.ow2.asm - asm-commons - - - org.ow2.asm - asm-tree - - - org.ow2.asm - asm-util - From cd7fbd38ba321aa2dd35cd0a3ba663526bb32c93 Mon Sep 17 00:00:00 2001 From: "Henning P. Schmiedehausen" Date: Thu, 26 May 2022 11:13:42 -0700 Subject: [PATCH 0729/1013] Support multiple bug inclusion files. Spotbugs always supported multiple files as a comma-separated list in the configuration option. This change also adds support for multiple files as a list: ... ... This allows using pom inheritance to control multiple files. Includes integration test to verify function. --- src/it/include-multi-list/invoker.properties | 4 ++ src/it/include-multi-list/pom.xml | 61 +++++++++++++++++ src/it/include-multi-list/verify.groovy | 66 +++++++++++++++++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 36 ++++++++++ 4 files changed, 167 insertions(+) create mode 100644 src/it/include-multi-list/invoker.properties create mode 100644 src/it/include-multi-list/pom.xml create mode 100644 src/it/include-multi-list/verify.groovy diff --git a/src/it/include-multi-list/invoker.properties b/src/it/include-multi-list/invoker.properties new file mode 100644 index 000000000..7fbf7d99f --- /dev/null +++ b/src/it/include-multi-list/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile site + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/include-multi-list/pom.xml b/src/it/include-multi-list/pom.xml new file mode 100644 index 000000000..62e24ef20 --- /dev/null +++ b/src/it/include-multi-list/pom.xml @@ -0,0 +1,61 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + includeFile-multi-list + includeFile-multi-list + jar + + + + spotbugs-maven-plugin.it + build-tools + testing + + + + + true + + + org.apache.maven.plugins + maven-jxr-plugin + @jxrPluginVersion@ + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + + whizbang/lib-filter.xml + filters/lib-filter2.xml + + + + + + diff --git a/src/it/include-multi-list/verify.groovy b/src/it/include-multi-list/verify.groovy new file mode 100644 index 000000000..80d3f179d --- /dev/null +++ b/src/it/include-multi-list/verify.groovy @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + + +println '***************************' +println "Checking HTML file" +println '***************************' + +def xhtmlParser = new XmlSlurper(); +xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) +xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) +def path = xhtmlParser.parse( spotbugsHtml ) +//*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.section[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" + + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +path = new XmlSlurper().parse(spotbugXdoc) + +allNodes = path.depthFirst().collect{ it } +def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + + +assert xdocErrors == spotbugsXmlErrors + +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 7f12ac041..5ff6438f7 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -282,6 +282,32 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(property = "spotbugs.includeFilterFile") String includeFilterFile + /** + *

+ * File name for include filter files. Only bugs in matching the filters are reported. + *

+ * + *

+ * Potential values are a filesystem path, a URL, or a classpath resource. + *

+ * + *

+ * This is an alternative to <includeFilterFile> which allows multiple + * files to be specified as separate elements in a pom. + *

+ * + *

+ * This parameter is resolved as resource, URL, then file. If successfully + * resolved, the contents of the configuration is copied into the + * ${project.build.directory} + * directory before being passed to Spotbugs as a filter file. + *

+ * + * @since 4.7.0.1-SNAPSHOT + */ + @Parameter(property = "spotbugs.includeFilterFiles") + List includeFilterFiles + /** *

* File name of the exclude filter. Bugs matching the filters are not reported. @@ -914,6 +940,16 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } + if (includeFilterFiles) { + log.debug(" Adding Include Filter Files ") + + includeFilterFiles.each { includefilter -> + args << "-include" + args << resourceHelper.getResourceFile(includefilter.trim()) + } + + } + if (excludeFilterFile) { log.debug(" Adding Exclude Filter File ") String[] excludefilters = excludeFilterFile.split(SpotBugsInfo.COMMA) From b3e0d8cc60236829d6461e7d98619ede6f325336 Mon Sep 17 00:00:00 2001 From: "Henning P. Schmiedehausen" Date: Thu, 26 May 2022 11:17:05 -0700 Subject: [PATCH 0730/1013] Support multiple bug exclusion files. Spotbugs always supported multiple files as a comma-separated list in the configuration option. This change also adds support for multiple files as a list: ... ... This allows using pom inheritance to control multiple files. Includes integration test to verify function. --- src/it/exclude-multi-list/invoker.properties | 4 ++ src/it/exclude-multi-list/pom.xml | 61 +++++++++++++++++ src/it/exclude-multi-list/verify.groovy | 66 +++++++++++++++++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 32 +++++++++ 4 files changed, 163 insertions(+) create mode 100644 src/it/exclude-multi-list/invoker.properties create mode 100644 src/it/exclude-multi-list/pom.xml create mode 100644 src/it/exclude-multi-list/verify.groovy diff --git a/src/it/exclude-multi-list/invoker.properties b/src/it/exclude-multi-list/invoker.properties new file mode 100644 index 000000000..7fbf7d99f --- /dev/null +++ b/src/it/exclude-multi-list/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile site + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/exclude-multi-list/pom.xml b/src/it/exclude-multi-list/pom.xml new file mode 100644 index 000000000..2c700c8e0 --- /dev/null +++ b/src/it/exclude-multi-list/pom.xml @@ -0,0 +1,61 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + excludeFile-multi-list + excludeFile-multi-list + jar + + + + spotbugs-maven-plugin.it + build-tools + testing + + + + + true + + + org.apache.maven.plugins + maven-jxr-plugin + @jxrPluginVersion@ + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + + whizbang/lib-filter.xml + filters/lib-filter2.xml + + + + + + diff --git a/src/it/exclude-multi-list/verify.groovy b/src/it/exclude-multi-list/verify.groovy new file mode 100644 index 000000000..80d3f179d --- /dev/null +++ b/src/it/exclude-multi-list/verify.groovy @@ -0,0 +1,66 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugsHtml = new File(basedir, 'target/site/spotbugs.html') +assert spotbugsHtml.exists() + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + + +println '***************************' +println "Checking HTML file" +println '***************************' + +def xhtmlParser = new XmlSlurper(); +xhtmlParser.setFeature("http://apache.org/xml/features/disallow-doctype-decl", false) +xhtmlParser.setFeature("http://apache.org/xml/features/nonvalidating/load-external-dtd", false) +def path = xhtmlParser.parse( spotbugsHtml ) +//*[@id="contentBox"]/div[2]/table/tbody/tr[2]/td[2] +def spotbugsErrors = path.body.'**'.find {div -> div.@id == 'contentBox'}.section[1].table.tr[1].td[1].toInteger() +println "Error Count is ${spotbugsErrors}" + + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +path = new XmlSlurper().parse(spotbugXdoc) + +allNodes = path.depthFirst().collect{ it } +def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + + +assert xdocErrors == spotbugsXmlErrors + +assert spotbugsErrors == spotbugsXmlErrors diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 5ff6438f7..949ae593f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -330,6 +330,28 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(property = "spotbugs.excludeFilterFile") String excludeFilterFile + /** + *

+ * File name for exclude filter files. Bugs matching the filters are not reported. + *

+ * + *

+ * This is an alternative to <excludeFilterFile> which allows multiple + * files to be specified as separate elements in a pom. + *

+ * + *

+ * This parameter is resolved as resource, URL, then file. If successfully + * resolved, the contents of the configuration is copied into the + * ${project.build.directory} + * directory before being passed to Spotbugs as a filter file. + *

+ * + * @since 4.7.0.1-SNAPSHOT + */ + @Parameter(property = "spotbugs.excludeFilterFiles") + List excludeFilterFiles + /** *

* File names of the baseline files. Bugs found in the baseline files won't be reported. @@ -961,6 +983,16 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } + if (excludeFilterFiles) { + log.debug(" Adding Exclude Filter Files ") + + excludeFilterFiles.each { excludeFilter -> + args << "-exclude" + args << resourceHelper.getResourceFile(excludeFilter.trim()) + } + + } + if (excludeBugsFile) { log.debug(" Adding Exclude Bug Files (Baselines)") String[] excludeFiles = excludeBugsFile.split(SpotBugsInfo.COMMA) From 070c0e37195ae605cefcb408350d3b410a993bb9 Mon Sep 17 00:00:00 2001 From: "Henning P. Schmiedehausen" Date: Thu, 26 May 2022 11:18:28 -0700 Subject: [PATCH 0731/1013] Support multiple bug baseline files. Spotbugs always supported multiple files as a comma-separated list in the configuration option. This change also adds support for multiple files as a list: ... ... This allows using pom inheritance to control multiple files. As there were no integration tests for the bug baseline files, adds integration tests for - single bug exclusion file - multiple bug exclusion files, comma separated - multiple bug exclusion files as list --- .../baseline/spotbugs-baseline-other.xml | 181 +++++++++++++ .../spotbugs-baseline-outputstream.xml | 71 +++++ .../resources/baseline/spotbugs-baseline.xml | 249 ++++++++++++++++++ .../invoker.properties | 6 + src/it/check-bug-file-multi-list/pom.xml | 55 ++++ .../check-bug-file-multi-list/verify.groovy | 47 ++++ .../check-bug-file-multi/invoker.properties | 6 + src/it/check-bug-file-multi/pom.xml | 52 ++++ src/it/check-bug-file-multi/verify.groovy | 47 ++++ src/it/check-bug-file/invoker.properties | 6 + src/it/check-bug-file/pom.xml | 52 ++++ src/it/check-bug-file/verify.groovy | 47 ++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 37 ++- 13 files changed, 855 insertions(+), 1 deletion(-) create mode 100644 src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml create mode 100644 src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml create mode 100644 src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml create mode 100644 src/it/check-bug-file-multi-list/invoker.properties create mode 100644 src/it/check-bug-file-multi-list/pom.xml create mode 100644 src/it/check-bug-file-multi-list/verify.groovy create mode 100644 src/it/check-bug-file-multi/invoker.properties create mode 100644 src/it/check-bug-file-multi/pom.xml create mode 100644 src/it/check-bug-file-multi/verify.groovy create mode 100644 src/it/check-bug-file/invoker.properties create mode 100644 src/it/check-bug-file/pom.xml create mode 100644 src/it/check-bug-file/verify.groovy diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml new file mode 100644 index 000000000..16626519e --- /dev/null +++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-other.xml @@ -0,0 +1,181 @@ + + + + Bad comparison of signed byte + Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[]) + + + At AssumeUnsignedBytes.java:[lines 3-10] + + In class AssumeUnsignedBytes + + + + In method AssumeUnsignedBytes.find200(byte[]) + + + Value 200 + + + At AssumeUnsignedBytes.java:[line 8] + + + + Class defines equals() and uses Object.hashCode() + UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode() + + + At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24] + + In class UseOfNonHashableClassInHashDataStructure + + + + In method UseOfNonHashableClassInHashDataStructure.equals(Object) + + + At UseOfNonHashableClassInHashDataStructure.java:[line 16] + + + + Signature declares use of unhashable class in hashed construct + UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + In class UseOfNonHashableClassInHashDataStructure$UMap + + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + In class UseOfNonHashableClassInHashDataStructure$UMap + + + + At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24] + + Unhashable class UseOfNonHashableClassInHashDataStructure + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + + + Overwritten increment + Overwritten increment in UselessAssignments.oops() + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method UselessAssignments.oops() + + + At UselessAssignments.java:[line 30] + + + + Self assignment of field + Self assignment of field foo in new UselessAssignments(int, int) + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method new UselessAssignments(int, int) + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + Did you mean to refer to the local variable ? + + + At UselessAssignments.java:[line 16] + + + + Self assignment of field + Self assignment of field foo in UselessAssignments.oops() + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method UselessAssignments.oops() + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + At UselessAssignments.java:[line 31] + + + + Uninitialized read of field in constructor + Uninitialized read of foo in new UselessAssignments(int, int) + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method new UselessAssignments(int, int) + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + Did you mean to refer to the local variable ? + + + At UselessAssignments.java:[line 16] + + + + Reliance on default encoding + Found reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String) + + + At UserMistakes.java:[lines 10-43] + + In class UserMistakes + + + + In method UserMistakes.main(String[]) + + + + Called method new java.io.FileReader(String) + + + At UserMistakes.java:[line 26] + + + Another occurrence at UserMistakes.java:[line 37] + + + diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml new file mode 100644 index 000000000..20c0b2d9f --- /dev/null +++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml @@ -0,0 +1,71 @@ + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject1(File, Object) + + + At AppendingToAnObjectOutputStream.java:[line 14] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject2(File, Object) + + + At AppendingToAnObjectOutputStream.java:[line 21] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject3(String, Object) + + + At AppendingToAnObjectOutputStream.java:[line 28] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject4(String, Object) + + + At AppendingToAnObjectOutputStream.java:[line 35] + + + diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml new file mode 100644 index 000000000..b8a98ac53 --- /dev/null +++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml @@ -0,0 +1,249 @@ + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject1(File, Object) + + + At AppendingToAnObjectOutputStream.java:[line 14] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject2(File, Object) + + + At AppendingToAnObjectOutputStream.java:[line 21] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject3(String, Object) + + + At AppendingToAnObjectOutputStream.java:[line 28] + + + + Doomed attempt to append to an object output stream + Doomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object) + + + At AppendingToAnObjectOutputStream.java:[lines 10-38] + + In class AppendingToAnObjectOutputStream + + + + In method AppendingToAnObjectOutputStream.appendObject4(String, Object) + + + At AppendingToAnObjectOutputStream.java:[line 35] + + + + Bad comparison of signed byte + Bad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[]) + + + At AssumeUnsignedBytes.java:[lines 3-10] + + In class AssumeUnsignedBytes + + + + In method AssumeUnsignedBytes.find200(byte[]) + + + Value 200 + + + At AssumeUnsignedBytes.java:[line 8] + + + + Class defines equals() and uses Object.hashCode() + UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode() + + + At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24] + + In class UseOfNonHashableClassInHashDataStructure + + + + In method UseOfNonHashableClassInHashDataStructure.equals(Object) + + + At UseOfNonHashableClassInHashDataStructure.java:[line 16] + + + + Signature declares use of unhashable class in hashed construct + UseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but it is used in a hashed context in UseOfNonHashableClassInHashDataStructure$UMap + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + In class UseOfNonHashableClassInHashDataStructure$UMap + + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + In class UseOfNonHashableClassInHashDataStructure$UMap + + + + At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24] + + Unhashable class UseOfNonHashableClassInHashDataStructure + + + At UseOfNonHashableClassInHashDataStructure.java:[line 5] + + + + Overwritten increment + Overwritten increment in UselessAssignments.oops() + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method UselessAssignments.oops() + + + At UselessAssignments.java:[line 30] + + + + Self assignment of field + Self assignment of field foo in new UselessAssignments(int, int) + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method new UselessAssignments(int, int) + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + Did you mean to refer to the local variable ? + + + At UselessAssignments.java:[line 16] + + + + Self assignment of field + Self assignment of field foo in UselessAssignments.oops() + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method UselessAssignments.oops() + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + At UselessAssignments.java:[line 31] + + + + Uninitialized read of field in constructor + Uninitialized read of foo in new UselessAssignments(int, int) + + + At UselessAssignments.java:[lines 14-42] + + In class UselessAssignments + + + + In method new UselessAssignments(int, int) + + + + In UselessAssignments.java + + Field UselessAssignments.foo + + + Did you mean to refer to the local variable ? + + + At UselessAssignments.java:[line 16] + + + + Reliance on default encoding + Found reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String) + + + At UserMistakes.java:[lines 10-43] + + In class UserMistakes + + + + In method UserMistakes.main(String[]) + + + + Called method new java.io.FileReader(String) + + + At UserMistakes.java:[line 26] + + + Another occurrence at UserMistakes.java:[line 37] + + + diff --git a/src/it/check-bug-file-multi-list/invoker.properties b/src/it/check-bug-file-multi-list/invoker.properties new file mode 100644 index 000000000..7e683f233 --- /dev/null +++ b/src/it/check-bug-file-multi-list/invoker.properties @@ -0,0 +1,6 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success + +#invoker.mavenOpts = -Xdebug -Xnoagent -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000 diff --git a/src/it/check-bug-file-multi-list/pom.xml b/src/it/check-bug-file-multi-list/pom.xml new file mode 100644 index 000000000..a6f59dd83 --- /dev/null +++ b/src/it/check-bug-file-multi-list/pom.xml @@ -0,0 +1,55 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check-bug-file-multi-list + check-bug-file-multi-list + jar + + + + spotbugs-maven-plugin.it + build-tools + testing + + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + High + + baseline/spotbugs-baseline-outputstream.xml + baseline/spotbugs-baseline-other.xml + + + + + + diff --git a/src/it/check-bug-file-multi-list/verify.groovy b/src/it/check-bug-file-multi-list/verify.groovy new file mode 100644 index 000000000..3ee96b1f7 --- /dev/null +++ b/src/it/check-bug-file-multi-list/verify.groovy @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +path = new XmlSlurper().parse(spotbugXdoc) + +allNodes = path.depthFirst().collect{ it } +def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + +assert xdocErrors == 0 +assert spotbugsXmlErrors == 0 diff --git a/src/it/check-bug-file-multi/invoker.properties b/src/it/check-bug-file-multi/invoker.properties new file mode 100644 index 000000000..7e683f233 --- /dev/null +++ b/src/it/check-bug-file-multi/invoker.properties @@ -0,0 +1,6 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success + +#invoker.mavenOpts = -Xdebug -Xnoagent -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000 diff --git a/src/it/check-bug-file-multi/pom.xml b/src/it/check-bug-file-multi/pom.xml new file mode 100644 index 000000000..a52cabb70 --- /dev/null +++ b/src/it/check-bug-file-multi/pom.xml @@ -0,0 +1,52 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check-bug-file-multi + check-bug-file-multi + jar + + + + spotbugs-maven-plugin.it + build-tools + testing + + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + High + baseline/spotbugs-baseline-outputstream.xml,baseline/spotbugs-baseline-other.xml + + + + + diff --git a/src/it/check-bug-file-multi/verify.groovy b/src/it/check-bug-file-multi/verify.groovy new file mode 100644 index 000000000..3ee96b1f7 --- /dev/null +++ b/src/it/check-bug-file-multi/verify.groovy @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +path = new XmlSlurper().parse(spotbugXdoc) + +allNodes = path.depthFirst().collect{ it } +def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + +assert xdocErrors == 0 +assert spotbugsXmlErrors == 0 diff --git a/src/it/check-bug-file/invoker.properties b/src/it/check-bug-file/invoker.properties new file mode 100644 index 000000000..7e683f233 --- /dev/null +++ b/src/it/check-bug-file/invoker.properties @@ -0,0 +1,6 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success + +#invoker.mavenOpts = -Xdebug -Xnoagent -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000 diff --git a/src/it/check-bug-file/pom.xml b/src/it/check-bug-file/pom.xml new file mode 100644 index 000000000..18195b67d --- /dev/null +++ b/src/it/check-bug-file/pom.xml @@ -0,0 +1,52 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check-bug-file + check-bug-file + jar + + + + spotbugs-maven-plugin.it + build-tools + testing + + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + High + baseline/spotbugs-baseline.xml + + + + + diff --git a/src/it/check-bug-file/verify.groovy b/src/it/check-bug-file/verify.groovy new file mode 100644 index 000000000..3ee96b1f7 --- /dev/null +++ b/src/it/check-bug-file/verify.groovy @@ -0,0 +1,47 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import groovy.xml.XmlSlurper + +File spotbugXdoc = new File(basedir, 'target/spotbugs.xml') +assert spotbugXdoc.exists() + +File spotbugXml = new File(basedir, 'target/spotbugsXml.xml') +assert spotbugXml.exists() + +println '**********************************' +println "Checking Spotbugs Native XML file" +println '**********************************' + +path = new XmlSlurper().parse(spotbugXml) + +allNodes = path.depthFirst().collect{ it } +def spotbugsXmlErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${spotbugsXmlErrors}" + + +println '***************************' +println "Checking xDoc file" +println '***************************' + +path = new XmlSlurper().parse(spotbugXdoc) + +allNodes = path.depthFirst().collect{ it } +def xdocErrors = allNodes.findAll {it.name() == 'BugInstance'}.size() +println "BugInstance size is ${xdocErrors}" + +assert xdocErrors == 0 +assert spotbugsXmlErrors == 0 diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 949ae593f..811ec68cf 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -375,6 +375,32 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(property = "spotbugs.excludeBugsFile") String excludeBugsFile + /** + *

+ * File names of the baseline files. Bugs found in the baseline files won't be reported. + *

+ * + *

+ * Potential values are a filesystem path, a URL, or a classpath resource. + *

+ * + *

+ * This is an alternative to <excludeBugsFile> which allows multiple + * files to be specified as separate elements in a pom. + *

+ * + *

+ * This parameter is resolved as resource, URL, then file. If successfully + * resolved, the contents of the configuration is copied into the + * ${project.build.directory} + * directory before being passed to Spotbugs as a filter file. + *

+ * + * @since 4.7.0.1-SNAPSHOT + */ + @Parameter(property = "spotbugs.excludeBugsFiles") + List excludeBugsFiles + /** * Effort of the bug finders. Valid values are Min, Default and Max. * @@ -994,7 +1020,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } if (excludeBugsFile) { - log.debug(" Adding Exclude Bug Files (Baselines)") + log.debug(" Adding Exclude Bug File (Baselines)") String[] excludeFiles = excludeBugsFile.split(SpotBugsInfo.COMMA) excludeFiles.each() { excludeFile -> @@ -1003,6 +1029,15 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } } + if (excludeBugsFiles) { + log.debug(" Adding Exclude Bug Files (Baselines)") + + excludeBugsFiles.each() { excludeFile -> + args << "-excludeBugs" + args << resourceHelper.getResourceFile(excludeFile.trim()) + } + } + if (addSourceDirs) { log.debug(" Adding Source directories (To process source exclusions)") args << "-sourcepath" From c0b2fff3389d38ecaa78b99b97c067030b08297a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 22:11:49 -0400 Subject: [PATCH 0732/1013] [pom] Bump jgit to 5.13.1.202206130422-r --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c8effa70e..c184a5101 100644 --- a/pom.xml +++ b/pom.xml @@ -181,7 +181,7 @@ 4.0.4 7.4.7 - 5.13.0.202109080827-r + 5.13.1.202206130422-r 9.3 From 993d405f7132fb98e4c9a35186e9af42fc411983 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 4 Jul 2022 22:13:11 -0400 Subject: [PATCH 0733/1013] [pom] Adjust since to match release version in flight --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 811ec68cf..37f33d59e 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -303,7 +303,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * directory before being passed to Spotbugs as a filter file. *

* - * @since 4.7.0.1-SNAPSHOT + * @since 4.7.1.0 */ @Parameter(property = "spotbugs.includeFilterFiles") List includeFilterFiles @@ -347,7 +347,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * directory before being passed to Spotbugs as a filter file. *

* - * @since 4.7.0.1-SNAPSHOT + * @since 4.7.1.0 */ @Parameter(property = "spotbugs.excludeFilterFiles") List excludeFilterFiles @@ -396,7 +396,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * directory before being passed to Spotbugs as a filter file. *

* - * @since 4.7.0.1-SNAPSHOT + * @since 4.7.1.0 */ @Parameter(property = "spotbugs.excludeBugsFiles") List excludeBugsFiles From f87e38e82db044e8c745cb6738abc3ef9c987aa5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 16:45:44 -0400 Subject: [PATCH 0734/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.1.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c184a5101..66528b068 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.1.0-SNAPSHOT + 4.7.1.0 maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.1.0 Github From 00f957f12966e0df9a876c450f640397b2ebccc1 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 16:45:48 -0400 Subject: [PATCH 0735/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 66528b068..34aa21284 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.1.0 + 4.7.1.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -94,7 +94,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.1.0 + HEAD Github From 809eee1633cd66baabeba21fcba7b8f5515fb934 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 17:05:45 -0400 Subject: [PATCH 0736/1013] [dependabot] Add github-actions and format slightly different --- .github/dependabot.yml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index daec31893..bd840b548 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,6 +1,10 @@ version: 2 updates: - - package-ecosystem: "maven" - directory: "/" - schedule: - interval: "daily" +- package-ecosystem: github-actions + directory: "/" + schedule: + interval: daily +- package-ecosystem: "maven" + directory: "/" + schedule: + interval: "daily" From e37b74682b6fc465ba49980faf149b2489cb9c7f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 17:47:40 -0400 Subject: [PATCH 0737/1013] [pom] Move javaparser to overall project (site issue) For some reason this doesn't pick up properly for gmavenplus now. Tried moving it directly there and that didn't work either so make it global. --- pom.xml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pom.xml b/pom.xml index 34aa21284..6a09dcb8b 100644 --- a/pom.xml +++ b/pom.xml @@ -317,6 +317,12 @@ groovy-xml + + com.github.javaparser + javaparser-core + ${javaparserVersion} + + org.apache.maven.reporting @@ -560,11 +566,6 @@ doxia-sink-api ${doxiaVersion} - - com.github.javaparser - javaparser-core - ${javaparserVersion} - From 9b85225cbf0e4978c3c2a8bfe1a9b890f10dd590 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 6 Jul 2022 22:54:42 +0000 Subject: [PATCH 0738/1013] Bump github/codeql-action from 1 to 2 Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/github/codeql-action/compare/v1...v2) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/codeql-analysis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 0f7025196..9ed3c0f76 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -43,7 +43,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@v1 + uses: github/codeql-action/init@v2 with: languages: ${{ matrix.language }} # If you wish to specify custom queries, you can do so here or in a config file. @@ -54,7 +54,7 @@ jobs: # Autobuild attempts to build any compiled languages (C/C++, C#, or Java). # If this step fails, then you should remove it and run the build manually (see below) - name: Autobuild - uses: github/codeql-action/autobuild@v1 + uses: github/codeql-action/autobuild@v2 # ℹ️ Command-line programs to run using the OS shell. # 📚 https://git.io/JvXDl @@ -68,4 +68,4 @@ jobs: # make release - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@v1 + uses: github/codeql-action/analyze@v2 From 477470c1c05204a1b9fd05e0448b902ffae0016f Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 6 Jul 2022 23:15:11 +0000 Subject: [PATCH 0739/1013] Bump JamesIves/github-pages-deploy-action from 3.7.1 to 4.3.4 Bumps [JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action) from 3.7.1 to 4.3.4. - [Release notes](https://github.com/JamesIves/github-pages-deploy-action/releases) - [Commits](https://github.com/JamesIves/github-pages-deploy-action/compare/3.7.1...v4.3.4) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 1953cc2fc..a825c17a7 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -25,7 +25,7 @@ jobs: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Site to gh-pages - uses: JamesIves/github-pages-deploy-action@3.7.1 + uses: JamesIves/github-pages-deploy-action@v4.3.4 with: SSH: true BRANCH: gh-pages From c864324d0cf1cbbd97ade81155a2e089ce0d9eca Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 19:53:26 -0400 Subject: [PATCH 0740/1013] [pom] Bump base-parent to 36 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6a09dcb8b..c5d04c220 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 35 + 36 From 14b7e3de05c669cb4f52ce1474d954d9e382caa8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 6 Jul 2022 20:10:02 -0400 Subject: [PATCH 0741/1013] [mvn] Update maven wrapper --- .mvn/wrapper/MavenWrapperDownloader.java | 146 +++++++++++++---------- .mvn/wrapper/maven-wrapper.properties | 10 +- 2 files changed, 88 insertions(+), 68 deletions(-) diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java index 17add53ea..732313c43 100644 --- a/.mvn/wrapper/MavenWrapperDownloader.java +++ b/.mvn/wrapper/MavenWrapperDownloader.java @@ -17,14 +17,24 @@ * under the License. */ -import java.net.*; -import java.io.*; -import java.nio.channels.*; +import java.io.IOException; +import java.io.InputStream; +import java.net.Authenticator; +import java.net.PasswordAuthentication; +import java.net.URL; +import java.nio.file.Files; +import java.nio.file.LinkOption; +import java.nio.file.Path; +import java.nio.file.Paths; +import java.nio.file.StandardCopyOption; +import java.nio.file.StandardOpenOption; import java.util.Properties; -public class MavenWrapperDownloader +public final class MavenWrapperDownloader { - private static final String WRAPPER_VERSION = "3.1.0"; + private static final String WRAPPER_VERSION = "3.1.1"; + + private static final boolean VERBOSE = Boolean.parseBoolean( System.getenv( "MVNW_VERBOSE" ) ); /** * Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' is provided. @@ -49,78 +59,53 @@ public class MavenWrapperDownloader */ private static final String PROPERTY_NAME_WRAPPER_URL = "wrapperUrl"; - public static void main( String args[] ) + public static void main( String[] args ) { - System.out.println( "- Downloader started" ); - File baseDirectory = new File( args[0] ); - System.out.println( "- Using base directory: " + baseDirectory.getAbsolutePath() ); - - // If the maven-wrapper.properties exists, read it and check if it contains a custom - // wrapperUrl parameter. - File mavenWrapperPropertyFile = new File( baseDirectory, MAVEN_WRAPPER_PROPERTIES_PATH ); - String url = DEFAULT_DOWNLOAD_URL; - if ( mavenWrapperPropertyFile.exists() ) + if ( args.length == 0 ) { - FileInputStream mavenWrapperPropertyFileInputStream = null; - try - { - mavenWrapperPropertyFileInputStream = new FileInputStream( mavenWrapperPropertyFile ); - Properties mavenWrapperProperties = new Properties(); - mavenWrapperProperties.load( mavenWrapperPropertyFileInputStream ); - url = mavenWrapperProperties.getProperty( PROPERTY_NAME_WRAPPER_URL, url ); - } - catch ( IOException e ) - { - System.out.println( "- ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'" ); - } - finally - { - try - { - if ( mavenWrapperPropertyFileInputStream != null ) - { - mavenWrapperPropertyFileInputStream.close(); - } - } - catch ( IOException e ) - { - // Ignore ... - } - } + System.err.println( " - ERROR projectBasedir parameter missing" ); + System.exit( 1 ); } - System.out.println( "- Downloading from: " + url ); - File outputFile = new File( baseDirectory.getAbsolutePath(), MAVEN_WRAPPER_JAR_PATH ); - if ( !outputFile.getParentFile().exists() ) + log( " - Downloader started" ); + final String dir = args[0].replace( "..", "" ); // Sanitize path + final Path projectBasedir = Paths.get( dir ).toAbsolutePath().normalize(); + if ( !Files.isDirectory( projectBasedir, LinkOption.NOFOLLOW_LINKS ) ) { - if ( !outputFile.getParentFile().mkdirs() ) - { - System.out.println( "- ERROR creating output directory '" + outputFile.getParentFile().getAbsolutePath() - + "'" ); - } + System.err.println( " - ERROR projectBasedir not exists: " + projectBasedir ); + System.exit( 1 ); } - System.out.println( "- Downloading to: " + outputFile.getAbsolutePath() ); + + log( " - Using base directory: " + projectBasedir ); + + // If the maven-wrapper.properties exists, read it and check if it contains a custom + // wrapperUrl parameter. + Path mavenWrapperPropertyFile = projectBasedir.resolve( MAVEN_WRAPPER_PROPERTIES_PATH ); + String url = readWrapperUrl( mavenWrapperPropertyFile ); + try { + Path outputFile = projectBasedir.resolve( MAVEN_WRAPPER_JAR_PATH ); + createDirectories( outputFile.getParent() ); downloadFileFromURL( url, outputFile ); - System.out.println( "Done" ); + log( "Done" ); System.exit( 0 ); } - catch ( Throwable e ) + catch ( IOException e ) { - System.out.println( "- Error downloading" ); + System.err.println( "- Error downloading" ); e.printStackTrace(); System.exit( 1 ); } } - private static void downloadFileFromURL( String urlString, File destination ) - throws Exception + private static void downloadFileFromURL( String urlString, Path destination ) throws IOException { + log( " - Downloading to: " + destination ); if ( System.getenv( "MVNW_USERNAME" ) != null && System.getenv( "MVNW_PASSWORD" ) != null ) { - String username = System.getenv( "MVNW_USERNAME" ); - char[] password = System.getenv( "MVNW_PASSWORD" ).toCharArray(); + final String username = System.getenv( "MVNW_USERNAME" ); + final char[] password = System.getenv( "MVNW_PASSWORD" ).toCharArray(); Authenticator.setDefault( new Authenticator() { @Override @@ -131,12 +116,47 @@ protected PasswordAuthentication getPasswordAuthentication() } ); } URL website = new URL( urlString ); - ReadableByteChannel rbc; - rbc = Channels.newChannel( website.openStream() ); - FileOutputStream fos = new FileOutputStream( destination ); - fos.getChannel().transferFrom( rbc, 0, Long.MAX_VALUE ); - fos.close(); - rbc.close(); + try ( InputStream inStream = website.openStream() ) { + Files.copy( inStream, destination, StandardCopyOption.REPLACE_EXISTING ); + } + log( " - Downloader complete" ); + } + + private static void createDirectories(Path outputPath) throws IOException + { + if ( !Files.isDirectory( outputPath, LinkOption.NOFOLLOW_LINKS ) ) { + Path createDirectories = Files.createDirectories( outputPath ); + log( " - Directories created: " + createDirectories ); + } + } + + private static String readWrapperUrl( Path mavenWrapperPropertyFile ) + { + String url = DEFAULT_DOWNLOAD_URL; + if ( Files.exists( mavenWrapperPropertyFile, LinkOption.NOFOLLOW_LINKS ) ) + { + log( " - Reading property file: " + mavenWrapperPropertyFile ); + try ( InputStream in = Files.newInputStream( mavenWrapperPropertyFile, StandardOpenOption.READ ) ) + { + Properties mavenWrapperProperties = new Properties(); + mavenWrapperProperties.load( in ); + url = mavenWrapperProperties.getProperty( PROPERTY_NAME_WRAPPER_URL, DEFAULT_DOWNLOAD_URL ); + } + catch ( IOException e ) + { + System.err.println( " - ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'" ); + } + } + log( " - Downloading from: " + url ); + return url; + } + + private static void log( String msg ) + { + if ( VERBOSE ) + { + System.out.println( msg ); + } } } diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index db95c131d..dc3affce3 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -5,14 +5,14 @@ # to you under the Apache License, Version 2.0 (the # "License"); you may not use this file except in compliance # with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# +# +# https://www.apache.org/licenses/LICENSE-2.0 +# # Unless required by applicable law or agreed to in writing, # software distributed under the License is distributed on an # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.5/apache-maven-3.8.5-bin.zip -wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip +wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar From b746a180ec469b9b5098a74357cbd5a7654d43fe Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Jul 2022 19:02:16 +0000 Subject: [PATCH 0742/1013] Bump maven-project-info-reports-plugin from 3.3.0 to 3.4.0 Bumps [maven-project-info-reports-plugin](https://github.com/apache/maven-project-info-reports-plugin) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/apache/maven-project-info-reports-plugin/releases) - [Commits](https://github.com/apache/maven-project-info-reports-plugin/compare/maven-project-info-reports-plugin-3.3.0...maven-project-info-reports-plugin-3.4.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-project-info-reports-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c5d04c220..d90ac2abd 100644 --- a/pom.xml +++ b/pom.xml @@ -151,7 +151,7 @@ 1.8 0.22-1 1.13.1 - 3.3.0 + 3.4.0 3.3.0 3.4.0 3.6.4 From 86de1a79faf929715953ce5e5c22b1525f90fa7e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Jul 2022 19:02:42 +0000 Subject: [PATCH 0743/1013] Bump maven-common-artifact-filters from 3.3.0 to 3.3.1 Bumps [maven-common-artifact-filters](https://github.com/apache/maven-common-artifact-filters) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/apache/maven-common-artifact-filters/releases) - [Commits](https://github.com/apache/maven-common-artifact-filters/compare/maven-common-artifact-filters-3.3.0...maven-common-artifact-filters-3.3.1) --- updated-dependencies: - dependency-name: org.apache.maven.shared:maven-common-artifact-filters dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d90ac2abd..c3f9ddfa1 100644 --- a/pom.xml +++ b/pom.xml @@ -138,7 +138,7 @@ 3.8.6 3.3.4 0.13.1 - 3.3.0 + 3.3.1 3.1.0 3.1.0 3.8.6 From dd0df240aaabb85a9767ee5ad06c988d16450c7b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 21 Jul 2022 19:54:24 +0000 Subject: [PATCH 0744/1013] Bump JamesIves/github-pages-deploy-action from 4.3.4 to 4.4.0 Bumps [JamesIves/github-pages-deploy-action](https://github.com/JamesIves/github-pages-deploy-action) from 4.3.4 to 4.4.0. - [Release notes](https://github.com/JamesIves/github-pages-deploy-action/releases) - [Commits](https://github.com/JamesIves/github-pages-deploy-action/compare/v4.3.4...v4.4.0) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index a825c17a7..156ee972e 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -25,7 +25,7 @@ jobs: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Site to gh-pages - uses: JamesIves/github-pages-deploy-action@v4.3.4 + uses: JamesIves/github-pages-deploy-action@v4.4.0 with: SSH: true BRANCH: gh-pages From 77862f53f750f7b0deede53aa2d6b34fe750807b Mon Sep 17 00:00:00 2001 From: Marvin Rensing Date: Fri, 22 Jul 2022 14:00:30 +0200 Subject: [PATCH 0745/1013] Validate Spotbugs report even if only test sources exist If you use this plugin in a project that only has test sources (source files in the folder `src/test/`) and no source files in the main folder (`src/main/`), then it'd not validate the report generated by spotbugs. Instead it would only log 0 bugs. Instead of verifying only the folder for class files (main folder), we also check if there are test class files (only if the option `includeTests` is enabled). If there are test files, validation of the report takes place. Fixes #454 --- .../invoker.properties | 4 ++ src/it/check-bug-only-test-sources/pom.xml | 47 +++++++++++++++++++ .../check-bug-only-test-sources/verify.groovy | 18 +++++++ .../spotbugs/BaseViolationCheckMojo.groovy | 21 ++++++--- 4 files changed, 84 insertions(+), 6 deletions(-) create mode 100644 src/it/check-bug-only-test-sources/invoker.properties create mode 100644 src/it/check-bug-only-test-sources/pom.xml create mode 100644 src/it/check-bug-only-test-sources/verify.groovy diff --git a/src/it/check-bug-only-test-sources/invoker.properties b/src/it/check-bug-only-test-sources/invoker.properties new file mode 100644 index 000000000..4d27a3eed --- /dev/null +++ b/src/it/check-bug-only-test-sources/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean package spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = failure diff --git a/src/it/check-bug-only-test-sources/pom.xml b/src/it/check-bug-only-test-sources/pom.xml new file mode 100644 index 000000000..a9d29bf83 --- /dev/null +++ b/src/it/check-bug-only-test-sources/pom.xml @@ -0,0 +1,47 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check-bug-only-test-sources + check-bug-only-test-sources + jar + + + src/main + @project.basedir@/src/it-src/test/java + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + @spotbugsTestDebug@ + + + + + diff --git a/src/it/check-bug-only-test-sources/verify.groovy b/src/it/check-bug-only-test-sources/verify.groovy new file mode 100644 index 000000000..0c78ffed1 --- /dev/null +++ b/src/it/check-bug-only-test-sources/verify.groovy @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File buildLog = new File( basedir, 'build.log' ) +assert buildLog.text.contains( 'BugInstance size is 2' ) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 8f02039bc..c153f996c 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -479,15 +479,10 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { @Override void execute() { Locale locale = Locale.getDefault() - List sourceFiles log.debug("Executing spotbugs:check") - if (this.classFilesDirectory.exists() && this.classFilesDirectory.isDirectory()) { - sourceFiles = FileUtils.getFiles(classFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null) - } - - if (!skip && sourceFiles) { + if (!skip && doSourceFilesExist()) { // this goes @@ -555,6 +550,20 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { } } + private boolean doSourceFilesExist() { + List sourceFiles = new ArrayList() + + if (this.classFilesDirectory.exists() && this.classFilesDirectory.isDirectory()) { + sourceFiles.addAll(FileUtils.getFiles(classFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null)) + } + + if (this.includeTests && this.testClassFilesDirectory.exists() && this.testClassFilesDirectory.isDirectory()) { + sourceFiles.addAll(FileUtils.getFiles(testClassFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null)) + } + + !sourceFiles.isEmpty() + } + private void printBugs(total, bugs) { for (i in 0..total - 1) { def bug = bugs[i] From c357039bbd264fbac82b58aed26a5deedf5ffc28 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 22 Jul 2022 21:10:51 -0400 Subject: [PATCH 0746/1013] [ci] Fix FooTest for junit 5 styling needs --- .../org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java index c62b78aa0..987369648 100644 --- a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java +++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java @@ -9,7 +9,7 @@ * * @author user@example.com (John Doe) */ -public class FooTest { +class FooTest { @Test void thisAlwaysPasses() { @@ -18,7 +18,7 @@ void thisAlwaysPasses() { @Disabled @Test - public void thisIsIgnored() { + void thisIsIgnored() { // Do nothing } } From 2e6a9ea915c2d9a45ac0016ffa052667d01fc04f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 11:41:34 -0400 Subject: [PATCH 0747/1013] [pom] Bump groovy to 4.0.4 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index c3f9ddfa1..727080c1f 100644 --- a/pom.xml +++ b/pom.xml @@ -128,7 +128,7 @@ 1.7.36 1.10.12 - 4.0.3 + 4.0.4 3.0.11 3.24.2 From 34eae3edb57cd6e08e82a5835aeedb2d703329a2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 14:46:01 -0400 Subject: [PATCH 0748/1013] [pom] Bump junit jupiter to 5.9.0-RC1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 727080c1f..887c606ba 100644 --- a/pom.xml +++ b/pom.xml @@ -122,7 +122,7 @@ 1.8 - 5.8.2 + 5.9.0-RC1 4.7.1 4.7.1 1.7.36 From d1cf77057ce424bceec6526b7240c883e287ea28 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 14:46:11 -0400 Subject: [PATCH 0749/1013] [pom] Bump groovy3 to 3.0.12 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 887c606ba..057ed1798 100644 --- a/pom.xml +++ b/pom.xml @@ -129,7 +129,7 @@ 1.10.12 4.0.4 - 3.0.11 + 3.0.12 3.24.2 1.11.1 From 272a8af1c1e07e0bdcef38e6b9262defa3934f33 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 14:49:45 -0400 Subject: [PATCH 0750/1013] [pom] Move to codehaus l10n-maven-plugin 1.0.0 other one is not supported any longer and was from 2014. This one was way out of date too but is back to support and released in 2022. --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 057ed1798..f9bff3042 100644 --- a/pom.xml +++ b/pom.xml @@ -148,7 +148,7 @@ 3.4.2 3.1.0 - 1.8 + 1.0.0 0.22-1 1.13.1 3.4.0 @@ -698,7 +698,7 @@ ${infoReportsPluginVersion} - com.googlecode.l10n-maven-plugin + org.codehaus.mojo l10n-maven-plugin ${l10nPluginVersion} From 1f8efd69c7b19e3f5bc0005cff1092c99e61167d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 15:25:33 -0400 Subject: [PATCH 0751/1013] [pom] Add myself to developers / contributor section was not picking up from my base parent. --- pom.xml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/pom.xml b/pom.xml index f9bff3042..cb4368a15 100644 --- a/pom.xml +++ b/pom.xml @@ -30,6 +30,22 @@ https://spotbugs.github.io/ + + jlandis + Jeremy Landis + jeremylandis@hotmail.com + https://www.linkedin.com/in/jeremy-landis-548b2719 + hazendaz + https://github.com/hazendaz + + Architect + Developer + + -5 + + https://avatars0.githubusercontent.com/u/975267 + + cr Cyrill Ruettimann @@ -53,6 +69,20 @@ + + Jeremy Landis + jeremylandis@hotmail.com + https://www.linkedin.com/in/jeremy-landis-548b2719 + hazendaz + https://github.com/hazendaz + + Developer + + -5 + + https://avatars0.githubusercontent.com/u/975267 + + Olivier Lamy olamy@apache.org From 14e1438157eb4b335385559b49c3d19c82637bf7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 15:16:51 -0400 Subject: [PATCH 0752/1013] [pom] Cleanup spotbugs on site likely was when parent was still using the fork originally, had it listed two times. Clarify second by using actual group and artifact like everything else in this, keep project version. Remove the other one as it was running anyways. --- pom.xml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/pom.xml b/pom.xml index cb4368a15..e1c2c3dcb 100644 --- a/pom.xml +++ b/pom.xml @@ -699,14 +699,6 @@ true - - com.github.spotbugs - spotbugs-maven-plugin - ${project.version} - - true - - org.apache.maven.plugins maven-javadoc-plugin @@ -751,8 +743,8 @@ - ${project.groupId} - ${project.artifactId} + com.github.spotbugs + spotbugs-maven-plugin ${project.version} From 66d0c07646ad1dbf07883adc9093d93133222e1e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 15:41:11 -0400 Subject: [PATCH 0753/1013] [ci] Formatting --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index c153f996c..ccfb879c6 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -544,8 +544,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ") } } - } - else { + } else { log.debug("Nothing for SpotBugs to do here.") } } From 9a1fdde62f272549c5aa62f644378e4833ca4d2f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 16:16:58 -0400 Subject: [PATCH 0754/1013] [ci] Formatting --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 1 - .../groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy | 5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index ccfb879c6..52b76b0a4 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -567,7 +567,6 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { for (i in 0..total - 1) { def bug = bugs[i] log.error( bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type') - } } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy index e355f8271..4039fafb3 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/PluginArtifact.groovy @@ -1,7 +1,8 @@ package org.codehaus.mojo.spotbugs class PluginArtifact { - String groupId, artifactId, version - + String groupId; + String artifactId + String version String type = "jar" } From 6898a8a0e96d4d90cfd036e1b66ee5b8f6a3eefd Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 16:59:58 -0400 Subject: [PATCH 0755/1013] [ci] Remove unnecessary boxing --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 52b76b0a4..e8d548cf4 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -525,7 +525,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { for (i in 0..bugCount-1) { def bug = bugs[i] - def priorityNum = bug.'@priority' as int + def priorityNum = bug.'@priority' def priorityName = SpotBugsInfo.spotbugsPriority[priorityNum] def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' From 967df4f690a2216117016e9364cc475090e1890b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:00:26 -0400 Subject: [PATCH 0756/1013] [ci] Formatting --- src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy | 1 - 1 file changed, 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 18a776465..e2c35a990 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -233,6 +233,5 @@ class XDocsReporter { outputWriter << xmlBuilder.bind(xdoc) outputWriter.flush() outputWriter.close() - } } From 233594b6e2c79a79deb898a4c376609e901bc4d5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:14:10 -0400 Subject: [PATCH 0757/1013] [ci] Formatting --- .../mojo/spotbugs/SourceFileIndexer.groovy | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy index 7ec02aba5..ef7730e4f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -86,24 +86,22 @@ class SourceFileIndexer { */ private void scanDirectory(File directory,List files,String baseDirectory) throws IOException { - if(directory.exists()) { - for(File child : directory.listFiles()) { - if(child.isDirectory()) { + if (directory.exists()) { + for (File child : directory.listFiles()) { + if (child.isDirectory()) { scanDirectory(child,files,baseDirectory); - } - else { + } else { String newSourceFile = normalizePath(child.canonicalPath) - if(newSourceFile.startsWith(baseDirectory)) { - //The project will not be at the root of our file system. - //It will most likely be stored in a work directory. + if (newSourceFile.startsWith(baseDirectory)) { + // The project will not be at the root of our file system. + // It will most likely be stored in a work directory. // /work/project-code-to-scan/src/main/java/File.java => src/main/java/File.java // (Here baseDirectory is /work/project-code-to-scan/) String relativePath = Paths.get(baseDirectory).relativize(Paths.get(newSourceFile)) files.add(normalizePath(relativePath)) - } - else { - //Use the full path instead: - //This will occurs in many cases including when the pom.xml is + } else { + // Use the full path instead: + // This will occurs in many cases including when the pom.xml is // not in the same directory tree as the sources. files.add(newSourceFile) } From 2ee192d86da3a679b7443f91f83e5fc58a39a8ce Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:18:58 -0400 Subject: [PATCH 0758/1013] [ci] Remove unthrown exception and more formatting / clarification --- .../mojo/spotbugs/SourceFileIndexer.groovy | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy index ef7730e4f..3a4af3939 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -82,21 +82,20 @@ class SourceFileIndexer { * @param directory Directory to scan * @param files ArrayList where files found will be stored * @param baseDirectory This part will be truncated from path stored - * @throws IOException */ - private void scanDirectory(File directory,List files,String baseDirectory) throws IOException { + private void scanDirectory(File directory,List files,String baseDirectory) { if (directory.exists()) { for (File child : directory.listFiles()) { if (child.isDirectory()) { - scanDirectory(child,files,baseDirectory); + scanDirectory(child, files, baseDirectory); } else { String newSourceFile = normalizePath(child.canonicalPath) if (newSourceFile.startsWith(baseDirectory)) { // The project will not be at the root of our file system. // It will most likely be stored in a work directory. - // /work/project-code-to-scan/src/main/java/File.java => src/main/java/File.java - // (Here baseDirectory is /work/project-code-to-scan/) + // Example: /work/project-code-to-scan/src/main/java/File.java => src/main/java/File.java + // (Here baseDirectory is /work/project-code-to-scan/) String relativePath = Paths.get(baseDirectory).relativize(Paths.get(newSourceFile)) files.add(normalizePath(relativePath)) } else { @@ -129,18 +128,19 @@ class SourceFileIndexer { */ protected String searchActualFilesLocation(String filename) { - if(allSourceFiles == null) { + if (allSourceFiles == null) { throw new RuntimeException("Source files cache must be built prior to searches.") } - for(String fileFound in allSourceFiles) { + for (String fileFound in allSourceFiles) { - if(fileFound.endsWith(filename)) { + if (fileFound.endsWith(filename)) { return fileFound } } - return null //Not found + return null // Not found } + } From e977115c2f7eaa7ff16db1bdd5c4d6507647a4a6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:30:10 -0400 Subject: [PATCH 0759/1013] [ci] Do not box boolean --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 37f33d59e..49fe36beb 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -627,7 +627,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Override boolean canGenerateReport() { - def canGenerate = false + boolean canGenerate log.debug("****** SpotBugsMojo canGenerateReport *******") if (!skip && classFilesDirectory.exists()) { @@ -876,7 +876,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * */ protected boolean isJxrPluginEnabled() { - boolean isEnabled = false + boolean isEnabled if (xrefLocation.exists()) { isEnabled = true From de11ccf1de2562a482044a7bb1efe060bfb98eb2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:30:50 -0400 Subject: [PATCH 0760/1013] [ci] Minor cleanup --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 49fe36beb..332ad8f55 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1135,7 +1135,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { private void executeSpotbugs(File outputFile) { log.debug("****** SpotBugsMojo executeSpotbugs *******") - long startTime, duration + long startTime + long duration File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") File sarifTempFile = new File("${project.build.directory}/spotbugsTempSarif.json") @@ -1143,8 +1144,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { if (xmlOutput || !sarifOutput) { forceFileCreation(xmlTempFile) - } - else { + } else { forceFileCreation(sarifTempFile) } From ec7958889ccb49613323f552b59736c2b44a91de Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:44:38 -0400 Subject: [PATCH 0761/1013] [ci] Do not get locale if we are skipping as unnecessary --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 332ad8f55..1bbc1d7dd 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -786,8 +786,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { public void execute() { log.debug("****** SpotBugsMojo execute *******") - Locale locale = Locale.getDefault() if (!skip) { + Locale locale = Locale.getDefault() executeCheck(locale) if (canGenerateReport()) { generateXDoc(locale) @@ -1300,7 +1300,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { // With -Dspotbugs.sarifFullPath=true // The location uri will be replace by path relative to the root of project // SomeFile.java => src/main/java/SomeFile.java - //This change is required for some tool including Github code scanning API + // This change is required for some tool including Github code scanning API if (sarifFullPath) { def indexer = new SourceFileIndexer() From 63ef14af328a2716dc6ec4ce3fbb1aca703aef97 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:45:07 -0400 Subject: [PATCH 0762/1013] [ci] Add as Integer back in replacement of as int to resolve boxing --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index e8d548cf4..62228b95a 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -525,7 +525,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { for (i in 0..bugCount-1) { def bug = bugs[i] - def priorityNum = bug.'@priority' + def priorityNum = bug.'@priority' as Integer def priorityName = SpotBugsInfo.spotbugsPriority[priorityNum] def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' From cdfe8d1d3decb0ef2d11f0ef128e80f6366e3857 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:48:25 -0400 Subject: [PATCH 0763/1013] [ci] Reduce indentation by existing early if statement had unnecessary indentation and far path to completion, get out if we are skipping or if we cannot generate report. --- .../mojo/spotbugs/SpotBugsMojo.groovy | 87 +++++++++---------- 1 file changed, 40 insertions(+), 47 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 1bbc1d7dd..6fd15a535 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -721,64 +721,57 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("****** SpotBugsMojo executeReport *******") executeCheck(locale) - if (!skip && canGenerateReport()) { - - if (log.isDebugEnabled()) { - log.debug("Locale is ${locale.getLanguage()}") - log.debug("****** SpotBugsMojo executeReport *******") - log.debug("report Output Directory is " + getReportOutputDirectory()) - log.debug("Output Directory is " + outputDirectory) - log.debug("Classes Directory is " + classFilesDirectory) - log.debug(" Plugin Artifacts to be added ->" + pluginArtifacts.toString()) - } - - generateXDoc(locale) - - if (!outputDirectory.exists()) { - if (!outputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create html output directory") - } - } - - if (outputSpotbugsFile != null && outputSpotbugsFile.exists()) { - - if (skipEmptyReport && bugCount == 0) { - log.info("Skipping Generation Spotbugs HTML since there are not any bugs") - } else { - log.debug("Generating Spotbugs HTML") - - SpotbugsReportGenerator generator = new SpotbugsReportGenerator(getSink(), getBundle(locale), this.project.getBasedir(), siteTool) - - boolean isJxrPluginEnabled = isJxrPluginEnabled() - - generator.setIsJXRReportEnabled(isJxrPluginEnabled) + if (skip || !canGenerateReport()) { + log.info("cannot generate report") + return + } - if (isJxrPluginEnabled) { - generator.setCompileSourceRoots(this.compileSourceRoots) - generator.setTestSourceRoots(this.testSourceRoots) - generator.setXrefLocation(this.xrefLocation) - generator.setXrefTestLocation(this.xrefTestLocation) - generator.setIncludeTests(this.includeTests) - } + if (log.isDebugEnabled()) { + log.debug("Locale is ${locale.getLanguage()}") + log.debug("****** SpotBugsMojo executeReport *******") + log.debug("report Output Directory is " + getReportOutputDirectory()) + log.debug("Output Directory is " + outputDirectory) + log.debug("Classes Directory is " + classFilesDirectory) + log.debug(" Plugin Artifacts to be added ->" + pluginArtifacts.toString()) + } - generator.setLog(log) + generateXDoc(locale) - generator.threshold = threshold + if (!outputDirectory.exists()) { + if (!outputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create html output directory") + } + } - generator.effort = effort + if (outputSpotbugsFile != null && outputSpotbugsFile.exists()) { - generator.setSpotbugsResults(new XmlSlurper().parse(outputSpotbugsFile)) + if (skipEmptyReport && bugCount == 0) { + log.info("Skipping Generation Spotbugs HTML since there are not any bugs") + } else { + log.debug("Generating Spotbugs HTML") - generator.setOutputDirectory(new File(outputDirectory.getAbsolutePath())) + SpotbugsReportGenerator generator = new SpotbugsReportGenerator(getSink(), getBundle(locale), this.project.getBasedir(), siteTool) - generator.generateReport() + boolean isJxrPluginEnabled = isJxrPluginEnabled() - log.debug("xmlOutput is ${xmlOutput}") + generator.setIsJXRReportEnabled(isJxrPluginEnabled) + if (isJxrPluginEnabled) { + generator.setCompileSourceRoots(this.compileSourceRoots) + generator.setTestSourceRoots(this.testSourceRoots) + generator.setXrefLocation(this.xrefLocation) + generator.setXrefTestLocation(this.xrefTestLocation) + generator.setIncludeTests(this.includeTests) } + + generator.setLog(log) + generator.threshold = threshold + generator.effort = effort + generator.setSpotbugsResults(new XmlSlurper().parse(outputSpotbugsFile)) + generator.setOutputDirectory(new File(outputDirectory.getAbsolutePath())) + generator.generateReport() + log.debug("xmlOutput is ${xmlOutput}") } - } else { - log.info("cannot generate report"); } } From b201464a8f23014df3fc0e845f419356691cea3d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:49:25 -0400 Subject: [PATCH 0764/1013] [cleanup] Remove unused method to determine if we have source similar code is elsewhere if we needed such a thing. --- .../mojo/spotbugs/SpotBugsMojo.groovy | 22 ------------------- 1 file changed, 22 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 6fd15a535..134b90a1e 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1376,26 +1376,4 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { this.outputDirectory = reportOutputDirectory } - /** - * Collects the java sources from the source roots. - * - * @return A list containing the java sources or an empty list if no java sources are found. - * - */ - protected List getJavaSources(Locale locale) { - List sourceFiles = new ArrayList() - - if (classFilesDirectory.exists() && classFilesDirectory.isDirectory()) { - List files = FileUtils.getFiles(classFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null) - sourceFiles.addAll(files) - } - - if (testClassFilesDirectory.exists() && testClassFilesDirectory.isDirectory() && includeTests) { - List files = FileUtils.getFiles(testClassFilesDirectory, SpotBugsInfo.JAVA_REGEX_PATTERN, null) - sourceFiles.addAll(files) - } - - return sourceFiles - } - } From 6cca35b61805b9174b1776299bfe127c40a8cb95 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:56:29 -0400 Subject: [PATCH 0765/1013] [ci] Combine some if statements --- .../codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 134b90a1e..2be23dc03 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -737,10 +737,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { generateXDoc(locale) - if (!outputDirectory.exists()) { - if (!outputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create html output directory") - } + if (!outputDirectory.exists() && !outputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create html output directory") } if (outputSpotbugsFile != null && outputSpotbugsFile.exists()) { @@ -793,10 +791,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("Generating Spotbugs XML") - if (!spotbugsXmlOutputDirectory.exists()) { - if (!spotbugsXmlOutputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create xml output directory") - } + if (!spotbugsXmlOutputDirectory.exists() && !spotbugsXmlOutputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create xml output directory") } } @@ -810,10 +806,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { if (xmlOutput) { log.debug(" Using the xdoc format") - if (!xmlOutputDirectory.exists()) { - if (!xmlOutputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create xdoc output directory") - } + if (!xmlOutputDirectory.exists() && !xmlOutputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create xdoc output directory") } XDocsReporter xDocsReporter = new XDocsReporter(getBundle(locale), log, threshold, effort, outputEncoding) From 07f674846312a67b0f59f415b31f3be8d1bac311 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 17:56:46 -0400 Subject: [PATCH 0766/1013] [ci] Remove unused parameter --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 2be23dc03..09c2edf13 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -778,15 +778,15 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("****** SpotBugsMojo execute *******") if (!skip) { - Locale locale = Locale.getDefault() - executeCheck(locale) + executeCheck() if (canGenerateReport()) { + Locale locale = Locale.getDefault() generateXDoc(locale) } } } - private void executeCheck(Locale locale) { + private void executeCheck() { log.debug("****** SpotBugsMojo executeCheck *******") log.debug("Generating Spotbugs XML") From 0b23c6b6ada495dc9816652e1d11267324f025aa Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:00:10 -0400 Subject: [PATCH 0767/1013] [ci] Adjustments on locale usage --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 2 -- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 62228b95a..242efd672 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -478,8 +478,6 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { @Override void execute() { - Locale locale = Locale.getDefault() - log.debug("Executing spotbugs:check") if (!skip && doSourceFilesExist()) { diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 09c2edf13..ed89af40f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -711,7 +711,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * * Callback from Maven Site Plugin. * - * @param locale he wanted locale to generate the report, could be null. + * @param locale the wanted locale to generate the report, could be null. * * @see org.apache.maven.reporting.MavenReport #executeReport(java.util.Locale) */ @@ -719,7 +719,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { void executeReport(Locale locale) { log.debug("****** SpotBugsMojo executeReport *******") - executeCheck(locale) + executeCheck() if (skip || !canGenerateReport()) { log.info("cannot generate report") From 9e50fbad84cb14ae66f33e1c0f145a2fc80994d5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:03:36 -0400 Subject: [PATCH 0768/1013] [ci] Fix javadoc --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index ed89af40f..856375b59 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1115,8 +1115,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Set up and run the Spotbugs engine. * - * @param locale - * the locale the report should be generated for + * @param outputFile + * the outputFile * */ private void executeSpotbugs(File outputFile) { From 73bdd4f0b885cfa9c441256e1394adea611d766b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:11:33 -0400 Subject: [PATCH 0769/1013] [cleanup] Removed unused flag, don't double init jxr report, remove extra spaces javadoc a bit more and add note on one field not used by located elsewhere. --- .../spotbugs/SpotbugsReportGenerator.groovy | 58 ++++--------------- 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index ed530967f..46b5d96ca 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -35,85 +35,71 @@ class SpotbugsReportGenerator implements SpotBugsInfo { /** * The key to get the value if the line number is not available. - * */ static final String NOLINE_KEY = "report.spotbugs.noline" /** * The key to get the column title for the line. - * */ static final String COLUMN_LINE_KEY = "report.spotbugs.column.line" /** * The key to get the column title for the bug. - * */ static final String COLUMN_BUG_KEY = "report.spotbugs.column.bug" /** * The key to get the column title for the bugs. - * */ static final String COLUMN_BUGS_KEY = "report.spotbugs.column.bugs" /** * The key to get the column title for the category. - * */ static final String COLUMN_CATEGORY_KEY = "report.spotbugs.column.category" /** * The key to get the column title for the priority. - * */ static final String COLUMN_PRIORITY_KEY = "report.spotbugs.column.priority" /** * The key to get the column title for the details. - * */ static final String COLUMN_DETAILS_KEY = "report.spotbugs.column.details" /** * The key to get the report title of the Plug-In from the bundle. - * */ static final String REPORT_TITLE_KEY = "report.spotbugs.reporttitle" /** * The key to get the report link title of the Plug-In from the bundle. - * */ static final String LINKTITLE_KEY = "report.spotbugs.linktitle" /** * The key to get the report link of the Plug-In from the bundle. - * */ static final String LINK_KEY = "report.spotbugs.link" /** * The key to get the files title of the Plug-In from the bundle. - * */ static final String FILES_KEY = "report.spotbugs.files" /** * The key to get the threshold of the report from the bundle. - * */ static final String THRESHOLD_KEY = "report.spotbugs.threshold" /** * The key to get the effort of the report from the bundle. - * */ static final String EFFORT_KEY = "report.spotbugs.effort" /** * The key to get the link to SpotBugs description page from the bundle. - * */ static final String DETAILSLINK_KEY = "report.spotbugs.detailslink" @@ -125,164 +111,144 @@ class SpotbugsReportGenerator implements SpotBugsInfo { /** * The key to get the files title of the Plug-In from the bundle. - * */ static final String SUMMARY_KEY = "report.spotbugs.summary" /** * The key to column title for the Class. - * */ static final String COLUMN_CLASS_KEY = "report.spotbugs.column.class" /** * The key to column title for the Classes. - * */ static final String COLUMN_CLASSES_KEY = "report.spotbugs.column.classes" /** * The key to column title for the errors. - * */ static final String COLUMN_ERRORS_KEY = "report.spotbugs.column.errors" /** * The key to column title for the files. * + * note: not used but throughout properties */ static final String COLUMN_FILES_KEY = "report.spotbugs.column.files" /** * The key to column title for the files. - * */ static final String COLUMN_MISSINGCLASSES_KEY = "report.spotbugs.column.missingclasses" /** * The sink to write the report to. - * */ Sink sink /** * The bundle to get the messages from. - * */ ResourceBundle bundle /** * The logger to write logs to. - * */ Log log /** * The threshold of bugs severity. - * */ String threshold /** * The used effort for searching bugs. - * */ String effort /** * The name of the current class which is analysed by SpotBugs. - * */ String currentClassName - /** - * Signals if the report for the current class is opened. - * - */ - boolean mIsCurrentClassReportOpened = false - /** * Signals if the jxr report plugin is enabled. - * */ - boolean isJXRReportEnabled = false + boolean isJXRReportEnabled /** * The running total of bugs reported. - * */ int bugCount /** * The running total of missing classes reported. - * */ int missingClassCount /** * The running total of files analyzed. - * */ int fileCount /** * The Set of missing classes names reported. - * */ Set missingClassSet = new HashSet() /** * The running total of errors reported. - * */ int errorCount /** * Location where generated html will be created. - * */ File outputDirectory /** * Location of the Xrefs to link to. - * */ File xrefLocation /** * Location of the Test Xrefs to link to. - * */ File xrefTestLocation /** * The directories containing the sources to be compiled. - * */ List compileSourceRoots /** * The directories containing the test-sources to be compiled. - * */ List testSourceRoots /** * Run Spotbugs on the tests. - * */ boolean includeTests /** - * "org.apache.maven.doxia.tools.SiteTool" - * + * Doxia site tool. */ SiteTool siteTool + /** + * Base directory. + */ File basedir + /** + * Spotbugs results. + */ GPathResult spotbugsResults + /** + * Bug classes. + */ List bugClasses /** From 624f2c28819f263b4a9a9aa83d42b70cea251f9a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:20:24 -0400 Subject: [PATCH 0770/1013] [ci] Javadocs and comments --- .../codehaus/mojo/spotbugs/CheckMojo.groovy | 1 + .../codehaus/mojo/spotbugs/VerifyMojo.groovy | 1 + .../mojo/spotbugs/XDocsReporter.groovy | 25 +++++++++++-------- 3 files changed, 17 insertions(+), 10 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy index f37c9e49b..bf73f20ae 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/CheckMojo.groovy @@ -34,4 +34,5 @@ import org.apache.maven.plugins.annotations.ResolutionScope @Mojo( name = "check", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) @Execute( goal = "spotbugs") class CheckMojo extends BaseViolationCheckMojo { + // Check Mojo to run spotbugs execution } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy index 5cde89d15..9b8bb966f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy @@ -34,4 +34,5 @@ import org.apache.maven.plugins.annotations.ResolutionScope */ @Mojo( name = "verify", defaultPhase = LifecyclePhase.VERIFY, requiresDependencyResolution = ResolutionScope.TEST, requiresProject = true, threadSafe = true) class VerifyMojo extends BaseViolationCheckMojo { + // Verification Mojo to verify existing bugs rather than run spotbugs } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index e2c35a990..2eebf5ec3 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -31,58 +31,64 @@ class XDocsReporter { /** * The key to get the value if the line number is not available. - * */ static final String NOLINE_KEY = "report.spotbugs.noline" /** * The bundle to get the messages from. - * */ ResourceBundle bundle /** * The logger to write logs to. - * */ Log log /** * The threshold of bugs severity. - * */ String threshold /** * The used effort for searching bugs. - * */ String effort /** * The output Writer stream. - * */ Writer outputWriter + /** + * Spotbugs Results. + */ GPathResult spotbugsResults + /** + * Bug Classes. + */ List bugClasses /** * The directories containing the sources to be compiled. - * */ List compileSourceRoots + /** + * The directories containing the test sources to be compiled. + */ List testSourceRoots + /** + * The output encoding. + */ String outputEncoding /** * Default constructor. * - * @param bundle - The Resource Bundle to use + * @param bundle + * The Resource Bundle to use */ XDocsReporter(ResourceBundle bundle, Log log, String threshold, String effort, String outputEncoding) { assert bundle @@ -111,7 +117,6 @@ class XDocsReporter { * @param thresholdValue * The ThresholdValue integer to evaluate. * @return The string valueof the Threshold object. - * */ protected String evaluateThresholdParameter(String thresholdValue) { String thresholdName @@ -143,7 +148,6 @@ class XDocsReporter { * Gets the Spotbugs Version of the report. * * @return The Spotbugs Version used on the report. - * */ protected String getSpotBugsVersion() { return edu.umd.cs.findbugs.Version.VERSION_STRING @@ -234,4 +238,5 @@ class XDocsReporter { outputWriter.flush() outputWriter.close() } + } From bf8ee2d1bee08d0a51c65b677d779d2c94cc7cd1 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:20:49 -0400 Subject: [PATCH 0771/1013] [ci] Cleanup unnecessarily long if --- .../spotbugs/BaseViolationCheckMojo.groovy | 96 +++++++++---------- 1 file changed, 47 insertions(+), 49 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 242efd672..fa2cc46a9 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -480,70 +480,68 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { void execute() { log.debug("Executing spotbugs:check") - if (!skip && doSourceFilesExist()) { - - // this goes + if (skip || !doSourceFilesExist()) { + log.debug("Nothing for SpotBugs to do here.") + return + } - log.debug("Here goes...............Executing spotbugs:check") + log.debug("Here goes...............Executing spotbugs:check") - if (!spotbugsXmlOutputDirectory.exists()) { - if (!spotbugsXmlOutputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create xml output directory") - } + if (!spotbugsXmlOutputDirectory.exists()) { + if (!spotbugsXmlOutputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create xml output directory") } + } - File outputFile = new File("${spotbugsXmlOutputDirectory}/${spotbugsXmlOutputFilename}") + File outputFile = new File("${spotbugsXmlOutputDirectory}/${spotbugsXmlOutputFilename}") - if (outputFile.exists()) { + if (outputFile.exists()) { - def xml = new XmlParser().parse(outputFile) + def xml = new XmlParser().parse(outputFile) - def bugs = xml.BugInstance - def bugCount = bugs.size() - log.info("BugInstance size is ${bugCount}") + def bugs = xml.BugInstance + def bugCount = bugs.size() + log.info("BugInstance size is ${bugCount}") - def errorCount = xml.Error.size() - log.info("Error size is ${errorCount}") + def errorCount = xml.Error.size() + log.info("Error size is ${errorCount}") - if (bugCount <= 0) { - log.info('No errors/warnings found') - return - } else if (maxAllowedViolations > 0 && bugCount <= maxAllowedViolations) { - log.info("total ${bugCount} violations are found which is set to be acceptable using configured property maxAllowedViolations :"+maxAllowedViolations +".\nBelow are list of bugs ignored :\n") - printBugs(bugCount, bugs) - return; - } + if (bugCount <= 0) { + log.info('No errors/warnings found') + return + } else if (maxAllowedViolations > 0 && bugCount <= maxAllowedViolations) { + log.info("total ${bugCount} violations are found which is set to be acceptable using configured property maxAllowedViolations :"+maxAllowedViolations +".\nBelow are list of bugs ignored :\n") + printBugs(bugCount, bugs) + return; + } - log.info('Total bugs: ' + bugCount) - def bugCountAboveThreshold = 0 - def priorityThresholdNum = failThreshold ? SpotBugsInfo.spotbugsPriority.indexOf(failThreshold) : Integer.MAX_VALUE - if (priorityThresholdNum == -1) { - throw new MojoExecutionException("Invalid value for failThreshold: ${failThreshold}") - } + log.info('Total bugs: ' + bugCount) + def bugCountAboveThreshold = 0 + def priorityThresholdNum = failThreshold ? SpotBugsInfo.spotbugsPriority.indexOf(failThreshold) : Integer.MAX_VALUE + if (priorityThresholdNum == -1) { + throw new MojoExecutionException("Invalid value for failThreshold: ${failThreshold}") + } - for (i in 0..bugCount-1) { - def bug = bugs[i] - def priorityNum = bug.'@priority' as Integer - def priorityName = SpotBugsInfo.spotbugsPriority[priorityNum] - def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + - bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' - - if (priorityNum <= priorityThresholdNum) { // lower is more severe - bugCountAboveThreshold += 1 - log.error(logMsg) - } else { - log.info(logMsg) - } + for (i in 0..bugCount-1) { + def bug = bugs[i] + def priorityNum = bug.'@priority' as Integer + def priorityName = SpotBugsInfo.spotbugsPriority[priorityNum] + def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' + + if (priorityNum <= priorityThresholdNum) { // lower is more severe + bugCountAboveThreshold += 1 + log.error(logMsg) + } else { + log.info(logMsg) } + } - log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n') + log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n') - if ( (bugCountAboveThreshold || errorCount) && failOnError ) { - throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ") - } + if ( (bugCountAboveThreshold || errorCount) && failOnError ) { + throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ") } - } else { - log.debug("Nothing for SpotBugs to do here.") } } From 118a32e687df007c382ddd4d3ef3610949eb26fb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:21:59 -0400 Subject: [PATCH 0772/1013] [ci] Combine if statements --- .../codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index fa2cc46a9..5b8a5c414 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -487,10 +487,8 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { log.debug("Here goes...............Executing spotbugs:check") - if (!spotbugsXmlOutputDirectory.exists()) { - if (!spotbugsXmlOutputDirectory.mkdirs()) { - throw new MojoExecutionException("Cannot create xml output directory") - } + if (!spotbugsXmlOutputDirectory.exists() && !spotbugsXmlOutputDirectory.mkdirs()) { + throw new MojoExecutionException("Cannot create xml output directory") } File outputFile = new File("${spotbugsXmlOutputDirectory}/${spotbugsXmlOutputFilename}") From 2a348437000bfa3d425f3fb92dbb196eb4f6fecc Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:32:40 -0400 Subject: [PATCH 0773/1013] [ci] Formatting --- .../mojo/spotbugs/SourceFileIndexer.groovy | 17 ++++++++++------- .../codehaus/mojo/spotbugs/SpotBugsGui.groovy | 12 ++++++------ 2 files changed, 16 insertions(+), 13 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy index 3a4af3939..7892c66c0 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -48,22 +48,25 @@ class SourceFileIndexer { String basePath = normalizePath(session.getExecutionRootDirectory()) def allSourceFiles = new ArrayList<>() - //Resource - for(Resource r in project.getResources()) { + + // Resource + for (Resource r in project.getResources()) { scanDirectory(new File(r.directory), allSourceFiles, basePath) } - for(Resource r in project.getTestResources()) { + + for (Resource r in project.getTestResources()) { scanDirectory(new File(r.directory), allSourceFiles, basePath) } - //Source files - for(String sourceRoot in project.getCompileSourceRoots()) { + + // Source files + for (String sourceRoot in project.getCompileSourceRoots()) { scanDirectory(new File(sourceRoot), allSourceFiles, basePath) } - for(String sourceRoot in project.getTestCompileSourceRoots()) { + for (String sourceRoot in project.getTestCompileSourceRoots()) { scanDirectory(new File(sourceRoot), allSourceFiles, basePath) } - for(String sourceRoot in project.getScriptSourceRoots()) { + for (String sourceRoot in project.getScriptSourceRoots()) { scanDirectory(new File(sourceRoot), allSourceFiles, basePath) } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy index 936909be0..cd1d65194 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy @@ -201,12 +201,13 @@ class SpotBugsGui extends AbstractMojo implements SpotBugsPluginsTrait { ant.project.setProperty('basedir', spotbugsXmlOutputDirectory.getAbsolutePath()) ant.project.setProperty('verbose', "true") - ant.java(classname: "edu.umd.cs.findbugs.LaunchAppropriateUI", fork: "true", failonerror: "true", clonevm: "true", maxmemory: "${maxHeap}m") - { + ant.java(classname: "edu.umd.cs.findbugs.LaunchAppropriateUI", fork: "true", failonerror: "true", clonevm: "true", maxmemory: "${maxHeap}m") { def effectiveEncoding = System.getProperty( "file.encoding", "UTF-8" ) - if ( encoding ) { effectiveEncoding = encoding } + if ( encoding ) { + effectiveEncoding = encoding + } log.info("File Encoding is " + effectiveEncoding) @@ -237,10 +238,9 @@ class SpotBugsGui extends AbstractMojo implements SpotBugsPluginsTrait { arg(value: spotbugsXml) } - classpath() - { + classpath() { - pluginArtifacts.each() {pluginArtifact -> + pluginArtifacts.each() { pluginArtifact -> if ( debug ) { log.debug(" Trying to Add to pluginArtifact ->" + pluginArtifact.file.toString()) } From d3587b830ea2e3fac5aff67bf57797f3342cea5d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:35:01 -0400 Subject: [PATCH 0774/1013] [ci] More formatting --- .../org/codehaus/mojo/spotbugs/XDocsReporter.groovy | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 2eebf5ec3..341a587fb 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -175,7 +175,7 @@ class XDocsReporter { log.debug("classStatsValue is ${classStatsValue}") log.debug("classStatsBugCount is ${classStatsBugCount}") - if ( Integer.parseInt(classStatsBugCount) > 0 ) { + if (Integer.parseInt(classStatsBugCount) > 0) { bugClasses << classStatsValue } } @@ -185,7 +185,7 @@ class XDocsReporter { file(classname: bugClass) { spotbugsResults.BugInstance.each() {bugInstance -> - if ( bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass ) { + if (bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass) { def type = bugInstance.@type.text() def category = bugInstance.@category.text() @@ -218,14 +218,14 @@ class XDocsReporter { log.debug("Printing Source Roots") if ( !compileSourceRoots.isEmpty() ) { - compileSourceRoots.each() {srcDir -> + compileSourceRoots.each() { srcDir -> log.debug("SrcDir is ${srcDir}") SrcDir(srcDir) } } if (!testSourceRoots.isEmpty()) { - testSourceRoots.each() {srcDir -> + testSourceRoots.each() { srcDir -> log.debug("SrcDir is ${srcDir}") SrcDir(srcDir) } From 40960240e3ca082c53be40168001b31efb9df7df Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:42:17 -0400 Subject: [PATCH 0775/1013] [ci] Continued formatting --- .../spotbugs/SpotbugsReportGenerator.groovy | 35 +++++++++---------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 46b5d96ca..d62ef8dad 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -292,7 +292,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("Finished searching for bugs!...") log.debug("sink is " + sink) - bugClasses.each() {bugClass -> + bugClasses.each() { bugClass -> log.debug("finish bugClass is ${bugClass}") printBug(bugClass) @@ -367,12 +367,11 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("printBug spotbugsResults is ${spotbugsResults}") - spotbugsResults.BugInstance.each() {bugInstance -> - + spotbugsResults.BugInstance.each() { bugInstance -> log.debug("bugInstance ---> ${bugInstance}") - if ( bugInstance.Class[0].@classname.text() == bugClass ) { + if (bugInstance.Class[0].@classname.text() == bugClass) { def type = bugInstance.@type.text() def category = bugInstance.@category.text() @@ -403,7 +402,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { // line sink.tableCell() - if ( isJXRReportEnabled ) { + if (isJXRReportEnabled) { log.debug("isJXRReportEnabled is enabled") sink.rawText(assembleJxrHyperlink(line)) } else { @@ -447,8 +446,8 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("xrefLocation is " + xrefLocation.getAbsolutePath()) log.debug("xrefTestLocation is " + xrefTestLocation.getAbsolutePath()) - compileSourceRoots.each {compileSourceRoot -> - if ( new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { + compileSourceRoots.each { compileSourceRoot -> + if (new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists()) { prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD @@ -456,9 +455,9 @@ class SpotbugsReportGenerator implements SpotBugsInfo { } } - if ( includeTests && !prefix ) { - testSourceRoots.each {testSourceRoot -> - if ( new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists() ) { + if (includeTests && !prefix) { + testSourceRoots.each { testSourceRoot -> + if (new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists()) { prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD @@ -470,7 +469,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { def path = prefix + line.@classname.text().replaceAll("[.]", "/").replaceAll("[\$].*", "") String lineNumber = valueForLine(line) - if ( lineNumber != bundle.getString(NOLINE_KEY) ) { + if (lineNumber != bundle.getString(NOLINE_KEY)) { hyperlink = "" + lineNumber + "" } else { hyperlink = lineNumber @@ -626,7 +625,6 @@ class SpotbugsReportGenerator implements SpotBugsInfo { /** * Class Summary */ - sink.table() sink.tableRow() @@ -642,12 +640,12 @@ class SpotbugsReportGenerator implements SpotBugsInfo { sink.tableRow_() - spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() {classStats -> + spotbugsResults.FindBugsSummary.PackageStats.ClassStats.each() { classStats -> def classStatsValue = classStats.'@class'.text() def classStatsBugCount = classStats.'@bugs'.text() - if ( Integer.parseInt(classStatsBugCount) > 0 ) { + if (Integer.parseInt(classStatsBugCount) > 0) { sink.tableRow() // class name @@ -702,16 +700,15 @@ class SpotbugsReportGenerator implements SpotBugsInfo { * @return The line number the bug appears or a statement that there is no source line available. * */ - protected String valueForLine(GPathResult line) - { + protected String valueForLine(GPathResult line) { String value - if ( line ) { + if (line) { def startLine = line.@start.text() def endLine = line.@end.text() - if ( startLine == endLine ) { - if ( startLine ) { + if (startLine == endLine) { + if (startLine) { value = startLine } else { value = bundle.getString(NOLINE_KEY) From c6225c57fdeb1e98fb3d8c9f0b5b194cecc12408 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 18:58:14 -0400 Subject: [PATCH 0776/1013] [ci] More minor cleanup --- .../mojo/spotbugs/SourceFileIndexer.groovy | 3 ++- .../org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 14 +++++--------- .../mojo/spotbugs/SpotBugsPluginsTrait.groovy | 4 ++-- .../codehaus/mojo/spotbugs/XDocsReporter.groovy | 4 ++-- 4 files changed, 11 insertions(+), 14 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy index 7892c66c0..06468c29e 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SourceFileIndexer.groovy @@ -143,7 +143,8 @@ class SourceFileIndexer { } - return null // Not found + // Not found + return null } } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 856375b59..322dde360 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -863,15 +863,14 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { * */ protected boolean isJxrPluginEnabled() { - boolean isEnabled - if (xrefLocation.exists()) { - isEnabled = true - return isEnabled + return true } List reportPlugins = getProject().getReportPlugins() + boolean isEnabled + reportPlugins.each() { reportPlugin -> log.debug("report plugin -> ${reportPlugin.getArtifactId()}") @@ -1072,11 +1071,9 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { def auxClasspath = "" if (auxClasspathElements) { - log.debug(" AuxClasspath Elements ->" + auxClasspathElements) def auxClasspathList = auxClasspathElements.findAll { project.build.outputDirectory != it.toString() } - if (auxClasspathList.size() > 0) { auxClasspath += File.pathSeparator @@ -1084,9 +1081,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug(" Last AuxClasspath is ->" + auxClasspathList[auxClasspathList.size() - 1]) auxClasspathList.each() { auxClasspathElement -> - log.debug(" Adding to AuxClasspath ->" + auxClasspathElement.toString()) - auxClasspath += auxClasspathElement.toString() + File.pathSeparator } } @@ -1243,7 +1238,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } } - path.SpotbugsResults.FindBugsSummary.'total_bugs' = bugCount // Fixes visitor problem + // Fixes visitor problem + path.SpotbugsResults.FindBugsSummary.'total_bugs' = bugCount xmlProject.appendNode { WrkDir(project.build.directory) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy index 449d41631..3b6da14a9 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsPluginsTrait.groovy @@ -80,8 +80,8 @@ trait SpotBugsPluginsTrait { log.debug(" Processing Plugin: " + pluginFileName.toString()) urlPlugins += resourceHelper.getResourceFile(pluginFileName.toString()).absolutePath + ((pluginJar == pluginJars[pluginJars.size() - 1]) ? "" : File.pathSeparator) - } catch (MalformedURLException exception) { - throw new MojoExecutionException("The addin plugin has an invalid URL") + } catch (MalformedURLException e) { + throw new MojoExecutionException("The addin plugin has an invalid URL", e) } } } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index 341a587fb..d0ddb0489 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -180,10 +180,10 @@ class XDocsReporter { } } - bugClasses.each() {bugClass -> + bugClasses.each() { bugClass -> log.debug("finish bugClass is ${bugClass}") file(classname: bugClass) { - spotbugsResults.BugInstance.each() {bugInstance -> + spotbugsResults.BugInstance.each() { bugInstance -> if (bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass) { From ee4bf8dcfb791d73ce43e566c92062252e1fc98a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 19:08:06 -0400 Subject: [PATCH 0777/1013] [ci] Unbury logic inside closure --- .../spotbugs/SpotbugsReportGenerator.groovy | 32 ++++++++++--------- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index d62ef8dad..a96d97488 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -645,25 +645,27 @@ class SpotbugsReportGenerator implements SpotBugsInfo { def classStatsValue = classStats.'@class'.text() def classStatsBugCount = classStats.'@bugs'.text() - if (Integer.parseInt(classStatsBugCount) > 0) { - sink.tableRow() + if (Integer.parseInt(classStatsBugCount) == 0) { + return + } - // class name - sink.tableCell() - sink.link("#" + classStatsValue) - sink.text(classStatsValue) - sink.link_() - sink.tableCell_() + sink.tableRow() - // class bug total count - sink.tableCell() - sink.text(classStatsBugCount) - sink.tableCell_() + // class name + sink.tableCell() + sink.link("#" + classStatsValue) + sink.text(classStatsValue) + sink.link_() + sink.tableCell_() - sink.tableRow_() + // class bug total count + sink.tableCell() + sink.text(classStatsBugCount) + sink.tableCell_() - bugClasses << classStatsValue - } + sink.tableRow_() + + bugClasses << classStatsValue } sink.table_() From 9c2ce682bf97de224c1327c82127ef0f7eeadbf2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 19:09:41 -0400 Subject: [PATCH 0778/1013] [ci] Unbury logic in closure --- .../spotbugs/SpotbugsReportGenerator.groovy | 87 ++++++++++--------- 1 file changed, 44 insertions(+), 43 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index a96d97488..3f6533e7b 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -371,53 +371,54 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("bugInstance ---> ${bugInstance}") - if (bugInstance.Class[0].@classname.text() == bugClass) { - - def type = bugInstance.@type.text() - def category = bugInstance.@category.text() - def message = bugInstance.LongMessage.text() - def priority = bugInstance.@priority.text() - def line = bugInstance.SourceLine[0] - log.debug("BugInstance message is ${message}") - - sink.tableRow() - - // bug - sink.tableCell() - sink.text(message) - sink.tableCell_() - - // category - sink.tableCell() - sink.text(category) - sink.tableCell_() - - // description link - sink.tableCell() - sink.link(bundle.getString(DETAILSLINK_KEY) + "#" + type) - sink.text(type) - sink.link_() - sink.tableCell_() - - // line - sink.tableCell() - - if (isJXRReportEnabled) { - log.debug("isJXRReportEnabled is enabled") - sink.rawText(assembleJxrHyperlink(line)) - } else { - sink.text(line.@start.text()) - } + if (bugInstance.Class[0].@classname.text() != bugClass) { + return + } - sink.tableCell_() + def type = bugInstance.@type.text() + def category = bugInstance.@category.text() + def message = bugInstance.LongMessage.text() + def priority = bugInstance.@priority.text() + def line = bugInstance.SourceLine[0] + log.debug("BugInstance message is ${message}") - // priority - sink.tableCell() - sink.text(spotbugsPriority[priority as Integer]) - sink.tableCell_() + sink.tableRow() - sink.tableRow_() + // bug + sink.tableCell() + sink.text(message) + sink.tableCell_() + + // category + sink.tableCell() + sink.text(category) + sink.tableCell_() + + // description link + sink.tableCell() + sink.link(bundle.getString(DETAILSLINK_KEY) + "#" + type) + sink.text(type) + sink.link_() + sink.tableCell_() + + // line + sink.tableCell() + + if (isJXRReportEnabled) { + log.debug("isJXRReportEnabled is enabled") + sink.rawText(assembleJxrHyperlink(line)) + } else { + sink.text(line.@start.text()) } + + sink.tableCell_() + + // priority + sink.tableCell() + sink.text(spotbugsPriority[priority as Integer]) + sink.tableCell_() + + sink.tableRow_() } sink.table_() From e16709bea0e58998beb7f08c54b5c4d76d2a1c9e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 19:33:18 -0400 Subject: [PATCH 0779/1013] [ci] Unbury more logic inside closures --- .../spotbugs/SpotbugsReportGenerator.groovy | 14 ++++++-------- .../mojo/spotbugs/XDocsReporter.groovy | 19 ++++++++++--------- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 3f6533e7b..1c92a47f7 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -448,22 +448,20 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("xrefTestLocation is " + xrefTestLocation.getAbsolutePath()) compileSourceRoots.each { compileSourceRoot -> - if (new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists()) { - prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) - - prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD + if (!new File(compileSourceRoot + File.separator + line.@sourcepath.text()).exists()) { return } + prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefLocation.getAbsolutePath()) + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD } if (includeTests && !prefix) { testSourceRoots.each { testSourceRoot -> - if (new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists()) { - prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) - - prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD + if (!new File(testSourceRoot + File.separator + line.@sourcepath.text()).exists()) { return } + prefix = PathTool.getRelativePath(outputDirectory.getAbsolutePath(), xrefTestLocation.getAbsolutePath()) + prefix = prefix ? prefix + SpotBugsInfo.URL_SEPARATOR + xrefTestLocation.getName() + SpotBugsInfo.URL_SEPARATOR : SpotBugsInfo.PERIOD } } diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy index d0ddb0489..d6829c34a 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/XDocsReporter.groovy @@ -185,17 +185,18 @@ class XDocsReporter { file(classname: bugClass) { spotbugsResults.BugInstance.each() { bugInstance -> - if (bugInstance.Class.find{ it.@primary == "true" }.@classname.text() == bugClass) { + if (bugInstance.Class.find{ it.@primary == "true" }.@classname.text() != bugClass) { + return + } - def type = bugInstance.@type.text() - def category = bugInstance.@category.text() - def message = bugInstance.LongMessage.text() - def priority = evaluateThresholdParameter(bugInstance.@priority.text()) - def line = bugInstance.SourceLine.@start[0].text() - log.debug("BugInstance message is ${message}") + def type = bugInstance.@type.text() + def category = bugInstance.@category.text() + def message = bugInstance.LongMessage.text() + def priority = evaluateThresholdParameter(bugInstance.@priority.text()) + def line = bugInstance.SourceLine.@start[0].text() + log.debug("BugInstance message is ${message}") - BugInstance(type: type, priority: priority, category: category, message: message, lineNumber: ((line) ? line: "-1")) - } + BugInstance(type: type, priority: priority, category: category, message: message, lineNumber: ((line) ? line: "-1")) } } } From fd3d9d07106bb3cc5755516d74c0a253633500a4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:01:56 -0400 Subject: [PATCH 0780/1013] [spotbugs] Add exclusion filter for items to avoid notice on --- pom.xml | 3 +++ src/main/tools/spotbugs-exclude-filters.xml | 19 +++++++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 src/main/tools/spotbugs-exclude-filters.xml diff --git a/pom.xml b/pom.xml index e1c2c3dcb..1a5d72015 100644 --- a/pom.xml +++ b/pom.xml @@ -746,6 +746,9 @@ com.github.spotbugs spotbugs-maven-plugin ${project.version} + + ${project.basedir}/src/main/tools/spotbugs-exclude-filters.xml + org.apache.maven.plugins diff --git a/src/main/tools/spotbugs-exclude-filters.xml b/src/main/tools/spotbugs-exclude-filters.xml new file mode 100644 index 000000000..175f581de --- /dev/null +++ b/src/main/tools/spotbugs-exclude-filters.xml @@ -0,0 +1,19 @@ + + + + + + + + + + + + + + + + + + + From 0defbc7845172fe4f30855c05c74ee86c2812b82 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:17:35 -0400 Subject: [PATCH 0781/1013] [spotbugs] Exclude xxe detection from java as only file with that is maven help mojo --- src/main/tools/spotbugs-exclude-filters.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/tools/spotbugs-exclude-filters.xml b/src/main/tools/spotbugs-exclude-filters.xml index 175f581de..51ab9dd8a 100644 --- a/src/main/tools/spotbugs-exclude-filters.xml +++ b/src/main/tools/spotbugs-exclude-filters.xml @@ -16,4 +16,9 @@ + + + + + From 6a568fae4c111a438e6701c7cf44029e986c9c5d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:25:27 -0400 Subject: [PATCH 0782/1013] [pom] Clarifications in pom --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 1a5d72015..0fcb65d67 100644 --- a/pom.xml +++ b/pom.xml @@ -613,7 +613,7 @@ - + org.apache.maven.plugins maven-pdf-plugin @@ -636,7 +636,7 @@ descriptor - + help-goal From b6598f595fed051e2822a4f1ec96c70be486c0c4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:07:51 -0400 Subject: [PATCH 0783/1013] [spotbugs] Add some comments and another item to ignore --- src/main/tools/spotbugs-exclude-filters.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/main/tools/spotbugs-exclude-filters.xml b/src/main/tools/spotbugs-exclude-filters.xml index 51ab9dd8a..26405f8d7 100644 --- a/src/main/tools/spotbugs-exclude-filters.xml +++ b/src/main/tools/spotbugs-exclude-filters.xml @@ -1,17 +1,26 @@ + + + + + + + + + From 8cd30104ddb5fb89b5352e34f05a89ae18443657 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:07:18 -0400 Subject: [PATCH 0784/1013] [ci] Use proper boolean setting --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 322dde360..f79ac78c6 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -1182,7 +1182,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } if (debug || trace) { - sysproperty(key: "findbugs.debug", value: true) + sysproperty(key: "findbugs.debug", value: Boolean.TRUE) } classpath() { From 9899b4cb9573cb26a0cda53fa3df2869fdd97f11 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 20:15:51 -0400 Subject: [PATCH 0785/1013] [todo] Remove todo around javaparser as now at project level --- TODO.md | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 TODO.md diff --git a/TODO.md b/TODO.md deleted file mode 100644 index c137938cc..000000000 --- a/TODO.md +++ /dev/null @@ -1,3 +0,0 @@ -issue ------ -- maven release plugin site is failing with gmavenplus groovydoc regarding missing javaparser class. Tried adding that both at gmavenplus and at site plugin, neither worked. It is at site plugin currently. Running site on its own runs this same step without issue. From 2e93666174158b15e7b1cef259877f0c75cedc11 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 21:12:34 -0400 Subject: [PATCH 0786/1013] [site] Bump fluido to 1.11.1 and add missing xml encoding --- src/site/site.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/site/site.xml b/src/site/site.xml index 2080b3e4a..cfc665842 100644 --- a/src/site/site.xml +++ b/src/site/site.xml @@ -1,4 +1,4 @@ - + @@ -10,7 +10,7 @@ org.apache.maven.skins maven-fluido-skin - 1.10.0 + 1.11.1 From 2737f05732cf4a7f907c179e2f6381c41833ce62 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 21:36:57 -0400 Subject: [PATCH 0787/1013] [pom] Add automatic module name to reflect this project not parent --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index 0fcb65d67..051e4a6f8 100644 --- a/pom.xml +++ b/pom.xml @@ -223,6 +223,9 @@ 2.11.0 2.6 3.12.0 + + + com.github.spotbugs.maven From b9ac9c6db35d4b3f7931d967de6ca34044ded8f3 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 23:20:45 -0400 Subject: [PATCH 0788/1013] [ci] Formatting --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index 5b8a5c414..d78034a82 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -537,7 +537,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n') - if ( (bugCountAboveThreshold || errorCount) && failOnError ) { + if ((bugCountAboveThreshold || errorCount) && failOnError) { throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ") } } From 50bc8c9391e7c5fc79743353349138790924a12d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 23:30:00 -0400 Subject: [PATCH 0789/1013] [ci] Move comment above line --- .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy index d78034a82..a9c580790 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy @@ -527,7 +527,8 @@ abstract class BaseViolationCheckMojo extends AbstractMojo { def logMsg = priorityName + ': ' + bug.LongMessage.text() + SpotBugsInfo.BLANK + bug.SourceLine.'@classname' + SpotBugsInfo.BLANK + bug.SourceLine.Message.text() + SpotBugsInfo.BLANK + bug.'@type' - if (priorityNum <= priorityThresholdNum) { // lower is more severe + // lower is more severe + if (priorityNum <= priorityThresholdNum) { bugCountAboveThreshold += 1 log.error(logMsg) } else { From 9c3774427f077714bd0196d222025fee929e756d Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 23 Jul 2022 23:32:39 -0400 Subject: [PATCH 0790/1013] [pom] Update comment on gmavenplus about 1.8 vs 8 as fixed in future release --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 051e4a6f8..7ff9f2cd2 100644 --- a/pom.xml +++ b/pom.xml @@ -149,7 +149,7 @@ 4.7.1 - + 1.8 5.9.0-RC1 From c811a57edb2b31cb040778f0db2b2c6a1cae7bb3 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 24 Jul 2022 00:07:00 -0400 Subject: [PATCH 0791/1013] [maven] Add java.base/java.io all unnamed add opens so site works with jdk 17 --- .mvn/jvm.config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/jvm.config b/.mvn/jvm.config index fbc2b50e9..24563d099 100644 --- a/.mvn/jvm.config +++ b/.mvn/jvm.config @@ -1 +1 @@ --XX:+TieredCompilation -XX:TieredStopAtLevel=1 +-XX:+TieredCompilation -XX:TieredStopAtLevel=1 --add-opens=java.base/java.io=ALL-UNNAMED From cf3dbf89ceff70656f1b2c1629d718e687952735 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 24 Jul 2022 00:09:09 -0400 Subject: [PATCH 0792/1013] [github] Move more builds to jdk 17 --- .github/workflows/coveralls.yaml | 2 +- .github/workflows/coverity.yaml | 2 +- .github/workflows/it.yaml | 2 +- .github/workflows/site.yaml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 92c5c5ecb..038e5ebeb 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -27,7 +27,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Report Coverage to Coveralls for Pull Requests if: github.event_name == 'pull_request' diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml index 87f593ee5..c7cfd0d8b 100644 --- a/.github/workflows/coverity.yaml +++ b/.github/workflows/coverity.yaml @@ -14,7 +14,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Analyze with Coverity run: | diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml index 62be1a879..6c1391174 100644 --- a/.github/workflows/it.yaml +++ b/.github/workflows/it.yaml @@ -30,7 +30,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Build Setup run: ./mvnw clean install diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 156ee972e..0c630ddcc 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -14,7 +14,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - uses: webfactory/ssh-agent@master with: From ebe409af821344e927ec8923aed1e083cabb6597 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 24 Jul 2022 13:03:58 -0400 Subject: [PATCH 0793/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.1.1 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 7ff9f2cd2..355e92ed7 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.1.1-SNAPSHOT + 4.7.1.1 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.1.1 Github From d474e61eff2f6b12ca65cd982cd753e2ad8a2114 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 24 Jul 2022 13:04:02 -0400 Subject: [PATCH 0794/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 355e92ed7..654a9b6d8 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.1.1 + 4.7.1.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.1.1 + HEAD Github From d875f99cfc611781092ad6f45263e6579834bc8a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 1 Aug 2022 19:07:11 +0000 Subject: [PATCH 0795/1013] Bump maven-reporting-api from 3.1.0 to 3.1.1 Bumps [maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/apache/maven-reporting-api/releases) - [Commits](https://github.com/apache/maven-reporting-api/compare/maven-reporting-api-3.1.0...maven-reporting-api-3.1.1) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 654a9b6d8..e006c6446 100644 --- a/pom.xml +++ b/pom.xml @@ -169,7 +169,7 @@ 3.3.4 0.13.1 3.3.1 - 3.1.0 + 3.1.1 3.1.0 3.8.6 From 83ae9744f7f0e08c1c715d305fe456004433e916 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 4 Aug 2022 19:02:10 +0000 Subject: [PATCH 0796/1013] Bump maven-site-plugin from 3.12.0 to 3.12.1 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.12.0 to 3.12.1. - [Release notes](https://github.com/apache/maven-site-plugin/releases) - [Commits](https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-3.12.0...maven-site-plugin-3.12.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-site-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e006c6446..160ff7f77 100644 --- a/pom.xml +++ b/pom.xml @@ -186,7 +186,7 @@ 3.4.0 3.6.4 1.13.0 - 3.12.0 + 3.12.1 3.6 2.11.0 From 3a1a24a990911d3d05b9cc360d26922b9cd9251a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 4 Aug 2022 19:02:19 +0000 Subject: [PATCH 0797/1013] Bump javaparser-core from 3.24.2 to 3.24.4 Bumps [javaparser-core](https://github.com/javaparser/javaparser) from 3.24.2 to 3.24.4. - [Release notes](https://github.com/javaparser/javaparser/releases) - [Changelog](https://github.com/javaparser/javaparser/blob/master/changelog.md) - [Commits](https://github.com/javaparser/javaparser/compare/javaparser-parent-3.24.2...javaparser-parent-3.24.4) --- updated-dependencies: - dependency-name: com.github.javaparser:javaparser-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e006c6446..0f0f4df07 100644 --- a/pom.xml +++ b/pom.xml @@ -160,7 +160,7 @@ 1.10.12 4.0.4 3.0.12 - 3.24.2 + 3.24.4 1.11.1 1.11.1 From 42c664dc6721065d2816fadbe563a1d54411e709 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 10 Aug 2022 19:02:40 +0000 Subject: [PATCH 0798/1013] Bump maven-reporting-impl from 3.1.0 to 3.2.0 Bumps [maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 3.1.0 to 3.2.0. - [Release notes](https://github.com/apache/maven-reporting-impl/releases) - [Commits](https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-3.1.0...maven-reporting-impl-3.2.0) --- updated-dependencies: - dependency-name: org.apache.maven.reporting:maven-reporting-impl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0464f055a..4aa8c0371 100644 --- a/pom.xml +++ b/pom.xml @@ -170,7 +170,7 @@ 0.13.1 3.3.1 3.1.1 - 3.1.0 + 3.2.0 3.8.6 2.1.1 From 4f2776f5134b88e6b7818fa16ed8e7d7238abbee Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 11 Aug 2022 01:58:32 +0000 Subject: [PATCH 0799/1013] Add renovate.json --- renovate.json | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 renovate.json diff --git a/renovate.json b/renovate.json new file mode 100644 index 000000000..39a2b6e9a --- /dev/null +++ b/renovate.json @@ -0,0 +1,6 @@ +{ + "$schema": "https://docs.renovatebot.com/renovate-schema.json", + "extends": [ + "config:base" + ] +} From fa2a9babb31cd3f6e4094be0acc165955b5190fb Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 13 Aug 2022 16:41:45 -0400 Subject: [PATCH 0800/1013] [github] Drop dependabot as we moved to renovate --- .github/dependabot.yml | 10 ---------- 1 file changed, 10 deletions(-) delete mode 100644 .github/dependabot.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml deleted file mode 100644 index bd840b548..000000000 --- a/.github/dependabot.yml +++ /dev/null @@ -1,10 +0,0 @@ -version: 2 -updates: -- package-ecosystem: github-actions - directory: "/" - schedule: - interval: daily -- package-ecosystem: "maven" - directory: "/" - schedule: - interval: "daily" From cede37e88e527fad47917da51fa1640d385e7ba5 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 13 Aug 2022 23:09:00 +0000 Subject: [PATCH 0801/1013] Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.4.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4aa8c0371..d89246224 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 1.13.1 3.4.0 3.3.0 - 3.4.0 + 3.4.1 3.6.4 1.13.0 3.12.1 From 8d0d85c0fe4f349bad730167ec06023037261880 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 13 Aug 2022 23:09:05 +0000 Subject: [PATCH 0802/1013] Update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 4aa8c0371..8a4ae44e9 100644 --- a/pom.xml +++ b/pom.xml @@ -181,7 +181,7 @@ 1.0.0 0.22-1 1.13.1 - 3.4.0 + 3.4.1 3.3.0 3.4.0 3.6.4 From dfeae38ab6df5ac5658244228975fef44edfad67 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 20 Aug 2022 20:03:42 +0000 Subject: [PATCH 0803/1013] Update slf4jVersion to v2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ef067bdaf..57fb45c76 100644 --- a/pom.xml +++ b/pom.xml @@ -155,7 +155,7 @@ 5.9.0-RC1 4.7.1 4.7.1 - 1.7.36 + 2.0.0 1.10.12 4.0.4 From 01758a3843ac2ebbd783a9c8fdf3d505a6aca121 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 5 Sep 2022 05:35:37 +0000 Subject: [PATCH 0804/1013] Update dependency com.github.spotbugs:spotbugs to v4.7.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ef067bdaf..f76792cac 100644 --- a/pom.xml +++ b/pom.xml @@ -153,7 +153,7 @@ 1.8 5.9.0-RC1 - 4.7.1 + 4.7.2 4.7.1 1.7.36 From ea6cb7c4911f9ecb64b10415b704b9d7dc59814e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 5 Sep 2022 21:46:38 -0400 Subject: [PATCH 0805/1013] [pom] Bump remainder of spotbugs to 4.7.2 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index a66673df0..cb4b39282 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.1.2-SNAPSHOT + 4.7.2.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -147,14 +147,14 @@ ${project.version} - 4.7.1 + 4.7.2 1.8 5.9.0-RC1 4.7.2 - 4.7.1 + 4.7.2 2.0.0 1.10.12 From 97012fa26ab7409da06885e37f4205117588d336 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 5 Sep 2022 21:46:47 -0400 Subject: [PATCH 0806/1013] [pom] Bump junit to 5.9.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index cb4b39282..4c1203261 100644 --- a/pom.xml +++ b/pom.xml @@ -152,7 +152,7 @@ 1.8 - 5.9.0-RC1 + 5.9.0 4.7.2 4.7.2 2.0.0 From 094bf441e10b7b666d4fd8012508c8eae1b2f667 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 5 Sep 2022 22:01:09 -0400 Subject: [PATCH 0807/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.2.0 --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index 4c1203261..c26374f5f 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.0-SNAPSHOT + 4.7.2.0 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.2.0 Github From 2ad479b5d059932725a75d66446f746d4cbd17ef Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 5 Sep 2022 22:01:13 -0400 Subject: [PATCH 0808/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pom.xml b/pom.xml index c26374f5f..444631ed0 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.0 + 4.7.2.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.2.0 + HEAD Github From c4d218a97487292db6eae052e4814c75251ef570 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 6 Sep 2022 10:09:06 +0000 Subject: [PATCH 0809/1013] Update dependency org.codehaus.mojo:versions-maven-plugin to v2.12.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 444631ed0..346e0ae8d 100644 --- a/pom.xml +++ b/pom.xml @@ -188,7 +188,7 @@ 1.13.0 3.12.1 3.6 - 2.11.0 + 2.12.0 false ${project.build.directory}/it-src-spotbugs From db262c223e1209431caaa5b9a18359630f0cd577 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 9 Sep 2022 15:54:08 +0000 Subject: [PATCH 0810/1013] Update groovy monorepo to v4.0.5 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 346e0ae8d..0004e3c29 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 2.0.0 1.10.12 - 4.0.4 + 4.0.5 3.0.12 3.24.4 From c48a90664473ec6f763b5d7ed877c0a1b4209cb9 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 14 Sep 2022 18:26:16 +0000 Subject: [PATCH 0811/1013] Update slf4jVersion to v2.0.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0004e3c29..ced30f956 100644 --- a/pom.xml +++ b/pom.xml @@ -155,7 +155,7 @@ 5.9.0 4.7.2 4.7.2 - 2.0.0 + 2.0.1 1.10.12 4.0.5 From 932ea7997766841e000c326d51061db764e0e61c Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 16 Sep 2022 10:47:32 +0000 Subject: [PATCH 0812/1013] Update dependency org.apache.maven.shared:maven-common-artifact-filters to v3.3.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ced30f956..e385326e5 100644 --- a/pom.xml +++ b/pom.xml @@ -168,7 +168,7 @@ 3.8.6 3.3.4 0.13.1 - 3.3.1 + 3.3.2 3.1.1 3.2.0 3.8.6 From 49ab8c31eb8fd55df5fa6f302c9b4b4a1c4acd7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Boutemy?= Date: Fri, 16 Sep 2022 19:00:51 +0200 Subject: [PATCH 0813/1013] Reproducible Builds: override timestamp value --- pom.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pom.xml b/pom.xml index e385326e5..0f2a63b4b 100644 --- a/pom.xml +++ b/pom.xml @@ -146,6 +146,9 @@ ${project.version} + + 1657151022 + 4.7.2 From f54ffa17189721811d50a54b2d7fc59a97d587eb Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 18 Sep 2022 10:31:48 +0000 Subject: [PATCH 0814/1013] Update groovy monorepo to v3.0.13 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0f2a63b4b..33b16db9c 100644 --- a/pom.xml +++ b/pom.xml @@ -162,7 +162,7 @@ 1.10.12 4.0.5 - 3.0.12 + 3.0.13 3.24.4 1.11.1 From 6cb063c1e8f1ed2ff757246770de9db3e987f36c Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 20 Sep 2022 19:53:16 +0000 Subject: [PATCH 0815/1013] Update dependency org.slf4j:slf4j-api to v2.0.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 33b16db9c..0e364e9d3 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 5.9.0 4.7.2 4.7.2 - 2.0.1 + 2.0.2 1.10.12 4.0.5 From f9dc957930d8db654d4c125d948f2786998059d8 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 27 Sep 2022 10:59:43 -0400 Subject: [PATCH 0816/1013] [pom] Bump junit to 5.9.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0e364e9d3..80767240a 100644 --- a/pom.xml +++ b/pom.xml @@ -155,7 +155,7 @@ 1.8 - 5.9.0 + 5.9.1 4.7.2 4.7.2 2.0.2 From f1b84ab96307977971ee600295459d42fa00dbcb Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 28 Sep 2022 11:34:07 +0000 Subject: [PATCH 0817/1013] Update slf4jVersion to v2.0.3 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0e364e9d3..66e2b8f91 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 5.9.0 4.7.2 4.7.2 - 2.0.2 + 2.0.3 1.10.12 4.0.5 From f57b664aad1e5d86480585d640e8e0341e9dea1b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 2 Oct 2022 12:37:47 +0000 Subject: [PATCH 0818/1013] Update dependency org.ow2.asm:asm-bom to v9.4 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index fb48215af..4593e7d13 100644 --- a/pom.xml +++ b/pom.xml @@ -217,7 +217,7 @@ 5.13.1.202206130422-r - 9.3 + 9.4 1.9.4 1.2 1.15 From 21e2e70c938a290fd4a43fc87decb7fcf89d8021 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 7 Oct 2022 23:21:48 -0400 Subject: [PATCH 0819/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.2.1 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 4593e7d13..1ebbba94c 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.1-SNAPSHOT + 4.7.2.1 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.2.1 Github @@ -147,7 +147,7 @@ ${project.version} - 1657151022 + 1665199293 4.7.2 From a518161a358ff2c33fcc1acc1940cc7de5db069a Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 7 Oct 2022 23:21:51 -0400 Subject: [PATCH 0820/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 1ebbba94c..baf58ba65 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.1 + 4.7.2.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.2.1 + HEAD Github @@ -147,7 +147,7 @@ ${project.version} - 1665199293 + 1665199311 4.7.2 From 81cfa116d8bbe08623a926550025826937291af7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Fri, 7 Oct 2022 23:41:29 -0400 Subject: [PATCH 0821/1013] [mvn] Update maven wrapper --- .mvn/maven.config | 1 + 1 file changed, 1 insertion(+) create mode 100644 .mvn/maven.config diff --git a/.mvn/maven.config b/.mvn/maven.config new file mode 100644 index 000000000..956533e67 --- /dev/null +++ b/.mvn/maven.config @@ -0,0 +1 @@ +-Daether.checksums.algorithms=SHA-512,SHA-256,SHA-1,MD5 From d878f12900d9ae8e90916f8f6d215a644af9664a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 9 Oct 2022 19:20:38 +0000 Subject: [PATCH 0822/1013] Update dependency org.codehaus.gmavenplus:gmavenplus-plugin to v2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index baf58ba65..5f9b4c76e 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 3.1.0 1.0.0 0.22-1 - 1.13.1 + 2.0.0 3.4.1 3.3.0 3.4.1 From 5c4080916231f23029dff6347ac7ebf75cc1a6d5 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 13 Oct 2022 05:32:52 +0000 Subject: [PATCH 0823/1013] Update JamesIves/github-pages-deploy-action action to v4.4.1 --- .github/workflows/site.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 0c630ddcc..29ab04650 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -25,7 +25,7 @@ jobs: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - name: Deploy Site to gh-pages - uses: JamesIves/github-pages-deploy-action@v4.4.0 + uses: JamesIves/github-pages-deploy-action@v4.4.1 with: SSH: true BRANCH: gh-pages From 48b87cd61131156f20f77f518d4ab93c4e094219 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 16 Oct 2022 09:16:24 +0000 Subject: [PATCH 0824/1013] Update groovy monorepo to v4.0.6 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 5f9b4c76e..75c286b40 100644 --- a/pom.xml +++ b/pom.xml @@ -161,7 +161,7 @@ 2.0.3 1.10.12 - 4.0.5 + 4.0.6 3.0.13 3.24.4 From 9f9e15bcaf0ed41a871ccd1271b516a747b2b371 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 17 Oct 2022 05:48:54 +0000 Subject: [PATCH 0825/1013] Update dependency com.github.spotbugs:spotbugs to v4.7.3 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 75c286b40..1037e8be0 100644 --- a/pom.xml +++ b/pom.xml @@ -156,7 +156,7 @@ 1.8 5.9.1 - 4.7.2 + 4.7.3 4.7.2 2.0.3 From 14d0e14113bf0afcb5bc9174773611b2a6e0038d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 20 Oct 2022 11:01:36 +0000 Subject: [PATCH 0826/1013] Update dependency com.github.javaparser:javaparser-core to v3.24.7 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 75c286b40..b6d953a90 100644 --- a/pom.xml +++ b/pom.xml @@ -163,7 +163,7 @@ 1.10.12 4.0.6 3.0.13 - 3.24.4 + 3.24.7 1.11.1 1.11.1 From a5a68a70fe4f53edc673e35e7148b2b953d1407d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 21 Oct 2022 03:13:48 +0000 Subject: [PATCH 0827/1013] Update dependency org.codehaus.gmavenplus:gmavenplus-plugin to v2.1.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a544c5541..a944efb44 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 3.1.0 1.0.0 0.22-1 - 2.0.0 + 2.1.0 3.4.1 3.3.0 3.4.1 From 2819833db11eb8fc93515582caa8c2a25b9f983e Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 23 Oct 2022 10:07:20 +0000 Subject: [PATCH 0828/1013] Update dependency org.codehaus.plexus:plexus-utils to v3.5.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a944efb44..f6f015600 100644 --- a/pom.xml +++ b/pom.xml @@ -178,7 +178,7 @@ 2.1.1 1.2.0 - 3.4.2 + 3.5.0 3.1.0 1.0.0 From a01ef40e5a6ffd2deff1f125b717396b671f1536 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 23 Oct 2022 17:14:59 +0000 Subject: [PATCH 0829/1013] Update dependency org.codehaus.mojo:versions-maven-plugin to v2.13.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a944efb44..a4915a781 100644 --- a/pom.xml +++ b/pom.xml @@ -191,7 +191,7 @@ 1.13.0 3.12.1 3.6 - 2.12.0 + 2.13.0 false ${project.build.directory}/it-src-spotbugs From e148e19538bccf78a215e95f520274a7a249839b Mon Sep 17 00:00:00 2001 From: Jan-Willem Gmelig Meyling Date: Thu, 3 Nov 2022 21:07:07 +0100 Subject: [PATCH 0830/1013] Make sarifOutputDirectory and sarifOutputFilename configurable --- .../mojo/spotbugs/SpotBugsMojo.groovy | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index f79ac78c6..d531fbb2b 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -77,6 +77,23 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(defaultValue = "false", property = "spotbugs.sarifFullPath", required = true) boolean sarifFullPath + /** + * Specifies the directory where the sarif output will be generated. + * + * @since 4.7.2.2 + */ + @Parameter(defaultValue = '${project.build.directory}', property = "spotbugs.sarifOutputDirectory", required = true) + File sarifOutputDirectory + + + /** + * Set the name of the output SARIF file produced + * + * @since 4.7.2.2 + */ + @Parameter(property = "spotbugs.sarifOutputFilename", defaultValue = "spotbugsSarif.json", required = true) + String sarifOutputFilename + /** * Specifies the directory where the xml output will be generated. * @@ -1122,7 +1139,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") File sarifTempFile = new File("${project.build.directory}/spotbugsTempSarif.json") - File sarifFinalFile = new File("${project.build.directory}/spotbugsSarif.json") + File sarifFinalFile = new File(sarifOutputDirectory, sarifOutputFilename) if (xmlOutput || !sarifOutput) { forceFileCreation(xmlTempFile) @@ -1312,6 +1329,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } } + forceFileCreation(sarifFinalFile) + sarifFinalFile.withWriter { builder.writeTo(it) } From f8450ddacc7328075693c6e56d3cdb2844767d1c Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 6 Nov 2022 11:21:02 -0500 Subject: [PATCH 0831/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.2.2 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 8fe4a0895..22b028a75 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.2-SNAPSHOT + 4.7.2.2 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.2.2 Github @@ -147,7 +147,7 @@ ${project.version} - 1665199311 + 1667751635 4.7.2 From d46ad44ad6c0b1782f2dfce57a59436e27e4ee79 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 6 Nov 2022 11:21:05 -0500 Subject: [PATCH 0832/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 22b028a75..79ee621c4 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.2 + 4.7.2.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.2.2 + HEAD Github @@ -147,7 +147,7 @@ ${project.version} - 1667751635 + 1667751665 4.7.2 From 371096c3b2dd6f320006b9d9fd95c411e93d48fc Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 7 Nov 2022 13:01:08 -0500 Subject: [PATCH 0833/1013] [pom] Set rest of spotbugs 4.7.3 artifacts --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 79ee621c4..4f9ecb101 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.2.3-SNAPSHOT + 4.7.3.0-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -150,14 +150,14 @@ 1667751665 - 4.7.2 + 4.7.3 1.8 5.9.1 4.7.3 - 4.7.2 + 4.7.3 2.0.3 1.10.12 From a084687f6bb4706314cc57c0119a79135ba053f6 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 7 Nov 2022 13:40:43 -0500 Subject: [PATCH 0834/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.3.0 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 4f9ecb101..dca441fad 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.0-SNAPSHOT + 4.7.3.0 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.3.0 Github @@ -147,7 +147,7 @@ ${project.version} - 1667751665 + 1667846410 4.7.3 From 85204db7ebc00cebbdd23619284ae19e9f87da68 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 7 Nov 2022 13:40:46 -0500 Subject: [PATCH 0835/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index dca441fad..f3592758a 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.0 + 4.7.3.1-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.3.0 + HEAD Github @@ -147,7 +147,7 @@ ${project.version} - 1667846410 + 1667846445 4.7.3 From ff52e57302515a677825125f74dfd4dbf6bcf7ad Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 7 Nov 2022 20:13:08 +0000 Subject: [PATCH 0836/1013] Update pluginPluginVersion to v3.7.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f3592758a..56736dfc8 100644 --- a/pom.xml +++ b/pom.xml @@ -187,7 +187,7 @@ 3.4.1 3.3.0 3.4.1 - 3.6.4 + 3.7.0 1.13.0 3.12.1 3.6 From f6f053340ad6bb7785a4faf70421f95c23a9d07c Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 17 Nov 2022 19:37:34 +0000 Subject: [PATCH 0837/1013] Update dependency com.github.javaparser:javaparser-core to v3.24.8 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 56736dfc8..8dbe3310a 100644 --- a/pom.xml +++ b/pom.xml @@ -163,7 +163,7 @@ 1.10.12 4.0.6 3.0.13 - 3.24.7 + 3.24.8 1.11.1 1.11.1 From 8ff403c74ab4b1be3fcd3d55c25388e91ed29184 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 17 Nov 2022 22:45:46 +0000 Subject: [PATCH 0838/1013] Update slf4jVersion to v2.0.4 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 56736dfc8..6638c9ae6 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 5.9.1 4.7.3 4.7.3 - 2.0.3 + 2.0.4 1.10.12 4.0.6 From aba456f8389958a93d0010db21e7999aad3c8b57 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 25 Nov 2022 12:58:18 +0000 Subject: [PATCH 0839/1013] Update slf4jVersion to v2.0.5 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 49800ae06..1bf0801bb 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 5.9.1 4.7.3 4.7.3 - 2.0.4 + 2.0.5 1.10.12 4.0.6 From e0057c1a0d1eeb2b719588b7913cbe71314fc0eb Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 12 Dec 2022 14:07:53 +0000 Subject: [PATCH 0840/1013] Update dependency com.github.javaparser:javaparser-core to v3.24.9 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1bf0801bb..dd7fa3150 100644 --- a/pom.xml +++ b/pom.xml @@ -163,7 +163,7 @@ 1.10.12 4.0.6 3.0.13 - 3.24.8 + 3.24.9 1.11.1 1.11.1 From 7978bea2491b814a4857cf933c031609f1e94674 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 13 Dec 2022 00:36:28 +0000 Subject: [PATCH 0841/1013] Update slf4jVersion to v2.0.6 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dd7fa3150..d7912d6a6 100644 --- a/pom.xml +++ b/pom.xml @@ -158,7 +158,7 @@ 5.9.1 4.7.3 4.7.3 - 2.0.5 + 2.0.6 1.10.12 4.0.6 From f37a1fcabb1b5ad4f30b77b0fc0c05d8701843b6 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 15 Dec 2022 15:48:38 +0000 Subject: [PATCH 0842/1013] Update dependency org.codehaus.mojo:versions-maven-plugin to v2.14.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index d7912d6a6..0e1af8bde 100644 --- a/pom.xml +++ b/pom.xml @@ -191,7 +191,7 @@ 1.13.0 3.12.1 3.6 - 2.13.0 + 2.14.1 false ${project.build.directory}/it-src-spotbugs From 7e93c919eb4b4b87a41aec4e0374c905e392bbee Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 24 Dec 2022 14:51:35 +0000 Subject: [PATCH 0843/1013] Update dependency org.codehaus.mojo:versions-maven-plugin to v2.14.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 0e1af8bde..cba5668fa 100644 --- a/pom.xml +++ b/pom.xml @@ -191,7 +191,7 @@ 1.13.0 3.12.1 3.6 - 2.14.1 + 2.14.2 false ${project.build.directory}/it-src-spotbugs From 977f5ab7bbe13d7fcfe0f02faa033deb6110ab04 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 24 Dec 2022 12:22:21 -0500 Subject: [PATCH 0844/1013] [pom] Update invoker plugin to 3.4.0 and update groovy used with it currently they are now the same. To ensure we keep same as we likely release more frequently, just keep overriding it to what we are on. --- pom.xml | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/pom.xml b/pom.xml index 0e1af8bde..df4fe7cd1 100644 --- a/pom.xml +++ b/pom.xml @@ -162,7 +162,6 @@ 1.10.12 4.0.6 - 3.0.13 3.24.9 1.11.1 @@ -185,7 +184,7 @@ 0.22-1 2.1.0 3.4.1 - 3.3.0 + 3.4.0 3.4.1 3.7.0 1.13.0 @@ -856,26 +855,26 @@ - + - org.codehaus.groovy + org.apache.groovy groovy - ${groovy3Version} + ${groovyVersion} - org.codehaus.groovy + org.apache.groovy groovy-json - ${groovy3Version} + ${groovyVersion} - org.codehaus.groovy + org.apache.groovy groovy-nio - ${groovy3Version} + ${groovyVersion} - org.codehaus.groovy + org.apache.groovy groovy-xml - ${groovy3Version} + ${groovyVersion} From 4e19698e531c6ece2d9d0c6ec62f6383a567242f Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 24 Dec 2022 17:41:59 +0000 Subject: [PATCH 0845/1013] Update groovy monorepo to v4.0.7 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ff09acad1..1826cfb90 100644 --- a/pom.xml +++ b/pom.xml @@ -161,7 +161,7 @@ 2.0.6 1.10.12 - 4.0.6 + 4.0.7 3.24.9 1.11.1 From 9c55d536f4562d1c0764b7bea02b909b529a1f81 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 30 Dec 2022 21:30:05 +0000 Subject: [PATCH 0846/1013] Update mavenCoreVersion to v3.8.7 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1826cfb90..d6cd18b26 100644 --- a/pom.xml +++ b/pom.xml @@ -167,7 +167,7 @@ 1.11.1 1.11.1 - 3.8.6 + 3.8.7 3.3.4 0.13.1 3.3.2 From 92df05c7c499a1514a00ad26becf0845758fb4ad Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Fri, 30 Dec 2022 21:30:11 +0000 Subject: [PATCH 0847/1013] Update mavenVersion to v3.8.7 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1826cfb90..5ef909d40 100644 --- a/pom.xml +++ b/pom.xml @@ -173,7 +173,7 @@ 3.3.2 3.1.1 3.2.0 - 3.8.6 + 3.8.7 2.1.1 1.2.0 From 9343fdfd2454b3374b9f47b47c19fea28d1e876b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 31 Dec 2022 18:40:03 +0000 Subject: [PATCH 0848/1013] Update dependency com.github.javaparser:javaparser-core to v3.24.10 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 1826cfb90..a52ac6d5b 100644 --- a/pom.xml +++ b/pom.xml @@ -162,7 +162,7 @@ 1.10.12 4.0.7 - 3.24.9 + 3.24.10 1.11.1 1.11.1 From 21d2fc86668c78ae89599b88909595e294f9636d Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 10 Jan 2023 07:04:45 +0000 Subject: [PATCH 0849/1013] Update dependency org.apache.ant:ant to v1.10.13 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2f10df596..7a7b6f296 100644 --- a/pom.xml +++ b/pom.xml @@ -160,7 +160,7 @@ 4.7.3 2.0.6 - 1.10.12 + 1.10.13 4.0.7 3.24.10 From 02f7605576da99ca9634f0f4ca1569609ec5967e Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 11 Jan 2023 23:44:18 +0000 Subject: [PATCH 0850/1013] Update dependency org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 7a7b6f296..6c4dc5a3f 100644 --- a/pom.xml +++ b/pom.xml @@ -183,7 +183,7 @@ 1.0.0 0.22-1 2.1.0 - 3.4.1 + 3.4.2 3.4.0 3.4.1 3.7.0 From e6b970864d6364c0c2450295e2ecc35a85fe88cd Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sat, 14 Jan 2023 17:46:20 +0000 Subject: [PATCH 0851/1013] Update doxiaVersion to v1.12.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6c4dc5a3f..e52dc6cf0 100644 --- a/pom.xml +++ b/pom.xml @@ -164,7 +164,7 @@ 4.0.7 3.24.10 - 1.11.1 + 1.12.0 1.11.1 3.8.7 From d4d1f1c504cdfd9d379c63199e76456a55a85b0b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 16 Jan 2023 11:20:54 +0000 Subject: [PATCH 0852/1013] Update pluginPluginVersion to v3.7.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index e52dc6cf0..54bd0b2cf 100644 --- a/pom.xml +++ b/pom.xml @@ -186,7 +186,7 @@ 3.4.2 3.4.0 3.4.1 - 3.7.0 + 3.7.1 1.13.0 3.12.1 3.6 From a4af18abf86ce0bf55ec120eeb9d511697368fed Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 16 Jan 2023 17:25:11 +0000 Subject: [PATCH 0853/1013] Update dependency com.github.hazendaz:base-parent to v37 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 54bd0b2cf..a9febca7e 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 36 + 37 From 13a612b7f9af1d1211b92379f263d3678b042e4f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 16 Jan 2023 12:48:41 -0500 Subject: [PATCH 0854/1013] [actions] Rename codeql yml to yaml --- .github/workflows/{codeql-analysis.yml => codeql-analysis.yaml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{codeql-analysis.yml => codeql-analysis.yaml} (100%) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yaml similarity index 100% rename from .github/workflows/codeql-analysis.yml rename to .github/workflows/codeql-analysis.yaml From 031befcb132d5a570ef77c434046d151b60ef943 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 16 Jan 2023 12:49:46 -0500 Subject: [PATCH 0855/1013] [actions] Drop jdk 18, add 20-ea and use 19 ga --- .github/workflows/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 147064789..4be13742e 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,7 +8,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macOS-latest, windows-latest] - java: [11, 17, 18, 19-ea] + java: [11, 17, 19, 20-ea] fail-fast: false max-parallel: 4 name: Test JDK ${{ matrix.java }}, ${{ matrix.os }} From 6c5dd1166f213e6d3f0dce5c73307b87f6eddf2b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 16 Jan 2023 12:49:57 -0500 Subject: [PATCH 0856/1013] [actons] Bump maven 3.3.9 usage to jdk 17 --- .github/workflows/it-maven339.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index a3c6281a9..99b86bb90 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -30,7 +30,7 @@ jobs: - name: Set up JDK uses: actions/setup-java@v3 with: - java-version: 11 + java-version: 17 distribution: 'zulu' - name: Load Maven 3.3.9 run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper -DmavenVersion=3.3.9 From 9618b391c3004935d3c86d4bb03fd93918d247d5 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Tue, 17 Jan 2023 21:25:27 -0500 Subject: [PATCH 0857/1013] [fix] Correct reporting to support maven site 4 changes --- .../codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 1c92a47f7..3b4fe5bc8 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -421,6 +421,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { sink.tableRow_() } + sink.tableRows_(); sink.table_() sink.section2_() @@ -509,6 +510,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { sink.text(bugClass) sink.sectionTitle2_() sink.table() + sink.tableRows(null, false) sink.tableRow() // bug @@ -554,6 +556,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { sink.sectionTitle1_() sink.table() + sink.tableRows(null, false) sink.tableRow() // classes @@ -601,6 +604,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { sink.tableCell_() sink.tableRow_() + sink.tableRows_(); sink.table_() sink.section1_() @@ -625,6 +629,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { * Class Summary */ sink.table() + sink.tableRows(null, false) sink.tableRow() // files @@ -667,6 +672,7 @@ class SpotbugsReportGenerator implements SpotBugsInfo { bugClasses << classStatsValue } + sink.tableRows_(); sink.table_() sink.section1_() From 607b7ab1db2b9865bee175c3c1727087c1880da0 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 24 Jan 2023 08:25:39 +0000 Subject: [PATCH 0858/1013] Update dependency maven to v3.8.7 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index dc3affce3..ca5ab4bab 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.6/apache-maven-3.8.6-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar From e6cb4751ac067a9232442784e7bd9a2e86d0b130 Mon Sep 17 00:00:00 2001 From: Benoit Lacelle Date: Fri, 27 Jan 2023 11:42:57 +0400 Subject: [PATCH 0859/1013] Remove -auxclasspathFromInput to prevent Systen.in usage --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index d531fbb2b..cd44d4263 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -935,8 +935,6 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << "-sarif=" + tempFile.getAbsolutePath() } - args << "-auxclasspathFromInput" - args << "-projectName" args << "${project.name}" From aa25a3a3f542c887711860a1d31f1b29ee60f802 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 31 Jan 2023 18:51:52 +0000 Subject: [PATCH 0860/1013] Update dependency com.github.javaparser:javaparser-core to v3.25.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index a9febca7e..37a4289d9 100644 --- a/pom.xml +++ b/pom.xml @@ -162,7 +162,7 @@ 1.10.13 4.0.7 - 3.24.10 + 3.25.0 1.12.0 1.11.1 From ff6a9af24e4bb90ad5999765dfb909a31fd8556a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 6 Feb 2023 09:49:36 +0000 Subject: [PATCH 0861/1013] Update dependency maven to v3.9.0 --- .mvn/wrapper/maven-wrapper.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties index ca5ab4bab..6686a643d 100644 --- a/.mvn/wrapper/maven-wrapper.properties +++ b/.mvn/wrapper/maven-wrapper.properties @@ -14,5 +14,5 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.8.7/apache-maven-3.8.7-bin.zip +distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar From e1c240a97037b3656a45adc9186551c8747574cd Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 6 Feb 2023 09:49:42 +0000 Subject: [PATCH 0862/1013] Update mavenCoreVersion to v3.9.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 37a4289d9..9ecd155e4 100644 --- a/pom.xml +++ b/pom.xml @@ -167,7 +167,7 @@ 1.12.0 1.11.1 - 3.8.7 + 3.9.0 3.3.4 0.13.1 3.3.2 From cad745fb322614980735b00b15103e0c571852d1 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 6 Feb 2023 13:33:37 +0000 Subject: [PATCH 0863/1013] Update mavenVersion to v3.9.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 37a4289d9..c6fbe7dde 100644 --- a/pom.xml +++ b/pom.xml @@ -173,7 +173,7 @@ 3.3.2 3.1.1 3.2.0 - 3.8.7 + 3.9.0 2.1.1 1.2.0 From cb09ed898306711af40572847c9111fbca038a0a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 15 Feb 2023 12:43:09 +0000 Subject: [PATCH 0864/1013] Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.5.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2780b10aa..eb148c221 100644 --- a/pom.xml +++ b/pom.xml @@ -185,7 +185,7 @@ 2.1.0 3.4.2 3.4.0 - 3.4.1 + 3.5.0 3.7.1 1.13.0 3.12.1 From ff45203c866ee45741dbd796c980a98dac9f7668 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 15 Feb 2023 23:14:42 +0000 Subject: [PATCH 0865/1013] Update dependency org.apache.maven.plugins:maven-invoker-plugin to v3.5.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index eb148c221..f9685b736 100644 --- a/pom.xml +++ b/pom.xml @@ -184,7 +184,7 @@ 0.22-1 2.1.0 3.4.2 - 3.4.0 + 3.5.0 3.5.0 3.7.1 1.13.0 From 16f84e0f070899bc23d035425f0d6c43e4264404 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 17:51:01 -0500 Subject: [PATCH 0866/1013] [action] Bump maven wrapper to 3.1.1 --- .github/workflows/it-maven339.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index 99b86bb90..7da4c868c 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -33,7 +33,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Load Maven 3.3.9 - run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.0:wrapper -DmavenVersion=3.3.9 + run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 - name: Build Setup run: ./mvnw clean install -Dmaven.min-version=3.3.9 - name: Integration Test with Maven From 8860b0e42d8e7592598c58d9bcb2df7fa755d14e Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 18:05:32 -0500 Subject: [PATCH 0867/1013] [ci] Remove extra lines from javadoc in spotbugsinfo --- .../org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index a4ff7b221..4e7721cc9 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -29,49 +29,41 @@ interface SpotBugsInfo { /** * The name of the Plug-In. - * */ static final String PLUGIN_NAME = "spotbugs" /** * The name of the property resource bundle (Filesystem). - * */ static final String BUNDLE_NAME = "spotbugs" /** * The key to get the name of the Plug-In from the bundle. - * */ static final String NAME_KEY = "report.spotbugs.name" /** * The key to get the description of the Plug-In from the bundle. - * */ static final String DESCRIPTION_KEY = "report.spotbugs.description" /** * The key to get the source directory message of the Plug-In from the bundle. - * */ static final String SOURCE_ROOT_KEY = "report.spotbugs.sourceRoot" /** * The key to get the source directory message of the Plug-In from the bundle. - * */ static final String TEST_SOURCE_ROOT_KEY = "report.spotbugs.testSourceRoot" /** * The key to get the java source message of the Plug-In from the bundle. - * */ static final String JAVA_SOURCES_KEY = "report.spotbugs.javasources" /** * The regex pattern to search for java class files. - * */ static final String JAVA_REGEX_PATTERN = "**/*.class" @@ -83,7 +75,6 @@ interface SpotBugsInfo { /** * The character to separate URL tokens. - * */ static final String URL_SEPARATOR = "/" From fece4858ae7c7a6fe60a6c7d0db86298796bbea7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 18:15:19 -0500 Subject: [PATCH 0868/1013] [pom] Bump junit to 5.9.2 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index f9685b736..b633127e8 100644 --- a/pom.xml +++ b/pom.xml @@ -155,7 +155,7 @@ 1.8 - 5.9.1 + 5.9.2 4.7.3 4.7.3 2.0.6 From b4fc7bdd727a21684469694d4715882ccb7c63ac Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 18:16:53 -0500 Subject: [PATCH 0869/1013] [pom] Bump surefire to 3.0.0-M9 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index b633127e8..61ca30331 100644 --- a/pom.xml +++ b/pom.xml @@ -208,7 +208,7 @@ 3.10.1 1.12.0 3.2.0 - 3.0.0-M7 + 3.0.0-M9 8.0.0 4.0.4 7.4.7 From dd83c23e58caa251fd1b8032cf9927d1f1d42a07 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 19:00:22 -0500 Subject: [PATCH 0870/1013] [actions] Add -B to everything and no-transfer-progress --- .github/workflows/coveralls.yaml | 2 +- .github/workflows/coverity.yaml | 2 +- .github/workflows/it-maven339.yaml | 6 +++--- .github/workflows/it.yaml | 4 ++-- .github/workflows/sonar.yaml | 2 +- .github/workflows/sonatype.yaml | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index 038e5ebeb..a47778adc 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -31,7 +31,7 @@ jobs: distribution: 'zulu' - name: Report Coverage to Coveralls for Pull Requests if: github.event_name == 'pull_request' - run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER + run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER --no-transfer-progress env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.number }} diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml index c7cfd0d8b..6977ed555 100644 --- a/.github/workflows/coverity.yaml +++ b/.github/workflows/coverity.yaml @@ -20,7 +20,7 @@ jobs: run: | wget -q https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_TOKEN&project=spotbugs%2Fspotbugs-maven-plugin" -O coverity_tool.tgz tar -xf coverity_tool.tgz - ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -DskipTests=true verify + ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -DskipTests=true verify --no-transfer-progress tar czvf spotbugs-maven-plugin.tgz cov-int curl --form token=$COVERITY_TOKEN \ --form email=$EMAIL \ diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index 7da4c868c..fac010d93 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -33,8 +33,8 @@ jobs: java-version: 17 distribution: 'zulu' - name: Load Maven 3.3.9 - run: ./mvnw org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 + run: ./mvnw -B org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 --no-transfer-progress - name: Build Setup - run: ./mvnw clean install -Dmaven.min-version=3.3.9 + run: ./mvnw -B clean install -Dmaven.min-version=3.3.9 --no-transfer-progress - name: Integration Test with Maven - run: ./mvnw -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 + run: ./mvnw -B -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml index 6c1391174..6f7052e1e 100644 --- a/.github/workflows/it.yaml +++ b/.github/workflows/it.yaml @@ -33,6 +33,6 @@ jobs: java-version: 17 distribution: 'zulu' - name: Build Setup - run: ./mvnw clean install + run: ./mvnw -B clean install --no-transfer-progress - name: Integration Test with Maven - run: ./mvnw -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 + run: ./mvnw -B -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index e454023f1..39a07855c 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -20,7 +20,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Analyze with SonarCloud - run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" + run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" --no-transfer-progress env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 0080c698c..25e68f92d 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -17,7 +17,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Deploy to Sonatype - run: ./mvnw deploy -DskipTests -B --no-transfer-progress --settings ./.mvn/settings.xml + run: ./mvnw deploy -DskipTests -B --no-transfer-progress --settings ./.mvn/settings.xml env: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }} From c63426cb522896012a9c3a71f108410a4374962f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 19:05:13 -0500 Subject: [PATCH 0871/1013] [actions] Add verbose to everything as easier to debug --- .github/workflows/ci.yaml | 2 +- .github/workflows/coveralls.yaml | 4 ++-- .github/workflows/coverity.yaml | 2 +- .github/workflows/it-maven339.yaml | 6 +++--- .github/workflows/it.yaml | 4 ++-- .github/workflows/site.yaml | 2 +- .github/workflows/sonar.yaml | 2 +- .github/workflows/sonatype.yaml | 2 +- 8 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 4be13742e..21b804091 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -21,4 +21,4 @@ jobs: java-version: ${{ matrix.java }} distribution: 'zulu' - name: Test with Maven - run: ./mvnw test -B --no-transfer-progress + run: ./mvnw test -B -V --no-transfer-progress diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml index a47778adc..5830a9c88 100644 --- a/.github/workflows/coveralls.yaml +++ b/.github/workflows/coveralls.yaml @@ -31,12 +31,12 @@ jobs: distribution: 'zulu' - name: Report Coverage to Coveralls for Pull Requests if: github.event_name == 'pull_request' - run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER --no-transfer-progress + run: ./mvnw -B -V test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER --no-transfer-progress env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} PR_NUMBER: ${{ github.event.number }} - name: Report Coverage to Coveralls for General Push if: github.event_name == 'push' - run: ./mvnw test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github + run: ./mvnw -B -V test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml index 6977ed555..2e04646bd 100644 --- a/.github/workflows/coverity.yaml +++ b/.github/workflows/coverity.yaml @@ -20,7 +20,7 @@ jobs: run: | wget -q https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_TOKEN&project=spotbugs%2Fspotbugs-maven-plugin" -O coverity_tool.tgz tar -xf coverity_tool.tgz - ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -DskipTests=true verify --no-transfer-progress + ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -V -DskipTests=true verify --no-transfer-progress tar czvf spotbugs-maven-plugin.tgz cov-int curl --form token=$COVERITY_TOKEN \ --form email=$EMAIL \ diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index fac010d93..4cd2bdd31 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -33,8 +33,8 @@ jobs: java-version: 17 distribution: 'zulu' - name: Load Maven 3.3.9 - run: ./mvnw -B org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 --no-transfer-progress + run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 --no-transfer-progress - name: Build Setup - run: ./mvnw -B clean install -Dmaven.min-version=3.3.9 --no-transfer-progress + run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9 --no-transfer-progress - name: Integration Test with Maven - run: ./mvnw -B -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress + run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml index 6f7052e1e..07f665a96 100644 --- a/.github/workflows/it.yaml +++ b/.github/workflows/it.yaml @@ -33,6 +33,6 @@ jobs: java-version: 17 distribution: 'zulu' - name: Build Setup - run: ./mvnw -B clean install --no-transfer-progress + run: ./mvnw -B -V clean install --no-transfer-progress - name: Integration Test with Maven - run: ./mvnw -B -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress + run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml index 29ab04650..0eae1df8f 100644 --- a/.github/workflows/site.yaml +++ b/.github/workflows/site.yaml @@ -20,7 +20,7 @@ jobs: with: ssh-private-key: ${{ secrets.DEPLOY_KEY }} - name: Build site - run: ./mvnw site site:stage -DskipTests -B --no-transfer-progress + run: ./mvnw site site:stage -DskipTests -B -V --no-transfer-progress env: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml index 39a07855c..43ed44adc 100644 --- a/.github/workflows/sonar.yaml +++ b/.github/workflows/sonar.yaml @@ -20,7 +20,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Analyze with SonarCloud - run: ./mvnw verify sonar:sonar -B -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" --no-transfer-progress + run: ./mvnw verify sonar:sonar -B -V -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" --no-transfer-progress env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml index 25e68f92d..08c015e15 100644 --- a/.github/workflows/sonatype.yaml +++ b/.github/workflows/sonatype.yaml @@ -17,7 +17,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Deploy to Sonatype - run: ./mvnw deploy -DskipTests -B --no-transfer-progress --settings ./.mvn/settings.xml + run: ./mvnw deploy -DskipTests -B -V --no-transfer-progress --settings ./.mvn/settings.xml env: CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }} CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }} From 361bbe48ed0c0c06c339f3c0ce5d48e115dbe7c7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 19:13:38 -0500 Subject: [PATCH 0872/1013] [actions] Fix maven wrapper pull as variable changed to simply maven --- .github/workflows/it-maven339.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index 4cd2bdd31..8f39566f6 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -33,7 +33,7 @@ jobs: java-version: 17 distribution: 'zulu' - name: Load Maven 3.3.9 - run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -DmavenVersion=3.3.9 --no-transfer-progress + run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -Dmaven=3.3.9 --no-transfer-progress - name: Build Setup run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9 --no-transfer-progress - name: Integration Test with Maven From 92cf86ec4604ce53eada49ef622c3a6a9043d056 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 19:20:47 -0500 Subject: [PATCH 0873/1013] [actions] Remove no transfer progress from older maven as it doesn't understand it --- .github/workflows/it-maven339.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index 8f39566f6..af599d630 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -35,6 +35,6 @@ jobs: - name: Load Maven 3.3.9 run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -Dmaven=3.3.9 --no-transfer-progress - name: Build Setup - run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9 --no-transfer-progress + run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9 - name: Integration Test with Maven - run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress + run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 From e2a09d3de10a1dacb6be8792af96dde60049ea02 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Wed, 15 Feb 2023 19:23:23 -0500 Subject: [PATCH 0874/1013] [actions] Set min maven version to 3.3.9 --- .github/workflows/it-maven339.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml index af599d630..edd135b41 100644 --- a/.github/workflows/it-maven339.yaml +++ b/.github/workflows/it-maven339.yaml @@ -37,4 +37,4 @@ jobs: - name: Build Setup run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9 - name: Integration Test with Maven - run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 + run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dmaven.min-version=3.3.9 From 5bffcdcb28591020f4794750ff2becfb0358dbd2 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Feb 2023 19:18:17 -0500 Subject: [PATCH 0875/1013] [ci] Remove redundant public on URL in spot bugs info groovy class --- src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy index 4e7721cc9..2be43c7b6 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy @@ -84,7 +84,7 @@ interface SpotBugsInfo { static final EOL = "\n" - public static final String URL = "url" + static final String URL = "url" static final String CLASS_SUFFIX = '.class' From a446d71b7e501421d6243445720db592986bea82 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Feb 2023 22:33:26 -0500 Subject: [PATCH 0876/1013] [ci] Cleanup javadocs --- .../mojo/spotbugs/SpotBugsMojo.groovy | 74 ++----------------- 1 file changed, 7 insertions(+), 67 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index cd44d4263..565cc2931 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -74,6 +74,11 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(defaultValue = "false", property = "spotbugs.sarifOutput", required = true) boolean sarifOutput + /** + * Sarif full Path used with sarif. + * + * @since 4.3.1 + */ @Parameter(defaultValue = "false", property = "spotbugs.sarifFullPath", required = true) boolean sarifFullPath @@ -87,7 +92,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** - * Set the name of the output SARIF file produced + * Set the name of the output SARIF file produced. * * @since 4.7.2.2 */ @@ -142,28 +147,24 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Directory containing the test class files for Spotbugs to analyze. - * */ @Parameter(defaultValue = '${project.build.testOutputDirectory}', required = true) File testClassFilesDirectory /** * Location of the Xrefs to link to. - * */ @Parameter(defaultValue = '${project.reporting.outputDirectory}/xref') File xrefLocation /** * Location of the Test Xrefs to link to. - * */ @Parameter(defaultValue = '${project.reporting.outputDirectory}/xref-test') File xrefTestLocation /** * The directories containing the sources to be compiled. - * */ @Parameter(defaultValue = '${project.compileSourceRoots}', required = true, readonly = true) List compileSourceRoots @@ -186,14 +187,12 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Run Spotbugs with -sourcepath parameter populated with the known source roots. - * */ @Parameter(defaultValue = "false", property = "spotbugs.addSourceDirs") boolean addSourceDirs /** * List of artifacts this plugin depends on. Used for resolving the Spotbugs core plugin. - * */ @Parameter(property = "plugin.artifacts", required = true, readonly = true) List pluginArtifacts @@ -207,14 +206,12 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * The local repository, needed to download the coreplugin jar. - * */ @Parameter(property = "localRepository", required = true, readonly = true) ArtifactRepository localRepository /** * Remote repositories which will be searched for the coreplugin jar. - * */ @Parameter(property = "project.remoteArtifactRepositories", required = true, readonly = true) List remoteArtifactRepositories @@ -227,14 +224,12 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Maven Project. - * */ @Parameter(property = "project", required = true, readonly = true) MavenProject project /** * Encoding used for xml files. Default value is UTF-8. - * */ @Parameter(defaultValue = "UTF-8", readonly = true) String xmlEncoding @@ -259,7 +254,6 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Threshold of minimum bug severity to report. Valid values are High, Default, Low, Ignore, and Exp (for experimental). - * */ @Parameter(defaultValue = "Default", property = "spotbugs.threshold") String threshold @@ -272,27 +266,20 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Used to look up Artifacts in the remote repository. - * */ @Component(role = RepositorySystem.class) RepositorySystem factory /** - *

* File name of the include filter. Only bugs in matching the filters are reported. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. * It supports multiple files separated by a comma - *

* * @since 1.0-beta-1 */ @@ -300,25 +287,17 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String includeFilterFile /** - *

* File name for include filter files. Only bugs in matching the filters are reported. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This is an alternative to <includeFilterFile> which allows multiple * files to be specified as separate elements in a pom. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. - *

* * @since 4.7.1.0 */ @@ -326,21 +305,15 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { List includeFilterFiles /** - *

* File name of the exclude filter. Bugs matching the filters are not reported. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. * It supports multiple files separated by a comma - *

* * @since 1.0-beta-1 */ @@ -348,21 +321,15 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String excludeFilterFile /** - *

* File name for exclude filter files. Bugs matching the filters are not reported. - *

- * *

* This is an alternative to <excludeFilterFile> which allows multiple * files to be specified as separate elements in a pom. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. - *

* * @since 4.7.1.0 */ @@ -370,21 +337,15 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { List excludeFilterFiles /** - *

* File names of the baseline files. Bugs found in the baseline files won't be reported. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. - *

- * + *

* This is a comma-delimited list. * * @since 2.4.1 @@ -393,25 +354,17 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String excludeBugsFile /** - *

* File names of the baseline files. Bugs found in the baseline files won't be reported. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This is an alternative to <excludeBugsFile> which allows multiple * files to be specified as separate elements in a pom. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a filter file. - *

* * @since 4.7.1.0 */ @@ -459,20 +412,14 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String omitVisitors /** - *

* The plugin list to include in the report. This is a comma-delimited list. - *

- * *

* Potential values are a filesystem path, a URL, or a classpath resource. - *

- * *

* This parameter is resolved as resource, URL, then file. If successfully * resolved, the contents of the configuration is copied into the * ${project.build.directory} * directory before being passed to Spotbugs as a plugin file. - *

* * @since 1.0-beta-1 */ @@ -480,11 +427,8 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String pluginList /** - *

* Collection of PluginArtifact to work on. (PluginArtifact contains groupId, artifactId, version, type.) * See Usage for details. - *

- * * * @since 2.4.1 */ @@ -586,9 +530,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { int timeout /** - *

* The arguments to pass to the forked VM (ignored if fork is disabled). - *

* * @since 2.4.1 */ @@ -618,9 +560,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String userPrefs /** - *

* System properties to set in the VM (or the forked VM if fork is enabled). - *

* * @since 4.3.0 */ From 17179b7636e95b488f6b69773556e24ab5e4592b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Feb 2023 21:12:17 -0500 Subject: [PATCH 0877/1013] [ci] Formatting --- .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 565cc2931..eb5259cf0 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -861,7 +861,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { ResourceHelper resourceHelper = new ResourceHelper(log, spotbugsXmlOutputDirectory, resourceManager) def args = new ArrayList() - if(userPrefs) { + if (userPrefs) { log.debug(" Adding User Preferences File -> ${userPrefs}" ) args << "-userPrefs" @@ -1230,7 +1230,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } - if(sarifTempFile && sarifOutput && sarifTempFile.size() > 0) { + if (sarifTempFile && sarifOutput && sarifTempFile.size() > 0) { def slurpedResult = new JsonSlurper().parse(sarifTempFile) def builder = new JsonBuilder(slurpedResult) @@ -1254,7 +1254,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { String newFileName = indexer.searchActualFilesLocation(originalFullPath) if (newFileName != null) { - if(getLog().isDebugEnabled()) { + if (getLog().isDebugEnabled()) { getLog().info("$originalFullPath modified to $newFileName") } loc.physicalLocation.artifactLocation.uri = newFileName From 5e291b992954559f92e570a030c837cab83350b6 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Wed, 22 Feb 2023 00:51:39 +0000 Subject: [PATCH 0878/1013] Update dependency org.codehaus.mojo:versions-maven-plugin to v2.15.0 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 61ca30331..013f44b27 100644 --- a/pom.xml +++ b/pom.xml @@ -190,7 +190,7 @@ 1.13.0 3.12.1 3.6 - 2.14.2 + 2.15.0 false ${project.build.directory}/it-src-spotbugs From e3c6bb156ac5f732ca832a22cf9d595ab5c14fe4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Mon, 20 Feb 2023 22:43:36 -0500 Subject: [PATCH 0879/1013] [reports] Support running reports for xml and sarif split setup throughout so it is possible to run both now. --- .../mojo/spotbugs/SpotBugsMojo.groovy | 29 ++++++++++--------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index eb5259cf0..8d0f4266e 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -852,12 +852,13 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Get the Spotbugs command line arguments. * - * @param Spotbugs temp output file + * @param xmlTempFile Spotbugs xml temp output file + * @param sarifTempFile Spotbugs sarif temp output file * * @return Spotbugs command line arguments. * */ - private ArrayList getSpotbugsArgs(File tempFile) { + private ArrayList getSpotbugsArgs(File xmlTempFile, File sarifTempFile) { ResourceHelper resourceHelper = new ResourceHelper(log, spotbugsXmlOutputDirectory, resourceManager) def args = new ArrayList() @@ -868,11 +869,10 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << resourceHelper.getResourceFile(userPrefs.trim()) } - if(!sarifOutput) { - args << "-xml:withMessages=" + tempFile.getAbsolutePath() - } - else { - args << "-sarif=" + tempFile.getAbsolutePath() + args << "-xml:withMessages=" + xmlTempFile.getAbsolutePath() + + if (sarifOutput) { + args << "-sarif=" + sarifTempFile.getAbsolutePath() } args << "-projectName" @@ -1079,9 +1079,9 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { File sarifTempFile = new File("${project.build.directory}/spotbugsTempSarif.json") File sarifFinalFile = new File(sarifOutputDirectory, sarifOutputFilename) - if (xmlOutput || !sarifOutput) { - forceFileCreation(xmlTempFile) - } else { + forceFileCreation(xmlTempFile) + + if (sarifOutput) { forceFileCreation(sarifTempFile) } @@ -1100,7 +1100,10 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") log.debug("outputFile is ${outputFile.getCanonicalPath()}") log.debug("output Directory is ${spotbugsXmlOutputDirectory.getAbsolutePath()}") - log.debug("TempFile is ${(sarifOutput ? sarifTempFile : xmlTempFile).getCanonicalPath()}"); + log.debug("XmlTempFile is ${xmlTempFile.getCanonicalPath()}"); + if (sarifOutput) { + log.debug("SarifTempFile is ${sarifTempFile.getCanonicalPath()}"); + } } def ant = new AntBuilder() @@ -1111,7 +1114,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { startTime = System.nanoTime() } - def spotbugsArgs = !sarifOutput ? getSpotbugsArgs(xmlTempFile) : getSpotbugsArgs(sarifTempFile) + def spotbugsArgs = getSpotbugsArgs(xmlTempFile, sarifTempFile) def effectiveEncoding = System.getProperty("file.encoding", "UTF-8") @@ -1168,7 +1171,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.info("Done SpotBugs Analysis....") - if (xmlTempFile.exists() && !sarifOutput) { + if (xmlTempFile.exists()) { if (xmlTempFile.size() > 0) { def path = new XmlSlurper().parse(xmlTempFile) From 89ad8c2d3296d84d92eda7ca8fa0b5f1c7b7d9c7 Mon Sep 17 00:00:00 2001 From: Hielke de Vries Date: Wed, 22 Feb 2023 05:20:49 +0100 Subject: [PATCH 0880/1013] Feature/generate html reports (#161) * Add option for generating HTML reports * Try to add integration test * Use @pom.version instead of @project.version * Fix eol marker * [ci] Adjust formatting to that of original * [IT] Remove commented out code * [fix] Correct merge resolution mistake * [rework] Before applying this will rework original as it should allow multiple reports since spotbugs 4.5.0, we can run multiple reports so we should not limit to sarif or xml but rather open that up. The remainder of this tries to do similar that was done with those but just keeps the temp name for spotbugs html report which does work after fixing this up. Previously it was full of xml content as only thing done was to rename file. * [ci] Add javadoc for html report --------- Co-authored-by: Hielke de Vries Co-authored-by: Jeremy Landis --- src/it/html-report/invoker.properties | 4 ++ src/it/html-report/pom.xml | 45 +++++++++++++++++++ src/it/html-report/verify.groovy | 18 ++++++++ .../mojo/spotbugs/SpotBugsMojo.groovy | 31 +++++++++++-- 4 files changed, 94 insertions(+), 4 deletions(-) create mode 100644 src/it/html-report/invoker.properties create mode 100644 src/it/html-report/pom.xml create mode 100644 src/it/html-report/verify.groovy diff --git a/src/it/html-report/invoker.properties b/src/it/html-report/invoker.properties new file mode 100644 index 000000000..d5da9063b --- /dev/null +++ b/src/it/html-report/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/html-report/pom.xml b/src/it/html-report/pom.xml new file mode 100644 index 000000000..30f985909 --- /dev/null +++ b/src/it/html-report/pom.xml @@ -0,0 +1,45 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check + check + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + true + false + @spotbugsTestDebug@ + High + + + + + diff --git a/src/it/html-report/verify.groovy b/src/it/html-report/verify.groovy new file mode 100644 index 000000000..a5da449ac --- /dev/null +++ b/src/it/html-report/verify.groovy @@ -0,0 +1,18 @@ +/* + * Copyright (C) 2006-2017 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +File spotbugsHtml = new File(basedir, 'target/spotbugs.html') +assert spotbugsHtml.exists() diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 8d0f4266e..26dc226c0 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -64,6 +64,14 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { @Parameter(defaultValue = "false", property = "spotbugs.xmlOutput", required = true) boolean xmlOutput + /** + * Turn on and off HTML output of the Spotbugs report. + * + * @since 4.7.3.1 + */ + @Parameter(defaultValue = "false", property = "spotbugs.htmlOutput", required = true) + boolean htmlOutput + /** * Turn on and off SARIF output of the Spotbugs report. * SARIF is a JSON format standardize for all code scanning tools. @@ -852,13 +860,14 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { /** * Get the Spotbugs command line arguments. * + * @param htmlTempFile Spotbugs html temp output file * @param xmlTempFile Spotbugs xml temp output file * @param sarifTempFile Spotbugs sarif temp output file * * @return Spotbugs command line arguments. * */ - private ArrayList getSpotbugsArgs(File xmlTempFile, File sarifTempFile) { + private ArrayList getSpotbugsArgs(File htmlTempFile, File xmlTempFile, File sarifTempFile) { ResourceHelper resourceHelper = new ResourceHelper(log, spotbugsXmlOutputDirectory, resourceManager) def args = new ArrayList() @@ -869,6 +878,10 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << resourceHelper.getResourceFile(userPrefs.trim()) } + if (htmlOutput) { + args << "-html=" + htmlTempFile.getAbsolutePath() + } + args << "-xml:withMessages=" + xmlTempFile.getAbsolutePath() if (sarifOutput) { @@ -1075,17 +1088,21 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { long startTime long duration + File htmlTempFile = new File("${project.build.directory}/spotbugs.html") File xmlTempFile = new File("${project.build.directory}/spotbugsTemp.xml") File sarifTempFile = new File("${project.build.directory}/spotbugsTempSarif.json") File sarifFinalFile = new File(sarifOutputDirectory, sarifOutputFilename) + if (htmlOutput) { + forceFileCreation(htmlTempFile) + } + forceFileCreation(xmlTempFile) if (sarifOutput) { forceFileCreation(sarifTempFile) } - outputEncoding = outputEncoding ?: 'UTF-8' log.debug("****** Executing SpotBugsMojo *******") @@ -1100,6 +1117,9 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.debug("Plugin Artifacts to be added -> ${pluginArtifacts.toString()}") log.debug("outputFile is ${outputFile.getCanonicalPath()}") log.debug("output Directory is ${spotbugsXmlOutputDirectory.getAbsolutePath()}") + if (htmlOutput) { + log.debug("HtmlTempFile is ${htmlTempFile.getCanonicalPath()}"); + } log.debug("XmlTempFile is ${xmlTempFile.getCanonicalPath()}"); if (sarifOutput) { log.debug("SarifTempFile is ${sarifTempFile.getCanonicalPath()}"); @@ -1114,7 +1134,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { startTime = System.nanoTime() } - def spotbugsArgs = getSpotbugsArgs(xmlTempFile, sarifTempFile) + def spotbugsArgs = getSpotbugsArgs(htmlTempFile, xmlTempFile, sarifTempFile) def effectiveEncoding = System.getProperty("file.encoding", "UTF-8") @@ -1171,8 +1191,11 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { log.info("Done SpotBugs Analysis....") - if (xmlTempFile.exists()) { + if (htmlTempFile.exists() && htmlOutput && htmlTempFile.size() > 0) { + // Do nothing more at this time + } + if (xmlTempFile.exists()) { if (xmlTempFile.size() > 0) { def path = new XmlSlurper().parse(xmlTempFile) From c399e99d424f02236e33ce791ad48b6582f694fa Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 23 Feb 2023 21:38:32 -0500 Subject: [PATCH 0881/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.3.1 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 013f44b27..3fc462d48 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.1-SNAPSHOT + 4.7.3.1 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.3.1 Github @@ -147,7 +147,7 @@ ${project.version} - 1667846445 + 1677206281 4.7.3 From 13542b8b97c04067e4e632a75bfb656773653400 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Thu, 23 Feb 2023 21:38:35 -0500 Subject: [PATCH 0882/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 3fc462d48..2fe9abb7f 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.1 + 4.7.3.2-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.3.1 + HEAD Github @@ -147,7 +147,7 @@ ${project.version} - 1677206281 + 1677206314 4.7.3 From 6a9bb44b3614a5d001e2854944b44e6c3f7541f0 Mon Sep 17 00:00:00 2001 From: Gabor Garancsi Date: Fri, 24 Feb 2023 12:38:07 +0100 Subject: [PATCH 0883/1013] #549 Pass the auxiliary classpath using the -auxclasspathFromFile argument The plugin versions before 4.7.3.1 passed the auxiliary classpath via the standard input, which caused a deadlock during parallel builds with non-forked spotbugs. #488 Although this was fixed by removing the -auxclasspathFromInput, this broke the classpath logic. The solution is to pass the classpath using a file. --- .../mojo/spotbugs/SpotBugsMojo.groovy | 31 ++++++++++--------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy index 26dc226c0..5cbaffa51 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy @@ -870,6 +870,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { private ArrayList getSpotbugsArgs(File htmlTempFile, File xmlTempFile, File sarifTempFile) { ResourceHelper resourceHelper = new ResourceHelper(log, spotbugsXmlOutputDirectory, resourceManager) def args = new ArrayList() + def auxClasspathFile = createSpotbugsAuxClasspathFile() if (userPrefs) { log.debug(" Adding User Preferences File -> ${userPrefs}" ) @@ -888,6 +889,11 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { args << "-sarif=" + sarifTempFile.getAbsolutePath() } + if (auxClasspathFile) { + args << "-auxclasspathFromFile" + args << auxClasspathFile.getAbsolutePath() + } + args << "-projectName" args << "${project.name}" @@ -1022,42 +1028,37 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { } /** - * Get the Spotbugs AuxClasspath. + * Create the Spotbugs AuxClasspath file. * */ - private String getSpotbugsAuxClasspath() { + private File createSpotbugsAuxClasspathFile() { def auxClasspathElements - if (classFilesDirectory.exists() && classFilesDirectory.isDirectory()) { - auxClasspathElements = project.compileClasspathElements - } - if (testClassFilesDirectory.exists() && testClassFilesDirectory.isDirectory() && includeTests) { auxClasspathElements = project.testClasspathElements + } else if (classFilesDirectory.exists() && classFilesDirectory.isDirectory()) { + auxClasspathElements = project.compileClasspathElements } - def auxClasspath = "" + File auxClasspathFile = null if (auxClasspathElements) { + auxClasspathFile = File.createTempFile("auxclasspath", ".tmp") + auxClasspathFile.deleteOnExit() log.debug(" AuxClasspath Elements ->" + auxClasspathElements) def auxClasspathList = auxClasspathElements.findAll { project.build.outputDirectory != it.toString() } if (auxClasspathList.size() > 0) { - - auxClasspath += File.pathSeparator - log.debug(" Last AuxClasspath is ->" + auxClasspathList[auxClasspathList.size() - 1]) auxClasspathList.each() { auxClasspathElement -> log.debug(" Adding to AuxClasspath ->" + auxClasspathElement.toString()) - auxClasspath += auxClasspathElement.toString() + File.pathSeparator + auxClasspathFile << auxClasspathElement.toString() + "\n" } } } - log.debug(" AuxClasspath is ->" + auxClasspath) - - return auxClasspath + return auxClasspathFile } /** @@ -1142,7 +1143,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait { effectiveEncoding = sourceEncoding } - ant.java(classname: "edu.umd.cs.findbugs.FindBugs2", inputstring: getSpotbugsAuxClasspath(), fork: "${fork}", failonerror: "true", clonevm: "false", timeout: "${timeout}", maxmemory: "${maxHeap}m") { + ant.java(classname: "edu.umd.cs.findbugs.FindBugs2", fork: "${fork}", failonerror: "true", clonevm: "false", timeout: "${timeout}", maxmemory: "${maxHeap}m") { log.debug("File Encoding is " + effectiveEncoding) From 6ac7bf32b8225f5292954a067aafd353ad5e9e44 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 16:15:37 -0500 Subject: [PATCH 0884/1013] [pom] Bump base-parent to 38 (#552) --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 2fe9abb7f..00dcf61d7 100644 --- a/pom.xml +++ b/pom.xml @@ -5,7 +5,7 @@ com.github.hazendaz base-parent - 37 + 38 From b4ea4a70028626404f63273853c43dfebc7f6a9f Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 16:15:31 -0500 Subject: [PATCH 0885/1013] [tests] Add integration test to check file open issues per #517 Test simply runs through clean at end to ensure files not still open. Using 4.7.3.0, I can repeat the reported issue. The issue is gone in 4.7.3.1 and likely related to the auxpath issue. --- src/it/verify-clean/invoker.properties | 4 ++ src/it/verify-clean/pom.xml | 59 ++++++++++++++++++++++++++ 2 files changed, 63 insertions(+) create mode 100644 src/it/verify-clean/invoker.properties create mode 100644 src/it/verify-clean/pom.xml diff --git a/src/it/verify-clean/invoker.properties b/src/it/verify-clean/invoker.properties new file mode 100644 index 000000000..32ee7246c --- /dev/null +++ b/src/it/verify-clean/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean verify package clean + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/verify-clean/pom.xml b/src/it/verify-clean/pom.xml new file mode 100644 index 000000000..e2e69cb66 --- /dev/null +++ b/src/it/verify-clean/pom.xml @@ -0,0 +1,59 @@ + + + + + 4.0.0 + + spotbugs-maven-plugin.it + common + testing + ../common.xml + + check + check + jar + + + + com.github.spotbugs + spotbugs-maven-plugin + + true + false + @spotbugsTestDebug@ + High + + + + run-analysis + process-classes + + spotbugs + + + + process-results + + verify + + + + + + + From a613a51776adc63c2d885f8a486889ec0781f31b Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 17:40:01 -0500 Subject: [PATCH 0886/1013] [tests] Add check that we are not missing classes for analysis Test ensures issue with aux path fix in 4.7.3.1 does not resurface. Confirmed this test will fail with usage of 4.7.3.1 but is fixed now on latest. --- .../invoker.properties | 4 ++ src/it/check-no-missing-classes/pom.xml | 70 +++++++++++++++++++ .../src/main/java/test/App.java | 14 ++++ src/it/check-no-missing-classes/verify.groovy | 21 ++++++ 4 files changed, 109 insertions(+) create mode 100644 src/it/check-no-missing-classes/invoker.properties create mode 100644 src/it/check-no-missing-classes/pom.xml create mode 100644 src/it/check-no-missing-classes/src/main/java/test/App.java create mode 100644 src/it/check-no-missing-classes/verify.groovy diff --git a/src/it/check-no-missing-classes/invoker.properties b/src/it/check-no-missing-classes/invoker.properties new file mode 100644 index 000000000..d5da9063b --- /dev/null +++ b/src/it/check-no-missing-classes/invoker.properties @@ -0,0 +1,4 @@ +invoker.goals = clean compile spotbugs:check + +# The expected result of the build, possible values are "success" (default) and "failure" +invoker.buildResult = success diff --git a/src/it/check-no-missing-classes/pom.xml b/src/it/check-no-missing-classes/pom.xml new file mode 100644 index 000000000..02e01db6c --- /dev/null +++ b/src/it/check-no-missing-classes/pom.xml @@ -0,0 +1,70 @@ + + + + 4.0.0 + + spotbugs-maven-plugin.it + check-no-missing-classes + testing + check-no-missing-classes + jar + + + org.junit.jupiter + junit-jupiter-engine + @junitVersion@ + + + + + + com.github.spotbugs + spotbugs-maven-plugin + @pom.version@ + + true + false + @spotbugsTestDebug@ + High + + + + run-analysis + process-classes + + spotbugs + + + + process-results + + verify + + + + + + + diff --git a/src/it/check-no-missing-classes/src/main/java/test/App.java b/src/it/check-no-missing-classes/src/main/java/test/App.java new file mode 100644 index 000000000..e4c6765b8 --- /dev/null +++ b/src/it/check-no-missing-classes/src/main/java/test/App.java @@ -0,0 +1,14 @@ +package test; + +import org.junit.jupiter.api.Assertions; + +/** + * Hello world! + */ +public class App { + + public static void main( String[] args ) { + Assertions.assertNull(args); + System.out.println( "Hello World!" ); + } +} diff --git a/src/it/check-no-missing-classes/verify.groovy b/src/it/check-no-missing-classes/verify.groovy new file mode 100644 index 000000000..14f621bf1 --- /dev/null +++ b/src/it/check-no-missing-classes/verify.groovy @@ -0,0 +1,21 @@ +/* + * Copyright (C) 2006-2020 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +// Check no missing classes + +File buildLog = new File( basedir, 'build.log' ) +assert !buildLog.text.contains( 'The following classes needed for analysis were missing' ) + From 7f0dd1e3c0f059361fe4eb03736a40d57db73ec7 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 17:58:28 -0500 Subject: [PATCH 0887/1013] [test] Set new test to use jdk 8 --- src/it/check-no-missing-classes/pom.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/it/check-no-missing-classes/pom.xml b/src/it/check-no-missing-classes/pom.xml index 02e01db6c..0776017c2 100644 --- a/src/it/check-no-missing-classes/pom.xml +++ b/src/it/check-no-missing-classes/pom.xml @@ -30,6 +30,10 @@ testing check-no-missing-classes jar + + 1.8 + 1.8 + org.junit.jupiter From 52676c2c94613bca0ed0c977f48ef07ca76a7338 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 19:57:24 -0500 Subject: [PATCH 0888/1013] [fix] Resolve inner classes broken links per #236 --- .../mojo/spotbugs/SpotbugsReportGenerator.groovy | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy index 3b4fe5bc8..df50d2131 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy @@ -21,7 +21,10 @@ package org.codehaus.mojo.spotbugs import groovy.xml.slurpersupport.GPathResult +import org.apache.maven.doxia.markup.HtmlMarkup import org.apache.maven.doxia.sink.Sink +import org.apache.maven.doxia.sink.SinkEventAttributes +import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet import org.apache.maven.doxia.tools.SiteTool import org.apache.maven.plugin.logging.Log @@ -502,8 +505,10 @@ class SpotbugsReportGenerator implements SpotBugsInfo { log.debug("Opening Class Report Section") - sink.anchor(bugClass) - sink.anchor_() + // Dollar '$' for nested classes is not valid character in sink.anchor() and therefore it is ignored + // https://github.com/spotbugs/spotbugs-maven-plugin/issues/236 + sink.unknown(HtmlMarkup.A.toString(), new Object[] { HtmlMarkup.TAG_TYPE_START }, new SinkEventAttributeSet(SinkEventAttributes.NAME, bugClass)); + sink.unknown(HtmlMarkup.A.toString(), new Object[] { HtmlMarkup.TAG_TYPE_END }, null); sink.section2() sink.sectionTitle2() From 5dcdfd1aee3f05fc7632f9bb2a39695b988c8623 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 20:22:28 -0500 Subject: [PATCH 0889/1013] [maven-release-plugin] prepare release spotbugs-maven-plugin-4.7.3.2 --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 00dcf61d7..747229536 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.2-SNAPSHOT + 4.7.3.2 maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - HEAD + spotbugs-maven-plugin-4.7.3.2 Github @@ -147,7 +147,7 @@ ${project.version} - 1677206314 + 1677374534 4.7.3 From 0617640693babb589f39db37508ae5d314c01d30 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sat, 25 Feb 2023 20:22:31 -0500 Subject: [PATCH 0890/1013] [maven-release-plugin] prepare for next development iteration --- pom.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pom.xml b/pom.xml index 747229536..8c5c340aa 100644 --- a/pom.xml +++ b/pom.xml @@ -11,7 +11,7 @@ com.github.spotbugs spotbugs-maven-plugin - 4.7.3.2 + 4.7.3.3-SNAPSHOT maven-plugin SpotBugs Maven Plugin @@ -124,7 +124,7 @@ scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git https://github.com/spotbugs/spotbugs-maven-plugin - spotbugs-maven-plugin-4.7.3.2 + HEAD Github @@ -147,7 +147,7 @@ ${project.version} - 1677374534 + 1677374551 4.7.3 From 90b2b20c88cf188308ae9e28d173883c849b367a Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Mon, 27 Feb 2023 09:57:31 +0000 Subject: [PATCH 0891/1013] Update pluginPluginVersion to v3.8.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 8c5c340aa..ea1f82b4d 100644 --- a/pom.xml +++ b/pom.xml @@ -186,7 +186,7 @@ 3.4.2 3.5.0 3.5.0 - 3.7.1 + 3.8.1 1.13.0 3.12.1 3.6 From 33854e371304738b29fe94ade26360078742136b Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Tue, 28 Feb 2023 17:02:47 +0000 Subject: [PATCH 0892/1013] Update dependency com.github.javaparser:javaparser-core to v3.25.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index ea1f82b4d..6c0677659 100644 --- a/pom.xml +++ b/pom.xml @@ -162,7 +162,7 @@ 1.10.13 4.0.7 - 3.25.0 + 3.25.1 1.12.0 1.11.1 From 6a0f0a2f9008c40d626ec8f1c74aeed7ddd140ca Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 2 Mar 2023 05:22:47 +0000 Subject: [PATCH 0893/1013] Update dependency org.codehaus.plexus:plexus-utils to v3.5.1 --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 6c0677659..52b0fa8c3 100644 --- a/pom.xml +++ b/pom.xml @@ -177,7 +177,7 @@ 2.1.1 1.2.0 - 3.5.0 + 3.5.1 3.1.0 1.0.0 From 375ffc8e134d89497c421b922c9b2030173e3ca7 Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Sun, 12 Mar 2023 09:51:16 +0000 Subject: [PATCH 0894/1013] Update groovy monorepo --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 52b0fa8c3..62778c744 100644 --- a/pom.xml +++ b/pom.xml @@ -161,7 +161,7 @@ 2.0.6 1.10.13 - 4.0.7 + 4.0.10 3.25.1 1.12.0 From ce7941f4d572334c4844314f17e160fcd78649b4 Mon Sep 17 00:00:00 2001 From: Jeremy Landis Date: Sun, 12 Mar 2023 15:01:56 -0400 Subject: [PATCH 0895/1013] [ci] Trim whitespace --- README.md | 4 +- src/it/check-fail/verify.groovy | 2 +- src/it/check-no-missing-classes/verify.groovy | 2 +- src/it/systemPropertyVariables/verify.groovy | 2 +- src/it/verify-fail/verify.groovy | 2 +- .../codehaus/mojo/spotbugs/SpotBugsGui.groovy | 2 +- .../codehaus/mojo/spotbugs/VerifyMojo.groovy | 4 +- src/site/resources/examples/spotbugs.html | 22 ++--- .../spotbugs-maven-plugin/it/App.html | 14 +-- .../spotbugs-maven-plugin/it/FooTest.html | 12 +-- .../it/package-summary.html | 6 +- .../examples/xref-test/overview-summary.html | 8 +- .../xref/AbstractMissingHashCode.html | 6 +- .../AccidentalNonConstructorInInnerClass.html | 16 ++-- .../examples/xref/AnnotationTest.html | 2 +- .../xref/AppendingToAnObjectOutputStream.html | 8 +- .../examples/xref/ArrayToString.html | 18 ++-- .../examples/xref/AssignedOnlyInCtor.html | 6 +- .../examples/xref/AssumeUnsignedBytes.html | 4 +- .../resources/examples/xref/UseInitCause.html | 8 +- ...OfNonHashableClassInHashDataStructure.html | 12 +-- .../examples/xref/UselessAssignments.html | 12 +-- .../examples/xref/UselessControlFlow.html | 14 +-- .../examples/xref/UselessCurrentThread.html | 12 +-- .../examples/xref/UselessSCMethods.html | 20 ++-- .../examples/xref/UserAss3rtion.html | 2 +- .../resources/examples/xref/UserMistakes.html | 28 +++--- .../examples/xref/badNaming/package1/A.html | 4 +- .../badNaming/package1/package-summary.html | 6 +- .../examples/xref/badNaming/package2/A.html | 4 +- .../xref/badNaming/package2/AnInterface.html | 4 +- .../badNaming/package2/package-summary.html | 6 +- .../examples/xref/equals/ArrayEquality.html | 10 +- .../examples/xref/equals/package-summary.html | 6 +- .../AllListsCouldBeEqual.html | 72 +++++++------- .../gcUnrelatedTypes/ArrayListContains.html | 96 +++++++++---------- .../gcUnrelatedTypes/ArrayListContains0.html | 74 +++++++------- .../gcUnrelatedTypes/package-summary.html | 6 +- .../examples/xref/jsr305/AlwaysBlue.html | 8 +- .../examples/xref/jsr305/package-summary.html | 6 +- .../examples/xref/npe/AtomicFieldUpdater.html | 22 ++--- .../examples/xref/npe/UseCheckUse.html | 6 +- .../examples/xref/npe/package-summary.html | 6 +- .../nullnessAnnotations/UseAnnotations.html | 12 +-- .../nullnessAnnotations/package-summary.html | 6 +- .../obligation/UsesWillCloseAnnotation.html | 12 +-- .../xref/obligation/package-summary.html | 6 +- .../examples/xref/overview-summary.html | 8 +- .../examples/xref/package-summary.html | 6 +- .../xref/uselessThread/UsefulThread.html | 4 +- .../xref/uselessThread/package-summary.html | 6 +- 51 files changed, 322 insertions(+), 322 deletions(-) diff --git a/README.md b/README.md index 2ed52ee64..7377cd922 100644 --- a/README.md +++ b/README.md @@ -51,7 +51,7 @@ mvn -DtestSrc=remote -Prun-its -Dinvoker.test=build-*,basic-1,check-nofail clean Run tests in debugger ``` -mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000 -Xnoagent -Djava.compiler=NONE" -Prun-its clean install +mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000 -Xnoagent -Djava.compiler=NONE" -Prun-its clean install ``` Run selected tests in debugger @@ -61,7 +61,7 @@ mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspe Run gui with a specific version ``` -mvn com.github.spotbugs:spotbugs-maven-plugin:4.0.0:gui +mvn com.github.spotbugs:spotbugs-maven-plugin:4.0.0:gui ``` ## Contributing ## diff --git a/src/it/check-fail/verify.groovy b/src/it/check-fail/verify.groovy index c509ec221..d5aea13e7 100644 --- a/src/it/check-fail/verify.groovy +++ b/src/it/check-fail/verify.groovy @@ -15,4 +15,4 @@ */ File buildLog = new File( basedir, 'build.log' ) -assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) +assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/it/check-no-missing-classes/verify.groovy b/src/it/check-no-missing-classes/verify.groovy index 14f621bf1..16739ac4d 100644 --- a/src/it/check-no-missing-classes/verify.groovy +++ b/src/it/check-no-missing-classes/verify.groovy @@ -17,5 +17,5 @@ // Check no missing classes File buildLog = new File( basedir, 'build.log' ) -assert !buildLog.text.contains( 'The following classes needed for analysis were missing' ) +assert !buildLog.text.contains( 'The following classes needed for analysis were missing' ) diff --git a/src/it/systemPropertyVariables/verify.groovy b/src/it/systemPropertyVariables/verify.groovy index 1d5d6a834..d6efc030f 100644 --- a/src/it/systemPropertyVariables/verify.groovy +++ b/src/it/systemPropertyVariables/verify.groovy @@ -15,4 +15,4 @@ */ File buildLog = new File( basedir, 'build.log' ) -assert buildLog.text.contains( '[java] INFO: System variables are considered to be tainted' ) +assert buildLog.text.contains( '[java] INFO: System variables are considered to be tainted' ) diff --git a/src/it/verify-fail/verify.groovy b/src/it/verify-fail/verify.groovy index c509ec221..d5aea13e7 100644 --- a/src/it/verify-fail/verify.groovy +++ b/src/it/verify-fail/verify.groovy @@ -15,4 +15,4 @@ */ File buildLog = new File( basedir, 'build.log' ) -assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) +assert buildLog.text.contains( '[ERROR] High: Found reliance on default encoding in UserMistakes' ) diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy index cd1d65194..dba282cde 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsGui.groovy @@ -131,7 +131,7 @@ class SpotBugsGui extends AbstractMojo implements SpotBugsPluginsTrait { */ @Parameter (defaultValue = '${session}', required = true, readonly = true) MavenSession session; - + /** * Maven Project. * diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy index 9b8bb966f..5be99611f 100644 --- a/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy +++ b/src/main/groovy/org/codehaus/mojo/spotbugs/VerifyMojo.groovy @@ -25,8 +25,8 @@ import org.apache.maven.plugins.annotations.ResolutionScope /** * Fail the build if any SpotBugs violations can be found in a preexisting {@code spotBugs.xml} file. - * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. - * This way, it is possible to split the analysis and verification into lifecycle phases of one's choosing. + * Note that unlike the {@code check} goal, this goal only reads existing XML reports, without actually performing SpotBugs analysis. + * This way, it is possible to split the analysis and verification into lifecycle phases of one's choosing. * One use case for that is running multiple code analyzers at once and only failing the build at a later stage, so that all of them have a chance to run. * To see more documentation about SpotBugs' options, please see the SpotBugs Manual.. * diff --git a/src/site/resources/examples/spotbugs.html b/src/site/resources/examples/spotbugs.html index 715924066..5298f13a1 100644 --- a/src/site/resources/examples/spotbugs.html +++ b/src/site/resources/examples/spotbugs.html @@ -13,7 +13,7 @@ - +

Class Summary
Class SummaryClass Summary
@@ -49,7 +49,7 @@

Package com.github.spotbugs.spotbugs-maven-plugin.it

- +
  • @@ -73,4 +73,4 @@

    Package com.github.spotbugs.spotbugs-maven-plugin.it

    Copyright © 2020. All rights reserved.
- \ No newline at end of file + diff --git a/src/site/resources/examples/xref-test/overview-summary.html b/src/site/resources/examples/xref-test/overview-summary.html index e4a7c9f5d..a4f57df46 100644 --- a/src/site/resources/examples/xref-test/overview-summary.html +++ b/src/site/resources/examples/xref-test/overview-summary.html @@ -24,7 +24,7 @@
- +

basic-1 testing Reference

@@ -42,7 +42,7 @@

basic-1 testing Reference

- +
  • Overview
    • @@ -59,10 +59,10 @@

    basic-1 testing Reference

- +
- \ No newline at end of file + diff --git a/src/site/resources/examples/xref/AbstractMissingHashCode.html b/src/site/resources/examples/xref/AbstractMissingHashCode.html index 1a41d526a..2f84c796c 100644 --- a/src/site/resources/examples/xref/AbstractMissingHashCode.html +++ b/src/site/resources/examples/xref/AbstractMissingHashCode.html @@ -9,17 +9,17 @@ 
 1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
+2
 3   abstract class AbstractMissingHashCode {
 4   	int x;
-5   
+5
 6   	@Override
 7   	public boolean equals(Object o) {
 8   		if (!(o instanceof AbstractMissingHashCode))
 9   			return false;
 10  		return x == ((AbstractMissingHashCode) o).x;
 11  	}
-12  
+12
 13  	@ExpectWarning("HE")
 14  	static class StillMissingHashCode extends AbstractMissingHashCode {
 15  		int y;
diff --git a/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html b/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html
index 0285ac7dd..a0d512c8e 100644
--- a/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html
+++ b/src/site/resources/examples/xref/AccidentalNonConstructorInInnerClass.html
@@ -9,40 +9,40 @@
 
 
 1   public class AccidentalNonConstructorInInnerClass {
-2   
+2
 3   	class Report {
 4   		void Report() {
 5   		};
-6   
+6
 7   		class DeeplyNested {
 8   			void DeeplyNested() {
 9   			};
 10  		}
 11  	}
-12  
+12
 13  	static class Report2 {
 14  		void Report2() {
 15  		};
 16  	}
-17  
+17
 18  	class DoNotReport {
 19  		@Deprecated
 20  		void DoNotReport() {
 21  		}
-22  
+22
 23  		DoNotReport() {
 24  		}
 25  	}
-26  
+26
 27  	static class DoNotReport2 {
 28  		void DoNotReport2() {
 29  			throw new UnsupportedOperationException();
 30  		}
-31  
+31
 32  		DoNotReport2() {
 33  		}
 34  	}
-35  
+35
 36  }
 

 

diff --git a/src/site/resources/examples/xref/AnnotationTest.html b/src/site/resources/examples/xref/AnnotationTest.html
index b42aaf5f3..37ba4f703 100644
--- a/src/site/resources/examples/xref/AnnotationTest.html
+++ b/src/site/resources/examples/xref/AnnotationTest.html
@@ -10,7 +10,7 @@
 
 1   import edu.umd.cs.findbugs.annotations.CheckReturnValue;
 2   import edu.umd.cs.findbugs.annotations.Priority;
-3   
+3
 4   class AnnotationTest {
 5   	@CheckReturnValue(priority = Priority.HIGH)
 6   	int f() {
diff --git a/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html b/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html
index cb709e0dd..e4df20ce8 100644
--- a/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html
+++ b/src/site/resources/examples/xref/AppendingToAnObjectOutputStream.html
@@ -14,12 +14,12 @@
 4   import java.io.FileOutputStream;
 5   import java.io.IOException;
 6   import java.io.ObjectOutputStream;
-7   
+7
 8   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-9   
-10  
+9
+10
 11  public class AppendingToAnObjectOutputStream {
-12  	
+12
 13  	@ExpectWarning("IO")
 14  	public static void appendObject1(File f, Object o) throws FileNotFoundException, IOException {
 15  		ObjectOutputStream out = new ObjectOutputStream (new FileOutputStream(f, true));
diff --git a/src/site/resources/examples/xref/ArrayToString.html b/src/site/resources/examples/xref/ArrayToString.html
index 935156040..43d106580 100644
--- a/src/site/resources/examples/xref/ArrayToString.html
+++ b/src/site/resources/examples/xref/ArrayToString.html
@@ -9,12 +9,12 @@
 
 
 1   import edu.umd.cs.findbugs.annotations.DesireWarning;
-2   
-3   
+2
+3
 4   public class ArrayToString {
-5   	
+5
 6   	private static final String[] gargs = new String[] {"1", "2"};
-7   	
+7
 8   	public static void main(String[] args) {
 9   		ArrayToString a = new ArrayToString();
 10  		a.print0(args);
@@ -22,23 +22,23 @@
 12  		a.print2();
 13  		a.print3();
 14  	}
-15  	
+15
 16  	@DesireWarning("DMI")
 17  	public void print0(String args[]) {
 18  		System.out.println(args.toString());
 19  	}
-20  
+20
 21  	@DesireWarning("DMI")
 22  	public void print1() {
 23  		String [] args2 = new String[] {"Hello", "there"};
 24  		System.out.println(args2.toString());
 25  	}
-26  
+26
 27  	@DesireWarning("DMI")
 28  	public void print2() {
-29  		System.out.println((new String[] {"one","two"}).toString());		
+29  		System.out.println((new String[] {"one","two"}).toString());
 30  	}
-31  
+31
 32  	@DesireWarning("DMI")
 33  	public void print3() {
 34  		System.out.println(gargs.toString());
diff --git a/src/site/resources/examples/xref/AssignedOnlyInCtor.html b/src/site/resources/examples/xref/AssignedOnlyInCtor.html
index 2db619f3c..1323c699e 100644
--- a/src/site/resources/examples/xref/AssignedOnlyInCtor.html
+++ b/src/site/resources/examples/xref/AssignedOnlyInCtor.html
@@ -10,15 +10,15 @@
 
 1   public class AssignedOnlyInCtor {
 2   	private int value;
-3   
+3
 4   	public AssignedOnlyInCtor(int value) {
 5   		this.value = value;
 6   	}
-7   
+7
 8   	public int getValue() {
 9   		return value;
 10  	}
-11  
+11
 12  }
 

 

diff --git a/src/site/resources/examples/xref/AssumeUnsignedBytes.html b/src/site/resources/examples/xref/AssumeUnsignedBytes.html
index 1c9106340..9fd893b04 100644
--- a/src/site/resources/examples/xref/AssumeUnsignedBytes.html
+++ b/src/site/resources/examples/xref/AssumeUnsignedBytes.html
@@ -9,9 +9,9 @@
 
 
 1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
+2
 3   class AssumeUnsignedBytes {
-4   
+4
 5   	@ExpectWarning("INT")
 6   	int find200(byte[] b) {
 7   		for (int i = 0; i < b.length; i++)
diff --git a/src/site/resources/examples/xref/UseInitCause.html b/src/site/resources/examples/xref/UseInitCause.html
index f60f4a083..65de88d4a 100644
--- a/src/site/resources/examples/xref/UseInitCause.html
+++ b/src/site/resources/examples/xref/UseInitCause.html
@@ -10,10 +10,10 @@
 
 1   import java.io.BufferedReader;
 2   import java.io.IOException;
-3   
-4   
+3
+4
 5   public class UseInitCause {
-6   
+6
 7   	public String firstLine(BufferedReader r) {
 8   		try {
 9   			return r.readLine();
@@ -21,7 +21,7 @@
 11  			throw (RuntimeException) new RuntimeException("IO Error").initCause(e);
 12  		}
 13  	}
-14  
+14
 15  }
 

 

diff --git a/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html b/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html
index 5b2565d4a..f540c9470 100644
--- a/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html
+++ b/src/site/resources/examples/xref/UseOfNonHashableClassInHashDataStructure.html
@@ -9,13 +9,13 @@
 
 
 1   import java.util.HashMap;
-2   
+2
 3   public class UseOfNonHashableClassInHashDataStructure {
-4   
-5   
+4
+5
 6   	static class UMap extends HashMap<UseOfNonHashableClassInHashDataStructure, String> {};
 7   	static HashMap<UseOfNonHashableClassInHashDataStructure, String> m = new HashMap<UseOfNonHashableClassInHashDataStructure, String>();
-8   
+8
 9   	static int foo(HashMap<UseOfNonHashableClassInHashDataStructure, String> map) {
 10  		return map.size();
 11  	}
@@ -23,12 +23,12 @@
 13  	public boolean equals(Object o) {
 14  		return hashCode() == o.hashCode();
 15  	}
-16  
+16
 17  	public static String add(UseOfNonHashableClassInHashDataStructure b,
 18  			String s) {
 19  		return m.put(b, s);
 20  	}
-21  
+21
 22  	public static String get(UseOfNonHashableClassInHashDataStructure b) {
 23  		return m.get(b);
 24  	}
diff --git a/src/site/resources/examples/xref/UselessAssignments.html b/src/site/resources/examples/xref/UselessAssignments.html
index b6b6cad9c..11350f616 100644
--- a/src/site/resources/examples/xref/UselessAssignments.html
+++ b/src/site/resources/examples/xref/UselessAssignments.html
@@ -9,11 +9,11 @@
 
 
 1   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-2   
+2
 3   class UselessAssignments {
 4   	@ExpectWarning("UuF,UrF")
 5   	int foo, bar,g1,g2;
-6   
+6
 7   	@ExpectWarning("DLS,SA")
 8   	public UselessAssignments(int Foo, int Bar) {
 9   		int x,y;
@@ -22,12 +22,12 @@
 12  		g1 = g1 = 0;
 13  		x = x = 0;
 14  	}
-15  
+15
 16  	static void setFoo(UselessAssignments ua1, UselessAssignments ua2) {
 17  		ua1.foo = ua2.foo = 1;
 18  		ua1.bar = ua1.bar = ua1.bar = 2;
 19      }
-20  
+20
 21  	int oops() {
 22  		int i = 7;
 23          i = ++i;
@@ -36,14 +36,14 @@
 26  		foo = ++foo;
 27          return i;
 28  	}
-29  
+29
 30  	public static void report(UselessAssignments ua1, UselessAssignments ua2) {
 31  		ua1.foo = ua1.foo = ua1.foo = 17;
 32  	}
 33      public static void doNotReport(UselessAssignments ua1, UselessAssignments ua2) {
 34  		ua1.bar = ua2.bar = 42;
 35  	}
-36  
+36
 37  }
 

 

diff --git a/src/site/resources/examples/xref/UselessControlFlow.html b/src/site/resources/examples/xref/UselessControlFlow.html
index d603da56a..218eed31c 100644
--- a/src/site/resources/examples/xref/UselessControlFlow.html
+++ b/src/site/resources/examples/xref/UselessControlFlow.html
@@ -8,14 +8,14 @@
 
 
 
-1   
+1
 2   public class UselessControlFlow {
-3   
+3
 4   	void harmless1(Object x, Object y) {
 5   		if (!x.equals(y)) {
-6   
+6
 7   		} else {
-8   
+8
 9   		}
 10  		System.out.println(x);
 11  		System.out.println(y);
@@ -31,14 +31,14 @@
 21  	}
 22  	void report2(Object x, Object y) {
 23  		if (!x.equals(y));
-24  
+24
 25  		  System.out.println(x);
 26  		System.out.println(y);
 27  	}
 28  	void report3(Object x, Object y) {
 29  		if (!x.equals(y));
-30  
-31  
+30
+31
 32  		  System.out.println(x);
 33  		System.out.println(y);
 34  	}
diff --git a/src/site/resources/examples/xref/UselessCurrentThread.html b/src/site/resources/examples/xref/UselessCurrentThread.html
index 1d745631b..20251142c 100644
--- a/src/site/resources/examples/xref/UselessCurrentThread.html
+++ b/src/site/resources/examples/xref/UselessCurrentThread.html
@@ -8,14 +8,14 @@
 
 
 
-1   
+1
 2   public class UselessCurrentThread implements Runnable {
 3   	private Thread unknownThread;
-4   
+4
 5   	public UselessCurrentThread(Thread t) {
 6   		unknownThread = t;
 7   	}
-8   
+8
 9   	public void run() {
 10  		try {
 11  			// The first should be ok, the next two are silly, the third is
@@ -24,18 +24,18 @@
 14  				System.out.println("huh?");
 15  				Thread.sleep(10000);
 16  			}
-17  
+17
 18  			while (!Thread.currentThread().interrupted()) {
 19  				System.out.println("huh?");
 20  				Thread.sleep(10000);
 21  			}
-22  
+22
 23  			Thread t = Thread.currentThread();
 24  			while (!t.interrupted()) {
 25  				System.out.println("huh?");
 26  				Thread.sleep(10000);
 27  			}
-28  
+28
 29  			while (!unknownThread.interrupted()) {
 30  				System.out.println("huh?");
 31  				Thread.sleep(10000);
diff --git a/src/site/resources/examples/xref/UselessSCMethods.html b/src/site/resources/examples/xref/UselessSCMethods.html
index d5bd63dd8..8c5ddc8a2 100644
--- a/src/site/resources/examples/xref/UselessSCMethods.html
+++ b/src/site/resources/examples/xref/UselessSCMethods.html
@@ -8,49 +8,49 @@
 
 
 
-1   
+1
 2   class Super {
 3   	public void test1() {
 4   	}
-5   
+5
 6   	public int test2(String s) {
 7   		return 1;
 8   	}
-9   
+9
 10  	public double test3(double d, int i, Object o, float f, long l) {
 11  		return 0.0;
 12  	}
-13  
+13
 14  	protected void test4(String s) {
 15  	}
-16  
+16
 17  	public void test5(String[] s) {
 18  	}
 19  }
-20  
+20
 21  public class UselessSCMethods extends Super {
 22  	@Override
 23  	public void test1() {
 24  		super.test1();
 25  	}
-26  
+26
 27  	@Override
 28  	public int test2(String s) {
 29  		return super.test2(s);
 30  	}
-31  
+31
 32  	@Override
 33  	public double test3(double d, int i, Object o, float f, long l) {
 34  		return super.test3(d, i, o, f, l);
 35  	}
-36  
+36
 37  	@Override
 38  	public void test4(String s) { // don't report this, altho suspect, access
 39  									// has been widened
 40  		// perhaps this should be reported as another bug type, dunno
 41  		super.test4(s);
 42  	}
-43  
+43
 44  	@Override
 45  	public void test5(String[] s) {
 46  		super.test5(s);
diff --git a/src/site/resources/examples/xref/UserAss3rtion.html b/src/site/resources/examples/xref/UserAss3rtion.html
index 3c4a6a949..533fa211e 100644
--- a/src/site/resources/examples/xref/UserAss3rtion.html
+++ b/src/site/resources/examples/xref/UserAss3rtion.html
@@ -13,7 +13,7 @@
 3   		if (!cond)
 4   			throw new IllegalStateException();
 5   	}
-6   
+6
 7   	public void f(Object o) {
 8   		UserAss3rtion.makeSureItIsOK(o != null);
 9   		System.out.println(o.hashCode());
diff --git a/src/site/resources/examples/xref/UserMistakes.html b/src/site/resources/examples/xref/UserMistakes.html
index 83298dec0..27823f218 100644
--- a/src/site/resources/examples/xref/UserMistakes.html
+++ b/src/site/resources/examples/xref/UserMistakes.html
@@ -8,33 +8,33 @@
 
 
 
-1   
-2   
+1
+2
 3   import java.io.BufferedReader;
 4   import java.io.FileNotFoundException;
 5   import java.io.FileReader;
 6   import java.io.IOException;
 7   import java.io.LineNumberReader;
-8   
+8
 9   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-10  
+10
 11  public class UserMistakes {
 12  	@ExpectWarning("RE,RV")
 13  	public static void main(String[] args) throws IOException {
 14  		String id="Mr. Ed";
 15  		id=name.replaceAll(".", "s.");
 16  		System.out.println(name);
-17  
-18  
+17
+18
 19  		//FIXME:SpotBugs only catches this error with name.indexOf(String)
 20  		if (name.indexOf("s") > 0)
 21  			System.out.println("Yay");
 22  		else
 23  			System.out.println("Boo");
-24  
+24
 25  		String result;
-26  
-27  		try 
+26
+27  		try
 28  		{
 29  			BufferedReader findFiles=new BufferedReader(new FileReader("/mainList.txt"));
 30  			if (findFiles.readLine()!=null)
@@ -46,16 +46,16 @@
 36  		} catch (IOException e) {
 37  			e.printStackTrace();
 38  		}
-39  
-40  
-41  
+39
+40
+41
 42  		LineNumberReader tmp=new LineNumberReader(new FileReader("/mainList.txt"));
 43  		int count = 0;
 44  		while (tmp.readLine()!=null) count++;
-45            
+45
 46  		tmp.close();
 47  }
-48  
+48
 49  }
 

 

diff --git a/src/site/resources/examples/xref/badNaming/package1/A.html b/src/site/resources/examples/xref/badNaming/package1/A.html
index 4f3f19407..6788e9f41 100644
--- a/src/site/resources/examples/xref/badNaming/package1/A.html
+++ b/src/site/resources/examples/xref/badNaming/package1/A.html
@@ -9,9 +9,9 @@
 
 
 1   package badNaming.package1;
-2   
+2
 3   public class A {
-4   
+4
 5   }
 

 

diff --git a/src/site/resources/examples/xref/badNaming/package1/package-summary.html b/src/site/resources/examples/xref/badNaming/package1/package-summary.html
index 47edc4024..f8d6cbb85 100644
--- a/src/site/resources/examples/xref/badNaming/package1/package-summary.html
+++ b/src/site/resources/examples/xref/badNaming/package1/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package badNaming.package1

 
 		
@@ -44,7 +44,7 @@ 
Package badNaming.package1

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package badNaming.package1
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/badNaming/package2/A.html b/src/site/resources/examples/xref/badNaming/package2/A.html
index 58eb724f2..fda88b17a 100644
--- a/src/site/resources/examples/xref/badNaming/package2/A.html
+++ b/src/site/resources/examples/xref/badNaming/package2/A.html
@@ -9,9 +9,9 @@
 
 
 1   package badNaming.package2;
-2   
+2
 3   public class A {
-4   
+4
 5   }
 

 

diff --git a/src/site/resources/examples/xref/badNaming/package2/AnInterface.html b/src/site/resources/examples/xref/badNaming/package2/AnInterface.html
index 9fe2c5f5e..d19175e81 100644
--- a/src/site/resources/examples/xref/badNaming/package2/AnInterface.html
+++ b/src/site/resources/examples/xref/badNaming/package2/AnInterface.html
@@ -9,10 +9,10 @@
 
 
 1   package badNaming.package2;
-2   
+2
 3   public interface AnInterface {
 4   	public void test2(A a);
-5   
+5
 6   }
 

 

diff --git a/src/site/resources/examples/xref/badNaming/package2/package-summary.html b/src/site/resources/examples/xref/badNaming/package2/package-summary.html
index c87989d8d..34d9d6766 100644
--- a/src/site/resources/examples/xref/badNaming/package2/package-summary.html
+++ b/src/site/resources/examples/xref/badNaming/package2/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package badNaming.package2

 
 		
@@ -49,7 +49,7 @@ 
Package badNaming.package2

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -73,4 +73,4 @@ 
    Package badNaming.package2
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/equals/ArrayEquality.html b/src/site/resources/examples/xref/equals/ArrayEquality.html
index 2e53ccb8c..9fb50be1a 100644
--- a/src/site/resources/examples/xref/equals/ArrayEquality.html
+++ b/src/site/resources/examples/xref/equals/ArrayEquality.html
@@ -9,15 +9,15 @@
 
 
 1   package equals;
-2   
+2
 3   import java.io.Serializable;
-4   
+4
 5   public class ArrayEquality {
-6   
+6
 7   	boolean reportProblemsWithArrayEquality(String[] a, String b) {
 8   		return a.equals(b);
 9   	}
-10  
+10
 11  	boolean reportProblemsWithArrayEquality2(String[] a, String b) {
 12  		return  b.equals(a);
 13  	}
@@ -45,7 +45,7 @@
 35  	boolean reportProblemsWithArrayEqualityFalsePositive2(String[] a, Cloneable b) {
 36  		return a.equals(b) || b.equals(a);
 37  	}
-38  
+38
 39  }
 

 

diff --git a/src/site/resources/examples/xref/equals/package-summary.html b/src/site/resources/examples/xref/equals/package-summary.html
index 15004beff..307775a7d 100644
--- a/src/site/resources/examples/xref/equals/package-summary.html
+++ b/src/site/resources/examples/xref/equals/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package equals

 
 		
@@ -44,7 +44,7 @@ 
Package equals

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package equals
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html b/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html
index 8392c0f1a..978ab0823 100644
--- a/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html
+++ b/src/site/resources/examples/xref/gcUnrelatedTypes/AllListsCouldBeEqual.html
@@ -9,7 +9,7 @@
 
 
 1   package gcUnrelatedTypes;
-2   
+2
 3   import java.util.ArrayList;
 4   import java.util.Collection;
 5   import java.util.HashSet;
@@ -18,151 +18,151 @@
 8   import java.util.List;
 9   import java.util.ListIterator;
 10  import java.util.Set;
-11  
+11
 12  public class AllListsCouldBeEqual {
-13  	
+13
 14  	static class MyList<E> implements List<E> {
-15  
+15
 16  		public boolean add(E o) {
 17  	        // TODO Auto-generated method stub
 18  	        return false;
 19          }
-20  
+20
 21  		public void add(int index, E element) {
 22  	        // TODO Auto-generated method stub
-23  	        
+23
 24          }
-25  
+25
 26  		public boolean addAll(Collection<? extends E> c) {
 27  	        // TODO Auto-generated method stub
 28  	        return false;
 29          }
-30  
+30
 31  		public boolean addAll(int index, Collection<? extends E> c) {
 32  	        // TODO Auto-generated method stub
 33  	        return false;
 34          }
-35  
+35
 36  		public void clear() {
 37  	        // TODO Auto-generated method stub
-38  	        
+38
 39          }
-40  
+40
 41  		public boolean contains(Object o) {
 42  	        // TODO Auto-generated method stub
 43  	        return false;
 44          }
-45  
+45
 46  		public boolean containsAll(Collection<?> c) {
 47  	        // TODO Auto-generated method stub
 48  	        return false;
 49          }
-50  
+50
 51  		public E get(int index) {
 52  	        // TODO Auto-generated method stub
 53  	        return null;
 54          }
-55  
+55
 56  		public int indexOf(Object o) {
 57  	        // TODO Auto-generated method stub
 58  	        return 0;
 59          }
-60  
+60
 61  		public boolean isEmpty() {
 62  	        // TODO Auto-generated method stub
 63  	        return false;
 64          }
-65  
+65
 66  		public Iterator<E> iterator() {
 67  	        // TODO Auto-generated method stub
 68  	        return null;
 69          }
-70  
+70
 71  		public int lastIndexOf(Object o) {
 72  	        // TODO Auto-generated method stub
 73  	        return 0;
 74          }
-75  
+75
 76  		public ListIterator<E> listIterator() {
 77  	        // TODO Auto-generated method stub
 78  	        return null;
 79          }
-80  
+80
 81  		public ListIterator<E> listIterator(int index) {
 82  	        // TODO Auto-generated method stub
 83  	        return null;
 84          }
-85  
+85
 86  		public boolean remove(Object o) {
 87  	        // TODO Auto-generated method stub
 88  	        return false;
 89          }
-90  
+90
 91  		public E remove(int index) {
 92  	        // TODO Auto-generated method stub
 93  	        return null;
 94          }
-95  
+95
 96  		public boolean removeAll(Collection<?> c) {
 97  	        // TODO Auto-generated method stub
 98  	        return false;
 99          }
-100 
+100
 101 		public boolean retainAll(Collection<?> c) {
 102 	        // TODO Auto-generated method stub
 103 	        return false;
 104         }
-105 
+105
 106 		public E set(int index, E element) {
 107 	        // TODO Auto-generated method stub
 108 	        return null;
 109         }
-110 
+110
 111 		public int size() {
 112 	        // TODO Auto-generated method stub
 113 	        return 0;
 114         }
-115 
+115
 116 		public List<E> subList(int fromIndex, int toIndex) {
 117 	        // TODO Auto-generated method stub
 118 	        return null;
 119         }
-120 
+120
 121 		public Object[] toArray() {
 122 	        // TODO Auto-generated method stub
 123 	        return null;
 124         }
-125 
+125
 126 		public <T> T[] toArray(T[] a) {
 127 	        // TODO Auto-generated method stub
 128 	        return null;
 129         }}
 130 	public static void main(String arg[]) {
 131 		falsePositive();
-132 		
+132
 133 		List<Integer> lst = new LinkedList<Integer>();
 134 		List<Integer> lst2 = (ArrayList<Integer>)lst;
-135 		
-136 		
+135
+136
 137 		List<ArrayList<String>> mlist = null;
 138 		mlist.contains(new LinkedList<String>());
-139 
+139
 140 	}
 141 	public static void falsePositive() {
 142 		ArrayList<Integer> aLst = new ArrayList<Integer>();
 143 		LinkedList<Integer> lLst = new LinkedList<Integer>();
 144 		MyList<Integer> mLst = new MyList<Integer>();
-145 		
+145
 146 		Set<ArrayList<Integer>> alSet = new HashSet<ArrayList<Integer>>();
 147 		Set<LinkedList<Integer>> llSet = new HashSet<LinkedList<Integer>>();
-148 		
+148
 149 		System.out.println(aLst.equals(lLst));
 150 		System.out.println(mLst.equals(lLst));
-151 		
+151
 152 		alSet.contains(lLst);
 153 		alSet.contains(mLst);
 154 		alSet.containsAll(llSet);
-155 
+155
 156 	}
 157 }
 

diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html
index 3ef3e30d3..6c14ae57a 100644
--- a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html
+++ b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains.html
@@ -9,46 +9,46 @@
 
 
 1   package gcUnrelatedTypes;
-2   
+2
 3   import java.util.ArrayList;
-4   
+4
 5   import edu.umd.cs.findbugs.annotations.ExpectWarning;
-6   
+6
 7   public class ArrayListContains<T> {
-8   
+8
 9   	static class Dummy {
-10  
+10
 11  	}
-12  
+12
 13  	static class DummyChild extends Dummy {
-14  
+14
 15  	}
-16  
+16
 17  	private ArrayList<?> wildcardF;
-18  
+18
 19  	private ArrayList<Dummy> dummyF;
 20  	private ArrayList<? extends Dummy> dummyEF;
 21  	private ArrayList<? super Dummy> dummySF;
-22  
+22
 23  	private ArrayList<DummyChild> childF;
 24  	private ArrayList<? extends DummyChild> childEF;
 25  	private ArrayList<? super DummyChild> childSF;
-26  
-27  	private ArrayList<T> genericF;		
+26
+27  	private ArrayList<T> genericF;
 28  	private ArrayList<? extends T> genericEF;
-29  	private ArrayList<? super T> genericSF;		
-30  
+29  	private ArrayList<? super T> genericSF;
+30
 31  	@ExpectWarning("GC")
 32  	public ArrayListContains(
-33  			ArrayList<?> wildcardF, 
-34  			ArrayList<Dummy> dummyF, 
-35  			ArrayList<? extends Dummy> dummyEF, 
-36  			ArrayList<? super Dummy> dummySF, 
-37  			ArrayList<DummyChild> childF, 
-38  			ArrayList<? extends DummyChild> childEF, 
-39  			ArrayList<? super DummyChild> childSF, 
-40  			ArrayList<T> genericF, 
-41  			ArrayList<? extends T> genericEF, 
+33  			ArrayList<?> wildcardF,
+34  			ArrayList<Dummy> dummyF,
+35  			ArrayList<? extends Dummy> dummyEF,
+36  			ArrayList<? super Dummy> dummySF,
+37  			ArrayList<DummyChild> childF,
+38  			ArrayList<? extends DummyChild> childEF,
+39  			ArrayList<? super DummyChild> childSF,
+40  			ArrayList<T> genericF,
+41  			ArrayList<? extends T> genericEF,
 42  			ArrayList<? super T> genericSF) {
 43  		this.wildcardF = wildcardF;
 44  		this.dummyF = dummyF;
@@ -60,103 +60,103 @@
 50  		this.genericF = genericF;
 51  		this.genericEF = genericEF;
 52  		this.genericSF = genericSF;
-53  
+53
 54  		Dummy dummy = new Dummy();
 55  		DummyChild dummyChild = new DummyChild();
 56  		String s = "Mismatched Type";
-57  
+57
 58  		wildcardF.contains(dummy); 				// No warning
 59  		wildcardF.contains(dummyChild); 		// No warning
 60  		wildcardF.contains(s); 					// No warning
-61  
+61
 62  		dummyF.contains(dummy); 				// No warning
 63  		dummyF.contains(dummyChild); 		 	// No warning
 64  		dummyF.contains(s); 					// HIGH
-65  
+65
 66  		dummyEF.contains(dummy); 				// No warning
 67  		dummyEF.contains(dummyChild); 		 	// No warning
 68  		dummyEF.contains(s); 					// HIGH
-69  
+69
 70  		dummySF.contains(dummy); 				// No warning
 71  		dummySF.contains(dummyChild); 		 	// No warning
 72  		dummySF.contains(s); 					// HIGH
-73  
+73
 74  		childF.contains(dummy); 				// No warning
 75  		childF.contains(dummyChild); 		 	// No warning
 76  		childF.contains(s); 					// HIGH
-77  
+77
 78  		childEF.contains(dummy); 				// No warning
 79  		childEF.contains(dummyChild); 		 	// No warning
 80  		childEF.contains(s); 					// HIGH
-81  
+81
 82  		childSF.contains(dummy); 				// No warning
 83  		childSF.contains(dummyChild); 		 	// No warning
 84  		childSF.contains(s); 					// HIGH
-85  
+85
 86  		genericF.contains(dummy); 				// No warning
 87  		genericF.contains(dummyChild); 		 	// No warning
 88  		genericF.contains(s); 					// No warning
-89  
+89
 90  		genericEF.contains(dummy); 				// No warning
 91  		genericEF.contains(dummyChild); 		    // No warning
 92  		genericEF.contains(s); 					// No warning
-93  
+93
 94  		genericSF.contains(dummy); 				// No warning
 95  		genericSF.contains(dummyChild); 		// No warning
 96  		genericSF.contains(s); 					// No warning
-97  
+97
 98  	}
-99  
+99
 100 	@ExpectWarning("GC")
 101 	public void testFields() {
 102 		Dummy dummy = new Dummy();
 103 		DummyChild dummyChild = new DummyChild();
 104 		String s = "Mismatched Type";
-105 
+105
 106 		wildcardF.contains(dummy); 				// No warning
 107 		wildcardF.contains(dummyChild); 		// No warning
 108 		wildcardF.contains(s); 					// No warning
-109 
+109
 110 		dummyF.contains(dummy); 				// No warning
 111 		dummyF.contains(dummyChild); 		 	// No warning
 112 		dummyF.contains(s); 					// HIGH
-113 
+113
 114 		dummyEF.contains(dummy); 				// No warning
 115 		dummyEF.contains(dummyChild); 		 	// No warning
 116 		dummyEF.contains(s); 					// HIGH
-117 
+117
 118 		dummySF.contains(dummy); 				// No warning
 119 		dummySF.contains(dummyChild); 		 	// No warning
 120 		dummySF.contains(s); 					// HIGH
-121 
+121
 122 		childF.contains(dummy); 				// No warning
 123 		childF.contains(dummyChild); 		 	// No warning
 124 		childF.contains(s); 					// HIGH
-125 
+125
 126 		childEF.contains(dummy); 				// No warning
 127 		childEF.contains(dummyChild); 		 	// No warning
 128 		childEF.contains(s); 					// HIGH
-129 
+129
 130 		childSF.contains(dummy); 				// No warning
 131 		childSF.contains(dummyChild); 		 	// No warning
 132 		childSF.contains(s); 					// HIGH
-133 
+133
 134 		genericF.contains(dummy); 				// No warning
 135 		genericF.contains(dummyChild); 		 	// No warning
 136 		genericF.contains(s); 					// No warning
-137 
+137
 138 		genericEF.contains(dummy); 				// No warning
 139 		genericEF.contains(dummyChild); 		// No warning
 140 		genericEF.contains(s); 					// No warning
-141 
+141
 142 		genericSF.contains(dummy); 				// No warning
 143 		genericSF.contains(dummyChild); 		// No warning
 144 		genericSF.contains(s); 					// No warning
-145 
+145
 146 		// what if <T extends Dummy> in class definition? 
 147 		// Requires more analysis -- a future enhancement
 148 		// Can we be sure that the T is the same as the one in the class/method definition
-149 
+149
 150 	}
 151 }
 

diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html
index 2bc5aae0e..ffc9677c0 100644
--- a/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html
+++ b/src/site/resources/examples/xref/gcUnrelatedTypes/ArrayListContains0.html
@@ -9,70 +9,70 @@
 
 
 1   package gcUnrelatedTypes;
-2   
+2
 3   import java.util.ArrayList;
-4   
+4
 5   public class ArrayListContains0<T> {
-6   
+6
 7   	static class Dummy {
-8   
+8
 9   	}
-10  
+10
 11  	static class DummyChild extends Dummy {
-12  
+12
 13  	}
-14  
+14
 15  	private ArrayList<?> wildcardF;
-16  
+16
 17  	private ArrayList<Dummy> dummyF;
 18  	private ArrayList<? extends Dummy> dummyEF;
 19  	private ArrayList<? super Dummy> dummySF;
-20  
+20
 21  	private ArrayList<DummyChild> childF;
 22  	private ArrayList<? extends DummyChild> childEF;
 23  	private ArrayList<? super DummyChild> childSF;
-24  
-25  	private ArrayList<T> genericF;		
+24
+25  	private ArrayList<T> genericF;
 26  	private ArrayList<? extends T> genericEF;
-27  	private ArrayList<? super T> genericSF;		
-28  
-29  
+27  	private ArrayList<? super T> genericSF;
+28
+29
 30  	public ArrayListContains0(
-31  			ArrayList<?> wildcardF, 
-32  			ArrayList<Dummy> dummyF, 
-33  			ArrayList<? extends Dummy> dummyEF, 
-34  			ArrayList<? super Dummy> dummySF, 
-35  			ArrayList<DummyChild> childF, 
-36  			ArrayList<? extends DummyChild> childEF, 
-37  			ArrayList<? super DummyChild> childSF, 
-38  			ArrayList<T> genericF, 
-39  			ArrayList<? extends T> genericEF, 
+31  			ArrayList<?> wildcardF,
+32  			ArrayList<Dummy> dummyF,
+33  			ArrayList<? extends Dummy> dummyEF,
+34  			ArrayList<? super Dummy> dummySF,
+35  			ArrayList<DummyChild> childF,
+36  			ArrayList<? extends DummyChild> childEF,
+37  			ArrayList<? super DummyChild> childSF,
+38  			ArrayList<T> genericF,
+39  			ArrayList<? extends T> genericEF,
 40  			ArrayList<? super T> genericSF) {
-41  
+41
 42  		Dummy dummy = new Dummy();
 43  		DummyChild dummyChild = new DummyChild();
 44  		String s = "Mismatched Type";
-45  
+45
 46  		wildcardF.contains(s); 					// No warning
-47  
+47
 48  		dummyF.contains(s); 					// HIGH
-49  
+49
 50  		dummyEF.contains(s); 					// HIGH
-51  
+51
 52  		dummySF.contains(s); 					// HIGH
-53  
+53
 54  		childF.contains(s); 					// HIGH
-55  
+55
 56  		childEF.contains(s); 					// HIGH
-57  
+57
 58  		childSF.contains(s); 					// HIGH
-59  
-60  
-61  
-62  	
+59
+60
+61
+62
 63  	}
-64  
-65  
+64
+65
 66  	}
 

 

diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html b/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html
index 4cdd4e15d..e6aa34fbc 100644
--- a/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html
+++ b/src/site/resources/examples/xref/gcUnrelatedTypes/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package gcUnrelatedTypes

 
 		
@@ -69,7 +69,7 @@ 
Package gcUnrelatedTypes

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -93,4 +93,4 @@ 
    Package gcUnrelatedTypes
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/jsr305/AlwaysBlue.html b/src/site/resources/examples/xref/jsr305/AlwaysBlue.html
index e2bf40ef8..5461a35f3 100644
--- a/src/site/resources/examples/xref/jsr305/AlwaysBlue.html
+++ b/src/site/resources/examples/xref/jsr305/AlwaysBlue.html
@@ -9,18 +9,18 @@
 
 
 1   package jsr305;
-2   
+2
 3   import java.lang.annotation.Retention;
 4   import java.lang.annotation.RetentionPolicy;
-5   
+5
 6   import javax.annotation.meta.TypeQualifierNickname;
 7   import javax.annotation.meta.When;
-8   
+8
 9   @ExhaustiveQualifier(value=ExhaustiveQualifier.Color.BLUE, when=When.ALWAYS)
 10  @TypeQualifierNickname
 11  @Retention(RetentionPolicy.RUNTIME)
 12  public @interface AlwaysBlue {
-13  
+13
 14  }
 

 

diff --git a/src/site/resources/examples/xref/jsr305/package-summary.html b/src/site/resources/examples/xref/jsr305/package-summary.html
index 2df39dd8c..a3ed42c32 100644
--- a/src/site/resources/examples/xref/jsr305/package-summary.html
+++ b/src/site/resources/examples/xref/jsr305/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package jsr305

 
 		
@@ -44,7 +44,7 @@ 
Package jsr305

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package jsr305
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html b/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html
index 48a5aa346..55d98d7c4 100644
--- a/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html
+++ b/src/site/resources/examples/xref/npe/AtomicFieldUpdater.html
@@ -9,41 +9,41 @@
 
 
 1   package npe;
-2   
+2
 3   import java.util.concurrent.atomic.AtomicIntegerFieldUpdater;
 4   import java.util.concurrent.atomic.AtomicLongFieldUpdater;
 5   import java.util.concurrent.atomic.AtomicReferenceFieldUpdater;
-6   
+6
 7   public class AtomicFieldUpdater {
-8   
+8
 9   	volatile Object x;
 10  	volatile int y;
 11      volatile long z;
-12  
-13  	AtomicReferenceFieldUpdater<AtomicFieldUpdater  , Object> updaterX 
+12
+13  	AtomicReferenceFieldUpdater<AtomicFieldUpdater  , Object> updaterX
 14  	 = AtomicReferenceFieldUpdater.newUpdater(AtomicFieldUpdater.class, Object.class, "x");
-15      
+15
 16  	AtomicIntegerFieldUpdater<AtomicFieldUpdater> updaterY
 17  	= AtomicIntegerFieldUpdater.newUpdater(AtomicFieldUpdater.class, "y");
-18  
+18
 19      AtomicLongFieldUpdater<AtomicFieldUpdater> updaterZ
 20  	= AtomicLongFieldUpdater.newUpdater(AtomicFieldUpdater.class,  "z");
-21  
+21
 22  	int f() {
 23          return x.hashCode();
 24  	}
-25  
+25
 26  	void setX(Object foo) {
 27          updaterX.set(this, foo);
 28  	}
 29  	void setY(int foo) {
 30  		updaterY.set(this, foo);
 31      }
-32  
+32
 33  	void setZ(long foo) {
 34  		updaterZ.set(this, foo);
 35      }
-36  
+36
 37  }
 

 

diff --git a/src/site/resources/examples/xref/npe/UseCheckUse.html b/src/site/resources/examples/xref/npe/UseCheckUse.html
index c472d36e2..2aba78e1e 100644
--- a/src/site/resources/examples/xref/npe/UseCheckUse.html
+++ b/src/site/resources/examples/xref/npe/UseCheckUse.html
@@ -9,7 +9,7 @@
 
 
 1   package npe;
-2   
+2
 3   public class UseCheckUse {
 4   	final Object x;
 5   	UseCheckUse(Object x) {
@@ -20,13 +20,13 @@
 10  		if (x == null) {
 11              System.out.println("x is null");
 12  		}
-13  		if (b) 
+13  		if (b)
 14  			result *= x.hashCode();
 15          else
 16  			result += x.hashCode();
 17  		return result;
 18  	}
-19  
+19
 20  }
 

 

diff --git a/src/site/resources/examples/xref/npe/package-summary.html b/src/site/resources/examples/xref/npe/package-summary.html
index b6b07f84b..29320b200 100644
--- a/src/site/resources/examples/xref/npe/package-summary.html
+++ b/src/site/resources/examples/xref/npe/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package npe

 
 		
@@ -49,7 +49,7 @@ 
Package npe

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -73,4 +73,4 @@ 
    Package npe
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html b/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html
index ffb9daca9..7d29d8b61 100644
--- a/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html
+++ b/src/site/resources/examples/xref/nullnessAnnotations/UseAnnotations.html
@@ -9,17 +9,17 @@
 
 
 1   package nullnessAnnotations;
-2   
+2
 3   import javax.annotation.CheckForNull;
 4   import javax.annotation.Nonnull;
-5   
+5
 6   public class UseAnnotations {
-7   	
+7
 8   	@CheckForNull Object f(int x) {
 9   		if (x == 0) return null;
 10  		return (Integer) x;
 11  	}
-12  	
+12
 13  	int g(@Nonnull Object x) {
 14  		return 42;
 15  	}
@@ -37,7 +37,7 @@
 27  	int foo4() {
 28  		return f(12).hashCode();  // should generate a warning here (but don't)
 29  	}
-30  
+30
 31  	int bar() {
 32  		return f(12).hashCode();  // should generate a warning here (but don't)
 33  	}
@@ -55,7 +55,7 @@
 45  		if (x > 0) y = "";
 46  		return y.hashCode();  // should generate a warning here (but don't)
 47  	}
-48  
+48
 49  }
 

 

diff --git a/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html b/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html
index 59f5d9157..f69661894 100644
--- a/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html
+++ b/src/site/resources/examples/xref/nullnessAnnotations/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package nullnessAnnotations

 
 		
@@ -44,7 +44,7 @@ 
Package nullnessAnnotations

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package nullnessAnnotations
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html b/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html
index b216fc16b..b7010f96d 100644
--- a/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html
+++ b/src/site/resources/examples/xref/obligation/UsesWillCloseAnnotation.html
@@ -9,15 +9,15 @@
 
 
 1   package obligation;
-2   
+2
 3   import java.io.FileInputStream;
 4   import java.io.IOException;
 5   import java.io.InputStream;
-6   
+6
 7   import javax.annotation.WillClose;
-8   
+8
 9   import edu.umd.cs.findbugs.annotations.NoWarning;
-10  
+10
 11  /**
 12   * Test to see if WillClose annotations are understood.
 13   */
@@ -33,8 +33,8 @@
 23  			cleanup(in);
 24  		}
 25  	}
-26  	
-27  	
+26
+27
 28  	public void cleanup(@WillClose InputStream in) {
 29  		try {
 30  			in.close();
diff --git a/src/site/resources/examples/xref/obligation/package-summary.html b/src/site/resources/examples/xref/obligation/package-summary.html
index 888ae8256..bf4152108 100644
--- a/src/site/resources/examples/xref/obligation/package-summary.html
+++ b/src/site/resources/examples/xref/obligation/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package obligation

 
 		
@@ -44,7 +44,7 @@ 
Package obligation

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package obligation
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/overview-summary.html b/src/site/resources/examples/xref/overview-summary.html
index 7bb68a49e..1c3d292d3 100644
--- a/src/site/resources/examples/xref/overview-summary.html
+++ b/src/site/resources/examples/xref/overview-summary.html
@@ -24,7 +24,7 @@
         	  	
 	        
       	
-		
+
 		      	
basic-1 testing Reference

 
 		
@@ -87,7 +87,7 @@ 
basic-1 testing Reference

             	
 	          	        	
       	

-		
+
 				

 			
    
 				
  • Overview
    • 
@@ -104,10 +104,10 @@ 
    basic-1 testing Reference
    
         	  	
 	        

       	

-		
+
 		

 		
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/package-summary.html b/src/site/resources/examples/xref/package-summary.html
index 1664578cd..4807b2e40 100644
--- a/src/site/resources/examples/xref/package-summary.html
+++ b/src/site/resources/examples/xref/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package (default package)

 
 		
@@ -164,7 +164,7 @@ 
Package (default package)

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -188,4 +188,4 @@ 
    Package (default package)
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/uselessThread/UsefulThread.html b/src/site/resources/examples/xref/uselessThread/UsefulThread.html
index b207fe69c..85755e255 100644
--- a/src/site/resources/examples/xref/uselessThread/UsefulThread.html
+++ b/src/site/resources/examples/xref/uselessThread/UsefulThread.html
@@ -9,12 +9,12 @@
 
 
 1   package uselessThread;
-2   
+2
 3   class UsefulThread extends Thread {
 4   	public UsefulThread() {
 5   		super("Usefull-" + System.currentTimeMillis());
 6   	}
-7   
+7
 8   	@Override
 9   	public void run() {
 10  		System.out.println("I am a useful thread!");
diff --git a/src/site/resources/examples/xref/uselessThread/package-summary.html b/src/site/resources/examples/xref/uselessThread/package-summary.html
index 6c0e6288c..7a9f65b45 100644
--- a/src/site/resources/examples/xref/uselessThread/package-summary.html
+++ b/src/site/resources/examples/xref/uselessThread/package-summary.html
@@ -26,7 +26,7 @@
           		
         	
       	
-		
+
 		      	
Package uselessThread

 
 		
@@ -44,7 +44,7 @@ 
Package uselessThread

             	
 				        	
       	

-		
+
 		      	

         	
    
           		
  • 
@@ -68,4 +68,4 @@ 
    Package uselessThread
    
 			Copyright © 2020. All rights reserved.
 		

 	
-
\ No newline at end of file
+

From f594c174b196532a29fb342b312004e2666a9900 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 12 Mar 2023 15:02:57 -0400
Subject: [PATCH 0896/1013] [ci] Fix end of file line markers

---
 .../src/main/config/spotbugs-exclude-filters.xml                | 2 +-
 src/it/sarif-1/verify.groovy                                    | 2 +-
 src/it/sarif-2/verify.groovy                                    | 2 +-
 .../github/spotbugs/spotbugs-maven-plugin/it/package-frame.html | 2 +-
 .../examples/xref/badNaming/package1/package-frame.html         | 2 +-
 .../examples/xref/badNaming/package2/package-frame.html         | 2 +-
 src/site/resources/examples/xref/equals/package-frame.html      | 2 +-
 .../resources/examples/xref/gcUnrelatedTypes/package-frame.html | 2 +-
 src/site/resources/examples/xref/jsr305/package-frame.html      | 2 +-
 src/site/resources/examples/xref/npe/package-frame.html         | 2 +-
 .../examples/xref/nullnessAnnotations/package-frame.html        | 2 +-
 src/site/resources/examples/xref/obligation/package-frame.html  | 2 +-
 src/site/resources/examples/xref/package-frame.html             | 2 +-
 .../resources/examples/xref/uselessThread/package-frame.html    | 2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
index b9b77c524..539a2ccfe 100644
--- a/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
+++ b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
@@ -3,4 +3,4 @@
   xmlns="https://github.com/spotbugs/filter/3.0.0"
   xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
   xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
-
\ No newline at end of file
+
diff --git a/src/it/sarif-1/verify.groovy b/src/it/sarif-1/verify.groovy
index b8fcad162..d04ea45b2 100644
--- a/src/it/sarif-1/verify.groovy
+++ b/src/it/sarif-1/verify.groovy
@@ -33,4 +33,4 @@ def results = path.runs.results[0]
 println "BugInstance size is ${results.size()}"
 
 
-assert results.size() > 0
\ No newline at end of file
+assert results.size() > 0
diff --git a/src/it/sarif-2/verify.groovy b/src/it/sarif-2/verify.groovy
index a41a8c0a8..d86c5fed4 100644
--- a/src/it/sarif-2/verify.groovy
+++ b/src/it/sarif-2/verify.groovy
@@ -49,4 +49,4 @@ for (result in slurpedResult.runs.results[0]) {
 println "BugInstance size is ${results.size()}"
 
 
-assert results.size() > 0
\ No newline at end of file
+assert results.size() > 0
diff --git a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-frame.html b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-frame.html
index 337021b97..fe38f5cd1 100644
--- a/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-frame.html
+++ b/src/site/resources/examples/xref-test/com/github/spotbugs/spotbugs-maven-plugin/it/package-frame.html
@@ -25,4 +25,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/badNaming/package1/package-frame.html b/src/site/resources/examples/xref/badNaming/package1/package-frame.html
index 6de694983..664ce523d 100644
--- a/src/site/resources/examples/xref/badNaming/package1/package-frame.html
+++ b/src/site/resources/examples/xref/badNaming/package1/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/badNaming/package2/package-frame.html b/src/site/resources/examples/xref/badNaming/package2/package-frame.html
index 1edbfce74..62d88df41 100644
--- a/src/site/resources/examples/xref/badNaming/package2/package-frame.html
+++ b/src/site/resources/examples/xref/badNaming/package2/package-frame.html
@@ -25,4 +25,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/equals/package-frame.html b/src/site/resources/examples/xref/equals/package-frame.html
index 3051768cc..e93d41929 100644
--- a/src/site/resources/examples/xref/equals/package-frame.html
+++ b/src/site/resources/examples/xref/equals/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/gcUnrelatedTypes/package-frame.html b/src/site/resources/examples/xref/gcUnrelatedTypes/package-frame.html
index ca9f655d1..b5fcefe47 100644
--- a/src/site/resources/examples/xref/gcUnrelatedTypes/package-frame.html
+++ b/src/site/resources/examples/xref/gcUnrelatedTypes/package-frame.html
@@ -37,4 +37,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/jsr305/package-frame.html b/src/site/resources/examples/xref/jsr305/package-frame.html
index 852be8f1d..c184ad707 100644
--- a/src/site/resources/examples/xref/jsr305/package-frame.html
+++ b/src/site/resources/examples/xref/jsr305/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/npe/package-frame.html b/src/site/resources/examples/xref/npe/package-frame.html
index 4349cc003..b438d5dfe 100644
--- a/src/site/resources/examples/xref/npe/package-frame.html
+++ b/src/site/resources/examples/xref/npe/package-frame.html
@@ -25,4 +25,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/nullnessAnnotations/package-frame.html b/src/site/resources/examples/xref/nullnessAnnotations/package-frame.html
index c1c2aae41..90e668358 100644
--- a/src/site/resources/examples/xref/nullnessAnnotations/package-frame.html
+++ b/src/site/resources/examples/xref/nullnessAnnotations/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/obligation/package-frame.html b/src/site/resources/examples/xref/obligation/package-frame.html
index cb1dd530e..02bc4db87 100644
--- a/src/site/resources/examples/xref/obligation/package-frame.html
+++ b/src/site/resources/examples/xref/obligation/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/package-frame.html b/src/site/resources/examples/xref/package-frame.html
index 051a1e9df..640c328b9 100644
--- a/src/site/resources/examples/xref/package-frame.html
+++ b/src/site/resources/examples/xref/package-frame.html
@@ -94,4 +94,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+
diff --git a/src/site/resources/examples/xref/uselessThread/package-frame.html b/src/site/resources/examples/xref/uselessThread/package-frame.html
index 322b93cdc..76946642c 100644
--- a/src/site/resources/examples/xref/uselessThread/package-frame.html
+++ b/src/site/resources/examples/xref/uselessThread/package-frame.html
@@ -22,4 +22,4 @@ 
Classes

           	      	
 
 	
-
\ No newline at end of file
+

From 17d39ae7347960d236d35f3021db4b1793c8606b Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 12 Mar 2023 15:04:33 -0400
Subject: [PATCH 0897/1013] [cross] For better cross platform support, use the
 system line separator

---
 .../org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy  | 4 ++--
 .../groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy     | 2 +-
 .../groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy
index a9c580790..9bef47734 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/BaseViolationCheckMojo.groovy
@@ -508,7 +508,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo {
                 log.info('No errors/warnings found')
                 return
             } else if (maxAllowedViolations > 0 && bugCount <= maxAllowedViolations) {
-                log.info("total ${bugCount} violations are found which is set to be acceptable using configured property maxAllowedViolations :"+maxAllowedViolations +".\nBelow are list of bugs ignored :\n")
+                log.info("total ${bugCount} violations are found which is set to be acceptable using configured property maxAllowedViolations :" + maxAllowedViolations + "." + SpotBugsInfo.EOL + "Below are list of bugs ignored :" + SpotBugsInfo.EOL)
                 printBugs(bugCount, bugs)
                 return;
             }
@@ -536,7 +536,7 @@ abstract class BaseViolationCheckMojo extends AbstractMojo {
                 }
             }
 
-            log.info('\n\n\nTo see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"\n\n\n')
+            log.info(SpotBugsInfo.EOL + SpotBugsInfo.EOL + SpotBugsInfo.EOL + 'To see bug detail using the Spotbugs GUI, use the following command "mvn spotbugs:gui"' + SpotBugsInfo.EOL + SpotBugsInfo.EOL + SpotBugsInfo.EOL)
 
             if ((bugCountAboveThreshold || errorCount) && failOnError) {
                 throw new MojoExecutionException("failed with ${bugCountAboveThreshold} bugs and ${errorCount} errors ")
diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy
index 2be43c7b6..fc81fc5cf 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsInfo.groovy
@@ -82,7 +82,7 @@ interface SpotBugsInfo {
 
     static final String PERIOD = "."
 
-    static final EOL = "\n"
+    static final EOL = System.lineSeparator()
 
     static final String URL = "url"
 
diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy
index 5cbaffa51..9e338c90b 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotBugsMojo.groovy
@@ -1053,7 +1053,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait {
 
                 auxClasspathList.each() { auxClasspathElement ->
                     log.debug("  Adding to AuxClasspath ->" + auxClasspathElement.toString())
-                    auxClasspathFile << auxClasspathElement.toString() + "\n"
+                    auxClasspathFile << auxClasspathElement.toString() + SpotBugsInfo.EOL
                 }
             }
         }
@@ -1244,7 +1244,7 @@ class SpotBugsMojo extends AbstractMavenReport implements SpotBugsPluginsTrait {
                     writer.write ""
                 }
 
-                writer.write "\n"
+                writer.write SpotBugsInfo.EOL
 
                 writer << xmlBuilder.bind { mkp.yield path }
             } else {

From 229b16559a81fbe5c5fc8fd39ec1bb74498d649b Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Sun, 12 Mar 2023 21:59:30 +0000
Subject: [PATCH 0898/1013] Update dependency maven-wrapper to v3.2.0

---
 .mvn/wrapper/maven-wrapper.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index 6686a643d..43a7228f1 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -15,4 +15,4 @@
 # specific language governing permissions and limitations
 # under the License.
 distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip
-wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.1/maven-wrapper-3.1.1.jar
+wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

From 95b857f49a8c15bd87de2576eb3fa7c688ce557a Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 12 Mar 2023 18:55:13 -0400
Subject: [PATCH 0899/1013] [mvn] Update maven wrapper

---
 .mvn/wrapper/MavenWrapperDownloader.java | 104 +++--------
 mvnw                                     | 220 +++++++++++------------
 mvnw.cmd                                 |  33 +++-
 3 files changed, 151 insertions(+), 206 deletions(-)

diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java
index 732313c43..84d1e60d8 100644
--- a/.mvn/wrapper/MavenWrapperDownloader.java
+++ b/.mvn/wrapper/MavenWrapperDownloader.java
@@ -23,85 +23,50 @@
 import java.net.PasswordAuthentication;
 import java.net.URL;
 import java.nio.file.Files;
-import java.nio.file.LinkOption;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 import java.nio.file.StandardCopyOption;
-import java.nio.file.StandardOpenOption;
-import java.util.Properties;
 
 public final class MavenWrapperDownloader
 {
-    private static final String WRAPPER_VERSION = "3.1.1";
+    private static final String WRAPPER_VERSION = "3.2.0";
 
     private static final boolean VERBOSE = Boolean.parseBoolean( System.getenv( "MVNW_VERBOSE" ) );
 
-    /**
-     * Default URL to download the maven-wrapper.jar from, if no 'downloadUrl' is provided.
-     */
-    private static final String DEFAULT_DOWNLOAD_URL =
-        "https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/" + WRAPPER_VERSION
-            + "/maven-wrapper-" + WRAPPER_VERSION + ".jar";
-
-    /**
-     * Path to the maven-wrapper.properties file, which might contain a downloadUrl property to use instead of the
-     * default one.
-     */
-    private static final String MAVEN_WRAPPER_PROPERTIES_PATH = ".mvn/wrapper/maven-wrapper.properties";
-
-    /**
-     * Path where the maven-wrapper.jar will be saved to.
-     */
-    private static final String MAVEN_WRAPPER_JAR_PATH = ".mvn/wrapper/maven-wrapper.jar";
-
-    /**
-     * Name of the property which should be used to override the default download url for the wrapper.
-     */
-    private static final String PROPERTY_NAME_WRAPPER_URL = "wrapperUrl";
-
     public static void main( String[] args )
     {
-        if ( args.length == 0 )
-        {
-            System.err.println( " - ERROR projectBasedir parameter missing" );
-            System.exit( 1 );
-        }
+        log( "Apache Maven Wrapper Downloader " + WRAPPER_VERSION );
 
-        log( " - Downloader started" );
-        final String dir = args[0].replace( "..", "" ); // Sanitize path
-        final Path projectBasedir = Paths.get( dir ).toAbsolutePath().normalize();
-        if ( !Files.isDirectory( projectBasedir, LinkOption.NOFOLLOW_LINKS ) )
+        if ( args.length != 2 )
         {
-            System.err.println( " - ERROR projectBasedir not exists: " + projectBasedir );
+            System.err.println( " - ERROR wrapperUrl or wrapperJarPath parameter missing" );
             System.exit( 1 );
         }
 
-        log( " - Using base directory: " + projectBasedir );
-
-        // If the maven-wrapper.properties exists, read it and check if it contains a custom
-        // wrapperUrl parameter.
-        Path mavenWrapperPropertyFile = projectBasedir.resolve( MAVEN_WRAPPER_PROPERTIES_PATH );
-        String url = readWrapperUrl( mavenWrapperPropertyFile );
-
         try
         {
-            Path outputFile = projectBasedir.resolve( MAVEN_WRAPPER_JAR_PATH );
-            createDirectories( outputFile.getParent() );
-            downloadFileFromURL( url, outputFile );
+            log( " - Downloader started" );
+            final URL wrapperUrl = new URL( args[0] );
+            final String jarPath = args[1].replace( "..", "" ); // Sanitize path
+            final Path wrapperJarPath = Paths.get( jarPath ).toAbsolutePath().normalize();
+            downloadFileFromURL( wrapperUrl, wrapperJarPath );
             log( "Done" );
-            System.exit( 0 );
         }
         catch ( IOException e )
         {
-            System.err.println( "- Error downloading" );
-            e.printStackTrace();
+            System.err.println( "- Error downloading: " + e.getMessage() );
+            if ( VERBOSE )
+            {
+                e.printStackTrace();
+            }
             System.exit( 1 );
         }
     }
 
-    private static void downloadFileFromURL( String urlString, Path destination ) throws IOException
+    private static void downloadFileFromURL( URL wrapperUrl, Path wrapperJarPath )
+        throws IOException
     {
-        log( " - Downloading to: " + destination );
+        log( " - Downloading to: " + wrapperJarPath );
         if ( System.getenv( "MVNW_USERNAME" ) != null && System.getenv( "MVNW_PASSWORD" ) != null )
         {
             final String username = System.getenv( "MVNW_USERNAME" );
@@ -115,40 +80,11 @@ protected PasswordAuthentication getPasswordAuthentication()
                 }
             } );
         }
-        URL website = new URL( urlString );
-        try ( InputStream inStream = website.openStream() ) {
-            Files.copy( inStream, destination, StandardCopyOption.REPLACE_EXISTING );
-        }
-        log( " - Downloader complete" );
-    }
-
-    private static void createDirectories(Path outputPath) throws IOException
-    {
-        if ( !Files.isDirectory( outputPath, LinkOption.NOFOLLOW_LINKS ) ) {
-            Path createDirectories = Files.createDirectories( outputPath );
-            log( " - Directories created: " + createDirectories );
-        }
-    }
-
-    private static String readWrapperUrl( Path mavenWrapperPropertyFile )
-    {
-        String url = DEFAULT_DOWNLOAD_URL;
-        if ( Files.exists( mavenWrapperPropertyFile, LinkOption.NOFOLLOW_LINKS ) )
+        try ( InputStream inStream = wrapperUrl.openStream() )
         {
-            log( " - Reading property file: " + mavenWrapperPropertyFile );
-            try ( InputStream in = Files.newInputStream( mavenWrapperPropertyFile, StandardOpenOption.READ ) )
-            {
-                Properties mavenWrapperProperties = new Properties();
-                mavenWrapperProperties.load( in );
-                url = mavenWrapperProperties.getProperty( PROPERTY_NAME_WRAPPER_URL, DEFAULT_DOWNLOAD_URL );
-            }
-            catch ( IOException e )
-            {
-                System.err.println( " - ERROR loading '" + MAVEN_WRAPPER_PROPERTIES_PATH + "'" );
-            }
+            Files.copy( inStream, wrapperJarPath, StandardCopyOption.REPLACE_EXISTING );
         }
-        log( " - Downloading from: " + url );
-        return url;
+        log( " - Downloader complete" );
     }
 
     private static void log( String msg )
diff --git a/mvnw b/mvnw
index 5643201c7..66df28542 100755
--- a/mvnw
+++ b/mvnw
@@ -8,7 +8,7 @@
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
 #
-#    http://www.apache.org/licenses/LICENSE-2.0
+#    https://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing,
 # software distributed under the License is distributed on an
@@ -19,7 +19,7 @@
 # ----------------------------------------------------------------------------
 
 # ----------------------------------------------------------------------------
-# Maven Start Up Batch script
+# Apache Maven Wrapper startup batch script, version 3.2.0
 #
 # Required ENV vars:
 # ------------------
@@ -27,7 +27,6 @@
 #
 # Optional ENV vars
 # -----------------
-#   M2_HOME - location of maven2's installed home dir
 #   MAVEN_OPTS - parameters passed to the Java VM when running Maven
 #     e.g. to debug Maven itself, use
 #       set MAVEN_OPTS=-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=8000
@@ -54,7 +53,7 @@ fi
 cygwin=false;
 darwin=false;
 mingw=false
-case "`uname`" in
+case "$(uname)" in
   CYGWIN*) cygwin=true ;;
   MINGW*) mingw=true;;
   Darwin*) darwin=true
@@ -62,9 +61,9 @@ case "`uname`" in
     # See https://developer.apple.com/library/mac/qa/qa1170/_index.html
     if [ -z "$JAVA_HOME" ]; then
       if [ -x "/usr/libexec/java_home" ]; then
-        export JAVA_HOME="`/usr/libexec/java_home`"
+        JAVA_HOME="$(/usr/libexec/java_home)"; export JAVA_HOME
       else
-        export JAVA_HOME="/Library/Java/Home"
+        JAVA_HOME="/Library/Java/Home"; export JAVA_HOME
       fi
     fi
     ;;
@@ -72,68 +71,38 @@ esac
 
 if [ -z "$JAVA_HOME" ] ; then
   if [ -r /etc/gentoo-release ] ; then
-    JAVA_HOME=`java-config --jre-home`
+    JAVA_HOME=$(java-config --jre-home)
   fi
 fi
 
-if [ -z "$M2_HOME" ] ; then
-  ## resolve links - $0 may be a link to maven's home
-  PRG="$0"
-
-  # need this for relative symlinks
-  while [ -h "$PRG" ] ; do
-    ls=`ls -ld "$PRG"`
-    link=`expr "$ls" : '.*-> \(.*\)$'`
-    if expr "$link" : '/.*' > /dev/null; then
-      PRG="$link"
-    else
-      PRG="`dirname "$PRG"`/$link"
-    fi
-  done
-
-  saveddir=`pwd`
-
-  M2_HOME=`dirname "$PRG"`/..
-
-  # make it fully qualified
-  M2_HOME=`cd "$M2_HOME" && pwd`
-
-  cd "$saveddir"
-  # echo Using m2 at $M2_HOME
-fi
-
 # For Cygwin, ensure paths are in UNIX format before anything is touched
 if $cygwin ; then
-  [ -n "$M2_HOME" ] &&
-    M2_HOME=`cygpath --unix "$M2_HOME"`
   [ -n "$JAVA_HOME" ] &&
-    JAVA_HOME=`cygpath --unix "$JAVA_HOME"`
+    JAVA_HOME=$(cygpath --unix "$JAVA_HOME")
   [ -n "$CLASSPATH" ] &&
-    CLASSPATH=`cygpath --path --unix "$CLASSPATH"`
+    CLASSPATH=$(cygpath --path --unix "$CLASSPATH")
 fi
 
 # For Mingw, ensure paths are in UNIX format before anything is touched
 if $mingw ; then
-  [ -n "$M2_HOME" ] &&
-    M2_HOME="`(cd "$M2_HOME"; pwd)`"
-  [ -n "$JAVA_HOME" ] &&
-    JAVA_HOME="`(cd "$JAVA_HOME"; pwd)`"
+  [ -n "$JAVA_HOME" ] && [ -d "$JAVA_HOME" ] &&
+    JAVA_HOME="$(cd "$JAVA_HOME" || (echo "cannot cd into $JAVA_HOME."; exit 1); pwd)"
 fi
 
 if [ -z "$JAVA_HOME" ]; then
-  javaExecutable="`which javac`"
-  if [ -n "$javaExecutable" ] && ! [ "`expr \"$javaExecutable\" : '\([^ ]*\)'`" = "no" ]; then
+  javaExecutable="$(which javac)"
+  if [ -n "$javaExecutable" ] && ! [ "$(expr "\"$javaExecutable\"" : '\([^ ]*\)')" = "no" ]; then
     # readlink(1) is not available as standard on Solaris 10.
-    readLink=`which readlink`
-    if [ ! `expr "$readLink" : '\([^ ]*\)'` = "no" ]; then
+    readLink=$(which readlink)
+    if [ ! "$(expr "$readLink" : '\([^ ]*\)')" = "no" ]; then
       if $darwin ; then
-        javaHome="`dirname \"$javaExecutable\"`"
-        javaExecutable="`cd \"$javaHome\" && pwd -P`/javac"
+        javaHome="$(dirname "\"$javaExecutable\"")"
+        javaExecutable="$(cd "\"$javaHome\"" && pwd -P)/javac"
       else
-        javaExecutable="`readlink -f \"$javaExecutable\"`"
+        javaExecutable="$(readlink -f "\"$javaExecutable\"")"
       fi
-      javaHome="`dirname \"$javaExecutable\"`"
-      javaHome=`expr "$javaHome" : '\(.*\)/bin'`
+      javaHome="$(dirname "\"$javaExecutable\"")"
+      javaHome=$(expr "$javaHome" : '\(.*\)/bin')
       JAVA_HOME="$javaHome"
       export JAVA_HOME
     fi
@@ -149,7 +118,7 @@ if [ -z "$JAVACMD" ] ; then
       JAVACMD="$JAVA_HOME/bin/java"
     fi
   else
-    JAVACMD="`\\unset -f command; \\command -v java`"
+    JAVACMD="$(\unset -f command 2>/dev/null; \command -v java)"
   fi
 fi
 
@@ -163,12 +132,9 @@ if [ -z "$JAVA_HOME" ] ; then
   echo "Warning: JAVA_HOME environment variable is not set."
 fi
 
-CLASSWORLDS_LAUNCHER=org.codehaus.plexus.classworlds.launcher.Launcher
-
 # traverses directory structure from process work directory to filesystem root
 # first directory with .mvn subdirectory is considered project base directory
 find_maven_basedir() {
-
   if [ -z "$1" ]
   then
     echo "Path not specified to find_maven_basedir"
@@ -184,96 +150,99 @@ find_maven_basedir() {
     fi
     # workaround for JBEAP-8937 (on Solaris 10/Sparc)
     if [ -d "${wdir}" ]; then
-      wdir=`cd "$wdir/.."; pwd`
+      wdir=$(cd "$wdir/.." || exit 1; pwd)
     fi
     # end of workaround
   done
-  echo "${basedir}"
+  printf '%s' "$(cd "$basedir" || exit 1; pwd)"
 }
 
 # concatenates all lines of a file
 concat_lines() {
   if [ -f "$1" ]; then
-    echo "$(tr -s '\n' ' ' < "$1")"
+    # Remove \r in case we run on Windows within Git Bash
+    # and check out the repository with auto CRLF management
+    # enabled. Otherwise, we may read lines that are delimited with
+    # \r\n and produce $'-Xarg\r' rather than -Xarg due to word
+    # splitting rules.
+    tr -s '\r\n' ' ' < "$1"
+  fi
+}
+
+log() {
+  if [ "$MVNW_VERBOSE" = true ]; then
+    printf '%s\n' "$1"
   fi
 }
 
-BASE_DIR=`find_maven_basedir "$(pwd)"`
+BASE_DIR=$(find_maven_basedir "$(dirname "$0")")
 if [ -z "$BASE_DIR" ]; then
   exit 1;
 fi
 
+MAVEN_PROJECTBASEDIR=${MAVEN_BASEDIR:-"$BASE_DIR"}; export MAVEN_PROJECTBASEDIR
+log "$MAVEN_PROJECTBASEDIR"
+
 ##########################################################################################
 # Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
 # This allows using the maven wrapper in projects that prohibit checking in binary data.
 ##########################################################################################
-if [ -r "$BASE_DIR/.mvn/wrapper/maven-wrapper.jar" ]; then
-    if [ "$MVNW_VERBOSE" = true ]; then
-      echo "Found .mvn/wrapper/maven-wrapper.jar"
-    fi
+wrapperJarPath="$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar"
+if [ -r "$wrapperJarPath" ]; then
+    log "Found $wrapperJarPath"
 else
-    if [ "$MVNW_VERBOSE" = true ]; then
-      echo "Couldn't find .mvn/wrapper/maven-wrapper.jar, downloading it ..."
-    fi
+    log "Couldn't find $wrapperJarPath, downloading it ..."
+
     if [ -n "$MVNW_REPOURL" ]; then
-      jarUrl="$MVNW_REPOURL/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar"
+      wrapperUrl="$MVNW_REPOURL/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar"
     else
-      jarUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar"
+      wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar"
     fi
-    while IFS="=" read key value; do
-      case "$key" in (wrapperUrl) jarUrl="$value"; break ;;
+    while IFS="=" read -r key value; do
+      # Remove '\r' from value to allow usage on windows as IFS does not consider '\r' as a separator ( considers space, tab, new line ('\n'), and custom '=' )
+      safeValue=$(echo "$value" | tr -d '\r')
+      case "$key" in (wrapperUrl) wrapperUrl="$safeValue"; break ;;
       esac
-    done < "$BASE_DIR/.mvn/wrapper/maven-wrapper.properties"
-    if [ "$MVNW_VERBOSE" = true ]; then
-      echo "Downloading from: $jarUrl"
-    fi
-    wrapperJarPath="$BASE_DIR/.mvn/wrapper/maven-wrapper.jar"
+    done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
+    log "Downloading from: $wrapperUrl"
+
     if $cygwin; then
-      wrapperJarPath=`cygpath --path --windows "$wrapperJarPath"`
+      wrapperJarPath=$(cygpath --path --windows "$wrapperJarPath")
     fi
 
     if command -v wget > /dev/null; then
-        if [ "$MVNW_VERBOSE" = true ]; then
-          echo "Found wget ... using wget"
-        fi
+        log "Found wget ... using wget"
+        [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--quiet"
         if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
-            wget "$jarUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath"
+            wget $QUIET "$wrapperUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath"
         else
-            wget --http-user=$MVNW_USERNAME --http-password=$MVNW_PASSWORD "$jarUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath"
+            wget $QUIET --http-user="$MVNW_USERNAME" --http-password="$MVNW_PASSWORD" "$wrapperUrl" -O "$wrapperJarPath" || rm -f "$wrapperJarPath"
         fi
     elif command -v curl > /dev/null; then
-        if [ "$MVNW_VERBOSE" = true ]; then
-          echo "Found curl ... using curl"
-        fi
+        log "Found curl ... using curl"
+        [ "$MVNW_VERBOSE" = true ] && QUIET="" || QUIET="--silent"
         if [ -z "$MVNW_USERNAME" ] || [ -z "$MVNW_PASSWORD" ]; then
-            curl -o "$wrapperJarPath" "$jarUrl" -f
+            curl $QUIET -o "$wrapperJarPath" "$wrapperUrl" -f -L || rm -f "$wrapperJarPath"
         else
-            curl --user $MVNW_USERNAME:$MVNW_PASSWORD -o "$wrapperJarPath" "$jarUrl" -f
+            curl $QUIET --user "$MVNW_USERNAME:$MVNW_PASSWORD" -o "$wrapperJarPath" "$wrapperUrl" -f -L || rm -f "$wrapperJarPath"
         fi
-
     else
-        if [ "$MVNW_VERBOSE" = true ]; then
-          echo "Falling back to using Java to download"
-        fi
-        javaClass="$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.java"
+        log "Falling back to using Java to download"
+        javaSource="$MAVEN_PROJECTBASEDIR/.mvn/wrapper/MavenWrapperDownloader.java"
+        javaClass="$MAVEN_PROJECTBASEDIR/.mvn/wrapper/MavenWrapperDownloader.class"
         # For Cygwin, switch paths to Windows format before running javac
         if $cygwin; then
-          javaClass=`cygpath --path --windows "$javaClass"`
+          javaSource=$(cygpath --path --windows "$javaSource")
+          javaClass=$(cygpath --path --windows "$javaClass")
         fi
-        if [ -e "$javaClass" ]; then
-            if [ ! -e "$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class" ]; then
-                if [ "$MVNW_VERBOSE" = true ]; then
-                  echo " - Compiling MavenWrapperDownloader.java ..."
-                fi
-                # Compiling the Java class
-                ("$JAVA_HOME/bin/javac" "$javaClass")
+        if [ -e "$javaSource" ]; then
+            if [ ! -e "$javaClass" ]; then
+                log " - Compiling MavenWrapperDownloader.java ..."
+                ("$JAVA_HOME/bin/javac" "$javaSource")
             fi
-            if [ -e "$BASE_DIR/.mvn/wrapper/MavenWrapperDownloader.class" ]; then
-                # Running the downloader
-                if [ "$MVNW_VERBOSE" = true ]; then
-                  echo " - Running MavenWrapperDownloader.java ..."
-                fi
-                ("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader "$MAVEN_PROJECTBASEDIR")
+            if [ -e "$javaClass" ]; then
+                log " - Running MavenWrapperDownloader.java ..."
+                ("$JAVA_HOME/bin/java" -cp .mvn/wrapper MavenWrapperDownloader "$wrapperUrl" "$wrapperJarPath") || rm -f "$wrapperJarPath"
             fi
         fi
     fi
@@ -282,35 +251,58 @@ fi
 # End of extension
 ##########################################################################################
 
-export MAVEN_PROJECTBASEDIR=${MAVEN_BASEDIR:-"$BASE_DIR"}
-if [ "$MVNW_VERBOSE" = true ]; then
-  echo $MAVEN_PROJECTBASEDIR
+# If specified, validate the SHA-256 sum of the Maven wrapper jar file
+wrapperSha256Sum=""
+while IFS="=" read -r key value; do
+  case "$key" in (wrapperSha256Sum) wrapperSha256Sum=$value; break ;;
+  esac
+done < "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.properties"
+if [ -n "$wrapperSha256Sum" ]; then
+  wrapperSha256Result=false
+  if command -v sha256sum > /dev/null; then
+    if echo "$wrapperSha256Sum  $wrapperJarPath" | sha256sum -c > /dev/null 2>&1; then
+      wrapperSha256Result=true
+    fi
+  elif command -v shasum > /dev/null; then
+    if echo "$wrapperSha256Sum  $wrapperJarPath" | shasum -a 256 -c > /dev/null 2>&1; then
+      wrapperSha256Result=true
+    fi
+  else
+    echo "Checksum validation was requested but neither 'sha256sum' or 'shasum' are available."
+    echo "Please install either command, or disable validation by removing 'wrapperSha256Sum' from your maven-wrapper.properties."
+    exit 1
+  fi
+  if [ $wrapperSha256Result = false ]; then
+    echo "Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised." >&2
+    echo "Investigate or delete $wrapperJarPath to attempt a clean download." >&2
+    echo "If you updated your Maven version, you need to update the specified wrapperSha256Sum property." >&2
+    exit 1
+  fi
 fi
+
 MAVEN_OPTS="$(concat_lines "$MAVEN_PROJECTBASEDIR/.mvn/jvm.config") $MAVEN_OPTS"
 
 # For Cygwin, switch paths to Windows format before running java
 if $cygwin; then
-  [ -n "$M2_HOME" ] &&
-    M2_HOME=`cygpath --path --windows "$M2_HOME"`
   [ -n "$JAVA_HOME" ] &&
-    JAVA_HOME=`cygpath --path --windows "$JAVA_HOME"`
+    JAVA_HOME=$(cygpath --path --windows "$JAVA_HOME")
   [ -n "$CLASSPATH" ] &&
-    CLASSPATH=`cygpath --path --windows "$CLASSPATH"`
+    CLASSPATH=$(cygpath --path --windows "$CLASSPATH")
   [ -n "$MAVEN_PROJECTBASEDIR" ] &&
-    MAVEN_PROJECTBASEDIR=`cygpath --path --windows "$MAVEN_PROJECTBASEDIR"`
+    MAVEN_PROJECTBASEDIR=$(cygpath --path --windows "$MAVEN_PROJECTBASEDIR")
 fi
 
 # Provide a "standardized" way to retrieve the CLI args that will
 # work with both Windows and non-Windows executions.
-MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $@"
+MAVEN_CMD_LINE_ARGS="$MAVEN_CONFIG $*"
 export MAVEN_CMD_LINE_ARGS
 
 WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain
 
+# shellcheck disable=SC2086 # safe args
 exec "$JAVACMD" \
   $MAVEN_OPTS \
   $MAVEN_DEBUG_OPTS \
   -classpath "$MAVEN_PROJECTBASEDIR/.mvn/wrapper/maven-wrapper.jar" \
-  "-Dmaven.home=${M2_HOME}" \
   "-Dmaven.multiModuleProjectDirectory=${MAVEN_PROJECTBASEDIR}" \
   ${WRAPPER_LAUNCHER} $MAVEN_CONFIG "$@"
diff --git a/mvnw.cmd b/mvnw.cmd
index 8a15b7f31..95ba6f54a 100644
--- a/mvnw.cmd
+++ b/mvnw.cmd
@@ -7,7 +7,7 @@
 @REM "License"); you may not use this file except in compliance
 @REM with the License.  You may obtain a copy of the License at
 @REM
-@REM    http://www.apache.org/licenses/LICENSE-2.0
+@REM    https://www.apache.org/licenses/LICENSE-2.0
 @REM
 @REM Unless required by applicable law or agreed to in writing,
 @REM software distributed under the License is distributed on an
@@ -18,13 +18,12 @@
 @REM ----------------------------------------------------------------------------
 
 @REM ----------------------------------------------------------------------------
-@REM Maven Start Up Batch script
+@REM Apache Maven Wrapper startup batch script, version 3.2.0
 @REM
 @REM Required ENV vars:
 @REM JAVA_HOME - location of a JDK home dir
 @REM
 @REM Optional ENV vars
-@REM M2_HOME - location of maven2's installed home dir
 @REM MAVEN_BATCH_ECHO - set to 'on' to enable the echoing of the batch commands
 @REM MAVEN_BATCH_PAUSE - set to 'on' to wait for a keystroke before ending
 @REM MAVEN_OPTS - parameters passed to the Java VM when running Maven
@@ -120,10 +119,10 @@ SET MAVEN_JAVA_EXE="%JAVA_HOME%\bin\java.exe"
 set WRAPPER_JAR="%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.jar"
 set WRAPPER_LAUNCHER=org.apache.maven.wrapper.MavenWrapperMain
 
-set DOWNLOAD_URL="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar"
+set WRAPPER_URL="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar"
 
 FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.properties") DO (
-    IF "%%A"=="wrapperUrl" SET DOWNLOAD_URL=%%B
+    IF "%%A"=="wrapperUrl" SET WRAPPER_URL=%%B
 )
 
 @REM Extension to allow automatically downloading the maven-wrapper.jar from Maven-central
@@ -134,11 +133,11 @@ if exist %WRAPPER_JAR% (
     )
 ) else (
     if not "%MVNW_REPOURL%" == "" (
-        SET DOWNLOAD_URL="%MVNW_REPOURL%/org/apache/maven/wrapper/maven-wrapper/3.1.0/maven-wrapper-3.1.0.jar"
+        SET WRAPPER_URL="%MVNW_REPOURL%/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar"
     )
     if "%MVNW_VERBOSE%" == "true" (
         echo Couldn't find %WRAPPER_JAR%, downloading it ...
-        echo Downloading from: %DOWNLOAD_URL%
+        echo Downloading from: %WRAPPER_URL%
     )
 
     powershell -Command "&{"^
@@ -146,7 +145,7 @@ if exist %WRAPPER_JAR% (
 		"if (-not ([string]::IsNullOrEmpty('%MVNW_USERNAME%') -and [string]::IsNullOrEmpty('%MVNW_PASSWORD%'))) {"^
 		"$webclient.Credentials = new-object System.Net.NetworkCredential('%MVNW_USERNAME%', '%MVNW_PASSWORD%');"^
 		"}"^
-		"[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; $webclient.DownloadFile('%DOWNLOAD_URL%', '%WRAPPER_JAR%')"^
+		"[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; $webclient.DownloadFile('%WRAPPER_URL%', '%WRAPPER_JAR%')"^
 		"}"
     if "%MVNW_VERBOSE%" == "true" (
         echo Finished downloading %WRAPPER_JAR%
@@ -154,6 +153,24 @@ if exist %WRAPPER_JAR% (
 )
 @REM End of extension
 
+@REM If specified, validate the SHA-256 sum of the Maven wrapper jar file
+SET WRAPPER_SHA_256_SUM=""
+FOR /F "usebackq tokens=1,2 delims==" %%A IN ("%MAVEN_PROJECTBASEDIR%\.mvn\wrapper\maven-wrapper.properties") DO (
+    IF "%%A"=="wrapperSha256Sum" SET WRAPPER_SHA_256_SUM=%%B
+)
+IF NOT %WRAPPER_SHA_256_SUM%=="" (
+    powershell -Command "&{"^
+       "$hash = (Get-FileHash \"%WRAPPER_JAR%\" -Algorithm SHA256).Hash.ToLower();"^
+       "If('%WRAPPER_SHA_256_SUM%' -ne $hash){"^
+       "  Write-Output 'Error: Failed to validate Maven wrapper SHA-256, your Maven wrapper might be compromised.';"^
+       "  Write-Output 'Investigate or delete %WRAPPER_JAR% to attempt a clean download.';"^
+       "  Write-Output 'If you updated your Maven version, you need to update the specified wrapperSha256Sum property.';"^
+       "  exit 1;"^
+       "}"^
+       "}"
+    if ERRORLEVEL 1 goto error
+)
+
 @REM Provide a "standardized" way to retrieve the CLI args that will
 @REM work with both Windows and non-Windows executions.
 set MAVEN_CMD_LINE_ARGS=%*

From 1b2faaeda870fec719dccf0734e6512c01adde72 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 23 Mar 2023 09:25:20 -0400
Subject: [PATCH 0900/1013] [pom] Bump base-parent to 39

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 62778c744..902a32f38 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
   
     com.github.hazendaz
     base-parent
-    38
+    39
     
   
 

From f40bb89ad16039adae78f921ad39345bd95c4098 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 23 Mar 2023 09:25:38 -0400
Subject: [PATCH 0901/1013] [pom] Set maven-plugin-plugin to
 maven-plugin-report-plugin for site

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 902a32f38..216245798 100644
--- a/pom.xml
+++ b/pom.xml
@@ -711,7 +711,7 @@
       
       
         org.apache.maven.plugins
-        maven-plugin-plugin
+        maven-plugin-report-plugin
         ${pluginPluginVersion}
         
           

From c907103dd0b020c55ef0dd601636f810ce2b8069 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 23 Mar 2023 09:49:26 -0400
Subject: [PATCH 0902/1013] [maven-release-plugin] prepare release
 spotbugs-maven-plugin-4.7.3.3

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 216245798..586b2f21a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -11,7 +11,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.3-SNAPSHOT
+  4.7.3.3
   maven-plugin
 
   SpotBugs Maven Plugin
@@ -124,7 +124,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    HEAD
+    spotbugs-maven-plugin-4.7.3.3
   
   
     Github
@@ -147,7 +147,7 @@
     ${project.version}
 
     
-    1677374551
+    1679579347
 
     
     4.7.3

From d81fb5f652e7ef76538534ad822dbc83a4858479 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 23 Mar 2023 09:49:30 -0400
Subject: [PATCH 0903/1013] [maven-release-plugin] prepare for next development
 iteration

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 586b2f21a..6046c20dd 100644
--- a/pom.xml
+++ b/pom.xml
@@ -11,7 +11,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.3
+  4.7.3.4-SNAPSHOT
   maven-plugin
 
   SpotBugs Maven Plugin
@@ -124,7 +124,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    spotbugs-maven-plugin-4.7.3.3
+    HEAD
   
   
     Github
@@ -147,7 +147,7 @@
     ${project.version}
 
     
-    1679579347
+    1679579370
 
     
     4.7.3

From 816b63f5fe53f7e42e8af40c2c1bb574d3850ce4 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 3 Apr 2023 15:53:08 +0000
Subject: [PATCH 0904/1013] Update dependency
 com.github.javaparser:javaparser-core to v3.25.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 6046c20dd..56aec858f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -162,7 +162,7 @@
 
     1.10.13
     4.0.10
-    3.25.1
+    3.25.2
 
     1.12.0
     1.11.1

From d4e41fbd21b282d83f1768b6ea0e484b4e2848f5 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 4 Apr 2023 16:38:23 +0000
Subject: [PATCH 0905/1013] Update dependency maven to v3.9.1

---
 .mvn/wrapper/maven-wrapper.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index 43a7228f1..281ebbff8 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -14,5 +14,5 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.0/apache-maven-3.9.0-bin.zip
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.1/apache-maven-3.9.1-bin.zip
 wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

From 6156943b5eb7a93a7da95a6719554015c773524e Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 4 Apr 2023 16:38:29 +0000
Subject: [PATCH 0906/1013] Update mavenCoreVersion to v3.9.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 56aec858f..047d4f8d6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -167,7 +167,7 @@
     1.12.0
     1.11.1
 
-    3.9.0
+    3.9.1
     3.3.4
     0.13.1
     3.3.2

From 0829e3e124e0ec4ea2fc4128c3bf83aa8d0b4a72 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 5 Apr 2023 05:42:55 +0000
Subject: [PATCH 0907/1013] Update scmPluginVersion to v2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 56aec858f..c8ef5310c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -187,7 +187,7 @@
     3.5.0
     3.5.0
     3.8.1
-    1.13.0
+    2.0.0
     3.12.1
     3.6 
     2.15.0

From 5911d51e6b2db297d5e7144bf04124b7056ba82e Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 6 Apr 2023 06:59:25 +0000
Subject: [PATCH 0908/1013] Update mavenVersion to v3.9.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c8ef5310c..5bcccc1ed 100644
--- a/pom.xml
+++ b/pom.xml
@@ -173,7 +173,7 @@
     3.3.2
     3.1.1
     3.2.0
-    3.9.0
+    3.9.1
 
     2.1.1
     1.2.0

From 9c2becbc62adda9ea61ec9a4071f5770b6d9afa9 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 6 Apr 2023 06:59:29 +0000
Subject: [PATCH 0909/1013] Update slf4jVersion to v2.0.7

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c8ef5310c..3fb17b355 100644
--- a/pom.xml
+++ b/pom.xml
@@ -158,7 +158,7 @@
     5.9.2
     4.7.3
     4.7.3
-    2.0.6
+    2.0.7
 
     1.10.13
     4.0.10

From 59462fe1852f4f3b30fad6ef9cf6e5789c13da1a Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 6 Apr 2023 06:59:32 +0000
Subject: [PATCH 0910/1013] Update dependency org.ow2.asm:asm-bom to v9.5

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c8ef5310c..400d6c86c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -216,7 +216,7 @@
     5.13.1.202206130422-r
 
     
-    9.4
+    9.5
     1.9.4
     1.2
     1.15

From 1392b866831f0ca69d5e84cf0cbe2979ac6ea278 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 6 Apr 2023 06:59:56 +0000
Subject: [PATCH 0911/1013] Update dependency
 org.apache.maven.plugins:maven-invoker-plugin to v3.5.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 6272484fe..bb8194f5a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -184,7 +184,7 @@
     0.22-1
     2.1.0
     3.4.2
-    3.5.0
+    3.5.1
     3.5.0
     3.8.1
     2.0.0

From 8533efe6432a077cf5b8ac8173b74d8096ac72df Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 6 Apr 2023 07:00:00 +0000
Subject: [PATCH 0912/1013] Update groovy monorepo to v4.0.11

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 6272484fe..3ae30c2c1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -161,7 +161,7 @@
     2.0.6
 
     1.10.13
-    4.0.10
+    4.0.11
     3.25.2
 
     1.12.0

From bf3259051707fe69a9b52d93d3683058b741b5a8 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 15:41:18 -0400
Subject: [PATCH 0913/1013] [pom] Bump maven compiler to 3.11.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index e16cbb05a..cc58c14cc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -205,7 +205,7 @@
     true
 
     
-    3.10.1
+    3.11.0
     1.12.0
     3.2.0
     3.0.0-M9

From edfa06c960e00a5ab3ab4b143891d04693549b68 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 15:41:29 -0400
Subject: [PATCH 0914/1013] [pom] Bump jxr plugin to 3.3.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index cc58c14cc..b141167e7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,8 +207,8 @@
     
     3.11.0
     1.12.0
-    3.2.0
     3.0.0-M9
+    3.3.0
     8.0.0
     4.0.4
     7.4.7

From 1630a50ecef81e81539679ae54106532e71b40c6 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 15:41:38 -0400
Subject: [PATCH 0915/1013] [pom] Bump surefire to 3.0.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index b141167e7..d604ecfe2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -207,8 +207,8 @@
     
     3.11.0
     1.12.0
-    3.0.0-M9
     3.3.0
+    3.0.0
     8.0.0
     4.0.4
     7.4.7

From 3265a13b75bc1cea10e7ea7227461faf8eeece43 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 15:41:48 -0400
Subject: [PATCH 0916/1013] [pom] Bump sb contrib to 7.6.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index d604ecfe2..02782da9e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -211,7 +211,7 @@
     3.0.0
     8.0.0
     4.0.4
-    7.4.7
+    7.6.0
 
     5.13.1.202206130422-r
 

From 3845cc901d36cc47bc849e18ac2195158b49f23c Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 18:41:16 -0400
Subject: [PATCH 0917/1013] [maven-release-plugin] prepare release
 spotbugs-maven-plugin-4.7.3.4

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 02782da9e..5a41f83b5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -11,7 +11,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.4-SNAPSHOT
+  4.7.3.4
   maven-plugin
 
   SpotBugs Maven Plugin
@@ -124,7 +124,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    HEAD
+    spotbugs-maven-plugin-4.7.3.4
   
   
     Github
@@ -147,7 +147,7 @@
     ${project.version}
 
     
-    1679579370
+    1680820861
 
     
     4.7.3

From f16c805dd559d8d31aae25672cb3cc462c666e9a Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 18:41:19 -0400
Subject: [PATCH 0918/1013] [maven-release-plugin] prepare for next development
 iteration

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 5a41f83b5..3a95e2281 100644
--- a/pom.xml
+++ b/pom.xml
@@ -11,7 +11,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.4
+  4.7.3.5-SNAPSHOT
   maven-plugin
 
   SpotBugs Maven Plugin
@@ -124,7 +124,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    spotbugs-maven-plugin-4.7.3.4
+    HEAD
   
   
     Github
@@ -147,7 +147,7 @@
     ${project.version}
 
     
-    1680820861
+    1680820879
 
     
     4.7.3

From 8eba40da699b21229e6a0e623b7b33bcd4b7411c Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 18:56:15 -0400
Subject: [PATCH 0919/1013] [ci] Add to readme that java 11 required to build

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 7377cd922..037e3a0c9 100644
--- a/README.md
+++ b/README.md
@@ -12,7 +12,7 @@ Please download latest snapshots from [here](https://oss.sonatype.org/content/re
 Building spotbugs-maven-plugin Requirements
 ===========================================
 
-Java 8+ is required for spotbugs analysis.
+Java 11+ is required to build the project.  Java 8+ is required for spotbugs analysis.
 
 spotbugs-maven-plugin
 =====================

From 721511b71797e7d4dca0692b57b47cdf6471e63c Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Thu, 6 Apr 2023 19:01:56 -0400
Subject: [PATCH 0920/1013] [actions] Drop[ jdk 19, add 21-ea and use 20 ga

---
 .github/workflows/ci.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 21b804091..14b73b62e 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        java: [11, 17, 19, 20-ea]
+        java: [11, 17, 20, 21-ea]
       fail-fast: false
       max-parallel: 4
     name: Test JDK ${{ matrix.java }}, ${{ matrix.os }}

From 714b2746047a382281ce611f60cc0b2787bd91ea Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 18 Apr 2023 07:40:24 +0000
Subject: [PATCH 0921/1013] Update dependency
 org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 3a95e2281..d32b4a00f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -183,7 +183,7 @@
     1.0.0
     0.22-1
     2.1.0
-    3.4.2
+    3.4.3
     3.5.1
     3.5.0
     3.8.1

From c76625331e392928a541cb58f1e92e213aa7734f Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 21 Apr 2023 21:56:14 +0000
Subject: [PATCH 0922/1013] Update pluginPluginVersion to v3.8.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 3a95e2281..c58b7a915 100644
--- a/pom.xml
+++ b/pom.xml
@@ -186,7 +186,7 @@
     3.4.2
     3.5.1
     3.5.0
-    3.8.1
+    3.8.2
     2.0.0
     3.12.1
     3.6 

From d7c3e727662f8a723d492218d30b573338423af7 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 2 May 2023 06:47:56 +0000
Subject: [PATCH 0923/1013] Update dependency
 com.github.javaparser:javaparser-core to v3.25.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 3572c9672..01c95aa10 100644
--- a/pom.xml
+++ b/pom.xml
@@ -162,7 +162,7 @@
 
     1.10.13
     4.0.11
-    3.25.2
+    3.25.3
 
     1.12.0
     1.11.1

From 82b34731de5a95e10ef40896f805d2fa44854a3a Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 3 May 2023 22:36:19 +0000
Subject: [PATCH 0924/1013] Update dependency
 org.apache.maven.shared:maven-shared-utils to v3.4.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 01c95aa10..b7653d5d5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -168,7 +168,7 @@
     1.11.1
 
     3.9.1
-    3.3.4
+    3.4.1
     0.13.1
     3.3.2
     3.1.1

From 95d541419dc2d0f97a9741709b31f8ce7f9dc9a3 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 8 May 2023 09:07:53 +0000
Subject: [PATCH 0925/1013] Update groovy monorepo to v4.0.12

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index b7653d5d5..5b92053f0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -161,7 +161,7 @@
     2.0.7
 
     1.10.13
-    4.0.11
+    4.0.12
     3.25.3
 
     1.12.0

From e07935621897d690f83320ad7493c35b7339a2f0 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 11 May 2023 07:33:30 +0000
Subject: [PATCH 0926/1013] Update dependency maven to v3.9.2

---
 .mvn/wrapper/maven-wrapper.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index 281ebbff8..e1d6b156e 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -14,5 +14,5 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.1/apache-maven-3.9.1-bin.zip
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.2/apache-maven-3.9.2-bin.zip
 wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

From bc27af22c5aa9070321cc2ecf5db7dee2853043a Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 11 May 2023 07:33:35 +0000
Subject: [PATCH 0927/1013] Update mavenCoreVersion to v3.9.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 5b92053f0..588b6c1ac 100644
--- a/pom.xml
+++ b/pom.xml
@@ -167,7 +167,7 @@
     1.12.0
     1.11.1
 
-    3.9.1
+    3.9.2
     3.4.1
     0.13.1
     3.3.2

From 4f5a4a47c5f23bca9d9bdc2e803bd94d39d2f250 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 11 May 2023 11:36:18 +0000
Subject: [PATCH 0928/1013] Update mavenVersion to v3.9.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 5b92053f0..6836cbc8d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -173,7 +173,7 @@
     3.3.2
     3.1.1
     3.2.0
-    3.9.1
+    3.9.2
 
     2.1.1
     1.2.0

From 5e106da0633217081df40a62d18c3ba8bae73b14 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 15 May 2023 19:15:26 +0000
Subject: [PATCH 0929/1013] Update dependency
 org.apache.maven.shared:maven-shared-utils to v3.4.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 846883838..d87f3308f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -168,7 +168,7 @@
     1.11.1
 
     3.9.2
-    3.4.1
+    3.4.2
     0.13.1
     3.3.2
     3.1.1

From 7898f7319e86f41fd18848cead0404ed5108b5f8 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 15 May 2023 19:15:30 +0000
Subject: [PATCH 0930/1013] Update dependency
 org.apache.maven.plugins:maven-plugin-report-plugin to v3.9.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 846883838..fd1bbb59c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -186,7 +186,7 @@
     3.4.3
     3.5.1
     3.5.0
-    3.8.2
+    3.9.0
     2.0.0
     3.12.1
     3.6 

From 87a4525c2374e20919b983c45233b77f4e2ee592 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 16 May 2023 23:27:21 +0000
Subject: [PATCH 0931/1013] Update dependency commons-io:commons-io to v2.12.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index fd9ae85ab..1d89f1a45 100644
--- a/pom.xml
+++ b/pom.xml
@@ -222,7 +222,7 @@
     1.15
     3.2.2
     2.1
-    2.11.0
+    2.12.0
     2.6
     3.12.0
 

From 615b1fa0fbbdcb093d887afca74d4cf6aedb8a3d Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 18 May 2023 15:49:50 +0000
Subject: [PATCH 0932/1013] Update scmPluginVersion to v2.0.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 1d89f1a45..e9dead0ec 100644
--- a/pom.xml
+++ b/pom.xml
@@ -187,7 +187,7 @@
     3.5.1
     3.5.0
     3.9.0
-    2.0.0
+    2.0.1
     3.12.1
     3.6 
     2.15.0

From fef61f51f12fcd6a6a443c756d9adcb34ae60456 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 23 Apr 2023 19:34:50 -0400
Subject: [PATCH 0933/1013] [actions] Bump maven wrapper to 3.2.0

---
 .github/workflows/it-maven339.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven339.yaml
index edd135b41..57781bb4c 100644
--- a/.github/workflows/it-maven339.yaml
+++ b/.github/workflows/it-maven339.yaml
@@ -33,7 +33,7 @@ jobs:
           java-version: 17
           distribution: 'zulu'
       - name: Load Maven 3.3.9
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.1.1:wrapper -Dmaven=3.3.9 --no-transfer-progress
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=3.3.9 --no-transfer-progress
       - name: Build Setup
         run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9
       - name: Integration Test with Maven

From 43d88e77ff5fa1c46a2315c285a948cfe7e615fb Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Fri, 12 May 2023 13:01:02 -0400
Subject: [PATCH 0934/1013] [mvn] Update maven wrapper

---
 .mvn/maven.config                        | 1 +
 .mvn/settings.xml                        | 1 +
 .mvn/wrapper/MavenWrapperDownloader.java | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.mvn/maven.config b/.mvn/maven.config
index 956533e67..afdcfab79 100644
--- a/.mvn/maven.config
+++ b/.mvn/maven.config
@@ -1 +1,2 @@
 -Daether.checksums.algorithms=SHA-512,SHA-256,SHA-1,MD5
+-Daether.connector.smartChecksums=false
diff --git a/.mvn/settings.xml b/.mvn/settings.xml
index 286ffa682..ace67a1cd 100644
--- a/.mvn/settings.xml
+++ b/.mvn/settings.xml
@@ -7,6 +7,7 @@
       ${env.CI_DEPLOY_USERNAME}
       ${env.CI_DEPLOY_PASSWORD}
     
+    
     
       gh-pages-scm
       
diff --git a/.mvn/wrapper/MavenWrapperDownloader.java b/.mvn/wrapper/MavenWrapperDownloader.java
index 84d1e60d8..f57fd86fb 100644
--- a/.mvn/wrapper/MavenWrapperDownloader.java
+++ b/.mvn/wrapper/MavenWrapperDownloader.java
@@ -7,7 +7,7 @@
  * "License"); you may not use this file except in compliance
  * with the License.  You may obtain a copy of the License at
  *
- *  http://www.apache.org/licenses/LICENSE-2.0
+ *  https://www.apache.org/licenses/LICENSE-2.0
  *
  * Unless required by applicable law or agreed to in writing,
  * software distributed under the License is distributed on an

From 78ae9fb40908cae34de07413a61d011c7ea4fea8 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 22 May 2023 16:23:41 -0400
Subject: [PATCH 0935/1013] [pom] Bump junit to 5.9.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index e9dead0ec..dddb186d3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -155,7 +155,7 @@
     
     1.8
 
-    5.9.2
+    5.9.3
     4.7.3
     4.7.3
     2.0.7

From 73901f4843141e51edc6bc5c03ed8cc60caa4480 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Tue, 23 May 2023 17:34:58 -0400
Subject: [PATCH 0936/1013] [ci] Update readme for spotbugs maven gui to match
 4.7.3.4 version

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 037e3a0c9..bdf588af6 100644
--- a/README.md
+++ b/README.md
@@ -61,7 +61,7 @@ mvn -Dmaven.surefire.debug="-Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspe
 
 Run gui with a specific version 
 ```
-mvn com.github.spotbugs:spotbugs-maven-plugin:4.0.0:gui
+mvn com.github.spotbugs:spotbugs-maven-plugin:4.7.3.4:gui
 ```
 
 ## Contributing ##

From 2d51fdf5d198ec516d01474edff29797db51addb Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Tue, 23 May 2023 17:35:13 -0400
Subject: [PATCH 0937/1013] [pom] Move from plexus utils to plexus xml 4.0.0

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index dddb186d3..caf146211 100644
--- a/pom.xml
+++ b/pom.xml
@@ -177,7 +177,7 @@
 
     2.1.1
     1.2.0
-    3.5.1
+    4.0.0
 
     3.1.0
     1.0.0
@@ -575,8 +575,8 @@
     
     
       org.codehaus.plexus
-      plexus-utils
-      ${plexusUtilsVersion}
+      plexus-xml
+      ${plexusXmlVersion}
     
   
 

From 0e00bc1859fc3a8a86d7e6e0e1672556a5443dd3 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Tue, 23 May 2023 22:16:51 -0400
Subject: [PATCH 0938/1013] [cleanup] Correct new Object[] usage for groovy
 style

---
 .../org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
index df50d2131..30a7e0df8 100644
--- a/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
+++ b/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
@@ -507,8 +507,8 @@ class SpotbugsReportGenerator implements SpotBugsInfo {
 
         // Dollar '$' for nested classes is not valid character in sink.anchor() and therefore it is ignored
         // https://github.com/spotbugs/spotbugs-maven-plugin/issues/236
-        sink.unknown(HtmlMarkup.A.toString(), new Object[] { HtmlMarkup.TAG_TYPE_START }, new SinkEventAttributeSet(SinkEventAttributes.NAME, bugClass));
-        sink.unknown(HtmlMarkup.A.toString(), new Object[] { HtmlMarkup.TAG_TYPE_END }, null);
+        sink.unknown(HtmlMarkup.A.toString(), [HtmlMarkup.TAG_TYPE_START] as Object[], new SinkEventAttributeSet(SinkEventAttributes.NAME, bugClass));
+        sink.unknown(HtmlMarkup.A.toString(), [HtmlMarkup.TAG_TYPE_END] as Object[], null);
 
         sink.section2()
         sink.sectionTitle2()

From 55eb3e255e81f48a3dab4d47f2a16bd2a4715493 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Tue, 23 May 2023 22:28:10 -0400
Subject: [PATCH 0939/1013] [git] Add factory path to git ignore

---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.gitignore b/.gitignore
index 9a39a682a..8705079f5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,3 +11,4 @@ target/
 *.releaseBackup
 release.properties
 .mvn/wrapper/maven-wrapper.jar
+.factorypath

From 796a0f37ba8285e4ad61fe7a563d68f9b1ea310d Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 24 May 2023 04:29:04 +0000
Subject: [PATCH 0940/1013] Update dependency
 org.codehaus.gmavenplus:gmavenplus-plugin to v3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index caf146211..b1d326b4b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -182,7 +182,7 @@
     3.1.0
     1.0.0
     0.22-1
-    2.1.0
+    3.0.0
     3.4.3
     3.5.1
     3.5.0

From 24cf93b054b98165ab6e3c2fbf6e79b6de8562fa Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 26 May 2023 16:20:31 +0000
Subject: [PATCH 0941/1013] Update JamesIves/github-pages-deploy-action action
 to v4.4.2

---
 .github/workflows/site.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml
index 0eae1df8f..420fcbf98 100644
--- a/.github/workflows/site.yaml
+++ b/.github/workflows/site.yaml
@@ -25,7 +25,7 @@ jobs:
           CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Deploy Site to gh-pages
-        uses: JamesIves/github-pages-deploy-action@v4.4.1
+        uses: JamesIves/github-pages-deploy-action@v4.4.2
         with:
           SSH: true
           BRANCH: gh-pages

From fad1efe08f4e47092003ad7952c296b73711ceda Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 29 May 2023 15:27:24 +0000
Subject: [PATCH 0942/1013] Update dependency
 org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.4

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index b1d326b4b..8c360270b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -183,7 +183,7 @@
     1.0.0
     0.22-1
     3.0.0
-    3.4.3
+    3.4.4
     3.5.1
     3.5.0
     3.9.0

From 3d2679c4f842e4e74bdd851cf7ef1f9859f114e4 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 30 May 2023 00:47:51 +0000
Subject: [PATCH 0943/1013] Update dependency com.github.hazendaz:base-parent
 to v40

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 8c360270b..14a881f83 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
   
     com.github.hazendaz
     base-parent
-    39
+    40
     
   
 

From edf6cb0eb77b443cf815aef33b52144015cfc15f Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 7 Jun 2023 23:30:53 +0000
Subject: [PATCH 0944/1013] Update dependency commons-io:commons-io to v2.13.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 14a881f83..2d9f21eea 100644
--- a/pom.xml
+++ b/pom.xml
@@ -222,7 +222,7 @@
     1.15
     3.2.2
     2.1
-    2.12.0
+    2.13.0
     2.6
     3.12.0
 

From b8ee524e7f899f859f27c0b6948d3939848fe99e Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 7 Jun 2023 23:46:40 +0000
Subject: [PATCH 0945/1013] Update dependency
 org.codehaus.mojo:versions-maven-plugin to v2.16.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 2d9f21eea..6fe4c9a1b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -190,7 +190,7 @@
     2.0.1
     3.12.1
     3.6 
-    2.15.0
+    2.16.0
 
     false
     ${project.build.directory}/it-src-spotbugs

From e8293e0668c6f18b0036f659f8d1b24ba15365ef Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 8 Jun 2023 01:01:28 +0000
Subject: [PATCH 0946/1013] Update dependency
 org.apache.maven.plugins:maven-project-info-reports-plugin to v3.4.5

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 6fe4c9a1b..1cd5d7ed4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -183,7 +183,7 @@
     1.0.0
     0.22-1
     3.0.0
-    3.4.4
+    3.4.5
     3.5.1
     3.5.0
     3.9.0

From e8e5aac578f58c4d258ca371430f2a7e0fd9cc1c Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 15 Jun 2023 08:34:41 +0000
Subject: [PATCH 0947/1013] Update dependency
 org.apache.maven.plugins:maven-invoker-plugin to v3.6.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 1cd5d7ed4..c27269a71 100644
--- a/pom.xml
+++ b/pom.xml
@@ -184,7 +184,7 @@
     0.22-1
     3.0.0
     3.4.5
-    3.5.1
+    3.6.0
     3.5.0
     3.9.0
     2.0.1

From 05846868ed5f736a4bef794735525d58654ea2b0 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 29 May 2023 19:37:05 -0400
Subject: [PATCH 0948/1013] [pom] Fix name tag

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c27269a71..bc75a4e6f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -14,7 +14,7 @@
   4.7.3.5-SNAPSHOT
   maven-plugin
 
-  SpotBugs Maven Plugin
+  spotbugs-maven-plugin
   This Plug-In generates reports based on the SpotBugs Library
   https://spotbugs.github.io/spotbugs-maven-plugin/
   2005

From 8a64606aa952b9475dc23feeb466ca4b0bc9cf8a Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 01:49:36 -0400
Subject: [PATCH 0949/1013] [cleanup] Delete legacy changes.xml as not used in
 long time

---
 src/changes/changes.xml | 253 ----------------------------------------
 1 file changed, 253 deletions(-)
 delete mode 100644 src/changes/changes.xml

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
deleted file mode 100644
index 75f85792c..000000000
--- a/src/changes/changes.xml
+++ /dev/null
@@ -1,253 +0,0 @@
-
-  
-    SpotBugs Maven plugin Changelog
-    
-      Garvin LeClaire
-    
-  
-  
-    
-        
-            Releasing support for spot bugs 4.0
-        
-    
-    
-        
-            Rebrand and upgrade to using spotbugs
-        
-    
-    
-      
-        Update to Findbugs 1.3.9
-      
-      
-        Add abilty set memory as an option
-      
-      
-        Add timeout option
-      
-      
-        Allow to fork a VM that runs findbugs
-      
-    
-    
-      
-        Update to Findbugs 1.3.8
-      
-    
-    
-      
-        Update to Findbugs 1.3.7
-      
-      
-        Default binding of goal check to the lifecycle verify phase
-      
-      
-        update to gmaven-plugin version 1.0-rc-3
-      
-      
-        Fail on project without any classes
-      
-      
-         FindBugs report doens't show priority of bug
-      
-      
-        Site example for multiprojects doesn't work
-      
-      
-         Add the ability to launch the Findbugs GUI
-      
-      
-        StackOverflow exception (Infinite Recursion?)
-      
-      
-        When there are no class, findbugs crash
-      
-      
-        Fail build if findbugs detects bugs
-      
-      
-        Add Integration Tests using shitty plugin
-      
-      
-        Unable to provide references to "resources" in excludeFilterFile/includeFilterFile configuration parameters
-        (multimodule setup)
-      
-      
-        Specifying a pluginList configuration value throws an exception
-      
-    
-    
-      
-        Fix file encoding used to generate xdoc report to use UTF-8
-      
-      
-        Added support for Findbugs v1.2.1
-      
-      
-        wrong class in xml report
-      
-      
-        malformed AnalysisError element in XML report when reporting on generic class
-      
-      
-        Add groovy nature to pom.xml
-      
-      
-        Added the ability to run the FindBugs native xml reporter
-      
-      
-        Fix findbugs xdoc format associates some bug instances with the last file processed.
-      
-      
-        Allow the use or URIs for includeFilter and excludeFilter.
-      
-      
-        Added Source Directory output to xml output.
-      
-      
-        Fixed invalid HTML issues.
-      
-    
-    
-      
-        Fixed Duplicate XML entries.
-      
-      
-        Changed XML encoding to ISO-8859-1.
-      
-      
-        Fix XML well-formed issues.
-      
-    
-    
-      
-        Fix FAQ dcoumentation to correct aggregate explanation.
-      
-      
-        Fix JXR link reference for inner classes.
-      
-      
-        Add the ability to skip Findbugs report with the
-        findbugs.skip property.
-      
-      
-        Added support for Findbugs v1.2.0
-      
-      
-        Changed from Findbug object to Findbug2 object to
-        resolve missing classes message. Suggestion from Henri
-        Tremblay
-      
-      
-        Fixed addition of compile artifacts to FindBug's
-        AuxClasspath to resolve missing classes message.
-      
-      
-        Added relaxed option.
-      
-      
-        Added onlyAnalyze option.
-      
-    
-    
-      
-        Fixed escape characters output for message attribute in
-        xml format.
-      
-      
-        Added the ability to select an output directory for the
-        xml report output.
-      
-      
-        Update maven-artifact dependency to version 2.0.4
-      
-      
-        Update maven-reporting dependency to version 2.0.4
-      
-      
-        Fix documentation to pass docck:check test
-      
-      
-        Added summary to HTML report for Classes scanned,
-        errors, bugs and missing classes
-      
-      
-        Added file bug subtotal to the File Section of the HTML
-        report
-      
-      
-        Added support for Findbugs v1.1.1
-      
-      
-        Add xml report output option.
-      
-      
-        Fix a typo on the usage page.
-      
-      
-        changed JXR dependencies to maven-jxr-plugin from
-        jxr-maven-plugin.
-      
-    
-    
-      
-        Added support for using third-party plugins
-      
-      
-        Added support for specifying Visitors to include and
-        exclude
-      
-      
-        Added Findbugs version to report header
-      
-      
-        Fixed resolution of FindBugs coreplugin.
-      
-      Enhanced JavaDoc.
-      
-        Upgraded findbugs to version 1.0.0.
-      
-      
-        Added suppression of FindBugs System.out output.
-      
-      
-        adds support for effort parameter (min,default,max) and
-        showing it in the report
-      
-      
-        adds support for specifying include and exclude filter
-        file
-      
-      
-        changes report name to "FindBugs Report", was previously
-        "Maven FindBugs Report"
-      
-      
-        fixes line number column: "5-5" changed to "5". "-1"
-        changed to "Not available"
-      
-      
-        adds a new details column with long description name
-        that also links to findbugs official site for
-        descriptions
-      
-      
-        Added a hyperlink in the report pointing to the source
-        generated by the maven-jxr-plugin. The link to the
-        javadoc was not implemented. Enable/Disable of the
-        plugin was not implemented.
-      
-      
-        Added the auxiliary classpath from the pom to the
-        findbugs configuration.
-      
-      
-        Upgraded jaxen to version 1.0-FCS.
-      
-      
-        Added dependency to saxpath - needed by jaxen.
-      
-    
-  
-

From 7e7c907304c6b1d32debe87c96905c6a6a61979e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 01:50:35 -0400
Subject: [PATCH 0950/1013] [site] Bump fluido skin to 1.11.2

---
 src/site/site.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/site/site.xml b/src/site/site.xml
index cfc665842..02714f70d 100644
--- a/src/site/site.xml
+++ b/src/site/site.xml
@@ -10,7 +10,7 @@
   
     org.apache.maven.skins
     maven-fluido-skin
-    1.11.1
+    1.11.2
   
 
   

From 18ad34cf118651f90525baa88a969c0a928a8524 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 01:54:08 -0400
Subject: [PATCH 0951/1013] [cleanup] Delete the groovy version test as not
 used by project

---
 versionTest.groovy | 128 ---------------------------------------------
 1 file changed, 128 deletions(-)
 delete mode 100644 versionTest.groovy

diff --git a/versionTest.groovy b/versionTest.groovy
deleted file mode 100644
index 274125274..000000000
--- a/versionTest.groovy
+++ /dev/null
@@ -1,128 +0,0 @@
-#!/usr/bin/env groovy
-
-/*
- *
- * Usage Examples
- * 
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin -b
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin -l NoBuildTestResults.txt
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin -l NoBuildTestResults.txt -f
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin -l BuildTestResults.txt -b
- * groovy versionTest -m /opt -p /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin -l BuildTestResults.txt -b -f
- *
- */
-
-
-def javaHome = System.getenv("JAVA_HOME")
-File logFile
-def buildPlugin = false
-def mvnPhase = ""
-def mvnCleanPhase = ""
-def verbose = false
-def retVal
-def stopFail = false
-
-def cli = new CliBuilder(usage:'versionTest -m maven.top.directory -p path  <-l logfile> <-b> <-v> <-f>')
-cli.h(longOpt: 'help', 'usage information')
-cli.m(argName: 'maven.top.directory',  longOpt: 'maven', required: true, args: 1, type:GString, 'Maven top directory containing version of Mven for test')
-cli.p(argName: 'path',  longOpt: 'path', required: true, args: 1, type:GString, 'Path for System')
-cli.l(argName: 'log',  longOpt: 'logFile', required: false, args: 1, type:GString, 'Optional log file')
-cli.b(argName: 'build',  longOpt: 'build', required: false, args: 0, type:GString, 'build every time')
-cli.v(argName: 'verbose',  longOpt: 'verbose', required: false, args: 0, type:GString, 'Run Maven in verbose mode')
-cli.f(argName: 'fail',  longOpt: 'fail', required: false, args: 0, type:GString, 'stop test if any fail')
-
-
-def opt = cli.parse(args)
-if (!opt) { return }
-if (opt.h) opt.usage()
-if (opt.m) mavenTopDir = opt.m
-if (opt.p) executePath = opt.p
-if (opt.l) logFile = new File(opt.l)
-if (opt.b) buildPlugin = true
-if (opt.f) stopFail = true
-
-if (logFile) {
-  logFile.write "\n"
-}
-
-
-println "Maven Top Directory is ${mavenTopDir}"
-
-mavenDirs = []
-
-new File(mavenTopDir).eachDir{ dir ->
-  if (dir.name.startsWith("maven-")) {
-    println "This Maven directory is ${dir.name}"
-    mavenDirs << dir
-  }
-}
-
-
-//mavenDirs.sort() {a,b -> a.name.padRight(12, '0').compareTo(b.name.padRight(12, '0')) }
-//quick and dirty sort
-mavenDirs.sort{it.name.substring(6).padLeft(6, '0')}
-println mavenDirs
-
-String[] ENVtoArray() { ENV.collect { k, v -> "$k=$v" } }
-
-if (buildPlugin) {
-  mvnPhase = "-Dshit=true install"
-  mvnCleanPhase = "clean shitty:clean"
-} else {
-  mvnPhase = "shitty:test"
-  mvnCleanPhase = "shitty:clean"
-}
-
-if (verbose) {
-  mvnPhase = "-v " + mvnPhase
-}
-
-try {
-  mavenDirs.each(){ mavenDir ->
-    ENV = [JAVA_HOME: javaHome]
-    ENV.M2_HOME = mavenDir.getAbsolutePath()
-    ENV.PATH = executePath + File.pathSeparator + "${mavenDir}/bin"
-    ENVtoArray()
-  
-    println "****************************************"
-    proc = "mvn -version".execute(ENVtoArray(), null)
-    proc.waitFor()
-    procText = proc.text
-    println procText
-    println "****************************************"
-
-    if (logFile) {
-      logFile << procText
-    }
-
-    println "Executing cleaning => ${mavenDir}/bin/mvn -Dshit=true ${mvnCleanPhase}"
-    proc = "${mavenDir}/bin/mvn ${mvnCleanPhase}".execute(ENVtoArray(), null)
-    retVal = proc.waitFor()
-    procText = proc.text
-    println procText
-
-
-    if (logFile) {
-      logFile << procText
-    }
-
-    println "Executing => ${mavenDir}/bin/mvn -Dshit=true ${mvnPhase}"
-    proc = "${mavenDir}/bin/mvn ${mvnPhase}".execute(ENVtoArray(), null)
-    retVal = proc.waitFor()
-    procText = proc.text
-    println procText
-
-
-    if (logFile) {
-      logFile << procText
-    }
-
-    if (stopFail && retVal > 0 ) {
-      println "Process Failed"
-      throw new Exception("Break")
-    }
-  }
-} catch (Exception e) { } // just drop the exception
-
-

From b07614d69ae3bc55aa5b38eb7aa215031f3ee510 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:16:06 -0400
Subject: [PATCH 0952/1013] [pom] Override gson to 2.10.1

---
 pom.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pom.xml b/pom.xml
index bc75a4e6f..4e31a718e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -222,6 +222,7 @@
     1.15
     3.2.2
     2.1
+    2.10.1
     2.13.0
     2.6
     3.12.0
@@ -297,6 +298,13 @@
       asm-util
     
 
+    
+    
+      com.google.code.gson
+      gson
+      ${gson.version}
+    
+
     
     
       org.apache.ant

From fd7ed1cd909d27e765da9fd94b61dddfd2585c6e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:16:17 -0400
Subject: [PATCH 0953/1013] [pom] Override bcel to 6.7.0

---
 pom.xml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pom.xml b/pom.xml
index 4e31a718e..1026240ce 100644
--- a/pom.xml
+++ b/pom.xml
@@ -217,6 +217,7 @@
 
     
     9.5
+    6.7.0
     1.9.4
     1.2
     1.15
@@ -298,6 +299,13 @@
       asm-util
     
 
+    
+    
+      org.apache.bcel
+      bcel
+      ${bcel.version}
+    
+
     
     
       com.google.code.gson

From f604640e6b37f6815f22dddd60fce798d956c140 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:22:33 -0400
Subject: [PATCH 0954/1013] [pom] Cleanup exclusions

---
 pom.xml | 40 ++++++----------------------------------
 1 file changed, 6 insertions(+), 34 deletions(-)

diff --git a/pom.xml b/pom.xml
index 1026240ce..827f695e5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -332,11 +332,11 @@
       
         
           org.apache.ant
-          ant-junit
+          ant-antlr
         
         
           org.apache.ant
-          ant-antlr
+          ant-junit
         
       
     
@@ -477,32 +477,16 @@
       ${doxiaSiteToolsVersion}
       
         
-          org.codehaus.plexus
-          plexus-component-api
-        
-        
-          org.codehaus.plexus
-          plexus-container-default
-        
-        
-          org.apache.struts
-          struts-taglib
-        
-        
-          org.apache.struts
-          struts-tiles
-        
-        
-          org.apache.struts
-          struts-core
+          commons-logging
+          commons-logging
         
         
           dom4j
           dom4j
         
         
-          commons-logging
-          commons-logging
+          org.codehaus.plexus
+          plexus-container-default
         
       
     
@@ -571,23 +555,11 @@
       org.codehaus.plexus
       plexus-container-default
       ${plexusContainerVersion}
-      
-          
-              com.google.collections
-              google-collections
-          
-      
     
     
       org.codehaus.plexus
       plexus-resources
       ${plexusResourcesVersion}
-      
-        
-          org.codehaus.plexus
-          plexus-container-default
-        
-      
     
     
       org.codehaus.plexus

From 6e6aebfd54802bb34e65124ca4af6c0bba479d94 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:26:38 -0400
Subject: [PATCH 0955/1013] [pom] Exclude junit 4

---
 pom.xml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/pom.xml b/pom.xml
index 827f695e5..7842c0dd7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -555,6 +555,12 @@
       org.codehaus.plexus
       plexus-container-default
       ${plexusContainerVersion}
+      
+          
+              junit
+              junit
+          
+      
     
     
       org.codehaus.plexus

From 410f6563c29fccd05548ea9cb249ef280af5c8a1 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:52:02 -0400
Subject: [PATCH 0956/1013] [pom] Add plexus-utils back

required by doxia
---
 pom.xml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/pom.xml b/pom.xml
index 7842c0dd7..6a4c4eba9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -177,6 +177,7 @@
 
     2.1.1
     1.2.0
+    4.0.0
     4.0.0
 
     3.1.0
@@ -567,6 +568,11 @@
       plexus-resources
       ${plexusResourcesVersion}
     
+    
+      org.codehaus.plexus
+      plexus-utils
+      ${plexusXmlVersion}
+    
     
       org.codehaus.plexus
       plexus-xml

From 5441595b522558cea4ba3bebcd7299800b09ab8f Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 03:02:02 -0400
Subject: [PATCH 0957/1013] [pom] Go back to plexus utils 3.5.1

---
 pom.xml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6a4c4eba9..312cd809c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -177,8 +177,7 @@
 
     2.1.1
     1.2.0
-    4.0.0
-    4.0.0
+    3.5.1
 
     3.1.0
     1.0.0
@@ -571,12 +570,7 @@
     
       org.codehaus.plexus
       plexus-utils
-      ${plexusXmlVersion}
-    
-    
-      org.codehaus.plexus
-      plexus-xml
-      ${plexusXmlVersion}
+      ${plexusUtilsVersion}
     
   
 

From e2ed84fcb204b586a7aa55fa7ee16e454fde446e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 02:30:01 -0400
Subject: [PATCH 0958/1013] [pom] Override jaxen to 2.0.0

---
 pom.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/pom.xml b/pom.xml
index 312cd809c..37b591833 100644
--- a/pom.xml
+++ b/pom.xml
@@ -225,6 +225,7 @@
     2.1
     2.10.1
     2.13.0
+    2.0.0
     2.6
     3.12.0
 
@@ -374,6 +375,12 @@
       ${javaparserVersion}
     
 
+    
+      jaxen
+      jaxen
+      ${jaxen.version}
+    
+
     
     
       org.apache.maven.reporting

From 753024210d8e31da3e4e0bb224eec680e9f42675 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 12:20:34 -0400
Subject: [PATCH 0959/1013] [GHA] Update github actions and add maven 4

---
 .github/workflows/coveralls.yaml              | 16 --------------
 .../{it-maven339.yaml => it-maven-3.3.9.yaml} | 18 ---------------
 .github/workflows/it-maven-4.0.0.yaml         | 22 +++++++++++++++++++
 .github/workflows/it.yaml                     | 18 ---------------
 4 files changed, 22 insertions(+), 52 deletions(-)
 rename .github/workflows/{it-maven339.yaml => it-maven-3.3.9.yaml} (51%)
 create mode 100644 .github/workflows/it-maven-4.0.0.yaml

diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml
index 5830a9c88..dc2632da7 100644
--- a/.github/workflows/coveralls.yaml
+++ b/.github/workflows/coveralls.yaml
@@ -1,19 +1,3 @@
-#
-#    Copyright 2015-2020 the original author or authors.
-#
-#    Licensed under the Apache License, Version 2.0 (the "License");
-#    you may not use this file except in compliance with the License.
-#    You may obtain a copy of the License at
-#
-#       http://www.apache.org/licenses/LICENSE-2.0
-#
-#    Unless required by applicable law or agreed to in writing, software
-#    distributed under the License is distributed on an "AS IS" BASIS,
-#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-#    See the License for the specific language governing permissions and
-#    limitations under the License.
-#
-
 name: Coveralls
 
 on: [push, pull_request]
diff --git a/.github/workflows/it-maven339.yaml b/.github/workflows/it-maven-3.3.9.yaml
similarity index 51%
rename from .github/workflows/it-maven339.yaml
rename to .github/workflows/it-maven-3.3.9.yaml
index 57781bb4c..937d77683 100644
--- a/.github/workflows/it-maven339.yaml
+++ b/.github/workflows/it-maven-3.3.9.yaml
@@ -1,21 +1,3 @@
-#
-#    Copyright 2011-2020 the original author or authors.
-#
-#    This program is free software; you can redistribute it and/or
-#    modify it under the terms of the GNU General Public License
-#    as published by the Free Software Foundation; either version 2
-#    of the License, or (at your option) any later version.
-#
-#    You may obtain a copy of the License at
-#
-#       https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-
 name: Java Integration Tests Maven 3.3.9
 
 on: [push, pull_request]
diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
new file mode 100644
index 000000000..cb67f2b97
--- /dev/null
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -0,0 +1,22 @@
+name: Java Integration Tests Maven 4.0.0-alpha-5
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    name: Integration Tests Maven 4.0.0-alpha-5
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Set up JDK
+        uses: actions/setup-java@v3
+        with:
+          java-version: 17
+          distribution: 'zulu'
+      - name: Load Maven 4.0.0-alpha-5
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-5 --no-transfer-progress
+      - name: Build Setup
+        run: ./mvnw -B -V clean install -Dmaven.min-version=4.0.0-alpha-5
+      - name: Integration Test with Maven
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dmaven.min-version=4.0.0-alpha-5
diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml
index 07f665a96..1f103a465 100644
--- a/.github/workflows/it.yaml
+++ b/.github/workflows/it.yaml
@@ -1,21 +1,3 @@
-#
-#    Copyright 2011-2020 the original author or authors.
-#
-#    This program is free software; you can redistribute it and/or
-#    modify it under the terms of the GNU General Public License
-#    as published by the Free Software Foundation; either version 2
-#    of the License, or (at your option) any later version.
-#
-#    You may obtain a copy of the License at
-#
-#       https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-
 name: Java Integration Tests
 
 on: [push, pull_request]

From 6279f5f13393faa361247b8526d3c529a1ad8e9f Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 12:21:42 -0400
Subject: [PATCH 0960/1013] [pom] Remove old groovy 1.8 setting for java
 version as now fixed

---
 pom.xml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 37b591833..7ce840a37 100644
--- a/pom.xml
+++ b/pom.xml
@@ -152,9 +152,6 @@
     
     4.7.3
 
-    
-    1.8
-
     5.9.3
     4.7.3
     4.7.3

From 3bd90909c75de9bc016b18e117fb947bb7890599 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 12:40:22 -0400
Subject: [PATCH 0961/1013] [license] Automate license application

---
 .mvn/extensions.xml                           | 17 ++++++++++
 .mvn/settings.xml                             | 17 ++++++++++
 LICENSE_HEADER                                | 13 +++++++
 pom.xml                                       | 17 ++++++++++
 .../mojo/spotbugsmavenplugin/it/App.java      | 15 ++++++++
 .../mojo/spotbugsmavenplugin/it/FooTest.java  | 15 ++++++++
 src/it-tools/build-tools/invoker.properties   | 16 +++++++++
 src/it-tools/build-tools/pom.xml              |  4 ++-
 .../baseline/spotbugs-baseline-other.xml      | 17 ++++++++++
 .../spotbugs-baseline-outputstream.xml        | 17 ++++++++++
 .../resources/baseline/spotbugs-baseline.xml  | 17 ++++++++++
 .../main/resources/filters/lib-filter2.xml    | 17 ++++++++++
 .../main/resources/whizbang/lib-filter.xml    | 17 ++++++++++
 src/it-tools/build-tools/verify.groovy        |  3 +-
 src/it-tools/prime/invoker.properties         | 16 +++++++++
 src/it-tools/prime/pom.xml                    |  4 ++-
 .../main/resources/filters/lib-filter2.xml    | 17 ++++++++++
 .../main/resources/whizbang/lib-filter.xml    | 17 ++++++++++
 src/it-tools/prime/verify.groovy              |  3 +-
 src/it/MFINDBUGS-145/invoker.properties       | 16 +++++++++
 src/it/MFINDBUGS-145/pom.xml                  |  4 ++-
 .../it/mfindbugs145/App.java                  | 15 ++++++++
 src/it/MFINDBUGS-178/invoker.properties       | 16 +++++++++
 src/it/MFINDBUGS-178/pom.xml                  |  4 ++-
 src/it/basic-1/invoker.properties             | 16 +++++++++
 src/it/basic-1/pom.xml                        |  4 ++-
 src/it/basic-1/verify.groovy                  |  3 +-
 src/it/change-xml-filename/invoker.properties | 16 +++++++++
 src/it/change-xml-filename/pom.xml            |  4 ++-
 src/it/change-xml-filename/verify.groovy      |  3 +-
 .../invoker.properties                        | 16 +++++++++
 src/it/check-bug-file-multi-list/pom.xml      |  4 ++-
 .../check-bug-file-multi-list/verify.groovy   |  3 +-
 .../check-bug-file-multi/invoker.properties   | 16 +++++++++
 src/it/check-bug-file-multi/pom.xml           |  4 ++-
 src/it/check-bug-file-multi/verify.groovy     |  3 +-
 src/it/check-bug-file/invoker.properties      | 16 +++++++++
 src/it/check-bug-file/pom.xml                 |  4 ++-
 src/it/check-bug-file/verify.groovy           |  3 +-
 .../invoker.properties                        | 16 +++++++++
 src/it/check-bug-only-test-sources/pom.xml    |  4 ++-
 .../check-bug-only-test-sources/verify.groovy |  3 +-
 src/it/check-fail/invoker.properties          | 16 +++++++++
 src/it/check-fail/pom.xml                     |  4 ++-
 src/it/check-fail/verify.groovy               |  3 +-
 src/it/check-failThreshold/invoker.properties | 16 +++++++++
 src/it/check-failThreshold/pom.xml            |  4 ++-
 src/it/check-failThreshold/verify.groovy      |  3 +-
 src/it/check-jvmargs/invoker.properties       | 16 +++++++++
 src/it/check-jvmargs/pom.xml                  |  4 ++-
 src/it/check-jvmargs/verify.groovy            |  3 +-
 .../invoker.properties                        | 16 +++++++++
 .../check-multi-filter-dups/module1/pom.xml   |  4 ++-
 .../check-multi-filter-dups/module2/pom.xml   |  4 ++-
 src/it/check-multi-filter-dups/pom.xml        |  4 ++-
 .../main/config/spotbugs-exclude-filters.xml  | 17 ++++++++++
 src/it/check-multi-filter-dups/verify.groovy  |  5 +--
 src/it/check-multi/invoker.properties         | 16 +++++++++
 src/it/check-multi/modules/module-1/pom.xml   |  4 ++-
 src/it/check-multi/modules/module-2/pom.xml   |  4 ++-
 src/it/check-multi/modules/pom.xml            |  4 ++-
 src/it/check-multi/pom.xml                    |  4 ++-
 src/it/check-multi/verify.groovy              |  5 +--
 .../invoker.properties                        | 16 +++++++++
 src/it/check-no-missing-classes/pom.xml       |  4 ++-
 .../src/main/java/test/App.java               | 15 ++++++++
 src/it/check-no-missing-classes/verify.groovy |  3 +-
 src/it/check-nofail/invoker.properties        | 16 +++++++++
 src/it/check-nofail/pom.xml                   |  4 ++-
 .../check-pluginList-repo/invoker.properties  | 16 +++++++++
 src/it/check-pluginList-repo/pom.xml          | 25 +++++++-------
 src/it/check-pluginList-repo/verify.groovy    |  3 +-
 src/it/check-skip/invoker.properties          | 16 +++++++++
 src/it/check-skip/pom.xml                     |  4 ++-
 src/it/check-skip/verify.groovy               |  3 +-
 src/it/check-timeout/invoker.properties       | 16 +++++++++
 src/it/check-timeout/pom.xml                  |  5 +--
 src/it/check/invoker.properties               | 16 +++++++++
 src/it/check/pom.xml                          |  4 ++-
 src/it/check/verify.groovy                    |  3 +-
 src/it/common.xml                             |  4 ++-
 src/it/effort-default/invoker.properties      | 16 +++++++++
 src/it/effort-default/pom.xml                 |  4 ++-
 src/it/effort-default/verify.groovy           |  3 +-
 src/it/effort-max/invoker.properties          | 16 +++++++++
 src/it/effort-max/pom.xml                     |  4 ++-
 src/it/effort-max/verify.groovy               |  3 +-
 src/it/effort-min/invoker.properties          | 16 +++++++++
 src/it/effort-min/pom.xml                     |  4 ++-
 src/it/effort-min/verify.groovy               |  3 +-
 src/it/empty/invoker.properties               | 16 +++++++++
 src/it/empty/pom.xml                          |  4 ++-
 .../empty/src/main/resources/app.properties   | 16 +++++++++
 src/it/empty/verify.groovy                    |  3 +-
 src/it/encoding-utf8/invoker.properties       | 16 +++++++++
 src/it/encoding-utf8/pom.xml                  |  4 ++-
 src/it/encoding-utf8/verify.groovy            |  3 +-
 src/it/exclude-modules/invoker.properties     | 16 +++++++++
 src/it/exclude-modules/module1/pom.xml        |  4 ++-
 .../module1/src/main/excludeBugs.xml          | 17 ++++++++++
 src/it/exclude-modules/module2/pom.xml        |  4 ++-
 .../module2/src/main/excludeBugs.xml          | 17 ++++++++++
 src/it/exclude-modules/pom.xml                |  4 ++-
 src/it/exclude-modules/verify.groovy          |  5 +--
 src/it/exclude-multi-list/invoker.properties  | 16 +++++++++
 src/it/exclude-multi-list/pom.xml             |  4 ++-
 src/it/exclude-multi-list/verify.groovy       |  3 +-
 src/it/exclude-multi/invoker.properties       | 16 +++++++++
 src/it/exclude-multi/pom.xml                  |  4 ++-
 src/it/exclude-multi/verify.groovy            |  3 +-
 src/it/exclude/invoker.properties             | 16 +++++++++
 src/it/exclude/pom.xml                        |  4 ++-
 src/it/exclude/verify.groovy                  |  3 +-
 src/it/excludeBugsFile/excludeBugs1.xml       | 16 +++++++++
 src/it/excludeBugsFile/excludeBugs2.xml       | 16 +++++++++
 src/it/excludeBugsFile/invoker.properties     | 16 +++++++++
 src/it/excludeBugsFile/pom.xml                |  4 ++-
 src/it/excludeBugsFile/verify.groovy          |  3 +-
 src/it/experimental/invoker.properties        | 16 +++++++++
 src/it/experimental/pom.xml                   |  4 ++-
 src/it/experimental/verify.groovy             |  3 +-
 src/it/html-report/invoker.properties         | 16 +++++++++
 src/it/html-report/pom.xml                    |  6 ++--
 src/it/html-report/verify.groovy              |  5 ++-
 src/it/include-multi-list/invoker.properties  | 16 +++++++++
 src/it/include-multi-list/pom.xml             |  4 ++-
 src/it/include-multi-list/verify.groovy       |  3 +-
 src/it/include-multi/invoker.properties       | 16 +++++++++
 src/it/include-multi/pom.xml                  |  4 ++-
 src/it/include-multi/verify.groovy            |  3 +-
 src/it/include/invoker.properties             | 16 +++++++++
 src/it/include/pom.xml                        |  4 ++-
 src/it/include/verify.groovy                  |  3 +-
 src/it/maxRank/invoker.properties             | 16 +++++++++
 src/it/maxRank/pom.xml                        |  4 ++-
 src/it/maxRank/verify.groovy                  |  3 +-
 src/it/multi-build/invoker.properties         | 16 +++++++++
 src/it/multi-build/modules/module-1/pom.xml   |  4 ++-
 src/it/multi-build/modules/module-2/pom.xml   |  4 ++-
 src/it/multi-build/modules/pom.xml            |  4 ++-
 src/it/multi-build/pom.xml                    |  4 ++-
 src/it/multi-build/verify.groovy              |  3 +-
 src/it/multi/invoker.properties               | 16 +++++++++
 src/it/multi/modules/module-1/pom.xml         |  4 ++-
 .../multi/modules/module-1/src/site/site.xml  | 17 ++++++++++
 .../modules/module-1/src/site/xdoc/index.xml  | 17 ++++++++++
 src/it/multi/modules/module-2/pom.xml         |  4 ++-
 .../multi/modules/module-2/src/site/site.xml  | 17 ++++++++++
 .../modules/module-2/src/site/xdoc/index.xml  | 17 ++++++++++
 src/it/multi/modules/pom.xml                  |  4 ++-
 src/it/multi/pom.xml                          |  4 ++-
 src/it/multi/verify.groovy                    |  3 +-
 src/it/nested/invoker.properties              | 16 +++++++++
 src/it/nested/pom.xml                         |  4 ++-
 src/it/nested/verify.groovy                   |  3 +-
 src/it/no-src/invoker.properties              | 16 +++++++++
 src/it/no-src/pom.xml                         |  4 ++-
 .../no-src/src/test/java/EmptyJUnitTest.java  |  5 ++-
 src/it/no-src/verify.groovy                   |  3 +-
 src/it/no-testsrc/invoker.properties          | 16 +++++++++
 src/it/no-testsrc/pom.xml                     |  4 ++-
 src/it/no-testsrc/verify.groovy               |  3 +-
 src/it/omitVisitors/invoker.properties        | 16 +++++++++
 src/it/omitVisitors/pom.xml                   |  4 ++-
 src/it/omitVisitors/verify.groovy             |  3 +-
 src/it/onlyAnalyze/invoker.properties         | 16 +++++++++
 src/it/onlyAnalyze/pom.xml                    |  4 ++-
 src/it/onlyAnalyze/verify.groovy              |  3 +-
 src/it/pluginList-repo/invoker.properties     | 16 +++++++++
 src/it/pluginList-repo/pom.xml                |  4 ++-
 src/it/pluginList-repo/verify.groovy          |  3 +-
 src/it/pluginList/invoker.properties          | 16 +++++++++
 src/it/pluginList/pom.xml                     |  4 ++-
 src/it/pluginList/verify.groovy               |  3 +-
 src/it/relaxed/invoker.properties             | 16 +++++++++
 src/it/relaxed/pom.xml                        |  4 ++-
 src/it/relaxed/verify.groovy                  |  3 +-
 src/it/sarif-1/invoker.properties             | 16 +++++++++
 src/it/sarif-1/pom.xml                        |  4 ++-
 src/it/sarif-1/verify.groovy                  |  3 +-
 src/it/sarif-2/invoker.properties             | 16 +++++++++
 src/it/sarif-2/pom.xml                        |  4 ++-
 src/it/sarif-2/verify.groovy                  |  3 +-
 src/it/settings.xml                           | 28 +++++++--------
 src/it/site-brazil/invoker.properties         | 16 +++++++++
 src/it/site-brazil/pom.xml                    |  4 ++-
 src/it/site-brazil/verify.groovy              |  3 +-
 src/it/site-default/invoker.properties        | 16 +++++++++
 src/it/site-default/pom.xml                   |  4 ++-
 src/it/site-default/verify.groovy             |  3 +-
 src/it/site-french/invoker.properties         | 16 +++++++++
 src/it/site-french/pom.xml                    |  4 ++-
 src/it/site-french/verify.groovy              |  3 +-
 src/it/site-spanish/invoker.properties        | 16 +++++++++
 src/it/site-spanish/pom.xml                   |  4 ++-
 src/it/site-spanish/verify.groovy             |  3 +-
 src/it/skip/invoker.properties                | 16 +++++++++
 src/it/skip/pom.xml                           |  4 ++-
 src/it/skip/verify.groovy                     |  3 +-
 src/it/skipEmpty/invoker.properties           | 16 +++++++++
 src/it/skipEmpty/pom.xml                      |  4 ++-
 src/it/skipEmpty/src/main/java/test/App.java  | 15 ++++++++
 src/it/skipEmpty/verify.groovy                |  3 +-
 .../invoker.properties                        | 16 +++++++++
 src/it/systemPropertyVariables/pom.xml        |  4 ++-
 src/it/systemPropertyVariables/verify.groovy  |  3 +-
 src/it/threaded/invoker.properties            | 16 +++++++++
 src/it/threaded/pom.xml                       |  4 ++-
 src/it/threaded/verify.groovy                 |  3 +-
 .../threshold-experimental/invoker.properties | 16 +++++++++
 src/it/threshold-experimental/pom.xml         |  4 ++-
 src/it/threshold-experimental/verify.groovy   |  3 +-
 src/it/threshold-high/invoker.properties      | 16 +++++++++
 src/it/threshold-high/pom.xml                 |  4 ++-
 src/it/threshold-high/verify.groovy           |  3 +-
 src/it/threshold-low/invoker.properties       | 16 +++++++++
 src/it/threshold-low/pom.xml                  |  4 ++-
 src/it/threshold-low/verify.groovy            |  3 +-
 src/it/trace/invoker.properties               | 16 +++++++++
 src/it/trace/pom.xml                          |  4 ++-
 src/it/trace/verify.groovy                    |  3 +-
 src/it/userPrefs-override/invoker.properties  | 16 +++++++++
 src/it/userPrefs-override/pom.xml             |  4 ++-
 src/it/userPrefs-override/verify.groovy       |  3 +-
 src/it/userPrefs/invoker.properties           | 16 +++++++++
 src/it/userPrefs/pom.xml                      |  4 ++-
 src/it/userPrefs/verify.groovy                |  3 +-
 src/it/verify-clean/invoker.properties        | 16 +++++++++
 src/it/verify-clean/pom.xml                   |  4 ++-
 src/it/verify-fail/invoker.properties         | 16 +++++++++
 src/it/verify-fail/pom.xml                    |  4 ++-
 src/it/verify-fail/verify.groovy              |  3 +-
 src/it/verify/invoker.properties              | 16 +++++++++
 src/it/verify/pom.xml                         |  4 ++-
 src/it/verify/verify.groovy                   |  3 +-
 .../spotbugs/BaseViolationCheckMojo.groovy    | 28 +++++++--------
 .../codehaus/mojo/spotbugs/CheckMojo.groovy   | 34 ++++++++-----------
 .../mojo/spotbugs/PluginArtifact.groovy       | 15 ++++++++
 .../mojo/spotbugs/ResourceHelper.groovy       | 28 +++++++--------
 .../mojo/spotbugs/SourceFileIndexer.groovy    | 28 +++++++--------
 .../codehaus/mojo/spotbugs/SpotBugsGui.groovy | 28 +++++++--------
 .../mojo/spotbugs/SpotBugsInfo.groovy         | 29 +++++++---------
 .../mojo/spotbugs/SpotBugsMojo.groovy         | 28 +++++++--------
 .../mojo/spotbugs/SpotBugsPluginsTrait.groovy | 28 +++++++--------
 .../spotbugs/SpotbugsReportGenerator.groovy   | 28 +++++++--------
 .../codehaus/mojo/spotbugs/VerifyMojo.groovy  | 28 +++++++--------
 .../mojo/spotbugs/XDocsReporter.groovy        | 28 +++++++--------
 .../m2e/lifecycle-mapping-metadata.xml        | 17 ++++++++++
 src/main/resources/spotbugs.properties        | 16 +++++++++
 src/main/resources/spotbugs_en.properties     | 16 +++++++++
 src/main/resources/spotbugs_es.properties     | 16 +++++++++
 src/main/resources/spotbugs_fr.properties     | 16 +++++++++
 src/main/resources/spotbugs_no_NO.properties  | 16 +++++++++
 src/main/resources/spotbugs_pt_BR.properties  | 16 +++++++++
 src/main/tools/cleanup.sh                     | 16 +++++++++
 src/main/tools/fb2bundle.groovy               | 15 ++++++++
 src/main/tools/fb2local.groovy                | 15 ++++++++
 src/main/tools/fb2repo.groovy                 | 15 ++++++++
 src/main/tools/jFormatString.pom              | 17 ++++++++++
 src/main/tools/jsr305.pom                     | 17 ++++++++++
 src/main/tools/spotbugs-annotations.pom       | 17 ++++++++++
 src/main/tools/spotbugs-ant.pom               | 17 ++++++++++
 src/main/tools/spotbugs-exclude-filters.xml   | 17 ++++++++++
 src/main/tools/spotbugs.pom                   | 17 ++++++++++
 .../apt/examples/multi-module-config.apt.vm   | 15 ++++++++
 .../apt/examples/violationChecking.apt.vm     | 15 ++++++++
 src/site/apt/index.apt.vm                     | 15 ++++++++
 src/site/apt/usage.apt.vm                     | 15 ++++++++
 src/site/fml/faq.fml                          | 17 ++++++++++
 .../resources/examples/css/maven-base.css     | 15 ++++++++
 .../resources/examples/css/maven-theme.css    | 15 ++++++++
 src/site/resources/examples/css/print.css     | 15 ++++++++
 src/site/resources/examples/css/site.css      | 15 ++++++++
 src/site/resources/examples/spotbugs.html     | 17 ++++++++++
 src/site/resources/examples/spotbugs.xml      | 17 ++++++++++
 src/site/resources/examples/spotbugsXml.xml   | 16 +++++++++
 .../examples/xref-test/allclasses-frame.html  | 17 ++++++++++
 .../spotbugs-maven-plugin/it/App.html         | 17 ++++++++++
 .../spotbugs-maven-plugin/it/FooTest.html     | 17 ++++++++++
 .../it/package-frame.html                     | 17 ++++++++++
 .../it/package-summary.html                   | 17 ++++++++++
 .../resources/examples/xref-test/index.html   | 17 ++++++++++
 .../examples/xref-test/overview-frame.html    | 17 ++++++++++
 .../examples/xref-test/overview-summary.html  | 17 ++++++++++
 .../examples/xref-test/stylesheet.css         | 15 ++++++++
 src/site/resources/examples/xref/A.html       | 17 ++++++++++
 .../xref/AbstractMissingHashCode.html         | 17 ++++++++++
 .../AccidentalNonConstructorInInnerClass.html | 17 ++++++++++
 .../examples/xref/AnnotationTest.html         | 17 ++++++++++
 .../xref/AppendingToAnObjectOutputStream.html | 17 ++++++++++
 .../examples/xref/ArrayToString.html          | 17 ++++++++++
 .../examples/xref/AssignedOnlyInCtor.html     | 17 ++++++++++
 .../examples/xref/AssumeUnsignedBytes.html    | 17 ++++++++++
 .../resources/examples/xref/UseInitCause.html | 17 ++++++++++
 ...OfNonHashableClassInHashDataStructure.html | 17 ++++++++++
 .../examples/xref/UselessAssignments.html     | 17 ++++++++++
 .../examples/xref/UselessControlFlow.html     | 17 ++++++++++
 .../examples/xref/UselessCurrentThread.html   | 17 ++++++++++
 .../examples/xref/UselessFinalize.html        | 17 ++++++++++
 .../examples/xref/UselessSCMethods.html       | 17 ++++++++++
 .../examples/xref/UserAss3rtion.html          | 17 ++++++++++
 .../resources/examples/xref/UserMistakes.html | 17 ++++++++++
 .../examples/xref/allclasses-frame.html       | 17 ++++++++++
 .../examples/xref/badNaming/package1/A.html   | 17 ++++++++++
 .../badNaming/package1/package-frame.html     | 17 ++++++++++
 .../badNaming/package1/package-summary.html   | 17 ++++++++++
 .../examples/xref/badNaming/package2/A.html   | 17 ++++++++++
 .../xref/badNaming/package2/AnInterface.html  | 17 ++++++++++
 .../badNaming/package2/package-frame.html     | 17 ++++++++++
 .../badNaming/package2/package-summary.html   | 17 ++++++++++
 .../examples/xref/equals/ArrayEquality.html   | 17 ++++++++++
 .../examples/xref/equals/package-frame.html   | 17 ++++++++++
 .../examples/xref/equals/package-summary.html | 17 ++++++++++
 .../AllListsCouldBeEqual.html                 | 17 ++++++++++
 .../gcUnrelatedTypes/ArrayListContains.html   | 17 ++++++++++
 .../gcUnrelatedTypes/ArrayListContains0.html  | 17 ++++++++++
 .../xref/gcUnrelatedTypes/package-frame.html  | 17 ++++++++++
 .../gcUnrelatedTypes/package-summary.html     | 17 ++++++++++
 src/site/resources/examples/xref/index.html   | 17 ++++++++++
 .../examples/xref/jsr305/AlwaysBlue.html      | 17 ++++++++++
 .../examples/xref/jsr305/package-frame.html   | 17 ++++++++++
 .../examples/xref/jsr305/package-summary.html | 17 ++++++++++
 .../examples/xref/npe/AtomicFieldUpdater.html | 17 ++++++++++
 .../examples/xref/npe/UseCheckUse.html        | 17 ++++++++++
 .../examples/xref/npe/package-frame.html      | 17 ++++++++++
 .../examples/xref/npe/package-summary.html    | 17 ++++++++++
 .../nullnessAnnotations/UseAnnotations.html   | 17 ++++++++++
 .../nullnessAnnotations/package-frame.html    | 17 ++++++++++
 .../nullnessAnnotations/package-summary.html  | 17 ++++++++++
 .../obligation/UsesWillCloseAnnotation.html   | 17 ++++++++++
 .../xref/obligation/package-frame.html        | 17 ++++++++++
 .../xref/obligation/package-summary.html      | 17 ++++++++++
 .../examples/xref/overview-frame.html         | 17 ++++++++++
 .../examples/xref/overview-summary.html       | 17 ++++++++++
 .../examples/xref/package-frame.html          | 17 ++++++++++
 .../examples/xref/package-summary.html        | 17 ++++++++++
 .../resources/examples/xref/stylesheet.css    | 15 ++++++++
 .../xref/uselessThread/UsefulThread.html      | 17 ++++++++++
 .../xref/uselessThread/package-frame.html     | 17 ++++++++++
 .../xref/uselessThread/package-summary.html   | 17 ++++++++++
 src/site/site.xml                             | 17 ++++++++++
 341 files changed, 3523 insertions(+), 420 deletions(-)
 create mode 100644 LICENSE_HEADER

diff --git a/.mvn/extensions.xml b/.mvn/extensions.xml
index 6463f95c7..f11b43b5d 100644
--- a/.mvn/extensions.xml
+++ b/.mvn/extensions.xml
@@ -1,4 +1,21 @@
 
+
 
     
       fr.jcgay.maven
diff --git a/.mvn/settings.xml b/.mvn/settings.xml
index ace67a1cd..c31ad8151 100644
--- a/.mvn/settings.xml
+++ b/.mvn/settings.xml
@@ -1,4 +1,21 @@
 
+
 
   
diff --git a/LICENSE_HEADER b/LICENSE_HEADER
new file mode 100644
index 000000000..9e12c03ad
--- /dev/null
+++ b/LICENSE_HEADER
@@ -0,0 +1,13 @@
+Copyright ${license.git.copyrightYears} the original author or authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    https://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
diff --git a/pom.xml b/pom.xml
index 7ce840a37..4c4faee4e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
 
diff --git a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java
index a9edcd9d7..f446093cc 100644
--- a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java
+++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/App.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.codehaus.mojo.spotbugsmavenplugin.it;
 
 /**
diff --git a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java
index 987369648..a323d0138 100644
--- a/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java
+++ b/src/it-src/test/java/org/codehaus/mojo/spotbugsmavenplugin/it/FooTest.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.codehaus.mojo.spotbugsmavenplugin.it;
 
 
diff --git a/src/it-tools/build-tools/invoker.properties b/src/it-tools/build-tools/invoker.properties
index 69960fdbb..ec94541cb 100644
--- a/src/it-tools/build-tools/invoker.properties
+++ b/src/it-tools/build-tools/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean install
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it-tools/build-tools/pom.xml b/src/it-tools/build-tools/pom.xml
index 5a2d63255..83917c156 100644
--- a/src/it-tools/build-tools/pom.xml
+++ b/src/it-tools/build-tools/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
+
 
   
     Bad comparison of signed byte
diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml
index 20c0b2d9f..d5b4ae922 100644
--- a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml
+++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline-outputstream.xml
@@ -1,4 +1,21 @@
 
+
 
   
     Doomed attempt to append to an object output stream
diff --git a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
index b8a98ac53..51124a2be 100644
--- a/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
+++ b/src/it-tools/build-tools/src/main/resources/baseline/spotbugs-baseline.xml
@@ -1,4 +1,21 @@
 
+
 
   
     Doomed attempt to append to an object output stream
diff --git a/src/it-tools/build-tools/src/main/resources/filters/lib-filter2.xml b/src/it-tools/build-tools/src/main/resources/filters/lib-filter2.xml
index adae72cb0..4d2892858 100644
--- a/src/it-tools/build-tools/src/main/resources/filters/lib-filter2.xml
+++ b/src/it-tools/build-tools/src/main/resources/filters/lib-filter2.xml
@@ -1,3 +1,20 @@
+
 
   
   
diff --git a/src/it-tools/build-tools/src/main/resources/whizbang/lib-filter.xml b/src/it-tools/build-tools/src/main/resources/whizbang/lib-filter.xml
index d861517b9..f22c88969 100644
--- a/src/it-tools/build-tools/src/main/resources/whizbang/lib-filter.xml
+++ b/src/it-tools/build-tools/src/main/resources/whizbang/lib-filter.xml
@@ -1,3 +1,20 @@
+
 
   
   
diff --git a/src/it-tools/build-tools/verify.groovy b/src/it-tools/build-tools/verify.groovy
index 84fb4e3f7..c50c9ad63 100644
--- a/src/it-tools/build-tools/verify.groovy
+++ b/src/it-tools/build-tools/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,5 +13,4 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 assert new File(basedir, 'target/build-tools-testing.jar').exists()
diff --git a/src/it-tools/prime/invoker.properties b/src/it-tools/prime/invoker.properties
index 850739135..a7f5ccfcf 100644
--- a/src/it-tools/prime/invoker.properties
+++ b/src/it-tools/prime/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean package
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it-tools/prime/pom.xml b/src/it-tools/prime/pom.xml
index 0b6d1ab21..1af6ce313 100644
--- a/src/it-tools/prime/pom.xml
+++ b/src/it-tools/prime/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
   
   
diff --git a/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml b/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml
index d861517b9..f22c88969 100644
--- a/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml
+++ b/src/it-tools/prime/src/main/resources/whizbang/lib-filter.xml
@@ -1,3 +1,20 @@
+
 
   
   
diff --git a/src/it-tools/prime/verify.groovy b/src/it-tools/prime/verify.groovy
index c0771f01a..59074bc84 100644
--- a/src/it-tools/prime/verify.groovy
+++ b/src/it-tools/prime/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,5 +13,4 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 assert new File(basedir, 'target/prime-testing.jar').exists()
diff --git a/src/it/MFINDBUGS-145/invoker.properties b/src/it/MFINDBUGS-145/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/MFINDBUGS-145/invoker.properties
+++ b/src/it/MFINDBUGS-145/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/MFINDBUGS-145/pom.xml b/src/it/MFINDBUGS-145/pom.xml
index 1c1ecf67f..7e3b449a7 100644
--- a/src/it/MFINDBUGS-145/pom.xml
+++ b/src/it/MFINDBUGS-145/pom.xml
@@ -1,6 +1,7 @@
 
 
 
diff --git a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java b/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
index 43de59a09..04f511eeb 100644
--- a/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
+++ b/src/it/MFINDBUGS-145/src/main/java/org/codehaus/mojo/spotbugsmavenplugin/it/mfindbugs145/App.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package org.codehaus.mojo.spotbugsmavenplugin.it.mfindbugs145;
 
 /**
diff --git a/src/it/MFINDBUGS-178/invoker.properties b/src/it/MFINDBUGS-178/invoker.properties
index 284f9e230..3dcb66088 100644
--- a/src/it/MFINDBUGS-178/invoker.properties
+++ b/src/it/MFINDBUGS-178/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean verify site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/MFINDBUGS-178/pom.xml b/src/it/MFINDBUGS-178/pom.xml
index eeb0c743b..acb070f94 100644
--- a/src/it/MFINDBUGS-178/pom.xml
+++ b/src/it/MFINDBUGS-178/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
index 539a2ccfe..370feb261 100644
--- a/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
+++ b/src/it/check-multi-filter-dups/src/main/config/spotbugs-exclude-filters.xml
@@ -1,4 +1,21 @@
 
+
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/check-multi/verify.groovy b/src/it/check-multi/verify.groovy
index f54885656..e070df0b5 100644
--- a/src/it/check-multi/verify.groovy
+++ b/src/it/check-multi/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,9 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
-
 //  check module 1
 
 import groovy.xml.XmlSlurper
diff --git a/src/it/check-no-missing-classes/invoker.properties b/src/it/check-no-missing-classes/invoker.properties
index d5da9063b..c35bc4bb6 100644
--- a/src/it/check-no-missing-classes/invoker.properties
+++ b/src/it/check-no-missing-classes/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile spotbugs:check
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/check-no-missing-classes/pom.xml b/src/it/check-no-missing-classes/pom.xml
index 0776017c2..737a0f396 100644
--- a/src/it/check-no-missing-classes/pom.xml
+++ b/src/it/check-no-missing-classes/pom.xml
@@ -1,6 +1,7 @@
 
 
 
diff --git a/src/it/check-no-missing-classes/src/main/java/test/App.java b/src/it/check-no-missing-classes/src/main/java/test/App.java
index e4c6765b8..09851ab7f 100644
--- a/src/it/check-no-missing-classes/src/main/java/test/App.java
+++ b/src/it/check-no-missing-classes/src/main/java/test/App.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package test;
 
 import org.junit.jupiter.api.Assertions;
diff --git a/src/it/check-no-missing-classes/verify.groovy b/src/it/check-no-missing-classes/verify.groovy
index 16739ac4d..45c4872d1 100644
--- a/src/it/check-no-missing-classes/verify.groovy
+++ b/src/it/check-no-missing-classes/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 // Check no missing classes
 
 File buildLog = new File( basedir, 'build.log' )
diff --git a/src/it/check-nofail/invoker.properties b/src/it/check-nofail/invoker.properties
index d5da9063b..c35bc4bb6 100644
--- a/src/it/check-nofail/invoker.properties
+++ b/src/it/check-nofail/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile spotbugs:check
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/check-nofail/pom.xml b/src/it/check-nofail/pom.xml
index 1fa8c02bb..8507dd99c 100644
--- a/src/it/check-nofail/pom.xml
+++ b/src/it/check-nofail/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
+-->
 
   4.0.0
diff --git a/src/it/check/invoker.properties b/src/it/check/invoker.properties
index d5da9063b..c35bc4bb6 100644
--- a/src/it/check/invoker.properties
+++ b/src/it/check/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile spotbugs:check
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/check/pom.xml b/src/it/check/pom.xml
index 1fa8c02bb..8507dd99c 100644
--- a/src/it/check/pom.xml
+++ b/src/it/check/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
diff --git a/src/it/effort-default/invoker.properties b/src/it/effort-default/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/effort-default/invoker.properties
+++ b/src/it/effort-default/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/effort-default/pom.xml b/src/it/effort-default/pom.xml
index a83c27a9c..06542ad67 100644
--- a/src/it/effort-default/pom.xml
+++ b/src/it/effort-default/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/empty/src/main/resources/app.properties b/src/it/empty/src/main/resources/app.properties
index a5518e60d..70221204d 100644
--- a/src/it/empty/src/main/resources/app.properties
+++ b/src/it/empty/src/main/resources/app.properties
@@ -1 +1,17 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 nothing=all
diff --git a/src/it/empty/verify.groovy b/src/it/empty/verify.groovy
index 64f82d36f..6bb0b8ebc 100644
--- a/src/it/empty/verify.groovy
+++ b/src/it/empty/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 assert !(new File(basedir, 'target/site/spotbugs.html').exists())
 
 assert !(new File(basedir, 'target/spotbugs.xml').exists())
diff --git a/src/it/encoding-utf8/invoker.properties b/src/it/encoding-utf8/invoker.properties
index d44b2c062..a9f0e31b4 100644
--- a/src/it/encoding-utf8/invoker.properties
+++ b/src/it/encoding-utf8/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean install site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/encoding-utf8/pom.xml b/src/it/encoding-utf8/pom.xml
index e41eb9839..5c939a46d 100644
--- a/src/it/encoding-utf8/pom.xml
+++ b/src/it/encoding-utf8/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
   
   
diff --git a/src/it/exclude-modules/module2/pom.xml b/src/it/exclude-modules/module2/pom.xml
index 9e6d7dfb9..ecd320b8f 100644
--- a/src/it/exclude-modules/module2/pom.xml
+++ b/src/it/exclude-modules/module2/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
     
     
diff --git a/src/it/exclude-modules/pom.xml b/src/it/exclude-modules/pom.xml
index 89229bde2..1c2abf87c 100644
--- a/src/it/exclude-modules/pom.xml
+++ b/src/it/exclude-modules/pom.xml
@@ -1,6 +1,7 @@
 
 
 
diff --git a/src/it/exclude-modules/verify.groovy b/src/it/exclude-modules/verify.groovy
index 40b7cefff..1389829de 100644
--- a/src/it/exclude-modules/verify.groovy
+++ b/src/it/exclude-modules/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,9 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
-
-
 //  check module 1
 
 import groovy.xml.XmlSlurper
diff --git a/src/it/exclude-multi-list/invoker.properties b/src/it/exclude-multi-list/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/exclude-multi-list/invoker.properties
+++ b/src/it/exclude-multi-list/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/exclude-multi-list/pom.xml b/src/it/exclude-multi-list/pom.xml
index 2c700c8e0..3c351c630 100644
--- a/src/it/exclude-multi-list/pom.xml
+++ b/src/it/exclude-multi-list/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 /Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-sink-api/1.1.3/doxia-sink-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-site-renderer/1.1.3/doxia-site-renderer-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/targetDoomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 14]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 28]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 35]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 16]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 24]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 30]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 26]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 37]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 92-2973]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 12]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 92-2973]Expected StringValue loaded from ?At ArrayEquality.java:[line 17]equals() used to compare array and nonarrayCalling String[][].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 27]equals() used to compare array and nonarrayCalling String[].equals(String[][]) in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 32]Call to equals() comparing different typesCall to String[].equals(int[]) in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 37]Call to equals() comparing different typesCall to int[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 42]Call to equals() comparing different typesCall to StringBuffer[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 47]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 162]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 67]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 79]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 83]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 115]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 111]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 127]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 123]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 131]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 119]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 56]Nullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 12 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 6-19]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 11]Redundant null check at UseCheckUse.java:[line 12]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 44]Method call passes null to a nonnull parameter Null passed for nonnull parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 24]Dodgy codeBad practiceCorrectnessInternationalizationClass defines equals() and uses Object.hashCode()

 
   <p> This class overrides <code>equals(Object)</code>, but does not
diff --git a/src/it/excludeBugsFile/excludeBugs2.xml b/src/it/excludeBugsFile/excludeBugs2.xml
index 9e8b20110..adae641ba 100644
--- a/src/it/excludeBugsFile/excludeBugs2.xml
+++ b/src/it/excludeBugsFile/excludeBugs2.xml
@@ -1,4 +1,20 @@
+
 /Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/targetDead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 17]Another occurrence at UselessAssignments.java:[line 19]Dead store to local variableDead store to $L1 in UselessCurrentThread.test4()At UselessCurrentThread.java:[lines 7-64]In class UselessCurrentThreadIn method UselessCurrentThread.test4()Local variable stored in JVM register 1At UselessCurrentThread.java:[line 37]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 28]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 159]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]Dodgy codeDead store to local variable

 
 <p>
diff --git a/src/it/excludeBugsFile/invoker.properties b/src/it/excludeBugsFile/invoker.properties
index d5da9063b..c35bc4bb6 100644
--- a/src/it/excludeBugsFile/invoker.properties
+++ b/src/it/excludeBugsFile/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile spotbugs:check
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/excludeBugsFile/pom.xml b/src/it/excludeBugsFile/pom.xml
index 694b75642..9d1ab3c19 100644
--- a/src/it/excludeBugsFile/pom.xml
+++ b/src/it/excludeBugsFile/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/multi-build/verify.groovy b/src/it/multi-build/verify.groovy
index 5d994177e..d3e31160a 100644
--- a/src/it/multi-build/verify.groovy
+++ b/src/it/multi-build/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import groovy.xml.XmlSlurper
 
 def effortLevel = 'default'
diff --git a/src/it/multi/invoker.properties b/src/it/multi/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/multi/invoker.properties
+++ b/src/it/multi/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/multi/modules/module-1/pom.xml b/src/it/multi/modules/module-1/pom.xml
index 06ce1d9db..1522f14ec 100644
--- a/src/it/multi/modules/module-1/pom.xml
+++ b/src/it/multi/modules/module-1/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
+
 
   
   
diff --git a/src/it/multi/modules/module-1/src/site/xdoc/index.xml b/src/it/multi/modules/module-1/src/site/xdoc/index.xml
index 6efb12a9a..cf4156661 100644
--- a/src/it/multi/modules/module-1/src/site/xdoc/index.xml
+++ b/src/it/multi/modules/module-1/src/site/xdoc/index.xml
@@ -1,4 +1,21 @@
 
+
 
   
     SpotBugs Maven Testing
diff --git a/src/it/multi/modules/module-2/pom.xml b/src/it/multi/modules/module-2/pom.xml
index 9cde01f1c..1c54f1329 100644
--- a/src/it/multi/modules/module-2/pom.xml
+++ b/src/it/multi/modules/module-2/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
+
 
   
   
diff --git a/src/it/multi/modules/module-2/src/site/xdoc/index.xml b/src/it/multi/modules/module-2/src/site/xdoc/index.xml
index 73c6f349a..514f4208c 100644
--- a/src/it/multi/modules/module-2/src/site/xdoc/index.xml
+++ b/src/it/multi/modules/module-2/src/site/xdoc/index.xml
@@ -1,4 +1,21 @@
 
+
 
   
     Spotbugs Maven Testing
diff --git a/src/it/multi/modules/pom.xml b/src/it/multi/modules/pom.xml
index 4883ec293..14ca0b81e 100644
--- a/src/it/multi/modules/pom.xml
+++ b/src/it/multi/modules/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
diff --git a/src/it/multi/verify.groovy b/src/it/multi/verify.groovy
index f90f3ca9f..975e43a19 100644
--- a/src/it/multi/verify.groovy
+++ b/src/it/multi/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import groovy.xml.XmlSlurper
 
 def effortLevel = 'default'
diff --git a/src/it/nested/invoker.properties b/src/it/nested/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/nested/invoker.properties
+++ b/src/it/nested/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/nested/pom.xml b/src/it/nested/pom.xml
index 8750e0f6c..11e31ed1a 100644
--- a/src/it/nested/pom.xml
+++ b/src/it/nested/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/pluginList-repo/verify.groovy b/src/it/pluginList-repo/verify.groovy
index 50e5c4cfc..b6ccacfd3 100644
--- a/src/it/pluginList-repo/verify.groovy
+++ b/src/it/pluginList-repo/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import groovy.xml.XmlSlurper
 
 def effortLevel = 'default'
diff --git a/src/it/pluginList/invoker.properties b/src/it/pluginList/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/pluginList/invoker.properties
+++ b/src/it/pluginList/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/pluginList/pom.xml b/src/it/pluginList/pom.xml
index 5a05a97e2..2c565dc2b 100644
--- a/src/it/pluginList/pom.xml
+++ b/src/it/pluginList/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
diff --git a/src/it/relaxed/verify.groovy b/src/it/relaxed/verify.groovy
index 605f2a6f9..1d779d5b3 100644
--- a/src/it/relaxed/verify.groovy
+++ b/src/it/relaxed/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import groovy.xml.XmlSlurper
 
 def effortLevel = 'default'
diff --git a/src/it/sarif-1/invoker.properties b/src/it/sarif-1/invoker.properties
index ccba96b66..d8b5ed16c 100644
--- a/src/it/sarif-1/invoker.properties
+++ b/src/it/sarif-1/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile compiler:testCompile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/sarif-1/pom.xml b/src/it/sarif-1/pom.xml
index 5a201afa8..13119a208 100644
--- a/src/it/sarif-1/pom.xml
+++ b/src/it/sarif-1/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
-
 
 
 
diff --git a/src/it/site-brazil/invoker.properties b/src/it/site-brazil/invoker.properties
index dd2baaf77..e39fcdfdb 100644
--- a/src/it/site-brazil/invoker.properties
+++ b/src/it/site-brazil/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 # A comma or space separated list of goals/phases to execute, may
 # specify an empty list to execute the default goal of the IT project
 invoker.goals = clean install site:site
diff --git a/src/it/site-brazil/pom.xml b/src/it/site-brazil/pom.xml
index 3230484fd..4d017b961 100644
--- a/src/it/site-brazil/pom.xml
+++ b/src/it/site-brazil/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
diff --git a/src/it/skipEmpty/src/main/java/test/App.java b/src/it/skipEmpty/src/main/java/test/App.java
index 9436923b3..da4453baa 100644
--- a/src/it/skipEmpty/src/main/java/test/App.java
+++ b/src/it/skipEmpty/src/main/java/test/App.java
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 package test;
 
 /**
diff --git a/src/it/skipEmpty/verify.groovy b/src/it/skipEmpty/verify.groovy
index 213b199c4..861203e08 100644
--- a/src/it/skipEmpty/verify.groovy
+++ b/src/it/skipEmpty/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 import groovy.xml.XmlSlurper
 
 File spotbugsHtml =  new File(basedir, 'target/site/spotbugs.html')
diff --git a/src/it/systemPropertyVariables/invoker.properties b/src/it/systemPropertyVariables/invoker.properties
index 7fbf7d99f..af4f3cdc1 100644
--- a/src/it/systemPropertyVariables/invoker.properties
+++ b/src/it/systemPropertyVariables/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/systemPropertyVariables/pom.xml b/src/it/systemPropertyVariables/pom.xml
index 712126d8f..9485c9810 100644
--- a/src/it/systemPropertyVariables/pom.xml
+++ b/src/it/systemPropertyVariables/pom.xml
@@ -1,6 +1,7 @@
 
 
 
diff --git a/src/it/systemPropertyVariables/verify.groovy b/src/it/systemPropertyVariables/verify.groovy
index d6efc030f..ed706270c 100644
--- a/src/it/systemPropertyVariables/verify.groovy
+++ b/src/it/systemPropertyVariables/verify.groovy
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2020 the original author or authors.
+ * Copyright 2005-2023 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,6 +13,5 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 File buildLog = new File( basedir, 'build.log' )
 assert buildLog.text.contains( '[java] INFO: System variables are considered to be tainted' )
diff --git a/src/it/threaded/invoker.properties b/src/it/threaded/invoker.properties
index 9def49711..f7e170ecb 100644
--- a/src/it/threaded/invoker.properties
+++ b/src/it/threaded/invoker.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 invoker.goals = clean compile site
 invoker.parallelThreads = 2
 # The expected result of the build, possible values are "success" (default) and "failure"
diff --git a/src/it/threaded/pom.xml b/src/it/threaded/pom.xml
index 9a07e4a6a..531023fbb 100644
--- a/src/it/threaded/pom.xml
+++ b/src/it/threaded/pom.xml
@@ -1,6 +1,7 @@
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
     
         
diff --git a/src/main/resources/spotbugs.properties b/src/main/resources/spotbugs.properties
index e783fe99b..81e177044 100644
--- a/src/main/resources/spotbugs.properties
+++ b/src/main/resources/spotbugs.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Category
diff --git a/src/main/resources/spotbugs_en.properties b/src/main/resources/spotbugs_en.properties
index e783fe99b..81e177044 100644
--- a/src/main/resources/spotbugs_en.properties
+++ b/src/main/resources/spotbugs_en.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Category
diff --git a/src/main/resources/spotbugs_es.properties b/src/main/resources/spotbugs_es.properties
index d19f4ace7..0244fd36b 100644
--- a/src/main/resources/spotbugs_es.properties
+++ b/src/main/resources/spotbugs_es.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Categoría
diff --git a/src/main/resources/spotbugs_fr.properties b/src/main/resources/spotbugs_fr.properties
index f4ac3c118..c58a89650 100644
--- a/src/main/resources/spotbugs_fr.properties
+++ b/src/main/resources/spotbugs_fr.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Cat\u00e9gorie
diff --git a/src/main/resources/spotbugs_no_NO.properties b/src/main/resources/spotbugs_no_NO.properties
index e67586710..518801661 100644
--- a/src/main/resources/spotbugs_no_NO.properties
+++ b/src/main/resources/spotbugs_no_NO.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Kategori
diff --git a/src/main/resources/spotbugs_pt_BR.properties b/src/main/resources/spotbugs_pt_BR.properties
index 145bcee16..b3e72512c 100644
--- a/src/main/resources/spotbugs_pt_BR.properties
+++ b/src/main/resources/spotbugs_pt_BR.properties
@@ -1,3 +1,19 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 report.spotbugs.column.bug=Bug
 report.spotbugs.column.bugs=Bugs
 report.spotbugs.column.category=Categoria
diff --git a/src/main/tools/cleanup.sh b/src/main/tools/cleanup.sh
index dcb6b96d2..2acbae184 100755
--- a/src/main/tools/cleanup.sh
+++ b/src/main/tools/cleanup.sh
@@ -1,2 +1,18 @@
+#
+# Copyright 2005-2023 the original author or authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     https://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 rm *-bundle.jar
 rm *.xml
diff --git a/src/main/tools/fb2bundle.groovy b/src/main/tools/fb2bundle.groovy
index f2b5ab5bc..590bde5f0 100644
--- a/src/main/tools/fb2bundle.groovy
+++ b/src/main/tools/fb2bundle.groovy
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 #!/usr/bin/env groovy
 
 def cli = new CliBuilder(usage:'fb2bundle -f spotbugs.home -version version')
diff --git a/src/main/tools/fb2local.groovy b/src/main/tools/fb2local.groovy
index 50cef8be1..9c6632cd3 100644
--- a/src/main/tools/fb2local.groovy
+++ b/src/main/tools/fb2local.groovy
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 #!groovy
 
 def spotbugsHome = System.getenv("SPOTBUGS_HOME")
diff --git a/src/main/tools/fb2repo.groovy b/src/main/tools/fb2repo.groovy
index e211abd28..ddb8149a8 100644
--- a/src/main/tools/fb2repo.groovy
+++ b/src/main/tools/fb2repo.groovy
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 #!/usr/bin/env groovy
 
 def spotbugsHome = System.getenv("SPOTBUGS_HOME")
diff --git a/src/main/tools/jFormatString.pom b/src/main/tools/jFormatString.pom
index a79c24ef1..9912bd924 100644
--- a/src/main/tools/jFormatString.pom
+++ b/src/main/tools/jFormatString.pom
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
diff --git a/src/main/tools/jsr305.pom b/src/main/tools/jsr305.pom
index c28dab18c..59e34af8f 100644
--- a/src/main/tools/jsr305.pom
+++ b/src/main/tools/jsr305.pom
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
diff --git a/src/main/tools/spotbugs-annotations.pom b/src/main/tools/spotbugs-annotations.pom
index bb0a265a6..f2ad8c02f 100644
--- a/src/main/tools/spotbugs-annotations.pom
+++ b/src/main/tools/spotbugs-annotations.pom
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
diff --git a/src/main/tools/spotbugs-ant.pom b/src/main/tools/spotbugs-ant.pom
index 99c7a1db3..42441a123 100644
--- a/src/main/tools/spotbugs-ant.pom
+++ b/src/main/tools/spotbugs-ant.pom
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
diff --git a/src/main/tools/spotbugs-exclude-filters.xml b/src/main/tools/spotbugs-exclude-filters.xml
index 26405f8d7..c2570ce90 100644
--- a/src/main/tools/spotbugs-exclude-filters.xml
+++ b/src/main/tools/spotbugs-exclude-filters.xml
@@ -1,4 +1,21 @@
 
+
 
     
     
diff --git a/src/main/tools/spotbugs.pom b/src/main/tools/spotbugs.pom
index 426972e8f..747949715 100644
--- a/src/main/tools/spotbugs.pom
+++ b/src/main/tools/spotbugs.pom
@@ -1,4 +1,21 @@
 
+
 
   4.0.0
diff --git a/src/site/apt/examples/multi-module-config.apt.vm b/src/site/apt/examples/multi-module-config.apt.vm
index 4ea959212..7033dd250 100644
--- a/src/site/apt/examples/multi-module-config.apt.vm
+++ b/src/site/apt/examples/multi-module-config.apt.vm
@@ -1,3 +1,18 @@
+#*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
  ------
  Multimodule Configuration
  ------
diff --git a/src/site/apt/examples/violationChecking.apt.vm b/src/site/apt/examples/violationChecking.apt.vm
index 5ac98fe73..bc18800eb 100644
--- a/src/site/apt/examples/violationChecking.apt.vm
+++ b/src/site/apt/examples/violationChecking.apt.vm
@@ -1,3 +1,18 @@
+#*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
  ------
  Violation Checking
  ------
diff --git a/src/site/apt/index.apt.vm b/src/site/apt/index.apt.vm
index 603d422c2..ee3d07d0d 100644
--- a/src/site/apt/index.apt.vm
+++ b/src/site/apt/index.apt.vm
@@ -1,3 +1,18 @@
+#*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
  ------
  Introduction
  ------
diff --git a/src/site/apt/usage.apt.vm b/src/site/apt/usage.apt.vm
index ede98c890..72ad6914c 100644
--- a/src/site/apt/usage.apt.vm
+++ b/src/site/apt/usage.apt.vm
@@ -1,3 +1,18 @@
+#*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *#
  ------
  Usage
  ------
diff --git a/src/site/fml/faq.fml b/src/site/fml/faq.fml
index a9d090873..aab254ded 100644
--- a/src/site/fml/faq.fml
+++ b/src/site/fml/faq.fml
@@ -1,3 +1,20 @@
+
 
 
 
+
 /Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java
diff --git a/src/site/resources/examples/spotbugsXml.xml b/src/site/resources/examples/spotbugsXml.xml
index 9ed269d34..4a8009f70 100644
--- a/src/site/resources/examples/spotbugsXml.xml
+++ b/src/site/resources/examples/spotbugsXml.xml
@@ -1,4 +1,20 @@
+
 /Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/3.0.3-SNAPSHOT/spotbugs-maven-plugin-3.0.3-SNAPSHOT.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.1/jsr305-2.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel-spotbugs/6.0/bcel-spotbugs-6.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.1/jFormatString-2.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-debug-all/5.0.2/asm-debug-all-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-commons/5.0.2/asm-commons-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-tree/5.0.2/asm-tree-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm/5.0.2/asm-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.6/commons-lang-2.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/apple/AppleJavaExtensions/1.4/AppleJavaExtensions-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.9.4/ant-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.9.4/ant-launcher-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/2.4.3/groovy-all-2.4.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.4/doxia-core-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.4/doxia-logging-api-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.3/commons-codec-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.4/doxia-module-fml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-chain/commons-chain/1.1/commons-chain-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/sslext/sslext/1.2-0/sslext-1.2-0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/antlr/antlr/2.7.2/antlr-2.7.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-7/plexus-resources-1.0-alpha-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/junit/junit/4.11/junit-4.11.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/targetClass inherits equals() and uses Object.hashCode()AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode()At AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeAt AbstractMissingHashCode.java:[line 14]Unused fieldUnused field: AbstractMissingHashCode$StillMissingHashCode.yAt AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeIn AbstractMissingHashCode.javaField AbstractMissingHashCode$StillMissingHashCode.yIn AbstractMissingHashCode.javaShould be a static inner classShould AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 21-24]In class AccidentalNonConstructorInInnerClass$DoNotReportAt AccidentalNonConstructorInInnerClass.java:[lines 21-24]Should be a static inner classShould AccidentalNonConstructorInInnerClass$Report be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 3-7]In class AccidentalNonConstructorInInnerClass$ReportAt AccidentalNonConstructorInInnerClass.java:[lines 3-7]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 15]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 27]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 33]Invocation of toString on an unnamed arrayInvocation of toString on an unnamed array in ArrayToString.print2()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print2()At ArrayToString.java:[line 29]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print0(String[])At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print0(String[])Local variable stored in JVM register 1At ArrayToString.java:[line 18]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print1()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print1()Local variable stored in JVM register 1At ArrayToString.java:[line 24]Invocation of toString on an arrayInvocation of toString on gargs in ArrayToString.print3()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print3()In ArrayToString.javaValue loaded from field ArrayToString.gargsAt ArrayToString.java:[line 34]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Unusual equals method UseOfNonHashableClassInHashDataStructure.equals(Object) is unusualAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 23]equals() method does not check for null argumentUseOfNonHashableClassInHashDataStructure.equals(Object) does not check for null argumentAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)Parameter $L1At UseOfNonHashableClassInHashDataStructure.java:[line 14]Dead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Another occurrence at UselessAssignments.java:[line 13]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 24]Double assignment of fieldDouble assignment of field g1 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.g1In UselessAssignments.javaDid you mean to refer to the field UselessAssignments.g2?At UselessAssignments.java:[line 12]Double assignment of fieldDouble assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Another occurrence at UselessAssignments.java:[line 26]Double assignment of fieldDouble assignment of field foo in UselessAssignments.report(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.report(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Double assignment of fieldDouble assignment of field bar in UselessAssignments.setFoo(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.setFoo(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Double assignment of local variable Double assignment of $L3 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 3At UselessAssignments.java:[line 13]Self assignment of local variableSelf assignment of $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Unread fieldUnread field: UselessAssignments.barAt UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Unread fieldUnread field: UselessAssignments.g1At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g1At UselessAssignments.java:[line 12]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Unused fieldUnused field: UselessAssignments.g2At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g2In UselessAssignments.javaUseless control flowUseless control flow in UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[line 23]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[line 14]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[line 18]Useless non-empty void methodMethod UselessControlFlow.report4(Object[], Object) seems to be uselessAt UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report4(Object[], Object)At UselessControlFlow.java:[line 40]Static Thread.interrupted() method invoked on thread instanceUselessCurrentThread.run() invokes static Thread.interrupted() method on thread instanceAt UselessCurrentThread.java:[lines 5-36]In class UselessCurrentThreadIn method UselessCurrentThread.run()At UselessCurrentThread.java:[line 29]Finalizer does nothing but call superclass finalizerUselessFinalize.finalize() does nothing except call super.finalize(); delete itAt UselessFinalize.java:[lines 1-5]In class UselessFinalizeIn method UselessFinalize.finalize()At UselessFinalize.java:[lines 4-5]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 31]Code contains a hard coded reference to an absolute pathnameHard coded reference to an absolute pathname in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])File name /mainList.txtAt UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]"." or "|" used for regular expression"." or "|" used for regular expression in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method String.replaceAll(String, String)At UserMistakes.java:[line 15]Method discards result of readLine after checking if it is non-nullUserMistakes.main(String[]) discards result of readLine after checking if it is non-nullAt UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])At UserMistakes.java:[line 30]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 108-3095]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 8]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 108-3095]Expected StringValue loaded from ?At ArrayEquality.java:[line 12]Invocation of equals() on an array, which is equivalent to ==Using .equals to compare two String[]'s, (equivalent to ==) in equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])Actual type String[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 15]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a String[][] in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 18]equals(...) used to compare incompatible arraysUsing equals to compare a String[][] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 21]equals(...) used to compare incompatible arraysUsing equals to compare a int[] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 24]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a int[] in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 27]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a StringBuffer[] in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 30]Impossible castImpossible cast from java.util.LinkedList to java.util.ArrayList in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At LinkedList.java:[lines 85-1137]Actual type java.util.LinkedListAt ArrayList.java:[lines 102-966]Expected java.util.ArrayListValue loaded from ?At AllListsCouldBeEqual.java:[line 134]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 134]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 138]Return value of method without side effect is ignoredReturn value of java.util.Set.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.falsePositive()Called method java.util.Set.contains(Object)At AllListsCouldBeEqual.java:[line 152]Another occurrence at AllListsCouldBeEqual.java:[line 153]Return value of method without side effect is ignoredReturn value of java.util.List.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Called method java.util.List.contains(Object)At AllListsCouldBeEqual.java:[line 138]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 68]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 80]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 84]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 116]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 112]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 128]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 124]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 132]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 120]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 58]Another occurrence at ArrayListContains.java:[line 59]Another occurrence at ArrayListContains.java:[line 60]Another occurrence at ArrayListContains.java:[line 62]Another occurrence at ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 66]Another occurrence at ArrayListContains.java:[line 67]Another occurrence at ArrayListContains.java:[line 68]Another occurrence at ArrayListContains.java:[line 70]Another occurrence at ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 74]Another occurrence at ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 78]Another occurrence at ArrayListContains.java:[line 79]Another occurrence at ArrayListContains.java:[line 80]Another occurrence at ArrayListContains.java:[line 82]Another occurrence at ArrayListContains.java:[line 83]Another occurrence at ArrayListContains.java:[line 84]Another occurrence at ArrayListContains.java:[line 86]Another occurrence at ArrayListContains.java:[line 87]Another occurrence at ArrayListContains.java:[line 88]Another occurrence at ArrayListContains.java:[line 90]Another occurrence at ArrayListContains.java:[line 91]Another occurrence at ArrayListContains.java:[line 92]Another occurrence at ArrayListContains.java:[line 94]Another occurrence at ArrayListContains.java:[line 95]Another occurrence at ArrayListContains.java:[line 96]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 106]Another occurrence at ArrayListContains.java:[line 107]Another occurrence at ArrayListContains.java:[line 108]Another occurrence at ArrayListContains.java:[line 110]Another occurrence at ArrayListContains.java:[line 111]Another occurrence at ArrayListContains.java:[line 112]Another occurrence at ArrayListContains.java:[line 114]Another occurrence at ArrayListContains.java:[line 115]Another occurrence at ArrayListContains.java:[line 116]Another occurrence at ArrayListContains.java:[line 118]Another occurrence at ArrayListContains.java:[line 119]Another occurrence at ArrayListContains.java:[line 120]Another occurrence at ArrayListContains.java:[line 122]Another occurrence at ArrayListContains.java:[line 123]Another occurrence at ArrayListContains.java:[line 124]Another occurrence at ArrayListContains.java:[line 126]Another occurrence at ArrayListContains.java:[line 127]Another occurrence at ArrayListContains.java:[line 128]Another occurrence at ArrayListContains.java:[line 130]Another occurrence at ArrayListContains.java:[line 131]Another occurrence at ArrayListContains.java:[line 132]Another occurrence at ArrayListContains.java:[line 134]Another occurrence at ArrayListContains.java:[line 135]Another occurrence at ArrayListContains.java:[line 136]Another occurrence at ArrayListContains.java:[line 138]Another occurrence at ArrayListContains.java:[line 139]Another occurrence at ArrayListContains.java:[line 140]Another occurrence at ArrayListContains.java:[line 142]Another occurrence at ArrayListContains.java:[line 143]Another occurrence at ArrayListContains.java:[line 144]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 42]Another occurrence at ArrayListContains0.java:[line 43]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 58]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]Another occurrence at ArrayListContains0.java:[line 58]Unused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummySFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummySFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.wildcardFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.wildcardFIn ArrayListContains0.javaNullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 10 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 5-17]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 9]Redundant null check at UseCheckUse.java:[line 10]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 36]Method call passes null to a non-null parameter Null passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 20]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar3(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 41]Null value at UseAnnotations.java:[line 39]Known null at UseAnnotations.java:[line 40]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar4(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar4(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 46]Null value at UseAnnotations.java:[line 44]Known null at UseAnnotations.java:[line 45]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.bar() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 32]Known null at UseAnnotations.java:[line 32]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo()Local variable stored in JVM register ?Method invoked at UseAnnotations.java:[line 17]Known null at UseAnnotations.java:[line 17]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo4() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo4()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 28]Known null at UseAnnotations.java:[line 28]Method call passes null for non-null parameterNull passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo3(int)Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 might be null but must not be nullValue loaded from ?Method invoked at UseAnnotations.java:[line 25]Null value at UseAnnotations.java:[line 23]Known null at UseAnnotations.java:[line 24]clone method does not call super.clone()com.github.spotbugs.spotbugs-maven-plugin.it.App.clone() does not call super.clone()At App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Clone method may return nullcom.github.spotbugs.spotbugs-maven-plugin.it.App.clone() may return nullAt App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Dodgy codeBad practiceCorrectnessInternationalizationPerformanceImpossible cast

 
 <p>
diff --git a/src/site/resources/examples/xref-test/allclasses-frame.html b/src/site/resources/examples/xref-test/allclasses-frame.html
index 1b6487ccd..5c33fbb36 100644
--- a/src/site/resources/examples/xref-test/allclasses-frame.html
+++ b/src/site/resources/examples/xref-test/allclasses-frame.html
@@ -1,3 +1,20 @@
+
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
+
 

From 762a7c4c04e96a3c0ddf3edcc82f937885527aed Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 12:57:59 -0400
Subject: [PATCH 0962/1013] [pom] Delete overrides for dependency check / pdf
 plugins and add overrides for license plugin

---
 pom.xml | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/pom.xml b/pom.xml
index 4c4faee4e..19c45f772 100644
--- a/pom.xml
+++ b/pom.xml
@@ -618,27 +618,28 @@
             
           
         
+
         
           com.github.spotbugs
           spotbugs-maven-plugin
           ${project.version}
         
 
-        
         
-          org.owasp
-          dependency-check-maven
-          
-            true
-          
-        
-
-        
-        
-          org.apache.maven.plugins
-          maven-pdf-plugin
+          com.mycila
+          license-maven-plugin
           
-            false
+            
+              
+                
LICENSE_HEADER

+                
+                  **/*edu.umd.cs.findbugs.core.prefs
+                
+              
+            
+            
+              SLASHSTAR_STYLE
+            
           
         
       

From 5578744e3a6a31970eda04fc96b5960202456783 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 12:58:14 -0400
Subject: [PATCH 0963/1013] [license] License missed file bsh and cleanup a bit

---
 src/it/MFINDBUGS-145/verify.bsh | 21 +++++++++++++++++----
 1 file changed, 17 insertions(+), 4 deletions(-)

diff --git a/src/it/MFINDBUGS-145/verify.bsh b/src/it/MFINDBUGS-145/verify.bsh
index 57baba1c8..6a5ad6348 100644
--- a/src/it/MFINDBUGS-145/verify.bsh
+++ b/src/it/MFINDBUGS-145/verify.bsh
@@ -1,3 +1,18 @@
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 import org.codehaus.plexus.util.FileUtils;
 
 import java.io.*;
@@ -10,8 +25,7 @@ String[] paths =
 };
 
 // Spotbugs and JXR reports
-for ( String path : paths )
-{
+for ( String path : paths ) {
     File file = new File( basedir, path );
     System.out.println( "Checking for existence of " + file );
     if ( !file.isFile() )
@@ -22,8 +36,7 @@ for ( String path : paths )
 
 File report = new File( basedir, "target/site/spotbugs.html" );
 String content = FileUtils.fileRead( report, "UTF-8" );
-if ( content.indexOf( "" ) < 0 )
-{
+if ( content.indexOf( "" ) < 0 ) {
     throw new IOException( "XRef link not generated." );
 }
 

From 15d92698c96aec1387f8db09e9895cae056ce89e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:08:02 -0400
Subject: [PATCH 0964/1013] [GHA] Adjustments to handle turning off license
 plugin on remote

no need to run that on remote, also some other cleanup
---
 .github/workflows/ci.yaml             | 2 +-
 .github/workflows/coveralls.yaml      | 6 +++---
 .github/workflows/coverity.yaml       | 2 +-
 .github/workflows/it-maven-3.3.9.yaml | 6 +++---
 .github/workflows/it-maven-4.0.0.yaml | 6 +++---
 .github/workflows/it.yaml             | 6 +++---
 .github/workflows/site.yaml           | 2 +-
 .github/workflows/sonar.yaml          | 4 ++--
 .github/workflows/sonatype.yaml       | 2 +-
 9 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 14b73b62e..9feb9b1fe 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -21,4 +21,4 @@ jobs:
           java-version: ${{ matrix.java }}
           distribution: 'zulu'
       - name: Test with Maven
-        run: ./mvnw test -B -V --no-transfer-progress
+        run: ./mvnw test -B -V --no-transfer-progress -D"license.skip=true"
diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml
index dc2632da7..19c129605 100644
--- a/.github/workflows/coveralls.yaml
+++ b/.github/workflows/coveralls.yaml
@@ -12,15 +12,15 @@ jobs:
         uses: actions/setup-java@v3
         with:
           java-version: 17
-          distribution: 'zulu'
+          distribution: zulu
       - name: Report Coverage to Coveralls for Pull Requests
         if: github.event_name == 'pull_request'
-        run: ./mvnw -B -V test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER --no-transfer-progress
+        run: ./mvnw -B -V test jacoco:report coveralls:report -q -Dlicense.skip=true -DrepoToken=$GITHUB_TOKEN -DserviceName=github -DpullRequest=$PR_NUMBER --no-transfer-progress
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           PR_NUMBER: ${{ github.event.number }}
       - name: Report Coverage to Coveralls for General Push
         if: github.event_name == 'push'
-        run: ./mvnw -B -V test jacoco:report coveralls:report -q -D"license.skip=true" -DrepoToken=$GITHUB_TOKEN -DserviceName=github
+        run: ./mvnw -B -V test jacoco:report coveralls:report -q -Dlicense.skip=true -DrepoToken=$GITHUB_TOKEN -DserviceName=github
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml
index 2e04646bd..f376b9b28 100644
--- a/.github/workflows/coverity.yaml
+++ b/.github/workflows/coverity.yaml
@@ -20,7 +20,7 @@ jobs:
         run: |
           wget -q https://scan.coverity.com/download/linux64 --post-data "token=$COVERITY_TOKEN&project=spotbugs%2Fspotbugs-maven-plugin" -O coverity_tool.tgz
           tar -xf coverity_tool.tgz
-          ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -V -DskipTests=true verify --no-transfer-progress
+          ./cov-analysis-linux64-*/bin/cov-build --dir cov-int ./mvnw -B -V -DskipTests=true -Dlicense.skip=true verify --no-transfer-progress
           tar czvf spotbugs-maven-plugin.tgz cov-int
           curl --form token=$COVERITY_TOKEN \
             --form email=$EMAIL \
diff --git a/.github/workflows/it-maven-3.3.9.yaml b/.github/workflows/it-maven-3.3.9.yaml
index 937d77683..8753eaf14 100644
--- a/.github/workflows/it-maven-3.3.9.yaml
+++ b/.github/workflows/it-maven-3.3.9.yaml
@@ -13,10 +13,10 @@ jobs:
         uses: actions/setup-java@v3
         with:
           java-version: 17
-          distribution: 'zulu'
+          distribution: zulu
       - name: Load Maven 3.3.9
         run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=3.3.9 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dmaven.min-version=3.3.9
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=3.3.9
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dmaven.min-version=3.3.9
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=3.3.9
diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index cb67f2b97..fbc87cc75 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -13,10 +13,10 @@ jobs:
         uses: actions/setup-java@v3
         with:
           java-version: 17
-          distribution: 'zulu'
+          distribution: zulu
       - name: Load Maven 4.0.0-alpha-5
         run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-5 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dmaven.min-version=4.0.0-alpha-5
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dmaven.min-version=4.0.0-alpha-5
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml
index 1f103a465..bf736658e 100644
--- a/.github/workflows/it.yaml
+++ b/.github/workflows/it.yaml
@@ -13,8 +13,8 @@ jobs:
         uses: actions/setup-java@v3
         with:
           java-version: 17
-          distribution: 'zulu'
+          distribution: zulu
       - name: Build Setup
-        run: ./mvnw -B -V clean install --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true --no-transfer-progress
diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml
index 420fcbf98..cb6e7bff9 100644
--- a/.github/workflows/site.yaml
+++ b/.github/workflows/site.yaml
@@ -20,7 +20,7 @@ jobs:
         with:
           ssh-private-key: ${{ secrets.DEPLOY_KEY }}
       - name: Build site
-        run: ./mvnw site site:stage -DskipTests -B -V --no-transfer-progress
+        run: ./mvnw site site:stage -DskipTests -Dlicense.skip=true -B -V --no-transfer-progress
         env:
           CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml
index 43ed44adc..236865ba3 100644
--- a/.github/workflows/sonar.yaml
+++ b/.github/workflows/sonar.yaml
@@ -18,9 +18,9 @@ jobs:
         uses: actions/setup-java@v3
         with:
           java-version: 17
-          distribution: 'zulu'
+          distribution: zulu
       - name: Analyze with SonarCloud
-        run: ./mvnw verify sonar:sonar -B -V -D"sonar.projectKey=spotbugs_spotbugs-maven-plugin" -D"sonar.organization=spotbugs" -D"sonar.host.url=https://sonarcloud.io" -D"sonar.login=$SONAR_TOKEN" --no-transfer-progress
+        run: ./mvnw verify sonar:sonar -B -V -Dsonar.projectKey=spotbugs_spotbugs-maven-plugin -Dsonar.organization=spotbugs -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=$SONAR_TOKEN -Dlicense.skip=true --no-transfer-progress
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml
index 08c015e15..f19453c31 100644
--- a/.github/workflows/sonatype.yaml
+++ b/.github/workflows/sonatype.yaml
@@ -17,7 +17,7 @@ jobs:
           java-version: 17
           distribution: 'zulu'
       - name: Deploy to Sonatype
-        run: ./mvnw deploy -DskipTests -B -V --no-transfer-progress --settings ./.mvn/settings.xml
+        run: ./mvnw deploy -DskipTests -B -V --no-transfer-progress --settings ./.mvn/settings.xml -Dlicense.skip=true
         env:
           CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
           CI_DEPLOY_PASSWORD: ${{ secrets.CI_DEPLOY_PASSWORD }}

From 73a1a3132153330216641a5afd9f50303314f68e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:19:46 -0400
Subject: [PATCH 0965/1013] [license] Try doubleslash for bsh file as its
 really shell even though looks like java

---
 pom.xml                         |  2 +-
 src/it/MFINDBUGS-145/verify.bsh | 31 ++++++++++++++++---------------
 2 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/pom.xml b/pom.xml
index 19c45f772..10985e02b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -638,7 +638,7 @@
               
             
             
-              SLASHSTAR_STYLE
+              DOUBLESLASH_STYLE
             
           
         
diff --git a/src/it/MFINDBUGS-145/verify.bsh b/src/it/MFINDBUGS-145/verify.bsh
index 6a5ad6348..084a7742a 100644
--- a/src/it/MFINDBUGS-145/verify.bsh
+++ b/src/it/MFINDBUGS-145/verify.bsh
@@ -1,18 +1,19 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+//
+// Copyright 2005-2023 the original author or authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+//
+
 import org.codehaus.plexus.util.FileUtils;
 
 import java.io.*;

From 0379638e2abf4aa3535b6336bc4e455cf9bd9ff1 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:40:21 -0400
Subject: [PATCH 0966/1013] [fix] Issue was line number in verify.bsh

---
 src/it/MFINDBUGS-145/verify.bsh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/it/MFINDBUGS-145/verify.bsh b/src/it/MFINDBUGS-145/verify.bsh
index 084a7742a..721deb1e3 100644
--- a/src/it/MFINDBUGS-145/verify.bsh
+++ b/src/it/MFINDBUGS-145/verify.bsh
@@ -29,15 +29,14 @@ String[] paths =
 for ( String path : paths ) {
     File file = new File( basedir, path );
     System.out.println( "Checking for existence of " + file );
-    if ( !file.isFile() )
-    {
+    if ( !file.isFile() ) {
         throw new FileNotFoundException( "Missing: " + file.getAbsolutePath() );
     }
 }
 
 File report = new File( basedir, "target/site/spotbugs.html" );
 String content = FileUtils.fileRead( report, "UTF-8" );
-if ( content.indexOf( "" ) < 0 ) {
+if ( content.indexOf( "" ) < 0 ) {
     throw new IOException( "XRef link not generated." );
 }
 

From 6be7a274d4fa9d9efe0459699cedb36bd013f1d5 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:40:26 -0400
Subject: [PATCH 0967/1013] Revert "[license] Try doubleslash for bsh file as
 its really shell even though looks like java"

This reverts commit f57cfda939f5fcfe1bf7bb377811b48fcee8a7f4.
---
 pom.xml                         |  2 +-
 src/it/MFINDBUGS-145/verify.bsh | 31 +++++++++++++++----------------
 2 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/pom.xml b/pom.xml
index 10985e02b..19c45f772 100644
--- a/pom.xml
+++ b/pom.xml
@@ -638,7 +638,7 @@
               
             
             
-              DOUBLESLASH_STYLE
+              SLASHSTAR_STYLE
             
           
         
diff --git a/src/it/MFINDBUGS-145/verify.bsh b/src/it/MFINDBUGS-145/verify.bsh
index 721deb1e3..2789cdae9 100644
--- a/src/it/MFINDBUGS-145/verify.bsh
+++ b/src/it/MFINDBUGS-145/verify.bsh
@@ -1,19 +1,18 @@
-//
-// Copyright 2005-2023 the original author or authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     https://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-//
-
+/*
+ * Copyright 2005-2023 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 import org.codehaus.plexus.util.FileUtils;
 
 import java.io.*;

From 33ff59362aa1d906a877527505c35011f5a16643 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:16:25 -0400
Subject: [PATCH 0968/1013] [pom] Override guava to 32.0.1-jre

---
 pom.xml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/pom.xml b/pom.xml
index 19c45f772..3bb345a47 100644
--- a/pom.xml
+++ b/pom.xml
@@ -238,6 +238,7 @@
     3.2.2
     2.1
     2.10.1
+    32.0.1-jre2.13.0
     2.0.0
     2.6
@@ -389,6 +390,12 @@
       ${javaparserVersion}
     
 
+    
+      com.google.guava
+      guava
+      ${guava.version}
+    
+
     
       jaxen
       jaxen

From b67e23411434610901acff14f43d0cf28fae6a95 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:19:09 -0400
Subject: [PATCH 0969/1013] [pom] Fix guava tagging

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 3bb345a47..dfbc3a4f1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -238,7 +238,7 @@
     3.2.2
     2.1
     2.10.1
-    32.0.1-jre32.0.1-jre
     2.13.0
     2.0.0
     2.6

From 26e9f012adff6c6acdaf2af0ea5a87dc7923646f Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 13:26:03 -0400
Subject: [PATCH 0970/1013] [pom] Drop bcel back to 6.6.1 as it breaks doxia on
 site

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index dfbc3a4f1..6843c1ed5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -231,7 +231,7 @@
 
     
     9.5
-    6.7.0
+    6.6.1
     1.9.4
     1.2
     1.15

From bf74494d89db5dce88a35d06e5a9db5dc0d63ad7 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 17:55:43 -0400
Subject: [PATCH 0971/1013] [pom] Override extra enforcer rules to 1.7.0

---
 pom.xml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pom.xml b/pom.xml
index 6843c1ed5..52d305851 100644
--- a/pom.xml
+++ b/pom.xml
@@ -246,6 +246,9 @@
 
     
     com.github.spotbugs.maven
+
+    
+    1.7.0
   
 
   

From a979713daf0cdcf25614532bb19a75f5b81c9303 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 18:33:16 -0400
Subject: [PATCH 0972/1013] [GHA] Drop to maven 4 alpha 4 to see if issue is a
 regression

---
 .github/workflows/it-maven-4.0.0.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index fbc87cc75..aafff6fbc 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -1,11 +1,11 @@
-name: Java Integration Tests Maven 4.0.0-alpha-5
+name: Java Integration Tests Maven 4.0.0-alpha-4
 
 on: [push, pull_request]
 
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Integration Tests Maven 4.0.0-alpha-5
+    name: Integration Tests Maven 4.0.0-alpha-4
 
     steps:
       - uses: actions/checkout@v3
@@ -14,9 +14,9 @@ jobs:
         with:
           java-version: 17
           distribution: zulu
-      - name: Load Maven 4.0.0-alpha-5
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-5 --no-transfer-progress
+      - name: Load Maven 4.0.0-alpha-4
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-4 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress

From d78ff3f310beb8bd0b07917498acfcfcba2de108 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 19:08:43 -0400
Subject: [PATCH 0973/1013] [pom] Exclude plexus container default

---
 pom.xml | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/pom.xml b/pom.xml
index 52d305851..5bd715b1b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -490,6 +490,10 @@
           commons-logging
           commons-logging
         
+        
+          org.codehaus.plexus
+          plexus-container-default
+        
       
     
     
@@ -525,6 +529,12 @@
       org.apache.maven.doxia
       doxia-integration-tools
       ${doxiaSiteToolsVersion}
+      
+        
+          org.codehaus.plexus
+          plexus-container-default
+        
+      
     
 
     
@@ -582,17 +592,6 @@
     
 
     
-    
-      org.codehaus.plexus
-      plexus-container-default
-      ${plexusContainerVersion}
-      
-          
-              junit
-              junit
-          
-      
-    
     
       org.codehaus.plexus
       plexus-resources

From ae262bae560adad3dea113b263b9b88049adf847 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 19:51:17 -0400
Subject: [PATCH 0974/1013] [maven-release-plugin] prepare release
 spotbugs-maven-plugin-4.7.3.5

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 5bd715b1b..0283e2f65 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.5-SNAPSHOT
+  4.7.3.5
   maven-plugin
 
   spotbugs-maven-plugin
@@ -141,7 +141,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    HEAD
+    spotbugs-maven-plugin-4.7.3.5
   
   
     Github
@@ -164,7 +164,7 @@
     ${project.version}
 
     
-    1680820879
+    1687218645
 
     
     4.7.3

From 4d45aadf1fc827ed41954380c04c0a2ae2e417af Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Mon, 19 Jun 2023 19:51:21 -0400
Subject: [PATCH 0975/1013] [maven-release-plugin] prepare for next development
 iteration

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 0283e2f65..63a684cd7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.5
+  4.7.3.6-SNAPSHOT
   maven-plugin
 
   spotbugs-maven-plugin
@@ -141,7 +141,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    spotbugs-maven-plugin-4.7.3.5
+    HEAD
   
   
     Github
@@ -164,7 +164,7 @@
     ${project.version}
 
     
-    1687218645
+    1687218680
 
     
     4.7.3

From 6d1d89ce7742571908683d9ff8edc4f8ae72fef3 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 26 Jun 2023 13:29:01 +0000
Subject: [PATCH 0976/1013] Update mavenVersion to v3.9.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 63a684cd7..9b007f6c3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -187,7 +187,7 @@
     3.3.2
     3.1.1
     3.2.0
-    3.9.2
+    3.9.3
 
     2.1.1
     1.2.0

From ad8505d0323c942b079cce2d90fe11336f30edec Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 27 Jun 2023 01:20:24 +0000
Subject: [PATCH 0977/1013] Update dependency maven to v3.9.3

---
 .mvn/wrapper/maven-wrapper.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index e1d6b156e..5366408e6 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -14,5 +14,5 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.2/apache-maven-3.9.2-bin.zip
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.3/apache-maven-3.9.3-bin.zip
 wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

From b7d02b5f3b1f6f5fbe4562d24edea247415b1c42 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 27 Jun 2023 01:20:55 +0000
Subject: [PATCH 0978/1013] Update mavenCoreVersion to v3.9.3

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 9b007f6c3..490712137 100644
--- a/pom.xml
+++ b/pom.xml
@@ -181,7 +181,7 @@
     1.12.0
     1.11.1
 
-    3.9.2
+    3.9.3
     3.4.2
     0.13.1
     3.3.2

From 69c677543fbe7d55b60c015d48117bce6dd82f3a Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 27 Jun 2023 01:21:31 +0000
Subject: [PATCH 0979/1013] Update dependency commons-codec:commons-codec to
 v1.16.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 490712137..e30b8ab16 100644
--- a/pom.xml
+++ b/pom.xml
@@ -234,7 +234,7 @@
     6.6.1
     1.9.4
     1.2
-    1.15
+    1.16.0
     3.2.2
     2.1
     2.10.1

From 908767f914f35cb85cb241c97d12f54f589140fc Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 27 Jun 2023 01:22:08 +0000
Subject: [PATCH 0980/1013] Update jgit.version to v5.13.2.202306221912-r

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index e30b8ab16..015dcdae4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -227,7 +227,7 @@
     4.0.4
     7.6.0
 
-    5.13.1.202206130422-r
+    5.13.2.202306221912-r
 
     
     9.5

From c8b8de85881598eea95f5054ecb1be4744d1493c Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 30 Jun 2023 16:46:18 +0000
Subject: [PATCH 0981/1013] Update dependency com.google.guava:guava to
 v32.1.1-jre

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 015dcdae4..f4324022f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -238,7 +238,7 @@
     3.2.2
     2.1
     2.10.1
-    32.0.1-jre
+    32.1.1-jre
     2.13.0
     2.0.0
     2.6

From 38025869dac0bc3e4c94f29488c0093ba499b113 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Sat, 1 Jul 2023 16:23:17 +0000
Subject: [PATCH 0982/1013] Update dependency
 com.github.javaparser:javaparser-core to v3.25.4

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 015dcdae4..081ffd9b4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -176,7 +176,7 @@
 
     1.10.13
     4.0.12
-    3.25.3
+    3.25.4
 
     1.12.0
     1.11.1

From 0fc265c84e4e2b392f4614db970c559cf6156839 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Sat, 1 Jul 2023 17:40:45 +0000
Subject: [PATCH 0983/1013] Update groovy monorepo to v4.0.13

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 081ffd9b4..8f32671b9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -175,7 +175,7 @@
     2.0.7
 
     1.10.13
-    4.0.12
+    4.0.13
     3.25.4
 
     1.12.0

From be9f8317c3ec4f0843f0373cfd0f9be108a2267e Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Wed, 12 Jul 2023 04:20:59 +0000
Subject: [PATCH 0984/1013] Update JamesIves/github-pages-deploy-action action
 to v4.4.3

---
 .github/workflows/site.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml
index cb6e7bff9..eaaf74710 100644
--- a/.github/workflows/site.yaml
+++ b/.github/workflows/site.yaml
@@ -25,7 +25,7 @@ jobs:
           CI_DEPLOY_USERNAME: ${{ secrets.CI_DEPLOY_USERNAME }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       - name: Deploy Site to gh-pages
-        uses: JamesIves/github-pages-deploy-action@v4.4.2
+        uses: JamesIves/github-pages-deploy-action@v4.4.3
         with:
           SSH: true
           BRANCH: gh-pages

From ffb621ee67cb828fdc4c1d6156a0de3d11890adf Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 28 Jul 2023 04:04:53 +0000
Subject: [PATCH 0985/1013] Update dependency org.apache.commons:commons-lang3
 to v3.13.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index b8b2e46ef..fc936954f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -242,7 +242,7 @@
     2.13.0
     2.0.0
     2.6
-    3.12.0
+    3.13.0
 
     
     com.github.spotbugs.maven

From f60b5e60ffcec7f207b1a76712a3804ec6a74af7 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 3 Aug 2023 14:33:28 +0000
Subject: [PATCH 0986/1013] Update mavenVersion to v3.9.4

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index fc936954f..0fe058983 100644
--- a/pom.xml
+++ b/pom.xml
@@ -187,7 +187,7 @@
     3.3.2
     3.1.1
     3.2.0
-    3.9.3
+    3.9.4
 
     2.1.1
     1.2.0

From 722aace8054a8fd1878bd9593ef06bffd57198e4 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 14 Aug 2023 21:34:22 +0000
Subject: [PATCH 0987/1013] Update dependency com.google.guava:guava to
 v32.1.2-jre

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 0fe058983..66b0115f5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -238,7 +238,7 @@
     3.2.2
     2.1
     2.10.1
-    32.1.1-jre
+    32.1.2-jre
     2.13.0
     2.0.0
     2.6

From b2e37523c409145a5db47d1d26f53c56d993d9b2 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 14 Aug 2023 21:34:25 +0000
Subject: [PATCH 0988/1013] Update dependency maven to v3.9.4

---
 .mvn/wrapper/maven-wrapper.properties | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.mvn/wrapper/maven-wrapper.properties b/.mvn/wrapper/maven-wrapper.properties
index 5366408e6..3267ebce8 100644
--- a/.mvn/wrapper/maven-wrapper.properties
+++ b/.mvn/wrapper/maven-wrapper.properties
@@ -14,5 +14,5 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.3/apache-maven-3.9.3-bin.zip
+distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.4/apache-maven-3.9.4-bin.zip
 wrapperUrl=https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/3.2.0/maven-wrapper-3.2.0.jar

From c416a74cfddb9d4b870a4f2466147c8f9e6ffd8d Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 14 Aug 2023 21:35:41 +0000
Subject: [PATCH 0989/1013] Update mavenCoreVersion to v3.9.4

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 66b0115f5..436845473 100644
--- a/pom.xml
+++ b/pom.xml
@@ -181,7 +181,7 @@
     1.12.0
     1.11.1
 
-    3.9.3
+    3.9.4
     3.4.2
     0.13.1
     3.3.2

From 6c2c818e651e11b5e90012e16e459ce007198bc8 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 19:34:42 -0400
Subject: [PATCH 0990/1013] [cleanup] Remove jformatstring from sample it tests
 as not part of project nor needed there

---
 src/it/excludeBugsFile/excludeBugs1.xml     | 2 +-
 src/it/excludeBugsFile/excludeBugs2.xml     | 2 +-
 src/site/resources/examples/spotbugsXml.xml | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/it/excludeBugsFile/excludeBugs1.xml b/src/it/excludeBugsFile/excludeBugs1.xml
index 8992c88b0..b57b21497 100644
--- a/src/it/excludeBugsFile/excludeBugs1.xml
+++ b/src/it/excludeBugsFile/excludeBugs1.xml
@@ -15,7 +15,7 @@
     limitations under the License.
 
 -->
-/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-sink-api/1.1.3/doxia-sink-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-site-renderer/1.1.3/doxia-site-renderer-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/targetDoomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 14]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 28]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 35]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 16]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 24]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 30]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 26]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 37]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 92-2973]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 12]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 92-2973]Expected StringValue loaded from ?At ArrayEquality.java:[line 17]equals() used to compare array and nonarrayCalling String[][].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 27]equals() used to compare array and nonarrayCalling String[].equals(String[][]) in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 32]Call to equals() comparing different typesCall to String[].equals(int[]) in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 37]Call to equals() comparing different typesCall to int[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 42]Call to equals() comparing different typesCall to StringBuffer[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 47]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 162]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 67]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 79]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 83]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 115]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 111]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 127]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 123]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 131]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 119]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 56]Nullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 12 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 6-19]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 11]Redundant null check at UseCheckUse.java:[line 12]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 44]Method call passes null to a nonnull parameter Null passed for nonnull parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 24]Dodgy codeBad practiceCorrectnessInternationalizationClass defines equals() and uses Object.hashCode()

+/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-sink-api/1.1.3/doxia-sink-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-site-renderer/1.1.3/doxia-site-renderer-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/basic-2/targetDoomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 14]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 28]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 10-38]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 35]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 16]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-24]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 24]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 30]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 16]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 26]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 37]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 92-2973]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 12]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 92-2973]Expected StringValue loaded from ?At ArrayEquality.java:[line 17]equals() used to compare array and nonarrayCalling String[][].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 27]equals() used to compare array and nonarrayCalling String[].equals(String[][]) in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 32]Call to equals() comparing different typesCall to String[].equals(int[]) in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 37]Call to equals() comparing different typesCall to int[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 42]Call to equals() comparing different typesCall to StringBuffer[].equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 8-57]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 47]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 162]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 67]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 79]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 83]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 115]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 111]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 127]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 123]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 131]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 41-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 119]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 92-2973]Actual type StringAt Object.java:[lines 20-535]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 56]Nullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 12 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 6-19]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 11]Redundant null check at UseCheckUse.java:[line 12]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 44]Method call passes null to a nonnull parameter Null passed for nonnull parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-58]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 24]Dodgy codeBad practiceCorrectnessInternationalizationClass defines equals() and uses Object.hashCode()

 
   <p> This class overrides <code>equals(Object)</code>, but does not
   override <code>hashCode()</code>, and inherits the implementation of
diff --git a/src/it/excludeBugsFile/excludeBugs2.xml b/src/it/excludeBugsFile/excludeBugs2.xml
index adae641ba..1bdfd626e 100644
--- a/src/it/excludeBugsFile/excludeBugs2.xml
+++ b/src/it/excludeBugsFile/excludeBugs2.xml
@@ -15,7 +15,7 @@
     limitations under the License.
 
 -->
-/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.0/jFormatString-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/targetDead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 17]Another occurrence at UselessAssignments.java:[line 19]Dead store to local variableDead store to $L1 in UselessCurrentThread.test4()At UselessCurrentThread.java:[lines 7-64]In class UselessCurrentThreadIn method UselessCurrentThread.test4()Local variable stored in JVM register 1At UselessCurrentThread.java:[line 37]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 28]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 159]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]Dodgy codeDead store to local variable

+/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/target/classes/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/2.4.1-SNAPSHOT/spotbugs-maven-plugin-2.4.1-SNAPSHOT.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-mojo/1.3/gmaven-mojo-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-api/1.3/gmaven-runtime-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-api/1.3/gmaven-feature-api-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-1.5/1.3/gmaven-runtime-1.5-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/feature/gmaven-feature-support/1.3/gmaven-feature-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all-minimal/1.5.8/groovy-all-minimal-1.5.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.7.1/ant-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.7.1/ant-launcher-1.7.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jline/jline/0.9.94/jline-0.9.94.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/gmaven-plugin/1.3/gmaven-plugin-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-loader/1.3/gmaven-runtime-loader-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/gmaven/runtime/gmaven-runtime-support/1.3/gmaven-runtime-support-1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gshell/gshell-io/2.0/gshell-io-2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/thoughtworks/qdox/qdox/1.10/qdox-1.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/file-management/1.2.1/file-management-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-shared-io/1.1/maven-shared-io-1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.4/commons-lang-2.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/slf4j/slf4j-api/1.5.10/slf4j-api-1.5.10.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/gossip/gossip/1.2/gossip-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/1.7.4/groovy-all-1.7.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.1.3/doxia-core-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.1.3/doxia-logging-api-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.2/commons-codec-1.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.1.3/doxia-decoration-model-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.1.3/doxia-module-xhtml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.1.3/doxia-module-fml-1.1.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2/commons-collections-3.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs-ant/2.0.0/spotbugs-ant-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel/2.0.0/bcel-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.0/jsr305-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/annotations/2.0.0/annotations-2.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.1/jaxen-1.1.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jdom/jdom/1.0/jdom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xom/xom/1.0/xom-1.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xmlParserAPIs/2.6.2/xmlParserAPIs-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xalan/xalan/2.6.0/xalan-2.6.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm/3.3/asm-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-tree/3.3/asm-tree-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/asm/asm-commons/3.3/asm-commons-3.3.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jgoodies/plastic/1.2.0/plastic-1.2.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-4/plexus-resources-1.0-alpha-4.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.6.2/xercesImpl-2.6.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/junit/junit/4.8.1/junit-4.8.1.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/NetBeansProjects/spotbugs-maven-plugin/target/it/includeFile/targetDead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 14-42]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 17]Another occurrence at UselessAssignments.java:[line 19]Dead store to local variableDead store to $L1 in UselessCurrentThread.test4()At UselessCurrentThread.java:[lines 7-64]In class UselessCurrentThreadIn method UselessCurrentThread.test4()Local variable stored in JVM register 1At UselessCurrentThread.java:[line 37]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 10-43]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 28]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-181]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 159]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 38-58]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 40]Another occurrence at ArrayListContains0.java:[line 41]Dodgy codeDead store to local variable

 
 <p>
 This instruction assigns a value to a local variable,
diff --git a/src/site/resources/examples/spotbugsXml.xml b/src/site/resources/examples/spotbugsXml.xml
index 4a8009f70..a39eba370 100644
--- a/src/site/resources/examples/spotbugsXml.xml
+++ b/src/site/resources/examples/spotbugsXml.xml
@@ -15,7 +15,7 @@
     limitations under the License.
 
 -->
-/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/3.0.3-SNAPSHOT/spotbugs-maven-plugin-3.0.3-SNAPSHOT.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.1/jsr305-2.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel-spotbugs/6.0/bcel-spotbugs-6.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jFormatString/2.0.1/jFormatString-2.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-debug-all/5.0.2/asm-debug-all-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-commons/5.0.2/asm-commons-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-tree/5.0.2/asm-tree-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm/5.0.2/asm-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.6/commons-lang-2.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/apple/AppleJavaExtensions/1.4/AppleJavaExtensions-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.9.4/ant-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.9.4/ant-launcher-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/2.4.3/groovy-all-2.4.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.4/doxia-core-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.4/doxia-logging-api-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.3/commons-codec-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.4/doxia-module-fml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-chain/commons-chain/1.1/commons-chain-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/sslext/sslext/1.2-0/sslext-1.2-0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/antlr/antlr/2.7.2/antlr-2.7.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-7/plexus-resources-1.0-alpha-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/junit/junit/4.11/junit-4.11.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/targetClass inherits equals() and uses Object.hashCode()AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode()At AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeAt AbstractMissingHashCode.java:[line 14]Unused fieldUnused field: AbstractMissingHashCode$StillMissingHashCode.yAt AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeIn AbstractMissingHashCode.javaField AbstractMissingHashCode$StillMissingHashCode.yIn AbstractMissingHashCode.javaShould be a static inner classShould AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 21-24]In class AccidentalNonConstructorInInnerClass$DoNotReportAt AccidentalNonConstructorInInnerClass.java:[lines 21-24]Should be a static inner classShould AccidentalNonConstructorInInnerClass$Report be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 3-7]In class AccidentalNonConstructorInInnerClass$ReportAt AccidentalNonConstructorInInnerClass.java:[lines 3-7]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 15]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 27]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 33]Invocation of toString on an unnamed arrayInvocation of toString on an unnamed array in ArrayToString.print2()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print2()At ArrayToString.java:[line 29]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print0(String[])At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print0(String[])Local variable stored in JVM register 1At ArrayToString.java:[line 18]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print1()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print1()Local variable stored in JVM register 1At ArrayToString.java:[line 24]Invocation of toString on an arrayInvocation of toString on gargs in ArrayToString.print3()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print3()In ArrayToString.javaValue loaded from field ArrayToString.gargsAt ArrayToString.java:[line 34]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Unusual equals method UseOfNonHashableClassInHashDataStructure.equals(Object) is unusualAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 23]equals() method does not check for null argumentUseOfNonHashableClassInHashDataStructure.equals(Object) does not check for null argumentAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)Parameter $L1At UseOfNonHashableClassInHashDataStructure.java:[line 14]Dead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Another occurrence at UselessAssignments.java:[line 13]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 24]Double assignment of fieldDouble assignment of field g1 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.g1In UselessAssignments.javaDid you mean to refer to the field UselessAssignments.g2?At UselessAssignments.java:[line 12]Double assignment of fieldDouble assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Another occurrence at UselessAssignments.java:[line 26]Double assignment of fieldDouble assignment of field foo in UselessAssignments.report(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.report(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Double assignment of fieldDouble assignment of field bar in UselessAssignments.setFoo(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.setFoo(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Double assignment of local variable Double assignment of $L3 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 3At UselessAssignments.java:[line 13]Self assignment of local variableSelf assignment of $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Unread fieldUnread field: UselessAssignments.barAt UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Unread fieldUnread field: UselessAssignments.g1At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g1At UselessAssignments.java:[line 12]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Unused fieldUnused field: UselessAssignments.g2At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g2In UselessAssignments.javaUseless control flowUseless control flow in UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[line 23]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[line 14]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[line 18]Useless non-empty void methodMethod UselessControlFlow.report4(Object[], Object) seems to be uselessAt UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report4(Object[], Object)At UselessControlFlow.java:[line 40]Static Thread.interrupted() method invoked on thread instanceUselessCurrentThread.run() invokes static Thread.interrupted() method on thread instanceAt UselessCurrentThread.java:[lines 5-36]In class UselessCurrentThreadIn method UselessCurrentThread.run()At UselessCurrentThread.java:[line 29]Finalizer does nothing but call superclass finalizerUselessFinalize.finalize() does nothing except call super.finalize(); delete itAt UselessFinalize.java:[lines 1-5]In class UselessFinalizeIn method UselessFinalize.finalize()At UselessFinalize.java:[lines 4-5]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 31]Code contains a hard coded reference to an absolute pathnameHard coded reference to an absolute pathname in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])File name /mainList.txtAt UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]"." or "|" used for regular expression"." or "|" used for regular expression in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method String.replaceAll(String, String)At UserMistakes.java:[line 15]Method discards result of readLine after checking if it is non-nullUserMistakes.main(String[]) discards result of readLine after checking if it is non-nullAt UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])At UserMistakes.java:[line 30]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 108-3095]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 8]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 108-3095]Expected StringValue loaded from ?At ArrayEquality.java:[line 12]Invocation of equals() on an array, which is equivalent to ==Using .equals to compare two String[]'s, (equivalent to ==) in equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])Actual type String[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 15]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a String[][] in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 18]equals(...) used to compare incompatible arraysUsing equals to compare a String[][] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 21]equals(...) used to compare incompatible arraysUsing equals to compare a int[] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 24]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a int[] in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 27]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a StringBuffer[] in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 30]Impossible castImpossible cast from java.util.LinkedList to java.util.ArrayList in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At LinkedList.java:[lines 85-1137]Actual type java.util.LinkedListAt ArrayList.java:[lines 102-966]Expected java.util.ArrayListValue loaded from ?At AllListsCouldBeEqual.java:[line 134]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 134]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 138]Return value of method without side effect is ignoredReturn value of java.util.Set.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.falsePositive()Called method java.util.Set.contains(Object)At AllListsCouldBeEqual.java:[line 152]Another occurrence at AllListsCouldBeEqual.java:[line 153]Return value of method without side effect is ignoredReturn value of java.util.List.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Called method java.util.List.contains(Object)At AllListsCouldBeEqual.java:[line 138]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 68]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 80]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 84]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 116]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 112]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 128]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 124]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 132]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 120]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 58]Another occurrence at ArrayListContains.java:[line 59]Another occurrence at ArrayListContains.java:[line 60]Another occurrence at ArrayListContains.java:[line 62]Another occurrence at ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 66]Another occurrence at ArrayListContains.java:[line 67]Another occurrence at ArrayListContains.java:[line 68]Another occurrence at ArrayListContains.java:[line 70]Another occurrence at ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 74]Another occurrence at ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 78]Another occurrence at ArrayListContains.java:[line 79]Another occurrence at ArrayListContains.java:[line 80]Another occurrence at ArrayListContains.java:[line 82]Another occurrence at ArrayListContains.java:[line 83]Another occurrence at ArrayListContains.java:[line 84]Another occurrence at ArrayListContains.java:[line 86]Another occurrence at ArrayListContains.java:[line 87]Another occurrence at ArrayListContains.java:[line 88]Another occurrence at ArrayListContains.java:[line 90]Another occurrence at ArrayListContains.java:[line 91]Another occurrence at ArrayListContains.java:[line 92]Another occurrence at ArrayListContains.java:[line 94]Another occurrence at ArrayListContains.java:[line 95]Another occurrence at ArrayListContains.java:[line 96]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 106]Another occurrence at ArrayListContains.java:[line 107]Another occurrence at ArrayListContains.java:[line 108]Another occurrence at ArrayListContains.java:[line 110]Another occurrence at ArrayListContains.java:[line 111]Another occurrence at ArrayListContains.java:[line 112]Another occurrence at ArrayListContains.java:[line 114]Another occurrence at ArrayListContains.java:[line 115]Another occurrence at ArrayListContains.java:[line 116]Another occurrence at ArrayListContains.java:[line 118]Another occurrence at ArrayListContains.java:[line 119]Another occurrence at ArrayListContains.java:[line 120]Another occurrence at ArrayListContains.java:[line 122]Another occurrence at ArrayListContains.java:[line 123]Another occurrence at ArrayListContains.java:[line 124]Another occurrence at ArrayListContains.java:[line 126]Another occurrence at ArrayListContains.java:[line 127]Another occurrence at ArrayListContains.java:[line 128]Another occurrence at ArrayListContains.java:[line 130]Another occurrence at ArrayListContains.java:[line 131]Another occurrence at ArrayListContains.java:[line 132]Another occurrence at ArrayListContains.java:[line 134]Another occurrence at ArrayListContains.java:[line 135]Another occurrence at ArrayListContains.java:[line 136]Another occurrence at ArrayListContains.java:[line 138]Another occurrence at ArrayListContains.java:[line 139]Another occurrence at ArrayListContains.java:[line 140]Another occurrence at ArrayListContains.java:[line 142]Another occurrence at ArrayListContains.java:[line 143]Another occurrence at ArrayListContains.java:[line 144]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 42]Another occurrence at ArrayListContains0.java:[line 43]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 58]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]Another occurrence at ArrayListContains0.java:[line 58]Unused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummySFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummySFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.wildcardFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.wildcardFIn ArrayListContains0.javaNullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 10 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 5-17]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 9]Redundant null check at UseCheckUse.java:[line 10]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 36]Method call passes null to a non-null parameter Null passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 20]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar3(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 41]Null value at UseAnnotations.java:[line 39]Known null at UseAnnotations.java:[line 40]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar4(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar4(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 46]Null value at UseAnnotations.java:[line 44]Known null at UseAnnotations.java:[line 45]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.bar() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 32]Known null at UseAnnotations.java:[line 32]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo()Local variable stored in JVM register ?Method invoked at UseAnnotations.java:[line 17]Known null at UseAnnotations.java:[line 17]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo4() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo4()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 28]Known null at UseAnnotations.java:[line 28]Method call passes null for non-null parameterNull passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo3(int)Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 might be null but must not be nullValue loaded from ?Method invoked at UseAnnotations.java:[line 25]Null value at UseAnnotations.java:[line 23]Known null at UseAnnotations.java:[line 24]clone method does not call super.clone()com.github.spotbugs.spotbugs-maven-plugin.it.App.clone() does not call super.clone()At App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Clone method may return nullcom.github.spotbugs.spotbugs-maven-plugin.it.App.clone() may return nullAt App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Dodgy codeBad practiceCorrectnessInternationalizationPerformanceImpossible cast

+/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/mojo/spotbugs-maven-plugin/3.0.3-SNAPSHOT/spotbugs-maven-plugin-3.0.3-SNAPSHOT.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/spotbugs/3.1.0/spotbugs-3.1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/net/jcip/jcip-annotations/1.0/jcip-annotations-1.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/jsr305/2.0.1/jsr305-2.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/github/spotbugs/bcel-spotbugs/6.0/bcel-spotbugs-6.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/dom4j/dom4j/1.6.1/dom4j-1.6.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xml-apis/xml-apis/1.0.b2/xml-apis-1.0.b2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-debug-all/5.0.2/asm-debug-all-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-commons/5.0.2/asm-commons-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm-tree/5.0.2/asm-tree-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/ow2/asm/asm/5.0.2/asm-5.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-lang/commons-lang/2.6/commons-lang-2.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/com/apple/AppleJavaExtensions/1.4/AppleJavaExtensions-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant/1.9.4/ant-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/ant/ant-launcher/1.9.4/ant-launcher-1.9.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/groovy/groovy-all/2.4.3/groovy-all-2.4.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/reporting/maven-reporting-impl/2.1/maven-reporting-impl-2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-validator/commons-validator/1.2.0/commons-validator-1.2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-digester/commons-digester/1.6/commons-digester-1.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-logging/commons-logging/1.0.4/commons-logging-1.0.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/oro/oro/2.0.8/oro-2.0.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-core/1.4/doxia-core-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-logging-api/1.4/doxia-logging-api-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-codec/commons-codec/1.3/commons-codec-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-xhtml/1.4/doxia-module-xhtml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/doxia/doxia-module-fml/1.4/doxia-module-fml-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity/1.5/velocity-1.5.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-chain/commons-chain/1.1/commons-chain-1.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/sslext/sslext/1.2-0/sslext-1.2-0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/antlr/antlr/2.7.2/antlr-2.7.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/apache/maven/shared/maven-doxia-tools/1.2.1/maven-doxia-tools-1.2.1.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/commons-io/commons-io/1.4/commons-io-1.4.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-resources/1.0-alpha-7/plexus-resources-1.0-alpha-7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/target/test-classes/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/junit/junit/4.11/junit-4.11.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/jboss/jboss-j2ee/4.0.2/jboss-j2ee-4.0.2.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/local-repo/org/mortbay/jetty/servlet-api/2.5-6.0.0/servlet-api-2.5-6.0.0.jar/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it-src-spotbugs/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/src/it-src/test/java/Users/garvin/gitProjects/Spotbugs/spotbugs-maven-plugin/target/it/basic-1/targetClass inherits equals() and uses Object.hashCode()AbstractMissingHashCode$StillMissingHashCode inherits equals and uses Object.hashCode()At AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeAt AbstractMissingHashCode.java:[line 14]Unused fieldUnused field: AbstractMissingHashCode$StillMissingHashCode.yAt AbstractMissingHashCode.java:[line 14]In class AbstractMissingHashCode$StillMissingHashCodeIn AbstractMissingHashCode.javaField AbstractMissingHashCode$StillMissingHashCode.yIn AbstractMissingHashCode.javaShould be a static inner classShould AccidentalNonConstructorInInnerClass$DoNotReport be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 21-24]In class AccidentalNonConstructorInInnerClass$DoNotReportAt AccidentalNonConstructorInInnerClass.java:[lines 21-24]Should be a static inner classShould AccidentalNonConstructorInInnerClass$Report be a _static_ inner class?At AccidentalNonConstructorInInnerClass.java:[lines 3-7]In class AccidentalNonConstructorInInnerClass$ReportAt AccidentalNonConstructorInInnerClass.java:[lines 3-7]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject1(File, Object)At AppendingToAnObjectOutputStream.java:[line 15]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject2(File, Object)At AppendingToAnObjectOutputStream.java:[line 21]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject3(String, Object)At AppendingToAnObjectOutputStream.java:[line 27]Doomed attempt to append to an object output streamDoomed attempt to append to an object output stream in AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[lines 11-36]In class AppendingToAnObjectOutputStreamIn method AppendingToAnObjectOutputStream.appendObject4(String, Object)At AppendingToAnObjectOutputStream.java:[line 33]Invocation of toString on an unnamed arrayInvocation of toString on an unnamed array in ArrayToString.print2()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print2()At ArrayToString.java:[line 29]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print0(String[])At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print0(String[])Local variable stored in JVM register 1At ArrayToString.java:[line 18]Invocation of toString on an arrayInvocation of toString on ? in ArrayToString.print1()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print1()Local variable stored in JVM register 1At ArrayToString.java:[line 24]Invocation of toString on an arrayInvocation of toString on gargs in ArrayToString.print3()At ArrayToString.java:[lines 4-35]In class ArrayToStringIn method ArrayToString.print3()In ArrayToString.javaValue loaded from field ArrayToString.gargsAt ArrayToString.java:[line 34]Bad comparison of signed byteBad comparison of signed byte with 200 in AssumeUnsignedBytes.find200(byte[])At AssumeUnsignedBytes.java:[lines 3-10]In class AssumeUnsignedBytesIn method AssumeUnsignedBytes.find200(byte[])Value 200At AssumeUnsignedBytes.java:[line 8]Unusual equals method UseOfNonHashableClassInHashDataStructure.equals(Object) is unusualAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Class defines equals() and uses Object.hashCode()UseOfNonHashableClassInHashDataStructure defines equals and uses Object.hashCode()At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 14]Use of class without a hashCode() method in a hashed data structureUseOfNonHashableClassInHashDataStructure doesn't define a hashCode() method but is used in a hashed data structure in UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.get(UseOfNonHashableClassInHashDataStructure)At UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]Unhashable class UseOfNonHashableClassInHashDataStructure Called method java.util.HashMap.get(Object)At UseOfNonHashableClassInHashDataStructure.java:[line 23]equals() method does not check for null argumentUseOfNonHashableClassInHashDataStructure.equals(Object) does not check for null argumentAt UseOfNonHashableClassInHashDataStructure.java:[lines 3-23]In class UseOfNonHashableClassInHashDataStructureIn method UseOfNonHashableClassInHashDataStructure.equals(Object)Parameter $L1At UseOfNonHashableClassInHashDataStructure.java:[line 14]Dead store to local variableDead store to $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Another occurrence at UselessAssignments.java:[line 13]Overwritten incrementOverwritten increment in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()At UselessAssignments.java:[line 24]Double assignment of fieldDouble assignment of field g1 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.g1In UselessAssignments.javaDid you mean to refer to the field UselessAssignments.g2?At UselessAssignments.java:[line 12]Double assignment of fieldDouble assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Another occurrence at UselessAssignments.java:[line 26]Double assignment of fieldDouble assignment of field foo in UselessAssignments.report(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.report(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 31]Double assignment of fieldDouble assignment of field bar in UselessAssignments.setFoo(UselessAssignments, UselessAssignments)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.setFoo(UselessAssignments, UselessAssignments)In UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Self assignment of fieldSelf assignment of field foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Self assignment of fieldSelf assignment of field foo in UselessAssignments.oops()At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method UselessAssignments.oops()In UselessAssignments.javaField UselessAssignments.fooAt UselessAssignments.java:[line 25]Double assignment of local variable Double assignment of $L3 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 3At UselessAssignments.java:[line 13]Self assignment of local variableSelf assignment of $L2 in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)Local variable stored in JVM register 2At UselessAssignments.java:[line 11]Unread fieldUnread field: UselessAssignments.barAt UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.barAt UselessAssignments.java:[line 18]Unread fieldUnread field: UselessAssignments.g1At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g1At UselessAssignments.java:[line 12]Uninitialized read of field in constructorUninitialized read of foo in new UselessAssignments(int, int)At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn method new UselessAssignments(int, int)In UselessAssignments.javaField UselessAssignments.fooDid you mean to refer to the local variable ?At UselessAssignments.java:[line 10]Unused fieldUnused field: UselessAssignments.g2At UselessAssignments.java:[lines 8-35]In class UselessAssignmentsIn UselessAssignments.javaField UselessAssignments.g2In UselessAssignments.javaUseless control flowUseless control flow in UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report2(Object, Object)At UselessControlFlow.java:[line 23]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report0(Object, Object)At UselessControlFlow.java:[line 14]Useless control flow to next lineUseless control flow to next line in UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report1(Object, Object)At UselessControlFlow.java:[line 18]Useless non-empty void methodMethod UselessControlFlow.report4(Object[], Object) seems to be uselessAt UselessControlFlow.java:[lines 2-40]In class UselessControlFlowIn method UselessControlFlow.report4(Object[], Object)At UselessControlFlow.java:[line 40]Static Thread.interrupted() method invoked on thread instanceUselessCurrentThread.run() invokes static Thread.interrupted() method on thread instanceAt UselessCurrentThread.java:[lines 5-36]In class UselessCurrentThreadIn method UselessCurrentThread.run()At UselessCurrentThread.java:[line 29]Finalizer does nothing but call superclass finalizerUselessFinalize.finalize() does nothing except call super.finalize(); delete itAt UselessFinalize.java:[lines 1-5]In class UselessFinalizeIn method UselessFinalize.finalize()At UselessFinalize.java:[lines 4-5]Dead store to local variableDead store to $L3 in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Local variable stored in JVM register 3At UserMistakes.java:[line 31]Code contains a hard coded reference to an absolute pathnameHard coded reference to an absolute pathname in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])File name /mainList.txtAt UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]Reliance on default encodingFound reliance on default encoding in UserMistakes.main(String[]): new java.io.FileReader(String)At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method new java.io.FileReader(String)At UserMistakes.java:[line 29]Another occurrence at UserMistakes.java:[line 42]"." or "|" used for regular expression"." or "|" used for regular expression in UserMistakes.main(String[])At UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])Called method String.replaceAll(String, String)At UserMistakes.java:[line 15]Method discards result of readLine after checking if it is non-nullUserMistakes.main(String[]) discards result of readLine after checking if it is non-nullAt UserMistakes.java:[lines 11-47]In class UserMistakesIn method UserMistakes.main(String[])At UserMistakes.java:[line 30]equals() used to compare array and nonarrayCalling String[].equals(String) in equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality(String[], String)At String.java:[lines 108-3095]Actual type StringExpected String[]Value loaded from ?At ArrayEquality.java:[line 8]equals() used to compare array and nonarrayCalling String.equals(String[]) in equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality2(String[], String)Actual type String[]At String.java:[lines 108-3095]Expected StringValue loaded from ?At ArrayEquality.java:[line 12]Invocation of equals() on an array, which is equivalent to ==Using .equals to compare two String[]'s, (equivalent to ==) in equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality3(String[], String[])Actual type String[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 15]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a String[][] in equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality4(String[][], String[])Actual type String[]Expected String[][]Value loaded from ?At ArrayEquality.java:[line 18]equals(...) used to compare incompatible arraysUsing equals to compare a String[][] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality5(String[], String[][])Actual type String[][]Expected String[]Value loaded from ?At ArrayEquality.java:[line 21]equals(...) used to compare incompatible arraysUsing equals to compare a int[] and a String[] in equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality6(String[], int[])Actual type int[]Expected String[]Value loaded from ?At ArrayEquality.java:[line 24]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a int[] in equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality7(int[], String[])Actual type String[]Expected int[]Value loaded from ?At ArrayEquality.java:[line 27]equals(...) used to compare incompatible arraysUsing equals to compare a String[] and a StringBuffer[] in equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])At ArrayEquality.java:[lines 5-36]In class equals.ArrayEqualityIn method equals.ArrayEquality.reportProblemsWithArrayEquality8(StringBuffer[], String[])Actual type String[]Expected StringBuffer[]Value loaded from ?At ArrayEquality.java:[line 30]Impossible castImpossible cast from java.util.LinkedList to java.util.ArrayList in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At LinkedList.java:[lines 85-1137]Actual type java.util.LinkedListAt ArrayList.java:[lines 102-966]Expected java.util.ArrayListValue loaded from ?At AllListsCouldBeEqual.java:[line 134]Dead store to local variableDead store to $L2 in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Local variable stored in JVM register 2At AllListsCouldBeEqual.java:[line 134]Null pointer dereferenceNull pointer dereference of ? in gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])At AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Value loaded from ?Dereferenced at AllListsCouldBeEqual.java:[line 138]Return value of method without side effect is ignoredReturn value of java.util.Set.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.falsePositive()Called method java.util.Set.contains(Object)At AllListsCouldBeEqual.java:[line 152]Another occurrence at AllListsCouldBeEqual.java:[line 153]Return value of method without side effect is ignoredReturn value of java.util.List.contains(Object) ignored, but method has no side effectAt AllListsCouldBeEqual.java:[lines 12-156]In class gcUnrelatedTypes.AllListsCouldBeEqualIn method gcUnrelatedTypes.AllListsCouldBeEqual.main(String[])Called method java.util.List.contains(Object)At AllListsCouldBeEqual.java:[line 138]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 68]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 80]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 84]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 116]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$Dummy in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 9]Expected gcUnrelatedTypes.ArrayListContains$DummyCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummyF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 112]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childEF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 128]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains$DummyChild in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt ArrayListContains.java:[line 13]Expected gcUnrelatedTypes.ArrayListContains$DummyChildCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 124]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.childSF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 132]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in gcUnrelatedTypes.ArrayListContains.testFields()At ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)In ArrayListContains.javaInvoked on gcUnrelatedTypes.ArrayListContains.dummySF? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains.java:[line 120]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method new gcUnrelatedTypes.ArrayListContains(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 58]Another occurrence at ArrayListContains.java:[line 59]Another occurrence at ArrayListContains.java:[line 60]Another occurrence at ArrayListContains.java:[line 62]Another occurrence at ArrayListContains.java:[line 63]Another occurrence at ArrayListContains.java:[line 64]Another occurrence at ArrayListContains.java:[line 66]Another occurrence at ArrayListContains.java:[line 67]Another occurrence at ArrayListContains.java:[line 68]Another occurrence at ArrayListContains.java:[line 70]Another occurrence at ArrayListContains.java:[line 71]Another occurrence at ArrayListContains.java:[line 72]Another occurrence at ArrayListContains.java:[line 74]Another occurrence at ArrayListContains.java:[line 75]Another occurrence at ArrayListContains.java:[line 76]Another occurrence at ArrayListContains.java:[line 78]Another occurrence at ArrayListContains.java:[line 79]Another occurrence at ArrayListContains.java:[line 80]Another occurrence at ArrayListContains.java:[line 82]Another occurrence at ArrayListContains.java:[line 83]Another occurrence at ArrayListContains.java:[line 84]Another occurrence at ArrayListContains.java:[line 86]Another occurrence at ArrayListContains.java:[line 87]Another occurrence at ArrayListContains.java:[line 88]Another occurrence at ArrayListContains.java:[line 90]Another occurrence at ArrayListContains.java:[line 91]Another occurrence at ArrayListContains.java:[line 92]Another occurrence at ArrayListContains.java:[line 94]Another occurrence at ArrayListContains.java:[line 95]Another occurrence at ArrayListContains.java:[line 96]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains.java:[lines 42-150]In class gcUnrelatedTypes.ArrayListContainsIn method gcUnrelatedTypes.ArrayListContains.testFields()Called method java.util.ArrayList.contains(Object)At ArrayListContains.java:[line 106]Another occurrence at ArrayListContains.java:[line 107]Another occurrence at ArrayListContains.java:[line 108]Another occurrence at ArrayListContains.java:[line 110]Another occurrence at ArrayListContains.java:[line 111]Another occurrence at ArrayListContains.java:[line 112]Another occurrence at ArrayListContains.java:[line 114]Another occurrence at ArrayListContains.java:[line 115]Another occurrence at ArrayListContains.java:[line 116]Another occurrence at ArrayListContains.java:[line 118]Another occurrence at ArrayListContains.java:[line 119]Another occurrence at ArrayListContains.java:[line 120]Another occurrence at ArrayListContains.java:[line 122]Another occurrence at ArrayListContains.java:[line 123]Another occurrence at ArrayListContains.java:[line 124]Another occurrence at ArrayListContains.java:[line 126]Another occurrence at ArrayListContains.java:[line 127]Another occurrence at ArrayListContains.java:[line 128]Another occurrence at ArrayListContains.java:[line 130]Another occurrence at ArrayListContains.java:[line 131]Another occurrence at ArrayListContains.java:[line 132]Another occurrence at ArrayListContains.java:[line 134]Another occurrence at ArrayListContains.java:[line 135]Another occurrence at ArrayListContains.java:[line 136]Another occurrence at ArrayListContains.java:[line 138]Another occurrence at ArrayListContains.java:[line 139]Another occurrence at ArrayListContains.java:[line 140]Another occurrence at ArrayListContains.java:[line 142]Another occurrence at ArrayListContains.java:[line 143]Another occurrence at ArrayListContains.java:[line 144]Dead store to local variableDead store to $L11 in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Local variable stored in JVM register 11At ArrayListContains0.java:[line 42]Another occurrence at ArrayListContains0.java:[line 43]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$Dummy in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 7]Expected gcUnrelatedTypes.ArrayListContains0$DummyCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]No relationship between generic parameter and method argumentString is incompatible with expected argument type ArrayListContains0$DummyChild in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt ArrayListContains0.java:[line 11]Expected gcUnrelatedTypes.ArrayListContains0$DummyChildCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]No relationship between generic parameter and method argumentString is incompatible with expected argument type Object in new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)At String.java:[lines 108-3095]Actual type StringAt Object.java:[lines 37-553]Expected ObjectCalled method java.util.ArrayList.contains(Object)Invoked on ?? passed as argumentString.equals(Object) used to determine equalityAt ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 58]Return value of method without side effect is ignoredReturn value of java.util.ArrayList.contains(Object) ignored, but method has no side effectAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In method new gcUnrelatedTypes.ArrayListContains0(ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList, ArrayList)Called method java.util.ArrayList.contains(Object)At ArrayListContains0.java:[line 46]Another occurrence at ArrayListContains0.java:[line 48]Another occurrence at ArrayListContains0.java:[line 50]Another occurrence at ArrayListContains0.java:[line 52]Another occurrence at ArrayListContains0.java:[line 54]Another occurrence at ArrayListContains0.java:[line 56]Another occurrence at ArrayListContains0.java:[line 58]Unused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.childSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.childSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummyFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummyFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.dummySFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.dummySFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericEFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericEFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.genericSFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.genericSFIn ArrayListContains0.javaUnused fieldUnused field: gcUnrelatedTypes.ArrayListContains0.wildcardFAt ArrayListContains0.java:[lines 40-63]In class gcUnrelatedTypes.ArrayListContains0In ArrayListContains0.javaField gcUnrelatedTypes.ArrayListContains0.wildcardFIn ArrayListContains0.javaNullcheck of value previously dereferencedNullcheck of UseCheckUse.x at line 10 of value previously dereferenced in npe.UseCheckUse.f(boolean)At UseCheckUse.java:[lines 5-17]In class npe.UseCheckUseIn method npe.UseCheckUse.f(boolean)In UseCheckUse.javaValue loaded from field npe.UseCheckUse.xAt UseCheckUse.java:[line 9]Redundant null check at UseCheckUse.java:[line 10]Null pointer dereferenceNull pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar2()Value loaded from ?Dereferenced at UseAnnotations.java:[line 36]Method call passes null to a non-null parameter Null passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo2()At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo2()Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 is definitely null but must not be nullAt UseAnnotations.java:[line 20]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar3(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 41]Null value at UseAnnotations.java:[line 39]Known null at UseAnnotations.java:[line 40]Possible null pointer dereferencePossible null pointer dereference of ? in nullnessAnnotations.UseAnnotations.bar4(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar4(int)Value loaded from ?Dereferenced at UseAnnotations.java:[line 46]Null value at UseAnnotations.java:[line 44]Known null at UseAnnotations.java:[line 45]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.bar() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.bar()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 32]Known null at UseAnnotations.java:[line 32]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo()Local variable stored in JVM register ?Method invoked at UseAnnotations.java:[line 17]Known null at UseAnnotations.java:[line 17]Possible null pointer dereference due to return value of called methodPossible null pointer dereference in nullnessAnnotations.UseAnnotations.foo4() due to return value of called methodAt UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo4()Local variable stored in JVM register ?Dereferenced at UseAnnotations.java:[line 28]Known null at UseAnnotations.java:[line 28]Method call passes null for non-null parameterNull passed for non-null parameter of g(Object) in nullnessAnnotations.UseAnnotations.foo3(int)At UseAnnotations.java:[lines 6-46]In class nullnessAnnotations.UseAnnotationsIn method nullnessAnnotations.UseAnnotations.foo3(int)Called method nullnessAnnotations.UseAnnotations.g(Object)Argument 1 might be null but must not be nullValue loaded from ?Method invoked at UseAnnotations.java:[line 25]Null value at UseAnnotations.java:[line 23]Known null at UseAnnotations.java:[line 24]clone method does not call super.clone()com.github.spotbugs.spotbugs-maven-plugin.it.App.clone() does not call super.clone()At App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Clone method may return nullcom.github.spotbugs.spotbugs-maven-plugin.it.App.clone() may return nullAt App.java:[lines 11-21]In class com.github.spotbugs.spotbugs-maven-plugin.it.AppIn method com.github.spotbugs.spotbugs-maven-plugin.it.App.clone()At App.java:[line 21]Dodgy codeBad practiceCorrectnessInternationalizationPerformanceImpossible cast

 
 <p>
 This cast will always throw a ClassCastException.

From 424b9143bea7e40e068dc1afa557cf4a71e750ea Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 19:36:10 -0400
Subject: [PATCH 0991/1013] [cleanup] Remove poms not used by this project from
 tools

- jformatstring
- jsr305
- spotbugs-annotations
- spotbugs-ant
- spotbugs
---
 src/main/tools/jFormatString.pom        |  41 ---------
 src/main/tools/jsr305.pom               |  41 ---------
 src/main/tools/spotbugs-annotations.pom |  42 ---------
 src/main/tools/spotbugs-ant.pom         |  49 -----------
 src/main/tools/spotbugs.pom             | 112 ------------------------
 5 files changed, 285 deletions(-)
 delete mode 100644 src/main/tools/jFormatString.pom
 delete mode 100644 src/main/tools/jsr305.pom
 delete mode 100644 src/main/tools/spotbugs-annotations.pom
 delete mode 100644 src/main/tools/spotbugs-ant.pom
 delete mode 100644 src/main/tools/spotbugs.pom

diff --git a/src/main/tools/jFormatString.pom b/src/main/tools/jFormatString.pom
deleted file mode 100644
index 9912bd924..000000000
--- a/src/main/tools/jFormatString.pom
+++ /dev/null
@@ -1,41 +0,0 @@
-
-
-
-  4.0.0
-  com.github.spotbugs
-  jFormatString
-  @Spotbugs.version@
-  jar
-  https://www.github.com/spotbugs/
-  SpotBugs-jFormatString
-  jFormatString for Spotbugs
-  
-    
-      GNU Lesser Public License
-      https://www.gnu.org/licenses/lgpl.html
-      repo
-    
-  
-  
-    scm:git:https://github.com/spotbugs/spotbugs.git
-    scm:git:ssh://git@github.com/spotbugs/spotbugs.git
-    https://github.com/spotbugs/spotbugs
-  
-
diff --git a/src/main/tools/jsr305.pom b/src/main/tools/jsr305.pom
deleted file mode 100644
index 59e34af8f..000000000
--- a/src/main/tools/jsr305.pom
+++ /dev/null
@@ -1,41 +0,0 @@
-
-
-
-  4.0.0
-  com.github.spotbugs
-  jsr305
-  @spotbugs.version@
-  jar
-  https://spotbugs.github.io/
-  SpotBugs-jsr305
-  JSR305 Annotations for Spotbugs
-  
-    
-      The Apache Software License, Version 2.0
-      https://www.apache.org/licenses/LICENSE-2.0.txt
-      repo
-    
-  
-  
-    scm:git:https://code.google.com/p/jsr-305/
-    scm:git:https://code.google.com/p/jsr-305/
-    https://code.google.com/p/jsr-305/
-  
-
diff --git a/src/main/tools/spotbugs-annotations.pom b/src/main/tools/spotbugs-annotations.pom
deleted file mode 100644
index f2ad8c02f..000000000
--- a/src/main/tools/spotbugs-annotations.pom
+++ /dev/null
@@ -1,42 +0,0 @@
-
-
-
-  4.0.0
-  com.github.spotbugs
-  spotbugs-annotations
-  @spotbugs.version@
-  jar
-  https://spotbugs.github.io/
-  SpotBugs-Annotations
-  Annotation supports the SpotBugs tool
-  
-    
-      GNU Lesser Public License
-      https://www.gnu.org/licenses/lgpl.html
-      repo
-    
-  
-  
-    scm:git:https://github.com/spotbugs/spotbugs.git
-    scm:git:ssh://git@github.com/spotbugs/spotbugs.git
-    https://github.com/spotbugs/spotbugs
-    HEAD
-  
-
diff --git a/src/main/tools/spotbugs-ant.pom b/src/main/tools/spotbugs-ant.pom
deleted file mode 100644
index 42441a123..000000000
--- a/src/main/tools/spotbugs-ant.pom
+++ /dev/null
@@ -1,49 +0,0 @@
-
-
-
-  4.0.0
-  com.github.spotbugs
-  spotbugs-ant
-  @spotbugs.version@
-  jar
-  https://spotbugs.github.io/
-  SpotBugs-AntTask
-  AntTask to run Spotbugs
-  
-    
-      GNU Lesser Public License
-      https://www.gnu.org/licenses/lgpl.html
-      repo
-    
-  
-  
-    scm:git:https://github.com/spotbugs/spotbugs.git
-    scm:git:ssh://git@github.com/spotbugs/spotbugs.git
-    https://github.com/spotbugs/spotbugs
-    HEAD
-  
-  
-    
-      com.github.spotbugs
-      spotbugs
-      @spotbugs.version@
-    
-  
-
diff --git a/src/main/tools/spotbugs.pom b/src/main/tools/spotbugs.pom
deleted file mode 100644
index 747949715..000000000
--- a/src/main/tools/spotbugs.pom
+++ /dev/null
@@ -1,112 +0,0 @@
-
-
-
-  4.0.0
-  com.github.spotbugs
-  spotbugs
-  @spotbugs.version@
-  jar
-  https://spotbugs.github.io/
-  SpotBugs
-  Spotbugs: Because it's easy!
-  
-    
-      GNU Lesser Public License
-      https://www.gnu.org/licenses/lgpl.html
-      repo
-    
-  
-  
-    scm:git:https://github.com/spotbugs/spotbugs.git
-    scm:git:ssh://git@github.com/spotbugs/spotbugs.git
-    https://github.com/spotbugs/spotbugs
-    HEAD
-  
-  
-    
-      com.github.spotbugs
-      bcel
-      @spotbugs.version@
-    
-    
-      com.github.spotbugs
-      jsr305
-      @spotbugs.version@
-    
-    
-      com.github.spotbugs
-      jFormatString
-      @spotbugs.version@
-    
-    
-      com.github.spotbugs
-      annotations
-      @spotbugs.version@
-    
-    
-      dom4j
-      dom4j
-      1.6.1
-    
-    
-      jaxen
-      jaxen
-      1.1.1
-    
-    
-      asm
-      asm
-      3.3
-    
-    
-      asm
-      asm-tree
-      3.3
-    
-    
-      asm
-      asm-commons
-      3.3
-    
-    
-      commons-lang
-      commons-lang
-      2.4
-    
-  
-  
-    
-      
-        org.apache.maven.plugins
-        maven-gpg-plugin
-        1.4
-        
-          
-            sign-artifacts
-            install
-            
-              sign
-            
-          
-        
-      
-    
-  
-

From 5d40b06ec58e4cff2e50b1a217fe39cb33b39121 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 19:37:53 -0400
Subject: [PATCH 0992/1013] [cleanup] Remove groovy scripts for fb2* as not
 used in project

these don't explain what they are for but appear to be used to pull code and deploy code via maven which we don't need nor use.  We use maven directly not some overlay in groovy to do maven stuff plus it seemed very 'ant' like too.
---
 src/main/tools/fb2bundle.groovy | 43 -------------------------
 src/main/tools/fb2local.groovy  | 56 --------------------------------
 src/main/tools/fb2repo.groovy   | 57 ---------------------------------
 3 files changed, 156 deletions(-)
 delete mode 100644 src/main/tools/fb2bundle.groovy
 delete mode 100644 src/main/tools/fb2local.groovy
 delete mode 100644 src/main/tools/fb2repo.groovy

diff --git a/src/main/tools/fb2bundle.groovy b/src/main/tools/fb2bundle.groovy
deleted file mode 100644
index 590bde5f0..000000000
--- a/src/main/tools/fb2bundle.groovy
+++ /dev/null
@@ -1,43 +0,0 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-#!/usr/bin/env groovy
-
-def cli = new CliBuilder(usage:'fb2bundle -f spotbugs.home -version version')
-cli.h(longOpt: 'help', 'usage information')
-cli.v(argName: 'version',  longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version')
-
-def opt = cli.parse(args)
-if (!opt) { return }
-if (opt.h) opt.usage()
-def spotbugsVersion = opt.v
-
-println "spotbugsVersion is ${spotbugsVersion}"
-println "Done parsing"
-
-def cmdPrefix = """"""
-
-println "os.name is " + System.getProperty("os.name")
-
-if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """
-
-def modules = ["spotbugs-annotations", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ]
-
-modules.each(){ module ->
-    println "Processing ${module}........"
-    cmd = cmdPrefix + """mvn repository:bundle-pack -B -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion}"""
-    proc = cmd.execute()
-    println proc.text
-}
diff --git a/src/main/tools/fb2local.groovy b/src/main/tools/fb2local.groovy
deleted file mode 100644
index 9c6632cd3..000000000
--- a/src/main/tools/fb2local.groovy
+++ /dev/null
@@ -1,56 +0,0 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-#!groovy
-
-def spotbugsHome = System.getenv("SPOTBUGS_HOME")
-def antBuilder = new AntBuilder()
-
-def cli = new CliBuilder(usage:'fb2local -f spotbugs.home -version version')
-cli.h(longOpt: 'help', 'usage information')
-cli.f(argName: 'home',  longOpt: 'home', required: false, args: 1, type:GString, 'Spotbugs home directory')
-cli.v(argName: 'version',  longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version')
-
-def opt = cli.parse(args)
-if (!opt) { return }
-if (opt.h) opt.usage()
-if (opt.f) spotbugsHome = opt.f
-def spotbugsVersion = opt.v
-
-println "spotbugsHome is ${spotbugsHome}"
-println "spotbugsVersion is ${spotbugsVersion}"
-println "Done parsing"
-
-def cmdPrefix = """"""
-
-println "os.name is " + System.getProperty("os.name")
-
-if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """
-
-def modules = ["spotbugs-annotations", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ]
-
-modules.each(){ module ->
-  antBuilder.copy(file: new File("${module}.pom"), toFile: new File("${module}.xml"), overwrite: true ) {
-    filterset() {
-      filter(token: "spotbugs.version", value: "${spotbugsVersion}")
-    }
-  }
-
-  cmd = cmdPrefix + """mvn install:install-file -DpomFile=${module}.xml -Dfile=${spotbugsHome}/lib/${module}.jar -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion} -Dpackaging=jar"""
-  proc = cmd.execute()
-  println proc.text
-}
-
-antBuilder.delete(file: "pom.xml")
diff --git a/src/main/tools/fb2repo.groovy b/src/main/tools/fb2repo.groovy
deleted file mode 100644
index ddb8149a8..000000000
--- a/src/main/tools/fb2repo.groovy
+++ /dev/null
@@ -1,57 +0,0 @@
-/*
- * Copyright 2005-2023 the original author or authors.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *     https://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-#!/usr/bin/env groovy
-
-def spotbugsHome = System.getenv("SPOTBUGS_HOME")
-def antBuilder = new AntBuilder()
-
-def cli = new CliBuilder(usage:'fb2repo -f spotbugs.home -version version -u repositoryURL')
-cli.h(longOpt: 'help', 'usage information')
-cli.f(argName: 'home',  longOpt: 'home', required: false, args: 1, type:GString, 'Spotbugs home directory')
-cli.v(argName: 'version',  longOpt: 'version', required: true, args: 1, type:GString, 'Spotbugs version')
-cli.u(argName: 'url',  longOpt: 'url', required: true, args: 1, type:GString, 'Repository URL')
-
-def opt = cli.parse(args)
-if (!opt) { return }
-if (opt.h) opt.usage()
-if (opt.f) spotbugsHome = opt.f
-def spotbugsVersion = opt.v
-def repoUrl = opt.u
-
-println "spotbugsHome is ${spotbugsHome}"
-println "spotbugsVersion is ${spotbugsVersion}"
-println "Done parsing"
-
-def cmdPrefix = """"""
-
-println "os.name is " + System.getProperty("os.name")
-
-if (System.getProperty("os.name").toLowerCase().contains("windows")) cmdPrefix = """cmd /c """
-
-def modules = ["annotations", "bcel", "spotbugs", "spotbugs-ant", "jFormatString", "jsr305" ]
-
-modules.each(){ module ->
-    antBuilder.copy(file: new File("${module}.pom"), toFile: new File("${module}.xml"), overwrite: true ) {
-        filterset() {
-            filter(token: "spotbugs.version", value: "${spotbugsVersion}")
-        }
-    }
-
-    cmd = cmdPrefix + """mvn deploy:deploy-file -DpomFile=${module}.xml -Dfile=${spotbugsHome}/lib/${module}.jar -DgroupId=com.github.spotbugs -DartifactId=${module} -Dversion=${spotbugsVersion} -Durl=${repoUrl} -Dpackaging=jar"""
-    proc = cmd.execute()
-    println proc.text
-    antBuilder.delete(file: "pom.xml")
-}

From 5b8c91fc4a3bb1ca0f186f1e2da5fc68b528a002 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 19:38:23 -0400
Subject: [PATCH 0993/1013] [cleanup] Delete cleanup script as not used for
 anything here

likely was to cleanup other items scripts pulled which are not used either.  We simply use maven directly.
---
 src/main/tools/cleanup.sh | 18 ------------------
 1 file changed, 18 deletions(-)
 delete mode 100755 src/main/tools/cleanup.sh

diff --git a/src/main/tools/cleanup.sh b/src/main/tools/cleanup.sh
deleted file mode 100755
index 2acbae184..000000000
--- a/src/main/tools/cleanup.sh
+++ /dev/null
@@ -1,18 +0,0 @@
-#
-# Copyright 2005-2023 the original author or authors.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     https://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-rm *-bundle.jar
-rm *.xml

From 0933b5d8037f5e8a42197009764722f816eb9c8c Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Tue, 22 Aug 2023 07:45:23 +0000
Subject: [PATCH 0994/1013] Update groovy monorepo to v4.0.14

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 436845473..c49cad857 100644
--- a/pom.xml
+++ b/pom.xml
@@ -175,7 +175,7 @@
     2.0.7
 
     1.10.13
-    4.0.13
+    4.0.14
     3.25.4
 
     1.12.0

From 171b0a1f43056d42d78cbc83413036efdb3edf2b Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Sat, 26 Aug 2023 18:58:47 +0000
Subject: [PATCH 0995/1013] Update dependency org.apache.ant:ant to v1.10.14

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index c49cad857..05b66eedf 100644
--- a/pom.xml
+++ b/pom.xml
@@ -174,7 +174,7 @@
     4.7.3
     2.0.7
 
-    1.10.13
+    1.10.14
     4.0.14
     3.25.4
 

From 4876be935c5b36456116067cdfb6e0e3547ed34c Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 31 Aug 2023 10:31:01 +0000
Subject: [PATCH 0996/1013] Update dependency
 com.github.javaparser:javaparser-core to v3.25.5

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 05b66eedf..e296f2682 100644
--- a/pom.xml
+++ b/pom.xml
@@ -176,7 +176,7 @@
 
     1.10.14
     4.0.14
-    3.25.4
+    3.25.5
 
     1.12.0
     1.11.1

From a1b03769b7ce09da0a5435c7ce0656762f865648 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 4 Sep 2023 12:46:27 +0000
Subject: [PATCH 0997/1013] Update actions/checkout action to v4

---
 .github/workflows/ci.yaml              | 2 +-
 .github/workflows/codeql-analysis.yaml | 2 +-
 .github/workflows/coveralls.yaml       | 2 +-
 .github/workflows/coverity.yaml        | 2 +-
 .github/workflows/it-maven-3.3.9.yaml  | 2 +-
 .github/workflows/it-maven-4.0.0.yaml  | 2 +-
 .github/workflows/it.yaml              | 2 +-
 .github/workflows/site.yaml            | 2 +-
 .github/workflows/sonar.yaml           | 2 +-
 .github/workflows/sonatype.yaml        | 2 +-
 10 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 9feb9b1fe..61a5d281d 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -14,7 +14,7 @@ jobs:
     name: Test JDK ${{ matrix.java }}, ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/codeql-analysis.yaml b/.github/workflows/codeql-analysis.yaml
index 9ed3c0f76..05728370b 100644
--- a/.github/workflows/codeql-analysis.yaml
+++ b/.github/workflows/codeql-analysis.yaml
@@ -39,7 +39,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@v3
+      uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml
index 19c129605..df8a1081c 100644
--- a/.github/workflows/coveralls.yaml
+++ b/.github/workflows/coveralls.yaml
@@ -7,7 +7,7 @@ jobs:
     if: github.repository_owner == 'spotbugs-OFF'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml
index f376b9b28..b01d874de 100644
--- a/.github/workflows/coverity.yaml
+++ b/.github/workflows/coverity.yaml
@@ -10,7 +10,7 @@ jobs:
     if: github.repository_owner == 'spotbugs'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/it-maven-3.3.9.yaml b/.github/workflows/it-maven-3.3.9.yaml
index 8753eaf14..d16feba0e 100644
--- a/.github/workflows/it-maven-3.3.9.yaml
+++ b/.github/workflows/it-maven-3.3.9.yaml
@@ -8,7 +8,7 @@ jobs:
     name: Integration Tests Maven 3.3.9
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index aafff6fbc..c98910e68 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -8,7 +8,7 @@ jobs:
     name: Integration Tests Maven 4.0.0-alpha-4
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml
index bf736658e..d6898d136 100644
--- a/.github/workflows/it.yaml
+++ b/.github/workflows/it.yaml
@@ -8,7 +8,7 @@ jobs:
     name: Integration Tests
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml
index eaaf74710..ce7a7cad8 100644
--- a/.github/workflows/site.yaml
+++ b/.github/workflows/site.yaml
@@ -10,7 +10,7 @@ jobs:
     if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml
index 236865ba3..86756a600 100644
--- a/.github/workflows/sonar.yaml
+++ b/.github/workflows/sonar.yaml
@@ -10,7 +10,7 @@ jobs:
     if: github.repository_owner == 'spotbugs'
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
         with:
           # Disabling shallow clone is recommended for improving relevancy of reporting
           fetch-depth: 0
diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml
index f19453c31..bf100111c 100644
--- a/.github/workflows/sonatype.yaml
+++ b/.github/workflows/sonatype.yaml
@@ -10,7 +10,7 @@ jobs:
     if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:

From e8126e9dce93acd69a3fd026091037d79b72d756 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 8 Sep 2023 22:22:55 +0000
Subject: [PATCH 0998/1013] Update slf4jVersion to v2.0.9

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index e296f2682..74930ccc8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -172,7 +172,7 @@
     5.9.3
     4.7.3
     4.7.3
-    2.0.7
+    2.0.9
 
     1.10.14
     4.0.14

From 88497c8cd94922b51a2c7db56148ff3bacd5a493 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 14 Sep 2023 10:04:17 +0000
Subject: [PATCH 0999/1013] Update groovy monorepo to v4.0.15

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 74930ccc8..cd5f47b90 100644
--- a/pom.xml
+++ b/pom.xml
@@ -175,7 +175,7 @@
     2.0.9
 
     1.10.14
-    4.0.14
+    4.0.15
     3.25.5
 
     1.12.0

From 36a56b860d9c4ae37bed53a72fcb7705fea2c138 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 15 Sep 2023 17:15:45 +0000
Subject: [PATCH 1000/1013] Update dependency
 org.apache.maven.plugins:maven-javadoc-plugin to v3.6.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index cd5f47b90..acd76a8f1 100644
--- a/pom.xml
+++ b/pom.xml
@@ -199,7 +199,7 @@
     3.0.0
     3.4.5
     3.6.0
-    3.5.0
+    3.6.0
     3.9.0
     2.0.1
     3.12.1

From a1f222d06eba640ec47bcf85caf3adf2e2df248e Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 20:06:19 -0400
Subject: [PATCH 1001/1013] [GHA] Update maven 4 to alpha 7

---
 .github/workflows/it-maven-4.0.0.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index c98910e68..ee474f213 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -1,11 +1,11 @@
-name: Java Integration Tests Maven 4.0.0-alpha-4
+name: Java Integration Tests Maven 4.0.0-alpha-7
 
 on: [push, pull_request]
 
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Integration Tests Maven 4.0.0-alpha-4
+    name: Integration Tests Maven 4.0.0-alpha-7
 
     steps:
       - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
@@ -14,9 +14,9 @@ jobs:
         with:
           java-version: 17
           distribution: zulu
-      - name: Load Maven 4.0.0-alpha-4
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-4 --no-transfer-progress
+      - name: Load Maven 4.0.0-alpha-7
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-7 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress

From ac1e6377fe57d8eff8c0617c4659f17be2a3d309 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sat, 19 Aug 2023 20:10:21 -0400
Subject: [PATCH 1002/1013] [GHA] Try maven 4 alpha 5

---
 .github/workflows/it-maven-4.0.0.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index ee474f213..245aa7cc2 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -1,11 +1,11 @@
-name: Java Integration Tests Maven 4.0.0-alpha-7
+name: Java Integration Tests Maven 4.0.0-alpha-5
 
 on: [push, pull_request]
 
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Integration Tests Maven 4.0.0-alpha-7
+    name: Integration Tests Maven 4.0.0-alpha-5
 
     steps:
       - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
@@ -14,9 +14,9 @@ jobs:
         with:
           java-version: 17
           distribution: zulu
-      - name: Load Maven 4.0.0-alpha-7
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-7 --no-transfer-progress
+      - name: Load Maven 4.0.0-alpha-5
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-5 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress

From 531f4f582365334a526ec9d975bc704aa516b582 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:27:28 -0400
Subject: [PATCH 1003/1013] Revert "[GHA] Try maven 4 alpha 5"

This reverts commit ac1e6377fe57d8eff8c0617c4659f17be2a3d309.
---
 .github/workflows/it-maven-4.0.0.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index 245aa7cc2..ee474f213 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -1,11 +1,11 @@
-name: Java Integration Tests Maven 4.0.0-alpha-5
+name: Java Integration Tests Maven 4.0.0-alpha-7
 
 on: [push, pull_request]
 
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Integration Tests Maven 4.0.0-alpha-5
+    name: Integration Tests Maven 4.0.0-alpha-7
 
     steps:
       - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
@@ -14,9 +14,9 @@ jobs:
         with:
           java-version: 17
           distribution: zulu
-      - name: Load Maven 4.0.0-alpha-5
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-5 --no-transfer-progress
+      - name: Load Maven 4.0.0-alpha-7
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-7 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-5 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress

From 59d813a4c4fb881223ddf7a09e89708a784ed842 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:27:33 -0400
Subject: [PATCH 1004/1013] Revert "[GHA] Update maven 4 to alpha 7"

This reverts commit a1f222d06eba640ec47bcf85caf3adf2e2df248e.
---
 .github/workflows/it-maven-4.0.0.yaml | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index ee474f213..c98910e68 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -1,11 +1,11 @@
-name: Java Integration Tests Maven 4.0.0-alpha-7
+name: Java Integration Tests Maven 4.0.0-alpha-4
 
 on: [push, pull_request]
 
 jobs:
   test:
     runs-on: ubuntu-latest
-    name: Integration Tests Maven 4.0.0-alpha-7
+    name: Integration Tests Maven 4.0.0-alpha-4
 
     steps:
       - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
@@ -14,9 +14,9 @@ jobs:
         with:
           java-version: 17
           distribution: zulu
-      - name: Load Maven 4.0.0-alpha-7
-        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-7 --no-transfer-progress
+      - name: Load Maven 4.0.0-alpha-4
+        run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-4 --no-transfer-progress
       - name: Build Setup
-        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
+        run: ./mvnw -B -V clean install -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress
       - name: Integration Test with Maven
-        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-7 --no-transfer-progress
+        run: ./mvnw -B -V -DtestSrc=remote -Prun-its clean install -Dinvoker.parallelThreads=4 -Dlicense.skip=true -Dmaven.min-version=4.0.0-alpha-4 --no-transfer-progress

From 45ee31ef04a7695c20bd46b69a986ef4e7f8da08 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 25 Sep 2023 00:28:30 +0000
Subject: [PATCH 1005/1013] Update dependency
 org.codehaus.mojo:versions-maven-plugin to v2.16.1

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index acd76a8f1..3cf9b2c0a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -204,7 +204,7 @@
     2.0.1
     3.12.1
     3.6 
-    2.16.0
+    2.16.1
 
     false
     ${project.build.directory}/it-src-spotbugs

From 40256e2a00df0c346535343fa5a7294e28b90093 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:30:34 -0400
Subject: [PATCH 1006/1013] [GHA] Fix checkout and update jdks

---
 .github/workflows/ci.yaml              | 4 ++--
 .github/workflows/codeql-analysis.yaml | 2 +-
 .github/workflows/coveralls.yaml       | 2 +-
 .github/workflows/coverity.yaml        | 4 ++--
 .github/workflows/it-maven-3.3.9.yaml  | 4 ++--
 .github/workflows/it-maven-4.0.0.yaml  | 4 ++--
 .github/workflows/it.yaml              | 4 ++--
 .github/workflows/site.yaml            | 4 ++--
 .github/workflows/sonar.yaml           | 4 ++--
 .github/workflows/sonatype.yaml        | 4 ++--
 10 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index 61a5d281d..5ceac734b 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -8,13 +8,13 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
-        java: [11, 17, 20, 21-ea]
+        java: [11, 17, 21]
       fail-fast: false
       max-parallel: 4
     name: Test JDK ${{ matrix.java }}, ${{ matrix.os }}
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/codeql-analysis.yaml b/.github/workflows/codeql-analysis.yaml
index 05728370b..ad3c924e6 100644
--- a/.github/workflows/codeql-analysis.yaml
+++ b/.github/workflows/codeql-analysis.yaml
@@ -39,7 +39,7 @@ jobs:
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      uses: actions/checkout@v4
 
     # Initializes the CodeQL tools for scanning.
     - name: Initialize CodeQL
diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml
index df8a1081c..389b363f4 100644
--- a/.github/workflows/coveralls.yaml
+++ b/.github/workflows/coveralls.yaml
@@ -7,7 +7,7 @@ jobs:
     if: github.repository_owner == 'spotbugs-OFF'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
diff --git a/.github/workflows/coverity.yaml b/.github/workflows/coverity.yaml
index b01d874de..9f6c97907 100644
--- a/.github/workflows/coverity.yaml
+++ b/.github/workflows/coverity.yaml
@@ -10,11 +10,11 @@ jobs:
     if: github.repository_owner == 'spotbugs'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: 'zulu'
       - name: Analyze with Coverity
         run: |
diff --git a/.github/workflows/it-maven-3.3.9.yaml b/.github/workflows/it-maven-3.3.9.yaml
index d16feba0e..75953f004 100644
--- a/.github/workflows/it-maven-3.3.9.yaml
+++ b/.github/workflows/it-maven-3.3.9.yaml
@@ -8,11 +8,11 @@ jobs:
     name: Integration Tests Maven 3.3.9
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: zulu
       - name: Load Maven 3.3.9
         run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=3.3.9 --no-transfer-progress
diff --git a/.github/workflows/it-maven-4.0.0.yaml b/.github/workflows/it-maven-4.0.0.yaml
index c98910e68..62aeaf7a6 100644
--- a/.github/workflows/it-maven-4.0.0.yaml
+++ b/.github/workflows/it-maven-4.0.0.yaml
@@ -8,11 +8,11 @@ jobs:
     name: Integration Tests Maven 4.0.0-alpha-4
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: zulu
       - name: Load Maven 4.0.0-alpha-4
         run: ./mvnw -B -V org.apache.maven.plugins:maven-wrapper-plugin:3.2.0:wrapper -Dmaven=4.0.0-alpha-4 --no-transfer-progress
diff --git a/.github/workflows/it.yaml b/.github/workflows/it.yaml
index d6898d136..6de781744 100644
--- a/.github/workflows/it.yaml
+++ b/.github/workflows/it.yaml
@@ -8,11 +8,11 @@ jobs:
     name: Integration Tests
 
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: zulu
       - name: Build Setup
         run: ./mvnw -B -V clean install -Dlicense.skip=true --no-transfer-progress
diff --git a/.github/workflows/site.yaml b/.github/workflows/site.yaml
index ce7a7cad8..edf837c6a 100644
--- a/.github/workflows/site.yaml
+++ b/.github/workflows/site.yaml
@@ -10,11 +10,11 @@ jobs:
     if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: 'zulu'
       - uses: webfactory/ssh-agent@master
         with:
diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml
index 86756a600..633aaa3cd 100644
--- a/.github/workflows/sonar.yaml
+++ b/.github/workflows/sonar.yaml
@@ -10,14 +10,14 @@ jobs:
     if: github.repository_owner == 'spotbugs'
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
         with:
           # Disabling shallow clone is recommended for improving relevancy of reporting
           fetch-depth: 0
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: zulu
       - name: Analyze with SonarCloud
         run: ./mvnw verify sonar:sonar -B -V -Dsonar.projectKey=spotbugs_spotbugs-maven-plugin -Dsonar.organization=spotbugs -Dsonar.host.url=https://sonarcloud.io -Dsonar.login=$SONAR_TOKEN -Dlicense.skip=true --no-transfer-progress
diff --git a/.github/workflows/sonatype.yaml b/.github/workflows/sonatype.yaml
index bf100111c..32917f70e 100644
--- a/.github/workflows/sonatype.yaml
+++ b/.github/workflows/sonatype.yaml
@@ -10,11 +10,11 @@ jobs:
     if: github.repository_owner == 'spotbugs' && ! contains(toJSON(github.event.head_commit.message), '[maven-release-plugin]')
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4
+      - uses: actions/checkout@v4
       - name: Set up JDK
         uses: actions/setup-java@v3
         with:
-          java-version: 17
+          java-version: 21
           distribution: 'zulu'
       - name: Deploy to Sonatype
         run: ./mvnw deploy -DskipTests -B -V --no-transfer-progress --settings ./.mvn/settings.xml -Dlicense.skip=true

From a8bbf0704a9e3326837d6d665a51f45ca834b157 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:50:50 -0400
Subject: [PATCH 1007/1013] [maven-release-plugin] prepare release
 spotbugs-maven-plugin-4.7.3.6

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index 3cf9b2c0a..f0e17134d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.6-SNAPSHOT
+  4.7.3.6
   maven-plugin
 
   spotbugs-maven-plugin
@@ -141,7 +141,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    HEAD
+    spotbugs-maven-plugin-4.7.3.6
   
   
     Github
@@ -164,7 +164,7 @@
     ${project.version}
 
     
-    1687218680
+    1695603014
 
     
     4.7.3

From 307517ad97f6cbeb29546351be58f7f9557b07e4 Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:50:54 -0400
Subject: [PATCH 1008/1013] [maven-release-plugin] prepare for next development
 iteration

---
 pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index f0e17134d..8b5957f24 100644
--- a/pom.xml
+++ b/pom.xml
@@ -28,7 +28,7 @@
 
   com.github.spotbugs
   spotbugs-maven-plugin
-  4.7.3.6
+  4.7.3.7-SNAPSHOT
   maven-plugin
 
   spotbugs-maven-plugin
@@ -141,7 +141,7 @@
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     scm:git:ssh://git@github.com/spotbugs/spotbugs-maven-plugin.git
     https://github.com/spotbugs/spotbugs-maven-plugin
-    spotbugs-maven-plugin-4.7.3.6
+    HEAD
   
   
     Github
@@ -164,7 +164,7 @@
     ${project.version}
 
     
-    1695603014
+    1695603053
 
     
     4.7.3

From bdee4e13ee6c63339526f9476c8c35e56819de4d Mon Sep 17 00:00:00 2001
From: Jeremy Landis 
Date: Sun, 24 Sep 2023 20:58:17 -0400
Subject: [PATCH 1009/1013] [GHA] Move sonar to ubuntu

---
 .github/workflows/sonar.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/sonar.yaml b/.github/workflows/sonar.yaml
index 633aaa3cd..4593c469b 100644
--- a/.github/workflows/sonar.yaml
+++ b/.github/workflows/sonar.yaml
@@ -8,7 +8,7 @@ on:
 jobs:
   build:
     if: github.repository_owner == 'spotbugs'
-    runs-on: windows-latest
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
         with:

From 87f89c6f9a9f9c1f8df38d5e92681b7299f527a1 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Mon, 25 Sep 2023 03:14:56 +0000
Subject: [PATCH 1010/1013] Update dependency com.github.hazendaz:base-parent
 to v41

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 8b5957f24..be3a86536 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,7 +22,7 @@
   
     com.github.hazendaz
     base-parent
-    40
+    41
     
   
 

From 1c0a3515927269eaef8e979de853fddaa0ee1fb7 Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Thu, 28 Sep 2023 21:38:30 +0000
Subject: [PATCH 1011/1013] Update dependency
 org.codehaus.gmavenplus:gmavenplus-plugin to v3.0.2

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index be3a86536..d0b03e08c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -196,7 +196,7 @@
     3.1.0
     1.0.0
     0.22-1
-    3.0.0
+    3.0.2
     3.4.5
     3.6.0
     3.6.0

From ea43474b7c3c955a92c1cdbd45c795a9646d5b6d Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Fri, 29 Sep 2023 22:15:51 +0000
Subject: [PATCH 1012/1013] Update dependency commons-io:commons-io to v2.14.0

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index d0b03e08c..5baa56748 100644
--- a/pom.xml
+++ b/pom.xml
@@ -239,7 +239,7 @@
     2.1
     2.10.1
     32.1.2-jre
-    2.13.0
+    2.14.0
     2.0.0
     2.6
     3.13.0

From bafe33dd3c9a8e5ade60acfa3d562f823bfa434d Mon Sep 17 00:00:00 2001
From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com>
Date: Sat, 30 Sep 2023 20:11:08 +0000
Subject: [PATCH 1013/1013] Update dependency org.ow2.asm:asm-bom to v9.6

---
 pom.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 5baa56748..f319b92a9 100644
--- a/pom.xml
+++ b/pom.xml
@@ -230,7 +230,7 @@
     5.13.2.202306221912-r
 
     
-    9.5
+    9.6
     6.6.1
     1.9.4
     1.2