Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve startup validation of request matchers #16135

Open
jzheaux opened this issue Nov 20, 2024 · 1 comment
Open

Improve startup validation of request matchers #16135

jzheaux opened this issue Nov 20, 2024 · 1 comment
Assignees
@jzheaux
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
6.5.x

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 20, 2024

Given that it's beneficial to use MvcRequestMatcher.Builder#servletPath whenever the MVC servlet path is something other than /, we should consider validating that at startup time.

One possibility is to provide a new implementation of FilterChainValidator.

Related to #13562
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Nov 20, 2024
@jzheaux jzheaux added this to the 6.5.x milestone Nov 20, 2024
@jzheaux jzheaux self-assigned this Nov 20, 2024
@baezzys
Copy link
Contributor

baezzys commented Nov 21, 2024

Hi @jzheaux Could I try this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.x
Development

No branches or pull requests
2 participants
@jzheaux @baezzys