Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode rendering issue with images on CSRF and Method Security pages #16151

Closed
harpreets789 opened this issue Nov 23, 2024 · 1 comment
Closed

Dark mode rendering issue with images on CSRF and Method Security pages #16151

harpreets789 opened this issue Nov 23, 2024 · 1 comment
Assignees
@jzheaux
Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug
Milestone
6.2.9

Comments

@harpreets789
Copy link
Contributor

harpreets789 commented Nov 23, 2024 •
edited
Loading

The transparent PNG files used in the Cross Site Request Forgery (CSRF) and Method Security documentation pages do not render clearly in dark mode. This issue seems to have been partially addressed in response to #14834, but these two pages were missed.
csrf_dark_mode_issue
@harpreets789 harpreets789 added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Nov 23, 2024
harpreets789 added a commit to harpreets789/spring-security that referenced this issue Nov 23, 2024
@harpreets789
Fix spring-projects#16151: Update images on CSRF and Method Security …
5000620 
…pages for dark mode
@harpreets789 harpreets789 mentioned this issue Nov 23, 2024
Closed
@jzheaux jzheaux added in: docs An issue in Documentation or samples and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 25, 2024
@jzheaux jzheaux self-assigned this Nov 25, 2024
@jzheaux jzheaux added this to the 6.2.9 milestone Nov 25, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Nov 25, 2024

Closing in favor of #16152

@jzheaux jzheaux closed this as completed Nov 25, 2024
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Nov 25, 2024
harpreets789 added a commit to harpreets789/spring-security that referenced this issue Nov 25, 2024
@harpreets789
Polish Dark Mode for CSRF and Method Security diagrams
68d9191 
Closes spring-projectsgh-16151
@harpreets789 harpreets789 mentioned this issue Nov 25, 2024
Merged
@sjohnr sjohnr mentioned this issue Nov 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
6.2.9
Development

No branches or pull requests
2 participants
@jzheaux @harpreets789