Count management interface in CLAB_INTFS_WITH_MGMT env var #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
changed the title
|
not a prio right now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now introduce a new env var CLAB_INTFS_WITH_MGMT that counts the management interface in when counting calculating the number of interfaces required by clab.
The reason for this change is to make sure that
network mode: nonesetting when eth0 interface is added manually to the list of endpoints and therefore it shouldn't be implied as an addition to datapath interfacesGoes together with vrnetlab change hellt/vrnetlab#166
** This is a breaking change for vrnetlab nodes**
Because newer vrnetlab (>=0.15.0) nodes will rely on the new CLAB_INTFS_WITH_MGMT env var, we will add an early error when this env var is not found asking users to upgrade containerlab.
Older vrnetlab nodes will continue to function because they would still use the CLAB_INTFS env var and since the calculation logic for CLAB_INTFS hasn't changed it will work as before.
It will not though support the
network mode: none.fix #1851