Proxy support

[fristhon]

Hey thanks for this
it would be great if you can add http or socks support

[staniel359]

@fristhon Hello.
Proxy support is planned.

[xyloflake]

@fristhon @staniel359 Sorry, I don't get why proxy is necessary. Could any of you guys explain about why you might need Proxy? Like why?

[fristhon]

@xyloflake
Maybe not necessary but a good feature to have. it's just about UX and having more control on things.

in some countries like mine some services are blocked, I don't like to tunnel the whole traffic with a VPN to bypass that limitation, I'll prefer to do that per app (like setting a proxy in browser). besides this, in general it is a good practice for applications to have a proxy option in their settings. it can add some privacy as well.

[xyloflake]

@fristhon thanks for the quick reply! I gotchu. We have planned to directly solve it directly on the server instead of the client. This will make user modification minimum and proxies also have a security concern so it would be better to use our server as a proxy.

Xylo,
Admin and dev at muffon

[staniel359]

@xyloflake Some providers' audio CDN links don't work from some countries.

[fristhon]

@xyloflake Server side proxy definitely is a plus but as @staniel359 mentioned, in some countries, certain links may be blocked and there is a possibility that your server could be blocked in future in those countries. so at the end client side proxy needed.

[xyloflake]

I recently removed a security vulnerability related to proxy in #133. I don't suggest enabling proxy on the client side. I'll look into it tho.

[staniel359]

@xyloflake Why is proxy a security issue?

[xyloflake]

@staniel359 I'll explain on call after my exams, if you don't mind.

[staniel359]

@xyloflake Sure.

[fristhon]

Summarize that call and share with us here please 😄

[xyloflake]

@fristhon my exams end in March. Hope you can wait until then 🙂