-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoVerifyServerName
disables sending SNI
#313
Comments
etan-status
added a commit
to status-im/nim-json-rpc
that referenced
this issue
Sep 14, 2022
Setting `NoVerifyHost`, `NoVerifyServerName` by default leads to hard-to-debug bugs, it should always be explicit if wanted. Note: This is also a workaround for status-im/nim-chronos#313
This was referenced Sep 14, 2022
Seems to be a bearssl limitation: The presence of "server_name" is used as a flag of "verify server name", so we can't send the server_name without verifying it |
etan-status
added a commit
to status-im/nim-json-rpc
that referenced
this issue
Sep 16, 2022
Setting `NoVerifyHost`, `NoVerifyServerName` by default leads to hard-to-debug bugs, it should always be explicit if wanted. Note: This is also a workaround for status-im/nim-chronos#313
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When
TLSFlags.NoVerifyServerName
is specified, intlsstream.nim
, BearSSL is configured withsslClientReset(res.ccontext, "", 0)
. While this disables server name verification, it also disables sending SNI, leading to connection failure when connecting to servers that require SNI extension to be present (e.g., Alchemy).SNI extension should still be sent, even when
NoVerifyServerName
is specified.(empty string seems to have same behaviour as NULL)
The text was updated successfully, but these errors were encountered: