Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_getBlockByHash raises on missing block #17

Open
arnetheduck opened this issue Feb 6, 2020 · 0 comments
Open

eth_getBlockByHash raises on missing block #17

arnetheduck opened this issue Feb 6, 2020 · 0 comments

Comments

@arnetheduck
Copy link
Member

Per documentation, https://github.com/ethereum/wiki/wiki/json-rpc#eth_getblockbyhash returns a null object when the block cannot be found - a Option[Block..] would be a more natural mapping instead of a an exception with msg Parameter [result] expected JObject but got JNull - the latter is hard to filter for, and yet constitutes a "normal" non-exceptional response to the request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant