Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot connect to Fantom through websockets because SNI hostname is not set #50

Open
NinZine opened this issue May 18, 2022 · 0 comments

Comments

@NinZine
Copy link

NinZine commented May 18, 2022

await p.connect(uri)

I guess the TLSFlags should be passed in explicitly by the user.

In addition, I'm not sure it is a good idea to have no verification by default in the json_rpc library. I would think that it is more common for safe modes, where possible, are turned off by users when necessary (ie. running tests locally).

https://github.com/status-im/nim-json-rpc/blob/335f292a5816910aebf215e3a88db8a665133e0e/json_rpc/clients/websocketclient.nim#L131

@NinZine NinZine changed the title Cannot connect to Fantom because SNI hostname is not set Cannot connect to Fantom through websockets because SNI hostname is not set May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant