Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when including empty .less file in phantomjs #48

Open
1 of 5 tasks
matthewp opened this issue Mar 11, 2017 · 2 comments
Open
1 of 5 tasks

Exception when including empty .less file in phantomjs #48

matthewp opened this issue Mar 11, 2017 · 2 comments
Labels

Comments

@matthewp
Copy link
Member

@Nithanaroy commented on Fri Mar 10 2017

How often can you reproduce it?

  • Always
  • Sometimes
  • Rarely
  • Unable
  • I didn’t try

Description:
I get an exception when I include an empty .less file in my component.js file and load it in a phantomjs browser. When I add something to that .less file everything works. Here is the dump of my terminal:

> mocha-phantomjs -p /Applications/phantomjs-2.1.1-macosx/bin/phantomjs ./test/index_cli.test.html

{"statusCode":0,"line":2271,"sourceURL":"file:///myproject/node_modules/steal/steal.js","stack":"file:///myproject/node_modules/steal/steal.js:2271:14\ntryCatchReject@file:///myproject/node_modules/steal/steal.js:1183:34\nrunContinuation1@file:///myproject/node_modules/steal/steal.js:1142:18\nwhen@file:///myproject/node_modules/steal/steal.js:963:20\nrun@file:///myproject/node_modules/steal/steal.js:821:17\n_drain@file:///myproject/node_modules/steal/steal.js:97:22\ndrain@file:///myproject/node_modules/steal/steal.js:62:15"} "file:///myproject/node_modules/steal/steal.js:2271:14\ntryCatchReject@file:///myproject/node_modules/steal/steal.js:1183:34\nrunContinuation1@file:///myproject/node_modules/steal/steal.js:1142:18\nwhen@file:///myproject/node_modules/steal/steal.js:963:20\nrun@file:///myproject/node_modules/steal/steal.js:821:17\n_drain@file:///myproject/node_modules/steal/steal.js:97:22\ndrain@file:///myproject/node_modules/steal/steal.js:62:15"

   in error at phantomjs://code/browser-shim.js:120

npm ERR! Test failed.  See above for more details.

Steps to reproduce:

  • If a component file includes a .less file which is empty,
  • open the app main_page.html in phantomjs and above exception is thrown

Expected results:

Transpile successfully and can see the app running

Actual results:

Fails with the exception strack

> mocha-phantomjs -p /Applications/phantomjs-2.1.1-macosx/bin/phantomjs ./test/index_cli.test.html

{"statusCode":0,"line":2271,"sourceURL":"file:///myproject/node_modules/steal/steal.js","stack":"file:///myproject/node_modules/steal/steal.js:2271:14\ntryCatchReject@file:///myproject/node_modules/steal/steal.js:1183:34\nrunContinuation1@file:///myproject/node_modules/steal/steal.js:1142:18\nwhen@file:///myproject/node_modules/steal/steal.js:963:20\nrun@file:///myproject/node_modules/steal/steal.js:821:17\n_drain@file:///myproject/node_modules/steal/steal.js:97:22\ndrain@file:///myproject/node_modules/steal/steal.js:62:15"} "file:///myproject/node_modules/steal/steal.js:2271:14\ntryCatchReject@file:///myproject/node_modules/steal/steal.js:1183:34\nrunContinuation1@file:///myproject/node_modules/steal/steal.js:1142:18\nwhen@file:///myproject/node_modules/steal/steal.js:963:20\nrun@file:///myproject/node_modules/steal/steal.js:821:17\n_drain@file:///myproject/node_modules/steal/steal.js:97:22\ndrain@file:///myproject/node_modules/steal/steal.js:62:15"

   in error at phantomjs://code/browser-shim.js:120

npm ERR! Test failed.  See above for more details.

Environment:

Software Version
Steal version ^1.0.9
Steal-tools version ^1.0.1
node -v 7.2.0
npm -v 3.10.9
Browser phantomjs
Operating system macOS
@seasoup
Copy link

seasoup commented Sep 19, 2017

Where is this bug at, looks like it's been open since march? Though the referenced identical bug is closed... Is this fixed?

@matthewp
Copy link
Member Author

No one has worked on it AFAIK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants