Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pundle-typescript doesn't report type errors #81

Open
appsforartists opened this issue Nov 4, 2016 · 2 comments
Open

pundle-typescript doesn't report type errors #81

appsforartists opened this issue Nov 4, 2016 · 2 comments

Comments

@appsforartists
Copy link

According to microsoft/TypeScript#4864, the simple transpileModule function in the TypeScript compiler only reports syntax errors (which is what babylon gives you anyway). For real errors, we'd need something more sophisticated, likely using language services to watch the filesystem. pundle is already using chokidar for watching.

TBD:

  • Is there a way to replace pundle's watcher with TypeScript's when using pundle-typescript?
  • What's the performance impact on letting both do the watching (pundle for bundling and TypeScript for error reporting)?
  • How much work it would be to write a Language Services-based pundle plugin?
@steelbrain
Copy link
Owner

That's actually a very good idea for the v2 struct. Thank You

@steelbrain
Copy link
Owner

Note to self This has now been fixed in the v2 struct by allowing all components to specify a activate() and dispose(). In theory a pundle-loader-typescript should be able to setup it's watchers on activate(), report any errors it sees on this.report(error) and when all compilation/watching is done, it can just dispose the watcher on disposes()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants