Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make add-translations script not commit all files #1654

Open
aristidesstaffieri opened this issue Nov 13, 2024 · 0 comments
Open

Make add-translations script not commit all files #1654

aristidesstaffieri opened this issue Nov 13, 2024 · 0 comments

Comments

@aristidesstaffieri
Copy link
Contributor

Right now, we run a pre commit hook to add translations for any copy changes in the PR.
The script adds translations and then commits all touched files. This can lead to unexpected side effects if you have other local changes that you did not intend to commit prior to this script running.

We should make this script only add/commit translation related changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants