Meson support #666
Meson support #666
Conversation
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
1 similar comment
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
d88341d
to
e429b4c
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
1 similar comment
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
96edf26
to
60a5bc5
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
60a5bc5
to
43ebaa7
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
43ebaa7
to
887dc3e
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
887dc3e
to
b59e538
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
I added .github/workflows/meson-build.yml to build and test via meson |
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
ae11522
to
40b13a0
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
40b13a0
to
5dfa3ae
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
src/meson.build
Outdated
| lt_current = 6 | ||
| lt_revision = 0 | ||
| lt_age = 1 | ||
| lt_version = '@0@.@1@.@2@'.format(lt_current, lt_age, lt_revision) |
There was a problem hiding this comment.
libtool version actually maps a bit funky to regular versions, the math for it is (C - A).(A).(R).
There was a problem hiding this comment.
Interesting. I changed it to:
lt_current = 6
lt_revision = 0
lt_age = 1
lt_version = '@0@.@1@.@2@'.format(lt_current - lt_age, lt_age, lt_revision)
and I get the following files created:
lrwxrwxrwx 1 jringle domain users 14 Nov 8 23:58 libmodbus.so -> libmodbus.so.6*
-rwxr-xr-x 1 jringle domain users 121176 Nov 8 23:58 libmodbus.so.5.1.0*
lrwxrwxrwx 1 jringle domain users 18 Nov 8 23:58 libmodbus.so.6 -> libmodbus.so.5.1.0*
Is this correct?
There was a problem hiding this comment.
Well, you need one more small tweak I just mentioned below.
src/meson.build
Outdated
| version: lt_version, | ||
| soversion: lt_current, |
There was a problem hiding this comment.
If you drop the soversion definition, Meson will default to using the first component of the version, which is usually what people want (and is compatible with autotools).
There was a problem hiding this comment.
I feel like I'm missing understanding something... What's the point of doing (C - A).(A).(R) if (C) never gets used on its own? Why not just make C=5 and just do (C).(A).(R)?
ringlej
force-pushed
the
meson-support
branch
from
5dfa3ae
to
52b8aaa
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
52b8aaa
to
bcec07c
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
1 similar comment
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
5ee6474
to
d8f505c
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
ringlej
force-pushed
the
meson-support
branch
from
be7174f
to
d8f505c
Compare
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
|
Why is a rebase needed? |
|
This way other users can build the current code without git cherry-picking. |
|
Thanks for rebasing. I tested this PR with both meson 0.61.2 and also meson's git master branch. Everything is working as expected and I saw no meson warnings. As meson support can be provided alongside the autoconf, can we merge it and note that this is a new experimental build system? |
|
@yegorich I think it's a good approach. |
|
@stephane great. Then, let's move this PR forward. |
This adds support to build using meson build
Porting over all of the autotools to meson including unit tests