No longer supressing error, swapped @constant() to defined(). Added @…

…throws docblocks for all exceptions thrown in the component.
strident · Feb 16, 2015 · 39b44c5 · 39b44c5
1 parent f28dc9a
commit 39b44c5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/Router/Route.php b/src/Router/Route.php
@@ -122,6 +122,8 @@ public function getTargets()
      * @param string $method
      *
      * @return mixed
+     *
+     * @throws \RuntimeException
      */
     public function getTargetForMethod($method)
     {
@@ -169,12 +171,14 @@ public function setTargets(array $targets)
      * @param mixed  $target
      *
      * @return Route
+     *
+     * @throws \InvalidArgumentException
      */
     public function target($method, $target)
     {
         $method = strtoupper($method);
 
-        if (!@constant("self::$method")) {
+        if (!defined("self::$method")) {
             throw new \InvalidArgumentException(sprintf(
                 'Invalid request method "%s" specified.',
                 $method

diff --git a/src/Router/RouteMatcher.php b/src/Router/RouteMatcher.php
@@ -57,6 +57,8 @@ public function match($method, $url, $routes)
 
     /**
      * {@inheritDoc}
+     *
+     * @throws RuntimeException
      */
     protected function compileRoute(Route $route)
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -57,6 +57,8 @@ public function match($method, $url, $routes) @@
         /**
          * {@inheritDoc}
+         *
+         * @throws RuntimeException
          */
         protected function compileRoute(Route $route)
         {
@@ Expand Down @@