Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is declared incompatible with strophejs 2.x #5

Open
tari opened this issue Feb 21, 2024 · 2 comments
Open

Plugin is declared incompatible with strophejs 2.x #5

tari opened this issue Feb 21, 2024 · 2 comments

Comments

@tari
Copy link
Contributor

tari commented Feb 21, 2024

strophejs 2.0.0 was just released, which increments the major version but doesn't appear to contain any API changes that would break this plugin. Since this currently declares a peer dependency on strophe.js ^1, dependency resolution does not permit upgrade of strophe.js.

I think the most reasonable solution is to update the peer dependency to be ^1.2.12 || ^2.0.0 to accept new 2.x versions of strophe while continuing to assume that post-2.x versions might break the plugin (requiring updates for any future major versions). Alternately, use >=1.2.12 to be optimistic that no future version of Strophe will break this plugin.

@jcbrand
Copy link
Contributor

jcbrand commented Feb 22, 2024

Hi @tari, can you please make a PR with the proposed change? The plugins are largely unmaintained currently.

@tari
Copy link
Contributor Author

tari commented Feb 28, 2024

The dependency is updated with #6, but it would be nice to get a new version on npm so there's a release including the fixed dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants