Patch: Fix URL path, WG subnet and initsetup route logic #196
Conversation
This is in case the subdir variable is empty, which could render the navigation link href empty.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sorry for the long wait. I will get to testing it with saml. However, it has been long since I could last get I touch with the other mainteiners, not sure I could merge it without a second peer review. On a related note, would you be interested in getting more involved in the project? We sure could use extra hands for pr reviews. |
|
Glad to help! |
Seems we can only do 120 characters max per line...
|
The PR should be ready for review and merge, please kindly take a look. Thanks!
ping @gchamon @jfrede @agonbar |
There was a problem hiding this comment.
Other than that, I wanted to find some way to cleanly set the subdirectory (I am not saying there is, only that I haven't looked into it).
I don't feel that much comfortable with the amount of repetition we need to employ to prepend subdir to all the routes. Any maintenance or added feature has to keep this in mind in order to support the feature.
Maybe the router module that is used could provide a cleaner way to set this kind of path subdir, but I would have to look into it.
|
The repetition is an intended implementation to work around the (at least to me) unmaintained http router package. The julienschmidt/httprouter#89 was raised in 2015, updated on 2017 and until now none of the maintainers of that package gives a look... PS: These are just all wild guess in my head...Looking on their profile, I doubt they can contribute in FOSS domain as usually employment contracts prohibits such contributions or Intellectual Properties that doesn't owned by the company. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Gently push a bit. |
|
Hey there, sorry I didn't answer. I can't get in contact with other maintainers to discuss this pull request. Since there is interest in this pr from other users, if other maintainers approve I have no objections to this pr |
|
Can we fork away this repository from the closed loop? Unless the constraint of requiring approval from two contributors with write access, this repository cannot live... |
|
The best thing would be to have more volunteers reviewing pull requests, but a fork is always possible. I thought of creating a "nightly" branch here with more permissive constraints and replicating pull requests there and creating a separate taggins system for docker. Another problem is that I am still without access to the dockerhub repo to fix and maybe extend the current tagging system. |
|
We use a fork where I work. There I tested the saml dep upgrade and other interesting improvements before they went mainstream. It needs to be synced with this repo, but we could use that in the meantime while we hopefully find other volunteers to maintain this repo |
cc: @subspacecommunity/subspace-maintainers
resolves: #195, also resolves #158
Background
Changes
Testing
The changes have been baked into a Docker image locally, it is up and running healthily with a WireGuard server installed on the host. All pages and functions are tested, except SAML and IDP related features/pages/functionalities.