Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace hard-coded SinkError from BatchSink (and Sink) traits' methods with an associated type #29

Open
imor opened this issue Sep 19, 2024 · 1 comment
Open

Replace hard-coded SinkError from BatchSink (and Sink) traits' methods with an associated type #29

imor opened this issue Sep 19, 2024 · 1 comment

Comments

@imor
Copy link
Contributor

imor commented Sep 19, 2024

The hardcoded SinkError makes it almost impossible to implement new sink implementations outside the pg_replicate crate. The associated type should make that possible.
@imor imor mentioned this issue Sep 19, 2024
Open
@passcod
Copy link
Contributor

passcod commented Nov 29, 2024

I've got an implementation of this in a branch, working to bring it up to date and ready for upstreaming.

@passcod passcod mentioned this issue Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@passcod @imor and others