Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic builds for apple silicon fix #4165

Open
wants to merge 3 commits into
base: master_dev
Choose a base branch
from

Conversation

glsorre
Copy link

@glsorre glsorre commented Feb 28, 2024

This small patch solves the problem with iconv not recognised during boost::locale build on apple silicon.

Furthermore it fixes the build on macOS Sonoma with latest Xcode.

@glsorre glsorre requested a review from supermerill as a code owner February 28, 2024 17:21
@supermerill
Copy link
Owner

merged.

@glsorre
Copy link
Author

glsorre commented Feb 28, 2024

@supermerill great! your project is super.

@glsorre
Copy link
Author

glsorre commented Feb 29, 2024

@supermerill let me give a look,
also you are not in GitHub Actions?

it seems I cannot see logs, I have no rights

@supermerill
Copy link
Owner

I have, there is the action menu on top.
I can see your builds & logs.
I don't know why you can't for mine.

@glsorre glsorre force-pushed the pr1 branch 3 times, most recently from 4768d04 to 97c0256 Compare February 29, 2024 11:22
@glsorre
Copy link
Author

glsorre commented Feb 29, 2024

I can replicate, let me investigate. It's strange as on my local machine I can build apple silicon correctly. https://drive.google.com/file/d/13fBXLvJVzxQodDBJMR6MtyiczQGQSYzn/view?usp=sharing

Leave it with me. I will solve.

@glsorre
Copy link
Author

glsorre commented Feb 29, 2024

Bingo! https://github.com/glsorre/SuperSlicer/actions/runs/8095431632/job/22122105390

The problem is libTIFF shasum check. Look at deps/TIFF/TIFF.cmake

Sorry but i forgot to put this change in the PR.

@glsorre
Copy link
Author

glsorre commented Feb 29, 2024

It does not build with the -b flag though. I will try to understand why.

@glsorre
Copy link
Author

glsorre commented Mar 1, 2024

Bingo2! https://github.com/glsorre/SuperSlicer/actions/runs/8112691883

This solves the nlopt problem on the debug builds.

I am not a super expert of cmake so please evaluate if the change can have an impact on other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants