Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add an option for --profile flag #21

Open
iamunnip opened this issue Jul 5, 2023 · 4 comments
Open

[Feature] add an option for --profile flag #21

iamunnip opened this issue Jul 5, 2023 · 4 comments

Comments

@iamunnip
Copy link

iamunnip commented Jul 5, 2023

Considering the issue #18, ecrctl needs AWS CLI needs to be configured for executing the login command.
So it's better add a --profile option for handling multiple profiles configured in AWS CLI.

Example command

> ecrctl login --profile <profile-name>
@surajnarwade
Copy link
Member

Thanks for the raising the issue. as I mentioned in the other issue. ecrctl needs your AWS credentials but it does not need AWS CLI.

@iamunnip
Copy link
Author

iamunnip commented Jul 5, 2023

Okay thank you.

@surajnarwade
Copy link
Member

@iamunnip I have added support for --profile flag, would you be able to test it from the main branch?

@iamunnip
Copy link
Author

iamunnip commented Jul 5, 2023

@surajnarwade Okay, I will test it from main branch, if you provide the right commands.
I don't have any programming experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants