Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

JS Bug with PHP 7.3? #51

Open
criwe opened this issue Nov 5, 2020 · 2 comments
Open

JS Bug with PHP 7.3? #51

criwe opened this issue Nov 5, 2020 · 2 comments

Comments

@criwe
Copy link

criwe commented Nov 5, 2020

Hi!
I´ve switched from PHP 7.2 to 7.3 in an TYPO3 9.6 with Flexslider 1.5.14. That leads die JS-Errors because of different inline js:

PHP 7.3:

jQuery(document).ready(function(){jQuery('#flexslider-59').flexslider({animation:"fade",animationLoop:!0,itemMargin:"0",easing:"swing",direction:"horizontal",reverse:!1,smoothHeight:!1,startAt:"0",slideshow:!0,slideshowSpeed:"6000",animationSpeed:"2000",initDelay:"0",randomize:!1,pauseOnAction:!0,pauseOnHover:!0,useCSS:!0,touch:!0,video:!1,controlNav:!1,directionNav:!0,prevText:"Zurück",nextText:"Weiter",keyboard:!0,multipleKeyboard:!1,mousewheel:!1,pausePlay:!1,pauseText:"Pause",playText:"Abspielen",controlsContainer:"{settings.controlsContainer}",manualControls:"{settings.manualControls}",sync:"{settings.sync}",asNavFor:"{settings.asNavFor}",itemWidth:"{settings.itemWidth}",itemMargin:"{settings.itemMargin}",minItems:"{settings.minItems}",maxItems:"{settings.maxItems}",move:"{settings.move}",carousel:{settings.carousel},start:function(slider){jQuery('body').removeClass('loading')}})});

Problem width PHP 7.3 here -> "{settings.controlsContainer}" instead of ""

PHP 7.2:

jQuery(document).ready(function(){jQuery('#flexslider-59').flexslider({animation:"fade",animationLoop:!0,itemMargin:"0",easing:"swing",direction:"horizontal",reverse:!1,smoothHeight:!1,startAt:"0",slideshow:!0,slideshowSpeed:"6000",animationSpeed:"2000",initDelay:"0",randomize:!1,pauseOnAction:!0,pauseOnHover:!0,useCSS:!0,touch:!0,video:!1,controlNav:!1,directionNav:!0,prevText:"Zurück",nextText:"Weiter",keyboard:!0,multipleKeyboard:!1,mousewheel:!1,pausePlay:!1,pauseText:"Pause",playText:"Abspielen",controlsContainer:"",manualControls:"",sync:"",asNavFor:"",itemWidth:"0",itemMargin:"0",minItems:"0",maxItems:"0",move:"0",carousel:!1,start:function(slider){jQuery('body').removeClass('loading')}})});

It´s an old, big installation, so could also have other causes (maybe configuration issue?!).
But switching back to PHP 7.2. fixed the mentioned problem.

Maybe someone can confirm that issue?

Best
Christoph

@slowhand11
Copy link

Same issue here

@kegoe
Copy link

kegoe commented Jan 27, 2021

Same here - did someone find a solution other than downgrading back to PHP 7.2?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants