fixes #1252 python asyncio: await refresh_api_key_hook, replace usage of urllib3, remove urllib3 #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-geist
force-pushed
the
codegen-generators-issue-1252
branch
from
47d9b05
to
975e046
Compare
…place usage of urllib3, remove urllib3
e-geist
force-pushed
the
codegen-generators-issue-1252
branch
from
975e046
to
9372727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the mentioned #1252 .
I would look into fixing the same issues for tornado, as soon as I was able to gather some experience with it.
Also not sure whether I need to recreate the petstore sample in the codegen repo?
Looking forward to suggestions for improvements.