Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test: correct answer should pass associated answer tests #50

Closed
WilCrofter opened this issue Jan 18, 2014 · 9 comments
Closed

unit test: correct answer should pass associated answer tests #50

WilCrofter opened this issue Jan 18, 2014 · 9 comments

Comments

@WilCrofter
Copy link
Contributor

Gina's idea, though I'm posting it.

If skip() is invoked, swirl acts for the user using a module's CorrectAnswer column. The correct answer is then subjected to tests, just as the user's answer would have been. If the correct answer fails to pass its own tests, e.g., because of a typo, the question will be impossible to skip.

Unit tests could insure that a module's correct answers pass their associated tests.

@ncarchedi
Copy link
Member

That's a great idea. I'm starting to think we should use a two-pronged
approach to testing. We should unit test our functions for "internal use"
(i.e. "behind-the-scenes" functionality), but also test swirl as a "system"
against potential input from a user. Actual implementation will require
some thought, but hopefully that makes sense conceptually.

On Sat, Jan 18, 2014 at 6:52 PM, William R Bauer
[email protected]:

Gina's idea, though I'm posting it.

If skip() is invoked, swirl acts for the user using a module's
CorrectAnswer column. The correct answer is then subjected to tests, just
as the user's answer would have been. If the correct answer fails to pass
its own tests, e.g., because of a typo, the question will be impossible to
skip.

Unit tests could insure that a module's correct answers pass their
associated tests.


Reply to this email directly or view it on GitHubhttps://github.com//issues/50
.

Nicholas A. Carchedi
ScM Student, Biostatistics
Johns Hopkins Bloomberg School of Public Health
NickCarchedi.com | 301.802.0573

@ChihChengLiang
Copy link

Thinking the same. I'm developing a package to test a course, so automatic testing and CI would be possible for instructors. Here's my repo: https://github.com/ChihChengLiang/swirlitest, forks are welcomed!

The package can run through all the cmd_questions, unit testing is not yet achieved at the moment. However, it can still help to teaching assistants to scan bugs of a course quickly on different OS environments.

I'm working on testing the official courses, the package may be proved useful when it can test all official courses

@ncarchedi
Copy link
Member

Very cool!! @seankross, you should take a look. Could be
possibly incorporated into swirlify/swirlools once it matures.

On Thursday, August 27, 2015, Chih Cheng Liang [email protected]
wrote:

Thinking the same. I'm developing a package to test a course, so automatic
testing and CI would be possible for instructors. Here's my repo:
https://github.com/ChihChengLiang/swirlitest, forks are welcomed!

The package can run through all the cmd_questions, unit testing is not yet
achieved at the moment. However, it can still help to teaching assistants
to scan bugs of a course quickly on different OS environments.

I'm working on testing the official courses, the package may be proved
useful when it can test all official courses


Reply to this email directly or view it on GitHub
#50 (comment).

@seankross
Copy link
Member

@ChihChengLiang this is great! Please keep us up to date with your developments on this project. I'd be very interested in folding this into swirlify.

@ChihChengLiang
Copy link

Thank @ncarchedi and @seankross ! Looks like I'm on the right track. Will keep you updated, and also please let me know what's the most wanted feature if any.

@seankross
Copy link
Member

@ChihChengLiang is this code/ these features incorporated into swirldev/swirlify#15?

@ChihChengLiang
Copy link

Exactly! all codes and features are included in swirldev/swirlify#15

@seankross
Copy link
Member

In that case can I close this issue?

@ChihChengLiang
Copy link

Sure, feel free to do it. Sorry for not referring the PR to this issue before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants