-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoComplete] "preferred_choices" are ignored #2257
Labels
Comments
Thanks for the documentation link. I adapted the code to be using the extra_options, but the preferred choices are still ignored : <?php
namespace App\Form;
use App\Repository\BookmarkRepository;
use Override;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\UX\Autocomplete\Form\AsEntityAutocompleteField;
#[AsEntityAutocompleteField]
class AutocompleteTestType extends AbstractType
{
public function __construct(
private readonly BookmarkRepository $bookmarkRepository,
) {
}
#[Override]
public function buildForm(
FormBuilderInterface $builder,
array $options,
): void {
$builder
->setMethod('GET')
->add(
'test',
AutocompleteTestField::class,
[
'extra_options' => [
'preferred_choices' => $this->getPreferredChoices(),
],
],
)
->add(
'submit',
SubmitType::class,
)
;
}
/**
* @return string[]
*/
private function getPreferredChoices(): iterable
{
$individuals = [];
foreach ($this->bookmarkRepository->findAll() as $bookmark) {
$individuals[] = $bookmark->getIndividual()->getId();
}
return $individuals;
}
} <?php
namespace App\Form;
use App\Entity\Individual;
use App\Repository\IndividualRepository;
use Override;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\UX\Autocomplete\Form\AsEntityAutocompleteField;
use Symfony\UX\Autocomplete\Form\BaseEntityAutocompleteType;
#[AsEntityAutocompleteField]
class AutocompleteTestField extends AbstractType
{
public function __construct(
private readonly IndividualRepository $individualRepository,
) {
}
#[Override]
public function configureOptions(OptionsResolver $resolver): void
{
$resolver->setDefaults(
[
'autocomplete' => true,
'choice_label' => static fn(Individual $individual) => "{$individual->getLastName()}, {$individual->getFirstName()}",
'choice_value' => 'id',
'class' => Individual::class,
'preferred_choices' => $this->getPreferredChoices(...),
]
);
}
/**
* @return Individual[]
*/
private function getPreferredChoices(Options $options): iterable
{
$ids = $options['extra_options']['preferred_choices'] ?? [];
if (empty($ids)) {
return [];
}
return $this->individualRepository->findBy(
[
'id' => $ids,
]
);
}
#[Override]
public function getParent(): string
{
return BaseEntityAutocompleteType::class;
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I recently switched from regular "EntityType" form fields to "BaseEntityAutocompleteType", and most features work as expected, except for preferred choices, which appear to be totally ignored.
Given this form + this field :
Expected behavior
Having the preferred choices showing before the autocomplete-fetched choices, like for non-autocomplete fields (EntityType, ChoiceType, etc).
...Or having the documentation reflect the absence of support for this feature.
Actual behavior
Starting with an empty selection, when I click on the form drop-down, the list is empty, the spinner shows, then the list of all choices is displayed, instead of showing preferred choices first, then the other choices.
The text was updated successfully, but these errors were encountered: