Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick oprom commits for bonw14 #44

Open
wants to merge 2 commits into
base: system76
Choose a base branch
from
Open

Conversation

crawfxrd
Copy link
Member

@crawfxrd crawfxrd commented Dec 28, 2023

Cherry-pick 28d4682 and d46c776 from system76-stable202002 to potentially fix system76/firmware-open#442.

These don't appear to change behavior on oryp8 (issues with external displays at boot), but maybe affect bonw14?

The Option ROM scanner can't work as enumeration was done by the
first stage bootloader. Running it will disable the ability of the
PCIPlatform code to scan for ROMs.

Required for the following patch that enables custom Option ROM
scanning using gPciPlatformProtocol.

Signed-off-by: Patrick Rudolph <[email protected]>
This will make sure the ConsoleInit is able to connect the driver installed
by the VGA Option ROMs.

Signed-off-by: Patrick Rudolph <[email protected]>
@crawfxrd crawfxrd changed the title Cherry-pick oprom commits Cherry-pick oprom commits for bonw14 Dec 28, 2023
@crawfxrd crawfxrd requested a review from leviport December 28, 2023 21:44
@crawfxrd crawfxrd marked this pull request as ready for review December 28, 2023 21:58
@leviport
Copy link
Member

I did a USB image build from firmware-open with this branch checked out in the edk2 submodule, but flashing it made early graphics break again. No firmware-setup menu, splash screen, or Plymouth decrypt prompt.

@leviport
Copy link
Member

This probably isn't related to edk2 specifically, but flashing current master of firmware-open also seems to break the touchpad on bonw14. I flashed back to the current release today to make sure, and the touchpad started working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bonw14: Graphics don't work pre-OS
3 participants