common: don't blanket-ignore sd-executor coredumps #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit this only to TEST-02-UNITTESTS where it's expected, as it otherwise might (and did) hide real issues.
There's quite a number of intentional crashes in unit tests and filtering them out is PITA, especially when it comes to crashes that happen during "double-fork" (test-execute), since their executable is then set to systemd-executor, which we don't want to "blanket-ignore". Instead, let's check for any coredumps before running unit tests, so we get the boot sequence covered, and then instruct the coredump-collecting machinery to look for coredumps that happened only after the unit tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
It's not used anywhere and just confuses shellcheck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit this only to TEST-02-UNITTESTS where it's expected, as it otherwise might (and did) hide real issues.