feat(toolbox): use AWS_PROFILE/AWS_REGION if set when calling awsi.sh
#5041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change conditionally propagates the following local environment variables into the `systeminit/toolbox` container: - `AWS_PROFILE` - `AWS_REGION` If either of these variables are not present they do not get added to the `docker run` command. In order to confirm the behavior change, several other updates are included: - Add `set -eu` resulting in the shell script aborting if an expected environment variable is not set. To preserve the error message when you aren't authenticated, the existing `AWS_*` credential variables are still passed in as empty if not set. - Add a `DEBUG` and `TRACE` mode to the script which add `set -v` and `set- xv` respectively when running the shell script. This helps to understand the final `docker run` command that is about to be executed (among other branching logic). Signed-off-by: Fletcher Nichol <[email protected]>
johnrwatson
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change conditionally propagates the following local environment variables into the
systeminit/toolboxcontainer:AWS_PROFILEAWS_REGIONIf either of these variables are not present they do not get added to the
docker runcommand.In order to confirm the behavior change, several other updates are included:
set -euresulting in the shell script aborting if an expected environment variable is not set. To preserve the error message when you aren't authenticated, the existingAWS_*credential variables are still passed in as empty if not set.DEBUGandTRACEmode to the script which addset -vandset- xvrespectively when running the shell script. This helps to understand the finaldocker runcommand that is about to be executed (among other branching logic).