Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The MaxMix device should wake up when editing rgb colors on the app #215

Open
1 task done
maelremrem opened this issue Sep 26, 2020 · 2 comments
Open
1 task done
Assignees
Labels
bug Something isn't working firmware Related to the device firmware P3 low Low Priority

Comments

@maelremrem
Copy link

Guidelines

Is your feature request related to a problem? Please describe.
Is the device is in sleep you can see the colors when you edit them in the app.

Describe the solution you'd like
When the app is open the device or at least the leds should be on to see the new colors.

Describe alternatives you've considered
Wake up the device but turning the encoder

@maelremrem maelremrem added the feature New feature or request label Sep 26, 2020
@SchemingWeasels SchemingWeasels added bug Something isn't working firmware Related to the device firmware and removed feature New feature or request labels Sep 26, 2020
@SchemingWeasels SchemingWeasels self-assigned this Sep 26, 2020
@SchemingWeasels
Copy link
Collaborator

SchemingWeasels commented Sep 26, 2020

RGB is not part of the settings message. I think we should include it in. But either way, it will have to wait for comms rework.

Edit: RGB is in settings. ProcessPackage returning true does not update activity time. Was dropped somewhere.

@t3knomanzer t3knomanzer added the P3 low Low Priority label Oct 25, 2020
@XScorpion2
Copy link
Collaborator

XScorpion2 commented Nov 1, 2020

In MaxMix.ino, change this:

    g_DisplayDirty = (command >= Command::SETTINGS || command <= Command::VOLUME_ALT_CHANGE);
    if (command == Command::CURRENT_SESSION || command == Command::ALTERNATE_SESSION ||
        command == Command::VOLUME_CURR_CHANGE || command == Command::VOLUME_ALT_CHANGE)
    {
        g_LastActivity = g_Now;
        g_DisplayDirty = true;
    }

To this:

    if (command >= Command::SETTINGS || command <= Command::VOLUME_NEXT_CHANGE)
    {
        g_LastActivity = g_Now;
        g_DisplayDirty = true;
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working firmware Related to the device firmware P3 low Low Priority
Projects
None yet
Development

No branches or pull requests

4 participants