Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker container has Tailscale version “1.72.1-ERR-BuildInfo” #140

Closed
avidrissman opened this issue Sep 2, 2024 · 3 comments · Fixed by #141
Closed

Docker container has Tailscale version “1.72.1-ERR-BuildInfo” #140

avidrissman opened this issue Sep 2, 2024 · 3 comments · Fixed by #141

Comments

@avidrissman
Copy link

I use the docker container ghcr.io/tailscale/golink:main and I just updated to the latest version. When I go to my Tailscale Admin page, I see that the Tailscale version is listed as “1.72.1-ERR-BuildInfo”.

That doesn’t strike me as a useful version number and it seems like something is broken in the release pipeline; can you fix it?
@willnorris
Copy link
Member

hmm, this does seem to be a newer behavior. I see it as well in my homelab with the latest container image. Previously, we had version numbers similar to 1.62.1-dev20240412.

Relevant code for these strings is https://github.com/tailscale/tailscale/blob/aeb15dea3032c0560793190731dd6a06b45850b2/version/version.go#L86-L102

@awly have you seen this with other tsnet apps? I doubt it would have had anything to do with #137, since we didn't actually change how we build the golink binary itself.

@patrickod
Copy link
Contributor

I don't think this behavior is golink specific, or at least I have observed the same -ERR-BuildInfo suffixes in personal software that uses tailscale.com/tsnet

awly added a commit that referenced this issue Sep 4, 2024
@awly
Dockerfile: install git to populate node version string
d7bc808 
Without the git CLI, `go build` will not produce the embedded VCS
metadata that's used to report the commit hash in node version string.
This fixes the `1.72.1-ERR-BuildInfo` version string reported to
Tailscale.

Fixes #140
@awly awly mentioned this issue Sep 4, 2024
Merged
@awly
Copy link
Contributor

awly commented Sep 4, 2024

In this case, we were missing git in the build container, which is necessary to populate the version info.

awly added a commit that referenced this issue Sep 4, 2024
@awly
Dockerfile: install git to populate node version string
2f607af 
Without the git CLI, `go build` will not produce the embedded VCS
metadata that's used to report the commit hash in node version string.
This fixes the `1.72.1-ERR-BuildInfo` version string reported to
Tailscale.

Fixes #140

Signed-off-by: Andrew Lytvynov <[email protected]>
@awly awly closed this as completed in #141 Sep 4, 2024
@awly awly closed this as completed in 854eae0 Sep 4, 2024
@stepbrobd stepbrobd mentioned this issue Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dockerfile: install git to populate node version string tailscale/golink
4 participants
@willnorris @patrickod @awly @avidrissman