Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor System.Drawing out of the project #223

Open
Webreaper opened this issue Dec 13, 2022 · 6 comments
Open

Refactor System.Drawing out of the project #223

Webreaper opened this issue Dec 13, 2022 · 6 comments
Assignees
@takuya-takeuchi
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Webreaper
Copy link

As of .Net 7 System.Drawing isn't supported by MSFT on Linux any more. Would be good to remove all references to System.Drawing and replace with something like ImageSharp.
@takuya-takeuchi takuya-takeuchi self-assigned this Dec 13, 2022
@takuya-takeuchi takuya-takeuchi added enhancement New feature or request good first issue Good for newcomers labels Dec 13, 2022
@takuya-takeuchi
Copy link
Owner

@Webreaper
Good idea but ImageSharp just changed license.
I would like to replace with SkiaSharp.
What do you think?

BTW, I have no time to work on OSS working now.
Sorry.

@Webreaper
Copy link
Author

ImageSharp's licence will be fine for most people - it's free for anyone whose organisation is pulling less than $1mm revenue.
But yes, Skiasharp would also be fine for this. Both are pretty equivalent for the basic task of pulling out bitmap bits to process for face detection etc.

@takuya-takeuchi
Copy link
Owner

takuya-takeuchi commented Dec 24, 2022 •
edited
Loading

This issue is related to takuya-takeuchi/DlibDotNet#294

@takuya-takeuchi
Copy link
Owner

ToBitmap method will use DlibDotNet.Extensions.Drawing.
Create FaceRecognitionDotNet.Extensions.Drawing and provide ToBitmap by using DlibDotNet.Extensions.Drawing.

@j4587698
Copy link

Has there been any progress on this issue?

@arnab77in
Copy link

Has the development done on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@takuya-takeuchi takuya-takeuchi

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Webreaper @takuya-takeuchi @j4587698 @arnab77in