feat: support lists in 'resolve_keyed_by' #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahal
force-pushed
the
push-zptlxmssuqnn
branch
from
0d74526 to
5daf787
Compare
ahal
force-pushed
the
push-zptlxmssuqnn
branch
from
5daf787 to
8c4f563
Compare
jcristau
requested changes
Nov 26, 2024
hneiva
reviewed
Nov 27, 2024
|
|
||
| def iter_dot_path( | ||
| container: Dict[str, Any], subfield: str | ||
| ) -> Generator[Tuple[dict[str, Any], str], None, None]: |
There was a problem hiding this comment.
Python < 3.9 can't handle type annotation using built-in types 😢 Just need to replace dict with Dict (I think it can handle str tho). Very annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this in Gecko and it resulted in an identical full graph