-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve the Reference -> Command Line section #609
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 125 125
Lines 10003 10003
Branches 1933 1933
=======================================
Hits 7337 7337
Misses 2342 2342
Partials 324 324 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change made me realize that there's probably no good reason for us to expose both the "set" and "graph" versions of each phase as top-level commands. IMO it only adds confusion.
defaults={"graph_attr": "full_task_set"}, | ||
) | ||
@command( | ||
"full", help="Show the full taskgraph.", defaults={"graph_attr": "full_task_graph"} | ||
"full", | ||
help="Show the full taskgraph. The full taskgraph consists of the full task set, with edges (dependencies) between tasks.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: s/taskgraph/task graph
While we're making things less confusing, let's make it clear that we're not talking about the package here. Note this comment applies to all the commands.
Filed #612 for my thought. |
Found myself browsing the codebase after reading reference/cli.html. Thought it'd be good to add more information about what the taskgraph sub-commands represent on this page.