You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This check results in errors when hosts manage the plugins using WP-CLI in conjunction with the --skip-plugins argument. Therefore, the plugin cannot be activated using wp-cli in isolation mode.
Description
Currently, there is an
exit()
function when certain requirements are not met in the activation process. See https://github.com/taxjar/taxjar-woocommerce-plugin/blob/master/taxjar-woocommerce.php#L161-L168This check results in errors when hosts manage the plugins using WP-CLI in conjunction with the
--skip-plugins
argument. Therefore, the plugin cannot be activated using wp-cli in isolation mode.e.g.,
Expected solution
Consider bailing early with
return
calls instead ofexit
ing. This part also seems relative: https://github.com/taxjar/taxjar-woocommerce-plugin/blob/master/taxjar-woocommerce.php#L27-L36 but i guess theregister_activation_hook()
runs independently. If so, TaxJar might need a small refactor to play well with the best practices.The text was updated successfully, but these errors were encountered: