Meta: integrate esmeta type checker into CI

[michaelficarra]

Currently has 72 false positives. Waiting on:

• esmeta support for accepting an exclusions file to ignore remaining false positives
• Editorial: move adder callability check out of AddEntriesFromIterable #2923
• Editorial: Fixed return types of algorithms returning ~empty~ #2924
• Editorial: Fix return type of ChainEvaluation algorithm #2925
• possibly wait for more esmeta typechecker bugfixes to reduce the number of ignored false positives

[ljharb]

This can't be made to run locally with npm install && npm run something?

[ljharb]

i think this can be done with the checkout action?

[michaelficarra]

Is that better though? This says exactly what's going on.

[bakkot]

For exclusions support, is there an error if something excluded does not have an error? We'll never remember to remove stuff from it otherwise.

[michaelficarra]

@bakkot No, it doesn't look like it: es-meta/esmeta@271fcae. I'll ask them to change it to xfail semantics.

[jhnaldo]

Hi, @bakkot. Do you mean that you want ESMeta to throw an error when excluded algorithms do not have any type mismatches?

[bakkot]

@jhnaldo Yes, that's what I mean.

Specifically, ideally, if there's any line in the "excluded" file such that the build would succeed without that line being present, then the build should fail. In other words, rather than actually excluding anything, it should run the full build and then assert that the set of algorithms with errors is exactly the set of algorithms listed in the exclusions file, rather than being a subset of that list.

[jhnaldo]

@bakkot Thank you for the kind explanation! I supported the feature you mentioned to detect unused names listed in the "excluded" file in the ESMeta v0.1.0-rc5 version. And, I attached the tight esmeta-ignore.json file as follows:

[
  "AddEntriesFromIterable",
  "AsyncGeneratorBody[0,0].EvaluateAsyncGeneratorBody",
  "BoundFunctionCreate",
  "Catch[1,0].CatchClauseEvaluation",
  "ClassElement[0,0].ClassElementEvaluation",
  "ClassElement[1,0].ClassElementEvaluation",
  "ClassStaticBlockBody[0,0].EvaluateClassStaticBlockBody",
  "CreateArrayIterator",
  "CreateBuiltinFunction",
  "CreateDynamicFunction",
  "CreateMappedArgumentsObject",
  "DeclarativeEnvironmentRecord.InitializeBinding",
  "DeclarativeEnvironmentRecord.SetMutableBinding",
  "FlattenIntoArray",
  "FunctionBody[0,0].EvaluateFunctionBody",
  "GeneratorBody[0,0].EvaluateGeneratorBody",
  "GeneratorResumeAbrupt",
  "GeneratorValidate",
  "GetGlobalObject",
  "GetMethod",
  "GetNewTarget",
  "GetPromiseResolve",
  "GetPrototypeFromConstructor",
  "GetThisValue",
  "INTRINSICS.DefaultTimeZone",
  "InnerModuleEvaluation",
  "IntegerIndexedObjectCreate",
  "LabelledItem[1,0].LabelledEvaluation",
  "LengthOfArrayLike",
  "MethodDefinition[0,0].DefineMethod",
  "ModuleNamespaceCreate",
  "NewPromiseReactionJob",
  "NormalCompletion",
  "OrdinaryGet",
  "PrivateGet",
  "ProxyCreate",
  "RegExpInitialize",
  "SerializeJSONObject",
  "SerializeJSONProperty",
  "SetDefaultGlobalBindings",
  "SetViewValue",
  "SortIndexedProperties",
  "SourceTextModuleRecord.ResolveExport",
  "SpeciesConstructor",
  "Statement[0,0].LabelledEvaluation",
  "Statement[1,0].LabelledEvaluation",
  "Statement[2,0].LabelledEvaluation",
  "StringCreate",
  "StringPad",
  "TemplateString",
  "ToBigInt64",
  "ToBigUint64",
  "ToUint32",
  "TrimString",
  "WeakRefDeref"
]