This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
Feature/sonar generic data format #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 4, 2018 16:25
|
This creates output that looks like <?xml version="1.0" encoding="UTF-8"?>
<testExecutions version="1">
<file path="github.com/group/project/cmd/server/repository/repository_test.go">
<testCase name="TestGetPolicy_ValidPolicyName" duration="0">
<failure message="error">
<![CDATA[ repository_test.go:67: Expected to find policy schema for tcp-proxy
repository_test.go:71: Expected to find policy schema for tcp-proxy to match test data
repository_test.go:77: Expected to find policy schema for tcp-proxy
repository_test.go:81: Expected to find policy schema for tcp-proxy to match test data]]>
</failure>
</testCase>
</file>
<file path="github.com/group/project/cmd/server/repository/repository_test.go">
<testCase name="TestGetPolicy_InvalidPolicyName" duration="0" />
</file>
<file path="github.com/group/project/cmd/server/repository/repository_test.go">
<testCase name="TestGetPolicy_MissingArtifact" duration="0" />
</file>
</testExecutions> |
|
Thanks, I'll have a look soon-ish ... |
tebeka
suggested changes
May 19, 2018
| "strings" | ||
| ) | ||
|
|
||
| func fileFileForTest(suite *Suite, test *Test, pkg *build.Package, strip string) string { |
There was a problem hiding this comment.
Not sure I like the name fileFile prefix. Hard to understand what this does from the name, maybe a document?
| continue | ||
| } | ||
| contents = string(body) | ||
| testFileContents[testFilePath] = contents |
There was a problem hiding this comment.
I don't see the test file contents in the XML example, why do we need it?
| for _, testFile := range pkg.TestGoFiles { | ||
| testFilePath = filepath.Join(pkg.Dir, testFile) | ||
| if contents, ok = testFileContents[testFilePath]; !ok { | ||
| if body, err = ioutil.ReadFile(testFilePath); err != nil { |
There was a problem hiding this comment.
Don't ignore errors, unless there's a good reason
|
|
||
| func fileFileForTest(suite *Suite, test *Test, pkg *build.Package, strip string) string { | ||
| var ( | ||
| testFileContents = make(map[string]string) |
There was a problem hiding this comment.
We usually don't declare variables in advance, we use := instead
| @@ -104,6 +122,14 @@ func escapeForXML(in string) (string, error) { | |||
| return w.String(), nil | |||
| } | |||
|
|
|||
| func secondsToMilliseconds(seconds string) string { | |||
| t, err := time.ParseDuration(seconds + "s") | |||
There was a problem hiding this comment.
If you already know it's in seconds, why not just do the math directly?
| @@ -28,6 +29,7 @@ func init() { | |||
| flag.BoolVar(&args.bambooOut, "bamboo", false, | |||
| "xml compatible with Atlassian's Bamboo") | |||
| flag.BoolVar(&args.xunitnetOut, "xunitnet", false, "xml compatible with xunit.net") | |||
| flag.BoolVar(&args.sonarGTDOut, "sonar", false, "xml compatible with Sonar Generic Test Data") | |||
There was a problem hiding this comment.
Need to add a check in main that it's no colliding with other formatting flags.
|
Will take a look at these issue this week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to output in the Sonar Qube Generic Test Data format
https://docs.sonarqube.org/display/SONAR/Generic+Test+Data
I created a new template for the sonar output, and added a template function that allows you to get the test file a test exists in as required by the Generic Test Data format