Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for affects-mails outdated? #166

Open
MrChick opened this issue Sep 7, 2020 · 3 comments · May be fixed by #181
Open

Docs for affects-mails outdated? #166

MrChick opened this issue Sep 7, 2020 · 3 comments · May be fixed by #181

Comments

@MrChick
Copy link
Contributor

MrChick commented Sep 7, 2020

I tried using affects-mails according to the example in the docs today.
Didn't work as expected, got an error that my mailer didn't have a setFrom() method.
I checked, the Mailer associated with my ConfigureMails event is an Illuminate\Mail\Mailer, not a Swift_Mailer.

Is the example outdated or did I do something wrong?

(tenancy/affects-mails, Laravel 7)
@sniper7kills
Copy link
Contributor

Sorry for the delay in a reply; the team has been super busy.

Unfortunately, I'm not overly familiar w/ the affects-mails module and those who are have been busy.

It is very possible that the docs are in-correct and we are planning some major improvements to the module in the future.

@MrChick
Copy link
Contributor Author

MrChick commented Sep 18, 2020

Yeah no worries as I got it working. Was just asking because I stumbled over it. If someone can confirm that this is in fact the case I'd submit a quick update for the docs.

@sniper7kills
Copy link
Contributor

Oh, we'd love a PR if you would be willing to make one!

@ArlonAntonius ArlonAntonius linked a pull request Oct 30, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update documentation regarding affects-mails ArlonHelps/tenancy-docs
2 participants
@MrChick @sniper7kills