Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starship: update to 0.48.0 #6222

Merged
merged 4 commits into from
Jan 6, 2021
Merged

starship: update to 0.48.0 #6222

merged 4 commits into from
Jan 6, 2021

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jan 6, 2021

No description provided.

@kidonng
Copy link
Contributor Author

kidonng commented Jan 6, 2021

The build failed because of Starship's dependency: FillZpp/sys-info-rs#67

The fix is in the master branch. I wonder if I can add a patch to Cargo.toml here.

Using master branch. Not sure if this is appropriate.

@Grimler91
Copy link
Member

Using master branch. Not sure if this is appropriate.

Only annoyance would be if https://github.com/FillZpp/sys-info-rs is updated at some later point and breaks this build, it would then be a bit hard to pinpoint what caused the build to stop working. Hopefully that does not happen though

@Grimler91 Grimler91 merged commit d3f75eb into termux:master Jan 6, 2021
@kidonng kidonng deleted the patch-1 branch January 7, 2021 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants