fix: Allow Serverless maintenance windows #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardo-mng
changed the title
bryantbiggs
changed the title
bryantbiggs
approved these changes
Feb 15, 2024
bryantbiggs
merged commit c7d2e77
into
terraform-aws-modules:master
15 of 16 checks passed
antonbabenko
pushed a commit
that referenced
this pull request
Feb 15, 2024
### [9.0.1](v9.0.0...v9.0.1) (2024-02-15) ### Bug Fixes * Allow Serverless maintenance windows ([#427](#427)) ([c7d2e77](c7d2e77))
|
This PR is included in version 9.0.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AWS added support for configuring maintenance windows on Serverless V1 clusters in February 2023, as described in this announcement. The terraform-aws-rds-aurora module does not pass the preferred_maintenance_window argument down to the aws_rds_cluster resource if engine_mode is serverless.
This change was done in the context of this issue 213
Note:
Also tested to set the
preferred_backup_windowattribute on serverless, but it still gives the error:InvalidParameterCombination: You currently can't modify BackupWindow with Aurora ServerlessMotivation and Context
We cannot warn our customers of database maintenance that has downtime because of this limitation.
preferred_maintenance_windowon Serverless V1 clusters #395Breaking Changes
There are no breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)pre-commit run -aon my pull request