Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not create dynamic DNS suffix for service principals #442

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Do not create dynamic DNS suffix for service principals

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit b79c17a into terraform-aws-modules:master Mar 26, 2024
12 checks passed
@bryantbiggs bryantbiggs deleted the fix/principal-domain branch March 26, 2024 20:32
antonbabenko pushed a commit that referenced this pull request Mar 26, 2024
## [9.3.1](v9.3.0...v9.3.1) (2024-03-26)

### Bug Fixes

* Do not create dynamic DNS suffix for service principals ([#442](#442)) ([b79c17a](b79c17a))
@antonbabenko
Copy link
Member

This PR is included in version 9.3.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when creating role in China
2 participants