Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of outdated ReactJS lifecycle methods #648

Closed
dnlkoch opened this issue May 14, 2018 · 4 comments
Closed

Usage of outdated ReactJS lifecycle methods #648

dnlkoch opened this issue May 14, 2018 · 4 comments
Assignees
@dnlkoch
Labels
bug enhancement refactoring

Comments

@dnlkoch
Copy link
Member

dnlkoch commented May 14, 2018

Some ReactJS lifecycle methods (componentWillMount(), componentWillReceiveProps() and componentWillUpdate()) will be removed in version 17.

We should fix the usage of the deprecated methods listed above by either refactoring the classes by using the newly introduced static methods, e.g. getDerivedStateFromProps() (see here) or adjusting the deprecated methods with the UNSAFE_ prefix (see here).

I'm pro option one.

See failing build in #647 as well.
@ahennr
Copy link
Member

ahennr commented May 14, 2018

In this context we should double-check for our components if shouldComponentUpdate or React.PureComponent can be used more often. This would increase performance significantly (especially in IE11)

@dnlkoch
Copy link
Member Author

dnlkoch commented May 14, 2018

@ahennr Absolutely! Pure! Pure! Pure!

Could you please create an issue for this?

@ahennr
Copy link
Member

ahennr commented May 15, 2018

See #650

@dnlkoch dnlkoch self-assigned this May 23, 2018
@dnlkoch dnlkoch mentioned this issue May 23, 2018
Merged
@dnlkoch
Copy link
Member Author

dnlkoch commented May 24, 2018

Closed via #663.

@dnlkoch dnlkoch closed this as completed May 24, 2018
hblitza pushed a commit that referenced this issue Oct 19, 2022
@annarieger
Merge pull request #648 from terrestris/dependabot/npm_and_yarn/ol-6.…
b28dcf2 
…14.1

chore(deps-dev): bump ol from 6.13.0 to 6.14.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dnlkoch dnlkoch

Labels
bug enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dnlkoch @ahennr