refactor: remove reduntant photos

teslahunt · Jun 18, 2024 · 8ee2c20 · 8ee2c20
1 parent 8249c21
commit 8ee2c20
Show file tree

Hide file tree

Showing 26 changed files with 26 additions and 65 deletions.
diff --git a/images/3/3.jpeg b/images/3/3.jpeg
diff --git a/images/3/5.jpeg b/images/3/5.jpeg
diff --git a/images/S/1.jpeg b/images/S/1.jpeg
diff --git a/images/S/2.jpeg b/images/S/2.jpeg
diff --git a/images/S/3.jpeg b/images/S/3.jpeg
diff --git a/images/S/4.jpeg b/images/S/4.jpeg
diff --git a/images/S/5.jpeg b/images/S/5.jpeg
diff --git a/images/S/6.jpeg b/images/S/6.jpeg
diff --git a/images/S/7.jpeg b/images/S/7.jpeg
diff --git a/images/X/1.jpeg b/images/X/1.jpeg
diff --git a/images/X/2.jpeg b/images/X/2.jpeg
diff --git a/images/X/3.jpeg b/images/X/3.jpeg
diff --git a/images/X/4.jpeg b/images/X/4.jpeg
diff --git a/images/X/5.jpeg b/images/X/5.jpeg
diff --git a/images/X/6.jpeg b/images/X/6.jpeg
diff --git a/images/Y/1.jpeg b/images/Y/1.jpeg
diff --git a/images/Y/2.jpeg b/images/Y/2.jpeg
diff --git a/images/Y/3.jpeg b/images/Y/3.jpeg
diff --git a/images/Y/4.jpeg b/images/Y/4.jpeg
diff --git a/images/Y/5.jpeg b/images/Y/5.jpeg
diff --git a/src/index.js b/src/index.js
@@ -26,7 +26,7 @@ module.exports = vin => {
     bodyType: require('./body-type')[modelLetter](digit(vin, 5), year),
     model: require('./model')(modelLetter),
     motor: require('./motor')[modelLetter](digit(vin, 8), year),
-    photos: require('./photos')[modelLetter](year),
+    photos: require('./photos')[modelLetter],
     plantOfManufacture: require('./plan-of-manufacture')(digit(vin, 11)),
     restraintSystems: require('./restraint-systems')[modelLetter](digit(vin, 6), year),
     sequenceNumber: require('./sequence-number')(digit(vin, 12, 17)),

diff --git a/src/photos.js b/src/photos.js
@@ -2,61 +2,24 @@
 
 const BASE_URL = 'https://teslahunt.github.io/tesla-vin/images'
 
-const S = year => {
-  switch (year) {
-    case 2012:
-    case 2013:
-    case 2014:
-    case 2015:
-      return [`${BASE_URL}/S/1.jpeg`, `${BASE_URL}/S/2.jpeg`, `${BASE_URL}/S/3.jpeg`]
-    case 2016:
-    case 2017:
-    case 2018:
-    case 2019:
-    case 2020:
-      return [
-        `${BASE_URL}/S/1.jpeg`,
-        `${BASE_URL}/S/2.jpeg`,
-        `${BASE_URL}/S/3.jpeg`,
-        `${BASE_URL}/S/4.jpeg`
-      ]
-    default:
-      return [`${BASE_URL}/S/5.jpeg`, `${BASE_URL}/S/6.jpeg`, `${BASE_URL}/S/7.jpeg`]
-  }
-}
+const S = [`${BASE_URL}/S/1.jpeg`, `${BASE_URL}/S/2.jpeg`, `${BASE_URL}/S/3.jpeg`]
 
-const X = year => {
-  switch (year) {
-    case 2015:
-    case 2016:
-    case 2017:
-    case 2018:
-    case 2019:
-    case 2020:
-      return [`${BASE_URL}/X/1.jpeg`, `${BASE_URL}/X/2.jpeg`, `${BASE_URL}/X/3.jpeg`]
-    default:
-      return [`${BASE_URL}/X/4.jpeg`, `${BASE_URL}/X/5.jpeg`, `${BASE_URL}/X/6.jpeg`]
-  }
-}
+const X = [`${BASE_URL}/X/1.jpeg`, `${BASE_URL}/X/2.jpeg`, `${BASE_URL}/X/3.jpeg`]
 
-const Y = () => {
-  return [
-    `${BASE_URL}/Y/1.jpeg`,
-    `${BASE_URL}/Y/2.jpeg`,
-    `${BASE_URL}/Y/3.jpeg`,
-    `${BASE_URL}/Y/4.jpeg`,
-    `${BASE_URL}/Y/5.jpeg`
-  ]
-}
+const Y = [
+  `${BASE_URL}/Y/1.jpeg`,
+  `${BASE_URL}/Y/2.jpeg`,
+  `${BASE_URL}/Y/3.jpeg`,
+  `${BASE_URL}/Y/4.jpeg`,
+  `${BASE_URL}/Y/5.jpeg`
+]
 
-const _3 = () => {
-  return [
-    `${BASE_URL}/3/1.jpeg`,
-    `${BASE_URL}/3/2.jpeg`,
-    `${BASE_URL}/3/3.jpeg`,
-    `${BASE_URL}/3/4.jpeg`,
-    `${BASE_URL}/3/5.jpeg`
-  ]
-}
+const _3 = [
+  `${BASE_URL}/3/1.jpeg`,
+  `${BASE_URL}/3/2.jpeg`,
+  `${BASE_URL}/3/3.jpeg`,
+  `${BASE_URL}/3/4.jpeg`,
+  `${BASE_URL}/3/5.jpeg`
+]
 
 module.exports = { S, 3: _3, X, Y }
diff --git a/test/snapshots/model-s.js.md b/test/snapshots/model-s.js.md
@@ -113,7 +113,6 @@ Generated by [AVA](https://avajs.dev).
         'https://teslahunt.github.io/tesla-vin/images/S/1.jpeg',
         'https://teslahunt.github.io/tesla-vin/images/S/2.jpeg',
         'https://teslahunt.github.io/tesla-vin/images/S/3.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/4.jpeg',
       ],
       plantOfManufacture: 'Tesla Fremont, California (USA)',
       restraintSystems: 'Type 2 manual seatbelts (FR, SR*3) with front airbags, side inflatable restraints & active hood',
@@ -138,7 +137,6 @@ Generated by [AVA](https://avajs.dev).
         'https://teslahunt.github.io/tesla-vin/images/S/1.jpeg',
         'https://teslahunt.github.io/tesla-vin/images/S/2.jpeg',
         'https://teslahunt.github.io/tesla-vin/images/S/3.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/4.jpeg',
       ],
       plantOfManufacture: 'Tesla Fremont, California (USA)',
       restraintSystems: 'Type 2 manual seatbelts (FR, SR*3) with front airbags, side inflatable restraints',
@@ -160,9 +158,9 @@ Generated by [AVA](https://avajs.dev).
       model: 'Tesla Model S',
       motor: 'Triple Motor',
       photos: [
-        'https://teslahunt.github.io/tesla-vin/images/S/5.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/6.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/7.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/1.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/2.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/3.jpeg',
       ],
       plantOfManufacture: 'Tesla Fremont, California (USA)',
       restraintSystems: 'Type 2 Manual seat belts (FR, SR*3) with front Airbags, PODS, side Inflatable restraints, Knee Airbags',
@@ -184,9 +182,9 @@ Generated by [AVA](https://avajs.dev).
       model: 'Tesla Model S',
       motor: null,
       photos: [
-        'https://teslahunt.github.io/tesla-vin/images/S/5.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/6.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/S/7.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/1.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/2.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/S/3.jpeg',
       ],
       plantOfManufacture: null,
       restraintSystems: null,

diff --git a/test/snapshots/model-s.js.snap b/test/snapshots/model-s.js.snap
diff --git a/test/snapshots/model-x.js.md b/test/snapshots/model-x.js.md
@@ -110,9 +110,9 @@ Generated by [AVA](https://avajs.dev).
       model: 'Tesla Model X',
       motor: 'Triple Motor',
       photos: [
-        'https://teslahunt.github.io/tesla-vin/images/X/4.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/X/5.jpeg',
-        'https://teslahunt.github.io/tesla-vin/images/X/6.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/X/1.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/X/2.jpeg',
+        'https://teslahunt.github.io/tesla-vin/images/X/3.jpeg',
       ],
       plantOfManufacture: 'Tesla Fremont, California (USA)',
       restraintSystems: 'Type 2 Manual seatbelts with front Airbags, PODS, side Inflatable restraints',

diff --git a/test/snapshots/model-x.js.snap b/test/snapshots/model-x.js.snap