Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Project Root Directory #10

Open
william-e-schroeder opened this issue Aug 29, 2014 · 3 comments
Open

Question: Project Root Directory #10

william-e-schroeder opened this issue Aug 29, 2014 · 3 comments

Comments

@william-e-schroeder
Copy link

Why Not Create the Project Root Directory, since you are asking for it on the command line? Or, if the developer is creating the directory and moving in to the directory to run the generator, why not extract it from the path?

Just a question. I love the generator!

@william-e-schroeder
Copy link
Author

I actually have some code locally for this. If you are interested, I can get all set up and make a pull request.

@thardy
Copy link
Owner

thardy commented Oct 9, 2014

I guess the reason why I didn't think to extract the directory name from the path and use it for the app name is because I've had SPA apps where the SPA itself was part of a bigger whole, with multiple folders, etc. Maybe the app itself shouldn't be named according to its directory. Sometimes I have mine sit in a "client" folder that's a peer to an "api" folder, or something like that.

I appreciate your work on and with the generator. I just don't know if this would restrict its usage in the scenarios described above.

@thardy
Copy link
Owner

thardy commented Oct 10, 2014

After thinking about it, how about we still ask what they want to name the app, but we default it to the containing directory? I think that would be good. If you want to submit a pull request for that, I'd be glad to accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants