Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coffescript included even if responded 'No' #24

Open
everson opened this issue Jun 10, 2015 · 2 comments
Open

Coffescript included even if responded 'No' #24

everson opened this issue Jun 10, 2015 · 2 comments

Comments

@everson
Copy link
Contributor

everson commented Jun 10, 2015

I have installed latest version(0.2.1), when asked if I want to use Coffeescript, I responded no. However, the generated Gruntfile, karma-unit* and package.json still contains references to Coffeescript.

@thardy
Copy link
Owner

thardy commented Jun 12, 2015

There are still some grunt-contrib references in the devDependencies of package.json, but these shouldn't impact your app in any way. Nothing gets added to your app payload if that's what you're worried about.

I'm not sure how much value it would add to prune these out of the generator because it would add some extra complexity to what is already a pretty difficult to read _Gruntfile.js - the file that transforms into your Gruntfile.js.

If you want to submit a pull request, I'd be happy to look at it.

@everson
Copy link
Contributor Author

everson commented Jun 12, 2015

Yes, it is harmless to the app. But value to the user is in the fact that people new to Grunt are already overwhelmed with how complex the Gruntfile looks, so any chance to make it smaller, would be good. From the template point of view, I understand your concern.

If I have the time, I will create a PR. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants