Postpone irrelevant/incoherent instance selection using the same logic as overlap #7373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracted from a failure in the stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the1lab/1lab#407 and another similar bug.
This is still in the spirit of using
overlapOkas a heuristic for "we now have a list of 'good enough' candidates that would all be equally suitable (save for additional constraints that do not mention the goal type), so we can proceed to thin down the list by applying overlap rules or picking an arbitrary candidate". The heuristic is not perfect but this can be remedied with--backtracking-instance-search; for example removing theINCOHERENTpragma fromIssue7364.agdastill fails as it always has.Note that the
Number-Natnonsense in the test cases is required to trigger the bugs, as these are scheduling-sensitive issues.